[clang] [clang][dataflow] Remove RecordValue.getLog() usage in HTMLLogger (PR #65645)

2023-09-11 Thread via cfe-commits
martinboehme wrote: Can you add a screenshot of what this looks like after the change? https://github.com/llvm/llvm-project/pull/65645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

2023-09-11 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:752 auto Action = [File = File.str(), Sel, TweakID = TweakID.str(), - CB = std::move(CB), + CB = std::move(CB), ActionKinds, this](Expected I

[clang] [clang][bpf] Fix invalid RUN lines in stack protector warning test (PR #65251)

2023-09-11 Thread David Spickett via cfe-commits
DavidSpickett wrote: @eddyz87 ping! https://github.com/llvm/llvm-project/pull/65251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 26f9e49 - [clangd] Delete deprecated enumerateTweaks endpoint

2023-09-11 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2023-09-11T09:09:12+02:00 New Revision: 26f9e49d9c92255f7e6e0420eb1d549a023bbcb5 URL: https://github.com/llvm/llvm-project/commit/26f9e49d9c92255f7e6e0420eb1d549a023bbcb5 DIFF: https://github.com/llvm/llvm-project/commit/26f9e49d9c92255f7e6e0420eb1d549a023bbcb5.dif

[clang] b908123 - [clang-format][NFC] Minor cleanup of token annotator and test cases

2023-09-11 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-09-11T00:18:57-07:00 New Revision: b908123c3c1934c03b5183318a47d321fb796260 URL: https://github.com/llvm/llvm-project/commit/b908123c3c1934c03b5183318a47d321fb796260 DIFF: https://github.com/llvm/llvm-project/commit/b908123c3c1934c03b5183318a47d321fb796260.diff LOG:

[PATCH] D64087: [clang] Correct source locations for instantiations of out-of-line defaulted special member functions. (PR25683)

2023-09-11 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM (assuming rebase goes well) @tahonermann ping folks in the future, and apologies for taking... 4 years! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[clang] 00add6e - [Driver] Remove duplicate -e on DragonFly (#65867)

2023-09-11 Thread via cfe-commits
Author: Brad Smith Date: 2023-09-11T03:21:44-04:00 New Revision: 00add6ed24a0f625f28c1cc27bb8579001d5fa7a URL: https://github.com/llvm/llvm-project/commit/00add6ed24a0f625f28c1cc27bb8579001d5fa7a DIFF: https://github.com/llvm/llvm-project/commit/00add6ed24a0f625f28c1cc27bb8579001d5fa7a.diff LO

[clang] [Driver] Remove duplicate -e on DragonFly (PR #65867)

2023-09-11 Thread Brad Smith via cfe-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/65867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

2023-09-11 Thread via cfe-commits
https://github.com/martinboehme updated https://github.com/llvm/llvm-project/pull/65319: >From 28ac8d2b627915e84ec4e7a14e435316aa895587 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Mon, 11 Sep 2023 07:21:56 + Subject: [PATCH] [clang][dataflow] Merge `RecordValue`s with different loc

[clang] 90db419 - [clang][AArch64] Add --print-supported-extensions support (#65466)

2023-09-11 Thread via cfe-commits
Author: David Spickett Date: 2023-09-11T08:25:02+01:00 New Revision: 90db4193f82937bff68c8f8a1481320f245f04ff URL: https://github.com/llvm/llvm-project/commit/90db4193f82937bff68c8f8a1481320f245f04ff DIFF: https://github.com/llvm/llvm-project/commit/90db4193f82937bff68c8f8a1481320f245f04ff.diff

[clang] [clang][AArch64] Add --print-supported-extensions support (PR #65466)

2023-09-11 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/65466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

2023-09-11 Thread via cfe-commits
@@ -121,18 +121,18 @@ static Value *mergeDistinctValues(QualType Type, Value &Val1, Value *MergedVal = nullptr; if (auto *RecordVal1 = dyn_cast(&Val1)) { -[[maybe_unused]] auto *RecordVal2 = cast(&Val2); - -// Values to be merged are always associated with the sam

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Now that prvalue expressions map directly to values (see https://reviews.llvm.org/D158977), it's no longer guaranteed that `RecordValue`s associated with the same expression will always have the same storage location. In other words, D158977 i

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

2023-09-11 Thread via cfe-commits
martinboehme wrote: (Sorry, rebased to head inadvertently -- still getting used to the new process. Will use fixup commits in the future.) https://github.com/llvm/llvm-project/pull/65319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

2023-09-11 Thread via cfe-commits
https://github.com/cor3ntin unassigned https://github.com/llvm/llvm-project/pull/65918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

2023-09-11 Thread via cfe-commits
cor3ntin wrote: @Fznamznon https://github.com/llvm/llvm-project/pull/65918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2d670fa - [clang][AArch64] Fix supported extensions test case

2023-09-11 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2023-09-11T07:50:52Z New Revision: 2d670fab4c099a3c8e7c257a100f5a34df598ac4 URL: https://github.com/llvm/llvm-project/commit/2d670fab4c099a3c8e7c257a100f5a34df598ac4 DIFF: https://github.com/llvm/llvm-project/commit/2d670fab4c099a3c8e7c257a100f5a34df598ac4.diff LOG

[clang] [clang][dataflow][NFC] Delete unused function. (PR #65602)

2023-09-11 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/65602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2757085 - [clang][dataflow][NFC] Delete unused function. (#65602)

2023-09-11 Thread via cfe-commits
Author: martinboehme Date: 2023-09-11T09:54:50+02:00 New Revision: 2757085e90823431cbaf96e5cc93cf7a73b8bdbd URL: https://github.com/llvm/llvm-project/commit/2757085e90823431cbaf96e5cc93cf7a73b8bdbd DIFF: https://github.com/llvm/llvm-project/commit/2757085e90823431cbaf96e5cc93cf7a73b8bdbd.diff

[clang-tools-extra] 64366d4 - [clangd] Rollforward include-cleaner library usage in symbol collector.

2023-09-11 Thread Viktoriia Bakalova via cfe-commits
Author: Viktoriia Bakalova Date: 2023-09-11T07:57:35Z New Revision: 64366d4935d3c56ce5906a321edb2e91d4f886bc URL: https://github.com/llvm/llvm-project/commit/64366d4935d3c56ce5906a321edb2e91d4f886bc DIFF: https://github.com/llvm/llvm-project/commit/64366d4935d3c56ce5906a321edb2e91d4f886bc.diff

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

2023-09-11 Thread Viktoriia Bakalova via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG64366d4935d3: [clangd] Rollforward include-cleaner library usage in symbol collector. (authored by VitaNuo). Changed prior to commit: https://reviews.llvm.org/D156659?vs=556135&id=556396#toc Repository

[clang] Extension: allow recursive macros (PR #65851)

2023-09-11 Thread via cfe-commits
https://github.com/kelbon updated https://github.com/llvm/llvm-project/pull/65851: >From 2f807b312baef8c6038c2452b84232acb6d6d2c2 Mon Sep 17 00:00:00 2001 From: Kelbon Nik Date: Sat, 9 Sep 2023 17:51:15 +0400 Subject: [PATCH 1/3] add define2 pp directive --- clang/include/clang/Basic/TokenKin

[clang-tools-extra] 94b1435 - [clangd] allow extracting to variable for lambda expressions

2023-09-11 Thread Nathan Ridge via cfe-commits
Author: Julian Schmidt Date: 2023-09-11T04:03:38-04:00 New Revision: 94b14355e2ef819fc56916e5d154be4f3aefda1c URL: https://github.com/llvm/llvm-project/commit/94b14355e2ef819fc56916e5d154be4f3aefda1c DIFF: https://github.com/llvm/llvm-project/commit/94b14355e2ef819fc56916e5d154be4f3aefda1c.diff

[PATCH] D141757: [clangd] allow extracting to variable for lambda expressions

2023-09-11 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94b14355e2ef: [clangd] allow extracting to variable for lambda exp

[clang-tools-extra] [clangd] Forward --target to system include extraction (PR #65824)

2023-09-11 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. https://github.com/llvm/llvm-project/pull/65824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

2023-09-11 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 556399. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152504/new/ https://reviews.llvm.org/D152504 Files: clang/include/clang/Analysis/Analyses/ThreadSafetyCommon.h clang/lib/Analysis/ThreadSafety.cpp clang/lib/Analysis/ThreadSafetyCommon.cpp

[clang-tools-extra] 4af340a - [clangd] Forward --target to system include extraction (#65824)

2023-09-11 Thread via cfe-commits
Author: Matthew Mirvish Date: 2023-09-11T04:11:37-04:00 New Revision: 4af340a6afb971c2f79d19b3575c7831f6949503 URL: https://github.com/llvm/llvm-project/commit/4af340a6afb971c2f79d19b3575c7831f6949503 DIFF: https://github.com/llvm/llvm-project/commit/4af340a6afb971c2f79d19b3575c7831f6949503.dif

[clang-tools-extra] [clangd] Forward --target to system include extraction (PR #65824)

2023-09-11 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/65824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

2023-09-11 Thread Nathan Gauër via Phabricator via cfe-commits
Keenuts added a comment. > Either I could push the patch for you (adding you as an author) or preferably > you could gain commit access yourself for this and future patches. Thanks, got commit access. Running tests again and merging this. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

2023-09-11 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. This can be closed, as the change has been made in https://github.com/llvm/llvm-project/pull/65824 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138546/new/ https://reviews.llvm.org/D138546 ___ cfe-commits mailing lis

[clang] [clang][dataflow] Remove unused function: transferBlock() (PR #65932)

2023-09-11 Thread Kinuko Yasuda via cfe-commits
https://github.com/kinu created https://github.com/llvm/llvm-project/pull/65932: No one seems to be using transferBlock() in TypeErasedDataflowAnalysis, it is likely a remnant of old code >From dc808e4edccdd8d405660729713dd169c87daf71 Mon Sep 17 00:00:00 2001 From: Kinuko Yasuda Date: Fri, 8

[clang] [clang][dataflow] Remove unused function: transferBlock() (PR #65932)

2023-09-11 Thread Kinuko Yasuda via cfe-commits
https://github.com/kinu review_requested https://github.com/llvm/llvm-project/pull/65932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Remove unused function: transferBlock() (PR #65932)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Remove unused function: transferBlock() (PR #65932)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Remove unused function: transferBlock() (PR #65932)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Remove unused function: transferBlock() (PR #65932)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes No one seems to be using transferBlock() in TypeErasedDataflowAnalysis, it is likely a remnant of old code -- Full diff: https://github.com/llvm/llvm-project/pull/65932.diff 2 Files Affected: - (modified) clang/include/clang/Analysis/FlowS

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

2023-09-11 Thread Nathan Gauër via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG53b6a169e453: [SPIR-V] Add SPIR-V logical triple. (authored by Keenuts). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] 53b6a16 - [SPIR-V] Add SPIR-V logical triple.

2023-09-11 Thread Nathan Gauër via cfe-commits
Author: Nathan Gauër Date: 2023-09-11T10:15:24+02:00 New Revision: 53b6a169e453a2a91d3713ca16fa089853c670a8 URL: https://github.com/llvm/llvm-project/commit/53b6a169e453a2a91d3713ca16fa089853c670a8 DIFF: https://github.com/llvm/llvm-project/commit/53b6a169e453a2a91d3713ca16fa089853c670a8.diff

[clang] [clang-format] Fix a bug in annotating '&&' enclosed in '<' and '>' (PR #65933)

2023-09-11 Thread Owen Pan via cfe-commits
https://github.com/owenca review_requested https://github.com/llvm/llvm-project/pull/65933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating '&&' enclosed in '<' and '>' (PR #65933)

2023-09-11 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/65933: Fixes #65877. >From 86b83692a9f13b8c608190f6abc3111719583730 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 11 Sep 2023 01:00:24 -0700 Subject: [PATCH] [clang-format] Fix a bug in annotating '&&' enclosed in

[clang] [clang-format] Fix a bug in annotating '&&' enclosed in '<' and '>' (PR #65933)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating '&&' enclosed in '<' and '>' (PR #65933)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating '&&' enclosed in '<' and '>' (PR #65933)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Fixes #65877. -- Full diff: https://github.com/llvm/llvm-project/pull/65933.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+5-2) - (modified) clang/unittests/Format/TokenAnnotatorTest.cpp (+6) diff --git a/clang

[clang] [clang-format] Fix a bug in annotating '&&' enclosed in '<' and '>' (PR #65933)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Changes Fixes #65877. -- Full diff: https://github.com/llvm/llvm-project/pull/65933.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+5-2) - (modified) clang/unittests/Format/TokenAnnotatorTest.cpp (+6) diff --git

[PATCH] D150647: [WIP][analyzer] Fix EnumCastOutOfRangeChecker C++17 handling

2023-09-11 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 abandoned this revision. gamesh411 added a comment. This is no longer relevant, as the fix already went in (D153954 ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150647/new/ https://reviews.llvm.org/D

[clang] [clang-format] Fix a bug in annotating `&&` enclosed in `<` and `>` (PR #65933)

2023-09-11 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158156: [analyzer] Add C++ array delete checker

2023-09-11 Thread Discookie via Phabricator via cfe-commits
Discookie updated this revision to Diff 556402. Discookie marked 8 inline comments as done. Discookie added a comment. Added a test for taking last upcast only for the note tag. For now the visitor matches all explicit casts, because there are too many edge cases to count for now wrt. explicit u

[PATCH] D158156: [analyzer] Add C++ array delete checker

2023-09-11 Thread Discookie via Phabricator via cfe-commits
Discookie added inline comments. Comment at: clang/docs/analyzer/checkers.rst:1793-1803 +.. code-block:: cpp + + Base *create() { + Base *x = new Derived[10]; // note: conversion from derived to base + // happened here + return x; + } --

[clang-tools-extra] 13e5faf - [clangd] Fix buildbot breakages from stemming from 64366d4935d3c56ce5906a321edb2e91d4f886bc

2023-09-11 Thread Viktoriia Bakalova via cfe-commits
Author: Viktoriia Bakalova Date: 2023-09-11T08:30:06Z New Revision: 13e5fafb5548caf52fc067ec443604d20bf60684 URL: https://github.com/llvm/llvm-project/commit/13e5fafb5548caf52fc067ec443604d20bf60684 DIFF: https://github.com/llvm/llvm-project/commit/13e5fafb5548caf52fc067ec443604d20bf60684.diff

[clang] [NFC][Clang] overrideFunctionFeaturesWithTargetFeatures (PR #65938)

2023-09-11 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/65938: Addressing remarks after merge of D159257 * Add comment * Remove irrelevant CHECKs from test * Simplify function * Use llvm::sort before setting target-features as it is done in CodeGenModeule From bd46d855b

[clang] [NFC][Clang] overrideFunctionFeaturesWithTargetFeatures (PR #65938)

2023-09-11 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez review_requested https://github.com/llvm/llvm-project/pull/65938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] overrideFunctionFeaturesWithTargetFeatures (PR #65938)

2023-09-11 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez labeled https://github.com/llvm/llvm-project/pull/65938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] overrideFunctionFeaturesWithTargetFeatures (PR #65938)

2023-09-11 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez review_requested https://github.com/llvm/llvm-project/pull/65938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] overrideFunctionFeaturesWithTargetFeatures (PR #65938)

2023-09-11 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez labeled https://github.com/llvm/llvm-project/pull/65938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Address reviews about overrideFunctionFeaturesWithTargetFeatures (PR #65938)

2023-09-11 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez edited https://github.com/llvm/llvm-project/pull/65938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Address reviews about overrideFunctionFeaturesWithTargetFeatures (PR #65938)

2023-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Addressing remarks after merge of D159257 * Add comment * Remove irrelevant CHECKs from test * Simplify function * Use llvm::sort before setting target-features as it is done in CodeGenModeule -- Full diff: https://github.com/llvm/llvm-project

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

2023-09-11 Thread Thomas Preud'homme via cfe-commits
@@ -34,29 +35,22 @@ } -def get_line2func_list(args, clang_args): +def get_line2func_list(clang_cmd: Command): ret = collections.defaultdict(list) # Use clang's JSON AST dump to get the mangled name -json_dump_args = [args.clang] + clang_args + ["-fsyntax-only",

[PATCH] D159206: [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

2023-09-11 Thread Juan Manuel Martinez Caamaño via Phabricator via cfe-commits
jmmartinez added a comment. @yaxunl I've addressed your remarks on a GitHub PR: https://github.com/llvm/llvm-project/pull/65938 Thanks for the remarks! It made me realize that I could simplify the code a lot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] [clang][dataflow] Remove RecordValue.getLog() usage in HTMLLogger (PR #65645)

2023-09-11 Thread Kinuko Yasuda via cfe-commits
kinu wrote: Here's the screenshot for a simple code snippet ![Btp9XprWFz4w2yQ (1)](https://github.com/llvm/llvm-project/assets/860295/bfd29ab5-ac44-418b-8649-365cfacae2c9) 'Without the patch' image is almost identical You can see some more screenshots here: https://docs.google.com/document/d/1g

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

2023-09-11 Thread Yurong via Phabricator via cfe-commits
yronglin added a comment. ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153701/new/ https://reviews.llvm.org/D153701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-11 Thread via cfe-commits
https://github.com/DonatNagyE requested changes to this pull request. https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-11 Thread via cfe-commits
@@ -1333,7 +1333,15 @@ void StmtProfiler::VisitPredefinedExpr(const PredefinedExpr *S) { void StmtProfiler::VisitIntegerLiteral(const IntegerLiteral *S) { VisitExpr(S); S->getValue().Profile(ID); - ID.AddInteger(S->getType()->castAs()->getKind()); + + int FoldingSetID =

[clang] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-11 Thread via cfe-commits
https://github.com/DonatNagyE edited https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-11 Thread via cfe-commits
@@ -0,0 +1,10 @@ +// RUN: %check_clang_tidy %s bugprone-inc-dec-in-conditions %t + +#define foo(x) \ + ({ \ +_BitInt(5) y = x; \

[clang] Extension: allow recursive macros (PR #65851)

2023-09-11 Thread via cfe-commits
https://github.com/kelbon updated https://github.com/llvm/llvm-project/pull/65851: >From 2f807b312baef8c6038c2452b84232acb6d6d2c2 Mon Sep 17 00:00:00 2001 From: Kelbon Nik Date: Sat, 9 Sep 2023 17:51:15 +0400 Subject: [PATCH 1/5] add define2 pp directive --- clang/include/clang/Basic/TokenKin

[clang] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-11 Thread via cfe-commits
https://github.com/DonatNagyE edited https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-11 Thread via cfe-commits
https://github.com/DonatNagyE edited https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148654: Modify BoundsSan to improve debuggability

2023-09-11 Thread Oskar Wirga via Phabricator via cfe-commits
oskarwirga added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:47 #include "llvm/Transforms/Utils/SanitizerStats.h" #include vitalybuka wrote: > this file and BoundsChecking.cpp belong to different patches Just to be clear on terms here, these ch

[clang] 87461d6 - [clang][Interp] Implement __builtin_offsetof

2023-09-11 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-09-11T12:03:47+02:00 New Revision: 87461d669684668f02362f77807f313187667329 URL: https://github.com/llvm/llvm-project/commit/87461d669684668f02362f77807f313187667329 DIFF: https://github.com/llvm/llvm-project/commit/87461d669684668f02362f77807f313187667329.diff LO

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

2023-09-11 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG87461d669684: [clang][Interp] Implement __builtin_offsetof (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D156400?vs=556

[clang] 4b5fe9c - [clang][Interp] Check floating results for NaNs

2023-09-11 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-09-11T12:21:36+02:00 New Revision: 4b5fe9c42d94905a6f940e50958c56ed2d47a2cc URL: https://github.com/llvm/llvm-project/commit/4b5fe9c42d94905a6f940e50958c56ed2d47a2cc DIFF: https://github.com/llvm/llvm-project/commit/4b5fe9c42d94905a6f940e50958c56ed2d47a2cc.diff LO

[PATCH] D156506: [clang][Interp] Check floating results for NaNs

2023-09-11 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b5fe9c42d94: [clang][Interp] Check floating results for NaNs (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D156506?vs=

[clang] Extension: allow recursive macros (PR #65851)

2023-09-11 Thread via cfe-commits
https://github.com/kelbon updated https://github.com/llvm/llvm-project/pull/65851: >From 2f807b312baef8c6038c2452b84232acb6d6d2c2 Mon Sep 17 00:00:00 2001 From: Kelbon Nik Date: Sat, 9 Sep 2023 17:51:15 +0400 Subject: [PATCH 1/6] add define2 pp directive --- clang/include/clang/Basic/TokenKin

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

2023-09-11 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154581/new/ https://reviews.llvm.org/D154581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Avoid checking magic numbers if _BitInt (PR #65888)

2023-09-11 Thread via cfe-commits
DonatNagyE wrote: LGTM as a temporary measure. Perhaps add a TODO note which asks for a more through solution; but you can also merge this as it is now. https://github.com/llvm/llvm-project/pull/65888 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [NFC][Clang][RISCV] Fix index typos of riscv-v-spec doc in riscv_vector.td (PR #65944)

2023-09-11 Thread Ying Chen via cfe-commits
https://github.com/punkyc created https://github.com/llvm/llvm-project/pull/65944: Fix index typos, s.t. indexes in comments be same with riscv-v-spec doc. >From 01a0763aa8c624834c5f6a98df22e75f3f5ae96b Mon Sep 17 00:00:00 2001 From: Ying Chen Date: Mon, 11 Sep 2023 18:36:22 +0800 Subject: [P

[clang] [NFC][Clang][RISCV] Fix index typos of riscv-v-spec doc in riscv_vector.td (PR #65944)

2023-09-11 Thread Ying Chen via cfe-commits
https://github.com/punkyc review_requested https://github.com/llvm/llvm-project/pull/65944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][RISCV] Fix index typos of riscv-v-spec doc in riscv_vector.td (PR #65944)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][RISCV] Fix index typos of riscv-v-spec doc in riscv_vector.td (PR #65944)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][RISCV] Fix index typos of riscv-v-spec doc in riscv_vector.td (PR #65944)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Remove Code Object V2 (PR #65715)

2023-09-11 Thread Pierre van Houtryve via cfe-commits
Pierre-vh wrote: > Is this dropping read support? Yes, it's dropping everything https://github.com/llvm/llvm-project/pull/65715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Remove Code Object V2 (PR #65715)

2023-09-11 Thread Pierre van Houtryve via cfe-commits
https://github.com/Pierre-vh review_requested https://github.com/llvm/llvm-project/pull/65715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D140538: [Clang][CodeGen] Use poison instead of undef for dummy values in CGExpr [NFC]

2023-09-11 Thread Manuel Brito via Phabricator via cfe-commits
ManuelJBrito updated this revision to Diff 556416. ManuelJBrito removed a reviewer: libc++abi. ManuelJBrito added a comment. This revision is now accepted and ready to land. Remove changes to demangle test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] [include-mapping] Python fixes (PR #65401)

2023-09-11 Thread Haojian Wu via cfe-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/65401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [include-mapping] Python fixes (PR #65401)

2023-09-11 Thread Haojian Wu via cfe-commits
https://github.com/hokein commented: thanks, the change looks reasonable. https://github.com/llvm/llvm-project/pull/65401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [include-mapping] Python fixes (PR #65401)

2023-09-11 Thread Haojian Wu via cfe-commits
hokein wrote: can you also update this file to use `python3`? https://github.com/llvm/llvm-project/pull/65401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [analyzer] Do not use APInt methods on _BitInt() Types (PR #65887)

2023-09-11 Thread via cfe-commits
https://github.com/DonatNagyE edited https://github.com/llvm/llvm-project/pull/65887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Do not use APInt methods on _BitInt() Types (PR #65887)

2023-09-11 Thread via cfe-commits
@@ -598,6 +598,12 @@ SVal SValBuilder::evalIntegralCast(ProgramStateRef state, SVal val, APSIntType ToType(getContext().getTypeSize(castTy), castTy->isUnsignedIntegerType()); llvm::APSInt ToTypeMax = ToType.getMaxValue(); + // With the introduction of

[clang] [analyzer] Do not use APInt methods on _BitInt() Types (PR #65887)

2023-09-11 Thread via cfe-commits
https://github.com/DonatNagyE requested changes to this pull request. I agree that it would be useful to systematically check the use of the `APSInt -> uint64_t` conversions, because it's likely that there are other ones that can lead to crashes. https://github.com/llvm/llvm-project/pull/65887

[clang] [analyzer] Do not use APInt methods on _BitInt() Types (PR #65887)

2023-09-11 Thread via cfe-commits
@@ -0,0 +1,11 @@ + // RUN: %clang_analyze_cc1 -analyzer-checker=core \ + // RUN: -analyzer-checker=debug.ExprInspection \ + // RUN: -verify %s + +// Don't crash when using _BitInt() +// expected-no-diagnostics +_BitInt(256) a; +_BitInt(129) b; +void c() { + b = a; +}

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-11 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   6   7   >