[clang] Update GoogleTest to v1.14.0 (PR #65823)

2023-09-09 Thread Petr Hosek via cfe-commits
@@ -77,18 +77,18 @@ endif () target_include_directories(llvm_gtest PUBLIC $ $ - $ - $ + $ + $ petrhosek wrote: This is undoing a change made recently in https://github.com/llvm/llvm-project/commit/91b3ca39667b6341a8c

[clang] Update GoogleTest to v1.14.0 (PR #65823)

2023-09-09 Thread Petr Hosek via cfe-commits
@@ -77,18 +77,18 @@ endif () target_include_directories(llvm_gtest PUBLIC $ $ - $ - $ + $ + $ PRIVATE googletest googlemock ) add_subdirectory(UnitTestMain) if (LLVM_INSTALL_GTEST) install(TARGETS llvm_gtest llvm_gtest_m

[clang] Update GoogleTest to v1.14.0 (PR #65823)

2023-09-09 Thread Petr Hosek via cfe-commits
@@ -1,22 +1,21 @@ LLVM notes -- -This directory contains Google Test 1.10.0, with all elements removed except for -the actual source code, to minimize the addition to the LLVM distribution. +This directory contains Google Test 1.14.0, +revision `f8d7d77c06936315286eb5

[clang] [Driver] Also use --no-as-needed when linking libatomic on Linux/Sparc (PR #65827)

2023-09-09 Thread Fangrui Song via cfe-commits
@@ -618,6 +618,7 @@ void tools::gnutools::Linker::ConstructJob(Compilation &C, const JobAction &JA, CmdArgs.push_back("--push-state"); MaskRay wrote: Is Issue #41880 and D118021 still relevant? If not, the description needs to describe why the change i

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

2023-09-09 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

2023-09-09 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/65861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

2023-09-09 Thread Owen Pan via cfe-commits
@@ -1599,6 +1600,15 @@ unsigned ContinuationIndenter::moveStateToNextToken(LineState &State, State.Column += Current.ColumnWidth; State.NextToken = State.NextToken->Next; + // Verilog case labels are are on the same unwrapped lines as the statements + // that follow. T

[clang] [Clang][OpenMP] Emit unroll directive w/o captured stmt (PR #65862)

2023-09-09 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/65862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 52b4bec - [Clang][OpenMP] Emit unroll directive w/o captured stmt (#65862)

2023-09-09 Thread via cfe-commits
Author: Shilei Tian Date: 2023-09-09T18:51:58-04:00 New Revision: 52b4bec9395703d4757c065649fa43a93e19b7b2 URL: https://github.com/llvm/llvm-project/commit/52b4bec9395703d4757c065649fa43a93e19b7b2 DIFF: https://github.com/llvm/llvm-project/commit/52b4bec9395703d4757c065649fa43a93e19b7b2.diff L

[clang] [Clang][OpenMP] Emit unroll directive w/o captured stmt (PR #65862)

2023-09-09 Thread Shilei Tian via cfe-commits
https://github.com/shiltian closed https://github.com/llvm/llvm-project/pull/65862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Remove duplicate -e on DragonFly (PR #65867)

2023-09-09 Thread Brad Smith via cfe-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/65867: 62281227bf7ca48d0101e4c9d11f71600208c7df was commited, but I noticed one spot was missed in the DragonFly Driver. >From 112b5c951afc9144271d77380c1c26cc5a6e0e24 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Sa

[clang] [Driver] Remove duplicate -e on DragonFly (PR #65867)

2023-09-09 Thread Brad Smith via cfe-commits
https://github.com/brad0 review_requested https://github.com/llvm/llvm-project/pull/65867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Remove duplicate -e on DragonFly (PR #65867)

2023-09-09 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Remove duplicate -e on DragonFly (PR #65867)

2023-09-09 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Remove duplicate -e on DragonFly (PR #65867)

2023-09-09 Thread Brad Smith via cfe-commits
https://github.com/brad0 review_requested https://github.com/llvm/llvm-project/pull/65867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Remove duplicate -e on DragonFly (PR #65867)

2023-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes 62281227bf7ca48d0101e4c9d11f71600208c7df was commited, but I noticed one spot was missed in the DragonFly Driver. -- Full diff: https://github.com/llvm/llvm-project/pull/65867.diff 1 Files Affected: - (modified) clang/lib/Driver/ToolChains/D

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

2023-09-09 Thread via cfe-commits
https://github.com/sstwcw updated https://github.com/llvm/llvm-project/pull/65861: >From c1982d451e6ca8e3cf1269677aabe984000f6801 Mon Sep 17 00:00:00 2001 From: sstwcw Date: Sat, 9 Sep 2023 20:35:33 + Subject: [PATCH 1/2] [clang-format] Properly indent lines inside Verilog case structure

[clang] [Driver] Replace usage of -Bshareable linker flag with -shared (PR #65842)

2023-09-09 Thread Brad Smith via cfe-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/65842: >From 80c558e007dc7424b31402909700bb558e3a8704 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Sat, 9 Sep 2023 03:43:57 -0400 Subject: [PATCH] [Driver] Replace usage of -Bshareable linker flag with -shared The t

[clang] [Fuchsia] Disable libcxx timezone database (PR #65870)

2023-09-09 Thread Alex Brachet via cfe-commits
https://github.com/abrachet created https://github.com/llvm/llvm-project/pull/65870: tzdb is currently broken when cross compiling from non Linux to Linux. Lets just disable it totally in our toolchain for now. We should remove this when #65859 lands. >From b75d844d09076f2a7f170454782662cfebd

[clang] [Fuchsia] Disable libcxx timezone database (PR #65870)

2023-09-09 Thread Alex Brachet via cfe-commits
https://github.com/abrachet review_requested https://github.com/llvm/llvm-project/pull/65870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Disable libcxx timezone database (PR #65870)

2023-09-09 Thread Alex Brachet via cfe-commits
https://github.com/abrachet review_requested https://github.com/llvm/llvm-project/pull/65870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Disable libcxx timezone database (PR #65870)

2023-09-09 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Disable libcxx timezone database (PR #65870)

2023-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes tzdb is currently broken when cross compiling from non Linux to Linux. Lets just disable it totally in our toolchain for now. We should remove this when #65859 lands. -- Full diff: https://github.com/llvm/llvm-project/pull/65870.diff 1 Files

[PATCH] D159414: [Driver] Fixes for header / library paths on Haiku

2023-09-09 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added inline comments. Comment at: clang/test/Driver/haiku.cpp:2 +// Check the C++ header path (libstdc++) +// RUN: %clang++ --target=x86_64-unknown-haiku -### %s 2>&1 \ +// RUN: --sysroot=%S/Inputs/haiku_x86_64_tree \ This test is broken for people wh

[PATCH] D159414: [Driver] Fixes for header / library paths on Haiku

2023-09-09 Thread Brad Smith via Phabricator via cfe-commits
brad added inline comments. Comment at: clang/test/Driver/haiku.cpp:2 +// Check the C++ header path (libstdc++) +// RUN: %clang++ --target=x86_64-unknown-haiku -### %s 2>&1 \ +// RUN: --sysroot=%S/Inputs/haiku_x86_64_tree \ abrachet wrote: > This test is broken

[clang] [Haiku] Don't assume clang was build with libstdc++ as default (PR #65871)

2023-09-09 Thread Alex Brachet via cfe-commits
https://github.com/abrachet review_requested https://github.com/llvm/llvm-project/pull/65871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Haiku] Don't assume clang was build with libstdc++ as default (PR #65871)

2023-09-09 Thread Alex Brachet via cfe-commits
https://github.com/abrachet created https://github.com/llvm/llvm-project/pull/65871: This test fails with `CLANG_DEFAULT_CXX_STDLIB=libc++` >From 01607fcb02df7e9f91f39c01938c8b67247703bd Mon Sep 17 00:00:00 2001 From: Alex Brachet Date: Sat, 9 Sep 2023 23:27:33 -0400 Subject: [PATCH] [Haiku] D

[clang] [Haiku] Don't assume clang was build with libstdc++ as default (PR #65871)

2023-09-09 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Haiku] Don't assume clang was build with libstdc++ as default (PR #65871)

2023-09-09 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159414: [Driver] Fixes for header / library paths on Haiku

2023-09-09 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added inline comments. Comment at: clang/test/Driver/haiku.cpp:2 +// Check the C++ header path (libstdc++) +// RUN: %clang++ --target=x86_64-unknown-haiku -### %s 2>&1 \ +// RUN: --sysroot=%S/Inputs/haiku_x86_64_tree \ brad wrote: > abrachet wrote: > >

[clang] [Haiku] Don't assume clang was build with libstdc++ as default (PR #65871)

2023-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes This test fails with `CLANG_DEFAULT_CXX_STDLIB=libc++` -- Full diff: https://github.com/llvm/llvm-project/pull/65871.diff 1 Files Affected: - (modified) clang/test/Driver/haiku.cpp (+1-1) diff --git a/clang/test/Driver/haiku.cpp b/clang/t

[clang] [Haiku] Don't assume clang was build with libstdc++ as default (PR #65871)

2023-09-09 Thread Brad Smith via cfe-commits
https://github.com/brad0 approved this pull request. https://github.com/llvm/llvm-project/pull/65871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6966c06 - [clang] NFCI: Use `FileEntryRef` in `suggestPathToFileForDiagnostics()`

2023-09-09 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-09-09T20:29:04-07:00 New Revision: 6966c06bedd0639169ad82cf17ded235d0acb850 URL: https://github.com/llvm/llvm-project/commit/6966c06bedd0639169ad82cf17ded235d0acb850 DIFF: https://github.com/llvm/llvm-project/commit/6966c06bedd0639169ad82cf17ded235d0acb850.diff L

[clang] 715257e - [clang] NFCI: Use `FileEntryRef` in `Sarif.cpp`

2023-09-09 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-09-09T20:56:46-07:00 New Revision: 715257eac76cafef483014e01c3b4abed964815f URL: https://github.com/llvm/llvm-project/commit/715257eac76cafef483014e01c3b4abed964815f DIFF: https://github.com/llvm/llvm-project/commit/715257eac76cafef483014e01c3b4abed964815f.diff L

[clang] 33f19a6 - [Haiku] Don't assume clang was build with libstdc++ as default (#65871)

2023-09-09 Thread via cfe-commits
Author: Alex Brachet Date: 2023-09-10T00:00:08-04:00 New Revision: 33f19a6f1c279f5f77a577fae41f13133522497b URL: https://github.com/llvm/llvm-project/commit/33f19a6f1c279f5f77a577fae41f13133522497b DIFF: https://github.com/llvm/llvm-project/commit/33f19a6f1c279f5f77a577fae41f13133522497b.diff

[clang] [Haiku] Don't assume clang was build with libstdc++ as default (PR #65871)

2023-09-09 Thread Alex Brachet via cfe-commits
https://github.com/abrachet closed https://github.com/llvm/llvm-project/pull/65871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e483a6e - [clang] NFCI: Use `FileEntryRef` in `LookupSubframeworkHeader()`

2023-09-09 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-09-09T21:50:38-07:00 New Revision: e483a6e174f5e06ae46d870c5263b489db4b9e65 URL: https://github.com/llvm/llvm-project/commit/e483a6e174f5e06ae46d870c5263b489db4b9e65 DIFF: https://github.com/llvm/llvm-project/commit/e483a6e174f5e06ae46d870c5263b489db4b9e65.diff L

[clang] bc933c9 - [clang] NFCI: Use `FileEntryRef` in `ModuleManager`

2023-09-09 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-09-09T21:50:38-07:00 New Revision: bc933c904704f747fb63f6c93d09c6759936e255 URL: https://github.com/llvm/llvm-project/commit/bc933c904704f747fb63f6c93d09c6759936e255 DIFF: https://github.com/llvm/llvm-project/commit/bc933c904704f747fb63f6c93d09c6759936e255.diff L

[clang] e644f59 - [clang] NFCI: Use `FileEntryRef` in `ModuleMapCallbacks`

2023-09-09 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-09-09T21:51:04-07:00 New Revision: e644f5973b0b71baadc6d7b64596527a1dc49d17 URL: https://github.com/llvm/llvm-project/commit/e644f5973b0b71baadc6d7b64596527a1dc49d17 DIFF: https://github.com/llvm/llvm-project/commit/e644f5973b0b71baadc6d7b64596527a1dc49d17.diff L

[clang] 14498a4 - [clang] NFCI: Use `FileEntryRef` in `GlobalModuleIndex`

2023-09-09 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-09-09T21:51:03-07:00 New Revision: 14498a477ee9e00dc462779cee8cbc5846ca6d3a URL: https://github.com/llvm/llvm-project/commit/14498a477ee9e00dc462779cee8cbc5846ca6d3a DIFF: https://github.com/llvm/llvm-project/commit/14498a477ee9e00dc462779cee8cbc5846ca6d3a.diff L

[clang] 89bacc0 - [clang] NFCI: Use `FileEntryRef` in `CreateHeaderMap()`

2023-09-09 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-09-09T21:51:04-07:00 New Revision: 89bacc0bb9f6aa66ca1951ec5c0e4c38cc661160 URL: https://github.com/llvm/llvm-project/commit/89bacc0bb9f6aa66ca1951ec5c0e4c38cc661160 DIFF: https://github.com/llvm/llvm-project/commit/89bacc0bb9f6aa66ca1951ec5c0e4c38cc661160.diff L

[PATCH] D158926: [clangd] Show parameter hints for operator()

2023-09-09 Thread Younan Zhang via Phabricator via cfe-commits
zyounan marked 2 inline comments as done. zyounan added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:626 + Method && Method->isInstance()) +Args = Args.drop_front(1); +processCall(Callee, Args); nridge wrote: > Huh, th

[PATCH] D158926: [clangd] Show parameter hints for operator()

2023-09-09 Thread Younan Zhang via Phabricator via cfe-commits
zyounan updated this revision to Diff 556358. zyounan marked an inline comment as done. zyounan added a comment. Address a nit comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158926/new/ https://reviews.llvm.org/D158926 Files: clang-tools-

[clang] [Fuchsia] Disable libcxx timezone database (PR #65870)

2023-09-09 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/65870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

2023-09-09 Thread Younan Zhang via Phabricator via cfe-commits
zyounan added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3577 // containing all of the arguments up to the first deducible argument. + // Or, if this isn't a call, emit all the template arguments + // to disambiguate the (potential) overload

<    1   2