[PATCH] D148381: [Clang] Add counted_by attribute

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/attr-counted-by.c:2 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 3 +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -O2 -Wall -fsanitize=array-bounds,

[PATCH] D157191: Improve dumps of attributes

giulianobelinassi updated this revision to Diff 556319. giulianobelinassi added a comment. Fix warning in MSVC Summary: Currently there is no `PrintOnLeft` attribute set, which results in an empty switch-case. When compiling this, MSVC issues a warning saying that the switch-case is empty. Fix th

[PATCH] D159490: Fix warning in MSVC

giulianobelinassi created this revision. giulianobelinassi added reviewers: aaron.ballman, erichkeane. Herald added a project: All. giulianobelinassi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently there is no `PrintOnLeft` attrib

[PATCH] D158948: [clang][ASTImporter] Add import of type-related nodes

haowei added a comment. Hi I am working on updating GoogleTest in LLVM to v1.14.0 and during my local testing, I noticed that this patch added 2 new tests `ImportMatrixType` and `ImportOpenCLPipe` through `TEST_P` calls, however, both tests were not instantiated by `INSTANTIATE_TEST_SUITE_P` so

[clang] [Parse] Split incremental-extensions (PR #65683)

bnbarham wrote: > LGTM! Maybe we can cherry pick it for the patch release 17.0.1. If that’s a > critical patch for swift we can try for the 17.0.0 release. It's in the appropriate branches in our fork, so it's fine for us either way. I suggested it more because of https://github.com/llvm/llvm-

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

void updated this revision to Diff 556323. void edited the summary of this revision. void added a comment. Fix docs to use the correct code examples throughout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

void added inline comments. Comment at: clang/test/CodeGen/attr-counted-by.c:2 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 3 +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -O2 -Wall -fsanitize=array-bounds,object-size

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

void added inline comments. Comment at: clang/test/CodeGen/attr-counted-by.c:2 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 3 +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -O2 -Wall -fsanitize=array-bounds,object-size

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

void updated this revision to Diff 556324. void added a comment. Add test output when the attribute isn't used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/AST/Decl.h cl

[clang-tools-extra] 5523fef - [clang][lex] Use preferred path separator in includer-relative lookup

Author: Jan Svoboda Date: 2023-09-08T16:38:08-07:00 New Revision: 5523fefb01c282c4cbcaf6314a9aaf658c6c145f URL: https://github.com/llvm/llvm-project/commit/5523fefb01c282c4cbcaf6314a9aaf658c6c145f DIFF: https://github.com/llvm/llvm-project/commit/5523fefb01c282c4cbcaf6314a9aaf658c6c145f.diff L

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

https://github.com/amykhuang resolved https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f0f548a - [clang] Make test separator-agnostic

Author: Jan Svoboda Date: 2023-09-08T16:56:01-07:00 New Revision: f0f548a65a215c450d956dbcedb03656449705b9 URL: https://github.com/llvm/llvm-project/commit/f0f548a65a215c450d956dbcedb03656449705b9 DIFF: https://github.com/llvm/llvm-project/commit/f0f548a65a215c450d956dbcedb03656449705b9.diff L

[clang] Update GoogleTest to v1.14.0 (PR #65823)

https://github.com/zeroomega review_requested https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Update GoogleTest to v1.14.0 (PR #65823)

https://github.com/zeroomega review_requested https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Update GoogleTest to v1.14.0 (PR #65823)

https://github.com/zeroomega review_requested https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Update GoogleTest to v1.14.0 (PR #65823)

https://github.com/zeroomega review_requested https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Update GoogleTest to v1.14.0 (PR #65823)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Forward --target to system include extraction (PR #65824)

https://github.com/mincrmatt12 review_requested https://github.com/llvm/llvm-project/pull/65824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Forward --target to system include extraction (PR #65824)

https://github.com/mincrmatt12 created https://github.com/llvm/llvm-project/pull/65824: Some clang multilib configurations (such as the one currently used in the [beta ARM LLVM toolchain](https://github.com/ARM-software/LLVM-embedded-toolchain-for-Arm)) wind up only reporting the C++ include

[clang-tools-extra] [clangd] Forward --target to system include extraction (PR #65824)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

felix642 updated this revision to Diff 556326. felix642 added a comment. Updated Differential to truly support optional parameters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159436/new/ https://reviews.llvm.org/D159436 Files: clang-tools-extr

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

@@ -3055,7 +3195,7 @@ void MicrosoftRecordLayoutBuilder::injectVBPtr(const CXXRecordDecl *RD) { // It is possible that there were no fields or bases located after vbptr, // so the size was not adjusted before. if (Size < FieldStart) - Size = FieldStart; +

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

felix642 updated this revision to Diff 556328. felix642 added a comment. Updated documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159436/new/ https://reviews.llvm.org/D159436 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.h clan

[clang] [RISCV] Support predefined marcro __riscv_misaligned_{fast,avoid}. (PR #65756)

@@ -322,6 +327,8 @@ bool RISCVTargetInfo::handleTargetFeatures(std::vector &Features, if (ISAInfo->hasExtension("zfh") || ISAInfo->hasExtension("zhinx")) HasLegalHalfType = true; + FastUnalignedAccess = llvm::is_contained(Features, "+unaligned-scalar-mem"); ---

[clang] [StackProtector] Clear out stack protector slot (PR #65461)

bwendling wrote: >From the feedback, I think this change may be a bit premature. As I mentioned, >there's already a way to zero the stack upon entry to the function. What I *really* want to do is zero out the register that held the stack guard value, like in the GCC patch @nickdesaulniers poin

[clang] [StackProtector] Clear out stack protector slot (PR #65461)

https://github.com/bwendling closed https://github.com/llvm/llvm-project/pull/65461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Also use --no-as-needed when linking libatomic on Linux/Sparc (PR #65827)

https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/65827: None >From 7d31337b87043828f96129e2aa2a02eaaccc3e5e Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Fri, 8 Sep 2023 17:44:48 -0400 Subject: [PATCH] [Driver] Also use --no-as-needed when linking libatomic on Linu

[clang] [Driver] Also use --no-as-needed when linking libatomic on Linux/Sparc (PR #65827)

https://github.com/brad0 review_requested https://github.com/llvm/llvm-project/pull/65827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Also use --no-as-needed when linking libatomic on Linux/Sparc (PR #65827)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Also use --no-as-needed when linking libatomic on Linux/Sparc (PR #65827)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

daltenty added a comment. In D159339#4642210 , @v.g.vassilev wrote: > In D159339#4642147 , @daltenty > wrote: > >> FYI: I tried to reproduce this on `powerpc64le-linux-gnu` at `-02` and >> didn't see it at this

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

https://github.com/rymiel edited https://github.com/llvm/llvm-project/pull/65808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

https://github.com/rymiel approved this pull request. https://github.com/llvm/llvm-project/pull/65808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

@@ -593,6 +593,47 @@ struct FormatStyle { /// \version 3.3 bool AllowAllParametersOfDeclarationOnNextLine; + /// Different ways to break before a noexcept specifier. + enum BreakBeforeNoexceptSpecifierStyle : int8_t { +/// No line break allowed. +/// \code +/

[clang] a3ba9d6 - [Driver] Fixes for header / library paths on Haiku

Author: Brad Smith Date: 2023-09-08T21:34:31-04:00 New Revision: a3ba9d697b17ebb969b86b5c3b34b102fd22e583 URL: https://github.com/llvm/llvm-project/commit/a3ba9d697b17ebb969b86b5c3b34b102fd22e583 DIFF: https://github.com/llvm/llvm-project/commit/a3ba9d697b17ebb969b86b5c3b34b102fd22e583.diff LO

[PATCH] D159414: [Driver] Fixes for header / library paths on Haiku

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. brad marked 2 inline comments as not done. Closed by commit rGa3ba9d697b17: [Driver] F

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

shafik wrote: LGTM, thank you for the quick fix! https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158948: [clang][ASTImporter] Add import of type-related nodes

danix800 added a comment. In D158948#4642422 , @haowei wrote: > Looking at > https://github.com/llvm/llvm-project/blob/37a20cc68f545647e614c5ba4ae311dc3fd277e9/clang/lib/Testing/CommandLineArgs.cpp#L47, > this is were the unreachable code was hit. Is it

[PATCH] D158948: [clang][ASTImporter] Add import of type-related nodes

danix800 added a comment. @haowei I noticed https://github.com/llvm/llvm-project/pull/65823, is it related to your work? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158948/new/ https://reviews.llvm.org/D158948 __

[PATCH] D158948: [clang][ASTImporter] Add import of type-related nodes

haowei added a comment. In D158948#4642475 , @danix800 wrote: > In D158948#4642422 , @haowei wrote: > >> Looking at >> https://github.com/llvm/llvm-project/blob/37a20cc68f545647e614c5ba4ae311dc3fd277e9/clang/lib/

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

felix642 updated this revision to Diff 556331. felix642 added a comment. Removed false option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159436/new/ https://reviews.llvm.org/D159436 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.h clang

[clang] 523c471 - Reapply "[clang] NFCI: Adopt `SourceManager::getFileEntryRefForID()`"

Author: Jan Svoboda Date: 2023-09-08T19:04:01-07:00 New Revision: 523c471250a49b5603bd907ff05535f18ef61c91 URL: https://github.com/llvm/llvm-project/commit/523c471250a49b5603bd907ff05535f18ef61c91 DIFF: https://github.com/llvm/llvm-project/commit/523c471250a49b5603bd907ff05535f18ef61c91.diff L

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

felix642 updated this revision to Diff 556333. felix642 added a comment. Moved to a new method, changed tests, changed documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159436/new/ https://reviews.llvm.org/D159436 Files: clang-tools-ex

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

felix642 added a comment. Hi @PiotrZSL and @carlosgalvezp, I have updated my PR based on your comments. Let me know what you think. What if: "MinimumLength" is a boolean. It's default value (if not specified) is True. And a user wants to set it as "False" here Wouldn't that cause

[clang] 0c41681 - [clang] NFCI: Use `FileEntryRef` in `VerifyDiagnosticConsumer`

Author: Jan Svoboda Date: 2023-09-08T20:12:08-07:00 New Revision: 0c41681a0ce3ab8c4f145b30e586d25a33b75bbf URL: https://github.com/llvm/llvm-project/commit/0c41681a0ce3ab8c4f145b30e586d25a33b75bbf DIFF: https://github.com/llvm/llvm-project/commit/0c41681a0ce3ab8c4f145b30e586d25a33b75bbf.diff L

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

felix642 updated this revision to Diff 556334. felix642 added a comment. Forgot to update a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159436/new/ https://reviews.llvm.org/D159436 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.h

[clang] c184f27 - Fixes for Haiku tests on Win32

Author: Brad Smith Date: 2023-09-09T00:13:26-04:00 New Revision: c184f27f55ab767e8c7bec589b24daeb4177c093 URL: https://github.com/llvm/llvm-project/commit/c184f27f55ab767e8c7bec589b24daeb4177c093 DIFF: https://github.com/llvm/llvm-project/commit/c184f27f55ab767e8c7bec589b24daeb4177c093.diff LO

[clang] 358d9db - [clang] NFCI: Use `FileEntryRef` in `checkMSVCHeaderSearch()`

Author: Jan Svoboda Date: 2023-09-08T21:28:05-07:00 New Revision: 358d9dbf4f1b9b3b166139a366d0e8c5162988c0 URL: https://github.com/llvm/llvm-project/commit/358d9dbf4f1b9b3b166139a366d0e8c5162988c0 DIFF: https://github.com/llvm/llvm-project/commit/358d9dbf4f1b9b3b166139a366d0e8c5162988c0.diff L

[clang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

Jianhui-Li wrote: > > We really just need a "mlir-runner" with target-platform as command > > parameters. > > What kind of "target-platform" command parameters do you have in mind? (other > than what we do now) The current way of mlir-cpu-runner using the share library name to indicate targe

[clang-tools-extra] [MLIR] Enabling Intel GPU Integration. (PR #65539)

Jianhui-Li wrote: > > We really just need a "mlir-runner" with target-platform as command > > parameters. > > What kind of "target-platform" command parameters do you have in mind? (other > than what we do now) The current way of mlir-cpu-runner using the share library name to indicate targe

[clang] f807494 - [clang][Interp] Fix SourceLocExpr used in CXXDefaultInitExprs

Author: Timm Bäder Date: 2023-09-09T07:28:50+02:00 New Revision: f8074942c5a6f266abb1c4d1465a4d8115b22d43 URL: https://github.com/llvm/llvm-project/commit/f8074942c5a6f266abb1c4d1465a4d8115b22d43 DIFF: https://github.com/llvm/llvm-project/commit/f8074942c5a6f266abb1c4d1465a4d8115b22d43.diff LO

[PATCH] D156045: [clang][Interp] Enable existing source_location tests

tbaeder added a comment. @hazohelet Thanks for noticing. Should be fixed via https://github.com/llvm/llvm-project/commit/f8074942c5a6f266abb1c4d1465a4d8115b22d43. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156045/new/ https://reviews.llvm.org/D

[clang] 8a2d68f - [clang][CodeGen] Switch declaration of vtable information to be [0 x ptr] (#65596)

Author: Nuno Lopes Date: 2023-09-09T07:50:35+01:00 New Revision: 8a2d68f6be5058f88588c31928ff40d8eb16c20a URL: https://github.com/llvm/llvm-project/commit/8a2d68f6be5058f88588c31928ff40d8eb16c20a DIFF: https://github.com/llvm/llvm-project/commit/8a2d68f6be5058f88588c31928ff40d8eb16c20a.diff LO

[clang] [clang][CodeGen] Switch declaration of vtable information to be [0 x ptr] (PR #65596)

https://github.com/nunoplopes closed https://github.com/llvm/llvm-project/pull/65596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4