[PATCH] D159479: [ASTImport]CXXBoolLiteralExpr should be handled explicitly in statement comparation

jcsxky added a comment. In D159479#4640607 , @steakhal wrote: > Make sure the commit message complies with the guidelines. Fix title and summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159479/new/

[PATCH] D159479: [ASTImport]CXXBoolLiteralExpr should be handled explicitly in statement comparation

jcsxky added a comment. In D159479#4640590 , @donat.nagy wrote: > Today we learned that truth is different from falsehood... > > LGTM, nice catch! Thanks for your quick review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D158371: [clang-tidy] Fix DanglingHandleCheck to work in C++17 and later mode

loskutov added a comment. In D158371#4619348 , @PiotrZSL wrote: > Please wait like 2 weeks before pushing this, so someone else could be able > to verify this if they need. It's been 2 weeks, so I guess nothing prevents from getting this change merged.

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

VitaNuo marked 2 inline comments as done. VitaNuo added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:919 + if (IncludeHeader.empty()) +HeaderFileURIs->getIncludeHeader(FID); + kadircet wrote: > i guess LHS of the as

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

VitaNuo updated this revision to Diff 556135. VitaNuo marked an inline comment as done. VitaNuo added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156659/new/ https://reviews.llvm.org/D156659 Files: clang-tools-extr

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/65381: >From d4bef144b3b0d53aaf2a68f24a596f71c7205317 Mon Sep 17 00:00:00 2001 From: yronglin Date: Wed, 6 Sep 2023 00:00:18 +0800 Subject: [PATCH 1/2] [Clang] Fix the do while statement disappearing in AST when an e

[clang] Reland "[CUDA][HIP] Fix overloading resolution in global variable ini… (PR #65606)

https://github.com/yxsamliu review_requested https://github.com/llvm/llvm-project/pull/65606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[CUDA][HIP] Fix overloading resolution in global variable ini… (PR #65606)

https://github.com/yxsamliu review_requested https://github.com/llvm/llvm-project/pull/65606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[CUDA][HIP] Fix overloading resolution in global variable ini… (PR #65606)

https://github.com/yxsamliu review_requested https://github.com/llvm/llvm-project/pull/65606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[CUDA][HIP] Fix overloading resolution in global variable ini… (PR #65606)

https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/65606: …tializer" https://reviews.llvm.org/D158247 caused regressions for HIP on Windows and was reverted. A reduced test case is: ``` typedef void (__stdcall* funcTy)(); void invoke(funcTy f); static void __stdca

[clang] Reland "[CUDA][HIP] Fix overloading resolution in global variable ini… (PR #65606)

https://github.com/yxsamliu review_requested https://github.com/llvm/llvm-project/pull/65606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[CUDA][HIP] Fix overloading resolution in global variable ini… (PR #65606)

https://github.com/yxsamliu review_requested https://github.com/llvm/llvm-project/pull/65606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[CUDA][HIP] Fix overloading resolution in global variable ini… (PR #65606)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158247: [CUDA][HIP] Fix overloading resolution in global variable initializer

yaxunl closed this revision. yaxunl added a comment. Phabricator no longer allows me to update the patch. Created PR in github https://github.com/llvm/llvm-project/pull/65606 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158247/new/ https://review

[clang] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

@@ -93,4 +93,4 @@ // RUN: not %clang_cc1 -triple riscv64 -tune-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --check-prefix TUNE-RISCV64 // TUNE-RISCV64: error: unknown target CPU 'not-a-cpu' -// TUNE-RISCV64-NEXT: note: valid target CPU values are: generic-rv64, rocket

[PATCH] D159250: [X86][RFC] Add new option `-m[no-]evex512` to disable ZMM and 64-bit mask instructions for AVX512 features

pengfei added inline comments. Comment at: clang/lib/CodeGen/Targets/X86.cpp:1493 const llvm::StringMap &CalleeMap, QualType Ty, StringRef Feature, bool IsArgument) { ---

[PATCH] D151834: Include math-errno with fast-math

zahiraam updated this revision to Diff 556141. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptions.def clan

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

ABataev added a comment. In D158266#4640416 , @koops wrote: > Can someone please review the changes that I uploaded last week? Still need to add extra tests to the nesting_of_regions.cpp test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266

[clang] a991ccd - [LTO][CodeGen] Test LTO pipeline choices more thoroughly (#65485)

Author: Paul T Robinson Date: 2023-09-07T09:49:27-04:00 New Revision: a991ccd8efec2888c9a46e68bf1d68820d66764a URL: https://github.com/llvm/llvm-project/commit/a991ccd8efec2888c9a46e68bf1d68820d66764a DIFF: https://github.com/llvm/llvm-project/commit/a991ccd8efec2888c9a46e68bf1d68820d66764a.dif

[clang] [LTO][CodeGen] Test LTO pipeline choices more thoroughly (PR #65485)

https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/65485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64]: Refactor target parser to use BitVector. (PR #65423)

https://github.com/hassnaaHamdi resolved https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64]: Refactor target parser to use BitVector. (PR #65423)

@@ -315,23 +317,23 @@ struct ArchInfo { }; // clang-format off -inline constexpr ArchInfo ARMV8A= { VersionTuple{8, 0}, AProfile, "armv8-a", "+v8a", (AArch64::AEK_FP | AArch64::AEK_SIMD), }; -inline constexpr ArchInfo ARMV8_1A = { VersionTuple{8, 1}, AProfile, "armv8.1-

[clang] [AArch64]: Refactor target parser to use BitVector. (PR #65423)

https://github.com/hassnaaHamdi resolved https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

https://github.com/mgudim updated https://github.com/llvm/llvm-project/pull/65535: >From d1ba27988840703b9a7a12ad48ecfb282752e7e2 Mon Sep 17 00:00:00 2001 From: Mikhail Gudim Date: Wed, 6 Sep 2023 17:15:56 -0400 Subject: [PATCH] [RISCV] Added definition of Ventana veyron-v1 processor. --- cla

[clang] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

https://github.com/NuriAmari closed https://github.com/llvm/llvm-project/pull/65179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

https://github.com/NuriAmari closed https://github.com/llvm/llvm-project/pull/65179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

erichkeane added a comment. In D159126#4640484 , @cor3ntin wrote: > Fix libc++ compile > > @erichkeane I struggle to reduce further, do you think it's worth adding this > inscrutable > test case somewhere? There's definitely value to putting it in some

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

https://github.com/daniel-grumberg updated https://github.com/llvm/llvm-project/pull/65481: >From 32155e8b5ac01242c3e16968f9a7c821d16b7007 Mon Sep 17 00:00:00 2001 From: Daniel Grumberg Date: Wed, 6 Sep 2023 12:20:30 +0100 Subject: [PATCH] [clang] Prioritze decl comments from macro expansion si

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

@@ -179,103 +179,38 @@ static SourceLocation getDeclLocForCommentSearch(const Decl *D, isa(D) || // Allow association with Y across {} in `typedef struct X {} Y`. isa(D)) -return D->getBeginLoc(); +return {D->getBeginLoc()}; daniel-gr

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

https://github.com/daniel-grumberg review_requested https://github.com/llvm/llvm-project/pull/65481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Exclude bitwise operators in bugprone-non-zero-enum-to-bool-conversion (PR #65498)

https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/65498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Exclude bitwise operators in bugprone-non-zero-enum-to-bool-conversion (PR #65498)

https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/65498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Exclude bitwise operators in bugprone-non-zero-enum-to-bool-conversion (PR #65498)

@@ -49,6 +49,9 @@ bool NonZeroEnumToBoolConversionCheck::isLanguageVersionSupported( } void NonZeroEnumToBoolConversionCheck::registerMatchers(MatchFinder *Finder) { + auto ExcludedOperators = binaryOperation(hasAnyOperatorName( + "|", "&", "^", "<<", ">>", "~", "|=", "

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

https://github.com/shafik commented: nit https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

@@ -4588,28 +4641,29 @@ std::string CompilerInvocation::getModuleHash() const { return toString(llvm::APInt(64, Hash), 36, /*Signed=*/false); } -void CompilerInvocation::generateCC1CommandLine( +void CompilerInvocationBase::generateCC1CommandLine( ArgumentConsumer Consu

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

sandeepkosuri added inline comments. Comment at: openmp/runtime/test/target/target_thread_limit.cpp:28 +// OMP51: target: parallel +// OMP51: target: parallel +// OMP51-NOT: target: parallel mstorsjo wrote: > mstorsjo wrote: > > This test fails when running (on W

[clang] [clang][AArch64] Add --print-supported-extensions support (PR #65466)

https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/65466: >From f0157ffb412fd2d6d4aa4a294b631f74e5638878 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 6 Sep 2023 10:15:27 + Subject: [PATCH 1/2] [clang][AArch64] Add --print-supported-extensions supp

<    1   2   3   4   5   6