[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-07 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-07 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-07 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64] Fix FMV crash on unspecified number of parameters function (PR #65671)

2023-09-07 Thread Pavel Iliin via cfe-commits
https://github.com/ilinpv created https://github.com/llvm/llvm-project/pull/65671: Fix Function Multi Versioning crash reported in https://github.com/llvm/llvm-project/issues/65669 >From 209597f82942f857e6f83da85335d61a6274e278 Mon Sep 17 00:00:00 2001 From: Pavel Iliin Date: Thu, 7 Sep 2023

[clang] [AArch64] Fix FMV crash on unspecified number of parameters function (PR #65671)

2023-09-07 Thread Pavel Iliin via cfe-commits
https://github.com/ilinpv review_requested https://github.com/llvm/llvm-project/pull/65671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64] Fix FMV crash on unspecified number of parameters function (PR #65671)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

2023-09-07 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added inline comments. Comment at: openmp/runtime/test/target/target_thread_limit.cpp:28 +// OMP51: target: parallel +// OMP51: target: parallel +// OMP51-NOT: target: parallel sandeepkosuri wrote: > mstorsjo wrote: > > mstorsjo wrote: > > > This test fa

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-07 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64] Fix FMV crash on unspecified number of parameters function (PR #65671)

2023-09-07 Thread Pavel Iliin via cfe-commits
https://github.com/ilinpv review_requested https://github.com/llvm/llvm-project/pull/65671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

2023-09-07 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-07 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e1cc299 - [clang] Introduce copy-on-write `CompilerInvocation` (#65412)

2023-09-07 Thread via cfe-commits
Author: Jan Svoboda Date: 2023-09-07T14:01:40-07:00 New Revision: e1cc299ec885d0b1607f162322fe23b772866acf URL: https://github.com/llvm/llvm-project/commit/e1cc299ec885d0b1607f162322fe23b772866acf DIFF: https://github.com/llvm/llvm-project/commit/e1cc299ec885d0b1607f162322fe23b772866acf.diff L

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

2023-09-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang labeled https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang created https://github.com/llvm/llvm-project/pull/65675: This implements the [[msvc::no_unique_address]] attribute. There is not ABI compatibility in this patch because the attribute is relatively new and there's still some uncertainty in the MSVC version. Bug: ht

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang review_requested https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang review_requested https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang review_requested https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang labeled https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang review_requested https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang review_requested https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang review_requested https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157762: Implement [[msvc::no_unique_address]]

2023-09-07 Thread Amy Huang via Phabricator via cfe-commits
akhuang added a comment. turned this into a github PR https://github.com/llvm/llvm-project/pull/65675/commits/923a43cd6386f6e57023fd8928eed0dc0ab04d57 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157762/new/ https://reviews.llvm.org/D157762 ___

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang edited https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159483: [Modules] Add a flag to control builtin headers being in system modules

2023-09-07 Thread Ian Anderson via Phabricator via cfe-commits
iana updated this revision to Diff 556206. iana added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159483/new/ https://reviews.llvm.org/D159483 Files: clang/include/clang/Basic/Features.def clang/include/clang/Basic/

[PATCH] D159483: [Modules] Add a flag to control builtin headers being in system modules

2023-09-07 Thread Ian Anderson via Phabricator via cfe-commits
iana updated this revision to Diff 556207. iana added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159483/new/ https://reviews.llvm.org/D159483 Files: clang/include/clang/Basic/Features.def clang/include/clang/Basic/LangOpti

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

2023-09-07 Thread Ian Anderson via Phabricator via cfe-commits
iana updated this revision to Diff 556208. iana added a comment. Fix formatting issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159064/new/ https://reviews.llvm.org/D159064 Files: clang/lib/Basic/Module.cpp clang/lib/Headers/__stddef_null.

[clang] [clang][deps] Store common, partially-formed invocation (PR #65677)

2023-09-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/65677: We create one `CompilerInvocation` for each modular dependency we discover. This means we create a lot of copies, even though most of the invocation is the same between modules. This patch makes use of the

[clang] [clang][deps] Store common, partially-formed invocation (PR #65677)

2023-09-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 review_requested https://github.com/llvm/llvm-project/pull/65677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Store common, partially-formed invocation (PR #65677)

2023-09-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 review_requested https://github.com/llvm/llvm-project/pull/65677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-07 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148: >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 1/3] [libc++] Implement ranges::contains Differential Revision:

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-07 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148: >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 1/4] [libc++] Implement ranges::contains Differential Revision:

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-07 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148: >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 1/4] [libc++] Implement ranges::contains Differential Revision:

[PATCH] D159483: [Modules] Add a flag to control builtin headers being in system modules

2023-09-07 Thread Ben Langmuir via Phabricator via cfe-commits
benlangmuir added a comment. I suggest we add a comment explaining the weird has_feature checks being added here (even if they're less weird than what they're replacing). Maybe just a comment in stdarg.h and/or stddef.h and then the __std(arg|def) headers could just add a one-liner reference

[PATCH] D141375: [SYCL][OpenMP] Fix compilation errors for unsupported __bf16 intrinsics

2023-09-07 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Herald added a subscriber: jplehr. Comment at: clang/lib/Sema/Sema.cpp:1978-1979 !Context.getTargetInfo().hasInt128Type()) || +(Ty->isBFloat16Type() && !Context.getTargetInfo().hasBFloat16Type() && + !LangOpts.CUDAIsDevice) ||

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

2023-09-07 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 556209. cor3ntin added a comment. Add the test case that caused a build failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159126/new/ https://reviews.llvm.org/D159126 Files: clang/docs/ReleaseNotes.rst

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Reid Kleckner via cfe-commits
@@ -4505,6 +4505,14 @@ bool FieldDecl::isZeroSize(const ASTContext &Ctx) const { if (!CXXRD->isEmpty()) return false; + // MS ABI: nonzero if class type with class type fields + if (Ctx.getTargetInfo().getCXXABI().isMicrosoft() && + llvm::any_of(CXXRD->fields(), [

[clang] [Parse] Split incremental-extensions (PR #65683)

2023-09-07 Thread Ben Barham via cfe-commits
https://github.com/bnbarham review_requested https://github.com/llvm/llvm-project/pull/65683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Parse] Split incremental-extensions (PR #65683)

2023-09-07 Thread Ben Barham via cfe-commits
https://github.com/bnbarham review_requested https://github.com/llvm/llvm-project/pull/65683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Parse] Split incremental-extensions (PR #65683)

2023-09-07 Thread Ben Barham via cfe-commits
https://github.com/bnbarham review_requested https://github.com/llvm/llvm-project/pull/65683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Parse] Split incremental-extensions (PR #65683)

2023-09-07 Thread Ben Barham via cfe-commits
https://github.com/bnbarham created https://github.com/llvm/llvm-project/pull/65683: The preprocessor `IncrementalProcessing` option was being used to control whether or not to teardown the lexer or run the end of translation unit action. In D127284 this was merged with `-fincremental-extensio

[clang] [Parse] Split incremental-extensions (PR #65683)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [sema] Improve -Wsign-compare (PR #65684)

2023-09-07 Thread via cfe-commits
https://github.com/apple-fcloutier review_requested https://github.com/llvm/llvm-project/pull/65684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [sema] Improve -Wsign-compare (PR #65684)

2023-09-07 Thread via cfe-commits
https://github.com/apple-fcloutier created https://github.com/llvm/llvm-project/pull/65684: Comparisons of integers with different signs are reported by -Wsign-compare off-by-default diagnostic: ```c int foo(int s, unsigned u) { return s < u; // ^ comparison of integers of differen

[clang] [sema] Improve -Wsign-compare (PR #65684)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Parse] Split incremental-extensions (PR #65683)

2023-09-07 Thread Ben Barham via cfe-commits
bnbarham wrote: Seems Swift wasn't the only project to run into this, eg. https://github.com/llvm/llvm-project/issues/62413#issuecomment-1526499543. https://github.com/llvm/llvm-project/pull/65683 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

2023-09-07 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. @erichkeane Ok, I added a test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159126/new/ https://reviews.llvm.org/D159126 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [clang][deps] Store common, partially-formed invocation (PR #65677)

2023-09-07 Thread Ben Langmuir via cfe-commits
@@ -279,13 +281,16 @@ class ModuleDepCollector final : public DependencyCollector { /// Add module files (pcm) to the invocation, if needed. void addModuleFiles(CompilerInvocation &CI, ArrayRef ClangModuleDeps) const; + void addModuleFiles(CowCompile

[clang] [clang][deps] Store common, partially-formed invocation (PR #65677)

2023-09-07 Thread Ben Langmuir via cfe-commits
@@ -117,14 +112,37 @@ ModuleDepCollector::makeInvocationForModuleBuildWithoutOutputs( CI.getFrontendOpts().ARCMTAction = FrontendOptions::ARCMT_None; CI.getFrontendOpts().ObjCMTAction = FrontendOptions::ObjCMT_None; CI.getFrontendOpts().MTMigrateDir.clear(); - CI.getLan

[clang] [clang][deps] Store common, partially-formed invocation (PR #65677)

2023-09-07 Thread Ben Langmuir via cfe-commits
@@ -117,14 +112,37 @@ ModuleDepCollector::makeInvocationForModuleBuildWithoutOutputs( CI.getFrontendOpts().ARCMTAction = FrontendOptions::ARCMT_None; CI.getFrontendOpts().ObjCMTAction = FrontendOptions::ObjCMT_None; CI.getFrontendOpts().MTMigrateDir.clear(); - CI.getLan

[PATCH] D159483: [Modules] Add a flag to control builtin headers being in system modules

2023-09-07 Thread Ian Anderson via Phabricator via cfe-commits
iana marked an inline comment as done. iana added inline comments. Comment at: clang/include/clang/Basic/Features.def:233 FEATURE(modules, LangOpts.Modules) +FEATURE(builtin_headers_in_system_modules, LangOpts.BuiltinHeadersInSystemModules) FEATURE(safe_stack, LangOpts.Sanitiz

[clang] Reland "[CUDA][HIP] Fix overloading resolution in global variable ini… (PR #65606)

2023-09-07 Thread Mehdi Amini via cfe-commits
joker-eph wrote: Please reflow the title to avoid the `` and line wrap. https://github.com/llvm/llvm-project/pull/65606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Store common, partially-formed invocation (PR #65677)

2023-09-07 Thread Jan Svoboda via cfe-commits
@@ -279,13 +281,16 @@ class ModuleDepCollector final : public DependencyCollector { /// Add module files (pcm) to the invocation, if needed. void addModuleFiles(CompilerInvocation &CI, ArrayRef ClangModuleDeps) const; + void addModuleFiles(CowCompile

[clang] [clang][deps] Store common, partially-formed invocation (PR #65677)

2023-09-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/65677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Reid Kleckner via cfe-commits
@@ -3055,7 +3195,7 @@ void MicrosoftRecordLayoutBuilder::injectVBPtr(const CXXRecordDecl *RD) { // It is possible that there were no fields or bases located after vbptr, // so the size was not adjusted before. if (Size < FieldStart) - Size = FieldStart; +

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Reid Kleckner via cfe-commits
@@ -2937,14 +2964,97 @@ void MicrosoftRecordLayoutBuilder::layoutNonVirtualBase( BaseOffset = CharUnits::Zero(); } else { // Otherwise, lay the base out at the end of the MDC. - BaseOffset = Size = Size.alignTo(Info.Alignment); + BaseOffset = DataSize

[clang] [clang][deps] Store common, partially-formed invocation (PR #65677)

2023-09-07 Thread Jan Svoboda via cfe-commits
@@ -117,14 +112,37 @@ ModuleDepCollector::makeInvocationForModuleBuildWithoutOutputs( CI.getFrontendOpts().ARCMTAction = FrontendOptions::ARCMT_None; CI.getFrontendOpts().ObjCMTAction = FrontendOptions::ObjCMT_None; CI.getFrontendOpts().MTMigrateDir.clear(); - CI.getLan

[clang] [clang][deps] Store common, partially-formed invocation (PR #65677)

2023-09-07 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir resolved https://github.com/llvm/llvm-project/pull/65677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a8fbc16 - Revert "[git-clang-format] Fix typo in help message"

2023-09-07 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-09-07T15:05:46-07:00 New Revision: a8fbc16ebebedce98d06782680fcafae0cf06e7d URL: https://github.com/llvm/llvm-project/commit/a8fbc16ebebedce98d06782680fcafae0cf06e7d DIFF: https://github.com/llvm/llvm-project/commit/a8fbc16ebebedce98d06782680fcafae0cf06e7d.diff LOG:

[clang] Add error note when if clause is used on teams before 5.2. (PR #65686)

2023-09-07 Thread via cfe-commits
https://github.com/shraiysh created https://github.com/llvm/llvm-project/pull/65686: None >From cdcacbd3f8b86fffa0f00d8890d8b3cc3bd170bb Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Thu, 7 Sep 2023 16:30:36 -0500 Subject: [PATCH] Add error note when if clause is used on teams before 5

[clang] Add error note when if clause is used on teams before 5.2. (PR #65686)

2023-09-07 Thread via cfe-commits
https://github.com/shraiysh review_requested https://github.com/llvm/llvm-project/pull/65686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add error note when if clause is used on teams before 5.2. (PR #65686)

2023-09-07 Thread via cfe-commits
https://github.com/shraiysh review_requested https://github.com/llvm/llvm-project/pull/65686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add error note when if clause is used on teams before 5.2. (PR #65686)

2023-09-07 Thread via cfe-commits
https://github.com/shraiysh edited https://github.com/llvm/llvm-project/pull/65686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add error note when if clause is used on teams before 5.2. (PR #65686)

2023-09-07 Thread via cfe-commits
https://github.com/shraiysh edited https://github.com/llvm/llvm-project/pull/65686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Documentation] Fix typoed integer (PR #65688)

2023-09-07 Thread via cfe-commits
https://github.com/Alcaro created https://github.com/llvm/llvm-project/pull/65688: (Yes, this commit is two years old, I never felt like investigating Phabricator) >From eede884bb0e374d6ce0db4811ab1a62fc21f4c2c Mon Sep 17 00:00:00 2001 From: Alcaro Date: Fri, 4 Jun 2021 09:25:40 +0200 Subject:

[clang] [Documentation] Fix typoed integer (PR #65688)

2023-09-07 Thread via cfe-commits
https://github.com/Alcaro review_requested https://github.com/llvm/llvm-project/pull/65688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Store common, partially-formed invocation (PR #65677)

2023-09-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/65677: >From 0b4be90372e314e7ae79d58099ef940092a73536 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 24 Aug 2023 17:33:38 -0700 Subject: [PATCH] [clang][deps] Store common, partially-formed invocation ---

[clang] [clang][deps] Store common, partially-formed invocation (PR #65677)

2023-09-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 review_requested https://github.com/llvm/llvm-project/pull/65677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141375: [SYCL][OpenMP] Fix compilation errors for unsupported __bf16 intrinsics

2023-09-07 Thread Elizabeth Andrews via Phabricator via cfe-commits
eandrews added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1978-1979 !Context.getTargetInfo().hasInt128Type()) || +(Ty->isBFloat16Type() && !Context.getTargetInfo().hasBFloat16Type() && + !LangOpts.CUDAIsDevice) || LongDoubleMismatched)

[clang] [clang][deps] Store common, partially-formed invocation (PR #65677)

2023-09-07 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. https://github.com/llvm/llvm-project/pull/65677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148654: Modify BoundsSan to improve debuggability

2023-09-07 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:47 #include "llvm/Transforms/Utils/SanitizerStats.h" #include this file and BoundsChecking.cpp belong to different patches Comment at: clang/lib/CodeGen/CGExpr.cpp:

[clang] 9208065 - [clang][deps] Store common, partially-formed invocation (#65677)

2023-09-07 Thread via cfe-commits
Author: Jan Svoboda Date: 2023-09-07T15:49:11-07:00 New Revision: 9208065a7b51958b44ea012259097e742825b7f4 URL: https://github.com/llvm/llvm-project/commit/9208065a7b51958b44ea012259097e742825b7f4 DIFF: https://github.com/llvm/llvm-project/commit/9208065a7b51958b44ea012259097e742825b7f4.diff L

[clang] [clang][deps] Store common, partially-formed invocation (PR #65677)

2023-09-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/65677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64]: Refactor target parser to use Bitset. (PR #65423)

2023-09-07 Thread via cfe-commits
https://github.com/hassnaaHamdi edited https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64]: Refactor target parser to use Bitset. (PR #65423)

2023-09-07 Thread via cfe-commits
https://github.com/hassnaaHamdi edited https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add error note when if clause is used on teams before 5.2. (PR #65686)

2023-09-07 Thread Raghu Maddhipatla via cfe-commits
https://github.com/raghavendhra approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/65686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Generate command lines lazily (PR #65691)

2023-09-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 review_requested https://github.com/llvm/llvm-project/pull/65691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Generate command lines lazily (PR #65691)

2023-09-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/65691: This patch makes the generation of command lines for modular dependencies lazy/on-demand. That operation is somewhat expensive and prior to this patch used to be performed multiple times for the identical

[clang] [clang][deps] Generate command lines lazily (PR #65691)

2023-09-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 review_requested https://github.com/llvm/llvm-project/pull/65691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141375: [SYCL][OpenMP] Fix compilation errors for unsupported __bf16 intrinsics

2023-09-07 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1978-1979 !Context.getTargetInfo().hasInt128Type()) || +(Ty->isBFloat16Type() && !Context.getTargetInfo().hasBFloat16Type() && + !LangOpts.CUDAIsDevice) || LongDoubleMismatched) { --

[clang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

2023-09-07 Thread Mehdi Amini via cfe-commits
@@ -0,0 +1,223 @@ +//===- SyclRuntimeWrappers.cpp - MLIR SYCL wrapper library ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

2023-09-07 Thread Reid Kleckner via cfe-commits
https://github.com/rnk created https://github.com/llvm/llvm-project/pull/65692: MSVC allows users to pass structures with required alignments greater than 4 to variadic functions. It does not pass them indirectly to correctly align them. Instead, it passes them directly with the usual 4 byte st

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

2023-09-07 Thread Reid Kleckner via cfe-commits
https://github.com/rnk review_requested https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

2023-09-07 Thread Reid Kleckner via cfe-commits
https://github.com/rnk review_requested https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

2023-09-07 Thread Reid Kleckner via cfe-commits
https://github.com/rnk review_requested https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

2023-09-07 Thread Reid Kleckner via cfe-commits
https://github.com/rnk review_requested https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

2023-09-07 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. Following up, the vararg fix is here: https://github.com/llvm/llvm-project/pull/65692 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152752/new/ https://reviews.llvm.org/D152752 ___

[clang] [clang][deps] Generate command lines lazily (PR #65691)

2023-09-07 Thread Ben Langmuir via cfe-commits
@@ -532,7 +539,8 @@ ModuleDepCollectorPP::handleTopLevelModule(const Module *M) { // Finish the compiler invocation. Requires dependencies and the context hash. MDC.addOutputPaths(CI, MD); - MD.BuildArguments = CI.getCC1CommandLine(); + MD.BuildInvocationOrArguments =

[clang] [clang][deps] Generate command lines lazily (PR #65691)

2023-09-07 Thread Jan Svoboda via cfe-commits
@@ -532,7 +539,8 @@ ModuleDepCollectorPP::handleTopLevelModule(const Module *M) { // Finish the compiler invocation. Requires dependencies and the context hash. MDC.addOutputPaths(CI, MD); - MD.BuildArguments = CI.getCC1CommandLine(); + MD.BuildInvocationOrArguments =

[clang] [clang][deps] Generate command lines lazily (PR #65691)

2023-09-07 Thread Jan Svoboda via cfe-commits
@@ -136,9 +138,15 @@ struct ModuleDeps { /// determined that the differences are benign for this compilation. std::vector ClangModuleDeps; - /// Compiler invocation that can be used to build this module. Does not - /// include argv[0]. - std::vector BuildArguments; + /

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-07 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Generate command lines lazily (PR #65691)

2023-09-07 Thread Ben Langmuir via cfe-commits
@@ -136,9 +138,15 @@ struct ModuleDeps { /// determined that the differences are benign for this compilation. std::vector ClangModuleDeps; - /// Compiler invocation that can be used to build this module. Does not - /// include argv[0]. - std::vector BuildArguments; + /

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

2023-09-07 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx created https://github.com/llvm/llvm-project/pull/65699: This change is symmetric with the one reviewed in and handles the exception handling specific intrinsic, which slipped through the cracks, in the same way, by inserting an ad

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

2023-09-07 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx review_requested https://github.com/llvm/llvm-project/pull/65699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

2023-09-07 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx labeled https://github.com/llvm/llvm-project/pull/65699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

2023-09-07 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx review_requested https://github.com/llvm/llvm-project/pull/65699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   6   >