[clang-tools-extra] [clang-tidy] Exclude bitwise operators in bugprone-non-zero-enum-to-bool-conversion (PR #65498)

https://github.com/PiotrZSL updated https://github.com/llvm/llvm-project/pull/65498: >From 79b61b63896a203793bdb0af62c8bee4f676a5c1 Mon Sep 17 00:00:00 2001 From: Piotr Zegar Date: Wed, 6 Sep 2023 16:41:22 + Subject: [PATCH 1/2] [clang-tidy] Exclude bitwise operators in bugprone-non-zero-e

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

@@ -0,0 +1,105 @@ +//===--- CppInitClassMembersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] Add Documentation for Execution Results Handling in Clang-Repl (PR #65650)

vgvassilev wrote: @gribozavr, after this PR we will need to have `dot` for the sphinx documentation for the bots. Could you install it on the bots? Eg, https://lab.llvm.org/buildbot/#/builders/92/builds/49520 Further details: https://discourse.llvm.org/t/any-tool-for-creating-editable-diagram

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

https://github.com/adriannistor edited https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159292: [driver] Conditionally include installed libc++ headers for Android

smeenai added a comment. In D159292#4632389 , @rprichard wrote: > This change looks like an improvement to me. The NDK currently puts the > libc++ headers into the sysroot, but putting it in the usual toolchain > include location seems better. Are you

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

@@ -0,0 +1,105 @@ +//===--- CppInitClassMembersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai added a comment. Ping. I added the warning and release note. I haven't made search paths be dumped in `-v` mode because I thought it could be pretty noisy (especially since you'll be doing three searches, for resource dir libraries, libc++ per-target headers, and non-resource dir librar

[clang] [AArch64]: Refactor target parser to use BitVector. (PR #65423)

@@ -96,64 +97,65 @@ static_assert(FEAT_MAX <= 64, // Arch extension modifiers for CPUs. These are labelled with their Arm ARM // feature name (though the canonical reference for those is AArch64.td) // clang-format off -enum ArchExtKind : uint64_t { - AEK_NONE =1, - A

[clang] [AArch64]: Refactor target parser to use BitVector. (PR #65423)

hassnaaHamdi wrote: Hi, Thanks for your comments. I think that I have resolved them. Now I'm using Bitset instead of Bitvector, as it has constexpr constructor. Also I dropped splitting the TargetParserTest, and now It's a single test as previous. https://github.com/llvm/llvm-project/pull/65423

[clang] [clang][dataflow] Remove RecordValue.getLog() usage in HTMLLogger (PR #65645)

kinu wrote: @martinboehme @Xazax-hun @ymand if anyone can review this small patch that removes one more dependency on RecordValue.getLoc()... thanks! https://github.com/llvm/llvm-project/pull/65645 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] [AArch64]: Refactor target parser to use BitVector. (PR #65423)

@@ -69,6 +70,24 @@ std::string FormatExtensionFlags(uint64_t Flags) { return llvm::join(Features, ", "); } +std::string SerializeExtensionFlags(Bitset Flags) { + std::string SerializedFlags; + int HexaValue = 0; topperc wrote: Hexa -> Hex. https://githu

[clang] [clang] Make the entire `CompilerInvocation` ref-counted (PR #65647)

https://github.com/benlangmuir approved this pull request. https://github.com/llvm/llvm-project/pull/65647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64]: Refactor target parser to use BitVector. (PR #65423)

@@ -69,6 +70,24 @@ std::string FormatExtensionFlags(uint64_t Flags) { return llvm::join(Features, ", "); } +std::string SerializeExtensionFlags(Bitset Flags) { + std::string SerializedFlags; + int HexaValue = 0; + for(unsigned int i = 0; i < AArch64::AEK_EXTENTIONS_MAX;

[clang] [AArch64]: Refactor target parser to use BitVector. (PR #65423)

@@ -96,64 +97,65 @@ static_assert(FEAT_MAX <= 64, // Arch extension modifiers for CPUs. These are labelled with their Arm ARM // feature name (though the canonical reference for those is AArch64.td) // clang-format off -enum ArchExtKind : uint64_t { - AEK_NONE =1, - A

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

@@ -0,0 +1,32 @@ +.. title:: clang-tidy - google-cpp-init-class-members + +google-cpp-init-class-members += + +Checks that class members are initialized in constructors (implicitly or +explicitly). Reports constructors or classes where class members are

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

https://github.com/adriannistor edited https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:312 + // printing on the left side for readbility. +else if (const VarDecl *VD = dyn_cast(D); + VD && VD->getInit() && erichkeane wrote: > While

[clang] [clang-format] Correctly annotate designated initializer with PP if (PR #65409)

https://github.com/rymiel updated https://github.com/llvm/llvm-project/pull/65409: >From e15868400981600b7dc68229660391a7874e67af Mon Sep 17 00:00:00 2001 From: Emilia Kond Date: Tue, 5 Sep 2023 22:44:41 +0300 Subject: [PATCH 1/2] [clang-format] Correctly annotate designated initializer with P

[clang] [clang][dataflow] Remove RecordValue.getLog() usage in HTMLLogger (PR #65645)

https://github.com/ymand approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/65645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

@@ -121,18 +121,18 @@ static Value *mergeDistinctValues(QualType Type, Value &Val1, Value *MergedVal = nullptr; if (auto *RecordVal1 = dyn_cast(&Val1)) { -[[maybe_unused]] auto *RecordVal2 = cast(&Val2); - -// Values to be merged are always associated with the sam

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/65319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow][NFC] Delete unused function. (PR #65602)

https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/65602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Eliminate `RecordValue::getChild()`. (PR #65586)

https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/65586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159483: [Modules] Add a flag to control builtin headers being in system modules

iana created this revision. iana added reviewers: aaron.ballman, rsmith, efriedma, ldionne, ChuanqiXu, Bigcheese, vsapsai, benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. iana requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald a

[clang] [clang][dataflow] Remove RecordValue.getLog() usage in HTMLLogger (PR #65645)

https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/65645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana updated this revision to Diff 556192. iana added a comment. Rebase on top of D159483 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159064/new/ https://reviews.llvm.org/D159064 Files: clang/lib/Basic/Module

[clang-tools-extra] [MLIR] Enabling Intel GPU Integration. (PR #65539)

Jianhui-Li wrote: > > At some point it would be nice to have some design document or > > documentation somewhere explaining how all these MLIR runners works, > > including this one. > > The idea is to eventually consolidate all runners into one. This PR is just > another piece of the puzzle.

[clang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

Jianhui-Li wrote: > > At some point it would be nice to have some design document or > > documentation somewhere explaining how all these MLIR runners works, > > including this one. > > The idea is to eventually consolidate all runners into one. This PR is just > another piece of the puzzle.

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

@@ -148,6 +148,16 @@ New checks Flags coroutines that suspend while a lock guard is in scope at the suspension point. +- New :doc:`google-cpp-init-class-members + ` check. + + Checks that class members are initialized in constructors (implicitly or adria

[clang] [clang-format] Correctly annotate designated initializer with PP if (PR #65409)

https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/65409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

@@ -0,0 +1,105 @@ +//===--- CppInitClassMembersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

https://github.com/adriannistor resolved https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

https://github.com/adriannistor resolved https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana marked 2 inline comments as done. iana added inline comments. Comment at: clang/lib/Headers/module.modulemap:269 + explicit module wint_t { +header "__stddef_wint_t.h" +export * Arguably this should be textual since stddef.h shouldn't own wint_t and

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

@@ -0,0 +1,105 @@ +//===--- CppInitClassMembersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

https://github.com/adriannistor resolved https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LoongArch] Generate _mcount instead of mcount (PR #65657)

https://github.com/nathanchance review_requested https://github.com/llvm/llvm-project/pull/65657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

https://github.com/adriannistor resolved https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LoongArch] Generate _mcount instead of mcount (PR #65657)

https://github.com/nathanchance created https://github.com/llvm/llvm-project/pull/65657: When building the LoongArch Linux kernel without `CONFIG_DYNAMIC_FTRACE`, the build fails to link because the mcount symbol is `mcount`, not `_mcount` like GCC generates and the kernel expects: ``` ld.lld

[clang] [Clang][LoongArch] Generate _mcount instead of mcount (PR #65657)

https://github.com/nathanchance review_requested https://github.com/llvm/llvm-project/pull/65657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LoongArch] Generate _mcount instead of mcount (PR #65657)

https://github.com/nathanchance review_requested https://github.com/llvm/llvm-project/pull/65657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

@@ -0,0 +1,32 @@ +.. title:: clang-tidy - google-cpp-init-class-members + +google-cpp-init-class-members += + +Checks that class members are initialized in constructors (implicitly or +explicitly). Reports constructors or classes where class members are

[clang] [Clang][LoongArch] Generate _mcount instead of mcount (PR #65657)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

https://github.com/adriannistor resolved https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LoongArch] Generate _mcount instead of mcount (PR #65657)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

https://github.com/adriannistor resolved https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

@@ -0,0 +1,105 @@ +//===--- CppInitClassMembersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

https://github.com/adriannistor resolved https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 80f0dc3 - [clang][dataflow] Unsoundly treat "Unknown" as "Equivalent" in widening.

Author: Yitzhak Mandelbaum Date: 2023-09-07T19:06:35Z New Revision: 80f0dc3aa4bf2097932fb789904c33d985767ecd URL: https://github.com/llvm/llvm-project/commit/80f0dc3aa4bf2097932fb789904c33d985767ecd DIFF: https://github.com/llvm/llvm-project/commit/80f0dc3aa4bf2097932fb789904c33d985767ecd.diff

[PATCH] D159355: [clang][dataflow] Unsoundly treat "Unknown" as "Equivalent" in widening.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80f0dc3aa4bf: [clang][dataflow] Unsoundly treat "Unknown" as "Equivalent" in widening. (authored by ymandel). Repository: rG LLVM Github Monorepo

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

adriannistor wrote: @Xazax-hun @carlosgalvezp @EugeneZelenko @PiotrZSL I addressed all the comments in this PR. Please take a look and let me know what you think! @PiotrZSL @carlosgalvezp , for the [comment regarding the the existing checker](https://github.com/llvm/llvm-project/pull/65189#

[PATCH] D159483: [Modules] Add a flag to control builtin headers being in system modules

iana added a comment. A big assumption this patch makes is that `ModuleMap::isBuiltinHeader` is primarily to support Apple's unfortunate module needs. Thus this patch turns that behavior off by default, which makes things work the way one would expect. That is, when usr/include/module.modulemap

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi updated this revision to Diff 556197. giulianobelinassi added a comment. Fix `dangling-else` compilation warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141714/new/ https://reviews.llvm.org/D141714 Files: clang/include/c

[clang] e9ed1aa - [clang-format] Correctly annotate designated initializer with PP if (#65409)

Author: Emilia Kond Date: 2023-09-07T22:23:05+03:00 New Revision: e9ed1aa9cd867938cd05fe76df57eb505591e81a URL: https://github.com/llvm/llvm-project/commit/e9ed1aa9cd867938cd05fe76df57eb505591e81a DIFF: https://github.com/llvm/llvm-project/commit/e9ed1aa9cd867938cd05fe76df57eb505591e81a.diff L

[clang] [clang-format] Correctly annotate designated initializer with PP if (PR #65409)

https://github.com/rymiel closed https://github.com/llvm/llvm-project/pull/65409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Docs] Document X86 interrupt attribute (PR #65662)

https://github.com/antangelo created https://github.com/llvm/llvm-project/pull/65662: Adds documentation for the X86 `__attribute__((interrupt))` attribute, in a similar format to interrupt attributes of other platforms. >From 96db4e211cabae972fd3dfe476c23c6377b9f5df Mon Sep 17 00:00:00 2001

[clang] [clang][Docs] Document X86 interrupt attribute (PR #65662)

https://github.com/antangelo review_requested https://github.com/llvm/llvm-project/pull/65662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Docs] Document X86 interrupt attribute (PR #65662)

https://github.com/antangelo labeled https://github.com/llvm/llvm-project/pull/65662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Docs] Document X86 interrupt attribute (PR #65662)

https://github.com/antangelo labeled https://github.com/llvm/llvm-project/pull/65662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Docs] Document X86 interrupt attribute (PR #65662)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Docs] Document X86 interrupt attribute (PR #65662)

https://github.com/antangelo review_requested https://github.com/llvm/llvm-project/pull/65662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Docs] Document X86 interrupt attribute (PR #65662)

https://github.com/antangelo review_requested https://github.com/llvm/llvm-project/pull/65662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Docs] Document X86 interrupt attribute (PR #65662)

https://github.com/antangelo edited https://github.com/llvm/llvm-project/pull/65662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Documentation] Replace recommonmark by myst-parser (PR #65664)

https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/65664: This is a bit rough, but i did that while trying to figure out if there would be a good way to do pre commit checks on RsT files. Recommonmark has been deprecated, then archived last year. This was tracked by:

[clang] [Documentation] Replace recommonmark by myst-parser (PR #65664)

https://github.com/cor3ntin review_requested https://github.com/llvm/llvm-project/pull/65664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Documentation] Replace recommonmark by myst-parser (PR #65664)

https://github.com/cor3ntin labeled https://github.com/llvm/llvm-project/pull/65664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Documentation] Replace recommonmark by myst-parser (PR #65664)

https://github.com/cor3ntin review_requested https://github.com/llvm/llvm-project/pull/65664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Documentation] Replace recommonmark by myst-parser (PR #65664)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

https://github.com/adriannistor review_requested https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159483: [Modules] Add a flag to control builtin headers being in system modules

benlangmuir added a comment. > but need to be repeatedly included when they're used in system modules How does this work today? Wouldn't the include guard prevent this? Comment at: clang/include/clang/Basic/Features.def:233 FEATURE(modules, LangOpts.Modules) +FEATURE(builtin_

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

@@ -96,6 +96,21 @@ void JSONNodeDumper::Visit(QualType T) { JOS.attribute("qualifiers", T.split().Quals.getAsString()); } +void JSONNodeDumper::Visit(TypeLoc TL) { + if (TL.isNull()) +return; + JOS.attribute("kind", +(llvm::Twine(TL.getTypeLocClass() ==

[clang] [Clang][LoongArch] Generate _mcount instead of mcount (PR #65657)

nathanchance wrote: cc @xen0n https://github.com/llvm/llvm-project/pull/65657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 62e576b - [clang] Make the entire `CompilerInvocation` ref-counted (#65647)

Author: Jan Svoboda Date: 2023-09-07T13:10:30-07:00 New Revision: 62e576b454e11b06c6f2683d0684cf3302640f45 URL: https://github.com/llvm/llvm-project/commit/62e576b454e11b06c6f2683d0684cf3302640f45 DIFF: https://github.com/llvm/llvm-project/commit/62e576b454e11b06c6f2683d0684cf3302640f45.diff L

[clang] [clang] Make the entire `CompilerInvocation` ref-counted (PR #65647)

https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/65647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/65412: >From 1cf820b6e89b8747ed77bf998e0c0784a23bf851 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 7 Sep 2023 12:54:51 -0700 Subject: [PATCH] [clang] Introduce copy-on-write `CompilerInvocation` --- cla

[PATCH] D151869: [RISCV] Enable more builtin for zvfhmin without zvfh

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151869/new/ https://reviews.llvm.org/D151869 ___

[clang] [Clang][LoongArch] Generate _mcount instead of mcount (PR #65657)

xen0n wrote: also cc @SixWeining (BTW we want to have a GitHub team set up for notifications and assignments apparently) It's 4 am here and I'd take a look after getting some sleep, to ensure review quality ;-) https://github.com/llvm/llvm-project/pull/65657 __

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

https://github.com/jansvoboda11 review_requested https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

https://github.com/benlangmuir commented: This basically LGTM, but could we add some unit tests for the new type? https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

https://github.com/benlangmuir resolved https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

https://github.com/benlangmuir resolved https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

https://github.com/benlangmuir resolved https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

https://github.com/benlangmuir resolved https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

https://github.com/benlangmuir resolved https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

https://github.com/benlangmuir resolved https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

https://github.com/benlangmuir resolved https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

https://github.com/benlangmuir resolved https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

https://github.com/benlangmuir unresolved https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159483: [Modules] Add a flag to control builtin headers being in system modules

iana added inline comments. Comment at: clang/include/clang/Driver/Options.td:2944 [NoXarchOption], [ClangOption, CLOption]>>; +def fbuiltin_headers_in_system_modules : Flag <["-"], "fbuiltin-headers-in-system-modules">, + Group, I don't love this fl

[PATCH] D159483: [Modules] Add a flag to control builtin headers being in system modules

iana added a comment. In D159483#4641231 , @benlangmuir wrote: >> but need to be repeatedly included when they're used in system modules > > How does this work today? Wouldn't the include guard prevent this? Today they don't define their include guard w

[PATCH] D159483: [Modules] Add a flag to control builtin headers being in system modules

iana marked an inline comment as done. iana added inline comments. Comment at: clang/include/clang/Basic/Features.def:233 FEATURE(modules, LangOpts.Modules) +FEATURE(builtin_headers_in_system_modules, LangOpts.BuiltinHeadersInSystemModules) FEATURE(safe_stack, LangOpts.Sanitiz

[clang] 46f3ade - Fix ast print of variables with attributes

Author: Giuliano Belinassi Date: 2023-09-07T13:35:50-07:00 New Revision: 46f3ade5083b8bfce55c78a21086a487eaac6f99 URL: https://github.com/llvm/llvm-project/commit/46f3ade5083b8bfce55c78a21086a487eaac6f99 DIFF: https://github.com/llvm/llvm-project/commit/46f3ade5083b8bfce55c78a21086a487eaac6f99.

[PATCH] D141714: Fix ast print of variables with attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46f3ade5083b: Fix ast print of variables with attributes (authored by giulianobelinassi, committed by erichkeane). Changed prior to commit: https:

[PATCH] D141714: Fix ast print of variables with attributes

erichkeane added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:312 + // printing on the left side for readbility. +else if (const VarDecl *VD = dyn_cast(D); + VD && VD->getInit() && giulianobelinassi wrote: > erichk

[PATCH] D159483: [Modules] Add a flag to control builtin headers being in system modules

benlangmuir added a comment. >> How does this work today? Wouldn't the include guard prevent this? > > Today they don't define their include guard when building with modules. Thanks - I can see some headers behave that way, or in other cases there are other sorts of has_feature(modules) checks t

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/65412: >From dd1c433670028232f172a5372cc325d0c85f9d4f Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 7 Sep 2023 12:54:51 -0700 Subject: [PATCH] [clang] Introduce copy-on-write `CompilerInvocation` When ado

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

https://github.com/jansvoboda11 review_requested https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159483: [Modules] Add a flag to control builtin headers being in system modules

iana marked an inline comment as done. iana added a comment. In D159483#4641289 , @benlangmuir wrote: >>> How does this work today? Wouldn't the include guard prevent this? >> >> Today they don't define their include guard when building with modules. > >

[clang] [libc++] Implement ranges::contains (PR #65148)

https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   6   >