[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/65148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159250: [X86][RFC] Add new option `-m[no-]evex512` to disable ZMM and 64-bit mask instructions for AVX512 features

pengfei added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159250/new/ https://reviews.llvm.org/D159250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang-tools-extra] [clang-tidy] Exclude bitwise operators in bugprone-non-zero-enum-to-bool-conversion (PR #65498)

HerrCai0907 wrote: explicit bit usage will not case false positive without this patch. Should we consider case of operator overloading? ```cpp bool explicitBitUsage1(EStatus value) { return (value & SUCCESS); } bool explicitBitUsage2(EStatus value) { return (value | SUCCESS); } ``` https:/

[PATCH] D158920: Delete CloudABI support

emaste added a comment. In D158920#4620361 , @brad wrote: > Looking for any feedback from the FreeBSD guys. Sorry for no reply earlier, I was away for some of the summer and missed this originally. While CloudABI was a very interesting FreeBSD-related p

[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

lkail added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159167/new/ https://reviews.llvm.org/D159167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D159250: [X86][RFC] Add new option `-m[no-]evex512` to disable ZMM and 64-bit mask instructions for AVX512 features

skan added inline comments. Comment at: llvm/lib/Target/X86/X86Subtarget.cpp:277 + + if (posAVX512F != StringRef::npos && + (posNoAVX512F == StringRef::npos || posNoAVX512F < posAVX512F)) Well. It's a very tricky implementation, but I can find out a better

[PATCH] D159250: [X86][RFC] Add new option `-m[no-]evex512` to disable ZMM and 64-bit mask instructions for AVX512 features

skan accepted this revision. skan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159250/new/ https://reviews.llvm.org/D159250 ___ cfe

[clang-tools-extra] [MLIR] Enabling Intel GPU Integration. (PR #65539)

https://github.com/keryell commented: Quite interesting! At some point it would be nice to have some design document or documentation somewhere explaining how all these MLIR runners works, including this one. Globally this PR add a SYCL runner, but it is very specific for Intel Level 0. It would

[clang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -116,6 +116,7 @@ add_definitions(-DMLIR_ROCM_CONVERSIONS_ENABLED=${MLIR_ENABLE_ROCM_CONVERSIONS}) set(MLIR_ENABLE_CUDA_RUNNER 0 CACHE BOOL "Enable building the mlir CUDA runner") set(MLIR_ENABLE_ROCM_RUNNER 0 CACHE BOOL "Enable building the mlir ROCm runner") +set(MLIR_E

[clang-tools-extra] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -0,0 +1,223 @@ +//===- SyclRuntimeWrappers.cpp - MLIR SYCL wrapper library ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -0,0 +1,223 @@ +//===- SyclRuntimeWrappers.cpp - MLIR SYCL wrapper library ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang-tools-extra] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -0,0 +1,223 @@ +//===- SyclRuntimeWrappers.cpp - MLIR SYCL wrapper library ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -0,0 +1,223 @@ +//===- SyclRuntimeWrappers.cpp - MLIR SYCL wrapper library ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

https://github.com/keryell edited https://github.com/llvm/llvm-project/pull/65539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -0,0 +1,223 @@ +//===- SyclRuntimeWrappers.cpp - MLIR SYCL wrapper library ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang-tools-extra] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -0,0 +1,223 @@ +//===- SyclRuntimeWrappers.cpp - MLIR SYCL wrapper library ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang-tools-extra] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -116,6 +116,7 @@ add_definitions(-DMLIR_ROCM_CONVERSIONS_ENABLED=${MLIR_ENABLE_ROCM_CONVERSIONS}) set(MLIR_ENABLE_CUDA_RUNNER 0 CACHE BOOL "Enable building the mlir CUDA runner") set(MLIR_ENABLE_ROCM_RUNNER 0 CACHE BOOL "Enable building the mlir ROCm runner") +set(MLIR_E

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/65558: Fixed #65055 >From f25a855ac2d3ec4b89f55a08e415596b3b65f142 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 7 Sep 2023 10:14:28 +0800 Subject: [PATCH] [clang-tidy][modernize-use-using]fix function p

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. In D159115#4640154 , @tuliom wrote: > This new test does not work on ppc64le. I'm sorry, by "new" you mean the version with `uintptr_t` or the original as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92733: Fix PR25627 - false positive diagnostics involving implicit-captures in dependent lambda expressions.

faisalv added a comment. In D92733#4638319 , @cor3ntin wrote: > @Fznamznon This might be of interest to you > @faisalv are you still working on this? Yeah - sorry - been a little distracted with other stuff. I tried uploading an updated patch to phabrica

[clang] [APINotes] Support `SwiftImportAs` for C++ structs (PR #65323)

https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/65323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Exclude bitwise operators in bugprone-non-zero-enum-to-bool-conversion (PR #65498)

PiotrZSL wrote: > explicit bit usage will not case false positive without this patch. Should we > consider case of operator overloading? Yes, thats a side effect due to implicit casting enums to integers. I added tests because those were missing, then I implemented version with cxxOverloadCal

[clang-tools-extra] [lit] Are all RUN lines skipped in windows cmd? (PR #65242)

compnerd wrote: I think that might be a bit too accelerated. I work mostly with a fork of LLVM (https://github.com/apple/llvm-project) and do care about the usability of `cmd` as a shell. I think that Swift is a large enough consumer of LLVM to consider testing that before declaring this fea

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

@@ -314,3 +314,10 @@ typedef struct { struct { int a; struct { struct { int b; } c; int d; } e; } f; typedef struct { struct { int a; } b; union { int c; float d; struct { int e; }; }; struct { double f; } g; } PR50990_siblings; // CHECK-MESSAGES: :[[@LINE-1]]:1: warning: use

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

@@ -314,3 +314,10 @@ typedef struct { struct { int a; struct { struct { int b; } c; int d; } e; } f; typedef struct { struct { int a; } b; union { int c; float d; struct { int e; }; }; struct { double f; } g; } PR50990_siblings; // CHECK-MESSAGES: :[[@LINE-1]]:1: warning: use

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

@@ -246,6 +246,9 @@ Changes in existing checks ` check to accurately generate fixes for reordering arguments. +- Improved :doc:`modernize-use-using` PiotrZSL wrote: put space before <, juts for visibility. https://github.com/llvm/llvm-project/pull/65558

[clang] [clang-format] Fix misannotation of && before noexcept (PR #65526)

https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/65526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix misannotation of && before noexcept (PR #65526)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

koops added a comment. Can someone please review the changes that I uploaded last week? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D158715: [Driver] Cleanup last vestiges of Minix / Contiki support

uabelho added inline comments. Comment at: clang/lib/Lex/InitHeaderSearch.cpp:336 - case llvm::Triple::Minix: -AddGnuCPlusPlusIncludePaths("/usr/gnu/include/c++/4.4.3", -"", "", "", triple); brad wrote: > uabelho wrote: > > @b

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

mpaszkowski added a comment. In D155978#4639499 , @Keenuts wrote: > In D155978#4639094 , @mpaszkowski > wrote: > >> @Keenuts Hi Nathan, thanks for the patch! I agree with your approach and I >> think that this s

[clang] c998106 - [Lex] Remove unused AddGnuCPlusPlusIncludePaths after e75f240a0432d827c28a5d77fad26a099ceb7a72

Author: Fangrui Song Date: 2023-09-06T22:25:47-07:00 New Revision: c998106a7fea2b11bee250dd1f92ed4418a08c5a URL: https://github.com/llvm/llvm-project/commit/c998106a7fea2b11bee250dd1f92ed4418a08c5a DIFF: https://github.com/llvm/llvm-project/commit/c998106a7fea2b11bee250dd1f92ed4418a08c5a.diff

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

@@ -314,3 +314,10 @@ typedef struct { struct { int a; struct { struct { int b; } c; int d; } e; } f; typedef struct { struct { int a; } b; union { int c; float d; struct { int e; }; }; struct { double f; } g; } PR50990_siblings; // CHECK-MESSAGES: :[[@LINE-1]]:1: warning: use

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/65558: >From f25a855ac2d3ec4b89f55a08e415596b3b65f142 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 7 Sep 2023 10:14:28 +0800 Subject: [PATCH 1/2] [clang-tidy][modernize-use-using]fix function pointer typ

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/65558: >From f25a855ac2d3ec4b89f55a08e415596b3b65f142 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 7 Sep 2023 10:14:28 +0800 Subject: [PATCH 1/2] [clang-tidy][modernize-use-using]fix function pointer typ

[clang] [clang-format] Correctly annotate designated initializer with PP if (PR #65409)

@@ -626,6 +626,8 @@ void UnwrappedLineParser::calculateBraceTypes(bool ExpectClassBody) { case tok::kw_switch: case tok::kw_try: case tok::kw___try: + if (PrevTok->is(tok::hash)) +break; owenca wrote: This should be applied to `kw_if`

[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159167/new/ https://reviews.llvm.org/D159167 __

[clang] [clang-format] Correctly annotate designated initializer with PP if (PR #65409)

@@ -1998,6 +1998,41 @@ TEST_F(TokenAnnotatorTest, UnderstandsNestedBlocks) { EXPECT_BRACE_KIND(Tokens[10], BK_Block); } +TEST_F(TokenAnnotatorTest, UnderstandDesignatedInitializers) { + auto Tokens = annotate("SomeStruct { .a = 1 };"); + ASSERT_EQ(Tokens.size(), 9u) << Tok

[clang] [clang-format] Correctly annotate designated initializer with PP if (PR #65409)

@@ -1998,6 +1998,41 @@ TEST_F(TokenAnnotatorTest, UnderstandsNestedBlocks) { EXPECT_BRACE_KIND(Tokens[10], BK_Block); } +TEST_F(TokenAnnotatorTest, UnderstandDesignatedInitializers) { + auto Tokens = annotate("SomeStruct { .a = 1 };"); + ASSERT_EQ(Tokens.size(), 9u) << Tok

<    1   2   3   4   5