[clang-tools-extra] [clang-tidy] Exclude bitwise operators in bugprone-non-zero-enum-to-bool-conversion (PR #65498)

2023-09-06 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL review_requested https://github.com/llvm/llvm-project/pull/65498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Exclude bitwise operators in bugprone-non-zero-enum-to-bool-conversion (PR #65498)

2023-09-06 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL review_requested https://github.com/llvm/llvm-project/pull/65498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Exclude bitwise operators in bugprone-non-zero-enum-to-bool-conversion (PR #65498)

2023-09-06 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL created https://github.com/llvm/llvm-project/pull/65498: Improved bugprone-non-zero-enum-to-bool-conversion check by eliminating false positives resulting from direct usage of bitwise operators. >From 79b61b63896a203793bdb0af62c8bee4f676a5c1 Mon Sep 17 00:00:00 2001

[clang-tools-extra] [clang-tidy] Exclude bitwise operators in bugprone-non-zero-enum-to-bool-conversion (PR #65498)

2023-09-06 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL review_requested https://github.com/llvm/llvm-project/pull/65498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [include-cleaner] Always keep non-self-contained files (PR #65499)

2023-09-06 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet created https://github.com/llvm/llvm-project/pull/65499: None From c1f9b400497b78a5283d75da6f7ee0c14320e541 Mon Sep 17 00:00:00 2001 From: Kadir Cetinkaya Date: Wed, 6 Sep 2023 18:42:21 +0200 Subject: [PATCH] [include-cleaner] Always keep non-self-contained files -

[clang-tools-extra] [include-cleaner] Always keep non-self-contained files (PR #65499)

2023-09-06 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet review_requested https://github.com/llvm/llvm-project/pull/65499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [include-cleaner] Always keep non-self-contained files (PR #65499)

2023-09-06 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet review_requested https://github.com/llvm/llvm-project/pull/65499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [include-cleaner] Always keep non-self-contained files (PR #65499)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [include-cleaner] Always keep non-self-contained files (PR #65499)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AArch64] Add --print-supported-extensions support (PR #65466)

2023-09-06 Thread via cfe-commits
https://github.com/DanielKristofKiss edited https://github.com/llvm/llvm-project/pull/65466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AArch64] Add --print-supported-extensions support (PR #65466)

2023-09-06 Thread via cfe-commits
@@ -12,6 +12,7 @@ //===--===// #include "llvm/TargetParser/AArch64TargetParser.h" +#include "llvm/Support/raw_ostream.h" DanielKristofKiss wrote: Did you run clang-format? IIRC this would be

[clang] [clang][AArch64] Add --print-supported-extensions support (PR #65466)

2023-09-06 Thread via cfe-commits
https://github.com/DanielKristofKiss commented: just a NIT, LGTM otherwise. https://github.com/llvm/llvm-project/pull/65466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159355: [clang][dataflow] Unsoundly treat "Unknown" as "Equivalent" in widening.

2023-09-06 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 556051. ymandel added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159355/new/ https://reviews.llvm.org/D159355 Files: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp clang/un

[PATCH] D159355: [clang][dataflow] Unsoundly treat "Unknown" as "Equivalent" in widening.

2023-09-06 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:53 +// +// FIXME: this function is a hook that enable unsoundness in support of +// convergence. Once we have widening support for the ref

[clang] [analyzer] Reduce constraint on modulo with small concrete range (PR #65448)

2023-09-06 Thread Balazs Benics via cfe-commits
https://github.com/steakhal unlabeled https://github.com/llvm/llvm-project/pull/65448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114649: [libc++] Implement not-yet-voted LWG3436

2023-09-06 Thread Louis Dionne via Phabricator via cfe-commits
ldionne abandoned this revision. ldionne added a comment. Herald added a project: All. Abandoning since this LWG issue isn't voted yet and we don't need this to implement other features. I've moved it to https://github.com/ldionne/llvm-project/tree/wip/LWG3436-construct_at-arrays and create a G

[clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #65407)

2023-09-06 Thread Yusra Syeda via cfe-commits
https://github.com/ysyeda updated https://github.com/llvm/llvm-project/pull/65407: >From f7968e42d9c8fae2435dbffe9be46cb4c474fedc Mon Sep 17 00:00:00 2001 From: Yusra Syeda Date: Tue, 5 Sep 2023 15:43:24 -0400 Subject: [PATCH] [SystemZ][z/OS] This change adds support for the PPA2 section in zO

[clang] [clang][deps] Optimize command line generation (PR #65412)

2023-09-06 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/65412: >From e41d54104cff710a9f6744bfcda9962386558b17 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Fri, 1 Sep 2023 15:07:23 -0700 Subject: [PATCH 1/2] [llvm][ADT] Implement `IntrusiveRefCntPtr::useCount()` Th

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

2023-09-06 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

2023-09-06 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

2023-09-06 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: I evicted a couple of commits from this PR in order to work better with the new GitHub PR "squash and merge" workflow. I'll create new PRs for the remaining commits. https://github.com/llvm/llvm-project/pull/65412 ___ cfe-commits

[clang] [clang] Introduce copy-on-write `CompilerInvocation` (PR #65412)

2023-09-06 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/65412: >From 5f8e316a774dbd18cbdf98d507bc6910de3d37d4 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 31 Aug 2023 11:39:32 -0700 Subject: [PATCH] [clang] Introduce copy-on-write `CompilerInvocation` --- cl

[clang] b084d10 - [Driver] Wrap -lgcc_s in -z ignore/-z record on Solaris (#65487)

2023-09-06 Thread via cfe-commits
Author: rorth Date: 2023-09-06T19:44:39+02:00 New Revision: b084d10c2898e4a9da7348cd4774f4fe409fe83c URL: https://github.com/llvm/llvm-project/commit/b084d10c2898e4a9da7348cd4774f4fe409fe83c DIFF: https://github.com/llvm/llvm-project/commit/b084d10c2898e4a9da7348cd4774f4fe409fe83c.diff LOG: [D

[clang] [Driver] Wrap -lgcc_s in -z ignore/-z record on Solaris (PR #65487)

2023-09-06 Thread via cfe-commits
https://github.com/rorth closed https://github.com/llvm/llvm-project/pull/65487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

2023-09-06 Thread Ben Barham via cfe-commits
@@ -179,103 +179,38 @@ static SourceLocation getDeclLocForCommentSearch(const Decl *D, isa(D) || // Allow association with Y across {} in `typedef struct X {} Y`. isa(D)) -return D->getBeginLoc(); +return {D->getBeginLoc()}; bnbarham

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

2023-09-06 Thread Ben Barham via cfe-commits
bnbarham wrote: Thanks for looking into this @daniel-grumberg! https://github.com/llvm/llvm-project/pull/65481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

2023-09-06 Thread Ben Barham via cfe-commits
bnbarham wrote: FWIW @gribozavr the issue here is the hardcoding of the `NS_ENUM`/`NS_OPTIONS` logic, so the idea here is to make that more generic and still handle the comment inside macro case. https://github.com/llvm/llvm-project/pull/65481 ___ cf

[clang] ddbcc10 - [clang] NFCI: Adopt `SourceManager::getFileEntryRefForID()`

2023-09-06 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-09-06T10:49:48-07:00 New Revision: ddbcc10b9e26b18f6a70e23d0611b9da75ffa52f URL: https://github.com/llvm/llvm-project/commit/ddbcc10b9e26b18f6a70e23d0611b9da75ffa52f DIFF: https://github.com/llvm/llvm-project/commit/ddbcc10b9e26b18f6a70e23d0611b9da75ffa52f.diff L

[PATCH] D144136: Add a "remark" to report on array accesses

2023-09-06 Thread Kees Cook via Phabricator via cfe-commits
kees added a comment. Can you refresh this patch to work with https://reviews.llvm.org/D148381 ? My testing seems to imply that it doesn't know the size of the array. I assume the `if (!IsUnboundedArray)` check is incomplete now. i.e. for a `__counted_by` array, I see the "unknown" remark: a

[clang-tools-extra] [include-cleaner] Always keep non-self-contained files (PR #65499)

2023-09-06 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall approved this pull request. Oops, I thought we had this already! https://github.com/llvm/llvm-project/pull/65499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D148381: [Clang] Add counted_by attribute

2023-09-06 Thread Kees Cook via Phabricator via cfe-commits
kees added a comment. I can generate warnings for anonymous structs were the `__counted_by` member is reported as "not found". For example: little.c:7:28: warning: counted_by field 'count' not found 7 | int array[] __counted_by(count); |

[clang] [LTO][CodeGen] Test LTO pipeline choices more thoroughly (PR #65485)

2023-09-06 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. Tests look good https://github.com/llvm/llvm-project/pull/65485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 93f9f63 - [clang-tidy][NFC] Update documentation for fuchsia-statically-constructed-objects

2023-09-06 Thread Piotr Zegar via cfe-commits
Author: Piotr Zegar Date: 2023-09-06T18:06:59Z New Revision: 93f9f63b2d3e04ec4abd79fb8119a685d9f750c6 URL: https://github.com/llvm/llvm-project/commit/93f9f63b2d3e04ec4abd79fb8119a685d9f750c6 DIFF: https://github.com/llvm/llvm-project/commit/93f9f63b2d3e04ec4abd79fb8119a685d9f750c6.diff LOG: [

[PATCH] D151834: Include math-errno with fast-math

2023-09-06 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam updated this revision to Diff 556057. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptions.def clan

[PATCH] D151834: Include math-errno with fast-math

2023-09-06 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam added a comment. @andrew.w.kaylor Would you mind taking a last look at this before I can push this, please? I got the thumbs up from Aaron. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834

[clang] e75ecaa - [clang] NFCI: Use `FileEntryRef` in `CoverageMappingGen`

2023-09-06 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-09-06T11:15:51-07:00 New Revision: e75ecaa190613bb4936be14dfb595fc2736e052e URL: https://github.com/llvm/llvm-project/commit/e75ecaa190613bb4936be14dfb595fc2736e052e DIFF: https://github.com/llvm/llvm-project/commit/e75ecaa190613bb4936be14dfb595fc2736e052e.diff L

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-09-06 Thread Wolfgang Pieb via cfe-commits
https://github.com/wolfy1961 created https://github.com/llvm/llvm-project/pull/65512: As described in issue [#64999](https://github.com/llvm/llvm-project/issues/64999), commit [e018cbf7208](https://github.com/llvm/llvm-project/commit/e018cbf7208b3d34f18997ddee84c66cee32fb1b) caused the symbol

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-09-06 Thread Wolfgang Pieb via cfe-commits
https://github.com/wolfy1961 review_requested https://github.com/llvm/llvm-project/pull/65512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-09-06 Thread Wolfgang Pieb via cfe-commits
https://github.com/wolfy1961 review_requested https://github.com/llvm/llvm-project/pull/65512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-09-06 Thread Wolfgang Pieb via cfe-commits
https://github.com/wolfy1961 review_requested https://github.com/llvm/llvm-project/pull/65512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-09-06 Thread Wolfgang Pieb via cfe-commits
https://github.com/wolfy1961 review_requested https://github.com/llvm/llvm-project/pull/65512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libcxx][libcxxabi][libunwind] Support target-specific flags for tests (PR #65517)

2023-09-06 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson review_requested https://github.com/llvm/llvm-project/pull/65517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libcxx][libcxxabi][libunwind] Support target-specific flags for tests (PR #65517)

2023-09-06 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson review_requested https://github.com/llvm/llvm-project/pull/65517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libcxx][libcxxabi][libunwind] Support target-specific flags for tests (PR #65517)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libcxx][libcxxabi][libunwind] Support target-specific flags for tests (PR #65517)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #65407)

2023-09-06 Thread Yusra Syeda via cfe-commits
https://github.com/ysyeda updated https://github.com/llvm/llvm-project/pull/65407: >From 392fe73436bf4f35163e96d7201bc7f1848d37a6 Mon Sep 17 00:00:00 2001 From: Yusra Syeda Date: Tue, 5 Sep 2023 15:43:24 -0400 Subject: [PATCH] [SystemZ][z/OS] This change adds support for the PPA2 section in zO

[clang] 65331da - Partially revert "[clang] NFCI: Adopt `SourceManager::getFileEntryRefForID()`"

2023-09-06 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-09-06T11:59:40-07:00 New Revision: 65331da0032ab4253a4bc0ddcb2da67664bd86a9 URL: https://github.com/llvm/llvm-project/commit/65331da0032ab4253a4bc0ddcb2da67664bd86a9 DIFF: https://github.com/llvm/llvm-project/commit/65331da0032ab4253a4bc0ddcb2da67664bd86a9.diff L

[clang] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

2023-09-06 Thread Nuri Amari via cfe-commits
https://github.com/NuriAmari review_requested https://github.com/llvm/llvm-project/pull/65179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ec70337 - Correct minimum Visual Studio version requirements

2023-09-06 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2023-09-06T15:18:55-04:00 New Revision: ec70337d136a97d9256125a8867ec75fed531d24 URL: https://github.com/llvm/llvm-project/commit/ec70337d136a97d9256125a8867ec75fed531d24 DIFF: https://github.com/llvm/llvm-project/commit/ec70337d136a97d9256125a8867ec75fed531d24.diff

[clang] [clang-format] Correctly annotate designated initializer with PP if (PR #65409)

2023-09-06 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/65409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix broken dump_format_help.py and sync the RST file (PR #65429)

2023-09-06 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/65429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

2023-09-06 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 556068. cor3ntin added a comment. Inherit from FunctionScopeRAII as per @erichkeane Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159126/new/ https://reviews.llvm.org/D159126 Files: clang/docs/ReleaseNotes.

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

2023-09-06 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:2263 +LocalInstantiationScope &Scope) +: FunctionScope(SemasRef) { + if (!isLambdaCallOperator(FD)) { erichkeane wrote: > cor3ntin wrote: > > erichkeane wrote: > > > Wonder if

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

2023-09-06 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:2263 +LocalInstantiationScope &Scope) +: FunctionScope(SemasRef) { + if (!isLambdaCallOperator(FD)) { cor3ntin wrote: > erichkeane wrote: > > cor3ntin wrote: > > > erichkeane

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

2023-09-06 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. This looks good to me modulo a couple of nits. Comment at: clang/include/clang/Lex/Lexer.h:806-807 /// Try to consume an identifier character encoded in UTF-8.

[PATCH] D159355: [clang][dataflow] Unsoundly treat "Unknown" as "Equivalent" in widening.

2023-09-06 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel marked an inline comment as done. ymandel added a comment. Gabor -- do you want a chance to review (given that it's a non-trivial change to the infrastructure)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159355/new/ https://reviews.llvm

[clang] eaf725b - [Clang] Add captures to the instantiation scope of lambda call operators

2023-09-06 Thread Corentin Jabot via cfe-commits
Author: Corentin Jabot Date: 2023-09-06T21:59:45+02:00 New Revision: eaf725bc9371a6699902d67d97662caaa3332799 URL: https://github.com/llvm/llvm-project/commit/eaf725bc9371a6699902d67d97662caaa3332799 DIFF: https://github.com/llvm/llvm-project/commit/eaf725bc9371a6699902d67d97662caaa3332799.diff

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

2023-09-06 Thread Corentin Jabot via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeaf725bc9371: [Clang] Add captures to the instantiation scope of lambda call operators (authored by cor3ntin). Repository: rG LLVM Github Monorepo

[PATCH] D158561: [-Wunsafe-buffer-usage] Add AST info to the unclaimed DRE debug notes for analysis

2023-09-06 Thread Ziqing Luo via Phabricator via cfe-commits
ziqingluo-90 updated this revision to Diff 556070. ziqingluo-90 added a comment. Add a test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158561/new/ https://reviews.llvm.org/D158561 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-unsafe-buffer-usage-debug-u

[clang] 3b4c150 - Fix the Clang sphinx bot

2023-09-06 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2023-09-06T16:11:23-04:00 New Revision: 3b4c150459d5943c594ad81dba8b2f424d6b3080 URL: https://github.com/llvm/llvm-project/commit/3b4c150459d5943c594ad81dba8b2f424d6b3080 DIFF: https://github.com/llvm/llvm-project/commit/3b4c150459d5943c594ad81dba8b2f424d6b3080.diff

[clang] [clang-format] Fix misannotation of && before noexcept (PR #65526)

2023-09-06 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks created https://github.com/llvm/llvm-project/pull/65526: When we are in an expression, it has to be a binary operator and not pointer of reference. From 7373d5822994616d9fba5d939815c9258d6f9a93 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Sch=C3=A

[PATCH] D148381: [Clang] Add counted_by attribute

2023-09-06 Thread Bill Wendling via Phabricator via cfe-commits
void added a comment. In D148381#4639909 , @kees wrote: > I can generate warnings for anonymous structs were the `__counted_by` member > is reported as "not found". For example: > > little.c:7:28: warning: counted_by field 'count' not found > 7 |

[clang] [clang-format] Fix misannotation of && before noexcept (PR #65526)

2023-09-06 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks review_requested https://github.com/llvm/llvm-project/pull/65526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix misannotation of && before noexcept (PR #65526)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159355: [clang][dataflow] Unsoundly treat "Unknown" as "Equivalent" in widening.

2023-09-06 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added a comment. Sorry for the late review. This looks good to me, but I hope we will be able to undo it soon :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159355/new/ https://reviews.llvm.org/D159355

[clang] 0a9611f - Revert "[clang] NFCI: Adopt `SourceManager::getFileEntryRefForID()`"

2023-09-06 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-09-06T13:23:23-07:00 New Revision: 0a9611fd8d8867ec5f2ad4612f7b9cc7e534efe3 URL: https://github.com/llvm/llvm-project/commit/0a9611fd8d8867ec5f2ad4612f7b9cc7e534efe3 DIFF: https://github.com/llvm/llvm-project/commit/0a9611fd8d8867ec5f2ad4612f7b9cc7e534efe3.diff L

[PATCH] D159355: [clang][dataflow] Unsoundly treat "Unknown" as "Equivalent" in widening.

2023-09-06 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added a comment. In D159355#4640054 , @xazax.hun wrote: > Sorry for the late review. This looks good to me, but I hope we will be able > to undo it soon :) Thanks! Np, and agreed. I think we have a clear path towards dropping the unsoundness al

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

2023-09-06 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 556076. cor3ntin added a comment. Address Tom's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159345/new/ https://reviews.llvm.org/D159345 Files: clang/docs/ReleaseNotes.rst clang/include/clang/L

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

2023-09-06 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann added inline comments. Comment at: clang/test/SemaCXX/static-assert-cxx26.cpp:304 +static_assert('\u{9}' == (char)1, ""); // expected-error {{failed}} \ + // expected-note {{evaluates to ''\t' (0x09, 9) == '' (0x01, 1)'}} +static

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

2023-09-06 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: Tests? https://github.com/llvm/llvm-project/pull/65483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

2023-09-06 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann accepted this revision. tahonermann added a comment. Even better than I asked for. I held back on suggesting the change of `Tok` to `Result` to match `tryConsumeIdentifierUCN()`, but you made that change anyway! You must have read my mind! :) Repository: rG LLVM Github Monorepo

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

2023-09-06 Thread Tulio Magno Quites Machado Filho via Phabricator via cfe-commits
tuliom added a comment. This new test does not work on ppc64le. The returned addresses are different: Expected equality of these values: (uintptr_t)&printf Which is: 140735424286016 Addr->getValue() Which is: 140735424167152 Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

2023-09-06 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/test/SemaCXX/static-assert-cxx26.cpp:304 +static_assert('\u{9}' == (char)1, ""); // expected-error {{failed}} \ + // expected-note {{evaluates to ''\t' (0x09, 9) == '' (0x01, 1)'}} +static_as

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

2023-09-06 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/test/SemaCXX/static-assert.cpp:287 + static_assert((char16_t)L'ゆ' == L"C̵̭̯̠̎͌ͅť̺"[1], ""); // expected-error {{failed}} \ + // expected-note {{evaluates to ''ゆ' (0x3086) == '̵'

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

2023-09-06 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. @hazohelet I'm happy with the patch, I just need to make sure Hubert and I agree! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155610/new/ https://reviews.llvm.org/D155610 ___ cfe-commits mailing list cfe-commits@l

[clang] 776e3b0 - [clang] Add clang support for Machine Function Splitting on AArch64

2023-09-06 Thread Daniel Hoekwater via cfe-commits
Author: Daniel Hoekwater Date: 2023-09-06T20:59:20Z New Revision: 776e3b052738a76518da1f4800a114f3733c35b0 URL: https://github.com/llvm/llvm-project/commit/776e3b052738a76518da1f4800a114f3733c35b0 DIFF: https://github.com/llvm/llvm-project/commit/776e3b052738a76518da1f4800a114f3733c35b0.diff L

[PATCH] D157157: [clang] Add clang support for Machine Function Splitting on AArch64

2023-09-06 Thread Daniel Hoekwater via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG776e3b052738: [clang] Add clang support for Machine Function Splitting on AArch64 (authored by dhoekwater). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-06 Thread via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-06 Thread via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-06 Thread via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-06 Thread via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

2023-09-06 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann added inline comments. Comment at: clang/test/SemaCXX/static-assert-cxx26.cpp:304 +static_assert('\u{9}' == (char)1, ""); // expected-error {{failed}} \ + // expected-note {{evaluates to ''\t' (0x09, 9) == '' (0x01, 1)'}} +static

[clang] 3eb67d2 - [Clang] Handle non-ASCII after line splicing

2023-09-06 Thread Corentin Jabot via cfe-commits
Author: Corentin Jabot Date: 2023-09-06T23:20:00+02:00 New Revision: 3eb67d28dee5c27f5db24a1b370f00a1a2cb456d URL: https://github.com/llvm/llvm-project/commit/3eb67d28dee5c27f5db24a1b370f00a1a2cb456d DIFF: https://github.com/llvm/llvm-project/commit/3eb67d28dee5c27f5db24a1b370f00a1a2cb456d.diff

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

2023-09-06 Thread Corentin Jabot via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3eb67d28dee5: [Clang] Handle non-ASCII after line splicing (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D159345?vs=55

[clang] 508ad37 - [Clang][NFC] Fix sphinx documentation

2023-09-06 Thread Corentin Jabot via cfe-commits
Author: Corentin Jabot Date: 2023-09-06T23:23:19+02:00 New Revision: 508ad3764853f52253a2f9a58da5eb3fba0ebcd7 URL: https://github.com/llvm/llvm-project/commit/508ad3764853f52253a2f9a58da5eb3fba0ebcd7 DIFF: https://github.com/llvm/llvm-project/commit/508ad3764853f52253a2f9a58da5eb3fba0ebcd7.diff

[PATCH] D159474: [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies with auto

2023-09-06 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a reviewer: ributzka. Herald added a project: All. Manna requested review of th

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

2023-09-06 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. In D159345#4640147 , @tahonermann wrote: > Even better than I asked for. I held back on suggesting the change of `Tok` > to `Result` to match `tryConsumeIdentifierUCN()`, but you made that change > anyway! You must have read m

[clang] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-06 Thread via cfe-commits
https://github.com/mgudim review_requested https://github.com/llvm/llvm-project/pull/65535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-06 Thread via cfe-commits
https://github.com/mgudim review_requested https://github.com/llvm/llvm-project/pull/65535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-06 Thread via cfe-commits
https://github.com/mgudim created https://github.com/llvm/llvm-project/pull/65535: None >From 6529eb1ad2a4d5922c8a66d3a11514b5c406eac0 Mon Sep 17 00:00:00 2001 From: Mikhail Gudim Date: Wed, 6 Sep 2023 17:15:56 -0400 Subject: [PATCH] [RISCV] Added definition of Ventana veyron-v1 processor. --

[clang] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-06 Thread via cfe-commits
https://github.com/mgudim review_requested https://github.com/llvm/llvm-project/pull/65535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-06 Thread via cfe-commits
https://github.com/mgudim review_requested https://github.com/llvm/llvm-project/pull/65535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-06 Thread Michael Maitland via cfe-commits
https://github.com/michaelmaitland review_requested https://github.com/llvm/llvm-project/pull/65535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-06 Thread Michael Maitland via cfe-commits
@@ -93,4 +93,4 @@ // RUN: not %clang_cc1 -triple riscv64 -tune-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --check-prefix TUNE-RISCV64 // TUNE-RISCV64: error: unknown target CPU 'not-a-cpu' -// TUNE-RISCV64-NEXT: note: valid target CPU values are: generic-rv64, rocket

<    1   2   3   4   5   >