[clang] [clang-repl] Emit const variables only once (PR #65257)

https://github.com/hahnjo review_requested https://github.com/llvm/llvm-project/pull/65257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AArch64] Define x86_64 macros for ARM64EC targets (PR #65420)

https://github.com/bylaws updated https://github.com/llvm/llvm-project/pull/65420: >From fafb14fd5795e3a2239afdb5e5ff75ffeb126869 Mon Sep 17 00:00:00 2001 From: Billy Laws Date: Tue, 5 Sep 2023 21:56:48 +0100 Subject: [PATCH] [Clang][AArch64] Define x86_64 macros for ARM64EC targets The ARM64E

[clang] [Clang][AArch64] Define x86_64 macros for ARM64EC targets (PR #65420)

https://github.com/bylaws resolved https://github.com/llvm/llvm-project/pull/65420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148381: [Clang] Add counted_by attribute

xbolva00 added a comment. Will gcc use counted_by or element_count ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D159463: [include-cleaner] Map the 4-argument move overload to the algorithm header.

VitaNuo created this revision. Herald added a subscriber: kadircet. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D159463 Fi

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

VitaNuo updated this revision to Diff 556004. VitaNuo marked 5 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156659/new/ https://reviews.llvm.org/D156659 Files: clang-too

[clang-tools-extra] d71adeb - [include-cleaner] Map the 4-argument move overload to the algorithm header.

Author: Viktoriia Bakalova Date: 2023-09-06T11:38:56Z New Revision: d71adebb9fb875a5fd23acdbe0cf0799092fa4ca URL: https://github.com/llvm/llvm-project/commit/d71adebb9fb875a5fd23acdbe0cf0799092fa4ca DIFF: https://github.com/llvm/llvm-project/commit/d71adebb9fb875a5fd23acdbe0cf0799092fa4ca.diff

[PATCH] D159463: [include-cleaner] Map the 4-argument move overload to the algorithm header.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd71adebb9fb8: [include-cleaner] Map the 4-argument move overload to the algorithm header. (authored by VitaNuo). Repository: rG LLVM Github Monore

[clang-tools-extra] [clangd][unittests] Limit paralelism for clangd unittests (PR #65444)

https://github.com/kadircet updated https://github.com/llvm/llvm-project/pull/65444: From 627082183a34c5b497db1c0eb775b8c3d0bbf06b Mon Sep 17 00:00:00 2001 From: Kadir Cetinkaya Date: Tue, 5 Sep 2023 19:19:47 +0200 Subject: [PATCH] [clangd][unittests] Limit paralelism for clangd unittests We s

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

aaron.ballman accepted this revision. aaron.ballman added a subscriber: Endill. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please add a release note because there are user-facing changes regarding what the feature test macros return or what spelli

[PATCH] D157526: [clang][Sema] Remove irrelevant diagnostics from constraint satisfaction failure

hazohelet added a comment. To generate only the necessary diagnostic information, we need to know the evaluation result of the entire constraint expression. So, the ideal way I can think of would be first to evaluate the nodes and, simultaneously, cache the results using `DenseMap` or something,

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 556008. to268 added a comment. This updates fixes the `_Atomic auto` diagnostic, the previous diagnostic was confusing since it was referencing a C++ feature (std::is_trivially_copyable). I have a few diagnostic issues remaining, some parts need to take place a

[clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #65407)

https://github.com/uweigand approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/65407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157615: [ExtendLifetimes][1/4] Add "disable-post-ra" function attribute to disable the post-regalloc scheduler

StephenTozer updated this revision to Diff 556011. StephenTozer added a comment. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. Significant patch updates: Changed attribute from "disable-post-ra" to `optdebug`, following the direction that the discussion on the O

[PATCH] D152246: [clang][ThreadSafety] Analyze known function pointer values

tbaeder added a comment. @aaronpuchert Do you think warning on assignment of function pointers with mismatched attributes is would be a viable way forward? This is what https://github.com/elmarco/clang/commit/bac94282a5c8e3b0410ee8c0522fbdb872ade00c tries to implement IIUC. CHANGES SINCE LAST

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

Keenuts added a comment. In D155978#4639094 , @mpaszkowski wrote: > @Keenuts Hi Nathan, thanks for the patch! I agree with your approach and I > think that this solution despite being a "hack" seems to be the most > straightforward. Eventual difference

[clang] b93d2d3 - [clang][Interp] Handle SourceLocExprs

Author: Timm Bäder Date: 2023-09-06T14:45:49+02:00 New Revision: b93d2d37e70942c951055019428708982b4e8d72 URL: https://github.com/llvm/llvm-project/commit/b93d2d37e70942c951055019428708982b4e8d72 DIFF: https://github.com/llvm/llvm-project/commit/b93d2d37e70942c951055019428708982b4e8d72.diff LO

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb93d2d37e709: [clang][Interp] Handle SourceLocExprs (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang-tools-extra] 73b2c86 - [include-cleaner] Weaken signal for boosting preferred headers

Author: Kadir Cetinkaya Date: 2023-09-06T14:46:33+02:00 New Revision: 73b2c86d95dc510d6972aaa4b44688aebebd89f1 URL: https://github.com/llvm/llvm-project/commit/73b2c86d95dc510d6972aaa4b44688aebebd89f1 DIFF: https://github.com/llvm/llvm-project/commit/73b2c86d95dc510d6972aaa4b44688aebebd89f1.dif

[PATCH] D159441: [include-cleaner] Weaken signal for boosting preferred headers

This revision was automatically updated to reflect the committed changes. Closed by commit rG73b2c86d95dc: [include-cleaner] Weaken signal for boosting preferred headers (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159441/new

[PATCH] D157526: [clang][Sema] Remove irrelevant diagnostics from constraint satisfaction failure

cor3ntin added a comment. Given that we still need to check for substitution errors in untaken branches, this look reasonable (especially as i think you are right that alternative approaches are likely to be more complex) however i think it does require a comment, and I'd like @erichkeane to ha

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

@@ -306,52 +276,79 @@ def main(): run_list = [] line2func_list = collections.defaultdict(list) -subs = { -"%s": ti.path, -"%t": tempfile.NamedTemporaryFile().name, -"%S": os.path.dirname(ti.path), -} +

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

@@ -34,29 +35,22 @@ } -def get_line2func_list(args, clang_args): +def get_line2func_list(clang_cmd: Command): ret = collections.defaultdict(list) # Use clang's JSON AST dump to get the mangled name -json_dump_args = [args.clang] + clang_args + ["-fsyntax-only",

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

@@ -306,52 +276,79 @@ def main(): run_list = [] line2func_list = collections.defaultdict(list) -subs = { -"%s": ti.path, -"%t": tempfile.NamedTemporaryFile().name, -"%S": os.path.dirname(ti.path), -} +

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

@@ -306,52 +276,79 @@ def main(): run_list = [] line2func_list = collections.defaultdict(list) -subs = { -"%s": ti.path, -"%t": tempfile.NamedTemporaryFile().name, -"%S": os.path.dirname(ti.path), -} +

[PATCH] D156045: [clang][Interp] Enable existing source_location tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e5809e7e7bc: [clang][Interp] Enable existing source_location tests (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 7e5809e - [clang][Interp] Enable existing source_location tests

Author: Timm Bäder Date: 2023-09-06T15:05:45+02:00 New Revision: 7e5809e7e7bc9a828427b6540a51d45884d8 URL: https://github.com/llvm/llvm-project/commit/7e5809e7e7bc9a828427b6540a51d45884d8 DIFF: https://github.com/llvm/llvm-project/commit/7e5809e7e7bc9a828427b6540a51d45884d8.diff LO

[clang] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

https://github.com/NuriAmari updated https://github.com/llvm/llvm-project/pull/65179: >From 5d395c85b84e5a554df4b092014d38123e666c6c Mon Sep 17 00:00:00 2001 From: Nuri Amari Date: Tue, 29 Aug 2023 10:10:57 -0700 Subject: [PATCH 1/4] Add flags to dump IR to a file before and after LLVM passes

[clang-tools-extra] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

https://github.com/NuriAmari updated https://github.com/llvm/llvm-project/pull/65179: >From 5d395c85b84e5a554df4b092014d38123e666c6c Mon Sep 17 00:00:00 2001 From: Nuri Amari Date: Tue, 29 Aug 2023 10:10:57 -0700 Subject: [PATCH 1/4] Add flags to dump IR to a file before and after LLVM passes

[PATCH] D151834: Include math-errno with fast-math

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please add a release note describing the changes when you land them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834

[clang] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

@@ -0,0 +1,71 @@ +; RUN: mkdir -p %t/logs +; RUN: rm -rf %t/logs + +; Basic dump before and after a single module pass +; RUN: opt %s -disable-output -passes='no-op-module' -ir-dump-directory %t/logs -dump-after=no-op-module -dump-before=no-op-module +; RUN: find %t/logs -type f

[clang-tools-extra] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

@@ -0,0 +1,71 @@ +; RUN: mkdir -p %t/logs +; RUN: rm -rf %t/logs + +; Basic dump before and after a single module pass +; RUN: opt %s -disable-output -passes='no-op-module' -ir-dump-directory %t/logs -dump-after=no-op-module -dump-before=no-op-module +; RUN: find %t/logs -type f

[clang] 92ac46e - [clang][Interp] Handle CXXParenListInitExprs

Author: Timm Bäder Date: 2023-09-06T15:26:54+02:00 New Revision: 92ac46e703cfa0a5313f83d5c5fa3b298edaa777 URL: https://github.com/llvm/llvm-project/commit/92ac46e703cfa0a5313f83d5c5fa3b298edaa777 DIFF: https://github.com/llvm/llvm-project/commit/92ac46e703cfa0a5313f83d5c5fa3b298edaa777.diff LO

[PATCH] D156047: [clang][Interp] Handle CXXParenListInitExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92ac46e703cf: [clang][Interp] Handle CXXParenListInitExprs (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D156047?vs=544

[clang] 6258912 - [clangd][clang-tidy] Add missing symbols to the symbol map.

Author: Viktoriia Bakalova Date: 2023-09-06T13:42:12Z New Revision: 6258912880876edd44944e130aef01b33480168b URL: https://github.com/llvm/llvm-project/commit/6258912880876edd44944e130aef01b33480168b DIFF: https://github.com/llvm/llvm-project/commit/6258912880876edd44944e130aef01b33480168b.diff

[PATCH] D159462: [clangd][clang-tidy] Add missing symbols to the symbol map.

This revision was automatically updated to reflect the committed changes. Closed by commit rG625891288087: [clangd][clang-tidy] Add missing symbols to the symbol map. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159462/new/ h

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

https://github.com/daniel-grumberg created https://github.com/llvm/llvm-project/pull/65481: For declarations declared inside a macro, e.g.: ``` `#define MAKE_FUNC(suffix) \ /// Not selected doc comment \ void func_##suffix(void) { } /// Doc comment foo MAKE_FUNC(foo) /// Doc

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

https://github.com/daniel-grumberg review_requested https://github.com/llvm/llvm-project/pull/65481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

https://github.com/daniel-grumberg review_requested https://github.com/llvm/llvm-project/pull/65481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

https://github.com/daniel-grumberg review_requested https://github.com/llvm/llvm-project/pull/65481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

daniel-grumberg wrote: This is a follow up on https://reviews.llvm.org/D142560 I couldn't find Dana on here to but in the the reviewer list. Maybe @gribozavr can help locate them? https://github.com/llvm/llvm-project/pull/65481 ___ cfe-commits mailing

[PATCH] D157810: [clang][ExtractAPI] Create extractapi::RecordLocation

dang added a comment. As per https://discourse.llvm.org/t/pull-request-migration-schedule/71595 we should move this review to GitHub to make sure we don't lose track of it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157810/new/ https://reviews.

[PATCH] D158646: [clang-tools-extra][ExtractAPI] create clang-symbolgraph-merger

dang added a comment. As per https://discourse.llvm.org/t/pull-request-migration-schedule/71595 we should move this review to GitHub to make sure we don't lose track of it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158646/new/ https://reviews.llvm.org/D158646 _

[PATCH] D151834: Include math-errno with fast-math

zahiraam updated this revision to Diff 556029. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptions.def clan

[PATCH] D151834: Include math-errno with fast-math

zahiraam added a comment. In D151834#4639536 , @aaron.ballman wrote: > LGTM, but please add a release note describing the changes when you land them. @aaron.ballman thanks for the reviews. Added some note in the RN, let me know if that is enough. CH

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

https://github.com/ajarmusch created https://github.com/llvm/llvm-project/pull/65483: Fix for an issue where clang was not adding the address space according to the data layout, instead was using the default which resulted in a crash at times. The fix includes changes to the cases of LargeCapM

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

https://github.com/ajarmusch review_requested https://github.com/llvm/llvm-project/pull/65483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

https://github.com/ajarmusch labeled https://github.com/llvm/llvm-project/pull/65483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

https://github.com/ajarmusch labeled https://github.com/llvm/llvm-project/pull/65483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

https://github.com/ajarmusch review_requested https://github.com/llvm/llvm-project/pull/65483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

kadircet added a comment. hi @hiraditya , i believe your issues should disappear starting with 9a26d2c6d35f574d7a4b06a5a22f8a1c063cb664 . LMK if you're still facing problems and want to move forward with such a patch CHANGES

[PATCH] D151834: Include math-errno with fast-math

aaron.ballman added a comment. In D151834#4639600 , @zahiraam wrote: > In D151834#4639536 , @aaron.ballman > wrote: > >> LGTM, but please add a release note describing the changes when you land >> them. > > @aar

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

https://github.com/sam-mccall created https://github.com/llvm/llvm-project/pull/65484: The ability to dump AST nodes is important to ad-hoc debugging, and the fact this doesn't work with TypeLoc nodes is an obvious missing feature in e.g. clang-query (`set output dump` simply does nothing). Hav

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

https://github.com/sam-mccall review_requested https://github.com/llvm/llvm-project/pull/65484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

https://github.com/sam-mccall updated https://github.com/llvm/llvm-project/pull/65484: >From f2269d93e313378581085bca418914229316bfc6 Mon Sep 17 00:00:00 2001 From: Sam McCall Date: Mon, 4 Sep 2023 15:48:47 +0200 Subject: [PATCH 1/2] [AST] Add dump() method to TypeLoc The ability to dump AST n

[clang] [LTO][CodeGen] Test LTO pipeline choices more thoroughly (PR #65485)

https://github.com/pogo59 review_requested https://github.com/llvm/llvm-project/pull/65485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LTO][CodeGen] Test LTO pipeline choices more thoroughly (PR #65485)

https://github.com/pogo59 created https://github.com/llvm/llvm-project/pull/65485: The test was looking only for the bitcode writer pass; it should check the full pipeline to make sure the choice is as intended. >From 6f5968e8e17ac4faae27bcaf2132a0df439f4c0f Mon Sep 17 00:00:00 2001 From: Paul

[clang] [LTO][CodeGen] Test LTO pipeline choices more thoroughly (PR #65485)

https://github.com/pogo59 review_requested https://github.com/llvm/llvm-project/pull/65485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LTO][CodeGen] Test LTO pipeline choices more thoroughly (PR #65485)

pogo59 wrote: This came up because Sony makes slightly different choices downstream, and we didn't get it exactly right in all cases. https://github.com/llvm/llvm-project/pull/65485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

@@ -3362,6 +3362,8 @@ Address CGOpenMPRuntimeGPU::getAddressOfLocalVariable(CodeGenFunction &CGF, break; case OMPAllocateDeclAttr::OMPLargeCapMemAlloc: case OMPAllocateDeclAttr::OMPCGroupMemAlloc: + if (VD->hasGlobalStorage()) +AS = getLangASFromTa

[clang] [clang-format] Fix broken dump_format_help.py and sync the RST file (PR #65429)

https://github.com/rymiel approved this pull request. https://github.com/llvm/llvm-project/pull/65429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Wrap -lgcc_s in -z ignore/-z record on Solaris (PR #65487)

https://github.com/rorth review_requested https://github.com/llvm/llvm-project/pull/65487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Wrap -lgcc_s in -z ignore/-z record on Solaris (PR #65487)

https://github.com/rorth created https://github.com/llvm/llvm-project/pull/65487: `clang` currently links `libgcc_s` unconditionally on Solaris, which is unnecessary. This patch wraps it in `-z ignore`/`-z record` instead. Tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`. >From 469

[clang] [Driver] Wrap -lgcc_s in -z ignore/-z record on Solaris (PR #65487)

https://github.com/rorth review_requested https://github.com/llvm/llvm-project/pull/65487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Wrap -lgcc_s in -z ignore/-z record on Solaris (PR #65487)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

@@ -0,0 +1,86 @@ +//===- unittests/AST/ASTDumperTest.cpp --- Test of AST node dump() methods ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

@@ -458,6 +532,9 @@ class ASTNodeTraverser if (Traversal == TK_IgnoreUnlessSpelledInSource && D->isCXXForRangeDecl()) return; +if (VisitLocs) cor3ntin wrote: Is that the only place where `VisitLocs` is used? https://github.com/llvm/llvm-project

[clang] [AST] Add dump() method to TypeLoc (PR #65484)

@@ -223,6 +238,22 @@ void JSONNodeDumper::Visit(const APValue &Value, QualType Ty) { JOS.attribute("value", OS.str()); } +void JSONNodeDumper::Visit(const ConceptReference *CR) { + JOS.attribute("kind", "ConceptReference"); + JOS.attribute("id", createPointerRepresentatio

[clang] Avoid copying Param and Constr (PR #65488)

https://github.com/mauro-balades created https://github.com/llvm/llvm-project/pull/65488: None From 36748679e04ecf52877c01e6dcc8d662349d5b00 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mauro=20Balad=C3=A9s?= Date: Wed, 6 Sep 2023 16:36:12 +0200 Subject: [PATCH] Avoid copying Param and Constr ---

[clang] Avoid copying Param and Constr (PR #65488)

https://github.com/mauro-balades review_requested https://github.com/llvm/llvm-project/pull/65488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix the for statement disappearing in AST when an error occurs in the conditional expression of the for statement (PR #65381)

https://github.com/yronglin review_requested https://github.com/llvm/llvm-project/pull/65381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Always use gas with -fno-integrated-as on Solaris (PR #65489)

https://github.com/rorth review_requested https://github.com/llvm/llvm-project/pull/65489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Always use gas with -fno-integrated-as on Solaris (PR #65489)

https://github.com/rorth created https://github.com/llvm/llvm-project/pull/65489: `clang -fno-integrated-as` doesn't currently work on Solaris: it doesn't even select between 32 and 64-bit objects. Besides, Solaris has both the native assembler (`/usr/bin/as`) and the GNU assembler (`/usr/bin

[clang] [Driver] Always use gas with -fno-integrated-as on Solaris (PR #65489)

https://github.com/rorth review_requested https://github.com/llvm/llvm-project/pull/65489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Always use gas with -fno-integrated-as on Solaris (PR #65489)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin updated this revision to Diff 556035. yronglin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153701/new/ https://reviews.llvm.org/D153701 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.cpp c

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

https://github.com/ajarmusch updated https://github.com/llvm/llvm-project/pull/65483: >From 5a56cffb1e53e8c7415bf468a7edfb464fbc08a0 Mon Sep 17 00:00:00 2001 From: Aaron Jarmusch Date: Wed, 6 Sep 2023 13:56:16 + Subject: [PATCH 1/2] [Clang][OpenMP] Clang adding the addrSpace according to D

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

@@ -3362,6 +3362,8 @@ Address CGOpenMPRuntimeGPU::getAddressOfLocalVariable(CodeGenFunction &CGF, break; case OMPAllocateDeclAttr::OMPLargeCapMemAlloc: case OMPAllocateDeclAttr::OMPCGroupMemAlloc: + if (VD->hasGlobalStorage()) +AS = getLangASFromTa

[PATCH] D158813: [analyzer] MPIChecker: MPI_Waitall should respect count arg

donat.nagy requested changes to this revision. donat.nagy added a comment. This revision now requires changes to proceed. I reviewed this change and collected my suggestions in comments. In general, I feel that the code added by this commit is "sloppy" in the sense that it's designed for the com

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

erichkeane added a comment. 1 suggestion, else LGTM. Comment at: clang/lib/Sema/SemaLambda.cpp:2263 +LocalInstantiationScope &Scope) +: FunctionScope(SemasRef) { + if (!isLambdaCallOperator(FD)) { Wonder if `LambdaScopeForCallOperatorInstantiationR

[PATCH] D159465: Add index test with unconstrained auto.

massberg created this revision. massberg added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without the fix in https://reviews.llvm.org/D15

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:2263 +LocalInstantiationScope &Scope) +: FunctionScope(SemasRef) { + if (!isLambdaCallOperator(FD)) { erichkeane wrote: > Wonder if `LambdaScopeForCallOperatorInstantiationRAII

[clang] [AArch64]: Refactor target parser to use BitVector. (PR #65423)

https://github.com/hassnaaHamdi resolved https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64]: Refactor target parser to use BitVector. (PR #65423)

https://github.com/hassnaaHamdi resolved https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64]: Refactor target parser to use BitVector. (PR #65423)

https://github.com/hassnaaHamdi resolved https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaLambda.cpp:2263 +LocalInstantiationScope &Scope) +: FunctionScope(SemasRef) { + if (!isLambdaCallOperator(FD)) { -

[clang] [AArch64]: Refactor target parser to use BitVector. (PR #65423)

topperc wrote: Does this end up creating a global constructor? Could llvm::Bitset be used instead. It has a constexpr constructor. https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

@@ -34,29 +35,22 @@ } -def get_line2func_list(args, clang_args): +def get_line2func_list(clang_cmd: Command): ret = collections.defaultdict(list) # Use clang's JSON AST dump to get the mangled name -json_dump_args = [args.clang] + clang_args + ["-fsyntax-only",

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

@@ -306,52 +276,79 @@ def main(): run_list = [] line2func_list = collections.defaultdict(list) -subs = { -"%s": ti.path, -"%t": tempfile.NamedTemporaryFile().name, -"%S": os.path.dirname(ti.path), -} +

[clang] [Clang][AArch64] Define x86_64 macros for ARM64EC targets (PR #65420)

efriedma-quic wrote: LGTM https://github.com/llvm/llvm-project/pull/65420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Always use gas with -fno-integrated-as on Solaris (PR #65489)

https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/65489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Always use gas with -fno-integrated-as on Solaris (PR #65489)

https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/65489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Always use gas with -fno-integrated-as on Solaris (PR #65489)

@@ -0,0 +1,11 @@ +/// General tests for assembler invocations on Solaris. + +/// Test that clang uses gas on Solaris. +// RUN: %clang -x assembler %s -### -c -fno-integrated-as \ MaskRay wrote: While here, consider testing `-Wa,` as well, e.g. `-Wa,--compress-de

[clang] [Driver] Wrap -lgcc_s in -z ignore/-z record on Solaris (PR #65487)

https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/65487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Wrap -lgcc_s in -z ignore/-z record on Solaris (PR #65487)

MaskRay wrote: @tstellar Strangely, `pr-subscribers-clang-driver` is not added for this PR. ``` % echo '/clang/*/Driver/' >> .gitignore % git check-ignore -v --no-index clang/lib/Driver/Driver.cpp .gitignore:74:/clang/*/Driver/ clang/lib/Driver/Driver.cpp % git restore .gitignore ``` We can se

[PATCH] D148381: [Clang] Add counted_by attribute

kees added a comment. In D148381#4639436 , @xbolva00 wrote: > Will gcc use counted_by or element_count ? GCC is using `__counted_by`: https://gcc.gnu.org/pipermail/gcc-patches/2023-August/628459.html Repository: rG LLVM Github Monorepo CHANGES SINC

[clang-tools-extra] [clang-tidy] Exclude bitwise operators in bugprone-non-zero-enum-to-bool-conversion (PR #65498)

https://github.com/PiotrZSL labeled https://github.com/llvm/llvm-project/pull/65498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >