[clang] dd27036 - [TableGen] Modernize OverloadInfo (NFC)

2023-09-04 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-09-04T13:35:26-07:00 New Revision: dd27036ff7292c90c4a0e08494579980cfa6922e URL: https://github.com/llvm/llvm-project/commit/dd27036ff7292c90c4a0e08494579980cfa6922e DIFF: https://github.com/llvm/llvm-project/commit/dd27036ff7292c90c4a0e08494579980cfa6922e.diff L

[PATCH] D133361: [BPF] Attribute btf_decl_tag("ctx") for structs

2023-09-04 Thread Alexei Starovoitov via Phabricator via cfe-commits
ast added a comment. In D133361#4637008 , @eddyz87 wrote: > In D133361#4629292 , @ast wrote: > >> ... >> Right. Such recursive propagation of PAI is necessary. For btf_tag we cannot >> do it. Always propagating i

[PATCH] D159284: [clang][dataflow] Fix Record initialization with InitListExpr and inheritances

2023-09-04 Thread Kinuko Yasuda via Phabricator via cfe-commits
kinu updated this revision to Diff 555777. kinu marked 19 inline comments as done. kinu added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159284/new/ https://reviews.llvm.org/D159284 Files: clang/lib/Analysis/Flow

[PATCH] D159284: [clang][dataflow] Fix Record initialization with InitListExpr and inheritances

2023-09-04 Thread Kinuko Yasuda via Phabricator via cfe-commits
kinu added a comment. Thanks! Updated the patch. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:650 + assert(FieldsForInit.size() + R->getNumBases() == Inits.size()); + for ([[maybe_unused]] const CXXBaseSpecifier &Base : R->bases()) { +assert(Init

[PATCH] D158963: [CodeGen] Function multi-versioning: don't set comdat for internal linkage resolvers

2023-09-04 Thread Pavel Iliin via Phabricator via cfe-commits
ilinpv added inline comments. Comment at: clang/docs/ReleaseNotes.rst:208 (`#61334 `_) +- For function multi-versioning using the ``target`` or ``target_clones`` + attributes, remove comdat for internal linkage functions. ---

[clang] [NFC][Clang] Fix test constexpr-function-recovery-crash.cpp (PR #65269)

2023-09-04 Thread via cfe-commits
cor3ntin wrote: This looks correct to me, but I'd like @sam-mccall to confirm that it was unintended. Maybe we should keep the old code around as loops tend to share _some_ code and we don't want `if(!!;;)` to crash either https://github.com/llvm/llvm-project/pull/65269 ___

[clang] [clang-format] modified goto bool to enum (PR #65140)

2023-09-04 Thread via cfe-commits
@@ -2421,20 +2421,28 @@ struct FormatStyle { /// Indent goto labels. /// - /// When ``false``, goto labels are flushed left. /// \code - ///true: false: - ///int f() { vs. int f() { - /// if (foo

[clang] [clang-format] modified goto bool to enum (PR #65140)

2023-09-04 Thread via cfe-commits
@@ -161,7 +171,8 @@ TEST(ConfigParseTest, ParsesConfigurationBools) { CHECK_PARSE_BOOL(IndentAccessModifiers); CHECK_PARSE_BOOL(IndentCaseLabels); CHECK_PARSE_BOOL(IndentCaseBlocks); - CHECK_PARSE_BOOL(IndentGotoLabels); + CHECK_PARSE_ENUM(IndentGotoLabels,

[clang] [clang-format] modified goto bool to enum (PR #65140)

2023-09-04 Thread via cfe-commits
https://github.com/mydeveloperday edited https://github.com/llvm/llvm-project/pull/65140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] modified goto bool to enum (PR #65140)

2023-09-04 Thread via cfe-commits
https://github.com/mydeveloperday edited https://github.com/llvm/llvm-project/pull/65140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] modified goto bool to enum (PR #65140)

2023-09-04 Thread via cfe-commits
https://github.com/mydeveloperday requested changes to this pull request. I’m not sure I quite understand what you are trying to do here now https://github.com/llvm/llvm-project/pull/65140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [clang-format] modified goto bool to enum (PR #65140)

2023-09-04 Thread via cfe-commits
@@ -1199,6 +1199,15 @@ template <> struct DocumentListTraits> { return Seq[Index]; } }; + +template <> struct ScalarEnumerationTraits { + static void enumeration(IO &IO, FormatStyle::GotoLabelIndentation &Value) { +IO.enumCase(Value, "None", FormatStyle::GLI_None);

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

2023-09-04 Thread via cfe-commits
https://github.com/kasuga-fj updated https://github.com/llvm/llvm-project/pull/65246: >From d15196f5148194c5cb2f59c438d06f9fa61c8b4a Mon Sep 17 00:00:00 2001 From: "kasuga.ryotaro" Date: Wed, 30 Aug 2023 13:26:31 +0900 Subject: [PATCH 1/4] [Clang] Fix missing diagnostic for non-standard layout

[PATCH] D159435: [NFC] remove unneded header includes

2023-09-04 Thread Bill Wendling via Phabricator via cfe-commits
void created this revision. void added reviewers: nickdesaulniers, aaron.ballman. Herald added a project: All. void requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: clang. This time from clang/Pa

[PATCH] D159414: Haiku: Fixes for header / library paths

2023-09-04 Thread Brad Smith via Phabricator via cfe-commits
brad updated this revision to Diff 555783. Herald added a subscriber: ormris. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159414/new/ https://reviews.llvm.org/D159414 Files: clang/lib/Driver/ToolChains/Haiku.cpp clang/test/Driver/haiku.c cla

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

2023-09-04 Thread via cfe-commits
kasuga-fj wrote: @metaflow I added an empty commit and the build was triggered, but it still failed. Could you help me? https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D159414: Haiku: Fixes for header / library paths

2023-09-04 Thread Brad Smith via Phabricator via cfe-commits
brad updated this revision to Diff 555785. brad added a comment. Add some C++ header path tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159414/new/ https://reviews.llvm.org/D159414 Files: clang/lib/Driver/ToolChains/Haiku.cpp clang/tes

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

2023-09-04 Thread Félix-Antoine Constantin via Phabricator via cfe-commits
felix642 created this revision. Herald added subscribers: PiotrZSL, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. felix642 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. If a parameter value is eith

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

2023-09-04 Thread Takuya Shimizu via cfe-commits
hazohelet wrote: FWIW, an empty commit didn't trigger CI correctly yesterday, so pushing a non-empty commit might fix the CI issue. https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

2023-09-04 Thread Félix-Antoine Constantin via Phabricator via cfe-commits
felix642 updated this revision to Diff 555788. felix642 added a comment. Added entry to release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159436/new/ https://reviews.llvm.org/D159436 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.h

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

2023-09-04 Thread Félix-Antoine Constantin via Phabricator via cfe-commits
felix642 updated this revision to Diff 555789. felix642 added a comment. Reworded release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159436/new/ https://reviews.llvm.org/D159436 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.h cla

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

2023-09-04 Thread via cfe-commits
kasuga-fj wrote: Ah, thanks. Then what should I do? Can I make another commit with the same content as the last commit and force push? (sorry, I don't fully understand the LLVM's PR rules) https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commi

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

2023-09-04 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/65248: >From eee4c3aee9350be51c9333f284810ffebd9d1663 Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Mon, 4 Sep 2023 16:23:00 +0900 Subject: [PATCH 1/3] [clang][MSExtentions] Fix invalid overload failure about

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

2023-09-04 Thread Takuya Shimizu via cfe-commits
hazohelet wrote: Adding an irrelevant new line in a modified test file would suffice to trigger the CI build. Force-pushing doesn't seem to be desirable during code review. https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list c

[clang] 880f39a - [Clang] Enable AIX initial-exec TLS mode

2023-09-04 Thread Qiu Chaofan via cfe-commits
Author: Qiu Chaofan Date: 2023-09-05T10:57:37+08:00 New Revision: 880f39af6115184ccd1950ff263b7c43993cd438 URL: https://github.com/llvm/llvm-project/commit/880f39af6115184ccd1950ff263b7c43993cd438 DIFF: https://github.com/llvm/llvm-project/commit/880f39af6115184ccd1950ff263b7c43993cd438.diff L

[PATCH] D156076: [PowerPC][Clang] Remove constraint for initial-exec TLS mode on AIX

2023-09-04 Thread Qiu Chaofan via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rG880f39af6115: [Clang] Enable AIX initial-exec TLS mode (authored by qiucf). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D159414: Haiku: Fixes for header / library paths

2023-09-04 Thread Brad Smith via Phabricator via cfe-commits
brad updated this revision to Diff 555794. brad edited the summary of this revision. brad added a comment. Separate out the GCC path handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159414/new/ https://reviews.llvm.org/D159414 Files: clan

[clang] ef5217b - [clang][Diagnostics] Fix wrong line number display (#65238)

2023-09-04 Thread via cfe-commits
Author: Takuya Shimizu Date: 2023-09-05T12:12:42+09:00 New Revision: ef5217b3c0dcbb58927fe43400b6d1faa677bf98 URL: https://github.com/llvm/llvm-project/commit/ef5217b3c0dcbb58927fe43400b6d1faa677bf98 DIFF: https://github.com/llvm/llvm-project/commit/ef5217b3c0dcbb58927fe43400b6d1faa677bf98.diff

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

2023-09-04 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet closed https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ddc8063 - [clang-format] Break long string literals in C#, etc.

2023-09-04 Thread via cfe-commits
Author: sstwcw Date: 2023-09-05T03:19:49Z New Revision: ddc80637ccbc5be26ae40f01841c6019a38d1955 URL: https://github.com/llvm/llvm-project/commit/ddc80637ccbc5be26ae40f01841c6019a38d1955 DIFF: https://github.com/llvm/llvm-project/commit/ddc80637ccbc5be26ae40f01841c6019a38d1955.diff LOG: [clang

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

2023-09-04 Thread sstwcw via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGddc80637ccbc: [clang-format] Break long string literals in C#, etc. (authored by sstwcw). Changed prior to commit: https://reviews.llvm.org/D154093?vs=553729&id=555795#toc Repository: rG LLVM Github

[clang] 082c5d7 - [PowerPC] Implement builtin for mffsl

2023-09-04 Thread Qiu Chaofan via cfe-commits
Author: Qiu Chaofan Date: 2023-09-05T11:22:09+08:00 New Revision: 082c5d7f63c490af69e8280e5b5ff6bf6051bd59 URL: https://github.com/llvm/llvm-project/commit/082c5d7f63c490af69e8280e5b5ff6bf6051bd59 DIFF: https://github.com/llvm/llvm-project/commit/082c5d7f63c490af69e8280e5b5ff6bf6051bd59.diff L

[PATCH] D158065: [PowerPC] Implement builtin for mffsl

2023-09-04 Thread Qiu Chaofan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG082c5d7f63c4: [PowerPC] Implement builtin for mffsl (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158065/new/ https://reviews.llvm.org/

[clang] 1362206 - [clang-format][doc] Fix the doc format

2023-09-04 Thread via cfe-commits
Author: sstwcw Date: 2023-09-05T03:39:24Z New Revision: 1362206e8ad3ec70603d4cdb78d1d4c7b9cb0528 URL: https://github.com/llvm/llvm-project/commit/1362206e8ad3ec70603d4cdb78d1d4c7b9cb0528 DIFF: https://github.com/llvm/llvm-project/commit/1362206e8ad3ec70603d4cdb78d1d4c7b9cb0528.diff LOG: [clang

[clang] [clang-format] modified goto bool to enum (PR #65140)

2023-09-04 Thread Devansh Varshney देवांश वार्ष्णेय via cfe-commits
https://github.com/varshneydevansh resolved https://github.com/llvm/llvm-project/pull/65140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] modified goto bool to enum (PR #65140)

2023-09-04 Thread Devansh Varshney देवांश वार्ष्णेय via cfe-commits
https://github.com/varshneydevansh resolved https://github.com/llvm/llvm-project/pull/65140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] modified goto bool to enum (PR #65140)

2023-09-04 Thread Devansh Varshney देवांश वार्ष्णेय via cfe-commits
https://github.com/varshneydevansh resolved https://github.com/llvm/llvm-project/pull/65140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

2023-09-04 Thread via cfe-commits
https://github.com/kasuga-fj updated https://github.com/llvm/llvm-project/pull/65246: >From d15196f5148194c5cb2f59c438d06f9fa61c8b4a Mon Sep 17 00:00:00 2001 From: "kasuga.ryotaro" Date: Wed, 30 Aug 2023 13:26:31 +0900 Subject: [PATCH 1/5] [Clang] Fix missing diagnostic for non-standard layout

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

2023-09-04 Thread Mikhail Goncharov via cfe-commits
metaflow wrote: alright, build has been triggered successfully! thank you <3 https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159412: [analyzer]FieldRegion in getStaticSize should return size of pointee type

2023-09-04 Thread Qizhi Hu via Phabricator via cfe-commits
jcsxky added a comment. In D159412#4636813 , @donat.nagy wrote: > Please add a testcase that demonstrates this issue (fails when your change in > MemRegion.cpp isn't added) and shows that your commit fixes it. Thanks for your advice. We use this api i

[clang] 0a73e1e - [analyzer][NFC] Use switch statement in MallocChecker::performKernelMalloc

2023-09-04 Thread Brad Smith via cfe-commits
Author: Brad Smith Date: 2023-09-05T01:06:43-04:00 New Revision: 0a73e1eb47ddc87fad51c390b4a8e20019614a08 URL: https://github.com/llvm/llvm-project/commit/0a73e1eb47ddc87fad51c390b4a8e20019614a08 DIFF: https://github.com/llvm/llvm-project/commit/0a73e1eb47ddc87fad51c390b4a8e20019614a08.diff LO

[PATCH] D159397: [analyzer][NFC] Use switch statement in MallocChecker::performKernelMalloc

2023-09-04 Thread Brad Smith via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0a73e1eb47dd: [analyzer][NFC] Use switch statement in MallocChecker::performKernelMalloc (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D158066: [PowerPC] Fix use of FPSCR builtins in smmintrin.h

2023-09-04 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf updated this revision to Diff 555805. qiucf added a comment. - Add macro alias to `mffs` `mffsl` `mtfsf` and `set_fpscr_rn`, although they don't work in freestanding mode - Add C++ run lines to intrinsics tests. To avoid further messing codegen checks, make them run under `-fsyntax-only`.

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

2023-09-04 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:840 -if (S->Scope == "std::" && S->Name == "move") { - if (!S->Signature.contains(',')) -return ""; - return ""; -} - -if (auto StdSym = tooling::stdl

[clang] b50c87d - [clang][dataflow] #llvm #flow-analysis Simplify formula at CNF construction time, and short-cut solving of known contradictory formulas.

2023-09-04 Thread Martin Braenne via cfe-commits
Author: Burak Emir Date: 2023-09-05T06:23:04Z New Revision: b50c87d1e63f187105b5b73f7add37717ccce7f6 URL: https://github.com/llvm/llvm-project/commit/b50c87d1e63f187105b5b73f7add37717ccce7f6 DIFF: https://github.com/llvm/llvm-project/commit/b50c87d1e63f187105b5b73f7add37717ccce7f6.diff LOG: [c

[PATCH] D158407: [clang][dataflow] #llvm #flow-analysis Simplify formula at CNF construction time, and short-cut solving of known contradictory formulas.

2023-09-04 Thread Martin Böhme via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb50c87d1e63f: [clang][dataflow] #llvm #flow-analysis Simplify formula at CNF construction… (authored by burakemir, committed by mboehme). Repositor

[PATCH] D156506: [clang][Interp] Check floating results for NaNs

2023-09-04 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. I thought this review wasn't clear at all on what's supposed to happen but since https://reviews.llvm.org/D157072 is going nowhere, I'll just push this one in the next few days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] [clang][dataflow] Emit an error if source code is not compiled as C++. (PR #65301)

2023-09-04 Thread via cfe-commits
https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/65301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Emit an error if source code is not compiled as C++. (PR #65301)

2023-09-04 Thread via cfe-commits
https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/65301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Emit an error if source code is not compiled as C++. (PR #65301)

2023-09-04 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/65301: The shape of certain elements of the AST can vary depending on the langugage. We currently only support C++. >From fc120d9d9df7cb02008f578219afb6a7d1977b83 Mon Sep 17 00:00:00 2001 From: Martin Braenne Da

[clang] [clang][dataflow] Emit an error if source code is not compiled as C++. (PR #65301)

2023-09-04 Thread via cfe-commits
https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/65301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Emit an error if source code is not compiled as C++. (PR #65301)

2023-09-04 Thread via cfe-commits
https://github.com/martinboehme review_requested https://github.com/llvm/llvm-project/pull/65301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3