[clang-tools-extra] a8c9b9f - [clangd] Support ConceptReference in generic AST wrangling code

Author: Sam McCall Date: 2023-09-04T14:58:25+02:00 New Revision: a8c9b9f1402ccf93955a26d5933cd8c3150c3845 URL: https://github.com/llvm/llvm-project/commit/a8c9b9f1402ccf93955a26d5933cd8c3150c3845 DIFF: https://github.com/llvm/llvm-project/commit/a8c9b9f1402ccf93955a26d5933cd8c3150c3845.diff LO

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

tbaederr wrote: @cor3ntin Yes, I wrote this in the wrong PR :facepalm: https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

tbaederr wrote: Okay, makes sense to me. Should probably also be backported to 17. https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin updated this revision to Diff 555712. cor3ntin added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/ https://reviews.llvm.org/D158591 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Se

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin added a comment. @RIscRIpt I added release notes, let me know if you are happy with everything before i land Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/ https://reviews.llvm.org/D158591 _

[PATCH] D159300: [AST] Support ConceptReference in DynTypedNode, add dump().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda5e11cd1ce0: [AST] Support ConceptReference in DynTypedNode, add dump(). (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D159299: [clangd] Support ConceptReference in generic AST wrangling code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8c9b9f1402c: [clangd] Support ConceptReference in generic AST wrangling code (authored by sammccall). Changed prior to commit: https://reviews.ll

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154262/new/ https://reviews.llvm.org/D154262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] 84643bf - [clang][Sema] Fix a copy/paste bug in ~Sema()

Author: Timm Bäder Date: 2023-09-04T15:32:35+02:00 New Revision: 84643bfa87233a0907481fa948b34d25795bb841 URL: https://github.com/llvm/llvm-project/commit/84643bfa87233a0907481fa948b34d25795bb841 DIFF: https://github.com/llvm/llvm-project/commit/84643bfa87233a0907481fa948b34d25795bb841.diff LO

[PATCH] D158361: [clang][Sema] Fix a copy/paste bug in ~Sema()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG84643bfa8723: [clang][Sema] Fix a copy/paste bug in ~Sema() (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1900721 - [clang][Interp][NFC] Check some emit* calls for errors

Author: Timm Bäder Date: 2023-09-04T15:42:33+02:00 New Revision: 1900721ae756d6750aaa98f3f4c7fd96dd74e056 URL: https://github.com/llvm/llvm-project/commit/1900721ae756d6750aaa98f3f4c7fd96dd74e056 DIFF: https://github.com/llvm/llvm-project/commit/1900721ae756d6750aaa98f3f4c7fd96dd74e056.diff LO

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

Keenuts updated this revision to Diff 555745. Keenuts added a comment. Changed the pointer size to 32 bit to 64 bits. So far, I haven't see any codegen difference, as logical pointers do not have a fixed size (driver will set it). However, in case of a raw buffer load (Vulkan extension), with the

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

cor3ntin wrote: could you upload a dummy change to trigger the build? Thanks! https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ac56556 - [clang][Interp][NFC] Rename a parameter

Author: Timm Bäder Date: 2023-09-04T15:44:09+02:00 New Revision: ac56556047bbbdf9d3991c40835e4b7b7ce513ad URL: https://github.com/llvm/llvm-project/commit/ac56556047bbbdf9d3991c40835e4b7b7ce513ad DIFF: https://github.com/llvm/llvm-project/commit/ac56556047bbbdf9d3991c40835e4b7b7ce513ad.diff LO

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin added a comment. ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153701/new/ https://reviews.llvm.org/D153701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D159086: Change begin of macro in translateSourceRange in libclang

quic-cbusold abandoned this revision. quic-cbusold added a comment. This does not work. Need more debugging on my end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159086/new/ https://reviews.llvm.org/D159086 _

[clang] bb94817 - [clang][NFC] Remove stray slash

Author: Timm Bäder Date: 2023-09-04T16:12:30+02:00 New Revision: bb94817ecfc5ca7de7a453eec5ad17c9781e24ed URL: https://github.com/llvm/llvm-project/commit/bb94817ecfc5ca7de7a453eec5ad17c9781e24ed DIFF: https://github.com/llvm/llvm-project/commit/bb94817ecfc5ca7de7a453eec5ad17c9781e24ed.diff LO

[PATCH] D159398: [AArch64][Clang] Disable outline atomics in freestanding env

ilinpv added a comment. Outline atomics are dependent on runtime library availability ( libgcc or compler-rt ). If there are no proper library available they will be disabled. So if in freestanding mode compiler is not dependent on runtime library you can remove it and get rid of outline atomic

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

serge-sans-paille added a comment. In D156337#4558410 , @aaron.ballman wrote: > Was there an RFC for this extension to the attribute? (There doesn't need to > be one, I'm just wondering if there's more background info on what's driving > this patch for

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt added a comment. Looks good. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/ https://reviews.llvm.org/D158591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [GlobalISel][AArch64] Combine unmerge(G_EXT v, undef) to unmerge(v). (PR #65263)

https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/65263: >From 6f762b1eb8ad944be81fb237da10110e282d45fe Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Mon, 4 Sep 2023 12:35:48 +0200 Subject: [PATCH] [GlobalISel][AArch64] Combine unmerge(G_EXT v, undef) t

[PATCH] D159398: [AArch64][Clang] Disable outline atomics in freestanding env

yota9 added a comment. >> Outline atomics are dependent on runtime library availability ( libgcc or >> compler-rt ). I understand that, but we can use compiler that have runtime library, but in freestanding mode usually we don't want it to be used. I understand that you could disable it with e

[clang-tools-extra] [mlir][OpenMP] Added omp.region operation (PR #65243)

shraiysh wrote: `internal_region` sounds good. I did not want to make it highly specific, because it could be used under other constructs too. Like, `omp.sections` could have an internal region and a barrier in the future. We do not need it for others at the moment, but not making it highly sp

[clang] [mlir][OpenMP] Added omp.region operation (PR #65243)

shraiysh wrote: `internal_region` sounds good. I did not want to make it highly specific, because it could be used under other constructs too. Like, `omp.sections` could have an internal region and a barrier in the future. We do not need it for others at the moment, but not making it highly sp

[clang] e6d305e - Add support of Windows Trace Logging macros

Author: Richard Dzenis Date: 2023-09-04T16:54:42+02:00 New Revision: e6d305e64fd39f0199b79d19dbc0d012efd83259 URL: https://github.com/llvm/llvm-project/commit/e6d305e64fd39f0199b79d19dbc0d012efd83259 DIFF: https://github.com/llvm/llvm-project/commit/e6d305e64fd39f0199b79d19dbc0d012efd83259.diff

[PATCH] D158591: Add support of Windows Trace Logging macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6d305e64fd3: Add support of Windows Trace Logging macros (authored by RIscRIpt, committed by cor3ntin). Changed prior to commit: https://reviews.

[clang] [AST] Fix nested name specifiers printing as NamespaceNamespace (PR #65266)

https://github.com/sam-mccall created https://github.com/llvm/llvm-project/pull/65266: This happens because we print both the kind of the NNS and the kind of decl (when it refers to one). These are always the same string. >From 0f32300def7e8bdbac3612f2e26a623629d308b7 Mon Sep 17 00:00:00 2001

[clang] [AST] Fix nested name specifiers printing as NamespaceNamespace (PR #65266)

https://github.com/sam-mccall review_requested https://github.com/llvm/llvm-project/pull/65266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159284: [clang][dataflow] Fix Record initialization with InitListExpr and inheritances

mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:632-635 +// For type comparison assertions. +[[maybe_unused]] auto GetCanonicalType = [](QualType Ty) { +return Ty.getCanonicalType().getUnqualifiedType(); +}; ---

[clang] [AST] Fix nested name specifiers printing as NamespaceNamespace (PR #65266)

https://github.com/sam-mccall review_requested https://github.com/llvm/llvm-project/pull/65266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/MaggieYingYi created https://github.com/llvm/llvm-project/pull/65268: When profiling code using `-ftime-trace` with the default `time-trace-granularity` value (500 microseconds), in some code there is a large empty timeline in the flame chart profiling view (using Chrome Tra

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/MaggieYingYi review_requested https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/MaggieYingYi review_requested https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Fix test constexpr-function-recovery-crash.cpp (PR #65269)

https://github.com/yronglin review_requested https://github.com/llvm/llvm-project/pull/65269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Fix test constexpr-function-recovery-crash.cpp (PR #65269)

https://github.com/yronglin review_requested https://github.com/llvm/llvm-project/pull/65269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/MaggieYingYi review_requested https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Fix test constexpr-function-recovery-crash.cpp (PR #65269)

https://github.com/yronglin created https://github.com/llvm/llvm-project/pull/65269: None >From 1c157a6c9fb7a98dc2a2509dcbc9f82b0ce69244 Mon Sep 17 00:00:00 2001 From: yronglin Date: Mon, 4 Sep 2023 23:06:09 +0800 Subject: [PATCH] [NFC][Clang] Fix test constexpr-function-recovery-crash.cpp Si

[clang] [NFC][Clang] Fix test constexpr-function-recovery-crash.cpp (PR #65269)

https://github.com/yronglin review_requested https://github.com/llvm/llvm-project/pull/65269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Fix test constexpr-function-recovery-crash.cpp (PR #65269)

@@ -99,6 +99,10 @@ TEST_EVALUATE(DoWhileCond, do {} while (some_cond < 10);); // expected-error // expected-error {{constexpr variable 'forceEvaluateDoWhileCond' must be initialized by a constant expression}} TE

[PATCH] D159398: [AArch64][Clang] Disable outline atomics in freestanding env

ilinpv added a comment. > I understand that you could disable it with extra option and that for now it > would be different with gcc, but it looks debatable to me that such a > behaviour in gcc is correct and expected, maybe someone need to change it > there too. (Please keep in mind that I mig

[clang] [AST] Fix nested name specifiers printing as NamespaceNamespace (PR #65266)

https://github.com/philnik777 labeled https://github.com/llvm/llvm-project/pull/65266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Fix test constexpr-function-recovery-crash.cpp (PR #65269)

https://github.com/philnik777 labeled https://github.com/llvm/llvm-project/pull/65269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159398: [AArch64][Clang] Disable outline atomics in freestanding env

yota9 added a comment. Great! I've add MaskRay to the reviewers list as known expert in both clang and gcc, maybe he have some thoughts on this proposal :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159398/new/ https://reviews.llvm.org/D159398

[clang] [NFC][Clang] Fix test constexpr-function-recovery-crash.cpp (PR #65269)

https://github.com/yronglin labeled https://github.com/llvm/llvm-project/pull/65269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/compnerd resolved https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

@@ -19,11 +19,11 @@ namespace clang { namespace api_notes { -class APINotesWriter::Implementation { - template - using VersionedSmallVector = - llvm::SmallVector, 1>; +template +using VersionedSmallVector = +llvm::SmallVector, 1>; compnerd wrote:

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/compnerd resolved https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/compnerd resolved https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/compnerd resolved https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155064/new/ https://reviews.llvm.org/D155064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/65238: >From 2bc13f3b013a4bda4364e9c29bc792ca6a0c7cf1 Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Mon, 4 Sep 2023 10:46:17 +0900 Subject: [PATCH 1/2] [clang][Diagnostics] Fix wrong line number display When t

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/65238: >From 2bc13f3b013a4bda4364e9c29bc792ca6a0c7cf1 Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Mon, 4 Sep 2023 10:46:17 +0900 Subject: [PATCH 1/3] [clang][Diagnostics] Fix wrong line number display When t

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/65248: >From eee4c3aee9350be51c9333f284810ffebd9d1663 Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Mon, 4 Sep 2023 16:23:00 +0900 Subject: [PATCH 1/2] [clang][MSExtentions] Fix invalid overload failure about

[clang] [AST] Fix nested name specifiers printing as NamespaceNamespace (PR #65266)

https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/65266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Fix nested name specifiers printing as NamespaceNamespace (PR #65266)

https://github.com/cor3ntin approved this pull request. LGTM modulo one nitpick https://github.com/llvm/llvm-project/pull/65266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Fix nested name specifiers printing as NamespaceNamespace (PR #65266)

@@ -16,6 +16,7 @@ #include "clang/AST/DeclOpenMP.h" #include "clang/AST/DeclTemplate.h" #include "clang/AST/LocInfoType.h" +#include "clang/AST/NestedNameSpecifier.h" cor3ntin wrote: That does not seem necessary https://github.com/llvm/llvm-project/pull/65266

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

cor3ntin wrote: Looks good to me but can you add a release note? This was landed before RC1 and I'm not sure it qualifies for a backport at this stage (@AaronBallman @tru) https://github.com/llvm/llvm-project/pull/65248 ___ cfe-commits mailing list cf

[clang] [clang-format] modified goto bool to enum (PR #65140)

https://github.com/varshneydevansh updated https://github.com/llvm/llvm-project/pull/65140: >From be006b494c4e34463818a7f1fd30cde9282fcea1 Mon Sep 17 00:00:00 2001 From: varshneydevansh Date: Thu, 31 Aug 2023 17:27:58 +0530 Subject: [PATCH 1/2] [clang] modified goto bool to enum --- clang/doc

[clang] [clang-format] modified goto bool to enum (PR #65140)

https://github.com/varshneydevansh review_requested https://github.com/llvm/llvm-project/pull/65140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] modified goto bool to enum (PR #65140)

https://github.com/varshneydevansh review_requested https://github.com/llvm/llvm-project/pull/65140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] modified goto bool to enum (PR #65140)

@@ -2432,9 +2431,25 @@ struct FormatStyle { ///label2:label2: /// return 1; return 1; ///} } + /// + ///GLI_HalfIndent: + ///int f() { + /// if

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/egorzhdan edited https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/egorzhdan updated https://github.com/llvm/llvm-project/pull/65187: >From a553de6bbcc96f0bbd94859defcb64f2c6dfa0f5 Mon Sep 17 00:00:00 2001 From: Egor Zhdan Date: Fri, 1 Sep 2023 22:07:47 +0100 Subject: [PATCH] [APINotes] Upstream APINotesWriter This upstreams more of the Cla

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

@@ -19,11 +19,11 @@ namespace clang { namespace api_notes { -class APINotesWriter::Implementation { - template - using VersionedSmallVector = - llvm::SmallVector, 1>; +template +using VersionedSmallVector = +llvm::SmallVector, 1>; egorzhdan wrote:

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

@@ -33,6 +33,7 @@ class APINotesWriter::Implementation { /// Mapping from strings to identifier IDs. llvm::StringMap IdentifierIDs; +public: egorzhdan wrote: Reverted this part of the change by making `APINotesWriter` a friend class of `Implementation`

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

Mordante added a comment. Herald added subscribers: bviyer, jplehr. For libc++ we like to clean up the review queue for the GitHub PR transition. Is there still interest on working on this patch? If so would it be possible to finish it before the Phabricator is changed to read only mode? CHANG

[clang] [clang][doc] Don't escape _ in .rst files. (PR #65277)

https://github.com/mordante review_requested https://github.com/llvm/llvm-project/pull/65277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][doc] Don't escape _ in .rst files. (PR #65277)

https://github.com/mordante labeled https://github.com/llvm/llvm-project/pull/65277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

https://github.com/cor3ntin approved this pull request. LGTM, thanks https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Emit const variables only once (PR #65257)

https://github.com/vgvassilev approved this pull request. That looks good to me. Can we backport that to the llvm17 release branch? I know at least one downstream project that jumps through hoops to support this. https://github.com/llvm/llvm-project/pull/65257 __

[clang-tools-extra] d03a7f1 - [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

Author: Ivan Murashko Date: 2023-09-04T18:53:49+01:00 New Revision: d03a7f15f019beb1896872ba9321cfed5f16a05f URL: https://github.com/llvm/llvm-project/commit/d03a7f15f019beb1896872ba9321cfed5f16a05f DIFF: https://github.com/llvm/llvm-project/commit/d03a7f15f019beb1896872ba9321cfed5f16a05f.diff

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

This revision was automatically updated to reflect the committed changes. Closed by commit rGd03a7f15f019: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free (authored by ivanmurashko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159

[PATCH] D157072: [clang][ExprConst] Check float operation input for signaling NaNs

sepavloff added inline comments. Comment at: clang/test/CXX/expr/expr.const/p2-0x.cpp:281-283 +constexpr float f10 = f2 - f2; +constexpr float f11 = f2 + f4; +constexpr float f12 = f2 / f2; I don't think silent NaN origination is a right behavior. By

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

@@ -105,6 +110,40 @@ class APINotesWriter::Implementation { llvm::SmallVector, 1>> Typedefs; + /// Retrieve the ID for the given identifier. + IdentifierID getIdentifier(StringRef Identifier) { +if (Identifier.empty()) + return 0; + +auto

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/compnerd approved this pull request. Would appreciate the removal of the noted unnecessary braces, but LGTM. https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/compnerd resolved https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/compnerd edited https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/compnerd resolved https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] modified goto bool to enum (PR #65140)

https://github.com/varshneydevansh updated https://github.com/llvm/llvm-project/pull/65140: >From be006b494c4e34463818a7f1fd30cde9282fcea1 Mon Sep 17 00:00:00 2001 From: varshneydevansh Date: Thu, 31 Aug 2023 17:27:58 +0530 Subject: [PATCH 1/3] [clang] modified goto bool to enum --- clang/doc

[PATCH] D159397: [StaticAnalyzer] Use switch statement in MallocChecker::performKernelMalloc. NFC

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. It doesn't look much of an improvement TBH, but I won't stand against it either. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159397/ne

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/egorzhdan updated https://github.com/llvm/llvm-project/pull/65187: >From a3e72323513a5ac102abb6c28ae4071955cc2373 Mon Sep 17 00:00:00 2001 From: Egor Zhdan Date: Fri, 1 Sep 2023 22:07:47 +0100 Subject: [PATCH] [APINotes] Upstream APINotesWriter This upstreams more of the Cla

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

@@ -105,6 +110,40 @@ class APINotesWriter::Implementation { llvm::SmallVector, 1>> Typedefs; + /// Retrieve the ID for the given identifier. + IdentifierID getIdentifier(StringRef Identifier) { +if (Identifier.empty()) + return 0; + +auto

[PATCH] D159398: [AArch64][Clang] Disable outline atomics in freestanding env

yota9 added a comment. Also please keep in mind that despite of different behaviour in gcc/clang not implying outline atomics won't result in any problems, but implying them in cases where we don't want them might result in some problems. Offtopic: Outlining atomics seems to be very CPU specifi

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

https://github.com/egorzhdan closed https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8dc789a - [APINotes] Upstream APINotesWriter

Author: Egor Zhdan Date: 2023-09-04T19:45:55+01:00 New Revision: 8dc789a22666f9b9fdde54fda23c9332dbc1db9b URL: https://github.com/llvm/llvm-project/commit/8dc789a22666f9b9fdde54fda23c9332dbc1db9b DIFF: https://github.com/llvm/llvm-project/commit/8dc789a22666f9b9fdde54fda23c9332dbc1db9b.diff LO

[PATCH] D159398: [AArch64][Clang] Disable outline atomics in freestanding env

ilinpv added a comment. > Offtopic: Outlining atomics seems to be very CPU specific thing. In my > experience LSE were ~= old exclusive semantics. So adding extra call + extra > bit check (too bad IFUNCs are not used :)) each time it would be executed > seems to be quite an extra load (for CPU,

[clang] [clang-format] modified goto bool to enum (PR #65140)

@@ -2432,9 +2431,25 @@ struct FormatStyle { ///label2:label2: /// return 1; return 1; ///} } + /// + ///GLI_HalfIndent: + ///int f() { + /// if

[clang] [clang-format] modified goto bool to enum (PR #65140)

https://github.com/HazardyKnusperkeks requested changes to this pull request. Do you actually want to use that feature, or do you only want to work on something? Please take a greater look on how enums are documented, parsed, and tested. A fairly recent example which transitioned from `bool` w

[clang] [clang-format] modified goto bool to enum (PR #65140)

@@ -161,7 +171,8 @@ TEST(ConfigParseTest, ParsesConfigurationBools) { CHECK_PARSE_BOOL(IndentAccessModifiers); CHECK_PARSE_BOOL(IndentCaseLabels); CHECK_PARSE_BOOL(IndentCaseBlocks); - CHECK_PARSE_BOOL(IndentGotoLabels); + CHECK_PARSE_ENUM(IndentGotoLabels,

[clang] [clang-format] modified goto bool to enum (PR #65140)

https://github.com/HazardyKnusperkeks edited https://github.com/llvm/llvm-project/pull/65140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] modified goto bool to enum (PR #65140)

@@ -2421,20 +2421,28 @@ struct FormatStyle { /// Indent goto labels. /// - /// When ``false``, goto labels are flushed left. /// \code - ///true: false: - ///int f() { vs. int f() { - /// if (foo

[clang] [clang-format] modified goto bool to enum (PR #65140)

@@ -3311,22 +3311,22 @@ the configuration (without a prefix: ``Auto``). .. _IndentGotoLabels: -**IndentGotoLabels** (``Boolean``) :versionbadge:`clang-format 10` :ref:`¶ ` +**IndentGotoLabels** (``enum``) :versionbadge:`clang-format 10` :ref:`¶ ` Indent goto labels. -

[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexAll()

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158415/new/ https://reviews.llvm.org/D158415

[clang] [clang-format] modified goto bool to enum (PR #65140)

@@ -3311,22 +3311,22 @@ the configuration (without a prefix: ``Auto``). .. _IndentGotoLabels: -**IndentGotoLabels** (``Boolean``) :versionbadge:`clang-format 10` :ref:`¶ ` +**IndentGotoLabels** (``enum``) :versionbadge:`clang-format 10` :ref:`¶ ` Indent goto labels. -

[clang] [clang-format] modified goto bool to enum (PR #65140)

@@ -161,7 +171,8 @@ TEST(ConfigParseTest, ParsesConfigurationBools) { CHECK_PARSE_BOOL(IndentAccessModifiers); CHECK_PARSE_BOOL(IndentCaseLabels); CHECK_PARSE_BOOL(IndentCaseBlocks); - CHECK_PARSE_BOOL(IndentGotoLabels); + CHECK_PARSE_ENUM(IndentGotoLabels,

[clang] [clang-format] modified goto bool to enum (PR #65140)

@@ -2421,20 +2421,28 @@ struct FormatStyle { /// Indent goto labels. /// - /// When ``false``, goto labels are flushed left. /// \code - ///true: false: - ///int f() { vs. int f() { - /// if (foo

[clang] [clang-format] modified goto bool to enum (PR #65140)

varshneydevansh wrote: > Do you actually want to use that feature, or do you only want to work on > something? > As it's something of my past pending task, I'm looking to learn and contribute in any way I can. I left without even trying to contribute to open source codes. =) https://gith

[clang] [clang-format] modified goto bool to enum (PR #65140)

@@ -3311,22 +3311,22 @@ the configuration (without a prefix: ``Auto``). .. _IndentGotoLabels: -**IndentGotoLabels** (``Boolean``) :versionbadge:`clang-format 10` :ref:`¶ ` +**IndentGotoLabels** (``enum``) :versionbadge:`clang-format 10` :ref:`¶ ` Indent goto labels. -

[clang] 232d29e - [TableGen] Modernize GroupInfo (NFC)

Author: Kazu Hirata Date: 2023-09-04T13:35:23-07:00 New Revision: 232d29ea0bd30ae94c76d48700fa2774b929e984 URL: https://github.com/llvm/llvm-project/commit/232d29ea0bd30ae94c76d48700fa2774b929e984 DIFF: https://github.com/llvm/llvm-project/commit/232d29ea0bd30ae94c76d48700fa2774b929e984.diff L

[clang] 77604d2 - [StaticAnalyzer] Modernize ObjCNonNilReturnValueChecker (NFC)

Author: Kazu Hirata Date: 2023-09-04T13:35:25-07:00 New Revision: 77604d2a845217cb6d793530c4819dc63bfd61d3 URL: https://github.com/llvm/llvm-project/commit/77604d2a845217cb6d793530c4819dc63bfd61d3 DIFF: https://github.com/llvm/llvm-project/commit/77604d2a845217cb6d793530c4819dc63bfd61d3.diff L

<    1   2   3   >