[PATCH] D159250: [X86][RFC] Add new option `-m[no-]evex512` to disable ZMM and 64-bit mask instructions for AVX512 features

pengfei added inline comments. Comment at: clang/lib/CodeGen/Targets/X86.cpp:1517 + bool Caller256 = CallerMap.lookup("avx512f") && !CallerMap.lookup("evex512"); + bool Callee256 = CallerMap.lookup("avx512f") && !CallerMap.lookup("evex512"); + RKSimon wrote: >

[PATCH] D159279: [clang] Emit `Wformat` for bool value and char specifier confusion in scanf

Fznamznon updated this revision to Diff 555289. Fznamznon added a comment. Rebase to maybe pass precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159279/new/ https://reviews.llvm.org/D159279 Files: clang/docs/ReleaseNotes.rst clang/lib/A

[clang] 2fd01d7 - [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

Author: Younan Zhang Date: 2023-09-01T15:49:39+08:00 New Revision: 2fd01d75a863184766ee0c82b5c0fc8be172448a URL: https://github.com/llvm/llvm-project/commit/2fd01d75a863184766ee0c82b5c0fc8be172448a DIFF: https://github.com/llvm/llvm-project/commit/2fd01d75a863184766ee0c82b5c0fc8be172448a.diff

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

This revision was automatically updated to reflect the committed changes. Closed by commit rG2fd01d75a863: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D159174: [Clang] Use stable_sort in AppendTargetMangling

dmgreen added a comment. Do you have a test-case where they were out of order? Or is that dependent on the C++ library? I think I just moved this code from elsewhere when I changed it, but it sounds like a sensible change to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e4e56f9 - [clang] Emit `Wformat` for bool value and char specifier confusion in scanf

Author: Podchishchaeva, Mariya Date: 2023-09-01T01:38:07-07:00 New Revision: e4e56f91df6a6078a82abd59e00a93b63de664b7 URL: https://github.com/llvm/llvm-project/commit/e4e56f91df6a6078a82abd59e00a93b63de664b7 DIFF: https://github.com/llvm/llvm-project/commit/e4e56f91df6a6078a82abd59e00a93b63de66

[PATCH] D159279: [clang] Emit `Wformat` for bool value and char specifier confusion in scanf

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4e56f91df6a: [clang] Emit `Wformat` for bool value and char specifier confusion in scanf (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D158050: [RISCV] RISCV vector calling convention (2/2)

4vtomat updated this revision to Diff 555304. 4vtomat added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Finish handling vector arguments in backend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158050

[PATCH] D158050: [RISCV] RISCV vector calling convention (2/2)

4vtomat added a comment. `RVVArgDispatcher` is the class used to compute and maximize the register usage by using the vector argument information placed in `std::vector`, it's both used by `frontend` and `backend`. Currently I'm not sure where is the better file to place this class, so I just p

[PATCH] D158050: [RISCV] RISCV vector calling convention (2/2)

4vtomat updated this revision to Diff 555307. 4vtomat edited the summary of this revision. 4vtomat added a comment. Update commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158050/new/ https://reviews.llvm.org/D158050 Files: clang/in

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. int a\ ス; Failed to be parsed as a valid identifier. Fixes #65156 Repository: rG LLVM Github Monorepo https://revie

[PATCH] D159346: Revert "Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas"

alexfh created this revision. alexfh added reviewers: vitalybuka, nickdesaulniers. Herald added a subscriber: jvesely. Herald added a project: All. alexfh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit e698695fbbf62e667

[PATCH] D159105: [analyzer] ArrayBoundCheckerV2 should check the region for taint as well

steakhal added a comment. In D159105#4631504 , @steakhal wrote: > There are still a few FPs of the kind, where they iterate over the result of > `getenv` in a loop, and continuously checks the character against the zero > terminator. > I refined the sup

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

steakhal added inline comments. Comment at: clang/test/Analysis/memory-model.cpp:167 + clang_analyzer_dumpExtent(a); // expected-warning {{0 S64b}} + clang_analyzer_dumpElementCount(a); // expected-warning {{5 S64b}} + clang_analyzer_dumpExtent(t); // expected-warn

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

alexfh added subscribers: vitalybuka, alexfh. alexfh added a comment. This commit caused invalid AddressSanitizer: stack-use-after-scope errors in our internal setup. Trying to create a standalone repro, but so far we think that the patch is incorrect. @vitalybuka says "The patch seems wrong, ca

[PATCH] D159233: [clang-format][NFC] Change duplicate config files to symlinks

MyDeveloperDay added a comment. out of interest what happens on windows? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159233/new/ https://reviews.llvm.org/D159233 ___ cfe-commits mailing list cfe-commit

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

d0nc1h0t updated this revision to Diff 555317. d0nc1h0t added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/unittests/Forma

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

alexfh added a comment. In D74094#4633785 , @alexfh wrote: > This commit caused invalid AddressSanitizer: stack-use-after-scope errors in > our internal setup. Trying to create a standalone repro, but so far we think > that the patch is incorrect. @vital

[clang-tools-extra] 69feef0 - [clangd][tests] Assert for idleness of scheduler

Author: Kadir Cetinkaya Date: 2023-09-01T12:19:09+02:00 New Revision: 69feef0e827793fd1c9df5dddc736441ff46f8af URL: https://github.com/llvm/llvm-project/commit/69feef0e827793fd1c9df5dddc736441ff46f8af DIFF: https://github.com/llvm/llvm-project/commit/69feef0e827793fd1c9df5dddc736441ff46f8af.dif

[clang-tools-extra] 16b8b3e - [clangd][tests] Bump timeouts in TUSchedulerTests to 60 secs

Author: Kadir Cetinkaya Date: 2023-09-01T12:19:10+02:00 New Revision: 16b8b3e59f7e5d64d4bb4e252a6fea5235feb630 URL: https://github.com/llvm/llvm-project/commit/16b8b3e59f7e5d64d4bb4e252a6fea5235feb630 DIFF: https://github.com/llvm/llvm-project/commit/16b8b3e59f7e5d64d4bb4e252a6fea5235feb630.dif

[PATCH] D159337: [clangd][tests] Assert for idleness of scheduler

This revision was automatically updated to reflect the committed changes. Closed by commit rG69feef0e8277: [clangd][tests] Assert for idleness of scheduler (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159337/new/ https://rev

[PATCH] D159338: [clangd][tests] Bump timeouts in TUSchedulerTests to 60 secs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16b8b3e59f7e: [clangd][tests] Bump timeouts in TUSchedulerTests to 60 secs (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

kadircet added a comment. In D158566#4616417 , @ilya-biryukov wrote: > Open question: I also feel like the best option here is to fix the tests, but > I'm not sure how hard that would be. @sammccall any thoughts? > I suspect the particular tests are fla

[PATCH] D159105: [analyzer] ArrayBoundCheckerV2 should check the region for taint as well

donat.nagy added a comment. As I thought more about this commit I realized that I have two vague but significant concerns. I'm sorry that I wasn't able to describe these before you started to dig into the details of the heuristics. (1) I don't think that code like `int *ptr; scanf("%ld", &ptr);

[clang] b7f4915 - Revert "Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas"

Author: Alexander Kornienko Date: 2023-09-01T12:53:24+02:00 New Revision: b7f4915644844fb9f32e8763922a070f5fe4fd29 URL: https://github.com/llvm/llvm-project/commit/b7f4915644844fb9f32e8763922a070f5fe4fd29 DIFF: https://github.com/llvm/llvm-project/commit/b7f4915644844fb9f32e8763922a070f5fe4fd29

[PATCH] D159346: Revert "Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb7f491564484: Revert "Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate… (authored by alexfh). Reposit

[PATCH] D159105: [analyzer] ArrayBoundCheckerV2 should check the region for taint as well

steakhal added a comment. In D159105#4633864 , @donat.nagy wrote: > As I thought more about this commit I realized that I have two vague but > significant concerns. I'm sorry that I wasn't able to describe these before > you started to dig into the det

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

d0nc1h0t added a comment. In D158363#4632451 , @owenpan wrote: > Do you need us to commit it for you? See > https://llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator. 'git push' or 'arc land' give an error 'remote: Permission t

[PATCH] D159351: [Sema] Change order of displayed overloads in diagnostics

ilya-biryukov created this revision. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make it a strict weak order. Fixes #64121. Current implementation uses the definition the definition of orderi

[PATCH] D159351: [Sema] Change order of displayed overloads in diagnostics

ilya-biryukov added reviewers: rnk, clang-language-wg. ilya-biryukov added a subscriber: rnk. ilya-biryukov added a comment. This change mainly tried to address the assertion failure in libc++, but got into the territory of changing the order of displayed overloads. Which might be a more complica

[PATCH] D159312: [Headers] Remove a space in NULL define

aaron.ballman added inline comments. Comment at: clang/lib/Headers/__stddef_null.h:18-21 +// Don't add any whitespaces in ((void*)0) below! +// musl (https://www.musl-libc.org/) redefines `NULL` as such and redefinition +// with a different expression, even in terms of a single w

[PATCH] D159312: [Headers] Remove a space in NULL define

dalias added a comment. I don't understand the motivation of trying to match musl's definition here. musl explicitly **does not support** using a compiler-provided `stddef.h` or other standard headers. If it's getting included, this is a symption of an include order problem that needs to be fix

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder added a comment. Not sure I have enough CFG knowledge. Do I just need to create another noreturn block for the cleanup function? This is the CFG I get when both the cleanup function and the destructor are noreturn: int main() [B4 (ENTRY)] Succs (1): B3 [B1] 1: CFGS

[PATCH] D159312: [Headers] Remove a space in NULL define

aaron.ballman added a comment. In D159312#4633989 , @dalias wrote: > I don't understand the motivation of trying to match musl's definition here. > musl explicitly **does not support** using a compiler-provided `stddef.h` or > other standard headers. If

[PATCH] D159105: [analyzer] ArrayBoundCheckerV2 should check the region for taint as well

steakhal added a comment. In D159105#4633899 , @steakhal wrote: > The measurement is still running, and I'll post a few words about that once I > had a look; but anyway, I feel that this patch is controversial and needs > more discussion before it could

[PATCH] D159352: [Driver] Don't default to DWARF 2 on Solaris

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. `clang` currently defaults to DWARF 2 on Solaris. This dates back to LLVM 3.8.0. I suspect thi

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:1901-1902 appendLifetimeEnds(Block, VD, S); -if (BuildOpts.AddImplicitDtors) +if (BuildOpts.AddImplicitDtors && !hasTrivialDestructor(VD)) appendAutomaticObjDtor(Block, VD, S); +if (Ha

[PATCH] D158519: [clangd] Move diagnostics from modules to the main source file

DmitryPolukhin added a comment. Friendly ping, any thoughts about this diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158519/new/ https://reviews.llvm.org/D158519 ___ cfe-commits mailing list cfe-co

[PATCH] D148131: Avoid unnecessarily aggressive line-breaking when using "LambdaBodyIndentation: OuterScope" with argument bin-packing.

jp4a50 added a comment. In D148131#4628719 , @HazardyKnusperkeks wrote: > But please wait for other opinions. OK sure. @owenpan, any thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148131/new/ ht

[PATCH] D159355: [clang][dataflow] Unsoundly treat "Unknown" as "Equivalent" in widening.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2, mboehme. Herald added a subscriber: martong. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This change makes widening act the same a

[clang] 1255906 - [analyzer] Fix a few size-type inconsistency relating to DynamicExtent

Author: dingfei Date: 2023-09-01T21:03:16+08:00 New Revision: 12559064e05a11e8418425de59d8745f0cfb1122 URL: https://github.com/llvm/llvm-project/commit/12559064e05a11e8418425de59d8745f0cfb1122 DIFF: https://github.com/llvm/llvm-project/commit/12559064e05a11e8418425de59d8745f0cfb1122.diff LOG:

[PATCH] D158499: [analyzer] Compute FAM dynamic size

steakhal added a comment. @danix800 FYI I think you used the wrong revision link in the commit. Maybe mark this revision as "abandoned" again, to reflect the actual status. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158499/new/ https://reviews.

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

steakhal closed this revision. steakhal added a comment. Landed as https://github.com/llvm/llvm-project/commit/12559064e05a11e8418425de59d8745f0cfb1122 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158707/new/ https://reviews.llvm.org/D158707 ___

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

zyounan updated this revision to Diff 555356. zyounan added a comment. Herald added a subscriber: javed.absar. Disperse the call over clangd tasks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158967/new/ https://reviews.llvm.org/D158967 Files:

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

zyounan added a comment. Thanks! I hope I'm getting things right. Specifically, 1. `UpdateIndexCallbacks::indexStdlib()::Task` in `ClangdServer.cpp` 2. `PreambleThread::run()`, `ASTWorker::run()` and `TUScheduler::runWithPreamble()::Task` in `TUScheduler.cpp` 3. The lambda of `runAsync` in `Back

[PATCH] D157385: [clang][CFG] Cleanup functions

steakhal added a comment. When I added `-analyzer-config cfg-lifetime=true` to `clang/test/Analysis/scopes-cfg-output.cpp`, suddenly duplicated lifetime ends entries appeared where we have `CleanupFunctions`. My output is: void test_cleanup_functions() [B2 (ENTRY)] Succs (1): B1

[PATCH] D158499: [analyzer] Compute FAM dynamic size

danix800 added a comment. https://github.com/llvm/llvm-project/commit/12559064e05a11e8418425de59d8745f0cfb1122 mistakingly linked here. The actual revision is D158707 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D158499: [analyzer] Compute FAM dynamic size

danix800 added a comment. In D158499#4634166 , @steakhal wrote: > @danix800 FYI I think you used the wrong revision link in the commit. Maybe > mark this revision as "abandoned" again, to reflect the actual status. Sorry for this mistake. D158707

[PATCH] D158407: [clang][dataflow] #llvm #flow-analysis Simplify formula at CNF construction time, and short-cut solving of known contradictory formulas.

burakemir updated this revision to Diff 555363. burakemir marked 4 inline comments as done. burakemir added a comment. Applied reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158407/new/ https://reviews.llvm.org/D158407 Files: c

[PATCH] D158407: [clang][dataflow] #llvm #flow-analysis Simplify formula at CNF construction time, and short-cut solving of known contradictory formulas.

burakemir added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/WatchedLiteralsSolver.cpp:184 +/// may in turn yield more unit clauses or even a contradiction. +/// The complexity of this preprocessing is O(log(K)) where K is the number +/// of unit clauses. Assumin

[PATCH] D159358: [Clang] Realize generic lambda call operators are dependent sooner

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When parsing a trailing return type / noexcept / constraint of a generic lambda, we need to know that we are in a dependen

[PATCH] D159358: [Clang] Realize generic lambda call operators are dependent sooner

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This is great! Probably worth the cherry pick to Clang17 as well! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159358/new/ https://revi

[PATCH] D159358: [Clang] Realize generic lambda call operators are dependent sooner

cor3ntin updated this revision to Diff 555374. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159358/new/ https://reviews.llvm.org/D159358 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h cla

[PATCH] D159358: [Clang] Realize generic lambda call operators are dependent sooner

cor3ntin updated this revision to Diff 555375. cor3ntin added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159358/new/ https://reviews.llvm.org/D159358 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h

[PATCH] D158296: [clang] Diagnose overly complex Record in __builtin_dump_struct

yronglin updated this revision to Diff 555376. yronglin added a comment. Address Aaron's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158296/new/ https://reviews.llvm.org/D158296 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D158296: [clang] Diagnose overly complex Record in __builtin_dump_struct

yronglin marked 4 inline comments as done. yronglin added a comment. Thank you for your review @aaron.ballman @rsmith , I will be happy to continue cook this patch once we reach a consensus. Comment at: clang/lib/Sema/SemaChecking.cpp:732-733 +int RDKind = RD->isClass() ?

[clang] 7c65443 - [clang][Sema] Correct RUN line in fixit tests

Author: David Spickett Date: 2023-09-01T14:53:41Z New Revision: 7c6544333eba516c1b569fb74288bbfe9ca54c1f URL: https://github.com/llvm/llvm-project/commit/7c6544333eba516c1b569fb74288bbfe9ca54c1f DIFF: https://github.com/llvm/llvm-project/commit/7c6544333eba516c1b569fb74288bbfe9ca54c1f.diff LOG

[clang] ef5219c - [clang][Driver] Correct OpenBSD UBSAN options test

Author: David Spickett Date: 2023-09-01T14:55:11Z New Revision: ef5219c18b252ac36815d5f322acab704259df08 URL: https://github.com/llvm/llvm-project/commit/ef5219c18b252ac36815d5f322acab704259df08 DIFF: https://github.com/llvm/llvm-project/commit/ef5219c18b252ac36815d5f322acab704259df08.diff LOG

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

beanz updated this revision to Diff 555380. beanz added a comment. Updating based on PR feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159247/new/ https://reviews.llvm.org/D159247 Files: clang/include/clang/AST/ExprCXX.h clang/lib/AST

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin added a comment. I believe this is better solved downstream, i.e., in musl. I'm not a musl developer but a user, but I can consider contributing a patch there. I'd like to remove the whitespace for now because it is currently breaking us and it had been that way for a long time anyway,

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

owenpan added a comment. We need the name and email you want to use in order to commit the patch for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158363 ___ cf

[PATCH] D114903: [clang] Support array placement new in constant expressions

ldionne abandoned this revision. ldionne added a comment. Herald added a project: All. I've run out of time to work on this. It's also not clear that it's supported by the Standard right now since there's a not-voted-yet LWG issue about it (http://wg21.link/LWG3436). Abandoning. This isn't bloc

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

ivanmurashko created this revision. ivanmurashko added reviewers: kadircet, sammccall. ivanmurashko added projects: clang, clang-tools-extra. Herald added a subscriber: arphaman. Herald added a project: All. ivanmurashko requested review of this revision. Herald added subscribers: cfe-commits, Mask

[PATCH] D159362: [clang][AST][DeclPrinter] Change "__attribute__" AST printing location for the sake of GCC compatibility.

mstachyraa created this revision. Herald added a project: All. mstachyraa requested review of this revision. Herald added a subscriber: wangpc. Herald added a project: clang. When printing C representation of AST, clang puts the "__attribute__" elements after the name of printed function. In orde

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Sorry about the layering mess... Comment at: clang-tools-extra/clangd/support/Threading.cpp:11 #include "support/Trace.h" +#include "clang/Basic/Stack.h" #inc

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

shafik added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1757 + // If a UTF-8 codepoint appears immediately after an escaped new line, + // CurPtr may point to the splicing \ at the on the preceding line, + // so we need to skip it. I think that is wh

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

ivanmurashko added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:610-619 StoreDiags PreambleDiagnostics; PreambleDiagnostics.setDiagCallback( [&ASTListeners](const clang::Diagnostic &D, clangd::Diag &Diag) { llvm::for_each(ASTListeners,

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice catch! Comment at: clang-tools-extra/clangd/Preamble.cpp:709 Ctx->setStatCache(Result->StatCache); + // We have to setup DiagnosticConsumer that will b

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:610-619 StoreDiags PreambleDiagnostics; PreambleDiagnostics.setDiagCallback( [&ASTListeners](const clang::Diagnostic &D, clangd::Diag &Diag) { llvm::for_each(ASTListeners,

[PATCH] D159188: [AArch64][SME] Make the overloaded svreinterpret_* functions streaming-compatible.

sdesmalen updated this revision to Diff 555402. sdesmalen marked an inline comment as done. sdesmalen added a comment. Added "aarch64_32" to TargetAArch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159188/new/ https://reviews.llvm.org/D159188

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder updated this revision to Diff 555403. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157385/new/ https://reviews.llvm.org/D157385 Files: clang/include/clang/Analysis/CFG.h clang/lib/Analysis/CFG.cpp clang/lib/Analysis/PathDiagnostic.cpp clang/lib/StaticAnalyzer/Core/ExprEn

[PATCH] D159188: [AArch64][SME] Make the overloaded svreinterpret_* functions streaming-compatible.

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/Attr.td:418 def TargetARM : TargetArch<["arm", "thumb", "armeb", "thumbeb"]>; -def TargetAArch64 : TargetArch<["aarch64"]>; +def TargetAArch64 : TargetArch<["aarch64", "aarch64_be"]>; def TargetAnyArm : Targ

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder marked an inline comment as done. tbaeder added a comment. @steakhal Double lifetime ends should be fixed now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157385/new/ https://reviews.llvm.org/D157385 ___ cfe-commits mailing list cfe

[clang] 8eb3470 - [SpecialCaseList] Add option to use Globs instead of Regex to match patterns

Author: Ellis Hoag Date: 2023-09-01T09:06:11-07:00 New Revision: 8eb34700c2b1847ec6dfb8f92b305b65278d2ec0 URL: https://github.com/llvm/llvm-project/commit/8eb34700c2b1847ec6dfb8f92b305b65278d2ec0 DIFF: https://github.com/llvm/llvm-project/commit/8eb34700c2b1847ec6dfb8f92b305b65278d2ec0.diff LO

[PATCH] D154014: [SpecialCaseList] Add option to use Globs instead of Regex to match patterns

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8eb34700c2b1: [SpecialCaseList] Add option to use Globs instead of Regex to match patterns (authored by ellis). Repository: rG LLVM Github Monorep

[PATCH] D159312: [Headers] Remove a space in NULL define

dalias added a comment. Please report what you're actually trying to do that's breaking rather than sending patches to align definitions that are not intended to be aligned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159312/new/ https://reviews

[PATCH] D159352: [Driver] Don't default to DWARF 2 on Solaris

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Comment at: clang/test/CodeGen/dwarf-version.c:7 // RUN: %clang -target x86_64-linux-gnu -gdwarf -S -emit-llvm -o - %s | FileCheck %s --check-prefix=VER5 +//

[PATCH] D147219: [OpenMP][Flang][MLIR] Lowering of requires directive from MLIR to LLVM IR

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147219/new/ https://reviews.llvm.org/D147219 __

[clang] f93c271 - [Object] Change OffloadBinary::write to return SmallString<0>

Author: Fangrui Song Date: 2023-09-01T09:19:25-07:00 New Revision: f93c271d4cc11b865b87da1402e1cb33449fe4bf URL: https://github.com/llvm/llvm-project/commit/f93c271d4cc11b865b87da1402e1cb33449fe4bf DIFF: https://github.com/llvm/llvm-project/commit/f93c271d4cc11b865b87da1402e1cb33449fe4bf.diff

[PATCH] D159335: [Object] Change OffloadBinary::write to return SmallString<0>

This revision was automatically updated to reflect the committed changes. Closed by commit rGf93c271d4cc1: [Object] Change OffloadBinary::write to return SmallString<0> (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159335/new/

[PATCH] D157385: [clang][CFG] Cleanup functions

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. In D157385#4634591 , @tbaeder wrote: > @steakhal Double lifetime ends should be fixed now. I haven't verified, but it should be good now. CHANGE

[PATCH] D159250: [X86][RFC] Add new option `-m[no-]evex512` to disable ZMM and 64-bit mask instructions for AVX512 features

jyknight added a comment. In D159250#4633530 , @pengfei wrote: > In D159250#4631786 , @RKSimon wrote: > >> Would it be possible to add function multiversioning tests to ensure the >> evex512 attribute would work

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

ivanmurashko updated this revision to Diff 555441. ivanmurashko marked an inline comment as done. ivanmurashko added a comment. @sammccall's comment was addressed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159363/new/ https://reviews.llvm.org/D1

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

ivanmurashko added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:709 Ctx->setStatCache(Result->StatCache); + // We have to setup DiagnosticConsumer that will be alife + // while preamble callback is executed sammccall wrote:

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

vitalybuka added a comment. In D74094#4633785 , @alexfh wrote: > This commit caused invalid AddressSanitizer: stack-use-after-scope errors in > our internal setup. Trying to create a standalone repro, but so far we think > that the patch is incorrect. @v

[PATCH] D159352: [Driver] Don't default to DWARF 2 on Solaris

ro marked an inline comment as done. ro added inline comments. Comment at: clang/test/CodeGen/dwarf-version.c:7 // RUN: %clang -target x86_64-linux-gnu -gdwarf -S -emit-llvm -o - %s | FileCheck %s --check-prefix=VER5 +// RUN: %clang -target i386-pc-solaris -g -S -emit-llvm -o -

[clang] b1b1f36 - [Driver] Don't default to DWARF 2 on Solaris

Author: Rainer Orth Date: 2023-09-01T20:02:37+02:00 New Revision: b1b1f364d63382637fa5f64871ee06bf74bd0405 URL: https://github.com/llvm/llvm-project/commit/b1b1f364d63382637fa5f64871ee06bf74bd0405 DIFF: https://github.com/llvm/llvm-project/commit/b1b1f364d63382637fa5f64871ee06bf74bd0405.diff L

[PATCH] D159352: [Driver] Don't default to DWARF 2 on Solaris

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ro marked an inline comment as done. Closed by commit rGb1b1f364d633: [Driver] Don't default to DWARF 2 on Solaris (authored by ro). Changed prior to commit: https:/

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

ellis added a comment. In D157913#4626007 , @zequanwu wrote: >> It seems that the `__llvm_prf_names` is retained in this mode. What is the >> overhead of this section generally? Can we instead use debug info to lookup >> function names? > > With debug i

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

rjmccall added a comment. Parameter objects are not temporaries and have their own lifetime rules, so there's nothing wrong with this idea in principle. This seems to just be a bug, probably that we're doing a type check on `E->getType()` without considering whether E might be a gl-value. We

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

daltenty added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2389 if (getTarget().getCXXABI().areMemberFunctionsAligned()) { -if (F->getPointerAlignment(getDataLayout()) < 2 && isa(D)) +if (isa(D) && F->getPointerAlignment(getDataLayout()) < 2)

[PATCH] D85309: [Driver] Support GNU ld on Solaris

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:55 + StringRef UseLinker = A ? A->getValue() : CLANG_DEFAULT_LINKER; + // FIXME: What about -fuse-ld=? + return

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

hiraditya added a comment. In D158566#4633847 , @kadircet wrote: > In D158566#4616417 , @ilya-biryukov > wrote: > >> Open question: I also feel like the best option here is to fix the tests, >> but I'm not sure

[PATCH] D159338: [clangd][tests] Bump timeouts in TUSchedulerTests to 60 secs

hiraditya added a comment. not sure if this is the right way to fix these tests. The problem is if a device is constraiend, this will further slow down the device and create more backlogs. Can we allow a way to skip these tests based on a flag/environment variable? Repository: rG LLVM Githu

[PATCH] D155769: [HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 555450. AlexVlx added a reviewer: JonChesterfield. AlexVlx added a comment. Correctly reflect AMDGPU-only nature of the extension. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155769/new/ https://reviews.llvm.org/D155769 Files: clang/docs/HIPSup

[PATCH] D159103: [Driver][HLSL] Improve diagnostics for invalid shader model and stage

bogner updated this revision to Diff 555451. bogner added a comment. - Consolidate error messages - Error messages should start with a lower case letter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159103/new/ https://reviews.llvm.org/D159103 Fil

[clang] [APINotes] Remove unused OS-availability feature (PR #65178)

https://github.com/egorzhdan opened https://github.com/llvm/llvm-project/pull/65178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Remove unused OS-availability feature (PR #65178)

https://github.com/egorzhdan labeled https://github.com/llvm/llvm-project/pull/65178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Remove unused OS-availability feature (PR #65178)

https://github.com/egorzhdan review_requested https://github.com/llvm/llvm-project/pull/65178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana added a comment. Ah, the tests are failing because some of them are putting the builtin headers in other modules. This is going to need the "optionally ignore the builtin modules" change first then. I almost have that one finished. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

  1   2   3   >