[clang] a4fbc09 - Clang: Don't warn about unused private fields of types declared maybe_unused

Author: Hans Wennborg Date: 2023-08-30T09:06:39+02:00 New Revision: a4fbc091846206fb6f5bc36115d65075764b51ea URL: https://github.com/llvm/llvm-project/commit/a4fbc091846206fb6f5bc36115d65075764b51ea DIFF: https://github.com/llvm/llvm-project/commit/a4fbc091846206fb6f5bc36115d65075764b51ea.diff

[PATCH] D159083: Clang: Don't warn about unused private fields of types declared maybe_unused

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa4fbc0918462: Clang: Don't warn about unused private fields of types declared maybe_unused (authored by hans). Changed prior to commit: https://re

[PATCH] D159138: [clang][Sema] Fix format size estimator's handling of %o, %x, %X with alternative form

serge-sans-paille added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:966 +// size. e.g.(("%#3x", 0xf) is "0xf") + +// If the result is zero, o, b, x, X adds nothing. Then couldn't we increase the Size if the `FieldWidth` is unspeci

[PATCH] D159024: [Parser] Parse string literal arguments of 'availability', 'external_source_symbol' and 'uuid' attributes as unevaluated

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM. Thanks again for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159024/new/ https://reviews.llvm.org/D159024

[PATCH] D159133: [Sema] Make C++ functional-style cast warn about dropped qualifiers (-Wcast-qual)

cor3ntin added a comment. I think this should get a mention in clang's releases notes. Otherwise LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159133/new/ https://reviews.llvm.org/D159133 ___ cfe-co

[PATCH] D158948: [clang][ASTImporter] Add import of type-related nodes

danix800 updated this revision to Diff 554603. danix800 added a comment. Pulling local matchers for testcases, since https://reviews.llvm.org/D158872 is abandoned. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158948/new/ https://reviews.llvm.org/D158948 Files: clang/lib/AST/ASTImpo

[PATCH] D159163: [analyzer][NFC] Workaround miscompilation on recent MSVC

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Feel free to merge it. Thanks! I'd be curious to see if this bug is tracked at Microsoft. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15916

[PATCH] D159173: [Driver] Report warnings for unlaimed TargetSpecific options for assembler input

MaskRay created this revision. MaskRay added reviewers: jansvoboda11, thesamesam, chill, peter.smith, simon_tatham, stuij. Herald added subscribers: kadircet, kristof.beyls. Herald added a reviewer: ctetreau. Herald added a project: All. MaskRay requested review of this revision. Herald added subs

[PATCH] D159174: [clang] Use stable_sort in AppendTargetMangling

BeMg created this revision. Herald added a subscriber: mgrang. Herald added a project: All. BeMg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For the target features in the same priority, make sure it is not a random mangling name. Re

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat added a comment. In D146054#4596571 , @MaskRay wrote: > In D146054#4587210 , @4vtomat wrote: > >> In D146054#4586067 , @MaskRay >> wrote: >> >>> I think the best

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 554609. 4vtomat added a comment. Resolved MaskRay's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files: clang/include/clang/Driver/Options.td clang/i

[PATCH] D158688: [Driver,ARM,AArch64] Ignore -mbranch-protection= diagnostics for assembler input

MaskRay added a comment. In D158688#4625839 , @MaskRay wrote: > In D158688#4624267 , @simon_tatham > wrote: > >> The change LGTM, and "agree with gcc" seems like a reasonable justification >> in this case. > > T

[PATCH] D159163: [analyzer][NFC] Workaround miscompilation on recent MSVC

steakhal added a comment. Please add the exact versions to the commit message of Visual Studio where it worked, and where it didn't, thus we applied this change so that it would work on all (both) Visual Studio versions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] c1dda0f - [AST] Remove unneeded `return false` from UseExcessPrecision. NFC.

Author: Jim Lin Date: 2023-08-30T16:05:55+08:00 New Revision: c1dda0f7934d28eb8dfc92206c49b188a1a091de URL: https://github.com/llvm/llvm-project/commit/c1dda0f7934d28eb8dfc92206c49b188a1a091de DIFF: https://github.com/llvm/llvm-project/commit/c1dda0f7934d28eb8dfc92206c49b188a1a091de.diff LOG:

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

mstorsjo added a comment. In D152752#4626234 , @rnk wrote: > I need to get to it, my recollection is that @mstorsjo ran into the same > issue here for mingw and made some changes, I wanted to go dig those up as a > starting point. I may have completely

[PATCH] D156076: [PowerPC][Clang] Remove constraint for initial-exec TLS mode on AIX

qiucf added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156076/new/ https://reviews.llvm.org/D156076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 updated this revision to Diff 554626. NoumanAmir657 set the repository for this revision to rG LLVM Github Monorepo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158540/new/ https://reviews.llvm.org/D158540 Files: clang/include/clan

[clang] 9b35254 - [NFC][Clang] Remove unused function `CodeGenModule::addDefaultFunctionDefinitionAttributes`

Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2023-08-30T10:32:51+02:00 New Revision: 9b352540184e181d2a38423d352c5d5e2142839e URL: https://github.com/llvm/llvm-project/commit/9b352540184e181d2a38423d352c5d5e2142839e DIFF: https://github.com/llvm/llvm-project/commit/9b352540184e181d2a38423d352c5d5

[PATCH] D158990: [NFC][Clang] Remove unused function `CodeGenModule::addDefaultFunctionDefinitionAttributes`

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG9b352540184e: [NFC][Clang] Remove unused function `CodeGenModule… (authored by jmmartinez). Repository: rG LLVM Github

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 updated this revision to Diff 554629. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158540/new/ https://reviews.llvm.org/D158540 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.cpp clang/test/CXX/dcl.dcl/dcl.spec/dcl.constexpr/p3.cpp

[clang] a7eaaba - [Parser] Parse string literal arguments of 'availability', 'external_source_symbol' and 'uuid' attributes as unevaluated

Author: Sergei Barannikov Date: 2023-08-30T11:46:54+03:00 New Revision: a7eaaba69906d3305752cb738332b9365e666def URL: https://github.com/llvm/llvm-project/commit/a7eaaba69906d3305752cb738332b9365e666def DIFF: https://github.com/llvm/llvm-project/commit/a7eaaba69906d3305752cb738332b9365e666def.d

[PATCH] D159024: [Parser] Parse string literal arguments of 'availability', 'external_source_symbol' and 'uuid' attributes as unevaluated

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7eaaba69906: [Parser] Parse string literal arguments of 'availability'… (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159024/new

[PATCH] D159163: [analyzer][NFC] Workaround miscompilation on recent MSVC

danix800 added a comment. In D159163#4627497 , @steakhal wrote: > Feel free to merge it. Thanks! > I'd be curious to see if this bug is tracked at Microsoft. I searched but no result so I submitted it to MS: https://developercommunity.visualstudio.com/t

[PATCH] D159105: [analyzer] ArrayBoundCheckerV2 should check the region for taint as well

donat.nagy added a comment. I was thinking about adding an improvement like this for the sake of consistency, but I fear that this might cause a surprising amount of false positives. (Did you test it on larger codebases?) As far as I understand (correct me if I'm wrong), there are situations wh

[PATCH] D156076: [PowerPC][Clang] Remove constraint for initial-exec TLS mode on AIX

shchenz accepted this revision as: shchenz. shchenz added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156076/new/ https://reviews.llvm.org/D156076 ___ cfe-commits mailing list cfe-commi

[PATCH] D159106: [analyzer] ArrayBoundCheckerV2 should listen to check::Bind as well

donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land. This seems to be a straightforward improvement over the current situation; LGTM if you test(ed) it on some real-life code (to ensure that it doesn't introduce a corner case that crashe

[clang] 5b3f41c - [analyzer][NFC] Workaround miscompilation on recent MSVC

Author: dingfei Date: 2023-08-30T17:14:38+08:00 New Revision: 5b3f41c55d9261dcb682d60a4258fa2c30fd50c8 URL: https://github.com/llvm/llvm-project/commit/5b3f41c55d9261dcb682d60a4258fa2c30fd50c8 DIFF: https://github.com/llvm/llvm-project/commit/5b3f41c55d9261dcb682d60a4258fa2c30fd50c8.diff LOG:

[PATCH] D159163: [analyzer][NFC] Workaround miscompilation on recent MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b3f41c55d92: [analyzer][NFC] Workaround miscompilation on recent MSVC (authored by dingfei ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D159138: [clang][Sema] Fix format size estimator's handling of %o, %x, %X with alternative form

hazohelet marked an inline comment as done. hazohelet added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:966 +// size. e.g.(("%#3x", 0xf) is "0xf") + +// If the result is zero, o, b, x, X adds nothing. serge-sans-paille wrote: > Th

[PATCH] D159105: [analyzer] ArrayBoundCheckerV2 should check the region for taint as well

steakhal added a comment. In D159105#4627724 , @donat.nagy wrote: > I was thinking about adding an improvement like this for the sake of > consistency, but I fear that this might cause a surprising amount of false > positives. (Did you test it on large

[PATCH] D159106: [analyzer] ArrayBoundCheckerV2 should listen to check::Bind as well

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:46 + void impl(SVal Loc, bool isLoad, const Stmt *S, CheckerContext &C) const; + donat.nagy wrote: > I'd call this function `performCheck` or something simila

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

overmighty added a comment. Ping. If you would like the current patch with `extractelt` to be committed, please commit it as "OverMighty ". Thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158008/new/ https://reviews.llvm.org/D158008 __

[PATCH] D159105: [analyzer] ArrayBoundCheckerV2 should check the region for taint as well

donat.nagy added a comment. In D159105#4627785 , @steakhal wrote: > In D159105#4627724 , @donat.nagy > wrote: > >> I was thinking about adding an improvement like this for the sake of >> consistency, but I fear

[PATCH] D159107: [analyzer] ArrayBoundCheckerV2 should disallow forming lvalues to out-of-bounds locations

donat.nagy added a comment. Good direction of development, this will be useful for providing better bug reports (in addition to ensuring correct behavior some situations). Note that it's also possible to dereference pointers with the operator `->`, which is represented by `MemberExpr`s in the A

[PATCH] D159109: [analyzer] CStringChecker buffer access checks should check the first bytes

donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land. LGTM if the test results are also good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159109/new/ https://reviews.llvm.org/D159109

[PATCH] D159108: [analyzer] CStringChecker should check the first byte of the destination of strcpy, strncpy

donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land. LGTM if the test results are good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159108/new/ https://reviews.llvm.org/D159108 _

[clang] 38c92c1 - [AArch64] Add patterns for FMADD, FMSUB

Author: OverMighty Date: 2023-08-30T12:39:04+02:00 New Revision: 38c92c1ee2f07e3260c94d51834a97e84f93c708 URL: https://github.com/llvm/llvm-project/commit/38c92c1ee2f07e3260c94d51834a97e84f93c708 DIFF: https://github.com/llvm/llvm-project/commit/38c92c1ee2f07e3260c94d51834a97e84f93c708.diff LO

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG38c92c1ee2f0: [AArch64] Add patterns for FMADD, FMSUB (authored by overmighty, committed by dzhidzhoev). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 554660. massberg marked 3 inline comments as done. massberg added a comment. Resolve remaining comments. - Added tests for new location functions of `ConceptReference`. There is an existing bug with the end location if there are no template arguments. As it

[PATCH] D155858: Add a concept AST node.

massberg added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:6824-6836 + unsigned size = TL.getTypePtr()->getTypeConstraintArguments().size(); + TemplateArgumentLocInfo *TALI = new TemplateArgumentLocInfo[size]; + TemplateSpecializationTypeLoc::initia

[PATCH] D153690: [clang][Sema] Remove dead diagnostic for loss of __unaligned qualifier

hazohelet added a comment. In D153690#4624726 , @michael-jabbour-sonarsource wrote: > The removal of the early return in this patch causes a crash when parsing the > following example: > > struct S { > bool operator==(int) const; > }; > > v

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

MaggieYi updated this revision to Diff 554665. MaggieYi marked 5 inline comments as done. MaggieYi added a comment. Thanks @MaskRay. The patch is updated. Hi @simon_tatham, are you happy with the patch? Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158614/new/ https://reviews.l

[PATCH] D159051: [clang-format][NFC] Change EXPECT_EQ to verifyFormat or verifyNoChang

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. +1 to this before we goto github Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159051/new/ https://reviews.llvm.org/D159051 ___ cfe-

[clang] 9939556 - [APINotes] Initial support for C++ namespaces

Author: Egor Zhdan Date: 2023-08-30T12:54:42+01:00 New Revision: 9939556625548d7ba2c3eba4d131b9b4d6bc0c02 URL: https://github.com/llvm/llvm-project/commit/9939556625548d7ba2c3eba4d131b9b4d6bc0c02 DIFF: https://github.com/llvm/llvm-project/commit/9939556625548d7ba2c3eba4d131b9b4d6bc0c02.diff LO

[PATCH] D159092: [APINotes] Initial support for C++ namespaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG993955662554: [APINotes] Initial support for C++ namespaces (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

mstorsjo added inline comments. Comment at: openmp/runtime/test/target/target_thread_limit.cpp:28 +// OMP51: target: parallel +// OMP51: target: parallel +// OMP51-NOT: target: parallel This test fails when running (on Windows) on GitHub Actions runners - see ht

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 added a comment. @xgupta the build is successful now. Earlier it failed due to format issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158540/new/ https://reviews.llvm.org/D158540 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

simon_tatham accepted this revision. simon_tatham added a comment. Yes, this looks good to me too. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158614/new/ https://reviews.llvm.org/D158614 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

aaron.ballman requested changes to this revision. aaron.ballman added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:7808-7809 +if (!MD->isConsteval()) { + Diag(MD->getBeginLoc(), diag::note_incorrect_defaulted_

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

goncharov added a comment. there is a number of unused vaiables in conditional loops there are firing now, I have submitted https://github.com/llvm/llvm-project/commit/74f4daef0412be33002bd4e24a30cb47d0187ecf but I suspect it's just a start. How did you checked the project code for that? Rep

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

zyounan updated this revision to Diff 554674. zyounan marked an inline comment as done. zyounan added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158967/new/ https://reviews.llvm.org/D158967 Files: clang-tools-extra/

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

zyounan added a comment. Thanks again for Richard and Sam's comments! (I didn't add another lit test for asynchronous case since it essentially works the same as the synchronous one. Hope this isn't harmful.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D159188: [AArch64][SME] Make the overloaded svreinterpret_* functions streaming-compatible.

sdesmalen created this revision. sdesmalen added reviewers: david-arm, paulwalker-arm. Herald added a subscriber: kristof.beyls. Herald added a reviewer: aaron.ballman. Herald added a project: All. sdesmalen requested review of this revision. Herald added a project: clang. Herald added a subscriber

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne added a comment. This looks good, the Windows CI is failing with the original premerge checks in exactly the same way as this new job, so I guess it's a current issue on `main`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ htt

[clang] eb27be9 - [clang] Add a Windows build in the Clang pre-commit CI

Author: Louis Dionne Date: 2023-08-30T09:15:55-04:00 New Revision: eb27be95a4c648707ad93e48049b3d463260a747 URL: https://github.com/llvm/llvm-project/commit/eb27be95a4c648707ad93e48049b3d463260a747 DIFF: https://github.com/llvm/llvm-project/commit/eb27be95a4c648707ad93e48049b3d463260a747.diff

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb27be95a4c6: [clang] Add a Windows build in the Clang pre-commit

[PATCH] D159197: [clang][ci] Don't block all jobs on clang-format

ldionne created this revision. ldionne added a reviewer: aaron.ballman. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It was expressed in some reviews that Clang folks didn't want to hold off other tes

[PATCH] D159197: [clang][ci] Don't block all jobs on clang-format

aaron.ballman added a comment. Thank you for this! I'm not qualified to say the changes are correct (they look sensible to me though), but I am really appreciative of the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159197/new/ https://re

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 added a comment. No, I don't have code examples that showcase the importance of the note. As you said the class context would be obvious whenever we run into this error. The test files also don't show where the note would be helpful. CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

probinson added a comment. In D159054#4626772 , @brad wrote: > Just FYI I am not in a rush to commit this. I am posting this more so as a > means of prodding for discussion of the feature. So far nobody has popped up to say they want it. @MaskRay I pok

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

aaron.ballman added a comment. In D158540#4628265 , @NoumanAmir657 wrote: > No, I don't have code examples that showcase the importance of the note. As > you said the class context would be obvious whenever we run into this error. > The test files also

[PATCH] D148131: Avoid unnecessarily aggressive line-breaking when using "LambdaBodyIndentation: OuterScope" with argument bin-packing.

jp4a50 updated this revision to Diff 554704. jp4a50 added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148131/new/ https://reviews.llvm.org/D148131 Files: clang/lib/Format/ContinuationIndenter.cpp clang/uni

[PATCH] D148131: Avoid unnecessarily aggressive line-breaking when using "LambdaBodyIndentation: OuterScope" with argument bin-packing.

jp4a50 marked 6 inline comments as done. jp4a50 added a comment. All comments addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148131/new/ https://reviews.llvm.org/D148131 ___ cfe-commits mailing

[PATCH] D159083: Clang: Don't warn about unused private fields of types declared maybe_unused

aaron.ballman added a comment. Thanks! I filed https://github.com/llvm/llvm-project/issues/65111 to track the template instantiation concerns Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159083/new/ https://reviews.llvm.org/D159083 _

[PATCH] D85309: [Driver] Support GNU ld on Solaris

ro updated this revision to Diff 554711. ro retitled this revision from "[WIP][clang][Driver] Support GNU ld on Solaris" to "[Driver] Support GNU ld on Solaris". ro added a comment. Herald added subscribers: llvm-commits, Sanitizers, Enna1, ormris. Herald added a reviewer: sscalpone. Herald added

[PATCH] D159206: [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

jmmartinez created this revision. jmmartinez added reviewers: arsenm, Pierre-vh, yaxunl, jhuber6. Herald added a project: All. jmmartinez requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Buitlins from AMD's device-libs are compiled with

[PATCH] D159206: [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2034 + } + + FuncAttr.addAttribute("target-features", llvm::join(MergedFeatures, ",")); Really it would be less bad if the incompatible functions were not imported rather than the backend p

[PATCH] D159206: [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2035 + + FuncAttr.addAttribute("target-features", llvm::join(MergedFeatures, ",")); +} do you need to guard against adding the empty attribute? I don't want to see "target-features"="" Rep

[PATCH] D156743: clang/OpenCL: Add inline implementations of sqrt in builtin header

arsenm added a comment. ping The alternative is to directly put the !fpmath on the sqrt call sites but I have no idea how to do that CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156743/new/ https://reviews.llvm.org/D156743 ___ cfe-commits

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

erichkeane added a comment. Hi, sorry for the delay in reviewing, I'm just coming back from an extended vacation. This looks alright, except for the test. Comment at: clang/test/SemaCXX/concept-crash-on-diagnostic.cpp:26 +// Consume remaining notes/errors. +// expected-note@*

[PATCH] D155858: Add a concept AST node.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LGTM, just nits! The SourceRanges are actually correct :-) Comment at: clang/include/clang/AST/ASTConcept.h:124 class ConceptReference { protected: // \brief The

[PATCH] D158963: [CodeGen] Function multi-versioning: don't set comdat for internal linkage resolvers

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Needs a release note. I don't have a problem with the patch, but don't really understand how COMDAT works/linking works, but since you're basically the person I'd tell someone else to

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 added a comment. In D158540#4628310 , @aaron.ballman wrote: > In D158540#4628265 , @NoumanAmir657 > wrote: > >> No, I don't have code examples that showcase the importance of the note. As >> you s

[clang] c2647ed - fix unused variables in condition warning

Author: Mikhail Goncharov Date: 2023-08-30T17:39:54+02:00 New Revision: c2647ed9b9cd5a0baddb2edf242c9b1f8976d7b6 URL: https://github.com/llvm/llvm-project/commit/c2647ed9b9cd5a0baddb2edf242c9b1f8976d7b6 DIFF: https://github.com/llvm/llvm-project/commit/c2647ed9b9cd5a0baddb2edf242c9b1f8976d7b6.d

[PATCH] D159212: [MLIR] Allow dialects to disable CSE for certain operations

skatrak created this revision. skatrak added reviewers: ftynse, kiranchandramohan, jsjodin, domada, agozillon, raghavendhra, TIFitis, shraiysh. Herald added subscribers: bviyer, Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurah

[PATCH] D157813: [Driver][VE] Support VPU flag as a feature for VE

kaz7 updated this revision to Diff 554742. kaz7 added a comment. By using hasFlag, change to enable VPU flag for VE by default again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157813/new/ https://reviews.llvm.org/D157813 Files: clang/include

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 554743. massberg marked 7 inline comments as done. massberg added a comment. Fixed remaining nits. Thanks for the reviews and comments everyone! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155858/new/ https:

[PATCH] D157813: [Driver][VE] Support VPU flag as a feature for VE

kaz7 marked an inline comment as done. kaz7 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/VE.cpp:22 + std::vector &Features) { + // Defaults. + bool EnableVPU = true; MaskRay wrote: > kaz7 wrote: > > MaskRay wro

[clang] 2263dfe - [test] Correct PS5 triple in clang :: Driver/unified-lto.c

Author: Matthew Voss Date: 2023-08-30T08:45:16-07:00 New Revision: 2263dfe368ce4925eb9f1fdcd11ff50455f546af URL: https://github.com/llvm/llvm-project/commit/2263dfe368ce4925eb9f1fdcd11ff50455f546af DIFF: https://github.com/llvm/llvm-project/commit/2263dfe368ce4925eb9f1fdcd11ff50455f546af.diff

[PATCH] D157813: [Driver][VE] Change to enable VPU flag by default

kaz7 marked an inline comment as done. kaz7 added a comment. Thank you for correction. I clean code again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157813/new/ https://reviews.llvm.org/D157813 ___

[PATCH] D158255: [RISCV][NFC] Update compile options for some vector crypto C intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158255/new/ https://reviews.llvm.org/D158255 ___

[PATCH] D159105: [analyzer] ArrayBoundCheckerV2 should check the region for taint as well

steakhal planned changes to this revision. steakhal added a comment. In D159105#4627883 , @donat.nagy wrote: > In D159105#4627785 , @steakhal > wrote: > >> In D159105#4627724

[PATCH] D141714: Fix ast print of variables with attributes

erichkeane added a comment. I think we can do better naming the tablegen'ed parts, else a bunch of smaller changes. Approach seems good enough to me, though Aaron should scroll through/make a determination after you've fixed my concerns. Comment at: clang/include/clang/Basic

[PATCH] D148131: Avoid unnecessarily aggressive line-breaking when using "LambdaBodyIndentation: OuterScope" with argument bin-packing.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. But please wait for other opinions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148131/new/ https://reviews.llvm.org/D

[PATCH] D159145: [RISCV] Don't add -unaligned-scalar-mem to target features by default.

wangpc accepted this revision. wangpc added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159145/new/ https://reviews.llvm.org/D159145 __

[PATCH] D159213: [AIX][ClangRepl] Disable new tests on AIX

Jake-Egan created this revision. Herald added a project: All. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D159213 Files: clang/unittests/Interpreter/CodeComple

[PATCH] D153339: [clang] Support vectors in __builtin_isfpclass

sepavloff updated this revision to Diff 554750. sepavloff added a comment. Update documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153339/new/ https://reviews.llvm.org/D153339 Files: clang/docs/LanguageExtensions.rst clang/docs/Rele

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ef536a12ea6: [UBSan] Disable the function and kcfi sanitizers on an execute-only target. (authored by MaggieYi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

smeenai added a comment. In D152495#4628028 , @goncharov wrote: > there is a number of unused vaiables in conditional loops that are firing > now, I have submitted > https://github.com/llvm/llvm-project/commit/74f4daef0412be33002bd4e24a30cb47d0187ecf >

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

madanial added a comment. Pinging for review. I will be taking over this patch from Paul, but Paul will still be around to answer any questions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://reviews.llvm.org/D154869 __

[clang] 9ef536a - [UBSan] Disable the function and kcfi sanitizers on an execute-only target.

Author: Ying Yi Date: 2023-08-30T17:17:37+01:00 New Revision: 9ef536a12ea65a2b9e2511936327c7b621af38fb URL: https://github.com/llvm/llvm-project/commit/9ef536a12ea65a2b9e2511936327c7b621af38fb DIFF: https://github.com/llvm/llvm-project/commit/9ef536a12ea65a2b9e2511936327c7b621af38fb.diff LOG:

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

cor3ntin added a comment. It is used, but only in an assert. Seems like the right fix! In D152495#4628778 , @smeenai wrote: > In D152495#4628028 , @goncharov > wrote: > >> there is a number of unused vaiables in

[PATCH] D159206: [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

jmmartinez marked 2 inline comments as done. jmmartinez added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2034 + } + + FuncAttr.addAttribute("target-features", llvm::join(MergedFeatures, ",")); arsenm wrote: > Really it would be less bad if the in

[PATCH] D159206: [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

jmmartinez updated this revision to Diff 554753. jmmartinez marked an inline comment as done. jmmartinez added a comment. - Drop incoming builtins with incompatible target-features Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159206/new/ https://r

[PATCH] D159206: [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

jmmartinez added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:282 } +} Remove { } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159206/new/ https://reviews.llvm.org/D159206

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c9988f85d25: [OpenMP] Allow exceptions in target regions when offloading to GPUs (authored by AntonRydahl). Repository: rG LLVM Github Monorepo

[clang] 3c9988f - [OpenMP] Allow exceptions in target regions when offloading to GPUs

Author: Anton Rydahl Date: 2023-08-30T09:36:22-07:00 New Revision: 3c9988f85d2508bdbc64c81fed7c4b9b8db54262 URL: https://github.com/llvm/llvm-project/commit/3c9988f85d2508bdbc64c81fed7c4b9b8db54262 DIFF: https://github.com/llvm/llvm-project/commit/3c9988f85d2508bdbc64c81fed7c4b9b8db54262.diff

[PATCH] D158963: [CodeGen] Function multi-versioning: don't set comdat for internal linkage resolvers

MaskRay updated this revision to Diff 554756. MaskRay edited the summary of this revision. MaskRay added a comment. add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158963/new/ https://reviews.llvm.org/D158963 Files: clang/docs/Rel

[clang] 651b2fb - [CodeGen] Function multi-versioning: don't set comdat for internal linkage resolvers

Author: Fangrui Song Date: 2023-08-30T09:46:48-07:00 New Revision: 651b2fbc1c7ec4992d2c80b8456c5c5a72394caf URL: https://github.com/llvm/llvm-project/commit/651b2fbc1c7ec4992d2c80b8456c5c5a72394caf DIFF: https://github.com/llvm/llvm-project/commit/651b2fbc1c7ec4992d2c80b8456c5c5a72394caf.diff

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

efriedma added a comment. Maybe split the changes to reformat the unittests into a separate patch? Otherwise, I'm happy with the current state of this patch, but probably someone more active in flang should approve. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

  1   2   >