[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

felix642 created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. felix642 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The documenta

[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

felix642 updated this revision to Diff 554122. felix642 added a comment. Fixed commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159045/new/ https://reviews.llvm.org/D159045 Files: clang-tools-extra/docs/clang-tidy/checks/readability/

[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

felix642 updated this revision to Diff 554124. felix642 added a comment. Linked issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159045/new/ https://reviews.llvm.org/D159045 Files: clang-tools-extra/docs/clang-tidy/checks/readability/function

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

jyu2 marked an inline comment as done. jyu2 added a comment. Thanks. @rnk Comment at: clang/test/CodeGenCXX/ms-inheriting-ctor.cpp:41 + +// CHECK-LABEL: define internal noundef ptr @"??0?$B@_N@@QEAA@AEBVF@@AEBUA@@@Z"(ptr noundef nonnull returned align 1 dereferenceable(1) %t

[PATCH] D126586: [InstrProf] Single byte counters in coverage

ayzhao added a comment. In D126586#4622003 , @gulfem wrote: > Fixed the issue that causes a crash in InstCombinePHI.cpp. Phi instructions > need to be inserted at the beginning of basic blocks, and profile increments > need to be inserted after phis for

[PATCH] D137213: [clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation

dexonsmith added a comment. Now that the behaviour change is understood, maybe it'd be useful to split the patch in two: - First, this patch, plus a call to `ASTReader::getInputFile()` only for its side effects, to make this patch actually NFC. - Second, committed a few days later, a patch that

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl updated this revision to Diff 554132. AntonRydahl added a comment. Rebased on main to see if libc++ CI is still failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153924/new/ https://reviews.llvm.org/D153924 Files: clang/include/

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

jhuber6 added a comment. The libcxx tests are always broken randomly in my experience. I wouldn't worry about it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153924/new/ https://reviews.llvm.org/D153924 _

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc1b5674fbb76: [OpenMP] Change OpenMP default version in documentation and help text for… (authored by AntonRydahl). Repos

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl added a comment. In D153924#4623357 , @jhuber6 wrote: > The libcxx tests are always broken randomly in my experience. I wouldn't > worry about it. Thanks a bunch! I did not know that. Shall I just land the patch? Repository: rG LLVM Gith

[clang] c1b5674 - [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version

Author: Anton Rydahl Date: 2023-08-28T19:05:55-07:00 New Revision: c1b5674fbb76c4b137a1e856441019605668f1ca URL: https://github.com/llvm/llvm-project/commit/c1b5674fbb76c4b137a1e856441019605668f1ca DIFF: https://github.com/llvm/llvm-project/commit/c1b5674fbb76c4b137a1e856441019605668f1ca.diff

[PATCH] D158977: [clang][dataflow] Don't associate prvalue expressions with storage locations.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Thanks! Sometimes I am wondering whether we actually need a full map for PRValues. E.g., once we processed a `MaterializeTemporaryExpr`, we now have a location for the value, and it feel

[PATCH] D133361: [BPF] Attribute btf_decl_tag("ctx") for structs

yonghong-song added a comment. I will try to review other parts of code in the next few days. Comment at: llvm/include/llvm/IR/Intrinsics.td:2432 ImmArg>]>; +def int_context_marker_bpf : DefaultAttrsIntrinsic<[llvm_ptr_ty], +

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

brad updated this revision to Diff 554140. brad added a comment. Remove C_INCLUDE_DIRS bits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158376/new/ https://reviews.llvm.org/D158376 Files: clang/lib/Driver/ToolChains/DragonFly.cpp clang/lib/

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

glandium added a comment. This conflicts with D146664 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158475/new/ https://reviews.llvm.org/D158475 ___ cfe-commits mailing

[clang] 196ff0c - [Driver] Add LiteOS and z/OS to ShouldAddDefaultIncludePaths()

Author: Brad Smith Date: 2023-08-28T23:01:50-04:00 New Revision: 196ff0c7ddacf571a3fc6c9163e85fd91ecab6b3 URL: https://github.com/llvm/llvm-project/commit/196ff0c7ddacf571a3fc6c9163e85fd91ecab6b3 DIFF: https://github.com/llvm/llvm-project/commit/196ff0c7ddacf571a3fc6c9163e85fd91ecab6b3.diff LO

[PATCH] D159042: [Driver] Add LiteOS and z/OS to ShouldAddDefaultIncludePaths()

This revision was automatically updated to reflect the committed changes. Closed by commit rG196ff0c7ddac: [Driver] Add LiteOS and z/OS to ShouldAddDefaultIncludePaths() (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159042/new/ h

[PATCH] D158709: [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces so that they can be modularized

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158709/new/ https://reviews.llvm.org/D158709 ___ cfe-commits mailing list cfe-commits@

[clang] 6f1b2e4 - [NFC] Correct the test code in pr65018

Author: Chuanqi Xu Date: 2023-08-29T11:30:47+08:00 New Revision: 6f1b2e4e97e2d6e8f19a9a6d64547b027617fa39 URL: https://github.com/llvm/llvm-project/commit/6f1b2e4e97e2d6e8f19a9a6d64547b027617fa39 DIFF: https://github.com/llvm/llvm-project/commit/6f1b2e4e97e2d6e8f19a9a6d64547b027617fa39.diff LO

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad created this revision. brad added reviewers: MaskRay, tstellar, probinson. brad added a project: clang. Herald added subscribers: pmatos, asb, abrachet, jgravelle-google, sbc100, dschuff, emaste. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: a

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Technically there is some risk but I think the blast radius, if present, is extremely small. `C_INCLUDE_DIRS` is not recognized by GCC. If I use https://sourcegraph.com/search?q=context:gl

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

wangpc marked 2 inline comments as done. wangpc added inline comments. Comment at: clang/include/clang/Basic/SizedDeallocation.h:23 +namespace clang { +inline llvm::VersionTuple sizedDeallocMinVersion(llvm::Triple::OSType OS) { + switch (OS) { MaskRay wrote: > D

[PATCH] D158739: AIX: Issue an error when specifying an alias for a common symbol

hubert.reinterpretcast added a comment. Aside from the comments Digger has made, I have no additional concerns about this patch. It is an improvement (although there are adjacent cases that need further handling). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad updated this revision to Diff 554156. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159054/new/ https://reviews.llvm.org/D159054 Files: clang/CMakeLists.txt clang/include/clang/Config/config.h.cmake clang/lib/Driver/ToolChains/Darwin.cpp

[PATCH] D159018: [clang][modules] Add a c23 module feature

iana updated this revision to Diff 554158. iana added a comment. remove the extra #endif (which oddly didn't produce an error locally so I must've ran the tests wrong the first time...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159018/new/ htt

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

mstorsjo added a comment. In D152054#4622642 , @vadikp-intel wrote: > Windows importing is now done by name, and new exports do not need to have an > ordinal specified for them i.e. you can add a line with just the API name to > dllexports. Oh, right,

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana created this revision. iana added reviewers: aaron.ballman, rsmith, efriedma, ldionne, ChuanqiXu, Bigcheese, vsapsai, benlangmuir, dexonsmith. Herald added a subscriber: ributzka. Herald added a project: All. iana requested review of this revision. Herald added a project: clang. Herald added

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana updated this revision to Diff 554183. iana added a comment. Remove the module cache before running the stdarg/stddef unit tests in module mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159064/new/ https://reviews.llvm.org/D159064 Files:

[clang] 0cfc2db - [OpenMP] Allow exceptions in target regions when offloading to GPUs

Author: Anton Rydahl Date: 2023-08-28T22:36:13-07:00 New Revision: 0cfc2dba93b172802b580713a492ea14148a0218 URL: https://github.com/llvm/llvm-project/commit/0cfc2dba93b172802b580713a492ea14148a0218 DIFF: https://github.com/llvm/llvm-project/commit/0cfc2dba93b172802b580713a492ea14148a0218.diff

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cfc2dba93b1: [OpenMP] Allow exceptions in target regions when offloading to GPUs (authored by AntonRydahl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

smeenai added a comment. In D158475#4623471 , @glandium wrote: > This conflicts with D146664 It sounds like you want the same logic as D158476 to apply to the stdlib search as well as

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

glandium added a comment. In D158475#4623842 , @smeenai wrote: > In D158475#4623471 , @glandium > wrote: > >> This conflicts with D146664 > > It sounds like you want the same lo

[PATCH] D159018: [clang][modules] Add a c23 module feature

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! In D159018#4622598 , @iana wrote: > Would we want to back port this to llvm 17? Yes probably. Repository: rG LLVM Github Monore

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana updated this revision to Diff 554193. iana added a comment. Add `@import` tests for all of the new modules Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159064/new/ https://reviews.llvm.org/D159064 Files: clang/lib/Headers/__stddef_max_alig

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana added inline comments. Comment at: clang/lib/Headers/__stddef_null.h:14 + * __need_NULL and rely on stddef.h to redefine NULL to the correct value again. + * Modules don't support redefining macros like that, but support that pattern + * in the non-modules case. ---

[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Change is ok. Interesting thing is that we got more of such issues in many checks. I'm thinking, maybe support for optional fields is needed, fields that can accept integer or false/no val

[clang] 20e6515 - [Coroutines] Mark 'coroutine_handle<>::address' as always-inline

Author: Chuanqi Xu Date: 2023-08-29T14:35:27+08:00 New Revision: 20e6515d5c5ff155a54e10f64caef1c76d8d5976 URL: https://github.com/llvm/llvm-project/commit/20e6515d5c5ff155a54e10f64caef1c76d8d5976 DIFF: https://github.com/llvm/llvm-project/commit/20e6515d5c5ff155a54e10f64caef1c76d8d5976.diff LO

[PATCH] D159068: [clang][X86] Update excessive register save diagnostic to more closely follow the interrupt attribute spec

antangelo created this revision. antangelo added reviewers: erichkeane, aaron.ballman, mibintc. Herald added a project: All. antangelo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The original diagnostic does not cover all cases accordin

[clang] aef05a1 - [clang][dataflow][NFC] Eliminate `getStorageLocation()` / `setStorageLocation()` in `DataflowAnalysisContext`.

Author: Martin Braenne Date: 2023-08-29T06:53:48Z New Revision: aef05a12329cf83c0a6fe46b464ab6ac08ee3439 URL: https://github.com/llvm/llvm-project/commit/aef05a12329cf83c0a6fe46b464ab6ac08ee3439 DIFF: https://github.com/llvm/llvm-project/commit/aef05a12329cf83c0a6fe46b464ab6ac08ee3439.diff LOG

[PATCH] D158981: [clang][dataflow][NFC] Eliminate `getStorageLocation()` / `setStorageLocation()` in `DataflowAnalysisContext`.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaef05a12329c: [clang][dataflow][NFC] Eliminate `getStorageLocation()` / `setStorageLocation… (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

<    1   2   3