[clang] 615d812 - [clang][ExprConstant] Improve error message of compound assignment against uninitialized object

Author: Takuya Shimizu Date: 2023-08-25T16:08:07+09:00 New Revision: 615d812696ee8827d6d78ad106d6022ff2778137 URL: https://github.com/llvm/llvm-project/commit/615d812696ee8827d6d78ad106d6022ff2778137 DIFF: https://github.com/llvm/llvm-project/commit/615d812696ee8827d6d78ad106d6022ff2778137.diff

[PATCH] D157855: [clang][ExprConstant] Improve error message of compound assignment against uninitialized object

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG615d812696ee: [clang][ExprConstant] Improve error message of compound assignment against… (authored by hazohelet). Changed prior to commit: https:

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. I'm not entirely convinced by the motivation (wouldn't it be better to just fix the tests?), but this seems like a perfectly reasonable flag to have. CHANGES SINCE LAST ACTION https://revie

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

efocht added a comment. Can somebody please revert this patch? It kills all builds on https://lab.llvm.org/buildbot/#/builders/91 since yesterday. @serge-sans-paille ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158558/new/ https://reviews.llvm

[clang] 01b2554 - [clang] - Add missing builtin name to AtomicExpr JSON dump

Author: serge-sans-paille Date: 2023-08-25T09:18:18+02:00 New Revision: 01b2554ff4defce979b16d794c13ea99f2e2c155 URL: https://github.com/llvm/llvm-project/commit/01b2554ff4defce979b16d794c13ea99f2e2c155 DIFF: https://github.com/llvm/llvm-project/commit/01b2554ff4defce979b16d794c13ea99f2e2c155.d

[PATCH] D158691: [clang-tidy] Container-size-empty fixed c++ version in tests to support string_literals operator

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158691/new/ https://reviews.llvm.org/D158691 ___

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:116-118 +- Improved :doc:`readability-identifier-naming + ` check to allow for + Leading_upper_snake_case naming convention. Wrong section, add it under "Changes in existing che

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

serge-sans-paille added a comment. In D158558#4616275 , @efocht wrote: > Can somebody please revert this patch? It kills all builds on > https://lab.llvm.org/buildbot/#/builders/91 since yesterday. > @serge-sans-paille ? This got reverted by https://r

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

PiotrZSL added a comment. And add reference to issue in commit description. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https://reviews.llvm.org/D158787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D158820: [Sema][HLSL] Fix naming of anyhit/closesthit shaders

bogner created this revision. bogner added reviewers: beanz, python3kgae. Herald added subscribers: Anastasia, mcrosier. Herald added a reviewer: aaron.ballman. Herald added a project: All. bogner requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commi

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner updated this revision to Diff 553395. bogner added a comment. Broke out a couple of semi-unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158803/new/ https://reviews.llvm.org/D158803 Files: clang/include/clang/Basic/Attr.td

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin added inline comments. Comment at: clang/test/CXX/drs/dr25xx.cpp:104-106 +struct D : B { + void f(this D&); // expected-error {{an explicit object parameter cannot appear in a virtual function}} +}; aaron.ballman wrote: > I'd like to see two other test

[PATCH] D158822: [Fuchsia] Make __start_* / __stop_* symbols hidden

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added a subscriber: abrachet. Herald added a project: All. phosek requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This is the intended semantics, see for more d

[PATCH] D158822: [Fuchsia] Make __start_* / __stop_* symbols hidden

phosek updated this revision to Diff 553402. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158822/new/ https://reviews.llvm.org/D158822 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp Index: clang/lib/Driver/ToolChains/Fuchsia.cpp ===

[PATCH] D158822: [Fuchsia] Make __start_* / __stop_* symbols hidden

phosek updated this revision to Diff 553403. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158822/new/ https://reviews.llvm.org/D158822 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/test/Driver/fuchsia.c Index: clang/test/Driver/fuchsia

[clang] 8760ff1 - Revert "[clang] - Add missing builtin name to AtomicExpr JSON dump"

Author: serge-sans-paille Date: 2023-08-25T09:51:44+02:00 New Revision: 8760ff163cc26f4411956a7d5678fe0aa7faa064 URL: https://github.com/llvm/llvm-project/commit/8760ff163cc26f4411956a7d5678fe0aa7faa064 DIFF: https://github.com/llvm/llvm-project/commit/8760ff163cc26f4411956a7d5678fe0aa7faa064.d

[PATCH] D158822: [Fuchsia] Make __start_* / __stop_* symbols hidden

phosek updated this revision to Diff 553404. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158822/new/ https://reviews.llvm.org/D158822 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/test/Driver/fuchsia.c clang/test/Driver/fuchsia.cpp

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

sandeepkosuri updated this revision to Diff 553405. sandeepkosuri added a comment. Made LIT test cases more robust to check lines ordering problem Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152054/new/ https://reviews.llvm.org/D152054 Files:

[clang] ea32f99 - [Sema][HLSL] Clarify wording. NFC

Author: Justin Bogner Date: 2023-08-25T01:03:22-07:00 New Revision: ea32f9948023ef168f6ea8f61c33c268f153a0ce URL: https://github.com/llvm/llvm-project/commit/ea32f9948023ef168f6ea8f61c33c268f153a0ce DIFF: https://github.com/llvm/llvm-project/commit/ea32f9948023ef168f6ea8f61c33c268f153a0ce.diff

[clang] d43f324 - [Sema][HLSL] Remove some duplicated code. NFC

Author: Justin Bogner Date: 2023-08-25T01:03:22-07:00 New Revision: d43f324f6de40f81001e4105fe99305ac3b1c875 URL: https://github.com/llvm/llvm-project/commit/d43f324f6de40f81001e4105fe99305ac3b1c875 DIFF: https://github.com/llvm/llvm-project/commit/d43f324f6de40f81001e4105fe99305ac3b1c875.diff

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

ilya-biryukov requested changes to this revision. ilya-biryukov added a subscriber: sammccall. ilya-biryukov added a comment. This revision now requires changes to proceed. Open question: I also feel like the best option here is to fix the tests, but I'm not sure how hard that would be. @sammccal

[PATCH] D158811: [X86] __builtin_cpu_supports: support x86-64{,-v2,-v3,-v4}

pengfei added inline comments. Comment at: llvm/include/llvm/TargetParser/X86TargetParser.h:63 + +#define X86_FEATURE(ENUM, STRING) +#define X86_MICROARCH_LEVEL(ENUM, STRING, PRIORITY) FEATURE_##ENUM = PRIORITY, Not needed. Comment at: llvm/lib

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

MaggieYi updated this revision to Diff 553409. MaggieYi edited the summary of this revision. MaggieYi added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. The changes include: 1. Added an ARM::supportedExecuteOnly function to avoid the duplicated code.

[PATCH] D154382: [ClangRepl] support code completion at a REPL

sammccall added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:845 case CodeCompletionContext::CCC_NewName: + case CodeCompletionContext::CCC_TopLevelOrExpression: return false; This should be `true` rather than `false`, since bot

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin marked 4 inline comments as done. cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx2b-deducing-this.cpp:19 + +void g(this auto) const; // expected-error{{a function with an explicit object parameter cannot be const}} +void h(this auto) &; // exp

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam updated this revision to Diff 553413. saiislam marked 2 inline comments as done. saiislam added a comment. Changed getImplicitArgsSize to use sizeof. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139730/new/ https://reviews.llvm.org/D13973

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

MaggieYi added a comment. Thanks @simon_tatham and @MaskRay for the quick code review. When I work on this issue, I want to add an error for both clang and clang -cc1. `-mexecute-only` is an ARM-only compiler option. The clang Driver will convert `-mexecute-only` to `-target-feature +execute-

[PATCH] D158827: [clang] Fix assertion fail when function has cleanups and fatal errors

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/48974 Repository: rG LLVM Github Monorepo https://reviews.llvm.or

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin marked 2 inline comments as done. cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7260-7265 +def ext_deducing_this : ExtWarn< + "explicit object parameters are a C++2b extension">, + InGroup; +def warn_cxx20_ext_deducing_thi

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158763/new/ https://reviews.llvm.org/D158763 ___

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt updated this revision to Diff 553437. RIscRIpt marked 2 inline comments as done. RIscRIpt added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/ https://reviews.llvm.org/D158591 Files: clang/i

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt added a comment. Regarding new interpreter. It takes more time and effort than I expected. Here's what I found: 1. Assertion in ByteCodeExprGen::VisitPredefinedExpr

[clang] 5e60345 - [clang] Also run the clang tests as part of the Clang-specific CI pipeline

Author: Louis Dionne Date: 2023-08-25T07:52:40-04:00 New Revision: 5e603450bb33e99aada164fc9f647c6bec21e092 URL: https://github.com/llvm/llvm-project/commit/5e603450bb33e99aada164fc9f647c6bec21e092 DIFF: https://github.com/llvm/llvm-project/commit/5e603450bb33e99aada164fc9f647c6bec21e092.diff

[PATCH] D158765: [clang] Also run the clang tests as part of the Clang-specific CI pipeline

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5e603450bb33: [clang] Also run the clang tests as part of the Clang-specific CI pipeline (authored by ldionne). Repositor

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:13033 + ExprResult Res = FixOverloadedFunctionReference(E, DAP, Found); + if (Res.isInvalid()) +return false; aaron.ballman wrote: > Below you assume that `Res.get()` returns a nonn

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. I'm happy punting the new interpreter to a subsequent PR, maybe there are unresolved issues with string literals? Anyway, we don't have to scope creep further, LGTM Thanks for working on t

[PATCH] D158775: [NFC] Initialize member pointer and avoid potential null dereference

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM though I can take or leave the changes to ThreadSafety.cpp. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2243 const auto *CurrentFunction = dyn_cast(

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt added a comment. In D158591#4616728 , @RIscRIpt wrote: > And it seems that `BasePtr` points to a different object, not the one which > corresponds to StringLiteral (at step 2). If I understand everything correctly, then in visitGlobalInitialize

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM but the changes need to be landed with a release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158557/new/ https://reviews.llvm.org/D158557 _

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Stmt.h:596-597 -// These don't need to be particularly wide, because they're -// strictly limited by the forms of expressions we permit. -unsigned NumSubExprs : 8; -unsigned ResultIndex : 3

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt updated this revision to Diff 553444. RIscRIpt added a comment. Rebased onto main, fixed commit messages, fixed formatting, re-run lit for clang/test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/ https://reviews.llvm.org/D1585

[PATCH] D158318: [Sema] tolerate more promotion matches in format string checking

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D158318#4615285 , @fcloutier wrote: > It seems that clang allows `char` specifiers to match `bool` in `scanf` > today, without my cha

[PATCH] D158562: [clang][Sema] Add truncation warning on fortified snprintf

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/lib/Sema/SemaChecking.cpp:1041 + ASTContext &Context) { + if (auto *Format = dyn_cast(FormatExpr); + Format && (Format->isOrdinary() || Forma

[PATCH] D158813: [analyzer] MPIChecker: MPI_Waitall should respect count arg

steakhal added a comment. Let me try to summarize some of the variables: So, given an invocation like `MPI_Waitall(C, Requests, Statues)`: - `MR` is `lval(Requests)` - `ElementCount` is the number of elements `Requests` consist of. - `ArrSize` is basically `ElementCount` but an APSInt. - `MROffs

[PATCH] D158766: [AST] TypeSourceInfo for params of inherited constructor should be null

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:13929 Context, DerivedCtor, UsingLoc, UsingLoc, /*IdentifierInfo=*/nullptr, -FPT->getParamType(I), TInfo, SC_None, /*DefArg=*/nullptr); +FPT->getParamType(I), /*TInfo=*/nullpt

[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

usaxena95 created this revision. usaxena95 added reviewers: massberg, sammccall. Herald added a subscriber: kadircet. Herald added a project: All. usaxena95 requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. This is similar t

[PATCH] D158771: [clang][tooling] Fix `name` range-selector to handle TypeLocs correctly.

ymandel updated this revision to Diff 553455. ymandel marked 2 inline comments as done. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158771/new/ https://reviews.llvm.org/D158771 Files: clang/lib/Tooling

[PATCH] D158771: [clang][tooling] Fix `name` range-selector to handle TypeLocs correctly.

ymandel updated this revision to Diff 553456. ymandel added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158771/new/ https://reviews.llvm.org/D158771 Files: clang/lib/Tooling/Transformer/RangeSelector.cpp clang/unittes

[PATCH] D158718: [Clang] Handle ellipsises in abiguous cast expressions.

cor3ntin abandoned this revision. cor3ntin added a comment. As described here, clang is actually conforming, there is an open core issue with unclear resolution and that ""fix"" doesn't cover all the ambiguous use cases https://github.com/llvm/llvm-project/issues/64926 Repository: rG LLVM Gi

[PATCH] D158367: [AMDGPU] Add target feature gws to clang

yaxunl updated this revision to Diff 553463. yaxunl retitled this revision from "[AMDGPU] Add target feature gds/gws to clang" to "[AMDGPU] Add target feature gws to clang". yaxunl added a comment. Herald added a reviewer: kiranchandramohan. remove gds feature since it is not used CHANGES SINCE

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

steakhal added a comment. I checked out the code to see how does the Static Analyzer work after this. I'm impressed that it seems to work. Do you mind adding my test file to this patch? `clang/test/Analysis/cxx2b-deducing-this.cpp`: // RUN: %clang_analyze_cc1 -std=c++2b -verify %s \ // RUN:

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

erichkeane added a comment. I suggest doing the -511LL value from the original bug report in the tests as well, else, fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158557/new/ https://reviews.llvm.org/D158557 ___ cfe-commits mail

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

erichkeane requested changes to this revision. erichkeane added a comment. This revision now requires changes to proceed. Ah, wait, still no release note! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158557/new/ https://reviews.llvm.org/D158557

[PATCH] D158135: [Clang][CodeGen] Add __builtin_bcopy

cseo updated this revision to Diff 553467. cseo added a comment. Address issues from the last revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158135/new/ https://reviews.llvm.org/D158135 Files: clang/include/clang/Basic/Builtins.def cl

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

erichkeane added a comment. Mostly just nits (plus my hatred for C style casts :) ), I didn't see any issues with the approach. Comment at: clang/include/clang/AST/ASTLambda.h:45 + return isLambdaCallOperator(DC) && + !cast(DC)->getType().isNull() && + !cast(D

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I see aaron mentioned the release note and is ok with it happening on commit, so I'll undo my 'needs revision'. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158557/new/ http

[PATCH] D158771: [clang][tooling] Fix `name` range-selector to handle TypeLocs correctly.

ymandel updated this revision to Diff 553471. ymandel added a comment. tweak Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158771/new/ https://reviews.llvm.org/D158771 Files: clang/lib/Tooling/Transformer/RangeSelector.cpp clang/unittests/Tool

[clang] c783258 - [clang][tooling] Fix `name` range-selector to handle TypeLocs correctly.

Author: Yitzhak Mandelbaum Date: 2023-08-25T14:44:43Z New Revision: c78325815062d62f0e2c68b6e72bb31b60c48260 URL: https://github.com/llvm/llvm-project/commit/c78325815062d62f0e2c68b6e72bb31b60c48260 DIFF: https://github.com/llvm/llvm-project/commit/c78325815062d62f0e2c68b6e72bb31b60c48260.diff

[PATCH] D158771: [clang][tooling] Fix `name` range-selector to handle TypeLocs correctly.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc78325815062: [clang][tooling] Fix `name` range-selector to handle TypeLocs correctly. (authored by ymandel). Repository: rG LLVM Github Monorepo

[PATCH] D156624: [clang-tidy] Access checks not done classes derived of std::array

PiotrZSL accepted this revision. PiotrZSL added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156624/new/ https://reviews.llvm.org/D156624 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D158848: [clang][dataflow] Support range-for loops in fixpoint algorithm.

ymandel created this revision. ymandel added reviewers: mboehme, xazax.hun. Herald added a subscriber: martong. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Adds support for recognizing range-for loops in the m

[PATCH] D158851: [clangd] Avoid null result in FindRecordTypeAt()

nridge created this revision. nridge added reviewers: kadircet, hokein. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository:

[PATCH] D156624: [clang-tidy] Access checks not done classes derived of std::array

sousajo added a comment. thanks for the review. can you please land it for me pls? Jorge Pinto Sousa Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156624/new/ https://reviews.llvm.org/D156624 ___ cfe-c

[PATCH] D78028: move shebangs from python2 to python3

LocutusOfBorg updated this revision to Diff 553486. Herald added a subscriber: PiotrZSL. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78028/new/ https://reviews.llvm.org/D78028 Files: llvm-toolchain-snapshot_16~++20230110111828+ded988ed0c00/clang-tools-extra/clang-include-fixer/find-

[PATCH] D158827: [clang] Fix assertion fail when function has cleanups and fatal errors

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. Thank you for the fix! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158827/new/ https://reviews.llvm.org/D158827

[PATCH] D78028: move shebangs from python2 to python3

LocutusOfBorg added a comment. Updated changes! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78028/new/ https://reviews.llvm.org/D78028 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

erjin updated this revision to Diff 553488. erjin added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158763/new/ https://reviews.llvm.org/D158763 Files: clang/include/clang/Driver/Options.td flang/test/Driver/driver-help-hid

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

erjin added a comment. In D158763#4616664 , @awarzynski wrote: > LGTM, thank you! Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158763/new/ https://reviews.llvm.org/D158763 __

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

sandeepkosuri updated this revision to Diff 553487. sandeepkosuri added a comment. made new LIT test cases target specific to linux Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152054/new/ https://reviews.llvm.org/D152054 Files: clang/include/c

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case issue 42451

MasterCopy8GB updated this revision to Diff 553494. MasterCopy8GB added a comment. Update documentation for issue 42451 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https://reviews.llvm.org/D158787 Files: clang-tools-extra/docs/ReleaseNotes.rst clang-tools-extra/docs/c

[PATCH] D158855: [analyzer][NFC] Remove useless class BuiltinBug

donat.nagy created this revision. donat.nagy added reviewers: Szelethus, steakhal, gamesh411, NoQ. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. donat.nagy requested review of this re

[PATCH] D158851: [clangd] Avoid null result in FindRecordTypeAt()

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! (Both assigned reviewers are currently out on vacation) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158851/new/ https://reviews.

[PATCH] D158855: [analyzer][NFC] Remove useless class BuiltinBug

donat.nagy added inline comments. Herald added a subscriber: ormris. Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:35-36 public Checker { - mutable std::unique_ptr BT; + mutable std::unique_ptr BT; mutable std::unique_ptr TaintBT; -

[clang-tools-extra] 1994e11 - [clangd] Avoid null result in FindRecordTypeAt()

Author: Nathan Ridge Date: 2023-08-25T11:50:19-04:00 New Revision: 1994e1173b64b61c07f8acf107f29c2c015575b4 URL: https://github.com/llvm/llvm-project/commit/1994e1173b64b61c07f8acf107f29c2c015575b4 DIFF: https://github.com/llvm/llvm-project/commit/1994e1173b64b61c07f8acf107f29c2c015575b4.diff

[PATCH] D158851: [clangd] Avoid null result in FindRecordTypeAt()

This revision was automatically updated to reflect the committed changes. Closed by commit rG1994e1173b64: [clangd] Avoid null result in FindRecordTypeAt() (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158851/new/ https://revie

[clang] b8a9c50 - [AMDGPU] Add target feature gws to clang

Author: Yaxun (Sam) Liu Date: 2023-08-25T11:50:47-04:00 New Revision: b8a9c50f22947284577a0a49038ea8ae5d45d6fa URL: https://github.com/llvm/llvm-project/commit/b8a9c50f22947284577a0a49038ea8ae5d45d6fa DIFF: https://github.com/llvm/llvm-project/commit/b8a9c50f22947284577a0a49038ea8ae5d45d6fa.dif

[PATCH] D158367: [AMDGPU] Add target feature gws to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8a9c50f2294: [AMDGPU] Add target feature gws to clang (authored by yaxunl). Herald added projects: clang, Flang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D158848: [clang][dataflow] Support range-for loops in fixpoint algorithm.

ymandel updated this revision to Diff 553505. ymandel added a comment. fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158848/new/ https://reviews.llvm.org/D158848 Files: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp c

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case issue 42451

MasterCopy8GB updated this revision to Diff 553504. MasterCopy8GB added a comment. Update diff with complete patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https://reviews.llvm.org/D158787 Files: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp cl

[PATCH] D158709: [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces so that they can be modularized

aaron.ballman added a reviewer: ChuanqiXu. aaron.ballman added a comment. I'm a bit concerned about the impact on (non-modules) build time performance. This splits stddef.h and stdarg.h into needing to open 14 different files instead of 2. Hopefully that's not a lot of overhead, but given that s

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

bryanpkc added inline comments. Comment at: clang/include/clang/Driver/Options.td:821 def L : JoinedOrSeparate<["-"], "L">, Flags<[RenderJoined]>, Group, +Visibility<[ClangOption, FlangOption]>, MetaVarName<"">, HelpText<"Add directory to library search path">;

[PATCH] D158855: [analyzer][NFC] Remove useless class BuiltinBug

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/BoolAssignmentChecker.cpp:27 class BoolAssignmentChecker : public Checker< check::Bind > { -mutable std::unique_ptr BT; +mutable std::unique_ptr BT; void emitReport(ProgramStateRef stat

[PATCH] D158857: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr for aarch64

a_vorobev created this revision. a_vorobev added reviewers: clang, akhuang, rnk. a_vorobev added a project: clang. Herald added subscribers: pengfei, hiraditya, kristof.beyls, arichardson. Herald added a project: All. a_vorobev requested review of this revision. Herald added subscribers: llvm-commi

[PATCH] D158858: [analyzer] MPIChecker: add defensive checking (check against nullptr)

danix800 created this revision. danix800 added reviewers: donat.nagy, steakhal. danix800 added a project: clang. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot added a comment. > so you could replace the logic that prints the return type + arg list with > `printType(functype, class, methodname)` (from AST.h). That should pick up > noexcept etc. I've tried it and it's not obvious to me how to do it properly: Since `printType` wants to print the

[PATCH] D148131: Avoid unnecessarily aggressive line-breaking when using "LambdaBodyIndentation: OuterScope" with argument bin-packing.

jp4a50 added a comment. Hello @owenpan , @HazardyKnusperkeks . Now that https://reviews.llvm.org/D156259 is merged, please can you take a look at this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148131/new/ https://reviews.llvm.org/D148

[PATCH] D158813: [analyzer] MPIChecker: MPI_Waitall should respect count arg

danix800 updated this revision to Diff 553514. danix800 edited the summary of this revision. danix800 added a comment. 1. Move out complicated computation into separate function; 2. Only check `ConreteInt` request count. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D158813: [analyzer] MPIChecker: MPI_Waitall should respect count arg

danix800 added a comment. In D158813#4616816 , @steakhal wrote: > Let me try to summarize some of the variables: > > So, given an invocation like `MPI_Waitall(C, Requests, Statues)`: > > - `MR` is `lval(Requests)` > - `ElementCount` is the number of eleme

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

erjin added inline comments. Comment at: clang/include/clang/Driver/Options.td:821 def L : JoinedOrSeparate<["-"], "L">, Flags<[RenderJoined]>, Group, +Visibility<[ClangOption, FlangOption]>, MetaVarName<"">, HelpText<"Add directory to library search path">; ---

[PATCH] D158813: [analyzer] MPIChecker: MPI_Waitall should respect count arg

danix800 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MPI-Checker/MPIChecker.cpp:46-48 +if (!ErrorNode) + return; + steakhal wrote: > If these hunks are not closely related to the issue you intend to fix in this > PR, I'd suggess

[PATCH] D158857: [clang][aarch64] Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr for aarch64

a_vorobev updated this revision to Diff 553518. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158857/new/ https://reviews.llvm.org/D158857 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/AArch64.h clang/test/CodeGen/ms-mixed-ptr-sizes.c llvm/lib/Target/AArch64/

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case issue 42451

PiotrZSL added a comment. Upload full path to avoid "Context not available." Comment at: clang-tools-extra/docs/ReleaseNotes.rst:256 +- Improved :doc:`readability-identifier-naming + ` Leading_upper_snake_case -> put this entry in alphabetical order =

[PATCH] D158813: [analyzer] MPIChecker: MPI_Waitall should respect count arg

danix800 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MPI-Checker/MPIChecker.cpp:185-188 +CharUnits ElemSizeInChars = ASTCtx.getTypeSizeInChars(ElemType); +int64_t ElemSizeInBits = +(ElemSizeInChars.isZero() ? 1 : ElemSizeInChars.getQuantit

[PATCH] D158813: [analyzer] MPIChecker: MPI_Waitall should respect count arg

danix800 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MPI-Checker/MPIChecker.cpp:189-190 +ASTCtx.getCharWidth(); +const NonLoc MROffset = +SVB.makeArrayIndex(MR->getAsOffset().getOffset() / ElemSizeInBits); steakhal w

[PATCH] D158813: [analyzer] MPIChecker: MPI_Waitall should respect count arg

danix800 added inline comments. Comment at: clang/test/Analysis/mpichecker.cpp:286-288 + for (int i = 0; i < 3; ++i) +MPI_Ireduce(MPI_IN_PLACE, &buf, 1, MPI_DOUBLE, MPI_SUM, 0, MPI_COMM_WORLD, +&rs.req[i]); steakhal wrote: > This loop here im

[PATCH] D158813: [analyzer] MPIChecker: MPI_Waitall should respect count arg

danix800 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MPI-Checker/MPIChecker.cpp:192-198 +SVal Count = CE.getArgSVal(0); +for (size_t i = 0; i < ArrSize; ++i) { + const NonLoc Idx = Ctx.getSValBuilder().makeArrayIndex(i); + auto CountReac

[PATCH] D158813: [analyzer] MPIChecker: MPI_Waitall should respect count arg

danix800 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MPI-Checker/MPIChecker.cpp:195 + const NonLoc Idx = Ctx.getSValBuilder().makeArrayIndex(i); + auto CountReached = SVB.evalBinOp(State, BO_GE, Idx, Count, ASTCtx.BoolTy) +

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

bryanpkc added inline comments. Comment at: clang/include/clang/Driver/Options.td:821 def L : JoinedOrSeparate<["-"], "L">, Flags<[RenderJoined]>, Group, +Visibility<[ClangOption, FlangOption]>, MetaVarName<"">, HelpText<"Add directory to library search path">;

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

jacek added a comment. I published an initial version of my attempt at documenting this stuff here: https://wiki.winehq.org/ARM64ECToolchain. It's not yet complete, but I hope it's already useful. I plan to extend it in the future. If some clarification or more information would be useful, plea

[clang] 1561495 - [flang][driver] Mark -L as visible in Flang

Author: Hao Jin Date: 2023-08-25T13:01:49-04:00 New Revision: 1561495cd128a641b9efcbb9d19d36e5a9c5e952 URL: https://github.com/llvm/llvm-project/commit/1561495cd128a641b9efcbb9d19d36e5a9c5e952 DIFF: https://github.com/llvm/llvm-project/commit/1561495cd128a641b9efcbb9d19d36e5a9c5e952.diff LOG:

  1   2   >