[clang] 63f0833 - [clang] Fix missing contract flag in sqrt intrinsic

Author: Yaxun (Sam) Liu Date: 2023-08-24T19:15:17-04:00 New Revision: 63f0833ec4beb7d6bc63759ad8b336ad6dce0f93 URL: https://github.com/llvm/llvm-project/commit/63f0833ec4beb7d6bc63759ad8b336ad6dce0f93 DIFF: https://github.com/llvm/llvm-project/commit/63f0833ec4beb7d6bc63759ad8b336ad6dce0f93.dif

[clang] 9da61ae - [OpenMP] Emit offloading entries for indirect target variables

Author: Joseph Huber Date: 2023-08-24T18:21:13-05:00 New Revision: 9da61aed751ea6a51e7fa2e970de896d3cc27791 URL: https://github.com/llvm/llvm-project/commit/9da61aed751ea6a51e7fa2e970de896d3cc27791 DIFF: https://github.com/llvm/llvm-project/commit/9da61aed751ea6a51e7fa2e970de896d3cc27791.diff

[PATCH] D157738: [OpenMP] Emit offloading entries for indirect target variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG9da61aed751e: [OpenMP] Emit offloading entries for indirect target variables (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157738/new/

[PATCH] D158666: [Clang] Fix linker error for function multiversioning

eandrews added a comment. aarch64 has different mangling for default functions when using target_clones. Sigh `int __attribute__((target_clones("ls64_v+fp16", "default"))) foo_ovl(int) { return 1; }` results in `@_Z7foo_ovli._Mfp16Mls64_v` and `@_Z7foo_ovlv`. Note there is no ".default" as in

[PATCH] D158795: Fix AlignArrayOfStructures + Cpp11BracedListStyle=false

galenelias created this revision. galenelias added a project: clang-format. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. galenelias requested review of this revision. Fixes: https://github.co

[clang] e94c171 - [clang][Driver] recognize `-ffp-contract=fast-honor-pragmas`

Author: Yaxun (Sam) Liu Date: 2023-08-24T19:50:10-04:00 New Revision: e94c171ddb036e9672681d74725069352dd04d0e URL: https://github.com/llvm/llvm-project/commit/e94c171ddb036e9672681d74725069352dd04d0e DIFF: https://github.com/llvm/llvm-project/commit/e94c171ddb036e9672681d74725069352dd04d0e.dif

[PATCH] D145648: [clang][Driver] recognize `-ffp-contract=fast-honor-pragmas`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe94c171ddb03: [clang][Driver] recognize `-ffp-contract=fast-honor-pragmas` (authored by yaxunl). Herald added a project: clang. Repository: rG LLV

[PATCH] D158798: [RFC] Android runtimes build demonstration

smeenai created this revision. smeenai added reviewers: danalbert, rprichard, srhines. Herald added a subscriber: danielkiss. Herald added a project: All. smeenai requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This demons

[PATCH] D158798: [RFC] Android runtimes build demonstration

smeenai added a comment. The manual `androideabi` normalization is only needed when building the runtimes, not when using them: $ for i in {21..32}; do printf '%s ' $i; bin/clang --print-file-name=libclang_rt.builtins.a -target armv7-none-linux-androideabi$i; done 21 /data/users/smeenai/l

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai added a comment. D158798 demonstrates a working Android runtimes setup with per-target runtime directories once this change is in place. It'll be nicer once D140925 lands, but it's workable even without that. Reposi

[clang] 053dd30 - Reland "[HIP] Allow std::malloc in device function"

Author: Yaxun (Sam) Liu Date: 2023-08-24T19:59:20-04:00 New Revision: 053dd30bb5d3ce5f6b57f10858ea0a6e4df7c738 URL: https://github.com/llvm/llvm-project/commit/053dd30bb5d3ce5f6b57f10858ea0a6e4df7c738 DIFF: https://github.com/llvm/llvm-project/commit/053dd30bb5d3ce5f6b57f10858ea0a6e4df7c738.dif

[clang] e75f240 - [Driver] Cleanup last vestiges of Minix / Contiki support

Author: Brad Smith Date: 2023-08-24T20:04:40-04:00 New Revision: e75f240a0432d827c28a5d77fad26a099ceb7a72 URL: https://github.com/llvm/llvm-project/commit/e75f240a0432d827c28a5d77fad26a099ceb7a72 DIFF: https://github.com/llvm/llvm-project/commit/e75f240a0432d827c28a5d77fad26a099ceb7a72.diff LO

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

brad updated this revision to Diff 553310. brad added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158376/new/ https://reviews.llvm.org/D158376 Files: clang/lib/Driver/ToolChains/DragonFly.cpp clang/lib/Driver/ToolChains/Dr

[clang] e4cb692 - [Driver] Add NaCl to ShouldAddDefaultIncludePaths()

Author: Brad Smith Date: 2023-08-24T21:09:09-04:00 New Revision: e4cb692526030a05424ee8299012ee76a7a0e3ca URL: https://github.com/llvm/llvm-project/commit/e4cb692526030a05424ee8299012ee76a7a0e3ca DIFF: https://github.com/llvm/llvm-project/commit/e4cb692526030a05424ee8299012ee76a7a0e3ca.diff LO

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner created this revision. bogner added reviewers: beanz, python3kgae, bob80905, tex3d. Herald added subscribers: Anastasia, arphaman, mcrosier. Herald added a reviewer: aaron.ballman. Herald added a project: All. bogner requested review of this revision. Herald added a project: clang. Herald ad

[PATCH] D158706: [Driver] Remove Myriad.cpp

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2958 default: return getTriple().getVendor() != llvm::Triple::Myriad; } brad wrote: > You might as well remove this. Will do! Rep

[PATCH] D158706: [Driver] Remove Myriad.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. MaskRay marked an inline comment as done. Closed by commit rGaa9d7d1cd0af: [Driver] Remove Myriad.cpp (authored by MaskRay). Herald added a project: LLVM. Herald added

[clang] aa9d7d1 - [Driver] Remove Myriad.cpp

Author: Fangrui Song Date: 2023-08-24T18:44:45-07:00 New Revision: aa9d7d1cd0afe06f3c212af65b66f7e1421e321b URL: https://github.com/llvm/llvm-project/commit/aa9d7d1cd0afe06f3c212af65b66f7e1421e321b DIFF: https://github.com/llvm/llvm-project/commit/aa9d7d1cd0afe06f3c212af65b66f7e1421e321b.diff

[PATCH] D158706: [Driver] Remove Myriad.cpp

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2958 default: return getTriple().getVendor() != llvm::Triple::Myriad; } MaskRay wrote: > brad wrote: > > You might as well remove this. > Will do! There is some Myriad remai

[PATCH] D158804: [Clang] Fix crash in Parser::ParseDirectDeclarator by adding check that token is not an annotation token

shafik created this revision. shafik added reviewers: aaron.ballman, nridge, erichkeane. Herald added a project: All. shafik requested review of this revision. In `Parser::ParseDirectDeclarator(...)` in some cases ill-formed code can cause an annotation token to end up where it was not expected.

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158475/new/ https://reviews.llvm.org/D158475 ___

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

danix800 updated this revision to Diff 553335. danix800 edited the summary of this revision. danix800 added a comment. 1. `getDynamicExtent()` can return both signed/unsigned results. They are converted to signed version as `ArrayIndexType` to keep consistency. All other APIs return this version

[PATCH] D158808: [Clang] Modify Parser::ParseLambdaExpressionAfterIntroducer to check whether the lambda-declarator is valid

shafik created this revision. shafik added reviewers: cor3ntin, aaron.ballman, erichkeane, rsmith. Herald added a project: All. shafik requested review of this revision. We had a couple of crashes due to invalid lambda trailing return types that were diagnosed but not treated as errors during par

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw added a comment. In the JavaScript tests that I added, it was wrong to use `SmallString`. Would you prefer me changing it to `string` or expanding the 6 test cases so we don't need a variable for the string? Shortly after I committed this patch, the server builds caught the problem in

[PATCH] D158811: [X86] __builtin_cpu_supports: support x86-64{,-v2,-v3,-v4}

MaskRay created this revision. MaskRay added reviewers: FreddyYe, pengfei, RKSimon, skan, erichkeane. Herald added a subscriber: hiraditya. Herald added a reviewer: ctetreau. Herald added a project: All. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added sub

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

danix800 updated this revision to Diff 553351. danix800 edited the summary of this revision. danix800 added a comment. `MPIChecker` is not strictly related to this revision. Will be moved into another revison. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D158813: [analyzer] MPIChecker: MPI_Waitall should respect count arg

danix800 created this revision. danix800 added reviewers: steakhal, donat.nagy, dcoughlin. danix800 added a project: clang. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. H

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

owenpan added a comment. In D154093#4615948 , @sstwcw wrote: > In the JavaScript tests that I added, it was wrong to use `SmallString`. > Would you prefer me changing it to `string` or expanding the 6 test cases so > we don't need a variable for the st

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

sandeepkosuri updated this revision to Diff 553358. sandeepkosuri added a comment. Used `CHECK-DAG` s to avoid LIT test failures on Windows system Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152054/new/ https://reviews.llvm.org/D152054 Files:

[PATCH] D158709: [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces so that they can be modularized

iana updated this revision to Diff 553360. iana added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158709/new/ https://reviews.llvm.org/D158709 Files: clang-tools-extra/clang-include-fixer/find-all-symbols/STLPostfixHeaderMap.

[clang] 5624e86 - [tsan] Respect !nosanitize metadata and remove gcov special case

Author: Fangrui Song Date: 2023-08-24T22:31:11-07:00 New Revision: 5624e86ae0fb259c6069d1cc7d5eaa24402f9134 URL: https://github.com/llvm/llvm-project/commit/5624e86ae0fb259c6069d1cc7d5eaa24402f9134 DIFF: https://github.com/llvm/llvm-project/commit/5624e86ae0fb259c6069d1cc7d5eaa24402f9134.diff

[PATCH] D158385: [tsan] Respect !nosanitize metadata and remove gcov special case

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5624e86ae0fb: [tsan] Respect !nosanitize metadata and remove gcov special case (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D158808: [Clang] Modify Parser::ParseLambdaExpressionAfterIntroducer to check whether the lambda-declarator is valid

cor3ntin added a comment. LGTM modulo: - No release notes - I think you need to write in the commit Fixes https://github.com/llvm/llvm-project/issues/64962 Fixes https://github.com/llvm/llvm-project/issues/28679 for github not to be confused - You need to clang-format

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin added a subscriber: tbaeder. cor3ntin added a comment. Looks mostly good to me, thanks! In D158591#4613868 , @RIscRIpt wrote: > The current implementation of `getPredefinedExprDeclContext` could be easily > moved to a static function inside `cl

[PATCH] D158502: [clang][Interp] Actually consider ConstantExpr result

cor3ntin added a comment. FYI there are build failures. you probably need to rebase (visitAPValue does not seem to actually exist) Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:767-772 + std::optional T = classify(E->getType()); + if (T && E->hasAPValueResult() && +

[PATCH] D154382: [ClangRepl] support code completion at a REPL

v.g.vassilev added inline comments. Comment at: clang/unittests/Interpreter/CodeCompletionTest.cpp:38 + + std::vector Results; + We should make this an out parameter instead of returning it by copy. Comment at: clang/unittests/Interpreter/Code

[PATCH] D158733: [Clang] Fix a crash when an invalid immediate function call appears in a cast

cor3ntin updated this revision to Diff 553381. cor3ntin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158733/new/ https://reviews.llvm.org/D158733 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp

[PATCH] D158733: [Clang] Fix a crash when an invalid immediate function call appears in a cast

cor3ntin updated this revision to Diff 553385. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158733/new/ https://reviews.llvm.org/D158733 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp clang/t

[clang] 6824d15 - [Clang] Fix a crash when an invalid immediate function call appears in a cast

Author: Corentin Jabot Date: 2023-08-25T08:50:41+02:00 New Revision: 6824d156d5dd9f5a3e837d8d4bc1dadb48170e2f URL: https://github.com/llvm/llvm-project/commit/6824d156d5dd9f5a3e837d8d4bc1dadb48170e2f DIFF: https://github.com/llvm/llvm-project/commit/6824d156d5dd9f5a3e837d8d4bc1dadb48170e2f.diff

[PATCH] D158733: [Clang] Fix a crash when an invalid immediate function call appears in a cast

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6824d156d5dd: [Clang] Fix a crash when an invalid immediate function call appears in a cast (authored by cor3ntin). Repository: rG LLVM Github Mon

<    1   2   3