[PATCH] D158246: [amdgpu] WIP variadics

JonChesterfield added a comment. Name candidates - expand - lower - desugar - transform Lowering probably makes the most sense for the abi level apply to all functions, I like desugar to cover rewriting a subset of the graph Comment at: libc/config/gpu/entrypoints.txt:84-85

[PATCH] D158246: [amdgpu] WIP variadics

arsenm added inline comments. Comment at: llvm/lib/CodeGen/DesugarVariadics.cpp:74-77 +Value *Mask = ConstantInt::get(IntPtrTy, ~(DataAlignMinusOne)); +Value *vaListAligned = Builder.CreateIntToPtr( +Builder.CreateAnd(Builder.CreatePtrToInt(Incr, IntPtrTy), Mask),

[PATCH] D158246: [amdgpu] WIP variadics

arsenm added inline comments. Comment at: llvm/lib/CodeGen/DesugarVariadics.cpp:296 +// Note - same attribute handling as DeadArgumentElimination +NF->copyAttributesFrom(&F); +NF->setComdat(F.getComdat()); This might be missing copying the linkage R

[clang] 7ba37f4 - [clang][ExtractAPI] Add support for C++ class templates and concepts

Author: Erick Velez Date: 2023-08-18T13:40:22-07:00 New Revision: 7ba37f4e46a5bbb1dc42f1ea1722296ea32034d5 URL: https://github.com/llvm/llvm-project/commit/7ba37f4e46a5bbb1dc42f1ea1722296ea32034d5 DIFF: https://github.com/llvm/llvm-project/commit/7ba37f4e46a5bbb1dc42f1ea1722296ea32034d5.diff L

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ba37f4e46a5: [clang][ExtractAPI] Add support for C++ class templates and concepts (authored by evelez7). Repository: rG LLVM Github Monorepo CHA

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

MaskRay reopened this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1787 +if (!VCI->isMinSignedValue()) { + return EmitAbs(CGF, ArgValue, true); +} nit: we delete

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

MaskRay added a comment. In D156821#4599471 , @thurston wrote: > This patch might have broke the buildbots, starting with when it was first > built in https://lab.llvm.org/buildbot/#/builders/85/builds/18390 > > > /b/sanitizer-x86_64-linux-bootstrap-u

[PATCH] D158246: [amdgpu] WIP variadics

arsenm added inline comments. Comment at: llvm/lib/CodeGen/DesugarVariadics.cpp:145 +for (Function &F : llvm::make_early_inc_range(M)) + if (Apply || canTransformFunctionInIsolation(F)) +Changed |= runOnFunction(F); I think you need to guard agai

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

shenhan updated this revision to Diff 551630. shenhan marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158231/new/ https://reviews.llvm.org/D158231 Files: clang/test/CodeGen/fsplit-machine-functions.c clang/test/Dr

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

shenhan updated this revision to Diff 551632. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158231/new/ https://reviews.llvm.org/D158231 Files: clang/test/CodeGen/fsplit-machine-functions.c clang/test/Driver/fsplit-machine-functions-with-cuda-nv

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

shenhan added inline comments. Comment at: clang/test/CodeGen/fsplit-machine-functions.c:1 +// REQUIRES: system-linux +// REQUIRES: x86-registered-target MaskRay wrote: > Any reason `system-linux` is needed? Deleted. Also deleted "REQUIRES: system-linux" from "f

[clang] 8d8c898 - [clang][ExtractAPI] Add support for C++ variable templates

Author: Erick Velez Date: 2023-08-18T13:57:02-07:00 New Revision: 8d8c8981cac0e548f0fca1268d6e501431564f66 URL: https://github.com/llvm/llvm-project/commit/8d8c8981cac0e548f0fca1268d6e501431564f66 DIFF: https://github.com/llvm/llvm-project/commit/8d8c8981cac0e548f0fca1268d6e501431564f66.diff L

[PATCH] D157350: [clang][ExtractAPI] Add support for C++ variable templates

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d8c8981cac0: [clang][ExtractAPI] Add support for C++ variable templates (authored by evelez7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157350/new/ ht

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

shenhan updated this revision to Diff 551634. shenhan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158231/new/ https://reviews.llvm.org/D158231 Files: clang/test/CodeGen/fsplit-machine-functions.c clang/test/Dr

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

thurston added a comment. In D156821#4600086 , @MaskRay wrote: > Failed Tests (4): > LLVM :: CodeGen/RISCV/rvv/fixed-vectors-int.ll > LLVM :: CodeGen/SystemZ/ctpop-01.ll > LLVM :: MC/ARM/basic-thumb2-instructions.s > LLVM :: tools/llvm-r

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

dzhidzhoev added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:5381-5393 + let Predicates = [HasFullFP16] in { + def : Pat<(f16 (node (f16 FPR16:$Rn), + (f16 (vector_extract (v8f16 V128:$Rm), (i64 0))), +

[PATCH] D157579: [clang][ExtractAPI] Add support for C++ global function templates

evelez7 updated this revision to Diff 551642. evelez7 added a comment. Formatting changes, keep GlobalFunction has templates together and revert extraneous formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157579/new/ https://reviews.llvm.o

[PATCH] D158293: [NFC][CLANG] Fix potential dereferencing of null return values

tahonermann added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2009-2010 (Line.MightBeFunctionDecl || Line.InPPDirective) && - Current.NestingLevel == 0 && + Current.NestingLevel == 0 && Current.Previous &&

[PATCH] D158238: Implement __builtin_fmaximum/fminimum*

tra updated this revision to Diff 551646. tra added a comment. Fixed test RUN lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158238/new/ https://reviews.llvm.org/D158238 Files: clang/include/clang/Basic/Builtins.def clang/lib/AST/ExprCons

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

rupprecht added a comment. The other common breakage I'm seeing is code that hasn't yet migrated from the "PRI" format macros, of which there's an example in LLVM itself: https://github.com/llvm/llvm-project/blob/6a0e536ccfef1f7bd64ee4153b4efc0aeecf28d4/clang/test/SemaCXX/cxx11-compat.cpp#L38 e

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

rupprecht added a comment. In D153156#4600270 , @rupprecht wrote: > of which there's an example in LLVM itself: > https://github.com/llvm/llvm-project/blob/6a0e536ccfef1f7bd64ee4153b4efc0aeecf28d4/clang/test/SemaCXX/cxx11-compat.cpp#L38 Sorry, I don't w

[clang] 3364d76 - [clang-format][doc] Don't use the ".0" suffix on version numbers

Author: Owen Pan Date: 2023-08-18T14:57:43-07:00 New Revision: 3364d7620ef78c6e9f04c63e62ac6b0801090ea5 URL: https://github.com/llvm/llvm-project/commit/3364d7620ef78c6e9f04c63e62ac6b0801090ea5 DIFF: https://github.com/llvm/llvm-project/commit/3364d7620ef78c6e9f04c63e62ac6b0801090ea5.diff LOG:

[PATCH] D158318: [Sema] tolerate more promotion matches in format string checking

fcloutier created this revision. fcloutier added a reviewer: aaron.ballman. Herald added a project: All. fcloutier requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It's been reported that when using __attribute__((format)) on non-variadic f

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem updated this revision to Diff 551656. artem marked 2 inline comments as done. artem added a comment. Fixed the comments. I do not have commit rights CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem added inline comments. Comment at: clang/test/ubsan/TestCases/Misc/abs.cpp:1 +// REQUIRES: arch=x86_64 +// MaskRay wrote: > Did you mean compiler-rt/ instead of clang/? > > `// REQUIRES: arch=x86_64` is legacy style. > > New style uses `// REQUIRES: targe

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

ldionne added a comment. This is going to be really naive, but can someone explain why we need these `__need_X` macros? Why doesn't `` simply always declare what it should declare? Also, does anybody understand the expected relationship between the C Standard Library headers and these Clang

[clang] 4ab4e40 - [OpenMP] Always pass the optimization level to the linker wrapper

Author: Joseph Huber Date: 2023-08-18T17:10:13-05:00 New Revision: 4ab4e40fa2944bfd2ed44c63027e7a838043e0fd URL: https://github.com/llvm/llvm-project/commit/4ab4e40fa2944bfd2ed44c63027e7a838043e0fd DIFF: https://github.com/llvm/llvm-project/commit/4ab4e40fa2944bfd2ed44c63027e7a838043e0fd.diff

[PATCH] D158298: [OpenMP] Always pass the optimization level to the linker wrapper

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ab4e40fa294: [OpenMP] Always pass the optimization level to the linker wrapper (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D158255: [RISCV][NFC] Update compile options for some vector crypto C intrinsics

craig.topper requested changes to this revision. craig.topper added inline comments. This revision now requires changes to proceed. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vcpopv.c:4 +// RUN: %clang_cc1 -triple riscv64 -target-

[PATCH] D158257: [RISCV] Add feature checks for vector crypto C intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158257/new/ https://reviews.llvm.org/D158257 ___

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: compiler-rt/test/ubsan/TestCases/Misc/abs.cpp:11 +int main() { + // ABORT: abs.cpp:[[@LINE+3]]:17: runtime error: negation of -{{[0-9]+}} cannot be repres

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1787 +if (!VCI->isMinSignedValue()) { + return EmitAbs(CGF, ArgValue, true); +} MaskRay wrote: > nit: we delete braces in this cascading case > > https://llvm.org/docs/Coding

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

dzhidzhoev added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:5393 + (EXTRACT_SUBREG V128:$Rn, hsub), FPR16:$Rm, FPR16:$Ra)>; + } + BTW, these lines add some patterns for fnmadd. Could you add some tests for them? Or

[PATCH] D157762: [WIP] Implement [[msvc::no_unique_address]]

akhuang marked 2 inline comments as done. akhuang added a comment. I'm still trying to figure out the MSVC layouts. I used the EmptySubobjects class for a lot of the logic, which is not always the same as what MSVC does. (some examples of differences in https://godbolt.org/z/6cP554ddb) Reposit

[PATCH] D157762: [WIP] Implement [[msvc::no_unique_address]]

akhuang updated this revision to Diff 551662. akhuang added a comment. address small fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157762/new/ https://reviews.llvm.org/D157762 Files: clang/include/clang/Basic/Attr.td clang/include/clang/

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

dzhidzhoev added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:5418 + (EXTRACT_SUBREG V128:$Rn, dsub), FPR64:$Rm, FPR64:$Ra)>; } Is it possible to use extractelt here? Since vector_extract is marked as deprecated in

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana added a comment. In D157757#4600357 , @ldionne wrote: > This is going to be really naive, but can someone explain why we need these > `__need_X` macros? Why doesn't `` simply always declare what it > should declare? Also, does anybody understan

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

MaskRay added a comment. > Currenly both Clang and GCC support the following set of flags that control code gen of signed overflow: > [...] > Howerver, clang ignores these flags for __builtin_abs(int) and its > higher-width versions, so passing minimum integer value always causes poison. This

[clang-tools-extra] 9be33de - [clang-tidy]`pro-bounds-array-to-pointer-decay` ignore predefined expression

Author: Congcong Cai Date: 2023-08-19T08:13:00+08:00 New Revision: 9be33de4f39713c2deb7cc262b4dd4e50dc8349d URL: https://github.com/llvm/llvm-project/commit/9be33de4f39713c2deb7cc262b4dd4e50dc8349d DIFF: https://github.com/llvm/llvm-project/commit/9be33de4f39713c2deb7cc262b4dd4e50dc8349d.diff

[PATCH] D158244: [clang-tidy]`pro-bounds-array-to-pointer-decay` ignore predefined expression

This revision was automatically updated to reflect the committed changes. Closed by commit rG9be33de4f397: [clang-tidy]`pro-bounds-array-to-pointer-decay` ignore predefined expression (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

craig.topper added a comment. In D156821#4600550 , @MaskRay wrote: >> Currenly both Clang and GCC support the following set of flags that control > > code gen of signed overflow: > >> [...] >> Howerver, clang ignores these flags for __builtin_abs(int) and

[PATCH] D158293: [NFC][CLANG] Fix potential dereferencing of null return values

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2009-2010 (Line.MightBeFunctionDecl || Line.InPPDirective) && - Current.NestingLevel == 0 && + Current.NestingLevel == 0 && Current.Previous &&

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

shenhan updated this revision to Diff 551680. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158231/new/ https://reviews.llvm.org/D158231 Files: clang/test/CodeGen/fsplit-machine-functions.c clang/test/Driver/fsplit-machine-functions-with-cuda-nv

[clang] 80b787e - [clang][ExtractAPI] Add support for C++ global function templates

Author: Erick Velez Date: 2023-08-18T17:42:05-07:00 New Revision: 80b787e803292119f30da2e1e95acff5beea61db URL: https://github.com/llvm/llvm-project/commit/80b787e803292119f30da2e1e95acff5beea61db DIFF: https://github.com/llvm/llvm-project/commit/80b787e803292119f30da2e1e95acff5beea61db.diff L

[PATCH] D157579: [clang][ExtractAPI] Add support for C++ global function templates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80b787e80329: [clang][ExtractAPI] Add support for C++ global function templates (authored by evelez7). Repository: rG LLVM Github Monorepo CHANGE

[clang] acc8a33 - [-Wunsafe-buffer-usage][NFC] Refactor `getFixIts`---where fix-its are generated

Author: ziqingluo-90 Date: 2023-08-18T17:44:22-07:00 New Revision: acc8a33b257f8176fae1bae929ff9da7ed2cbad5 URL: https://github.com/llvm/llvm-project/commit/acc8a33b257f8176fae1bae929ff9da7ed2cbad5 DIFF: https://github.com/llvm/llvm-project/commit/acc8a33b257f8176fae1bae929ff9da7ed2cbad5.diff

[PATCH] D156762: [-Wunsafe-buffer-usage][NFC] Refactor `getFixIts`---where fix-its are generated

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGacc8a33b257f: [-Wunsafe-buffer-usage][NFC] Refactor `getFixIts`---where fix-its are generated (authored by ziqingluo-90). Changed prior to commit:

[PATCH] D126586: [InstrProf] Single byte counters in coverage

gulfem updated this revision to Diff 551686. gulfem added a comment. Ensure the correct traversal order for loops in CodeGenPGO to fix the profile test failures (Profile/cxx-hash-v2.cpp and Profile/cxx-rangefor.cpp) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D126586: [InstrProf] Single byte counters in coverage

gulfem updated this revision to Diff 551687. gulfem added a comment. Remove hyphen between "single counter" for consistency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126586/new/ https://reviews.llvm.org/D126586 Files: clang/lib/CodeGen/CGExp

[clang] b9d079d - [clang][test] Refine clang machine-function-split tests.

Author: Han Shen Date: 2023-08-18T18:05:47-07:00 New Revision: b9d079d6188b50730e0a67267b7fee36008435ce URL: https://github.com/llvm/llvm-project/commit/b9d079d6188b50730e0a67267b7fee36008435ce DIFF: https://github.com/llvm/llvm-project/commit/b9d079d6188b50730e0a67267b7fee36008435ce.diff LOG:

[PATCH] D157565: [CodeGen] Add AArch64 behavior to existing MFS tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9d079d6188b: [clang][test] Refine clang machine-function-split tests. (authored by shenhan). Herald added subscribers: cfe-commits, mattd, asavonic.

[PATCH] D158158: [clang] Set FP options in Sema when instantiating CompoundStmt

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158158/new/ https://reviews.llvm.org/D158158 __

[clang-tools-extra] 3e69886 - [clangd] Fix incorrect RecursiveASTVisitor usage in summarizeExpr()

Author: Nathan Ridge Date: 2023-08-18T23:02:48-04:00 New Revision: 3e69886dd012fb446936760f0946db4df5223c48 URL: https://github.com/llvm/llvm-project/commit/3e69886dd012fb446936760f0946db4df5223c48 DIFF: https://github.com/llvm/llvm-project/commit/3e69886dd012fb446936760f0946db4df5223c48.diff

[PATCH] D158248: [clangd] Fix incorrect RecursiveASTVisitor usage in summarizeExpr()

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e69886dd012: [clangd] Fix incorrect RecursiveASTVisitor usage in summarizeExpr() (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158248/

[PATCH] D157953: [CGCall][RISCV] Handle function calls with parameter of RVV tuple type

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5278 + for (unsigned i = 0, e = STy->getNumElements(); i != e; ++i) { +llvm::Value *LI = Builder.CreateExtractValue( +StoredStructValue, i, Src.getName() + ".extract"

[PATCH] D149236: [clangd] Bail gracefully if given an assembly or IR source file

nridge updated this revision to Diff 551694. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149236/new/ https://reviews.llvm.org/D149236 Files: clang-tools-extra/clangd/ParsedAST.cpp clang-tools-ex

[clang-tools-extra] 744b111 - [clangd] Bail gracefully if given an assembly or IR source file

Author: Nathan Ridge Date: 2023-08-18T23:26:32-04:00 New Revision: 744b111434b25b1259308050c59062dc4f38a589 URL: https://github.com/llvm/llvm-project/commit/744b111434b25b1259308050c59062dc4f38a589 DIFF: https://github.com/llvm/llvm-project/commit/744b111434b25b1259308050c59062dc4f38a589.diff

[PATCH] D149236: [clangd] Bail gracefully if given an assembly or IR source file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG744b111434b2: [clangd] Bail gracefully if given an assembly or IR source file (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D158249: [clangd] Parameter hints for calls through function pointers

nridge updated this revision to Diff 551696. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158249/new/ https://reviews.llvm.org/D158249 Files: clang-tools-extra/clangd/InlayHints.cpp clang-tools-

[PATCH] D158249: [clangd] Parameter hints for calls through function pointers

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:508 + // Only one of Callee or ProtoTypeLoc is set. + const FunctionDecl *Callee = nullptr; + FunctionProtoTypeLoc ProtoTypeLoc; sammccal

[clang-tools-extra] 8ee710a - [clangd] Parameter hints for calls through function pointers

Author: Nathan Ridge Date: 2023-08-18T23:40:59-04:00 New Revision: 8ee710a40cc51098e6d1249afe9af0e64150f308 URL: https://github.com/llvm/llvm-project/commit/8ee710a40cc51098e6d1249afe9af0e64150f308 DIFF: https://github.com/llvm/llvm-project/commit/8ee710a40cc51098e6d1249afe9af0e64150f308.diff

[PATCH] D158249: [clangd] Parameter hints for calls through function pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. nridge marked an inline comment as done. Closed by commit rG8ee710a40cc5: [clangd] Parameter hints for calls through function pointers (authored by nridge). Repository

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target/target_clones attributes

MaskRay created this revision. MaskRay added reviewers: craig.topper, FreddyYe, pengfei, RKSimon, skan. Herald added subscribers: Enna1, hiraditya. Herald added a project: All. MaskRay requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13277 +llvm::Value * +CodeGenFunction::EmitX86CpuSupports(const uint32_t FeaturesMask[4]) { Value *Result = Builder.getTrue(); Can this be a std::array instead? The C array is prett

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

wangpc updated this revision to Diff 551702. wangpc added a comment. - Rebase. - Remove abilist changes. - Add clang-18. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 Files: clang-tools-extra/clangd/u

[PATCH] D158247: [CUDA][HIP] Fix overloading resolution in global variable initializer

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Sema/Sema.h:4753 + /// Otherwise, use \p D to determiine the host/device target. bool CheckCallingConvAttr(const ParsedAttr &attr, CallingConv &CC, +

[libunwind] 22a8402 - MIPS: unwind, don't save/restore hi/lo for R6

Author: YunQiang Su Date: 2023-08-19T00:35:25-04:00 New Revision: 22a84020d2324ac1f753705497a40c43d8284d94 URL: https://github.com/llvm/llvm-project/commit/22a84020d2324ac1f753705497a40c43d8284d94 DIFF: https://github.com/llvm/llvm-project/commit/22a84020d2324ac1f753705497a40c43d8284d94.diff L

[PATCH] D158247: [CUDA][HIP] Fix overloading resolution in global variable initializer

yaxunl updated this revision to Diff 551705. yaxunl marked 3 inline comments as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158247/new/ https://reviews.llvm.org/D158247 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseD

[clang] df8d33f - [OpenMP][AMDGPU] Add "amdgpu-flat-work-group-size" for known thread counts

Author: Johannes Doerfert Date: 2023-08-18T21:47:57-07:00 New Revision: df8d33fa7a22df3be34da5c6837031d897fa479b URL: https://github.com/llvm/llvm-project/commit/df8d33fa7a22df3be34da5c6837031d897fa479b DIFF: https://github.com/llvm/llvm-project/commit/df8d33fa7a22df3be34da5c6837031d897fa479b.d

[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

jcsxky added a comment. In D156693#4584657 , @balazske wrote: > A simple test should be added to StructuralEquivalenceTest.cpp too to check > if ignore (and not ignore) depth works. > > I think this solution is not always correct, but is still an improve

[clang] 11e2975 - Fx typos in documentation

Author: Kazu Hirata Date: 2023-08-18T23:36:04-07:00 New Revision: 11e2975810acd6abde9071818e03634d99492b54 URL: https://github.com/llvm/llvm-project/commit/11e2975810acd6abde9071818e03634d99492b54 DIFF: https://github.com/llvm/llvm-project/commit/11e2975810acd6abde9071818e03634d99492b54.diff L

[clang-tools-extra] 11e2975 - Fx typos in documentation

Author: Kazu Hirata Date: 2023-08-18T23:36:04-07:00 New Revision: 11e2975810acd6abde9071818e03634d99492b54 URL: https://github.com/llvm/llvm-project/commit/11e2975810acd6abde9071818e03634d99492b54 DIFF: https://github.com/llvm/llvm-project/commit/11e2975810acd6abde9071818e03634d99492b54.diff L

[clang] f237da1 - [AST] Use DenseMap::lookup (NFC)

Author: Kazu Hirata Date: 2023-08-18T23:52:57-07:00 New Revision: f237da1a2f6b89d8a832d37d64fb57795bfa7b9a URL: https://github.com/llvm/llvm-project/commit/f237da1a2f6b89d8a832d37d64fb57795bfa7b9a DIFF: https://github.com/llvm/llvm-project/commit/f237da1a2f6b89d8a832d37d64fb57795bfa7b9a.diff L

<    1   2   3