[clang] be5c8de - [Driver][DXC] Accept debug flags (/Zi and /Qembed_debug)

2023-08-17 Thread Justin Bogner via cfe-commits
Author: Justin Bogner Date: 2023-08-17T16:19:09-07:00 New Revision: be5c8dea1e1de5df98df656c6e4c92a3f6682661 URL: https://github.com/llvm/llvm-project/commit/be5c8dea1e1de5df98df656c6e4c92a3f6682661 DIFF: https://github.com/llvm/llvm-project/commit/be5c8dea1e1de5df98df656c6e4c92a3f6682661.diff

[PATCH] D158113: [Driver][DXC] Accept debug flags (/Zi and /Qembed_debug)

2023-08-17 Thread Justin Bogner via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe5c8dea1e1d: [Driver][DXC] Accept debug flags (/Zi and /Qembed_debug) (authored by bogner). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

2023-08-17 Thread Han Shen via Phabricator via cfe-commits
shenhan created this revision. shenhan added reviewers: MaskRay, Hahnfeld, steelannelida. Herald added subscribers: mattd, asavonic. Herald added a project: All. shenhan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

2023-08-17 Thread Han Shen via Phabricator via cfe-commits
shenhan added a comment. Thanks all. Created D158231 to address the post-submit comments and added all as reviewers. @MaskRay @Hahnfeld @steelannelida Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157750/new/ h

[clang] 8437847 - [-Wunsafe-buffer-usage][NFC] Slightly refactor and optimize the code

2023-08-17 Thread Ziqing Luo via cfe-commits
Author: Ziqing Luo Date: 2023-08-17T16:24:47-07:00 New Revision: 843784764ab58e35f8aa2da97f07dc5e810f4bcb URL: https://github.com/llvm/llvm-project/commit/843784764ab58e35f8aa2da97f07dc5e810f4bcb DIFF: https://github.com/llvm/llvm-project/commit/843784764ab58e35f8aa2da97f07dc5e810f4bcb.diff LO

[PATCH] D156474: [-Wunsafe-buffer-usage][NFC] Slightly refactor and optimize the code

2023-08-17 Thread Ziqing Luo via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG843784764ab5: [-Wunsafe-buffer-usage][NFC] Slightly refactor and optimize the code (authored by ziqingluo-90). Changed prior to commit: https://re

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

2023-08-17 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/CodeGen/fsplit-machine-functions.c:41 + +// RUN: %clang -c -target arm-unknown-linux-gnueabi -fsplit-machine-functions %s \ +// RUN: 2>&1 | FileCheck -check-prefix=MFS5 %s `-target ` has been deprecated s

[clang] ac9a76d - Revert "[-Wunsafe-buffer-usage][NFC] Slightly refactor and optimize the code"

2023-08-17 Thread Ziqing Luo via cfe-commits
Author: Ziqing Luo Date: 2023-08-17T16:42:30-07:00 New Revision: ac9a76d7487b9af1ace626eb90064194cb12c53d URL: https://github.com/llvm/llvm-project/commit/ac9a76d7487b9af1ace626eb90064194cb12c53d DIFF: https://github.com/llvm/llvm-project/commit/ac9a76d7487b9af1ace626eb90064194cb12c53d.diff LO

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

2023-08-17 Thread Anton Rydahl via Phabricator via cfe-commits
AntonRydahl updated this revision to Diff 551323. AntonRydahl added a comment. Avoided changing clang/lib/Frontend/CompilerInvocation.cpp by performing checks for OpenMP offloading to GPU devices in Sema instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D158233: [SEH] Fix wrong argument passes to the call of OutlinedFinally.

2023-08-17 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 created this revision. jyu2 added reviewers: asmith, tentzen, rnk, efriedma, pengfei. jyu2 added a project: clang. Herald added a project: All. jyu2 requested review of this revision. When return out of __try block. In this test case, currently "false" is passed to the OutlinedFinally call,

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

2023-08-17 Thread Harald van Dijk via Phabricator via cfe-commits
hvdijk added a comment. In D86310#4596932 , @tmgross wrote: > Was your failure in https://bugs.llvm.org/show_bug.cgi?id=50198 fixed with > these patches? Yes, it was (at least it was at the time that I initially commented). > I cannot reproduce that fai

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

2023-08-17 Thread Han Shen via Phabricator via cfe-commits
shenhan updated this revision to Diff 551332. shenhan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158231/new/ https://reviews.llvm.org/D158231 Files: clang/test/CodeGen/fsplit-machine-functions.c clang/test/Dr

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

2023-08-17 Thread Han Shen via Phabricator via cfe-commits
shenhan added inline comments. Comment at: clang/test/CodeGen/fsplit-machine-functions.c:41 + +// RUN: %clang -c -target arm-unknown-linux-gnueabi -fsplit-machine-functions %s \ +// RUN: 2>&1 | FileCheck -check-prefix=MFS5 %s MaskRay wrote: > `-target ` has

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

2023-08-17 Thread Zenong Zhang via Phabricator via cfe-commits
SlaterLatiao updated this revision to Diff 551337. SlaterLatiao added a comment. - Minor fix on comment. - Replace string '+' with Twine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158006/new/ https://reviews.llvm.org/D158006 Files: clang/inc

[PATCH] D158239: [clang][ExtractAPI] Add support for namespaces

2023-08-17 Thread Erick Velez via Phabricator via cfe-commits
evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Serialize namespaces, nested namespaces, and class relati

[PATCH] D158239: [clang][ExtractAPI] Add support for namespaces

2023-08-17 Thread Erick Velez via Phabricator via cfe-commits
evelez7 updated this revision to Diff 551340. evelez7 added a comment. Remove unnecessary line break. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158239/new/ https://reviews.llvm.org/D158239 Files: clang/include/clang/ExtractAPI/API.h clang/

[PATCH] D158239: [clang][ExtractAPI] Add support for namespaces

2023-08-17 Thread Erick Velez via Phabricator via cfe-commits
evelez7 added a comment. Note that this doesn't handle anonymous namespaces. Similar problems arise with anonymous classes/structs, being worked on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158239/new/ https://reviews.llvm.org/D158239 __

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

2023-08-17 Thread Zenong Zhang via Phabricator via cfe-commits
SlaterLatiao updated this revision to Diff 551342. SlaterLatiao added a comment. - Make transforming expressions for member packs a separate function. - Minor edits based on review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158006/new/

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

2023-08-17 Thread Zenong Zhang via Phabricator via cfe-commits
SlaterLatiao marked 4 inline comments as done. SlaterLatiao added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:4171 + if (CXXDependentScopeMemberExpr *MemberExpr = + dyn_cast(Pattern)) { dblaikie wrote: > Might be worth pulling

[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

2023-08-17 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. Reverted with D155568 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156042/new/ https://reviews.llvm.org/D156042 ___ cfe-commits mailing lis

[clang] e03686f - Revert "[clang][Interp] Make sure we push integers of the correct size"

2023-08-17 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2023-08-17T18:12:02-07:00 New Revision: e03686f4a399d7ebe8452d510452a72384261eaf URL: https://github.com/llvm/llvm-project/commit/e03686f4a399d7ebe8452d510452a72384261eaf DIFF: https://github.com/llvm/llvm-project/commit/e03686f4a399d7ebe8452d510452a72384261eaf.diff L

[PATCH] D158137: Rename warn_drv_overriding_flag_option (-Woverriding-t-option) to warn_drv_overriding_flag_option (-Woverriding-option)

2023-08-17 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. In D158137#4597009 , @MaskRay wrote: > In D158137#4596948 , @dexonsmith > wrote: > >> Can you explain the downside of leaving behind an alias? > > Two minor ones. (a) Existing `-Wno-ov

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

2023-08-17 Thread Congcong Cai via Phabricator via cfe-commits
HerrCai0907 updated this revision to Diff 551344. HerrCai0907 added a comment. update release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158152/new/ https://reviews.llvm.org/D158152 Files: clang-tools-extra/clang-tidy/readability/NonCons

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

2023-08-17 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. Some nits. I'm assuming we're getting the code object in the backend now? We'll need to make sure that `-Wl,--amdhsa-code-object-version` is passed to the clang invocation inside of the `clang-linker-wrapper` to handle `-save-temps` mode. Comment at:

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

2023-08-17 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/CodeGen/fsplit-machine-functions.c:41 + +// RUN: %clang -c -target arm-unknown-linux-gnueabi -fsplit-machine-functions %s \ +// RUN: 2>&1 | FileCheck -check-prefix=MFS5 %s shenhan wrote: > MaskRay wrote:

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

2023-08-17 Thread Zenong Zhang via Phabricator via cfe-commits
SlaterLatiao updated this revision to Diff 551348. SlaterLatiao marked an inline comment as done. SlaterLatiao added a comment. - Added test case for partial expansion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158006/new/ https://reviews.llvm.

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

2023-08-17 Thread Zenong Zhang via Phabricator via cfe-commits
SlaterLatiao added inline comments. Comment at: clang/test/CodeGenCXX/data_member_packs.cpp:73 + // CHECK: i32 @_Z3sumIJiiEEDaDpT_(i32 noundef %ts, i32 noundef %ts1) + sum_pack2(s6); + // Check instantiation of sum(int, long, float, double) cjdb wrote: > This

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

2023-08-17 Thread Trevor Gross via Phabricator via cfe-commits
tmgross added a comment. In D86310#4597359 , @hvdijk wrote: >> I cannot reproduce that failure for some reason, but it would likely make a >> good run-pass test. > > It's reproducible online, https://godbolt.org/z/j918EeoMv, it would be > interesting to

[PATCH] D158046: [X86] Support -march=gracemont

2023-08-17 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 551350. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158046/new/ https://reviews.llvm.org/D158046 Files: clang/lib/Basi

[PATCH] D158046: [X86] Support -march=gracemont

2023-08-17 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:551 case CK_Lunarlake: + case CK_Gracemont: case CK_Sierraforest: RKSimon wrote: > FreddyYe wrote: > > RKSimon wrote: > > > Why not handle this above (below tremont) as the next in

[PATCH] D158137: Rename warn_drv_overriding_flag_option (-Woverriding-t-option) to warn_drv_overriding_flag_option (-Woverriding-option)

2023-08-17 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D158137#4597491 , @dexonsmith wrote: > In D158137#4597009 , @MaskRay wrote: > >> In D158137#4596948 , @dexonsmith >> wrote: >> >>> Can you ex

[PATCH] D158242: [Clang][Attribute] Introduce linkage attribute to specify the exact LLVM linkage type for functions or variables

2023-08-17 Thread Timo Stripf via Phabricator via cfe-commits
strimo378 created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158242 Files:

[PATCH] D149236: [clangd] Bail gracefully if given an assembly or IR source file

2023-08-17 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a reviewer: sammccall. nridge added a comment. Adding Sam, since you're on a review roll ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149236/new/ https://reviews.llvm.org/D149236 ___ cfe

[PATCH] D157485: [X86][RFC] Support new feature AVX10

2023-08-17 Thread Evgenii Kudriashov via Phabricator via cfe-commits
e-kud added a comment. Just curious, in RFC we have `-mavx10.x-256/-mavx10.x-512` but here we refer to `-mavx10.x/-mavx10.x,-mavx10-512bit`. Is it compliant with GCC, or the revision is just for the illustrative purpose? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D158244: [clang-tidy]`pro-bounds-array-to-pointer-decay` ignore predefined expression

2023-08-17 Thread Congcong Cai via Phabricator via cfe-commits
HerrCai0907 created this revision. HerrCai0907 added reviewers: njames93, PiotrZSL, aaron.ballman, Eugene.Zelenko. Herald added subscribers: carlosgalvezp, kbarton, xazax.hun, nemanjai. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang-tools-e

[PATCH] D158244: [clang-tidy]`pro-bounds-array-to-pointer-decay` ignore predefined expression

2023-08-17 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:191 + ` check + to ignore predefined expression (e.g., __func__, ...). + Please enclose `__func__` in double back-ticks. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D158067: [RISCV] Bump vector crypto to v1.0 RC2

2023-08-17 Thread Brandon Wu via Phabricator via cfe-commits
4vtomat updated this revision to Diff 551364. 4vtomat added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158067/new/ https://reviews.llvm.o

[PATCH] D158067: [RISCV] Bump vector crypto to v1.0 RC2

2023-08-17 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158067/new/ https://reviews.llvm.org/D158067 ___

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

2023-08-17 Thread Wang Pengcheng via Phabricator via cfe-commits
wangpc updated this revision to Diff 551367. wangpc added a comment. Rebase and fix failed tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 Files: clang-tools-extra/clangd/unittests/FindTargetTest

[clang] 29f11e4 - [RISCV] Bump vector crypto to v1.0 RC2

2023-08-17 Thread via cfe-commits
Author: 4vtomat Date: 2023-08-17T21:19:59-07:00 New Revision: 29f11e4fb704ffe24c01204b035b2fe117bda7c1 URL: https://github.com/llvm/llvm-project/commit/29f11e4fb704ffe24c01204b035b2fe117bda7c1 DIFF: https://github.com/llvm/llvm-project/commit/29f11e4fb704ffe24c01204b035b2fe117bda7c1.diff LOG:

[PATCH] D158067: [RISCV] Bump vector crypto to v1.0 RC2

2023-08-17 Thread Brandon Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29f11e4fb704: [RISCV] Bump vector crypto to v1.0 RC2 (authored by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D158246: [amdgpu] WIP variadics

2023-08-17 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield created this revision. Herald added subscribers: libc-commits, foad, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl, arsenm. Herald added projects: libc-project, All. JonChesterfield requested review of this revision. Herald added subscribers: llvm-commits, cfe-commi

[PATCH] D158247: [CUDA][HIP] Fix overloading resolution in global variable initializer

2023-08-17 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: tra, rjmccall, rsmith. Herald added subscribers: mattd, carlosgalvezp, kerbowa, jvesely. Herald added a reviewer: aaron.ballman. Herald added a project: All. yaxunl requested review of this revision. Currently, clang does not resolve certain ov

[PATCH] D158246: [amdgpu] WIP variadics

2023-08-17 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a comment. The lowering pass is broadly right, missing a few edge cases. Comment at: libc/config/gpu/entrypoints.txt:88 +libc.src.stdio.vsnprintf libc.src.stdio.puts libc.src.stdio.fopen ^these try to build, but fail. I haven

[PATCH] D157952: [clang] Support function pointer types with attributes when extracting parameter names for signature help

2023-08-17 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 551374. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157952/new/ https://reviews.llvm.org/D157952 Files: clang-tools-extra/clangd/unittests/CodeCompleteTests.cp

[clang-tools-extra] d9cb76b - [clang] Support function pointer types with attributes when extracting parameter names for signature help

2023-08-17 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2023-08-18T00:27:15-04:00 New Revision: d9cb76bc4d5e903fe045c58a42fc791d0c70172b URL: https://github.com/llvm/llvm-project/commit/d9cb76bc4d5e903fe045c58a42fc791d0c70172b DIFF: https://github.com/llvm/llvm-project/commit/d9cb76bc4d5e903fe045c58a42fc791d0c70172b.diff

[PATCH] D157952: [clang] Support function pointer types with attributes when extracting parameter names for signature help

2023-08-17 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd9cb76bc4d5e: [clang] Support function pointer types with attributes when extracting… (authored by nridge). Repository: rG LLVM Github Monorepo C

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

2023-08-17 Thread Ben Barham via Phabricator via cfe-commits
bnbarham added inline comments. Comment at: clang/test/Index/annotate-comments-objc.m:67-74 +#define DECLARE_ENUMS(name) \ + /** enumFromMacro IS_DOXYGEN_SINGLE */ \ + enum enumFromMacro { A }; \ + /** namedEnumFromMacro IS_DOXYGEN_SINGLE */ \ + enum name { B }; + +/// IS_DOX

[PATCH] D157879: [clang] Report missing designated initializers in C++

2023-08-17 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. In D157879#4595058 , @Fznamznon wrote: > In D157879#4594790 , @tbaeder wrote: > >> Tangentially related: Now that we have this `InitializedFields` set, would >> it be easy to add a warnin

[PATCH] D158246: [amdgpu] WIP variadics

2023-08-17 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added inline comments. Comment at: llvm/lib/CodeGen/ExpandVAIntrinsics.cpp:159 +// conventions. Escape analysis on va_list values. +return false; + } Cut this from the WIP patch as the draft is noisy. Ran some tests through x64 with a pa

[PATCH] D147905: [clangd] Avoid passing -xobjective-c++-header to the system include extractor

2023-08-17 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 551377. nridge added a comment. Rebase and address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147905/new/ https://reviews.llvm.org/D147905 Files: clang-tools-extra/clangd/SystemIncludeExtrac

[clang-tools-extra] bd74186 - [clangd] Avoid passing -xobjective-c++-header to the system include extractor

2023-08-17 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2023-08-18T00:40:11-04:00 New Revision: bd74186f1a0831b2c596e87ea056419379a223c1 URL: https://github.com/llvm/llvm-project/commit/bd74186f1a0831b2c596e87ea056419379a223c1 DIFF: https://github.com/llvm/llvm-project/commit/bd74186f1a0831b2c596e87ea056419379a223c1.diff

[PATCH] D147905: [clangd] Avoid passing -xobjective-c++-header to the system include extractor

2023-08-17 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd74186f1a08: [clangd] Avoid passing -xobjective-c++-header to the system include extractor (authored by nridge). Repository: rG LLVM Github Monor

[PATCH] D158244: [clang-tidy]`pro-bounds-array-to-pointer-decay` ignore predefined expression

2023-08-17 Thread Congcong Cai via Phabricator via cfe-commits
HerrCai0907 updated this revision to Diff 551379. HerrCai0907 added a comment. update release-note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158244/new/ https://reviews.llvm.org/D158244 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/

[clang] af7231d - [RISCV] Make the order of tests in riscv-target-features.c eqaul to the extensions listed in the table in RISCVISAInfo.cpp. NFC.

2023-08-17 Thread Jim Lin via cfe-commits
Author: Jim Lin Date: 2023-08-18T12:56:12+08:00 New Revision: af7231d1835b3dbfd938c7fdff8188ce49a3b58b URL: https://github.com/llvm/llvm-project/commit/af7231d1835b3dbfd938c7fdff8188ce49a3b58b DIFF: https://github.com/llvm/llvm-project/commit/af7231d1835b3dbfd938c7fdff8188ce49a3b58b.diff LOG:

[PATCH] D158137: Rename warn_drv_overriding_flag_option (-Woverriding-t-option) to warn_drv_overriding_flag_option (-Woverriding-option)

2023-08-17 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. In D158137#4597565 , @MaskRay wrote: > In D158137#4597491 , @dexonsmith > wrote: > >> In D158137#4597009 , @MaskRay >> wrote: >> >>> In D1581

[PATCH] D158249: [clangd] Parameter hints for calls through function pointers

2023-08-17 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. nridge added reviewers: sammccall, hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Re

[clang] 993bdb0 - [X86]Support options -mno-gather -mno-scatter

2023-08-17 Thread via cfe-commits
Author: XinWang10 Date: 2023-08-17T23:02:25-07:00 New Revision: 993bdb047c90e9b85fb91578349a9faf4f6a853d URL: https://github.com/llvm/llvm-project/commit/993bdb047c90e9b85fb91578349a9faf4f6a853d DIFF: https://github.com/llvm/llvm-project/commit/993bdb047c90e9b85fb91578349a9faf4f6a853d.diff LOG

[PATCH] D158249: [clangd] Parameter hints for calls through function pointers

2023-08-17 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:466 +// so that we can recover argument names from it. +// FIXME: This function is mostly duplicated in SemaCodeComplete.cpp; unify. +static FunctionProtoTypeLoc getPrototypeLoc(Expr *Callee) {

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

2023-08-17 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG993bdb047c90: [X86]Support options -mno-gather -mno-scatter (authored by XinWang10, committed by xin10.wang ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D158248: [clangd] Fix incorrect RecursiveASTVisitor usage in summarizeExpr()

2023-08-17 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. nridge added reviewers: sammccall, hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Pl

[PATCH] D158249: [clangd] Parameter hints for calls through function pointers

2023-08-17 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:466 +// so that we can recover argument names from it. +// FIXME: This function is mostly duplicated in SemaCodeComplete.cpp; unify. +static FunctionProtoTypeLoc getPrototypeLoc(Expr *Callee) {

[PATCH] D158249: [clangd] Parameter hints for calls through function pointers

2023-08-17 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 551390. nridge added a comment. Fix naming nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158249/new/ https://reviews.llvm.org/D158249 Files: clang-tools-extra/clangd/InlayHints.cpp clang-tools-extra/cla

[PATCH] D158252: Fix regression of D157680

2023-08-17 Thread Wang, Xin via Phabricator via cfe-commits
XinWang10 created this revision. Herald added a subscriber: pengfei. Herald added a project: All. XinWang10 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Test cases in D157680 should be

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

2023-08-17 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3775 bool UseMemberUsingDeclRules, bool ConsiderCudaAttrs = true, - bool ConsiderRequiresClauses = true); + bool UseOverrideRules = false); -

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

2023-08-17 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld updated this revision to Diff 551401. Hahnfeld added a comment. Disable RTTI to (hopefully) avoid problems on Windows. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156537/new/ https://reviews.llvm.org/D156537 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/Interpret

<    1   2   3