[PATCH] D156461: [clang][ASTImporter] Merge implicit ctors with definition

2023-08-16 Thread Ding Fei via Phabricator via cfe-commits
danix800 added a comment. In D156461#4583806 , @balazske wrote: > It looks not good to remove an invalid node from the DeclContext that > otherwise remains in the AST. I checked the problem and found that the > existing move constructor (originally in t

[clang] 28741a2 - [clang][SVE] Rename isVLSTBuiltinType, NFC

2023-08-16 Thread Jianjian GUAN via cfe-commits
Author: Jianjian GUAN Date: 2023-08-17T14:18:32+08:00 New Revision: 28741a23c9fc5e9c9ba9cad8e71c3067544bcd66 URL: https://github.com/llvm/llvm-project/commit/28741a23c9fc5e9c9ba9cad8e71c3067544bcd66 DIFF: https://github.com/llvm/llvm-project/commit/28741a23c9fc5e9c9ba9cad8e71c3067544bcd66.diff

[PATCH] D158045: [clang][SVE] Rename isVLSTBuiltinType, NFC

2023-08-16 Thread Jianjian Guan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG28741a23c9fc: [clang][SVE] Rename isVLSTBuiltinType, NFC (authored by jacquesguan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158045/new/ https://review

[clang] 2f3fe3e - [CodeGen] Remove Constant arguments from linkage functions, NFCI.

2023-08-16 Thread Jonas Hahnfeld via cfe-commits
Author: Jonas Hahnfeld Date: 2023-08-17T08:28:51+02:00 New Revision: 2f3fe3ed97bcf778d73eda5aae9f166810a4af02 URL: https://github.com/llvm/llvm-project/commit/2f3fe3ed97bcf778d73eda5aae9f166810a4af02 DIFF: https://github.com/llvm/llvm-project/commit/2f3fe3ed97bcf778d73eda5aae9f166810a4af02.diff

[PATCH] D156891: [CodeGen] Remove Constant arguments from linkage functions, NFCI.

2023-08-16 Thread Jonas Hahnfeld via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f3fe3ed97bc: [CodeGen] Remove Constant arguments from linkage functions, NFCI. (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

2023-08-16 Thread Ding Fei via Phabricator via cfe-commits
danix800 updated this revision to Diff 551016. danix800 added a comment. Add alternative testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158145/new/ https://reviews.llvm.org/D158145 Files: clang/include/clang/AST/DeclBase.h clang/lib/S

[clang] 317a0fe - [Driver][CodeGen] Properly handle -fsplit-machine-functions for fatbinary compilation.

2023-08-16 Thread Han Shen via cfe-commits
Author: Han Shen Date: 2023-08-16T23:41:34-07:00 New Revision: 317a0fe5bd7113c0ac9d30b2de58ca409e5ff754 URL: https://github.com/llvm/llvm-project/commit/317a0fe5bd7113c0ac9d30b2de58ca409e5ff754 DIFF: https://github.com/llvm/llvm-project/commit/317a0fe5bd7113c0ac9d30b2de58ca409e5ff754.diff LOG:

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

2023-08-16 Thread Han Shen via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG317a0fe5bd71: [Driver][CodeGen] Properly handle -fsplit-machine-functions for fatbinary… (authored by shenhan). Repository: rG LLVM Github Monorep

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

2023-08-16 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. For context this seems to be the patch that did not increment the bit field https://reviews.llvm.org/D139837 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158145/new/ https://reviews.llvm.org/D158145

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

2023-08-16 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. Thanks for working on this! Looks good to me except for a couple typos. Can you an an entry in `clang/docs/ReleaseNotes.rst` (mentioning the github issue) Comment at: clang/unittests/AST/ASTImporterTest.cpp:7836 +TEST_P(ASTImporterOptionSpecificTestBa

<    1   2   3