[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156726/new/ https://reviews.llvm.org/D156726 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D157452: [RFC][Clang][Codegen] `std::type_info` needs special care with explicit address spaces

rjmccall added a comment. The path of least resistance here is that IRGen should just insert conversions from the global AS to the default AS as part of evaluating `typeid`. I haven't looked at it closely, but that seems to be what this patch is doing. However, `std::type_info` is an interesti

[PATCH] D157738: [OpenMP] Emit offloading entries for indirect target variables

RaviNarayanaswamy added a comment. In D157738#4586465 , @JonChesterfield wrote: >> calling device functions via their associated host pointer > > What does this mean? Defining a function foo such that the host and each > individual target each have thei

[PATCH] D157738: [OpenMP] Emit offloading entries for indirect target variables

JonChesterfield added a comment. If calling an indirect function pointer on the GPU requires a table lookup (keyed by host function addresses, which I didn't think we knew at GPU compile time), and we cannot distinguish indirect function pointers from function pointers, then this feature must s

[PATCH] D157738: [OpenMP] Emit offloading entries for indirect target variables

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:1996-1997 +llvm::GlobalValue *GV) { + std::optional ActiveAttr = + OMPDeclareTargetDeclAttr::getActiveAttr(FD); + not a huge fan

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157332/new/ https://reviews.llvm.org/D157332 ___

[PATCH] D157925: [MachineOutliner][LTO] Enable outlining of linkonceodr functions on all targets.

jroelofs created this revision. jroelofs added reviewers: aemerson, tellenbach. Herald added subscribers: ormris, inglorion. Herald added a project: All. jroelofs requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. ... that have the out

[PATCH] D157738: [OpenMP] Emit offloading entries for indirect target variables

JonChesterfield added a comment. Ok, I'm really sure this needs to be reflected in the type system. &foo for some target foo gets to be larger than 8 bytes and we use a different calling convention for it. Otherwise however we carve this the type erasure is going to make unrelated calls acquire

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

dyung added a comment. Hi @serge-sans-paille, your change is causing the test you modified, `clang/test/AST/ast-dump-attr-json.cpp` to fail. Can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/47461 https://lab.llvm.org/buildbot/#/builders/109/builds/71264 Repository: rG

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers added a comment. In D74094#4566543 , @nickdesaulniers wrote: > Hi @lei can you please help us retest this version of this patch that > previously broke your multistage build? > https://reviews.llvm.org/rGfafc6e4fdf3673dcf557d6c8ae0c0a4bb3

[clang] 19f2b68 - Make globals with mutable members non-constant, even in custom sections

Author: David Blaikie Date: 2023-08-14T22:25:42Z New Revision: 19f2b68095fe727e40079b7c6380b36b6462e691 URL: https://github.com/llvm/llvm-project/commit/19f2b68095fe727e40079b7c6380b36b6462e691 DIFF: https://github.com/llvm/llvm-project/commit/19f2b68095fe727e40079b7c6380b36b6462e691.diff LOG:

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19f2b68095fe: Make globals with mutable members non-constant, even in custom sections (authored by dblaikie). Repository: rG LLVM Github Monorepo

[PATCH] D157738: [OpenMP] Emit offloading entries for indirect target variables

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:1996-1997 +llvm::GlobalValue *GV) { + std::optional ActiveAttr = + OMPDeclareTargetDeclAttr::getActiveA

[PATCH] D157933: [OpenMP 5.1] Parsing and Sema support for `scope` construct

mdfazlay created this revision. mdfazlay added reviewers: ABataev, jyu2, mikerice. Herald added subscribers: steakhal, martong, arphaman, guansong, yaxunl. Herald added a reviewer: NoQ. Herald added a project: All. mdfazlay requested review of this revision. Herald added a reviewer: jdoerfert. Hera

[PATCH] D157925: [MachineOutliner][LTO] Enable outlining of linkonceodr functions on all targets.

tellenbach accepted this revision. tellenbach added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157925/new/ https://reviews.llvm.org/D157925 __

[PATCH] D157933: [OpenMP 5.1] Parsing and Sema support for `scope` construct

ABataev added a comment. Need to add the tests (and the checks, if required) for the nesting of the regions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157933/new/ https://reviews.llvm.org/D157933 ___

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

iana updated this revision to Diff 550121. iana marked 4 inline comments as done. iana added a comment. Review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157793/new/ https://reviews.llvm.org/D157793 Files: clang/lib/Headers/stdarg.h

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

iana added inline comments. Comment at: clang/test/Headers/stdarg.c:34 +__va_copy(g, v); +va_copy(g, v); // c89-error{{implicit}} c89-note{{va_copy}} c99-no-diagnostics +} aaron.ballman wrote: > You should spell out these diagnostics, and I think `c99-no

[clang] 4ac4d4a - Revert "[clang] Add missing field to TLSModelAttr json AST dump"

Author: Douglas Yung Date: 2023-08-14T16:14:28-07:00 New Revision: 4ac4d4a9777e47324766aef80cfd094d06b460ec URL: https://github.com/llvm/llvm-project/commit/4ac4d4a9777e47324766aef80cfd094d06b460ec DIFF: https://github.com/llvm/llvm-project/commit/4ac4d4a9777e47324766aef80cfd094d06b460ec.diff

[clang] b7e1d26 - Revert "[clang] Add missing field to VisibilityAttr json AST dump"

Author: Douglas Yung Date: 2023-08-14T16:15:30-07:00 New Revision: b7e1d26f841c7ef3db46d30239c179a1e1b4d156 URL: https://github.com/llvm/llvm-project/commit/b7e1d26f841c7ef3db46d30239c179a1e1b4d156 DIFF: https://github.com/llvm/llvm-project/commit/b7e1d26f841c7ef3db46d30239c179a1e1b4d156.diff

[clang] 1a135bc - [MachineOutliner][LTO] Enable outlining of linkonceodr functions on all targets.

Author: Jon Roelofs Date: 2023-08-14T16:22:48-07:00 New Revision: 1a135bceb66b2d448ba4363af2f8626b6e4110bd URL: https://github.com/llvm/llvm-project/commit/1a135bceb66b2d448ba4363af2f8626b6e4110bd DIFF: https://github.com/llvm/llvm-project/commit/1a135bceb66b2d448ba4363af2f8626b6e4110bd.diff L

[PATCH] D157925: [MachineOutliner][LTO] Enable outlining of linkonceodr functions on all targets.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a135bceb66b: [MachineOutliner][LTO] Enable outlining of linkonceodr functions on all targets. (authored by jroelofs). Repository: rG LLVM Github

[PATCH] D157150: [Driver] Update BoolOption to handle Visibility. NFC

bogner updated this revision to Diff 550125. bogner edited the summary of this revision. bogner added a comment. Rebase on top of "DefaultVis" naming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157150/new/ https://reviews.llvm.org/D157150 Files:

[PATCH] D157781: [clang] Add cleanup_function field to CleanupAttr json AST dump

paulkirth added a comment. Hi, we're seeing a test failure in our CI after this stack. Not exactly sure which commit though. You can find the failing bot here: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64-rbe/b8772753421607483249/overview Some test output fro

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan updated this revision to Diff 550137. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157750/new/ https://reviews.llvm.org/D157750 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/Clang.cpp clang/test

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan marked an inline comment as done. shenhan added inline comments. Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1281-1282 +else + WithColor::warning() + << "-fsplit-machine-functions is only valid for X86.\n"; } arsenm wrote: > she

[PATCH] D157149: [Option] Add "Visibility" field and clone the OptTable APIs to use it

phosek added inline comments. Comment at: llvm/include/llvm/Option/OptParser.td:153 class Flags flags> { list Flags = flags; } +class Vis vis> { list Vis = vis; } class Group { OptionGroup Group = group; } Would it be possible to spell this out in full, that is

[PATCH] D157738: [OpenMP] Emit offloading entries for indirect target variables

jhuber6 updated this revision to Diff 550140. jhuber6 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157738/new/ https://reviews.llvm.org/D157738 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/C

[PATCH] D156237: Complete the implementation of P2361 Unevaluated string literals

hubert.reinterpretcast added a comment. Thanks, @cor3ntin, for addressing my feedback. I am not familiar enough with various aspects of it to approve it, but I see Aaron has already approved it and I think all comments have been addressed. I also appreciate that the patch helps towards making th

[PATCH] D157149: [Option] Add "Visibility" field and clone the OptTable APIs to use it

bogner added inline comments. Comment at: llvm/include/llvm/Option/OptParser.td:153 class Flags flags> { list Flags = flags; } +class Vis vis> { list Vis = vis; } class Group { OptionGroup Group = group; } phosek wrote: > Would it be possible to spell this out

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

thakis added a comment. Hello, one of the many dump commits broke tests on macOS: http://45.33.8.238/macm1/67030/step_7.txt Please take a look and revert for now if it takes a while to fix. Also, consider spreading out commits a bit so that if one breaks something, it's easily to see which one

[PATCH] D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion

felix642 updated this revision to Diff 550156. felix642 added a comment. Code review Move constructor to cpp file Added store options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157829/new/ https://reviews.llvm.org/D157829 Files: clang-tools-

[PATCH] D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion

felix642 updated this revision to Diff 550159. felix642 added a comment. Updated commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157829/new/ https://reviews.llvm.org/D157829 Files: clang-tools-extra/clang-tidy/bugprone/LambdaFunctio

[PATCH] D157691: [ASTImporter] Remove extranous FunctionTemplateDecl introduced by templated friend

danix800 updated this revision to Diff 550160. danix800 added a comment. 1. Add unit testcase 2. Use better API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157691/new/ https://reviews.llvm.org/D157691 Files: clang/lib/AST/ASTImporter.cpp cla

[PATCH] D157944: [InstrProf] Single byte counters in coverage

gulfem created this revision. Herald added subscribers: wlei, ellis, wenlei. Herald added a project: All. gulfem requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch inserts 1-byte counters instead of an 8-byte counters into llvm prof

[PATCH] D126586: [InstrProf][WIP] Implement boolean counters in coverage

gulfem updated this revision to Diff 550163. gulfem added a comment. - Extend the prototype by implementing the rest of the control-flow statements - Rename the prototype to single byte counters to be consistent with the single byte coverage used in PGO Repository: rG LLVM Github Monorepo CH

[PATCH] D157933: [OpenMP 5.1] Parsing and Sema support for `scope` construct

mdfazlay added a comment. In D157933#4586816 , @ABataev wrote: > Need to add the tests (and the checks, if required) for the nesting of the > regions I think I have the nesting of regions checks in //scope_messages.cpp//. Do you prefer to have those ch

[PATCH] D157933: [OpenMP 5.1] Parsing and Sema support for `scope` construct

ABataev added a comment. In D157933#4587164 , @mdfazlay wrote: > In D157933#4586816 , @ABataev wrote: > >> Need to add the tests (and the checks, if required) for the nesting of the >> regions > > I think I have

[PATCH] D157777: [ASTMatcher] Add matcher for 'MacroQualifiedType'

danix800 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7261 +/// Matches macro qualified types. +/// aaron.ballman wrote: > How about: Matches qualified types when the qualifier is applied via a macro. > > and then a second e

[PATCH] D157777: [ASTMatcher] Add matcher for 'MacroQualifiedType'

danix800 updated this revision to Diff 550178. danix800 added a comment. 1. Improve matcher description 2. Add a counter-example for test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15/new/ https://reviews.llvm.org/D15 Files: clang/doc

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat marked 2 inline comments as done. 4vtomat added a comment. In D146054#4586067 , @MaskRay wrote: > I think the best place to test `RISCVISAInfo.cpp` is > `llvm/unittests/Support/RISCVISAInfoTest.cpp`. > > `clang/test/Driver/print-supported-extensi

[PATCH] D157833: [C++20] [Coroutines] Mark await_suspend as noinline if the awaiter is not empty

ChuanqiXu updated this revision to Diff 550181. ChuanqiXu added a comment. Address comments: - Remove the complicated TypeVisitor, use the simple `getNonReferenceType()->getAsCXXRecordDecl()` form instead. - Reword `*leak*` to `*escape*`. - Use the suggested comments. CHANGES SINCE LAST ACTION

[PATCH] D157833: [C++20] [Coroutines] Mark await_suspend as noinline if the awaiter is not empty

ChuanqiXu marked 4 inline comments as done. ChuanqiXu added a comment. Address comments. Thanks for reviewing. Comment at: clang/lib/CodeGen/CGCall.cpp:5496 + // execution of the await_suspend. To achieve this, we need to prevent the + // await_suspend get inlined before Coro

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 550185. 4vtomat added a comment. 1. Apply clang-format for this patch 2. Replace FileCheck --implicit-check-not=warning: with %clang -Werror Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://rev

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

kaz7 added reviewers: MaskRay, jdoerfert, awarzynski. kaz7 added a comment. I randamly added reviewrs who review code related to feature flags and features group in clang. I appreciate if some of you guys have a time to check this patch too. Thank you so much. Repository: rG LLVM Github Mo

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:5166 +// VE feature flags +let Flags = [TargetSpecific, CC1Option] in { +def mvevpu : Flag<["-"], "mvevpu">, Group, Other feature group options don't set CC1Option: we do not need t

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:5169 + HelpText<"Emit VPU instructions for VE">; +def mno_vevpu : Flag<["-"], "mno-vevpu">, Group, + HelpText<"Do not emit VPU instructions for VE">; In general, we just need docum

[PATCH] D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clang-tidy/bugprone/LambdaFunctionNameCheck.cpp:91-93 +if (IgnoreMacros) { + return; +} Repository:

[PATCH] D136664: [CMake] Support building crt with the bootstrapping build

phosek abandoned this revision. phosek added a comment. Herald added a subscriber: ekilmer. Superseded by D153989 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136664/new/ https://reviews.llvm.org/D136664 __

[PATCH] D157952: [clang] Support function pointer types with attributes when extracting parameter names for signature help

nridge created this revision. nridge added reviewers: hokein, kadircet, Qwinci. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, wangpc, ilya-biryukov. Herald added projects: clang, clang-tools-extra.

[clang-tools-extra] 766dd7b - [clang-tidy] Fix handling of out-of-line functions in readability-static-accessed-through-instance

Author: Piotr Zegar Date: 2023-08-15T06:59:11Z New Revision: 766dd7b80b575e723c8cb454532b614f9d5f2bc7 URL: https://github.com/llvm/llvm-project/commit/766dd7b80b575e723c8cb454532b614f9d5f2bc7 DIFF: https://github.com/llvm/llvm-project/commit/766dd7b80b575e723c8cb454532b614f9d5f2bc7.diff LOG: [

[clang-tools-extra] 0c7d28f - [clang-tidy] Ignore decltype in misc-redundant-expression

Author: Piotr Zegar Date: 2023-08-15T06:59:11Z New Revision: 0c7d28f72e190ca387a14cf76d611c4e8b292557 URL: https://github.com/llvm/llvm-project/commit/0c7d28f72e190ca387a14cf76d611c4e8b292557 DIFF: https://github.com/llvm/llvm-project/commit/0c7d28f72e190ca387a14cf76d611c4e8b292557.diff LOG: [

[PATCH] D157374: [clang-tidy] Ignore decltype in misc-redundant-expression

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c7d28f72e19: [clang-tidy] Ignore decltype in misc-redundant-expression (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D157374?vs=548104&id=550201#toc Repository: rG LLVM G

[PATCH] D157326: [clang-tidy] Fix handling of out-of-line functions in readability-static-accessed-through-instance

This revision was automatically updated to reflect the committed changes. Closed by commit rG766dd7b80b57: [clang-tidy] Fix handling of out-of-line functions in readability-static… (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D157326?vs=548066&id=550200#toc Reposit

<    1   2   3