[clang] 925ec54 - Revert "[clang][ExprConst] Add RHS source range to div by zero diags"

Author: Timm Bäder Date: 2023-08-08T18:16:35+02:00 New Revision: 925ec544cf541444bd6615fcf51d2a4b6af4acc5 URL: https://github.com/llvm/llvm-project/commit/925ec544cf541444bd6615fcf51d2a4b6af4acc5 DIFF: https://github.com/llvm/llvm-project/commit/925ec544cf541444bd6615fcf51d2a4b6af4acc5.diff LO

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

steven_wu accepted this revision. steven_wu added a comment. In D155824#4568904 , @xen0n wrote: > This still LGTM, @steven_wu would you please take another look so this can > get re-landed if confirmed working? The driver part LGTM. Repository: rG L

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Stmt.h:596-597 -// These don't need to be particularly wide, because they're -// strictly limited by the forms of expressions we permit. -unsigned NumSubExprs : 8; -unsigned ResultIndex : 3

[PATCH] D157410: [Flang] Enable Rpass flag

victorkingi created this revision. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. victorkingi requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert, MaskRay. Herald added a project: clang. This patch allows

[PATCH] D157394: [clang][DeclPrinter] Improve AST print of function attributes

aaron.ballman added a comment. This is looking to make similar changes to the ones proposed in https://reviews.llvm.org/D141714 -- can you coordinate with the other author so there's only one review that covers both needs? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

vitalybuka added a comment. In D157119#4569725 , @jroelofs wrote: > Flaky test? Here's a later build where it succeeds, but the change has > nothing to do with clangd: > https://lab.llvm.org/buildbot/#/builders/168/builds/14997 No, I manually requested

[clang] 4e8cae4 - Fix build break on pickier MSVC configurations [NFC]

Author: Paul Robinson Date: 2023-08-08T12:44:47-04:00 New Revision: 4e8cae4aec6590ca13ec65ed38d6da55c6031755 URL: https://github.com/llvm/llvm-project/commit/4e8cae4aec6590ca13ec65ed38d6da55c6031755 DIFF: https://github.com/llvm/llvm-project/commit/4e8cae4aec6590ca13ec65ed38d6da55c6031755.diff

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

probinson added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1761 + S.FFDiag(Loc, diag::note_constexpr_invalid_cast) + << static_cast(Kind) << S.Current->getRange(OpPC); + return false; aaron.ballman wrote: > tbaeder wrote: > > probinson wrot

[PATCH] D144831: Rebase D41416 on top of master

SAtacker updated this revision to Diff 548263. SAtacker added a comment. Fix call to lazyTemplateSpecialization in Function Template Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144831/new/ https://reviews.llvm.org/D144831 Files: clang/include/

[PATCH] D157410: [Flang] Enable Rpass flag

tblah accepted this revision. tblah added a comment. This revision is now accepted and ready to land. LGTM, thanks for this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157410/new/ https://reviews.llvm.org/D157410

[PATCH] D155997: [Phase Ordering] Don't speculate in SimplifyCFG before PGO annotation

tejohnson added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155997/new/ https://reviews.llvm.org/D155997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

aaron.ballman added subscribers: jcranmer-intel, zahiraam. aaron.ballman added inline comments. Comment at: clang/lib/AST/FormatString.cpp:484-487 + if (const auto *PT = argTy->getAs()) { +if (PT->getPointeeType()->isCharType()) + return Match; + }

[clang] 5f8d332 - Revert "[Clang][OpenMP] Support for Code Generation of loop bind clause."

Author: Nico Weber Date: 2023-08-08T13:12:25-04:00 New Revision: 5f8d332027c8a9ea657752a3b33696ddc9a7e257 URL: https://github.com/llvm/llvm-project/commit/5f8d332027c8a9ea657752a3b33696ddc9a7e257 DIFF: https://github.com/llvm/llvm-project/commit/5f8d332027c8a9ea657752a3b33696ddc9a7e257.diff LO

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt updated this revision to Diff 548274. RIscRIpt added a comment. Rebased onto main, run local lit clang/tests. (bump for @cor3ntin) As far as I understand this shall be merged into main by maintainers. Please let me know if something else is expected from me. Repository: rG LLVM Github

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

cor3ntin added a comment. In D153914#4570109 , @RIscRIpt wrote: > Rebased onto main, run local lit clang/tests. (bump for @cor3ntin) > As far as I understand this shall be merged into main by maintainers. > Please let me know if something else is expected

[PATCH] D157420: [clang] Enable constexpr on LZCNT/POPCNT MS extension intrinsics

alexguirre created this revision. alexguirre added a reviewer: RKSimon. Herald added a project: All. alexguirre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This enables us to use __lzcnt / __popcnt intrinsics inside constexpr code. Re

[PATCH] D156178: [HLSL] add pow library function

bogner added a comment. In D156178#4530161 , @bogner wrote: > Looking at > https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-pow, > it seems a bit underspecified, but do we need to worry about differences > between that spec

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

crtrott added a comment. Question: does this bug potentially affect code generation for AMD/NVIDIA/Intel GPUs? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157332/new/ https://reviews.llvm.org/D157332

[PATCH] D156172: [clang][CodeGen] Emit annotations for function declarations.

brendandahl added a comment. @efriedma I've updated the patch to fix the decl-use-decl example and added a test for it. Anything else? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156172/new/ https://reviews.llvm.org/D156172

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

hokein added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:322 + auto EndLoc = Args.empty() ? Loc : Args.back()->getEndLoc(); + return S.BuildCallExpr(nullptr, Result.get(), Loc, Args, EndLoc, nullptr); } aaron.ballman wrote: > hokein wrote: >

[PATCH] D156178: [HLSL] add pow library function

bob80905 updated this revision to Diff 548296. bob80905 added a comment. - clang format pow.hlsl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156178/new/ https://reviews.llvm.org/D156178 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h clang/t

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7280 + "a %select{function|lambda}0 with an explicit object parameter cannot " + "%select{be const|be mutable|have reference qualifiers|be volatile}1">; +def err_invalid_explicit_object

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

crtrott added a comment. To answer my own question: I was able to reproduce the bug when compiling for NVIDIA GPUs, I was not able to reproduce it for AMD GPUs yet, and I didn't try for Intel GPUs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM (but please don't merge until we reach consensus on the overall feature) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155850/new/ https://reviews.llvm.org/D155850 _

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

ilya-biryukov added a comment. In D153114#4569591 , @ChuanqiXu wrote: > BTW, I have a question about supporting header modules (including clang > header modules and C++20 header units) in static analysing tools (including > clangd), "why can't we fallba

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

AlexVlx added a comment. In D155850#4570336 , @efriedma wrote: > LGTM (but please don't merge until we reach consensus on the overall feature) Of course, and thank you for the review. Please, do stick around if you don't mind, because this'll still get

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

aaron.ballman added a comment. Aside from some changes to the test coverage, I think @hokein and I are in agreement on moving forward with the patch as-is (feel free to correct me if I'm wrong though!). Comment at: clang/lib/Sema/SemaCoroutine.cpp:322 + auto EndLoc = Args.em

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

efriedma added a comment. The overall approach here seems reasonable. I mean, technically the undefined behavior is happening in the library, but detecting it early seems like a good idea. This approach does have a significant limitation, though: CGBuiltin won't detect cases that involve taki

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

aaron.ballman added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1494-1505 +Decl *Sema::getCurLocalScopeDecl() { + if (const BlockScopeInfo *BSI = getCurBlock()) +return BSI->TheDecl; + else if (const LambdaScopeInfo *LSI = getCurLambda()) +return LSI->CallOpera

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

jyknight added a comment. In D155387#4557834 , @hctim wrote: > I found an issue with building Android using this patch. I've reduced it down > to the following problem where the evaluation of the `std::visit` is believed > to be non-exhaustive, but it s

[PATCH] D157420: [clang] Enable constexpr on LZCNT/POPCNT MS extension intrinsics

RKSimon added reviewers: erichkeane, aaron.ballman. RKSimon added a comment. Please can you add them to the constexpr lists in LanguageExtensions.rst ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157420/new/ https://reviews.llvm.org/D157420

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

fwolff created this revision. fwolff added reviewers: PiotrZSL, aaron.ballman. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. fwolff requested review of this revision. Herald added a subs

[PATCH] D157429: [NFC] [Clang] Fix static analyzer concern

eandrews created this revision. eandrews added reviewers: aaron.ballman, tahonermann. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. eandrews requested review of this revision.

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

PiotrZSL added a comment. Missing release notes, except that looks fine. What about switchStmt ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157428/new/ https://reviews.llvm.org/D157428 ___ cfe-commits

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

mstorsjo added a comment. In D157332#4570290 , @crtrott wrote: > Question: does this bug potentially affect code generation for > AMD/NVIDIA/Intel GPUs? I believe the easiest way to test that is to try compiling `struct S {}; S ret() { return S(); }` i

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

vitalybuka added a comment. In D157119#4569967 , @vitalybuka wrote: > In D157119#4569725 , @jroelofs > wrote: > >> Flaky test? Here's a later build where it succeeds, but the change has >> nothing to do with cl

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

vitalybuka added a comment. This patch brakes https://lab.llvm.org/buildbot/#/builders/168/builds/14997 Not sure what is wrong there, probably the test need to be updated. Can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

aaron.ballman added a comment. In D153536#4570513 , @vitalybuka wrote: > This patch brakes https://lab.llvm.org/buildbot/#/builders/168/builds/14997 > Not sure what is wrong there, probably the test need to be updated. Can you > please take a look? I'm

[PATCH] D157429: [NFC] [Clang] Fix static analyzer concern

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a small formatting nit. Comment at: clang/lib/Analysis/BodyFarm.cpp:809 Prop = MD->findPropertyDecl(); -IVar = findBackingIvar(Prop); +IV

[clang] df5137e - [HLSL] add pow library function

Author: Joshua Batista Date: 2023-08-08T13:07:36-07:00 New Revision: df5137e984a607248cd31ed67aa3822e8ac2a083 URL: https://github.com/llvm/llvm-project/commit/df5137e984a607248cd31ed67aa3822e8ac2a083 DIFF: https://github.com/llvm/llvm-project/commit/df5137e984a607248cd31ed67aa3822e8ac2a083.diff

[PATCH] D156178: [HLSL] add pow library function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf5137e984a6: [HLSL] add pow library function (authored by bob80905). Changed prior to commit: https://reviews.llvm.org/D156178?vs=548296&id=54832

[PATCH] D155997: [Phase Ordering] Don't speculate in SimplifyCFG before PGO annotation

aeubanks added a comment. can we try not gating this on PGO as suggested? minimizing differences between pipelines is nice, and as mentioned it'll help with other cases Comment at: llvm/test/Transforms/PhaseOrdering/simplifycfg-speculate-blocks.ll:1 +;; Check that SimplifyCFG

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

vitalybuka added a comment. In D153536#4570534 , @aaron.ballman wrote: > In D153536#4570513 , @vitalybuka > wrote: > >> This patch brakes https://lab.llvm.org/buildbot/#/builders/168/builds/14997 >> Not sure wha

[PATCH] D157420: [clang] Enable constexpr on LZCNT/POPCNT MS extension intrinsics

alexguirre updated this revision to Diff 548323. alexguirre added a comment. Added __lzcnt / __popcnt to the constexpr lists in LanguageExtensions.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157420/new/ https://reviews.llvm.org/D157420 Files

[PATCH] D157432: [clang][ConstExprEmitter] handle Unary Not on integers

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Consider the following statement: int x = ~0; With the following AST: `-VarDecl 0x5647bdb12d60 col:5

[PATCH] D157434: [include-cleaner] Add a simple heuristic to handle token-pasting symbols.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. include-cleaner didn't report the usage of token-pasting symbols, as these symbols are spelled in a "scratch space" fil

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

cor3ntin added a subscriber: sammccall. cor3ntin added a comment. Looking at the failing test (`clang-tools-extra/clangd/test/crash-preamble.test`), I'd be very surprising if it is related to a front end change like this PR. Any idea @sammccall ? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

vitalybuka added a comment. Not a test update The second line of the test triggers: RUN: not --crash clangd -lit-test -sync=0 < %s 2> %t.async.err == Signalled while building preamble Filename: ===

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

aaron.ballman added a comment. In D153536#4570561 , @vitalybuka wrote: > In D153536#4570534 , @aaron.ballman > wrote: > >> In D153536#4570513 , @vitalybuka >> wrote: >>

[PATCH] D157432: [clang][ConstExprEmitter] handle Unary Not on integers

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1402 +return nullptr; + } + A lot of these visitor methods for UnaryOperator are going to look almost the same; I think I might prefer to have a `VisitUnaryOperator` met

[PATCH] D157435: [Sema] Do not emit -Wmissing-variable-declarations for register variables

nathanchance created this revision. nathanchance added reviewers: aaron.ballman, nickdesaulniers. Herald added a subscriber: pengfei. Herald added a project: All. nathanchance requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When building th

[PATCH] D157436: [clang-tidy] `performance-faster-string-find` generates incorrect fixes for single quote character literals

fwolff created this revision. fwolff added reviewers: PiotrZSL, carlosgalvezp. fwolff added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. fwolff requested review of this revision. Herald added a subscriber: cfe-co

[PATCH] D157435: [Sema] Do not emit -Wmissing-variable-declarations for register variables

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the patch; I think it's better not to warn rather than expect users to add an `unsigned long currest_stack_pointer;` declaration before the definition for `registe

[clang] 6a4779c - [NFC] Fix static analyzer concern

Author: Elizabeth Andrews Date: 2023-08-08T13:28:15-07:00 New Revision: 6a4779cc235c171f7a5049726f58e14a2cc4e6c8 URL: https://github.com/llvm/llvm-project/commit/6a4779cc235c171f7a5049726f58e14a2cc4e6c8 DIFF: https://github.com/llvm/llvm-project/commit/6a4779cc235c171f7a5049726f58e14a2cc4e6c8.d

[PATCH] D157429: [NFC] [Clang] Fix static analyzer concern

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a4779cc235c: [NFC] Fix static analyzer concern (authored by eandrews). Herald added a project: clang. Changed prior to commit: https://reviews.ll

[PATCH] D157429: [NFC] [Clang] Fix static analyzer concern

eandrews added a comment. In D157429#4570540 , @aaron.ballman wrote: > LGTM with a small formatting nit. Thanks for the review! I committed the patch after fixing the formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

yaxunl accepted this revision. yaxunl added a comment. LGTM from HIP side. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155850/new/ https://reviews.llvm.org/D155850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

fwolff updated this revision to Diff 548334. fwolff added a comment. Mention this change in the release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157428/new/ https://reviews.llvm.org/D157428 Files: clang-tools-extra/clang-tidy/readabil

[PATCH] D157436: [clang-tidy] `performance-faster-string-find` generates incorrect fixes for single quote character literals

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/FasterStringFindCheck.cpp:40 + // "'" is OK, but ''' is not, so add a backslash + if (ClosePos - OpenPos == 2 && Result[OpenPos + 1] == '\'') +Result.replace(OpenPos + 1, 1, "\\'"); --

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

arsenm added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1101-1102 +MPM.addPass(StdParAcceleratorCodeSelectionPass()); +} +else if (LangOpts.HIPStdParInterposeAlloc) { + MPM.addPass(StdParAllocationInterpositionPass()); For

[PATCH] D157435: [Sema] Do not emit -Wmissing-variable-declarations for register variables

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some minor nits. Comment at: clang/docs/ReleaseNotes.rst:126-127 of a base class is not called in the constructor of its derived class. +- Clang no longer emits `-Wmissing-variable-declarati

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:199-202 +- Improved :doc:`readability-implicit-bool-conversion + ` check to take do-while loops into + account for the ``AllowIntegerConditions`` and ``AllowPointerConditions`` + options. -

[PATCH] D157438: [OpenMP] Ensure wrapper headers are included on both host and device

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, tra, JonChesterfield, yaxunl, sivachandra. Herald added a subscriber: guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sstefan1, MaskRa

[PATCH] D157435: [Sema] Do not emit -Wmissing-variable-declarations for register variables

nathanchance updated this revision to Diff 548337. nathanchance added a comment. - Update formatting in release notes - Add GCC bug link to commit message - Remove unnecessary REQUIRES: in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157435/ne

[clang] a22d385 - [Sema] Do not emit -Wmissing-variable-declarations for register variables

Author: Nathan Chancellor Date: 2023-08-08T13:41:21-07:00 New Revision: a22d385f9656c95f5ce4155ea705aab6f8ef6d82 URL: https://github.com/llvm/llvm-project/commit/a22d385f9656c95f5ce4155ea705aab6f8ef6d82 DIFF: https://github.com/llvm/llvm-project/commit/a22d385f9656c95f5ce4155ea705aab6f8ef6d82.d

[PATCH] D157435: [Sema] Do not emit -Wmissing-variable-declarations for register variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa22d385f9656: [Sema] Do not emit -Wmissing-variable-declarations for register variables (authored by nathanchance). Repository: rG LLVM Github Mo

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

aaron.ballman added a comment. Thank you for working on this! Comment at: clang/docs/ReleaseNotes.rst:59 +- Improved `__builtin_offsetof` support, allowing qualified name in member designator. You should also link to https://github.com/

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

fwolff updated this revision to Diff 548342. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157428/new/ https://reviews.llvm.org/D157428 Files: clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp clang-tools-extra/docs/Releas

[PATCH] D157040: [OpenMP][IR] Set correct alignment for internal variables

erjin updated this revision to Diff 548344. erjin added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. se Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157040/new/ https://reviews.llvm.org/D157040 Files: clang/

[PATCH] D155858: Add a concept AST node.

hokein added a subscriber: aaron.ballman. hokein added a comment. adding @aaron.ballman, who might have opinion on this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155858/new/ https://reviews.llvm.org/D155858 ___

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

fwolff marked an inline comment as done. fwolff added a comment. Thanks for reviewing this @PiotrZSL! In D157428#4570497 , @PiotrZSL wrote: > What about switchStmt ? The `AllowIntegerConditions` and `AllowPointerConditions` options only apply to `int -

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157428/new/ https://reviews.llvm.org/D157428 ___

[PATCH] D157436: [clang-tidy] `performance-faster-string-find` generates incorrect fixes for single quote character literals

fwolff updated this revision to Diff 548347. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157436/new/ https://reviews.llvm.org/D157436 Files: clang-tools-extra/clang-tidy/performance/FasterStringFindCheck.cpp clang-tools-extra/docs/ReleaseNotes

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis updated this revision to Diff 548349. ellis added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154014/new/ https://reviews.llvm.org/D154014 Files: clang/docs/SanitizerSpecialCaseList.rst clang/lib/Basic/ProfileList.cpp

[PATCH] D157436: [clang-tidy] `performance-faster-string-find` generates incorrect fixes for single quote character literals

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157436/new/ https://reviews.llvm.org/D157436 ___

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

aaron.ballman added a comment. In D155383#4507928 , @strimo378 wrote: > There are many ast-dump tests about decls but there are nearly no other type > tests. We should still be adding tests for these changes, to ensure we don't regress the behavior lat

[PATCH] D157384: [clang] Added Attr::getVariety function

strimo378 abandoned this revision. strimo378 added a comment. @aaron.ballman Thank you for the information. Strange that I missed that ... I even used the function somewhere else o_O Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157384/new/ https:

[PATCH] D157331: [clang] Implement C23

hiraditya added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) xbolva00 wrote: > yabinc wrote: > > enh wrote: > > > enh wrote: > > > > enh wrote: > > > > > Zij

[PATCH] D157438: [OpenMP] Ensure wrapper headers are included on both host and device

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1190-1191 // the resource directory at clang/lib/Headers/llvm_libc_wrappers. -if (C.getActiveOffloadKinds() == Action::OFK_None) { +if ((getToolChain().getTriple().isNVPTX() || +

[PATCH] D157428: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf263f45ba649: [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions`… (authored by fwolff). Repository: rG LLVM Github Monore

[clang-tools-extra] f263f45 - [clang-tidy] `readability-implicit-bool-conversion.AllowIntegerConditions` ignores `DoStmt`s

Author: Fabian Wolff Date: 2023-08-08T23:07:10+02:00 New Revision: f263f45ba6494c7516a11b1af920d6ca98e79d2b URL: https://github.com/llvm/llvm-project/commit/f263f45ba6494c7516a11b1af920d6ca98e79d2b DIFF: https://github.com/llvm/llvm-project/commit/f263f45ba6494c7516a11b1af920d6ca98e79d2b.diff

[PATCH] D157438: [OpenMP] Ensure wrapper headers are included on both host and device

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1190-1191 // the resource directory at clang/lib/Headers/llvm_libc_wrappers. -if (C.getActiveOffloadKinds() == Action::OFK_None) { +if ((getToolChain().getTriple().isNVPTX() || +

[PATCH] D157331: [clang] Implement C23

hiraditya added inline comments. Comment at: clang/test/Headers/stdckdint.cpp:1 +// RUN: %clang_cc1 -emit-llvm -fgnuc-version=4.2.1 -std=gnu++11 %s -o - | FileCheck %s + seems like we don't have a -std=gnu23, or -std=c23 standard flag for this in clang yet. ht

[PATCH] D157440: [clang][ConstExprEmitter] handle BinaryOperators that don't have signedness or overflow concerns for integrals

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Handles binary operators: & ^ | == != Check that each side evaluates to a ConstantInt then combine the resu

[PATCH] D157440: [clang][ConstExprEmitter] handle BinaryOperators that don't have signedness or overflow concerns for integrals

nickdesaulniers updated this revision to Diff 548358. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - use const & - add link to issue tracker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157440/new/ https://

[PATCH] D157441: [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: t-rasmud, NoQ, jkorous, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Use `Strategy` to determine whether to fix

[PATCH] D157331: [clang] Implement C23

enh added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) hiraditya wrote: > xbolva00 wrote: > > yabinc wrote: > > > enh wrote: > > > > enh wrote: > > > > > enh

[clang] ea72a4e - [CUDA][HIP] Fix template argument deduction

Author: Yaxun (Sam) Liu Date: 2023-08-08T17:39:01-04:00 New Revision: ea72a4e6547feaa82e132746c6777b3b69aed0d5 URL: https://github.com/llvm/llvm-project/commit/ea72a4e6547feaa82e132746c6777b3b69aed0d5 DIFF: https://github.com/llvm/llvm-project/commit/ea72a4e6547feaa82e132746c6777b3b69aed0d5.dif

[PATCH] D154300: [CUDA][HIP] Fix template argument deduction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea72a4e6547f: [CUDA][HIP] Fix template argument deduction (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D157441: [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1624 // Inserts the [0] -std::optional EndOfOperand = -getEndCharLoc(BaseDeclRefExpr, SM, Ctx.getLangOpts()); -if (EndOfOperand) { +if (auto LocPastOperand = +

[PATCH] D157445: [CodeGen][UBSan] getUBSanFunctionTypeHash does not handle the attributed function case correctly, leading to an assertion failure. This patch desugars the QualType if it is of Attribu

usama54321 created this revision. Herald added a project: All. usama54321 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. rdar://113144087 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157445 Files: clang/lib/CodeGen

[PATCH] D157438: [OpenMP] Ensure wrapper headers are included on both host and device

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1190-1191 // the resource directory at clang/lib/Headers/llvm_libc_wrappers. -if (C.getActiveOffloadKinds() == Action::OFK_None) { +if ((getToolChain().getTriple().isNVPTX() || +

[PATCH] D157438: [OpenMP] Ensure wrapper headers are included on both host and device

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1190-1191 // the resource directory at clang/lib/Headers/llvm_libc_wrappers. -if (C.getActiveOffloadKinds() == Action::OFK_None) { +if ((getToolChain().getTriple().isNVPTX() || +

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt updated this revision to Diff 548366. RIscRIpt marked 4 inline comments as done. RIscRIpt added a comment. Address review comments, rebase onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153914/new/ https://reviews.llvm.org/D153914

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt added a comment. In D153914#4570148 , @cor3ntin wrote: > We will commit on your behalf, what name/email do you want us to use? > Thanks! Thanks for asking; keep the name/email as-is in the commit you see: `Author: Richard Dzenis ` =

[PATCH] D157438: [OpenMP] Ensure wrapper headers are included on both host and device

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157438/new/ https://reviews.llvm.org/D157438 ___

[PATCH] D157331: [clang] Implement C23

ZijunZhao added inline comments. Comment at: clang/test/Headers/stdckdint.cpp:1 +// RUN: %clang_cc1 -emit-llvm -fgnuc-version=4.2.1 -std=gnu++11 %s -o - | FileCheck %s + enh wrote: > hiraditya wrote: > > seems like we don't have a -std=gnu23, or -std=c23 standar

[PATCH] D157331: [clang] Implement C23

enh added inline comments. Comment at: clang/test/Headers/stdckdint.cpp:1 +// RUN: %clang_cc1 -emit-llvm -fgnuc-version=4.2.1 -std=gnu++11 %s -o - | FileCheck %s + ZijunZhao wrote: > enh wrote: > > hiraditya wrote: > > > seems like we don't have a -std=gnu23, or

[PATCH] D142569: [OpenMP] Introduce kernel environment

doru1004 added a comment. The changes in this patch do not actually work correctly with kernels that really need to be in Generic mode. The ExecMode value recovered in the kmpc_kernel_init function is 3 in the case where it needs to be 1. The problem lies with the OpenMPOpt changes since disabl

[PATCH] D157331: [clang] Implement C23

ZijunZhao added inline comments. Comment at: clang/test/Headers/stdckdint.cpp:1 +// RUN: %clang_cc1 -emit-llvm -fgnuc-version=4.2.1 -std=gnu++11 %s -o - | FileCheck %s + enh wrote: > ZijunZhao wrote: > > enh wrote: > > > hiraditya wrote: > > > > seems like we do

<    1   2   3   >