[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hazohelet added a comment. In D152495#4566634 , @aaron.ballman wrote: > In D152495#4563520 , @hazohelet > wrote: > >> I reverted this change because it broke sanitizer buildbots. >> https://lab.llvm.org/buildbot

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

sandeepkosuri updated this revision to Diff 548082. sandeepkosuri added a comment. - Updated `SemaOpenMP.cpp` to support `thread_limit` clause on the newly allowed directives. - This update is to fix the newly added LIT tests' failures (which were occurring only on debug build) CHANGES SINCE

[PATCH] D157367: [clang-tidy] Ignore delegate constructors in cppcoreguidelines-pro-type-member-init

PiotrZSL created this revision. PiotrZSL added reviewers: carlosgalvezp, njames93, ccotter. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:841 const auto *ParamTy = - Method->getParamDecl(0)->getType()->getAs(); + Method->getNonObjectParameter(0)->getType()->getAs(); if (!ParamTy || ParamTy->getPointeeType().isConst

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. I'm ok with this if @owenpan is Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 ___ cfe-c

[clang] 28b5f30 - [Clang][AArch64] Add/implement ACLE keywords for SME.

Author: Sander de Smalen Date: 2023-08-08T07:00:59Z New Revision: 28b5f3087a3fcd39c80e2b1470a950da17e4cd08 URL: https://github.com/llvm/llvm-project/commit/28b5f3087a3fcd39c80e2b1470a950da17e4cd08 DIFF: https://github.com/llvm/llvm-project/commit/28b5f3087a3fcd39c80e2b1470a950da17e4cd08.diff L

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28b5f3087a3f: [Clang][AArch64] Add/implement ACLE keywords for SME. (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D12

[PATCH] D157362: [RISCV] Add Zicfilp extension.

fakepaper56 updated this revision to Diff 548088. fakepaper56 added a comment. Also support pseudo instruction lpad. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157362/new/ https://reviews.llvm.org/D157362 Files: clang/test/Preprocessor/riscv-

[clang] 658490a - [OpenMP][OMPD][Doc] Update OMPD implementations details.

Author: Vignesh Balasubramanian Date: 2023-08-08T13:11:35+05:30 New Revision: 658490abc97a291fc01e463599404f28e2126335 URL: https://github.com/llvm/llvm-project/commit/658490abc97a291fc01e463599404f28e2126335 DIFF: https://github.com/llvm/llvm-project/commit/658490abc97a291fc01e463599404f28e212

[PATCH] D156878: [OpenMP][OMPD][Doc] Update the implementation details of OMPD

This revision was automatically updated to reflect the committed changes. Closed by commit rG658490abc97a: [OpenMP][OMPD][Doc] Update OMPD implementations details. (authored by Vignesh Balasubramanian ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

donat.nagy added a comment. Why is this checker placed in the "unix" group (instead of e.g. "core")? As far as I understand it can check some POSIX-specific functions with a flag (that's off by default) but the core functionality checks platform-independent standard library functions. Moreover

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

hokein added a comment. Thanks for exploring all the options. For case 1) > Note that CXXMemberCallExpr 0x55d106716260 > relies on > RParenLoc directly. Coroutine is implemented as member call so I think RParen > is intended and should exist and be correct. Yeah, I think this is because we do

[clang] 38cf47f - [clang] Error on substitution failure within lambda body inside a requires-expression

Author: Podchishchaeva, Mariya Date: 2023-08-08T01:08:38-07:00 New Revision: 38cf47f037b2504a57ba5673f507241af1d6e19d URL: https://github.com/llvm/llvm-project/commit/38cf47f037b2504a57ba5673f507241af1d6e19d DIFF: https://github.com/llvm/llvm-project/commit/38cf47f037b2504a57ba5673f507241af1d6e

[PATCH] D156993: [clang] Error on substitution failure within lambda body inside a requires-expression

This revision was automatically updated to reflect the committed changes. Closed by commit rG38cf47f037b2: [clang] Error on substitution failure within lambda body inside a requires… (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

balazske added a comment. This checker was originally in the "unix" package. I agree that this is not exact and `core` can be better, the checked functions should be available in any default C library on UNIX, OSX, Windows or other platforms too, even the POSIX ones at least in some cases. Re

[clang] cb3136b - [clang] Pass --cuda-path to fix test/Driver/openmp-offload-jit.c

Author: Jonas Hahnfeld Date: 2023-08-08T10:21:55+02:00 New Revision: cb3136b0d3596f5c3984e4fb49359e2a1a28a547 URL: https://github.com/llvm/llvm-project/commit/cb3136b0d3596f5c3984e4fb49359e2a1a28a547 DIFF: https://github.com/llvm/llvm-project/commit/cb3136b0d3596f5c3984e4fb49359e2a1a28a547.diff

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

Hahnfeld added a comment. `test/Driver/openmp-offload-jit.c` was still failing for me with CUDA installed, so I pushed rGcb3136b0d3596f5c3984e4fb49359e2a1a28a547 to add an explicit `--cuda-path` and make it return exit code 0

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 548103. Herald added a subscriber: jplehr. Herald added a reviewer: kiranchandramohan. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/

[PATCH] D157374: [clang-tidy] Ignore decltype in misc-redundant-expression

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Modify check to ignor

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi added a comment. In D156320#4560839 , @awarzynski wrote: > Hey @victorkingi , thank you for working on this :) > > There's quite a lot going on here and I am thinking that it might be good to > split this into a few patches? Also, please not

[clang-tools-extra] 7899d2a - [clang-tidy][NFC] Remove trailing whitespaces from ProTypeVarargCheck

Author: Piotr Zegar Date: 2023-08-08T08:56:41Z New Revision: 7899d2aa666359adc6b1d3a66e36f07c2130eb6c URL: https://github.com/llvm/llvm-project/commit/7899d2aa666359adc6b1d3a66e36f07c2130eb6c DIFF: https://github.com/llvm/llvm-project/commit/7899d2aa666359adc6b1d3a66e36f07c2130eb6c.diff LOG: [

[PATCH] D157376: [clang-tidy] Ignore unevaluated context in cppcoreguidelines-pro-type-vararg

PiotrZSL created this revision. PiotrZSL added reviewers: carlosgalvezp, njames93, ccotter. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D156787: [analyzer][attr] Add docs to ownership_* attributes

Szelethus updated this revision to Diff 548116. Szelethus marked 4 inline comments as done. Szelethus added a comment. Fixes according to reviewer comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156787/new/ https://reviews.llvm.org/D156787 Files: clang/include/clang/Basic/Att

[PATCH] D156787: [analyzer][attr] Add docs to ownership_* attributes

Szelethus added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1189 +``onwership_returns``: Functions with this annotation return dynamic memory. +The second annotation parameter is the size of the returned memory in bytes. + aaron.ballman wro

[PATCH] D157379: [CodeGen] Restrict addEmittedDeferredDecl to incremental extensions

Hahnfeld created this revision. Hahnfeld added reviewers: rjmccall, v.g.vassilev, junaire. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reemission is only needed in incremental mode. With this early

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

Hahnfeld added a comment. In D156537#4554413 , @v.g.vassilev wrote: > In D156537#4554052 , @Hahnfeld > wrote: > >> @v.g.vassilev do we have a means to detect this case? In D156897 >>

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

sdesmalen added inline comments. Comment at: clang/test/Sema/aarch64-sme-func-attrs.c:181 +void non_za_definition(void) { + sme_arm_new_za(); // OK rsandifo-arm wrote: > sdesmalen wrote: > > rsandifo-arm wrote: > > > sdesmalen wrote: > > > > rsandifo-arm wrote

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

sdesmalen updated this revision to Diff 548130. sdesmalen added a comment. - (Clang) Added test-cases for indirect calls. - (LLVM) Moved the pseudo definition out of the 'let Predicates = [HasSME] {}' block as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

sdesmalen updated this revision to Diff 548131. sdesmalen added a comment. Added test-cases for indirect calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157270/new/ https://reviews.llvm.org/D157270 Files: clang/include/clang/Basic/Diagnostic

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

mstorsjo added a comment. In D157332#4568341 , @efriedma wrote: > I see what you're getting at here... but I don't think this works quite > right. If the empty class has a non-trivial constructor, we have to pass the > correct "this" address to that co

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

xen0n accepted this revision. xen0n added a comment. This revision is now accepted and ready to land. This still LGTM, @steven_wu would you please take another look so this can get re-landed if confirmed working? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 548142. victorkingi added a comment. fixing failing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/Driver/Options.td clang/l

[PATCH] D156693: [clang][ASTImporter]Skip check friend template depth

balazske added a comment. This fix can cause problems because the depth comparison is omitted all times. It would be better to omit depth check if the imported template is a friend, and has a `ClassTemplateSpecializationDecl` as context. Probably even then it is possible to construct cases wher

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2193 // Skip other prefixes once a GCC installation is found. -if (Version > VersionZero) +// Solaris GCC installations live in separate Prefixes per Version +// (/usr/gcc/) that arrive in

[PATCH] D156787: [analyzer][attr] Add docs to ownership_* attributes

donat.nagy added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1189 +``onwership_returns``: Functions with this annotation return dynamic memory. +The second annotation parameter is the size of the returned memory in bytes. + Szelethus wrote:

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 548148. victorkingi added a comment. from CamelCase to camelCase variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/Driver/Opt

[clang] a2132d7 - [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the do while statement

Author: yrong Date: 2023-08-08T19:34:43+08:00 New Revision: a2132d72bed153a3347763dfaa7e699de7128647 URL: https://github.com/llvm/llvm-project/commit/a2132d72bed153a3347763dfaa7e699de7128647 DIFF: https://github.com/llvm/llvm-project/commit/a2132d72bed153a3347763dfaa7e699de7128647.diff LOG: [C

[PATCH] D157195: [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the do while statement

This revision was automatically updated to reflect the committed changes. yronglin marked 2 inline comments as done. Closed by commit rGa2132d72bed1: [Clang] Fix the do while statement disappearing in AST when an error occurs in… (authored by yronglin). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D157383: [clang][Diagnostics] Provide source range to integer-overflow warnings

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, tbaeder, cjdb. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. BEFORE: overflow.cpp:1:21: warning: overflow in expression; result is -2147483648 with type 'int' [

[PATCH] D157383: [clang][Diagnostics] Provide source range to integer-overflow warnings

hazohelet added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:530-535 if (S.checkingForUndefinedBehavior()) { SmallString<32> Trunc; APResult.trunc(Result.bitWidth()).toString(Trunc, 10); auto Loc = E->getExprLoc(); -S.report(Loc, diag::warn_int

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

aaron.ballman added a comment. In D142609#4568095 , @xgupta wrote: > In D142609#4566418 , @aaron.ballman > wrote: > >> Concerns have been raised in >> https://github.com/llvm/llvm-project/issues/64356 that this

[clang] 241cceb - [Clang][Tooling] Accept preprocessed input files

Author: J. Ryan Stinnett Date: 2023-08-08T12:44:48+01:00 New Revision: 241cceb9af844ef7d7a87124407a04b0a64991fe URL: https://github.com/llvm/llvm-project/commit/241cceb9af844ef7d7a87124407a04b0a64991fe DIFF: https://github.com/llvm/llvm-project/commit/241cceb9af844ef7d7a87124407a04b0a64991fe.di

[PATCH] D157011: [Clang][Tooling] Accept preprocessed input files

This revision was automatically updated to reflect the committed changes. Closed by commit rG241cceb9af84: [Clang][Tooling] Accept preprocessed input files (authored by jryans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157011/new/ https://revie

[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

aaron.ballman added a comment. I'm not qualified to give a review of the functional changes, but the intent for the changes SGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157324/new/ https://reviews.llvm.org/D157324 _

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

paulwalker-arm added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:6762 +Context.getFunctionFeatureMap(CallerFeatureMap, CallerFD); +if (!CallerFeatureMap.count("sme")) + Diag(Loc, diag::err_sme_call_in_non_sme_target); `co

[PATCH] D157384: [clang] Added Attr::getVariety function

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The commit extends ClangAttrEmitter of tablegen to generate Attr*::getVariety

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

aaron.ballman added reviewers: efriedma, rjmccall, rsmith. aaron.ballman added a comment. Adding codegen and ubsan code owners for opinions. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1791 + // Try to eliminate overflow check. + if (auto *VCI = dyn_cast(ArgValue)) { +if

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit. Comment at: clang/lib/Sema/SemaChecking.cpp:6773 + bool CallerHasZAState = false; + if (auto *CallerFD = dyn_cast(CurContext))

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder created this revision. tbaeder added reviewers: aaronpuchert, NoQ, clang. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This might be a little light on the testing side. Repository: rG LLVM

[PATCH] D157383: [clang][Diagnostics] Provide source range to integer-overflow warnings

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:530-535 if (S.checkingForUndefinedBehavior()) { SmallString<32> Trunc; APResult.trunc(Result.bitWidth()).toString(Trunc, 10); auto Loc = E->getExprLoc(); -S.report(Loc, diag::warn_integ

[PATCH] D157383: [clang][Diagnostics] Provide source range to integer-overflow warnings

hazohelet added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:530-535 if (S.checkingForUndefinedBehavior()) { SmallString<32> Trunc; APResult.trunc(Result.bitWidth()).toString(Trunc, 10); auto Loc = E->getExprLoc(); -S.report(Loc, diag::warn_int

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

sdesmalen updated this revision to Diff 548168. sdesmalen marked 10 inline comments as done. sdesmalen added a comment. Address further review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157269/new/ https://reviews.llvm.org/D157269 Fil

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

sdesmalen added inline comments. Comment at: clang/test/Sema/aarch64-sme-func-attrs-without-target-feature.cpp:13-17 +__attribute__((target("sme"))) void streaming_compatible_def_sme_attr() __arm_streaming_compatible {} // OK +__attribute__((target("sme"))) void streaming_def_s

[PATCH] D156693: [clang][ASTImporter]Skip check friend template depth

jcsxky updated this revision to Diff 548166. jcsxky edited the summary of this revision. jcsxky added a comment. update diff: add more conditions on when to ignore comparing depth of two template classes to minimize influence to others and fix name of test case to make easy understanding Repos

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 548175. victorkingi added a comment. changed enum to enum class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/Driver/Options.td c

[PATCH] D156693: [clang][ASTImporter]Skip check friend template depth

jcsxky added a comment. In D156693#4568941 , @balazske wrote: > This fix can cause problems because the depth comparison is omitted all > times. It would be better to omit depth check if the imported template is a > friend, and has a `ClassTemplateSpeci

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi added a comment. In D156320#4559248 , @kiranchandramohan wrote: >> rpass flag now prints remarks when requested but does not display >> the passName used, i.e [-Rpass=inline] > > I think the location information is also not printed. Please ch

[PATCH] D157390: [clang-tidy][include-cleaner] Add option to control deduplication of findings per symbol

kadircet created this revision. kadircet added a reviewer: VitaNuo. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a sub

[PATCH] D144831: Rebase D41416 on top of master

SAtacker updated this revision to Diff 548183. SAtacker added a comment. Herald added a subscriber: cfe-commits. [Clang][Modules] Optimized template arguments ODR hash search for modules/PCH Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144831/new/

[PATCH] D157390: [clang-tidy][include-cleaner] Add option to control deduplication of findings per symbol

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. Thanks. Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.h:48 + // Whether emit only one finding per usage of a symbol. + const bool EmitOnce; llvm::S

[PATCH] D157390: [clang-tidy][include-cleaner] Add option to control deduplication of findings per symbol

kadircet updated this revision to Diff 548190. kadircet marked 2 inline comments as done. kadircet added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157390/new/ https://reviews.llvm.org/D157390 Files: clang-tools-ex

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

ABataev added a comment. Please, use the script to generate the checks for the newly added tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152054/new/ https://reviews.llvm.org/D152054 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] 247cc26 - [CUDA][HIP] Fix overloading resolution of delete operator

Author: Yaxun (Sam) Liu Date: 2023-08-08T09:50:24-04:00 New Revision: 247cc265e74e25164ee7ce85e6c9c53b3d177740 URL: https://github.com/llvm/llvm-project/commit/247cc265e74e25164ee7ce85e6c9c53b3d177740 DIFF: https://github.com/llvm/llvm-project/commit/247cc265e74e25164ee7ce85e6c9c53b3d177740.dif

[PATCH] D156795: [CUDA][HIP] Fix overloading resolution of delete operator

This revision was automatically updated to reflect the committed changes. Closed by commit rG247cc265e74e: [CUDA][HIP] Fix overloading resolution of delete operator (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D156795?vs=546045&id=548198

[PATCH] D157197: [clang][CodeGen][OpenMP] Fix if-clause for 'target teams loop'

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1570-1575 + // If we are here with a 'target teams loop' then we are emitting the + // 'parallel' region of the 'target teams distribute parallel for' + // emitted in place of the 'target teams loop'

[PATCH] D157390: [clang-tidy][include-cleaner] Add option to control deduplication of findings per symbol

kadircet updated this revision to Diff 548199. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157390/new/ https://reviews.llvm.org/D157390 Files: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp clang

[PATCH] D157394: [clang][DeclPrinter] Improved AST print of function attributes

strimo378 created this revision. Herald added a project: All. strimo378 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, wangpc, jplehr, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet updated this revision to Diff 548197. hazohelet added a comment. - Tentatively disable the warning on macros so as not to make a fuss in libc++ tests. - Fixed incorrect output in arguments. - Fixed incorrect output in declaration of init-statement of constexpr-if condition. - Added tes

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

VitaNuo created this revision. Herald added a subscriber: kadircet. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157395 Fi

[clang-tools-extra] 89d0a76 - [clang-tidy][include-cleaner] Add option to control deduplication of findings per symbol

Author: Kadir Cetinkaya Date: 2023-08-08T16:01:33+02:00 New Revision: 89d0a76be68b866779ac41e56bc7f7b4fc452f47 URL: https://github.com/llvm/llvm-project/commit/89d0a76be68b866779ac41e56bc7f7b4fc452f47 DIFF: https://github.com/llvm/llvm-project/commit/89d0a76be68b866779ac41e56bc7f7b4fc452f47.dif

[PATCH] D157390: [clang-tidy][include-cleaner] Add option to control deduplication of findings per symbol

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG89d0a76be68b: [clang-tidy][include-cleaner] Add option to control deduplication of findings… (authored by kadircet). Repository: rG LLVM Github Mo

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

VitaNuo updated this revision to Diff 548204. VitaNuo added a comment. Remove accidental comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157395/new/ https://reviews.llvm.org/D157395 Files: clang-tools-extra/include-cleaner/lib/Record.cpp

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

balazske added a comment. I have checked the results on some projects (memcached,tmux,curl,twin,vim,openssl,sqlite,ffmpeg,postgres,xerces,bitcoin). These results are more interesting, some look correct, some probably not: https://codechecker-demo.eastus.cloudapp.azure.com/Default/report-detail?r

[PATCH] D157390: [clang-tidy][include-cleaner] Add option to control deduplication of findings per symbol

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:195 +- Misc-include-cleaner check has option `DeduplicateFindings` to output one + finding per occurence of a symbol. invalid release note should be something like: ``` Improve

[clang-tools-extra] 724b40a - [clang-tidy][Docs] Update docs per post-commit review

Author: Kadir Cetinkaya Date: 2023-08-08T16:16:51+02:00 New Revision: 724b40a1379f7c116473a02a3cec4d341c475b46 URL: https://github.com/llvm/llvm-project/commit/724b40a1379f7c116473a02a3cec4d341c475b46 DIFF: https://github.com/llvm/llvm-project/commit/724b40a1379f7c116473a02a3cec4d341c475b46.dif

[PATCH] D157390: [clang-tidy][include-cleaner] Add option to control deduplication of findings per symbol

kadircet marked 2 inline comments as done. kadircet added a comment. hi @PiotrZSL, addressed those in 724b40a1379f7c116473a02a3cec4d341c475b46 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

aaron.ballman added a subscriber: efriedma. aaron.ballman added a comment. Round two of comments; I picked up from where I left off earlier and haven't checked your changes or responses yet. Precommit CI seems to have found a relevant failure from the patch. Comment at: clang

[clang] 8e7f032 - [Clang][OpenMP] Support for Code Generation of loop bind clause.

Author: Sunil Kuravinakop Date: 2023-08-08T09:23:00-05:00 New Revision: 8e7f0320ad7fb760fff598aba4b2c86528c58c2d URL: https://github.com/llvm/llvm-project/commit/8e7f0320ad7fb760fff598aba4b2c86528c58c2d DIFF: https://github.com/llvm/llvm-project/commit/8e7f0320ad7fb760fff598aba4b2c86528c58c2d.d

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin marked an inline comment as done. cor3ntin added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:4283 + if (HasExplicitObjectParameter) { +const VarDecl *D = cast(CurCodeDecl)->getParamDecl(0); +auto It = LocalDeclMap.find(D); aaron.ba

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin marked an inline comment as done. cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11308 + + // There should be a CWG issue for that + if (Name.getNameKind() == DeclarationName::CXXConstructorName || aaron.ballman wrote: > Do

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7280 + "a %select{function|lambda}0 with an explicit object parameter cannot " + "%select{be const|be mutable|have reference qualifiers|be volatile}1">; +def err_invalid_explicit_o

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

VitaNuo updated this revision to Diff 548217. VitaNuo added a comment. Remove the preferred header hint for exporters. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157395/new/ https://reviews.llvm.org/D157395 Files: clang-tools-extra/include-cl

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:322 + auto EndLoc = Args.empty() ? Loc : Args.back()->getEndLoc(); + return S.BuildCallExpr(nullptr, Result.get(), Loc, Args, EndLoc, nullptr); } hokein wrote: > aaron.ballman wr

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

yronglin marked 4 inline comments as done. yronglin added inline comments. Comment at: clang/include/clang/AST/Stmt.h:596-597 -// These don't need to be particularly wide, because they're -// strictly limited by the forms of expressions we permit. -unsigned NumSubEx

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

ChuanqiXu added a comment. BTW, I have a question about supporting header modules (including clang header modules and C++20 header units) in static analysing tools (including clangd), "why can't we fallback to include the corresponding headers simply?". So I still feel it is not a problem to su

[PATCH] D156787: [analyzer][attr] Add docs to ownership_* attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1189 +``onwership_returns``: Functions with this annotation return dynamic memory. +The second annotation parameter is the size of the returned memory in bytes. + donat.nagy wr

[PATCH] D157400: [include-cleaner] Dont boost private headers beyond public ones

kadircet created this revision. kadircet added a reviewer: VitaNuo. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Private headers should be the last resort, even if they match the name of

[clang] 58eba70 - [OpenMP] supporting additional case of declare target initializer expression list

Author: Ritanya B Bharadwaj Date: 2023-08-08T10:14:59-05:00 New Revision: 58eba709a330e4c83de0a98b50fc0acf26cb4344 URL: https://github.com/llvm/llvm-project/commit/58eba709a330e4c83de0a98b50fc0acf26cb4344 DIFF: https://github.com/llvm/llvm-project/commit/58eba709a330e4c83de0a98b50fc0acf26cb4344

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

jroelofs added a comment. Flaky test? Here's a later build where it succeeds, but the change has nothing to do with clangd: https://lab.llvm.org/buildbot/#/builders/168/builds/14997 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/ https:/

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

tahonermann added a comment. > @tahonermann are all your comments addressed at this point? Apologies for the late response; I was on vacation last week. No. I'm still skeptical that there is ever a desire to expand substitute drives. Comment at: clang/test/Lexer/case-insensit

[PATCH] D157379: [CodeGen] Restrict addEmittedDeferredDecl to incremental extensions

v.g.vassilev added a comment. This LGTM but I'd like to wait for @rjmccall for a week or so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157379/new/ https://reviews.llvm.org/D157379 ___ cfe-commits mai

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156604/new/ https://reviews.llvm.org/D156604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157400: [include-cleaner] Dont boost private headers beyond public ones

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. Thanks. Comment at: clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp:474 + Inputs.ExtraFiles["bar.h"] = + guard(R"cpp(#include "foo.h" // IWYU pragma:

[clang] 74c141a - [clang][ExprConst] Add RHS source range to div by zero diags

Author: Timm Bäder Date: 2023-08-08T17:59:13+02:00 New Revision: 74c141a467caf9ebb4835458bc4ffbedb172a63a URL: https://github.com/llvm/llvm-project/commit/74c141a467caf9ebb4835458bc4ffbedb172a63a DIFF: https://github.com/llvm/llvm-project/commit/74c141a467caf9ebb4835458bc4ffbedb172a63a.diff LO

[PATCH] D157074: [clang][ExprConst] Add RHS source range to div by zero diags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG74c141a467ca: [clang][ExprConst] Add RHS source range to div by zero diags (authored by tbaeder). Changed prior to commit: https://reviews.llvm.or

[PATCH] D157384: [clang] Added Attr::getVariety function

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Attr.h:87-99 + enum class Variety { +None, +GNU, // __attribute__((...)) +Declspec, // __declspec(...) +Microsoft,// [...] +CXX11,// [[...]] +C2x, /

[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

philnik accepted this revision. philnik added a comment. This revision is now accepted and ready to land. Thanks for working on this! I think it would make a lot of sense to unify this build and the Debian build, since currently we are building Clang twice without a good reason. Repository:

[PATCH] D157118: [NFC][Clang] Fix static analyzer concerns

tahonermann accepted this revision. tahonermann added a comment. I think this change is good as is, but I added some additional thoughts to Aaron's earlier comment. Comment at: clang/lib/AST/StmtPrinter.cpp:178 void StmtPrinter::PrintRawCompoundStmt(CompoundStmt *Node) { + a

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM but please give a day or two for @hazohelet to weigh in. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156604/new/ https://reviews.llvm.org/D156604 ___

[PATCH] D157129: [NFC] Fix unnecessary copy with auto.

tahonermann requested changes to this revision. tahonermann added a comment. I agree with the analysis done by @steakhal. The static analyzer being used (which I'm not allowed to name) is being too noisy in these cases; it complains about every case where an object of class type is copied regard

  1   2   3   >