[PATCH] D157197: [clang][CodeGen][OpenMP] Fix if-clause for 'target teams loop'

ddpagan updated this revision to Diff 547982. ddpagan added a comment. As requested, added reference to OpenMP 5.2 specification that discusses handling of if clauses with combined/composite directives. Also, improved comment relating to what was being done and why. CHANGES SINCE LAST ACTION

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 547986. ZijunZhao marked an inline comment as done. ZijunZhao added a comment. 1. Fix some format nits 2. Change `CHECK-NEXT` to `CHECK` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://revie

[PATCH] D157331: [clang] Implement C23

enh added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) is this ever _not_ set for clang? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157331: [clang] Implement C23

ZijunZhao added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) enh wrote: > is this ever _not_ set for clang? https://github.com/llvm/llvm-project/blob/main/cl

[PATCH] D157331: [clang] Implement C23

enh added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) ZijunZhao wrote: > enh wrote: > > is this ever _not_ set for clang? > https://github.com/llvm/llvm-pro

[PATCH] D157331: [clang] Implement C23

enh added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) enh wrote: > ZijunZhao wrote: > > enh wrote: > > > is this ever _not_ set for clang? > > https://githu

[PATCH] D157331: [clang] Implement C23

enh added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) enh wrote: > enh wrote: > > ZijunZhao wrote: > > > enh wrote: > > > > is this ever _not_ set for clang

[clang] 291eb25 - [clang][DeclPrinter] Fix AST print to suppress output of implicit (non-written) constructor initializers

Author: Timo Stripf Date: 2023-08-07T23:13:50Z New Revision: 291eb2589fdc78827af6c2c858bc5e9456e3dc20 URL: https://github.com/llvm/llvm-project/commit/291eb2589fdc78827af6c2c858bc5e9456e3dc20 DIFF: https://github.com/llvm/llvm-project/commit/291eb2589fdc78827af6c2c858bc5e9456e3dc20.diff LOG: [

[PATCH] D156523: [clang][DeclPrinter] Fix AST print to suppress output of implicit (non-written) constructor initializers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG291eb2589fdc: [clang][DeclPrinter] Fix AST print to suppress output of implicit (non-written)… (authored by strimo378). Changed prior to commit: h

[clang] f620472 - [OpenMP][Docs] Update OpenMP supported features table

Author: Dave Pagan Date: 2023-08-07T19:16:13-04:00 New Revision: f6204724df56188e82c6363aa13e1806cf6c5176 URL: https://github.com/llvm/llvm-project/commit/f6204724df56188e82c6363aa13e1806cf6c5176 DIFF: https://github.com/llvm/llvm-project/commit/f6204724df56188e82c6363aa13e1806cf6c5176.diff LO

[PATCH] D157135: [OpenMP][Docs] Update OpenMP supported features table

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6204724df56: [OpenMP][Docs] Update OpenMP supported features table (authored by ddpagan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157135/new/ https:/

[PATCH] D157331: [clang] Implement C23

xbolva00 added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) enh wrote: > enh wrote: > > enh wrote: > > > ZijunZhao wrote: > > > > enh wrote: > > > > > is thi

[PATCH] D157331: [clang] Implement C23

yabinc added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) enh wrote: > enh wrote: > > enh wrote: > > > ZijunZhao wrote: > > > > enh wrote: > > > > > is this

[PATCH] D157326: [clang-tidy] Fix handling of out-of-line functions in readability-static-accessed-through-instance

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp:23 static unsigned getNameSpecifierNestingLevel(const QualType &QType) { if (const ElaboratedType *ElType = QType->getAs()) { if (const Nest

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

rsandifo-arm added inline comments. Comment at: clang/test/Sema/aarch64-sme-func-attrs.c:181 +void non_za_definition(void) { + sme_arm_new_za(); // OK sdesmalen wrote: > rsandifo-arm wrote: > > sdesmalen wrote: > > > rsandifo-arm wrote: > > > > Would be good t

[clang] e7a8a7d - [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

Author: Weining Lu Date: 2023-08-08T09:07:11+08:00 New Revision: e7a8a7d4977627ebc43e9ed43462aebad4a66e8d URL: https://github.com/llvm/llvm-project/commit/e7a8a7d4977627ebc43e9ed43462aebad4a66e8d DIFF: https://github.com/llvm/llvm-project/commit/e7a8a7d4977627ebc43e9ed43462aebad4a66e8d.diff LO

[PATCH] D156116: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC behaviour

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7a8a7d49776: [Clang][LoongArch] Fix ABI handling of empty structs in C++ to match GCC… (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] 5bc4b34 - [clang][hexagon] Handle library path arguments earlier

Author: Brian Cain Date: 2023-08-07T18:18:59-07:00 New Revision: 5bc4b34a3aa9c6ea10663a252ac46d20862b38d5 URL: https://github.com/llvm/llvm-project/commit/5bc4b34a3aa9c6ea10663a252ac46d20862b38d5 DIFF: https://github.com/llvm/llvm-project/commit/5bc4b34a3aa9c6ea10663a252ac46d20862b38d5.diff LO

[PATCH] D156771: [clang][hexagon] Handle library path arguments earlier

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5bc4b34a3aa9: [clang][hexagon] Handle library path arguments earlier (authored by androm3da). Repository: rG LLVM Githu

[PATCH] D157350: [clang][ExtractAPI] Add support for C++ variable templates

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Serialize global C++ variable templates and specializatio

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

ChuanqiXu added a comment. Got it. Being patience is not bad and it is good enough to know that we are moving forward : ) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153114/new/ https://reviews.llvm.org/D153114 ___ cfe-commits mailing list

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 548022. AlexVlx added a comment. Extend handling of unsupported builtins to include dealing with the `target` attribute. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155850/new/ https://reviews.llvm.org/D155850 Files: clang/lib/CodeGen/BackendU

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

fakepaper56 updated this revision to Diff 548027. fakepaper56 added a comment. Bump to 0.2 and address part of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 Files: clang/test/Preprocessor/ri

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

danix800 added a comment. 1. Use invalid loc: `SourceLocation()` ExprWithCleanups 0x55d1067162c8 'void' `-CoyieldExpr 0x55d106716280 'void' |-CXXMemberCallExpr 0x55d106715ed8 'std::suspend_always':'std::suspend_always' | |-MemberExpr 0x55d106715ea8 '' .yield_value 0x55d10670b220

[clang] db92fb8 - [clang][ASTImporter] Add import of 'DependentSizedExtVectorType'

Author: dingfei Date: 2023-08-08T10:22:00+08:00 New Revision: db92fb8726fc09e6d76346a02169685025fd59ca URL: https://github.com/llvm/llvm-project/commit/db92fb8726fc09e6d76346a02169685025fd59ca DIFF: https://github.com/llvm/llvm-project/commit/db92fb8726fc09e6d76346a02169685025fd59ca.diff LOG:

[clang] df21f9f - [clang][ASTImporter] Add import of 'ConvertVectorExpr'

Author: dingfei Date: 2023-08-08T10:23:56+08:00 New Revision: df21f9fc037329ae05ff4640d9172364bb9ef6ed URL: https://github.com/llvm/llvm-project/commit/df21f9fc037329ae05ff4640d9172364bb9ef6ed DIFF: https://github.com/llvm/llvm-project/commit/df21f9fc037329ae05ff4640d9172364bb9ef6ed.diff LOG:

[PATCH] D157249: [clang][ASTImporter] Add import of 'ConvertVectorExpr'

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf21f9fc0373: [clang][ASTImporter] Add import of 'ConvertVectorExpr' (authored by dingfei ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D157238: [clang][ASTImporter] Add import of 'DependentSizedExtVectorType'

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb92fb8726fc: [clang][ASTImporter] Add import of 'DependentSizedExtVectorType' (authored by dingfei ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D157352: Revert "[Clang] Fix -Wconstant-logical-operand when LHS is a constant"

xgupta created this revision. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit dfdfd306cfaf54fbc43e2d5eb36489dac3eb9976

[clang] a845252 - Revert "[Clang] Fix -Wconstant-logical-operand when LHS is a constant"

Author: Shivam Gupta Date: 2023-08-08T08:00:02+05:30 New Revision: a84525233776a716e2c6291993f0b33fd1c76f7c URL: https://github.com/llvm/llvm-project/commit/a84525233776a716e2c6291993f0b33fd1c76f7c DIFF: https://github.com/llvm/llvm-project/commit/a84525233776a716e2c6291993f0b33fd1c76f7c.diff

[PATCH] D157352: Revert "[Clang] Fix -Wconstant-logical-operand when LHS is a constant"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa84525233776: Revert "[Clang] Fix -Wconstant-logical-operand when

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2193 // Skip other prefixes once a GCC installation is found. -if (Version > VersionZero) +// Solaris GCC installations live in separate Prefixes per Version +// (/usr/gcc/) that arriv

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta added a comment. In D142609#4566418 , @aaron.ballman wrote: > Concerns have been raised in > https://github.com/llvm/llvm-project/issues/64356 that this is an undesirable > change in diagnostic behavior. The diagnostic is supposed to fire when

[PATCH] D157353: [RISCV] Remove pre-defined macro test for b extension. NFC.

Jim created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, si

[PATCH] D157353: [RISCV] Remove pre-defined macro test for b extension. NFC.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157353/new/ https://reviews.llvm.org/D157353 ___

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 updated this revision to Diff 548042. evelez7 added a comment. Add brackets for SerializerBase visit methods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157076/new/ https://reviews.llvm.org/D157076 Files: clang/include/clang/ExtractAPI

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

vitalybuka added a comment. In D157119#4565993 , @jroelofs wrote: > In D157119#4564546 , @vitalybuka > wrote: > >> I suspect one of your recent changes broke >> https://lab.llvm.org/buildbot/#/builders/168/build

[clang] 767ca3a - [RISCV] Remove pre-defined macro test for b extension. NFC.

Author: Jim Lin Date: 2023-08-08T13:01:34+08:00 New Revision: 767ca3a70d6d60bd52ff0829335942aa6dafcc28 URL: https://github.com/llvm/llvm-project/commit/767ca3a70d6d60bd52ff0829335942aa6dafcc28 DIFF: https://github.com/llvm/llvm-project/commit/767ca3a70d6d60bd52ff0829335942aa6dafcc28.diff LOG:

[PATCH] D157353: [RISCV] Remove pre-defined macro test for b extension. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG767ca3a70d6d: [RISCV] Remove pre-defined macro test for b extension. NFC. (authored by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

vitalybuka added a comment. > How to reproduce locally: > https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild Does not reproduce on my workstation too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/ https://reviews

[PATCH] D157362: [RISCV] Add Zicfilp extension.

fakepaper56 created this revision. fakepaper56 added reviewers: craig.topper, reames, frasercrmck, rogfer01, asb. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, jdoerfert, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMos

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

efriedma added a comment. I see what you're getting at here... but I don't think this works quite right. If the empty class has a non-trivial constructor, we have to pass the correct "this" address to that constructor. Usually a constructor for an empty class won't do anything with that addre

[PATCH] D157326: [clang-tidy] Fix handling of out-of-line functions in readability-static-accessed-through-instance

PiotrZSL updated this revision to Diff 548066. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Fix 'auto' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157326/new/ https://reviews.llvm.org/D157326 Files: clang-tools-extra/c

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

cor3ntin added inline comments. Comment at: clang/test/CodeGenCXX/ctor-empty-nounique.cpp:1 +// RUN: %clang_cc1 -triple x86_64-windows-gnu -emit-llvm -o - %s | FileCheck %s + This should probably get another run line for powerpc64le Repository: rG LLVM Github

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7280 + "a %select{function|lambda}0 with an explicit object parameter cannot " + "%select{be const|be mutable|have reference qualifiers|be volatile}1">; +def err_invalid_explicit_object

[clang] 24c91d4 - [clang][ExprConstant] Fix crash on uninitialized base class subobject

Author: Takuya Shimizu Date: 2023-08-08T15:53:17+09:00 New Revision: 24c91d443222bdb20205630d300ae61bfa07067e URL: https://github.com/llvm/llvm-project/commit/24c91d443222bdb20205630d300ae61bfa07067e DIFF: https://github.com/llvm/llvm-project/commit/24c91d443222bdb20205630d300ae61bfa07067e.diff

[PATCH] D153969: [clang][ExprConstant] Fix crash on uninitialized base class subobject

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG24c91d443222: [clang][ExprConstant] Fix crash on uninitialized base class subobject (authored by hazohelet). Changed prior to commit: https://revi

<    1   2   3