[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 547804. massberg edited the summary of this revision. massberg added a comment. Rename `ConceptLoc` back to `ConceptReference`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155858/new/ https://reviews.llvm.or

[PATCH] D155858: Add a concept AST node.

massberg marked an inline comment as done. massberg added inline comments. Comment at: clang/include/clang/AST/ASTConcept.h:118 /// template arguments. -class ConceptReference { +class ConceptLoc { protected: cor3ntin wrote: > hokein wrote: > > I'm not sure the

[PATCH] D157135: [OpenMP][Docs] Update OpenMP supported features table

RaviNarayanaswamy added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157135/new/ https://reviews.llvm.org/D157135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

/test_scanf.c#n661 > > Seems like the test should be fixed, though I wonder why this same error > isn't effecting GCC builds. Thanks for the report! I sent a patch for this already, just waiting for it to be picked up: https://lore.kernel.org/20230807-test_scanf-wconstant-conver

[PATCH] D156910: [clang] Add pragma force_vectorize

kitaisreal updated this revision to Diff 547810. kitaisreal added a comment. Fixed build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156910/new/ https://reviews.llvm.org/D156910 Files: clang/include/clang/Basic/Attr.td clang/include/clang/B

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156014/new/ https://reviews.llvm.org/D156014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 547813. victorkingi added a comment. Herald added a subscriber: wangpc. added extraction of absolute file path in TextDiagnosticPrinter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://revi

[PATCH] D130209: [clang-tidy][NFC] Update tests to specify CheckOptions using new syntax

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Herald added subscribers: jplehr, carlosgalvezp. LGTM, minor conflicts only... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130209/new/ htt

[clang] fab4972 - Revert "[Clang][OpenMP] Support for Code Generation of loop bind clause"

Author: Nico Weber Date: 2023-08-07T12:01:54-04:00 New Revision: fab49721b4ef0b5079194bc09528df78f38c32a8 URL: https://github.com/llvm/llvm-project/commit/fab49721b4ef0b5079194bc09528df78f38c32a8 DIFF: https://github.com/llvm/llvm-project/commit/fab49721b4ef0b5079194bc09528df78f38c32a8.diff LO

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 547816. victorkingi added a comment. removed unnecessary code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/Driver/Options.td cla

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 547817. victorkingi added a comment. code cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/Driver/Options.td clang/lib/Basic

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

rsandifo-arm added inline comments. Comment at: clang/test/Sema/aarch64-sme-func-attrs.c:181 +void non_za_definition(void) { + sme_arm_new_za(); // OK sdesmalen wrote: > rsandifo-arm wrote: > > Would be good to have some tests for indirect function calls too (

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

aaron.ballman added a subscriber: rjmccall. aaron.ballman added a comment. I started my review for this, but haven't completed it yet. I figured some early feedback would be better than waiting for me to complete the whole review. Comment at: clang/include/clang/AST/Decl.h:101

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed. Hi @ChuanqiXu, Sam is on vacation now, but we are in the same team and I am responding on behalf of the team. First, sorry for not getting to this review earlier. The

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

yaxunl added a comment. need a lit test for the codegen of the clang builtin for cov 4/5/none and a lit test to show the branching code generated with cov none can be optimized away when linked with cov4 or cov5. Comment at: clang/lib/CodeGen/Targets/AMDGPU.cpp:383 +

[PATCH] D157246: [clang-tidy] Update tests to include C++23 and C++26

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc/const-correctness-values-before-cxx23.cpp:2-6 +// RUN: -config="{CheckOptions: [\ +// RUN: {key: 'misc-const-correctness.TransformValues', value: true}, \ +// RUN: {key: 'misc-const

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

yaxunl added a comment. I would suggest separating the clang/llvm part into a separate review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139730/new/ https://reviews.llvm.org/D139730 ___ cfe-commits m

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

DmitryPolukhin updated this revision to Diff 547825. DmitryPolukhin added a comment. Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157283/new/ https://reviews.llvm.org/D157283 Files: clang/lib/Driver/ToolChains/Darwin.cpp clang

[clang] f48969f - Revert "[Flang][Sema] Move directive sets to a shared location"

Author: Kiran Chandramohan Date: 2023-08-07T16:43:42Z New Revision: f48969f90769f37e042025dba6c544eeddd6d3e6 URL: https://github.com/llvm/llvm-project/commit/f48969f90769f37e042025dba6c544eeddd6d3e6 DIFF: https://github.com/llvm/llvm-project/commit/f48969f90769f37e042025dba6c544eeddd6d3e6.diff

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

rsandifo-arm added a comment. LGTM in terms of intent. Comment at: clang/lib/Sema/SemaDecl.cpp:12092 + diag::err_sme_definition_using_sm_in_non_sme_target); +if (UsesZA) + Diag(NewFD->getLocation(), Suggest making this an `else if

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

danix800 created this revision. danix800 added a reviewer: aaron.ballman. danix800 added a project: clang. Herald added a subscriber: ChuanqiXu. Herald added a project: All. danix800 requested review of this revision. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-proje

[PATCH] D157297: [clang] Fixes compile error like error: expected unqualified-id for ::_tzcnt_u32(mask);

lygstate created this revision. Herald added a project: All. lygstate requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Error message: In file included from ../src/amd/addrlib/src/core/addrobject.h:21: ../src/amd/addrlib/src/core/addrcommon.h

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:321 - return S.BuildCallExpr(nullptr, Result.get(), Loc, Args, Loc, nullptr); + auto EndLoc = Args.empty() ? Loc : Args.back()->getBeginLoc(); + return S.BuildCallExpr(nullptr, Result.get(), Loc, Arg

[PATCH] D156771: [clang][hexagon] Handle library path arguments earlier

sidneym added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156771/new/ https://reviews.llvm.org/D156771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

danix800 added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:321 - return S.BuildCallExpr(nullptr, Result.get(), Loc, Args, Loc, nullptr); + auto EndLoc = Args.empty() ? Loc : Args.back()->getBeginLoc(); + return S.BuildCallExpr(nullptr, Result.get(), Loc, Ar

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

aaron.ballman added subscribers: porglezomp, cjdb. aaron.ballman added a comment. Concerns have been raised in https://github.com/llvm/llvm-project/issues/64356 that this is an undesirable change in diagnostic behavior. The diagnostic is supposed to fire when misusing a logical operand that most

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

danix800 updated this revision to Diff 547843. danix800 added a comment. Use `getEndLoc()` instead of `getBeginLoc()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157296/new/ https://reviews.llvm.org/D157296 Files: clang/lib/Sema/SemaCoroutine

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

aaron.ballman added inline comments. Comment at: clang/test/Sema/aarch64-sme-func-attrs-without-target-feature.cpp:20 + +// No code is generated for declarations, so it should be fine to declare using the attribute. +void streaming_compatible_decl() __arm_streaming_compatible; /

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

tra added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:1995 } - if (S.Context.getTargetInfo().getTriple().isNVPTX()) { -S.Diag(AL.getLoc(), diag::err_alias_not_supported_on_nvptx); jhuber6 wrote: > jhuber6 wrote: > > tra wrote: > > > tra w

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers updated this revision to Diff 547846. nickdesaulniers added a comment. This revision is now accepted and ready to land. - fix remaining test failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74094/new/ https://reviews.llvm.org/

[PATCH] D157115: Revert "[clang][X86] Add __cpuidex function to cpuid.h"

aaron.ballman added a subscriber: eandrews. aaron.ballman added a comment. Thank you for the revert -- I've confirmed it fixed the issues for our downstream. Also, @eandrews said she may try to tackle the underlying issue with builtins in the relatively near future. Repository: rG LLVM Githu

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers updated this revision to Diff 547853. nickdesaulniers added a comment. - remove instance of auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74094/new/ https://reviews.llvm.org/D74094 Files: clang/lib/CodeGen/CGCall.cpp clang

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers added a comment. Hi @lei can you please help us retest this version of this patch that previously broke your multistage build? https://reviews.llvm.org/rGfafc6e4fdf3673dcf557d6c8ae0c0a4bb3184402#890444 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers updated this revision to Diff 547861. nickdesaulniers added a comment. - remove another auto, sink ArgSlotAlloca to reduce scope Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74094/new/ https://reviews.llvm.org/D74094 Files: clan

[PATCH] D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

lukasza updated this revision to Diff 547862. lukasza added a comment. More granular usage of `#if defined(CLANG_ABI_COMPAT) && ...` in tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155895/new/ https://reviews.llvm.org/D155895 Files: clang/include/clang/Basic/LangOptions.h cl

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

rsandifo-arm added inline comments. Comment at: clang/test/Sema/aarch64-sme-func-attrs-without-target-feature.cpp:20 + +// No code is generated for declarations, so it should be fine to declare using the attribute. +void streaming_compatible_decl() __arm_streaming_compatible; //

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

aaron.ballman added a comment. In D152495#4563520 , @hazohelet wrote: > I reverted this change because it broke sanitizer buildbots. > https://lab.llvm.org/buildbot/#/builders/19/builds/18369 > The cause of the errors here are relatively clear and I can s

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

aaron.ballman added a comment. Clang bits generally LGTM aside from a minor request; I'll leave the final sign-off to an LLVM person so those changes can also be reviewed. Comment at: clang/lib/Sema/SemaDecl.cpp:12092 + diag::err_sme_definition_using_sm_in_non_sm

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

jhuber6 updated this revision to Diff 547871. jhuber6 added a comment. Update to check the SDK version. Permit this if there is not passed in SDK version so that freestanding targets can still target CUDA and assume it's supported. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

MitalAshok updated this revision to Diff 547874. MitalAshok marked an inline comment as done. MitalAshok added a comment. Fix scanf("%p", (char**)ptr) for -Wformat-pedantic Also added more tests for %p and -Wformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang] bddaa35 - Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

Author: Dmitri Gribenko Date: 2023-08-07T20:30:48+02:00 New Revision: bddaa35177861545fc329123e55b6a3b34549507 URL: https://github.com/llvm/llvm-project/commit/bddaa35177861545fc329123e55b6a3b34549507 DIFF: https://github.com/llvm/llvm-project/commit/bddaa35177861545fc329123e55b6a3b34549507.dif

[PATCH] D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbddaa3517786: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`. (authored by gribozavr). Changed prior to commit: https://revie

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

MitalAshok added inline comments. Comment at: clang/test/Sema/format-pointer.c:39 + printf("%p", np); + scanf("%p", &np); // expected-warning {{format specifies type 'void **' but the argument has type 'nullptr_t *'}} + scanf("%p", &npp); // pedantic-warning {{format specif

[PATCH] D154559: [clang] Fix constant evaluation about static member function

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. Clang was correct here until fairly recently; P2280 (https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2280r4.html) changed the language rul

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157296/new/ https://reviews.llvm.org/D157296

[PATCH] D157157: [clang] Add clang support for Machine Function Splitting on AArch64

dhoekwater updated this revision to Diff 547884. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157157/new/ https://reviews.llvm.org/D157157 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/fsplit-machine-functions.c Index: clang/

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

hokein added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:322 + auto EndLoc = Args.empty() ? Loc : Args.back()->getEndLoc(); + return S.BuildCallExpr(nullptr, Result.get(), Loc, Args, EndLoc, nullptr); } Thanks for the fast fix. Reading the s

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:322 + auto EndLoc = Args.empty() ? Loc : Args.back()->getEndLoc(); + return S.BuildCallExpr(nullptr, Result.get(), Loc, Args, EndLoc, nullptr); } hokein wrote: > Thanks for the f

[PATCH] D141918: WIP: [Clang] Emit 'unwindabort' when applicable.

smeenai added a comment. Thanks for the rebase! We're eager to try this for Meta's Android apps, where size is a priority and better `noexcept` codegen would be really helpful. I ran into a crash with coroutines though, which blocks me from fully evaluating the size difference made by these ch

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

craig.topper added a comment. This looks good to me, but I'm not sure I'm a fully qualified reviewer here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D157227: [Clang] Don't add `undef` for `operator new` under -fno-exceptions.

ldionne added a comment. In D157227#4564817 , @nikic wrote: > Removing noundef makes no sense to me, because the return value is noundef > even under fno-exceptions. If we remove something, it should be the nonnull > attribute, because that's what's act

[PATCH] D156556: [AggressiveInstCombine][NFC] Fix typo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5dde755188e3: [AggressiveInstCombine][NFC] Fix typo (authored by kitaisreal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D157164: [clang-tidy] Add fix-it support to `llvmlibc-inline-function-decl`

PiotrZSL added a comment. Release notes are missing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157164/new/ https://reviews.llvm.org/D157164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin added inline comments. Comment at: clang/include/clang/AST/Expr.h:1279 + explicit DeclRefExpr(EmptyShell Empty) : Expr(DeclRefExprClass, Empty) { +DeclRefExprBits.CapturedByCopyInLambdaWithExplicitObjectParameter = false; + } aaron.ballman wrote: >

[PATCH] D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/82239/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155895/new/ https://reviews.ll

[PATCH] D154300: [CUDA][HIP] Fix template argument deduction

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12758-12764 +std::optional MorePreferableByCUDA = +CheckCUDAPreference(FD, Result); +// If FD has different CUDA preference than Result.

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

eaeltsin added a comment. Hi, Is it a known issue, that clang doesn't compile `void foo(char *argv[] [[maybe_unused]]) {}` ? https://godbolt.org/z/r9E81cWxh - clang fails, but gcc doesn't. It looks like there is a lot of oss code of the form `void foo(char *argv[] ATTRIBUTE_UNUSED)`, where `A

[clang] 0ba9aec - [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

Author: Joseph Huber Date: 2023-08-07T14:08:04-05:00 New Revision: 0ba9aec38faa8f567741fdb4eac1149c3fe94ceb URL: https://github.com/llvm/llvm-project/commit/0ba9aec38faa8f567741fdb4eac1149c3fe94ceb DIFF: https://github.com/llvm/llvm-project/commit/0ba9aec38faa8f567741fdb4eac1149c3fe94ceb.diff

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ba9aec38faa: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D154300: [CUDA][HIP] Fix template argument deduction

yaxunl updated this revision to Diff 547901. yaxunl marked an inline comment as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154300/new/ https://reviews.llvm.org/D154300 Files: clang/lib/Sema/SemaOverload.cpp clang/test/SemaCUDA/te

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

aaron.ballman added a comment. In D151683#4566907 , @eaeltsin wrote: > Hi, > > Is it a known issue, that clang doesn't compile `void foo(char *argv[] > [[maybe_unused]]) {}` ? The error is `error: 'maybe_unused' attribute cannot > be applied to types`.

[clang-tools-extra] 9d4162f - [clang-tidy] Add fix-it support to `llvmlibc-inline-function-decl`

Author: Roland McGrath Date: 2023-08-07T12:15:59-07:00 New Revision: 9d4162ff28b479c93d55df67bf38507bdc50a2d1 URL: https://github.com/llvm/llvm-project/commit/9d4162ff28b479c93d55df67bf38507bdc50a2d1 DIFF: https://github.com/llvm/llvm-project/commit/9d4162ff28b479c93d55df67bf38507bdc50a2d1.diff

[PATCH] D157164: [clang-tidy] Add fix-it support to `llvmlibc-inline-function-decl`

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d4162ff28b4: [clang-tidy] Add fix-it support to `llvmlibc-inline-function-decl` (authored by mcgrathr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157164

[PATCH] D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

lukasza added a comment. In D155895#4566903 , @thakis wrote: > Looks like this breaks tests on windows: > http://45.33.8.238/win/82239/step_7.txt Thanks for the report! It seems that `#if defined(_WIN64) && !defined(__MINGW32__)` from `clang/test/Sema

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 547905. koops added a comment. In clang/test/OpenMP/loop_bind_enclosed.cpp Generalizing the CHECK pattern for aarch64-linux, s390x-linux and ppc64le-linux. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634 F

[clang-tools-extra] 1af159e - [clang-tidy][NFC] Update tests to CheckOptions using new syntax

Author: Piotr Zegar Date: 2023-08-07T19:32:27Z New Revision: 1af159e98c23a293c103e1f548866488126ed6f6 URL: https://github.com/llvm/llvm-project/commit/1af159e98c23a293c103e1f548866488126ed6f6 DIFF: https://github.com/llvm/llvm-project/commit/1af159e98c23a293c103e1f548866488126ed6f6.diff LOG: [

[clang] 9e99a4f - [NVPTX] Fix missed test after adding alias support for NVPTX

Author: Joseph Huber Date: 2023-08-07T14:35:02-05:00 New Revision: 9e99a4f0db0e21b68e9aab9ad6f32f34d42eb460 URL: https://github.com/llvm/llvm-project/commit/9e99a4f0db0e21b68e9aab9ad6f32f34d42eb460 DIFF: https://github.com/llvm/llvm-project/commit/9e99a4f0db0e21b68e9aab9ad6f32f34d42eb460.diff

[clang] 0342bbf - Revert "Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`."

Author: Nico Weber Date: 2023-08-07T15:48:23-04:00 New Revision: 0342bbf223fa12701a0570a23f9eac433b8b341c URL: https://github.com/llvm/llvm-project/commit/0342bbf223fa12701a0570a23f9eac433b8b341c DIFF: https://github.com/llvm/llvm-project/commit/0342bbf223fa12701a0570a23f9eac433b8b341c.diff LO

[PATCH] D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

thakis added a comment. Reverted in 0342bbf223fa12701a0570a23f9eac433b8b341c for now, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155895/new/ https://reviews.llvm.org/D155895 ___ cfe-commits ma

[PATCH] D157321: [InstrProf] Fix macOS profile tests after D156569

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157321/new/ https://reviews.llvm.org/D157321

[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

ldionne created this revision. Herald added a subscriber: JDevlieghere. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The libc++ builders do not have the capacity to serve both libc++ and Clang CI need

[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

ldionne added a subscriber: goncharov. ldionne added a comment. @goncharov Now that we have a `buildkite-pipeline.yml` for Clang, would it make sense to stop running the "builtin" jobs like https://buildkite.com/llvm-project/premerge-checks/builds/169498#0189d1af-3c81-4ab5-a87a-ac8db177ccf0 and

[PATCH] D157246: [clang-tidy] Update tests to include C++23 and C++26

avogelsgesang updated this revision to Diff 547931. avogelsgesang added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157246/new/ https://reviews.llvm.org/D157246 Files: clang-tools-extra/test/clang-tidy/check_clang_t

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

sdesmalen updated this revision to Diff 547933. sdesmalen marked 2 inline comments as done. sdesmalen added a comment. Removed double error message for missing 'sme' for both ZA and Streaming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157269/new/

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

sdesmalen added a subscriber: paulwalker-arm. sdesmalen added a comment. Thanks for the review of the Clang side @aaron.ballman and @rsandifo-arm. @paulwalker-arm would you be happy to have a look at the LLVM side of this patch? Comment at: clang/test/Sema/aarch64-sme-func-at

[PATCH] D157326: [clang-tidy] Fix handling of out-of-line functions in readability-static-accessed-through-instance

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Use isStatic instead

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

sdesmalen updated this revision to Diff 547936. sdesmalen marked an inline comment as done. sdesmalen added a comment. - Replaced `|=` into normal assignment `=` - Added test for global initializer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1572

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

sdesmalen added inline comments. Comment at: clang/test/Sema/aarch64-sme-func-attrs.c:181 +void non_za_definition(void) { + sme_arm_new_za(); // OK rsandifo-arm wrote: > sdesmalen wrote: > > rsandifo-arm wrote: > > > Would be good to have some tests for indire

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:17143-17145 + llvm::LoadInst *LD; + Constant *Offset, *Offset1; + Value *DP, *DP1; Move down to define and initialize Comment at: clang/lib/CodeGen/CGBuiltin.cpp:17163

[clang-tools-extra] fda7778 - [clang-tidy] Update tests to include C++23 and C++26

Author: Adrian Vogelsgesang Date: 2023-08-07T21:25:22Z New Revision: fda777849b0088ba83e28683c53c5c8321ef2558 URL: https://github.com/llvm/llvm-project/commit/fda777849b0088ba83e28683c53c5c8321ef2558 DIFF: https://github.com/llvm/llvm-project/commit/fda777849b0088ba83e28683c53c5c8321ef2558.diff

[PATCH] D157246: [clang-tidy] Update tests to include C++23 and C++26

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfda777849b00: [clang-tidy] Update tests to include C++23 and C++26 (authored by avogelsgesang). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D157331: [clang] Implement C23

ZijunZhao created this revision. Herald added a project: All. ZijunZhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://github.com/llvm/llvm-project/issues/62248 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 547949. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Headers/stdckdint.h clang/lib/Lex/ModuleMap.cpp clan

[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

ldionne updated this revision to Diff 547950. ldionne added a comment. Try to fix build on queue=linux builders Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157324/new/ https://reviews.llvm.org/D157324 Files: clang/utils/ci/buildkite-pipeline.y

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

mstorsjo created this revision. mstorsjo added reviewers: aaron.ballman, efriedma. Herald added subscribers: steven.zhang, pengfei. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang. An empty struct is handled as a struct with a dummy i8, on all

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

steven_wu added a comment. This breaks macOS bot: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/36900/testReport/junit/Clang/SemaCUDA/alias_cu/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156014/new/ https://reviews.llvm

[PATCH] D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set

aidengrossman created this revision. Herald added subscribers: pengfei, mstorsjo. Herald added a project: All. aidengrossman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch makes sure _MSC_EXTENSIONS is defined if -fms-extensions

[clang] 769333a - [clang][CGExprConstant] handle unary negation on integrals

Author: Nick Desaulniers Date: 2023-08-07T14:51:01-07:00 New Revision: 769333aeeb4508a39ce61cde5d70d880f9abfc35 URL: https://github.com/llvm/llvm-project/commit/769333aeeb4508a39ce61cde5d70d880f9abfc35 DIFF: https://github.com/llvm/llvm-project/commit/769333aeeb4508a39ce61cde5d70d880f9abfc35.di

[PATCH] D156378: [clang][CGExprConstant] handle unary negation on integrals

This revision was automatically updated to reflect the committed changes. Closed by commit rG769333aeeb45: [clang][CGExprConstant] handle unary negation on integrals (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156378/

[PATCH] D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set

aidengrossman added reviewers: aaron.ballman, hans, mstorsjo, rnk, glandium. aidengrossman added a comment. This should fix the issues seen in https://reviews.llvm.org/D150646 regarding `-fms-extensions` being set on MinGW and the builtins being defined but no `_MSC_EXTENSIONS` macro being set w

[clang] f6267d3 - [clang][CGExprConstant] handle implicit widening/narrowing Int-to-Int casts

Author: Nick Desaulniers Date: 2023-08-07T14:57:25-07:00 New Revision: f6267d3b98c11b50bf24946f21c6646d2d3f6fa8 URL: https://github.com/llvm/llvm-project/commit/f6267d3b98c11b50bf24946f21c6646d2d3f6fa8 DIFF: https://github.com/llvm/llvm-project/commit/f6267d3b98c11b50bf24946f21c6646d2d3f6fa8.di

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

jhuber6 added a comment. In D156014#4567363 , @steven_wu wrote: > This breaks macOS bot: > https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/36900/testReport/junit/Clang/SemaCUDA/alias_cu/ I should've fixed that already. Is it still

[PATCH] D156466: [clang][CGExprConstant] handle implicit widening/narrowing Int-to-Int casts

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6267d3b98c1: [clang][CGExprConstant] handle implicit widening/narrowing Int-to-Int casts (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D157331: [clang] Implement C23

yabinc accepted this revision. yabinc added a comment. This revision is now accepted and ready to land. LGTM, but please wait for a couple of days in case others wish to review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://revie

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 updated this revision to Diff 547971. evelez7 added a comment. Refactor template arg name deduction to get as string for FragmentKind::typeIdentifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157076/new/ https://reviews.llvm.org/D15707

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

steven_wu added a comment. In D156014#4567446 , @jhuber6 wrote: > In D156014#4567363 , @steven_wu > wrote: > >> This breaks macOS bot: >> https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/36

[PATCH] D157331: [clang] Implement C23

hiraditya added inline comments. Comment at: clang/lib/Headers/stdckdint.h:1 +/*=== stdckdint.h - Standard header for checking integer + *-=== nit: format. Comment at: clang/test/Headers/stdckdint.cpp:1 +// RUN: %cla

[clang] 3e66a17 - Reland [clang][DeclPrinter] Fix missing semicolon in AST print for methods that are definitions without having a body

Author: Timo Stripf Date: 2023-08-07T22:14:15Z New Revision: 3e66a174dfd2144672cb7e23afb33df109abadd1 URL: https://github.com/llvm/llvm-project/commit/3e66a174dfd2144672cb7e23afb33df109abadd1 DIFF: https://github.com/llvm/llvm-project/commit/3e66a174dfd2144672cb7e23afb33df109abadd1.diff LOG: R

[PATCH] D157331: [clang] Implement C23

hiraditya added a comment. For the record, the documentation for stdckdint.h is here: https://open-std.org/JTC1/SC22/WG14/www/docs/n3096.pdf#page=330 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331 _

[PATCH] D156743: clang/OpenCL: Add inline implementations of sqrt in builtin header

arsenm added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:832 + +inline float __ovld __cnfn sqrt(float __x) { + return __builtin_elementwise_sqrt(__x); Anastasia wrote: > arsenm wrote: > > svenvh wrote: > > > Anastasia wrote: > > > > Is this a

<    1   2   3   >