[PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

azhan92 updated this revision to Diff 546064. azhan92 added a comment. Check if file is directory before opening. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151567/new/ https://reviews.llvm.org/D151567 Files: clang/lib/AST/Interp/Floating.h

[PATCH] D156123: [include-cleaner] Unify always_keep with rest of the keep logic

kadircet updated this revision to Diff 546070. kadircet added a comment. - Add tests for pragmas on stdlib headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156123/new/ https://reviews.llvm.org/D156123 Files: clang-tools-extra/clang-tidy/mis

[PATCH] D156123: [include-cleaner] Unify always_keep with rest of the keep logic

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:248 + if (Top.SeenAtFile == SM.getMainFileID() && IncludedFile) +Out->ShouldKeep.insert(IncludedFile->getUniqueID()); } VitaNuo wrote: > If I understand

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 546071. DiggerLin marked 5 inline comments as done. DiggerLin added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 Files: clang/lib/Dr

[PATCH] D155270: [clang][Interp] Basic support for bit fields

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D155270#4550473 , @tbaeder wrote: > In D155270#4550466 , @aaron.ballman > wrote: > >> Preco

[PATCH] D156123: [include-cleaner] Unify always_keep with rest of the keep logic

VitaNuo added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156123/new/ https://reviews.llvm.org/D156123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

Ruturaj4 updated this revision to Diff 546074. Ruturaj4 added a comment. - [clang][ExtractAPI] Add support for Objective-C categories - [clang][ExtractAPI] Add support for Objective-C categories 1. Updating D152770 : [clang][ExtractAPI] Add support for Objective

[PATCH] D156787: [analyzer][attr] Add docs to ownership_* attributes

aaron.ballman added a comment. Thank you for adding documentation for these attributes, it's greatly appreciated! Comment at: clang/include/clang/Basic/AttrDocs.td:1171-1175 +These attributes help the static analyzer understand custom ownership management +functions. Neither

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf marked 5 inline comments as done. capfredf added inline comments. Comment at: clang/lib/Interpreter/CodeCompletion.cpp:111 + auto *CConsumer = new ReplCompletionConsumer(Results); + auto Interp = Interpreter::createForCodeCompletion( + CB, MainInterp.getCompilerIn

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

aaron.ballman added a comment. In D155809#4527890 , @danlark wrote: > In D155809#4527847 , @aaron.ballman > wrote: > >> In D155809#4527199 , @danlark >> wrote: >> >>> In

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark added a comment. In D155809#4550646 , @aaron.ballman wrote: > In D155809#4527890 , @danlark wrote: > >> In D155809#4527847 , >> @aaron.ballman wrote: >> >>> In D

[PATCH] D156787: [analyzer][attr] Add docs to ownership_* attributes

steakhal added a comment. I haven't looked at the content but I have the feeling that we should probably backport this to release/17.x Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156787/new/ https://reviews.llvm.org/D156787

[clang] 7f12dca - [HIP] Fix regression about `__fp16` args and return value

Author: Yaxun (Sam) Liu Date: 2023-08-01T11:29:19-04:00 New Revision: 7f12dcac79f3d2653ae77cd1be0768e64ff7a518 URL: https://github.com/llvm/llvm-project/commit/7f12dcac79f3d2653ae77cd1be0768e64ff7a518 DIFF: https://github.com/llvm/llvm-project/commit/7f12dcac79f3d2653ae77cd1be0768e64ff7a518.dif

[PATCH] D156201: [ASTImporter] Fix corrupted RecordLayout introduced by circular referenced fields

balazske added a reviewer: aaron.ballman. balazske added a comment. The fix looks good, only a person with AST competence should have a look at it because a change in `Expr.h`. Comment at: clang/unittests/AST/ASTImporterTest.cpp:8033 +TEST_P(ASTImporterOptionSpecificTestBase,

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

aaron.ballman added a comment. In D155809#4550654 , @danlark wrote: > In D155809#4550646 , @aaron.ballman > wrote: > >> In D155809#4527890 , @danlark >> wrote: >> >>> In

[PATCH] D145345: [HIP] Fix regression about `__fp16` args and return value

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f12dcac79f3: [HIP] Fix regression about `__fp16` args and return value (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D145345?vs=502498&id=546079

[PATCH] D156201: [ASTImporter] Fix corrupted RecordLayout introduced by circular referenced fields

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Expr.h:2343-2344 -protected: - /// Set FPFeatures in trailing storage, used only by Serialization + /// Set FPFeatures in trailing storage, used by Serialization & ASTImporter void setStoredFPFeatures

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark added a comment. In D155809#4550663 , @aaron.ballman wrote: > In D155809#4550654 , @danlark wrote: > >> In D155809#4550646 , >> @aaron.ballman wrote: >> >>> In D

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

aaron.ballman added a comment. In D155809#4550674 , @danlark wrote: > In D155809#4550663 , @aaron.ballman > wrote: > >> In D155809#4550654 , @danlark >> wrote: >> >>> In

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin marked an inline comment as done. DiggerLin added inline comments. Comment at: llvm/test/tools/llvm-ranlib/non-AIX-not-supportedwq-X-option.test:1 +## REQUIRES: !system-aix +## Test the -X option is not supported on non-AIX os. jhenderson wrote: > Looks

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark added a subscriber: ldionne. danlark added a comment. In D155809#4550682 , @aaron.ballman wrote: > In D155809#4550674 , @danlark wrote: > >> In D155809#4550663 ,

[clang] 89e44e3 - [clang][Interp] Implement __builtin_fmax

Author: Timm Bäder Date: 2023-08-01T17:45:24+02:00 New Revision: 89e44e33edeca2fdfa1992096cd5faf98a1f7dae URL: https://github.com/llvm/llvm-project/commit/89e44e33edeca2fdfa1992096cd5faf98a1f7dae DIFF: https://github.com/llvm/llvm-project/commit/89e44e33edeca2fdfa1992096cd5faf98a1f7dae.diff LO

[PATCH] D155401: [clang][Interp] Implement __builtin_fmax

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG89e44e33edec: [clang][Interp] Implement __builtin_fmax (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

aaron.ballman added a comment. In D155809#4550700 , @danlark wrote: > In D155809#4550682 , @aaron.ballman > wrote: > >> In D155809#4550674 , @danlark >> wrote: >> >>> In

[PATCH] D156641: [Clang][Frontend] Change help text for --offload-host-device

AntonRydahl updated this revision to Diff 546083. AntonRydahl added a comment. Rebased on latest commit from main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156641/new/ https://reviews.llvm.org/D156641 Files: clang/include/clang/Driver/Optio

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark added a comment. In D155809#4550711 , @aaron.ballman wrote: > In D155809#4550700 , @danlark wrote: > >> In D155809#4550682 , >> @aaron.ballman wrote: >> >>> In D

[PATCH] D156794: [clang][Interp] Lazily visit unknown global declarations

tbaeder updated this revision to Diff 546090. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156794/new/ https://reviews.llvm.org/D156794 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/c.c Index: clang/test/AST/Interp/c.c ==

[PATCH] D155393: [clang][Interp] Implement __builtin_isfpclass

tbaeder closed this revision. tbaeder marked an inline comment as done. tbaeder added a comment. Also forgot the link in the commit message here. This is closed by https://github.com/llvm/llvm-project/commit/6ba4b213346fad36634a5571feda4f4481097c3a Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D156781: Use the canonical path for the include header search.

sammccall added a comment. I'm out on vacation the next two weeks, happy to look once back, otherwise @kadircet would be the person to review this on the clangd side. A couple of general notes: - people use symlinks in different ways, to give files multiple names, the idea that we can tell whi

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

hubert.reinterpretcast added a comment. In D156596#4546742 , @aaron.ballman wrote: > If so, I'd like @hubert.reinterpretcast to mention if this works for his > needs. We are putting together a build for the (known) affected groups. I will report back

[PATCH] D156806: [Modules] Add test for merging of template member parent

Hahnfeld created this revision. Hahnfeld added reviewers: rsmith, ChuanqiXu. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a reduced test case originally meant to be addressed by https://revi

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

Hahnfeld added a comment. The problem is back, but has been fixed upstream by https://reviews.llvm.org/rG61c7a9140becb19c5b1bc644e54452c6f782f5d5. I managed to reduce a test case triggering the assert touched in this revision, see https://reviews.llvm.org/D156806 Repository: rG LLVM Github

[PATCH] D156779: [RISCV] Use correct LMUL!=1 types for __attribute__((riscv_rvv_vector_bits(N)))

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156779/new/ https://reviews.llvm.org/D156779 ___

[PATCH] D156686: [AST] Simplify Type::isSizelessBuiltinType(). NFC.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156686/new/ https://reviews.llvm.org/D156686 ___

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

codemzs updated this revision to Diff 546100. codemzs marked an inline comment as done. codemzs added a comment. Updated with feedback from @tahonermann CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149573/new/ https://reviews.llvm.org/D149573 Files: clang/include/clang/AST/ASTContex

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

codemzs added a comment. @tahonermann I would like to understand your concern better on unordered floating point types as the callers of `getFloatingTypeOrder` handle this result as per the C++23 proposal, for example there is a test case that exercises this scenario: _Float16 f16_val_1 = 1.0bf

[PATCH] D156201: [ASTImporter] Fix corrupted RecordLayout introduced by circular referenced fields

danix800 added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:8033 +TEST_P(ASTImporterOptionSpecificTestBase, + ImportCirularRefFieldsWithoutCorruptedRecordLayoutCacheTest) { + // Import sequence: A => A.b => B => B.f() => ... => UnaryOperator(&) => .

Re: [clang] 3b34d69 - Revert "For #64088: mark vtable as used if we might emit a reference to it."

This revert reintroduces a wrong-code bug, can you explain what the purpose of the revert is? On Fri, 28 Jul 2023 at 03:50, Dmitry Chernenkov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Dmitry Chernenkov > Date: 2023-07-28T10:49:53Z > New Revision: 3b34d69ac7a643742364be3591b

[PATCH] D156571: [DebugInfo] Alternate MD5 fix, NFC

probinson updated this revision to Diff 546115. probinson added a comment. Use the main FileID instead of expensive string compares. Figured this out after staring at CreateCompileUnit for long enough. Seeding the DIFileCache with the DIFile created there made another test unhappy (difile_entry

[PATCH] D156571: [DebugInfo] Alternate MD5 fix, NFC

probinson added a comment. Of course this means we're rerunning MD5 on the main source file; probably can capture that from TheCU and save that cost as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156571/new/ https://reviews.llvm.org/D156571

[PATCH] D156201: [ASTImporter] Fix corrupted RecordLayout introduced by circular referenced fields

danix800 added inline comments. Comment at: clang/include/clang/AST/Expr.h:2343-2344 -protected: - /// Set FPFeatures in trailing storage, used only by Serialization + /// Set FPFeatures in trailing storage, used by Serialization & ASTImporter void setStoredFPFeatures(FPOp

[clang] edb5056 - [RISCV] Use correct LMUL!=1 types for __attribute__((riscv_rvv_vector_bits(N)))

Author: wangpc Date: 2023-08-02T01:21:14+08:00 New Revision: edb5056300bbb327a4b07b4f64ccc8678345721a URL: https://github.com/llvm/llvm-project/commit/edb5056300bbb327a4b07b4f64ccc8678345721a DIFF: https://github.com/llvm/llvm-project/commit/edb5056300bbb327a4b07b4f64ccc8678345721a.diff LOG: [

[PATCH] D156779: [RISCV] Use correct LMUL!=1 types for __attribute__((riscv_rvv_vector_bits(N)))

This revision was automatically updated to reflect the committed changes. Closed by commit rGedb5056300bb: [RISCV] Use correct LMUL!=1 types for __attribute__((riscv_rvv_vector_bits(N))) (authored by wangpc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D156234: [clang][deps] add support for dependency scanning with cc1 command line

Bigcheese added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:482 + bool Success = false; + if (FinalCommandLine[1] == "-cc1") { +Success = createAndRunToolInvocation(FinalCommandLine, Action, *FileMgr, cpsu

[clang] 2301e13 - [Clang][Frontend] Change help text for --offload-host-device

Author: Anton Rydahl Date: 2023-08-01T10:24:09-07:00 New Revision: 2301e13269d52dbed9b760615d9f328ca1cf72f5 URL: https://github.com/llvm/llvm-project/commit/2301e13269d52dbed9b760615d9f328ca1cf72f5 DIFF: https://github.com/llvm/llvm-project/commit/2301e13269d52dbed9b760615d9f328ca1cf72f5.diff

[PATCH] D156641: [Clang][Frontend] Change help text for --offload-host-device

This revision was automatically updated to reflect the committed changes. Closed by commit rG2301e13269d5: [Clang][Frontend] Change help text for --offload-host-device (authored by AntonRydahl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156641/ne

[PATCH] D156234: [clang][deps] add support for dependency scanning with cc1 command line

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:482 + bool Success = false; + if (FinalCommandLine[1] == "-cc1") { +Success = createAndRunToolInvocation(FinalCommandLine, Action, *FileMgr, c

[PATCH] D156201: [ASTImporter] Fix corrupted RecordLayout introduced by circular referenced fields

danix800 updated this revision to Diff 546127. danix800 added a comment. 1. Update `ReleaseNotes.rst`; 2. Fix testcase names (remove `Test` suffix); 3. Use `friend` instead of exposing API. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156201/new/

[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

jhuber6 created this revision. jhuber6 added reviewers: ebevhan, arsenm, JonChesterfield, jdoerfert, tianshilei1992, tra, yaxunl, rjmccall. Herald added subscribers: jeroen.dobbelaere, Naghasan, ldrumm, arichardson, Anastasia. Herald added a reviewer: aaron.ballman. Herald added a project: All. j

[PATCH] D156360: [clang-format] Support function and overloaded operator SpacesInParensOption

gedare added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:16786 verifyFormat("SomeType *__attribute__( ( attr ) ) *a = NULL;", Spaces); - verifyFormat("void __attribute__( ( naked ) ) foo( int bar )", Spaces); + verifyFormat("void __attribute__( ( x ) )

[clang] 2d1e46f - [clang][deps] NFC: Convert test to split-file

Author: Jan Svoboda Date: 2023-08-01T10:44:30-07:00 New Revision: 2d1e46fec6dbc6c4ecdf1354c091d01bc8267158 URL: https://github.com/llvm/llvm-project/commit/2d1e46fec6dbc6c4ecdf1354c091d01bc8267158 DIFF: https://github.com/llvm/llvm-project/commit/2d1e46fec6dbc6c4ecdf1354c091d01bc8267158.diff L

[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

yaxunl added a comment. Are these attributes supposed to be used in other languages? Some of their names are meaningful only in OpenCL and could be confusing/ambiguous for other languages, e.g "global" and "local". Comment at: clang/include/clang/Basic/Attr.td:1348 +

[PATCH] D156571: [DebugInfo] Alternate MD5 fix, NFC

probinson updated this revision to Diff 546144. probinson added a comment. Reuse the main file's checksum instead of recalculating it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156571/new/ https://reviews.llvm.org/D156571 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeG

[clang] 05d613e - [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

Author: Saleem Abdulrasool Date: 2023-08-01T11:00:27-07:00 New Revision: 05d613ea931b6de1b46dfe04b8e55285359047f4 URL: https://github.com/llvm/llvm-project/commit/05d613ea931b6de1b46dfe04b8e55285359047f4 DIFF: https://github.com/llvm/llvm-project/commit/05d613ea931b6de1b46dfe04b8e55285359047f4.

[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

jhuber6 updated this revision to Diff 546149. jhuber6 added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156816/new/ https://reviews.llvm.org/D156816 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrD

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05d613ea931b: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations (authored by compnerd). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D156539: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces too

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. No problem, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156539/new/ https://reviews.llvm.org/D156539 ___ cfe-commits mailing l

[PATCH] D156806: [Modules] Add test for merging of template member parent

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Awesome, thanks! It makes perfect sense that rG61c7a9140b would fix this. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D156201: [ASTImporter] Fix corrupted RecordLayout introduced by circular referenced fields

steakhal added a comment. Have you considered back porting this to clang-17? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156201/new/ https://reviews.llvm.org/D156201 ___ cfe-commits mailing list cfe-co

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem created this revision. artem added a reviewer: craig.topper. Herald added subscribers: Enna1, kbarton, nemanjai. Herald added a project: All. artem requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Currenly both Cl

[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

arsenm added a comment. I don't really see the point of doing this. These introduce ambiguous terminology. The reason you need the attributes is basically for FFI to opencl code, so might as well make the specific meaning clearer with the opencl bit Repository: rG LLVM Github Monorepo CHANG

[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

jhuber6 added a comment. In D156816#4551299 , @arsenm wrote: > I don't really see the point of doing this. These introduce ambiguous > terminology. The reason you need the attributes is basically for FFI to > opencl code, so might as well make the speci

[PATCH] D156201: [ASTImporter] Fix corrupted RecordLayout introduced by circular referenced fields

danix800 added a comment. In D156201#4551270 , @steakhal wrote: > Have you considered back porting this to clang-17? How to backport? I'm not familiar with this. Is it plain `cherry-pick` to specific branch? Repository: rG LLVM Github Monorepo CHAN

[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

yaxunl added a comment. In D156816#4551307 , @jhuber6 wrote: > In D156816#4551299 , @arsenm wrote: > >> I don't really see the point of doing this. These introduce ambiguous >> terminology. The reason you need th

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:290 + "encoding prefix '%0' on an unevaluated string literal has no effect" + "%select{| and is incompatible with c++2c}1">, + InGroup>; I am not seeing a

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 546159. koops added a comment. 1. clang/test/OpenMP/loop_bind_enclosed.cpp : Converting main and function names within it to use regular expressions to accomodate windows platform. 2. i) Instead of calling setMappedDirective() after the the creation of the Di

[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

jhuber6 added a comment. In D156816#4551338 , @yaxunl wrote: >> FFI isn't the reason you'd use these, it's for generic access to the actual >> backend. E.g. an `addrspace(3)` global is local memory, if it's external >> it's dynamic. Having these named i

[PATCH] D156743: clang/OpenCL: Add inline implementations of sqrt in builtin header

arsenm updated this revision to Diff 546164. arsenm retitled this revision from "[wip] clang/OpenCL: Add inline implementations of sqrt in builtin header" to "clang/OpenCL: Add inline implementations of sqrt in builtin header". arsenm edited the summary of this revision. arsenm added a comment.

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:291 + /// the frontend. + OpenMPDirectiveKind PrevMappedDirective = llvm::omp::OMPD_unknown; + ABataev wrote: > I don't see where this field is stored/loaded for PCH support. You need

[clang] d5ca160 - [Driver] Fix test usages of --rtlib= without --unwindlib=

Author: Alex Brachet Date: 2023-08-01T18:39:40Z New Revision: d5ca1602f64114f612ad5630f04e4aa90591c78d URL: https://github.com/llvm/llvm-project/commit/d5ca1602f64114f612ad5630f04e4aa90591c78d DIFF: https://github.com/llvm/llvm-project/commit/d5ca1602f64114f612ad5630f04e4aa90591c78d.diff LOG:

[PATCH] D156792: [Driver] Fix test usages of --rtlib= without --unwindlib=

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5ca1602f641: [Driver] Fix test usages of --rtlib= without --unwindlib= (authored by abrachet). Herald added a project: clang. Herald added a subscri

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:291 + /// the frontend. + OpenMPDirectiveKind PrevMappedDirective = llvm::omp::OMPD_unknown; + koops wrote: > ABataev wrote: > > I don't see where this field is stored/loaded for PC

[clang] eb8c4b1 - [clang][deps] NFC: Convert test to split-file

Author: Jan Svoboda Date: 2023-08-01T11:48:25-07:00 New Revision: eb8c4b1d0f6154704af669c3f2f7514cb921 URL: https://github.com/llvm/llvm-project/commit/eb8c4b1d0f6154704af669c3f2f7514cb921 DIFF: https://github.com/llvm/llvm-project/commit/eb8c4b1d0f6154704af669c3f2f7514cb921.diff L

[PATCH] D156234: [clang][deps] add support for dependency scanning with cc1 command line

cpsughrue added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:482 + bool Success = false; + if (FinalCommandLine[1] == "-cc1") { +Success = createAndRunToolInvocation(FinalCommandLine, Action, *FileMgr, Bigc

[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

Anastasia added a comment. In D156816#4551357 , @jhuber6 wrote: > In D156816#4551338 , @yaxunl wrote: > >>> FFI isn't the reason you'd use these, it's for generic access to the actual >>> backend. E.g. an `addrsp

[PATCH] D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1.

AMP999 added a comment. Hi @ziqingluo-90 ! I don't have commit privileges, could you commit this for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155814/new/ https://reviews.llvm.org/D155814 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

arsenm added a comment. In D156816#4551409 , @Anastasia wrote: > Why not to just use target address space and define it to some macro with > desirable spelling? If you mean the numbered address spaces, that's the broken thing this is specifically tryin

[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

jhuber6 added a comment. In D156816#4551409 , @Anastasia wrote: > Why not to just use target address space and define it to some macro with > desirable spelling? > > I don't think renaming OpenCL address space to something else makes sense. It > might m

[PATCH] D156201: [ASTImporter] Fix corrupted RecordLayout introduced by circular referenced fields

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! In D156201#4551332 , @danix800 wrote: > In D156201#4551270 , @steakhal > wrote: > >> Ha

[PATCH] D156234: [clang][deps] add support for dependency scanning with cc1 command line

cpsughrue updated this revision to Diff 546182. cpsughrue added a comment. Update llvm-lit test to use split-file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156234/new/ https://reviews.llvm.org/D156234 Files: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp clan

[clang] 59a57ca - [clang][deps] NFC: Convert test to split-file

Author: Jan Svoboda Date: 2023-08-01T12:27:14-07:00 New Revision: 59a57ca6d3e801a90dcef7b4216f6baca6ca99b8 URL: https://github.com/llvm/llvm-project/commit/59a57ca6d3e801a90dcef7b4216f6baca6ca99b8 DIFF: https://github.com/llvm/llvm-project/commit/59a57ca6d3e801a90dcef7b4216f6baca6ca99b8.diff L

[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

jdoerfert added a comment. In D156816#4551417 , @jhuber6 wrote: > In D156816#4551409 , @Anastasia > wrote: > >> Why not to just use target address space and define it to some macro with >> desirable spelling? >>

[PATCH] D156781: Use the canonical path for the include header search.

felberj added a comment. Thanks a lot for your notes! Unfortunately I noticed that while the test that I created passed, my actual issue [0] still persists and I sent out the change too early. It seems you are right and the symlink handling is in fact more nuanced. Enjoy your vacation! I will

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

anna added a comment. In D155145#4544068 , @pengfei wrote: > In D155145#4543326 , @anna wrote: > >> We see a crash bisected to this patch about using an illegal instruction. >> Here's the CPUInfo for the machine:

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:290 + "encoding prefix '%0' on an unevaluated string literal has no effect" + "%select{| and is incompatible with c++2c}1">, + InGroup>; hubert.reinterpretcast wro

[PATCH] D156192: [-Wunsafe-buffer-usage] Stop generating incorrect fix-its for variable declarations with unsupported specifiers

ziqingluo-90 added a comment. > Note that your patch doesn't actually address //type// attributes, only > //declaration// attributes. It does not address type attribute. We can address it in a follow-up patch. > So it's likely that we have to give up on unsupported type attributes very > earl

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1807 + + // Do not emit checks for disabled sanitizers to support recover + SmallVector, 2> Checks; recover -> recovery? Period at the end of the comment Repository: rG LLVM Gi

[PATCH] D156816: [Clang] Make generic aliases to OpenCL address spaces

jhuber6 added a comment. In D156816#4551500 , @jdoerfert wrote: > Macros seems to be good enough. If we really need clang attributes, we need > new docs, and naming convention etc. Yeah an alternative would be a new set of attributes, then we make the o

[clang] b314d05 - [Driver][test] Remove invalid -fuse-ld=wasm-ld

Author: Fangrui Song Date: 2023-08-01T12:52:49-07:00 New Revision: b314d057e717b12d645b1a7542b2918e8c176a37 URL: https://github.com/llvm/llvm-project/commit/b314d057e717b12d645b1a7542b2918e8c176a37 DIFF: https://github.com/llvm/llvm-project/commit/b314d057e717b12d645b1a7542b2918e8c176a37.diff

[clang] 8a9c51c - [Driver][test] Remove hipBundled before %clang

Author: Fangrui Song Date: 2023-08-01T12:55:00-07:00 New Revision: 8a9c51cdbb6d68a5526e4636090ee52ee3cf38f7 URL: https://github.com/llvm/llvm-project/commit/8a9c51cdbb6d68a5526e4636090ee52ee3cf38f7 DIFF: https://github.com/llvm/llvm-project/commit/8a9c51cdbb6d68a5526e4636090ee52ee3cf38f7.diff

[clang] 8c1a519 - [clang][dataflow] Remove deprecated `Strict` accessors.

Author: Martin Braenne Date: 2023-08-01T20:07:00Z New Revision: 8c1a519ee423f4097092095a44ba850bf0dd498d URL: https://github.com/llvm/llvm-project/commit/8c1a519ee423f4097092095a44ba850bf0dd498d DIFF: https://github.com/llvm/llvm-project/commit/8c1a519ee423f4097092095a44ba850bf0dd498d.diff LOG

[PATCH] D156749: [modules] Fix error about the same module being defined in different .pcm files when using VFS overlays.

jansvoboda11 added a comment. > And it is build system's responsibility to provide `-ivfsoverlay` options > that don't cause observable differences. I wasn't aware of that. Do we document this anywhere? It surprises me that we'd impose such restriction on the build system. This seems fairly eas

[PATCH] D156790: [clang][dataflow] Remove deprecated `Strict` accessors.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c1a519ee423: [clang][dataflow] Remove deprecated `Strict` accessors. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156790/new/ https

[PATCH] D156749: [modules] Fix error about the same module being defined in different .pcm files when using VFS overlays.

jansvoboda11 added a subscriber: benlangmuir. jansvoboda11 added a comment. CC @benlangmuir, since we've talked about this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156749/new/ https://reviews.llvm.org/D156749

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

aaron.ballman added a comment. (I snipped off earlier context because it was starting to get hard to read.) In D155809#4550727 , @danlark wrote: > Okay, but I still don't understand how I can satisfy the following conditions > at the same time > > - Ena

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

craig.topper added a comment. In D155145#4551526 , @anna wrote: > In D155145#4544068 , @pengfei wrote: > >> In D155145#4543326 , @anna wrote: >> >>> We see a crash bisecte

[clang] 63c648f - [Driver][test] Add --rocm-path or -nogpuinc/-nogpulib to some AMDGPU tests

Author: Fangrui Song Date: 2023-08-01T13:16:01-07:00 New Revision: 63c648f46dff8d21ade2b77515579b29421b5b69 URL: https://github.com/llvm/llvm-project/commit/63c648f46dff8d21ade2b77515579b29421b5b69 DIFF: https://github.com/llvm/llvm-project/commit/63c648f46dff8d21ade2b77515579b29421b5b69.diff

[PATCH] D156718: [ASanStableABI][Driver] Stop linking to asan dylib when stable abi is enabled

thetruestblue updated this revision to Diff 546199. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156718/new/ https://reviews.llvm.org/D156718 Files: clang/include/clang/Driver/SanitizerArgs.h clang/lib/Driver/ToolChains/Darwin.cpp compiler-rt/test/asan_abi/CMakeLists.txt compile

[clang] 9ecdbe3 - [clang][dataflow] Rename `AggregateStorageLocation` to `RecordStorageLocation` and `StructValue` to `RecordValue`.

Author: Martin Braenne Date: 2023-08-01T20:29:40Z New Revision: 9ecdbe3855a8048989a507ff8d470aee4d407589 URL: https://github.com/llvm/llvm-project/commit/9ecdbe3855a8048989a507ff8d470aee4d407589 DIFF: https://github.com/llvm/llvm-project/commit/9ecdbe3855a8048989a507ff8d470aee4d407589.diff LOG

[PATCH] D156788: [clang][dataflow] Rename `AggregateStorageLocation` to `RecordStorageLocation` and `StructValue` to `RecordValue`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ecdbe3855a8: [clang][dataflow] Rename `AggregateStorageLocation` to `RecordStorageLocation`… (authored by mboehme). Changed prior to commit: https://reviews.llvm.org/D156788?vs=546021&id=546201#toc Re

<    1   2   3   >