[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

tbaeder updated this revision to Diff 545934. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156604/new/ https://reviews.llvm.org/D156604 Files: clang/lib/AST/ExprConstant.cpp clang/lib/AST/Interp/Frame.h clang/lib/AST/Interp/InterpFrame.cpp clang/lib/AST/Interp/InterpFrame.h cl

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

tbaeder added a comment. In D156604#4546650 , @aaron.ballman wrote: >> As you can see I have a test case, but I didn't attach it in >> test/Misc/constexpr-source-ranges.cpp because I can't get >> -fdiagnostics-print-source-range-info to actually print

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

tbaeder added a comment. @hazohelet I changed this to just return `CallExpr->getSourceRange()` and to not save a source range separately. Can you give this a look please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156604/new/ https://reviews.llvm.org/D156604 ___

[PATCH] D155270: [clang][Interp] Basic support for bit fields

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155270/new/ https://reviews.llvm.org/D155270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154951: [clang][Interp] __builtin_bit_cast, Take 2

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154951/new/ https://reviews.llvm.org/D154951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154581/new/ https://reviews.llvm.org/D154581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D152132: [clang][Inter] Fix lifetime diagnostics for dead records

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152132/new/ https://reviews.llvm.org/D152132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144457/new/ https://reviews.llvm.org/D144457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] 535f34d - [index][clangd] Consider labels when indexing function bodies

Author: Christian Kandeler Date: 2023-08-01T09:07:05+02:00 New Revision: 535f34dd80c2200c35971632021a5ed375774d9b URL: https://github.com/llvm/llvm-project/commit/535f34dd80c2200c35971632021a5ed375774d9b DIFF: https://github.com/llvm/llvm-project/commit/535f34dd80c2200c35971632021a5ed375774d9b.

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG535f34dd80c2: [index][clangd] Consider labels when indexing function bodies (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ckandeler added a comment. Build failures seem unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

jhenderson added a comment. In D142660#4541406 , @jhenderson wrote: > In D142660#4538936 , @DiggerLin > wrote: > >>> As an alternative (but I think adds unnecessary complexity, due to needing >>> an extra varia

[PATCH] D146023: [AMDGPU] Remove Code Object V2

Pierre-vh added inline comments. Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:5583 + // FIXME: Shouldn't be needed anymore? Should we remove this directive + // entirely? See `amdpal-elf.ll` - the output ASM contains both amdgcn_target Thi

[clang] 97cddb7 - [clang][Interp] Fix ignoring MaterializeTemporaryExprs

Author: Timm Bäder Date: 2023-08-01T09:45:33+02:00 New Revision: 97cddb78502eee583b5f4ee02c59b7156398587f URL: https://github.com/llvm/llvm-project/commit/97cddb78502eee583b5f4ee02c59b7156398587f DIFF: https://github.com/llvm/llvm-project/commit/97cddb78502eee583b5f4ee02c59b7156398587f.diff LO

[PATCH] D154475: [clang][Interp] Fix ignoring MaterializeTemporaryExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97cddb78502e: [clang][Interp] Fix ignoring MaterializeTemporaryExprs (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D154

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

cor3ntin added inline comments. Comment at: clang/test/CXX/dcl.dcl/dcl.link/p2.cpp:11-14 +extern u8"C" {} // expected-warning {{encoding prefix 'u8' on an unevaluated string literal has no effect and is incompatible with c++2c}} +extern L"C" {} // expected-warning {{encoding

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 updated this revision to Diff 545952. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154588/new/ https://reviews.llvm.org/D154588 Files: llvm/lib/Target/CSKY/CSKYISelLowering.cpp llvm/lib/Target/CSKY/CSKYInstrInfo.td llvm/test/CodeGen

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/overloaded-operator-decl.cpp:64 +class E {}; +void operator+(E, ...) {} // expected-error{{overloaded 'operator+' cannot be variadic}} +void d() { E() + E(); } aaron.ballman wrote: > Fznamznon wrote:

[clang] 4d494e7 - [Clang] Handle static_assert messages with an expression started by a literal

Author: Corentin Jabot Date: 2023-08-01T10:16:02+02:00 New Revision: 4d494e76d098fde0a3399f792f360c111e546ae8 URL: https://github.com/llvm/llvm-project/commit/4d494e76d098fde0a3399f792f360c111e546ae8 DIFF: https://github.com/llvm/llvm-project/commit/4d494e76d098fde0a3399f792f360c111e546ae8.diff

[PATCH] D156597: [Clang] Handle static_assert messages with an expression started by a literal

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d494e76d098: [Clang] Handle static_assert messages with an expression started by a literal (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 6aac11b - [clang][Interp] Evaluate Base when discarding a MemberExpr

Author: Timm Bäder Date: 2023-08-01T10:16:31+02:00 New Revision: 6aac11bad9763dd0ff14637823311187fc3c11a7 URL: https://github.com/llvm/llvm-project/commit/6aac11bad9763dd0ff14637823311187fc3c11a7 DIFF: https://github.com/llvm/llvm-project/commit/6aac11bad9763dd0ff14637823311187fc3c11a7.diff LO

[PATCH] D149828: [clang][Interp] Evaluate Base when discarding a MemberExpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6aac11bad976: [clang][Interp] Evaluate Base when discarding a MemberExpr (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/

[clang] c7b400f - [clang][Interp] Fix ignoring SubstNonTypeTemplateParmExpr

Author: Timm Bäder Date: 2023-08-01T10:25:16+02:00 New Revision: c7b400f4a8d6a0230f8479945820652b37db4d66 URL: https://github.com/llvm/llvm-project/commit/c7b400f4a8d6a0230f8479945820652b37db4d66 DIFF: https://github.com/llvm/llvm-project/commit/c7b400f4a8d6a0230f8479945820652b37db4d66.diff LO

[PATCH] D149831: [clang][Interp] Fix ignoring SubstNonTypeTemplateParmExpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc7b400f4a8d6: [clang][Interp] Fix ignoring SubstNonTypeTemplateParmExpr (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D156779: [RISCV] Use correct LMUL!=1 types for __attribute__((riscv_rvv_vector_bits(N)))

wangpc created this revision. wangpc added a reviewer: craig.topper. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc2

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/BitwiseShiftChecker.cpp:301-302 + pluralSuffix(MaximalAllowedShift)); +R->addNote(LeftNote, PathDiagnosticLocation{LHS, Ctx.getSourceManager(), +

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

hazohelet added a comment. In D156604#4549524 , @tbaeder wrote: > @hazohelet I changed this to just return `CallExpr->getSourceRange()` and to > not save a source range separately. Can you give this a look please? I was thinking about removing `CallLoc`

[clang] b864592 - [clang][Interp] Fix ignoring TypeTraitExprs

Author: Timm Bäder Date: 2023-08-01T10:58:08+02:00 New Revision: b864592915aed568d81f8218cb5c424b0006c14b URL: https://github.com/llvm/llvm-project/commit/b864592915aed568d81f8218cb5c424b0006c14b DIFF: https://github.com/llvm/llvm-project/commit/b864592915aed568d81f8218cb5c424b0006c14b.diff LO

[PATCH] D149834: [clang][Interp] Fix ignoring TypeTraitExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb864592915ae: [clang][Interp] Fix ignoring TypeTraitExprs (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D149834?vs=5203

[clang-tools-extra] 3736eaa - [include-cleaner] Handle StdInitializerListExprs

Author: Kadir Cetinkaya Date: 2023-08-01T10:58:56+02:00 New Revision: 3736eaa6a0b8396e30978c768c02e43c821a8257 URL: https://github.com/llvm/llvm-project/commit/3736eaa6a0b8396e30978c768c02e43c821a8257 DIFF: https://github.com/llvm/llvm-project/commit/3736eaa6a0b8396e30978c768c02e43c821a8257.dif

[PATCH] D156712: [include-cleaner] Handle StdInitializerListExprs

This revision was automatically updated to reflect the committed changes. Closed by commit rG3736eaa6a0b8: [include-cleaner] Handle StdInitializerListExprs (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156712/new/ https://rev

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 closed this revision. benshi001 added a comment. Closed by https://reviews.llvm.org/rG80cd505914dfc2f38f57341f9bef9d208fdc238e https://github.com/llvm/llvm-project/commit/80cd505914dfc2f38f57341f9bef9d208fdc238e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D156781: Use the canonical path for the include header search.

felberj created this revision. Herald added subscribers: kadircet, arphaman, hiraditya. Herald added a project: All. felberj requested review of this revision. Herald added subscribers: cfe-commits, llvm-commits, ilya-biryukov. Herald added projects: clang, LLVM, clang-tools-extra. This is done so

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

tbaeder updated this revision to Diff 545980. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156604/new/ https://reviews.llvm.org/D156604 Files: clang/lib/AST/ExprConstant.cpp clang/lib/AST/Interp/Frame.h clang/lib/AST/Interp/InterpFrame.cpp clang/lib/AST/Interp/InterpFrame.h cl

[PATCH] D156781: Use the canonical path for the include header search.

felberj added a comment. This addresses things like - https://github.com/hedronvision/bazel-compile-commands-extractor/issues/136 - https://github.com/clangd/clangd/issues/124 Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1165 +auto Name = Node.getName(); +Output.

[clang] c0a36a1 - [clang][Interp] Fix ignoring CompoundLiteralExprs

Author: Timm Bäder Date: 2023-08-01T11:48:04+02:00 New Revision: c0a36a157d978bbb80a57f1ea349fdbfe4f9b870 URL: https://github.com/llvm/llvm-project/commit/c0a36a157d978bbb80a57f1ea349fdbfe4f9b870 DIFF: https://github.com/llvm/llvm-project/commit/c0a36a157d978bbb80a57f1ea349fdbfe4f9b870.diff LO

[PATCH] D149837: [clang][Interp] Fix ignoring CompoundLiteralExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc0a36a157d97: [clang][Interp] Fix ignoring CompoundLiteralExprs (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D149837?v

[PATCH] D156781: Use the canonical path for the include header search.

felberj added a comment. Sorry, I removed the reviewers again, because this might still need some work e2e anymore. I will update this once I resolved that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156781/new/ https://reviews.llvm.org/D156781

[clang] 0d2e9b6 - [clang][Interp][NFC] Ignore ArraySubScriptExpr like the other exprs

Author: Timm Bäder Date: 2023-08-01T12:14:20+02:00 New Revision: 0d2e9b6e4627c3c9f4956b212c761248f18f6eae URL: https://github.com/llvm/llvm-project/commit/0d2e9b6e4627c3c9f4956b212c761248f18f6eae DIFF: https://github.com/llvm/llvm-project/commit/0d2e9b6e4627c3c9f4956b212c761248f18f6eae.diff LO

[clang] eec6931 - [clang][Interp] Fix ignoring String- and CharacterLiterals

Author: Timm Bäder Date: 2023-08-01T12:23:57+02:00 New Revision: eec6931d778774bd0c03802e2ea21d8da9fa0362 URL: https://github.com/llvm/llvm-project/commit/eec6931d778774bd0c03802e2ea21d8da9fa0362 DIFF: https://github.com/llvm/llvm-project/commit/eec6931d778774bd0c03802e2ea21d8da9fa0362.diff LO

[PATCH] D149960: [clang][Interp] Fix ignoring String- and CharacterLiterals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeec6931d7787: [clang][Interp] Fix ignoring String- and CharacterLiterals (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D156784: [AArch64][PAC] Declare FPAC subtarget feature

atrosinenko created this revision. atrosinenko added reviewers: ab, kristof.beyls, apazos, pcc, psmith, t.p.northover. Herald added a subscriber: hiraditya. Herald added a project: All. atrosinenko requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llv

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:657-666 + bool DisallowLineBreaksOnThisLine = [&Style = this->Style, &Current] { +// Deal with lambda arguments in C++. The aim here is to ensure that we +// don't over-indent lambda func

[PATCH] D156122: [include-cleaner] Introduce support for always_keep pragma

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:63 + bool shouldKeep(unsigned HashLineNumber) const; + bool shouldKeep(const FileEntry *FE) const;

[PATCH] D156122: [include-cleaner] Introduce support for always_keep pragma

kadircet updated this revision to Diff 546001. kadircet marked an inline comment as done. kadircet added a comment. - Rebase - Properly check for null-ness of FileEntry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156122/new/ https://reviews.llvm

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 updated this revision to Diff 546002. jp4a50 added a comment. More CR feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156259/new/ https://reviews.llvm.org/D156259 Files: clang/docs/ReleaseNotes.rst clang/lib/Format/ContinuationI

[PATCH] D156286: [docs] Bump minimum GCC version to 7.4

aaron.ballman added inline comments. Comment at: llvm/docs/GettingStarted.rst:284-298 `python `_ >=3.6 Automated test suite\ :sup:`2` `zlib `_ >=1.2.3.4 Compression l

[PATCH] D155370: [CodeComplete] Improve FunctionCanBeCall

zyounan added a comment. In D155370#4545763 , @nridge wrote: > (e.g. maybe you're looking for one with a particular parameter type). I understand the second point that it'd be nice to offer the user a chance to see the arguments in order to help decide

[PATCH] D148131: Avoid unnecessarily aggressive line-breaking when using "LambdaBodyIndentation: OuterScope" with argument bin-packing.

jp4a50 updated this revision to Diff 546004. jp4a50 added a comment. Stack diff on top of https://reviews.llvm.org/D156259. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148131/new/ https://reviews.llvm.org/D148131 Files: clang/docs/ReleaseNotes

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan updated this revision to Diff 546007. zyounan added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300 Files: clang-tools-extra/clangd/InlayHints.cpp clang-tools-extra/clangd/unittes

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan updated this revision to Diff 546008. zyounan added a comment. Final update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300 Files: clang-tools-extra/clangd/InlayHints.cpp clang-tools-extra/cla

[clang-tools-extra] b1193c1 - [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

Author: Younan Zhang Date: 2023-08-01T20:12:35+08:00 New Revision: b1193c13a5f9e9a2dca6ae0dd8b4e911f54c09ce URL: https://github.com/llvm/llvm-project/commit/b1193c13a5f9e9a2dca6ae0dd8b4e911f54c09ce DIFF: https://github.com/llvm/llvm-project/commit/b1193c13a5f9e9a2dca6ae0dd8b4e911f54c09ce.diff

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1193c13a5f9: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter (authored by zyounan). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D156724: [StaticAnalyzer] Fix incorrect link to "note" diagnostics in HTML output

gruuprasad added a comment. I went through the build logs, but failed test (Clang :: Driver/fsanitize.c) seems to be irrelevant to the changes in this patch. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:596-599 os << "Note:" << "line "

[PATCH] D156122: [include-cleaner] Introduce support for always_keep pragma

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156122/new/ https://reviews.llvm.org/D156122 __

[PATCH] D153969: [clang][ExprConstant] Fix crash on uninitialized base class subobject

hazohelet added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153969/new/ https://reviews.llvm.org/D153969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

asb updated this revision to Diff 546012. asb added a comment. This update includes test coverage for the bug that was fixed in the reverted version of the patch. Thanks @rogfer01 for the smaller test case. To my surprise, cvise stripped out almost everything and test_s9 in abi-empty-structs.c

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin added a comment. > I'd still rather the invalid OBJECT_MODE value be read and rejected upfront > before even parsing the -X option. as Stephen and me point out, if there is -X option, we do not care about the environment env `OBJECT-MODE` , when user input the -X option , it means ,

[PATCH] D156786: [clang][Interp] Fix converting function pointers to bool

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Emit the proper `PT_FnPtr` instructions if we're handl

[clang] 65dca4c - [clang][Interp] Fix tests for ignored expressions

Author: Timm Bäder Date: 2023-08-01T14:58:46+02:00 New Revision: 65dca4cbcbfc5c4447207eff7d223005089e9fed URL: https://github.com/llvm/llvm-project/commit/65dca4cbcbfc5c4447207eff7d223005089e9fed DIFF: https://github.com/llvm/llvm-project/commit/65dca4cbcbfc5c4447207eff7d223005089e9fed.diff LO

[PATCH] D149965: [clang][Interp] Fix tests for ignored expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG65dca4cbcbfc: [clang][Interp] Fix tests for ignored expressions (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D156786: [clang][Interp] Fix converting function pointers to bool

tbaeder updated this revision to Diff 546015. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156786/new/ https://reviews.llvm.org/D156786 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/functions.cpp Index: clang/test/AST/Interp/functions.cpp ==

[PATCH] D156787: [analyzer][attr] Add docs to ownership_* attributes

Szelethus created this revision. Szelethus added reviewers: NoQ, steakhal, donat.nagy, balazske, gamesh411. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, yaxunl. Herald added a reviewer: aaron.ballman. Herald add

[PATCH] D156704: [clang][HeaderSearch] Treat framework headers as System for suggestPath

dgoldman updated this revision to Diff 546017. dgoldman added a comment. run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156704/new/ https://reviews.llvm.org/D156704 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp clan

[PATCH] D156786: [clang][Interp] Fix converting function pointers to bool

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156786/new/ https://reviews.llvm.org/D156786 ___ cfe-commits mailing list

[clang] 21aa8a2 - [clang][Interp] Fix ignoring Integral- and IntegralToBoolean casts

Author: Timm Bäder Date: 2023-08-01T15:21:20+02:00 New Revision: 21aa8a220c017e35338b3be44a011c6450786f54 URL: https://github.com/llvm/llvm-project/commit/21aa8a220c017e35338b3be44a011c6450786f54 DIFF: https://github.com/llvm/llvm-project/commit/21aa8a220c017e35338b3be44a011c6450786f54.diff LO

[PATCH] D154474: [clang][Interp] Fix ignoring Integral- and IntegralToBoolean casts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21aa8a220c01: [clang][Interp] Fix ignoring Integral- and IntegralToBoolean casts (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D156788: [clang][dataflow] Rename `AggregateStorageLocation` to `RecordStorageLocation` and `StructValue` to `RecordValue`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Both of these constructs are used to represent

[clang] 6ba4b21 - [clang][Interp] Implement __builtin_isfpclass

Author: Timm Bäder Date: 2023-08-01T15:25:22+02:00 New Revision: 6ba4b213346fad36634a5571feda4f4481097c3a URL: https://github.com/llvm/llvm-project/commit/6ba4b213346fad36634a5571feda4f4481097c3a DIFF: https://github.com/llvm/llvm-project/commit/6ba4b213346fad36634a5571feda4f4481097c3a.diff LO

[PATCH] D153969: [clang][ExprConstant] Fix crash on uninitialized base class subobject

aaron.ballman added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2422 + << BS.getType(); + Info.Note(BS.getBeginLoc(), diag::note_constexpr_base_inherited_here); + return false; aaron.ballman wrote: > hazohelet wrote

[PATCH] D156790: [clang][dataflow] Remove deprecated `Strict` accessors.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://r

[PATCH] D153969: [clang][ExprConstant] Fix crash on uninitialized base class subobject

aaron.ballman added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2422 + << BS.getType(); + Info.Note(BS.getBeginLoc(), diag::note_constexpr_base_inherited_here); + return false; aaron.ballman wrote: > aaron.ballman w

[PATCH] D156786: [clang][Interp] Fix converting function pointers to bool

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG015ffba811c4: [clang][Interp] Fix converting function pointers to bool (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 015ffba - [clang][Interp] Fix converting function pointers to bool

Author: Timm Bäder Date: 2023-08-01T15:36:34+02:00 New Revision: 015ffba811c49ee4d98cc68125b03bd5e1c2a2b6 URL: https://github.com/llvm/llvm-project/commit/015ffba811c49ee4d98cc68125b03bd5e1c2a2b6 DIFF: https://github.com/llvm/llvm-project/commit/015ffba811c49ee4d98cc68125b03bd5e1c2a2b6.diff LO

[PATCH] D155610: [Clang][ExprConstant] Print integer instead of character on static assertion failure

cor3ntin added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:838-858 + if (UseUCN) +OutStream << "\\u" + << llvm::format_hex_no_prefix(CodepointValue, /*Width=*/4, +/*Upper=*/false); +

[PATCH] D151834: Include math-errno with fast-math

aaron.ballman added inline comments. Comment at: clang/docs/LanguageExtensions.rst:4698 ``-ffast-math`` is disabled and ``-ffp-contract=on`` -(fused multiply add) is enabled. +(fused multiply add) is enabled. This pragam enables ``-fmath-errno``. + ==

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

abrachet added a comment. > I am curious what @phosek 's failures were about. I created D156792 which should fix those errors, and explains what the errors were. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1563

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/overloaded-operator-decl.cpp:64 +class E {}; +void operator+(E, ...) {} // expected-error{{overloaded 'operator+' cannot be variadic}} +void d() { E() + E(); } cor3ntin wrote: > aaron.ballman wr

[PATCH] D156794: [clang][Interp] Lazily visit unknown global declarations

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In C, we don't get a evaluateAsInitializer() call fo

[PATCH] D156234: [clang][deps] add support for dependency scanning with cc1 command line

cpsughrue added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:482 + bool Success = false; + if (FinalCommandLine[1] == "-cc1") { +Success = createAndRunToolInvocation(FinalCommandLine, Action, *FileMgr, Is t

[PATCH] D155394: [clang][Interp] Implement __builtin_fpclassify

tbaeder closed this revision. tbaeder added a comment. Dang, forgot to add the link to the commit message. This has been closed via https://github.com/llvm/llvm-project/commit/6ba4b213346fad36634a5571feda4f4481097c3a CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155394/new/ https://rev

[PATCH] D152132: [clang][Inter] Fix lifetime diagnostics for dead records

aaron.ballman added a comment. I think this is mostly good, but I did run into a question about removing the assertion so I might still be missing something about the changes. Comment at: clang/lib/AST/Interp/Interp.cpp:241 bool CheckMutable(InterpState &S, CodePtr OpPC, cons

[PATCH] D155661: [clang][ASTImporter] Fix friend class template import within dependent context

balazske accepted this revision. balazske added a comment. This revision is now accepted and ready to land. The fix looks OK, but the test could be improved and cleaned up (for example `FromClass` is the same as `FromD` in the test, and DeclContext is not checked, can be done like in the test `U

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. Ping for review. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/ https://reviews.llvm.org/D155290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D155610: [Clang][ExprConstant] Print integer instead of character on static assertion failure

cor3ntin added a comment. I've been thinking about it and I think I have a cleaner design for the printing of characters: We need a `CharToString(unsigned, Qualtype) -> SmallString` method that takes a value and the type. for `char` and `char8_t` we can just return the value. For `wchar_t`, `ch

[clang] 5821351 - [clang][Interp] Implement __builtin_fpclassify

Author: Timm Bäder Date: 2023-08-01T16:02:15+02:00 New Revision: 5821351343eba18b39ef97cf1866f57a967a5fd0 URL: https://github.com/llvm/llvm-project/commit/5821351343eba18b39ef97cf1866f57a967a5fd0 DIFF: https://github.com/llvm/llvm-project/commit/5821351343eba18b39ef97cf1866f57a967a5fd0.diff LO

[PATCH] D156795: [CUDA][HIP] Fix overloading resolution of delete operator

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a subscriber: mattd. Herald added a project: All. yaxunl requested review of this revision. Currently clang does not consider host/device preference when resolving delete operator in the file scope, which causes device opera

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/overloaded-operator-decl.cpp:64 +class E {}; +void operator+(E, ...) {} // expected-error{{overloaded 'operator+' cannot be variadic}} +void d() { E() + E(); } aaron.ballman wrote: > cor3ntin wrote:

[PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

azhan92 updated this revision to Diff 546051. azhan92 added a comment. Herald added a reviewer: jhenderson. Check if directory before opening as a file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151567/new/ https://reviews.llvm.org/D151567 Fil

[PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

azhan92 updated this revision to Diff 546053. azhan92 added a comment. Check if directory before opening file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151567/new/ https://reviews.llvm.org/D151567 Files: llvm/lib/Support/Unix/Path.inc Ind

[PATCH] D151834: Include math-errno with fast-math

zahiraam updated this revision to Diff 546055. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptio

[PATCH] D151834: Include math-errno with fast-math

zahiraam added inline comments. Comment at: clang/docs/LanguageExtensions.rst:4702 +optimizations are enabled in the section of code governed by the pragma. +Effectively ``-ffast-math`` is enabled and ``-ffp-contract=fast``. This pragam +disables ``-fmath-errno``. ---

[clang] 1684406 - [clang][Interp] Implement __builtin_fabs()

Author: Timm Bäder Date: 2023-08-01T16:32:29+02:00 New Revision: 1684406e63b75d81707900c442a8c69c95640338 URL: https://github.com/llvm/llvm-project/commit/1684406e63b75d81707900c442a8c69c95640338 DIFF: https://github.com/llvm/llvm-project/commit/1684406e63b75d81707900c442a8c69c95640338.diff LO

[PATCH] D155400: [clang][Interp] Implement __builtin_fabs()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1684406e63b7: [clang][Interp] Implement __builtin_fabs() (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D155400?vs=54078

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/overloaded-operator-decl.cpp:64 +class E {}; +void operator+(E, ...) {} // expected-error{{overloaded 'operator+' cannot be variadic}} +void d() { E() + E(); } cor3ntin wrote: > aaron.ballman wrote:

[PATCH] D153969: [clang][ExprConstant] Fix crash on uninitialized base class subobject

hazohelet added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2422 + << BS.getType(); + Info.Note(BS.getBeginLoc(), diag::note_constexpr_base_inherited_here); + return false; aaron.ballman wrote: > aaron.ballman wrote

[PATCH] D155270: [clang][Interp] Basic support for bit fields

aaron.ballman added a comment. Precommit CI is currently crashing on the newly introduced test case. Comment at: clang/test/AST/Interp/bitfields.cpp:36 + // TODO: +=, -=, etc. operators. +} shafik wrote: > This is an interesting test case: > > ``` > struct A

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

aaron.ballman added a comment. In D154581#4484363 , @tbaeder wrote: > One problem this does not fix (but rather introduce) is that the > `InterpState` will also free initmaps of global variables which haven't been > fully initialized. When the initializ

[PATCH] D151834: Include math-errno with fast-math

aaron.ballman added inline comments. Comment at: clang/docs/UsersManual.rst:1727 - * ``precise`` Disables optimizations that are not value-safe on floating-point data, although FP contraction (FMA) is enabled (``-ffp-contract=on``). This is the default behavior. + * ``pr

[PATCH] D155270: [clang][Interp] Basic support for bit fields

tbaeder added a comment. In D155270#4550466 , @aaron.ballman wrote: > Precommit CI is currently crashing on the newly introduced test case. It's missing https://reviews.llvm.org/D155548 :) That's of course just a workaround. At the beginning of the `ev

  1   2   3   >