[PATCH] D155661: [clang][ASTImporter] Fix friend class template import within dependent context

danix800 added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2862-2866 + bool ShouldAddRedecl = !(IsFriendTemplate && IsDependentContext); + // We may already have a record of the same name; try to find and match it. RecordDecl *PrevDecl = nullptr; if (!DC-

[PATCH] D155661: [clang][ASTImporter] Fix friend class template import within dependent context

danix800 updated this revision to Diff 545913. danix800 added a comment. Update ReleaseNotes.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155661/new/ https://reviews.llvm.org/D155661 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ASTImp

[PATCH] D156749: [modules] Fix error about the same module being defined in different .pcm files when using VFS overlays.

vsapsai added a comment. Thanks for the quick review! In D156749#4549226 , @ChuanqiXu wrote: > Although there is a FIXME in the definition of `getNameAsRequested()`, it > looks not sense to require you to fix that. It might not be an over burden > for

[clang] a5791bf - [RISCV][BF16] Enable __bf16 for riscv targets

Author: Jun Sha (Joshua) Date: 2023-08-01T13:59:27+08:00 New Revision: a5791bfef4e4bcc159ef9bf40d88262e5f409766 URL: https://github.com/llvm/llvm-project/commit/a5791bfef4e4bcc159ef9bf40d88262e5f409766 DIFF: https://github.com/llvm/llvm-project/commit/a5791bfef4e4bcc159ef9bf40d88262e5f409766.di

[PATCH] D150929: [RISCV][BF16] Enable __bf16 for riscv targets

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5791bfef4e4: [RISCV][BF16] Enable __bf16 for riscv targets (authored by joshua-arch1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.ll

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan updated this revision to Diff 545920. zyounan marked 2 inline comments as done. zyounan added a comment. Herald added a project: clang. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300 Files

[PATCH] D156686: [AST] Simplify Type::isSizelessBuiltinType(). NFC.

Jim updated this revision to Diff 545921. Jim added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156686/new/ https://reviews.llvm.org/D156686 Files: clang/lib/AST/Type.cpp Index: clang/lib/AST/Type.cpp

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan updated this revision to Diff 545922. zyounan added a comment. Fix the chaos in the previous update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300 Files: clang-tools-extra/clangd/InlayHints.cpp

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan added a comment. Sorry, looks like I messed up with the commits before. Fixed it now. Comment at: clang-tools-extra/clangd/InlayHints.cpp:207 + + // This is a bit tricky: we traverse the type structure and find whether or + // not a type in the desugaring process is o

cfe-commits@lists.llvm.org

yubing updated this revision to Diff 545924. yubing added a comment. address c++ windows's mangling prefix w=>x Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155863/new/ https://reviews.llvm.org/D155863 Files: clang/include/clang/Basic/LangOptio

[clang] 422bcd1 - [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

Author: Erick Velez Date: 2023-07-31T23:29:04-07:00 New Revision: 422bcd10c48bac9042ed9f33f3d17eb81ebfd21a URL: https://github.com/llvm/llvm-project/commit/422bcd10c48bac9042ed9f33f3d17eb81ebfd21a DIFF: https://github.com/llvm/llvm-project/commit/422bcd10c48bac9042ed9f33f3d17eb81ebfd21a.diff L

[PATCH] D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG422bcd10c48b: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON (authored by evelez7). Changed prior to commit: htt

[PATCH] D156027: [clang][Interp] Rework how initializers work

tbaeder updated this revision to Diff 545926. tbaeder added a comment. Add `::delegate(const Expr *E)` and squash previous commits into this one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156027/new/ https://reviews.llvm.org/D156027 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp

cfe-commits@lists.llvm.org

yubing updated this revision to Diff 545927. yubing added a comment. update testcase due to w=>x Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155863/new/ https://reviews.llvm.org/D155863 Files: clang/include/clang/Basic/LangOptions.def clang/

[PATCH] D156027: [clang][Interp] Rework how initializers work

tbaeder updated this revision to Diff 545928. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156027/new/ https://reviews.llvm.org/D156027 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Context.cpp clang/test/AST/Interp/l

cfe-commits@lists.llvm.org

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155863/new/ https://reviews.llvm.org/D155863

[PATCH] D156027: [clang][Interp] Rework how initializers work

tbaeder updated this revision to Diff 545929. tbaeder added a comment. merge `visitConditional()` into its only caller, `VisitAbstractConditionalOperator()`. This works now sine the initializer and non-initializer code paths are the same. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

zixuan-wu added inline comments. Comment at: llvm/test/CodeGen/CSKY/intrinsic.ll:21 +entry: + %ntz = call i32 @llvm.cttz.i32(i32 %x, i1 1) + ret i32 %ntz I think we can also test the condition that the second argument is zero. CHANGES SINCE LAST ACTION http

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:1432 TEST(TypeHints, SubstTemplateParameterAliases) { + llvm::StringRef Header = R"cpp(

<    1   2   3