[PATCH] D156546: [Clang][WIP]Experimental implementation of packed data members declarations

dblaikie added a comment. (just a side note about the title of this patch: I got "packed data members" confused and thought this was referring to struct packing `__attribute__((packed))` - so perhaps something more like "data member packs" would be a more clear term here?) C

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

shafik updated this revision to Diff 545283. shafik added a comment. Add release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155387/new/ https://reviews.llvm.org/D155387 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Lookup.h clang/lib/Sema/SemaOverload.cpp

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

jyknight added a comment. As I posted on the RFC thread, I think we have a viable alternative solution to address the original motiving use-case. One might potentially still make a case for implementing the `-fno-coroutines` flag for GCC compatibility, but given the concerns raised -- and that

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

SlaterLatiao updated this revision to Diff 545286. SlaterLatiao added a comment. - Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156546/new/ https://reviews.llvm.org/D156546 Files: clang/lib/AST/DeclPrinter.cpp clang/l

[PATCH] D156576: Remove rdar links in clang/lib. NFC

ahatanak created this revision. ahatanak added a reviewer: ravikandhadai. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. Herald added a subscriber: MaskRay. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D156576 Files:

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

SlaterLatiao updated this revision to Diff 545291. SlaterLatiao marked 2 inline comments as done. SlaterLatiao added a comment. Revert last commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156546/new/ https://reviews.llvm.org/D156546 Files:

[clang] cc1b666 - [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

Author: Shafik Yaghmour Date: 2023-07-28T15:21:57-07:00 New Revision: cc1b6668c57170cd440d321037ced89d6a61a9cb URL: https://github.com/llvm/llvm-project/commit/cc1b6668c57170cd440d321037ced89d6a61a9cb DIFF: https://github.com/llvm/llvm-project/commit/cc1b6668c57170cd440d321037ced89d6a61a9cb.dif

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc1b6668c571: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some… (authored by shafik). Herald added a project: clang. Repo

[PATCH] D155773: [llvm][MemoryBuiltins] Add alloca support to getInitialValueOfAllocation

jmciver updated this revision to Diff 545294. jmciver edited the summary of this revision. jmciver added a comment. Herald added subscribers: foad, kerbowa, jvesely, arsenm. Refactor AMDGPUPromoteAlloca to use getInitialValueOfAllocation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

SlaterLatiao updated this revision to Diff 545297. SlaterLatiao added a comment. Address comments. - Added test case of duplicate types in template arguments. - Added ending new line to test case file. - Renamed "packed data members" -> "data member packs" Repository: rG LLVM Github Monorepo

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

SlaterLatiao added a comment. In D156546#4543697 , @dblaikie wrote: > (just a side note about the title of this patch: I got "packed data members" > confused and thought this was referring to struct packing > `__attribute__((packed))` - so perhaps somet

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

SlaterLatiao added inline comments. Comment at: clang/test/CodeGenCXX/packed_data_member.cpp:8-12 +template struct S2 { +T t[2]; +Ts... ts; +}; + dblaikie wrote: > Did this test case come out of any particular bug discovered during > implementation? No.

[PATCH] D156237: Complete the implementation of P2361 Unevaluated string literals

barannikov88 added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:2349 + if (isVariadicStringLiteralArgument(Args[N])) { +for (; N < sizeof(uint32_t); N++) + Bits |= (1 << N); maskTrailingZeros might also be useful

[PATCH] D156576: Remove rdar links in clang/lib. NFC

ahatanak updated this revision to Diff 545300. ahatanak added a comment. Remove git commit hash in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156576/new/ https://reviews.llvm.org/D156576 Files: clang/lib/CodeGen/CGObjCMac.cpp clang

[PATCH] D156576: Remove rdar links in clang/lib. NFC

ravikandhadai accepted this revision. ravikandhadai added a comment. This revision is now accepted and ready to land. Thanks Akira. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156576/new/ https://reviews.llvm.org/D156576

[PATCH] D156580: [FunctionImport] Reduce string duplication (NFC)

tejohnson created this revision. tejohnson added a reviewer: mtrofin. Herald added subscribers: hoy, ormris, steven_wu, hiraditya. Herald added a project: All. tejohnson requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. The import/export

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

fridtjof updated this revision to Diff 545305. fridtjof retitled this revision from "[libclang] Expose arguments of clang::annotate{_type}" to "[libclang] Expose arguments of clang::annotate". fridtjof edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1513

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

fridtjof added a comment. In D151373#4538604 , @aaron.ballman wrote: > I think we should drop the `annotate_type` functionality from the patch > entirely rather than add it without any test coverage knowing it doesn't seem > to work as expected. Agree

[clang] b08d358 - Remove private rdar links. NFC

Author: Akira Hatanaka Date: 2023-07-28T16:42:31-07:00 New Revision: b08d358e8ac83cf31c007a58c814bf2dca03d591 URL: https://github.com/llvm/llvm-project/commit/b08d358e8ac83cf31c007a58c814bf2dca03d591 DIFF: https://github.com/llvm/llvm-project/commit/b08d358e8ac83cf31c007a58c814bf2dca03d591.diff

[PATCH] D156576: Remove rdar links in clang/lib. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb08d358e8ac8: Remove private rdar links. NFC (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D155997: [Phase Ordering] Don't speculate in SimplifyCFG before PGO annotation

tejohnson marked 2 inline comments as done. tejohnson added inline comments. Comment at: llvm/test/Transforms/PhaseOrdering/simplifycfg-speculate-blocks.ll:83 +!4 = !{i32 1, !"wchar_size", i32 4} +!5 = !{i32 8, !"PIC Level", i32 2} +!6 = !{i32 7, !"PIE Level", i32 2} ---

[PATCH] D155997: [Phase Ordering] Don't speculate in SimplifyCFG before PGO annotation

tejohnson updated this revision to Diff 545318. tejohnson marked an inline comment as done. tejohnson added a comment. Address test comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155997/new/ https://reviews.llvm.org/D155997 Files: clang/

[clang] 5ddc371 - [clang] [libIndex] Remove unused 'RefD' parameter of IndexingContext::handleReference()

Author: Nathan Ridge Date: 2023-07-28T21:36:27-04:00 New Revision: 5ddc371890324ba8aa5c54b42faeb0ed8a552fdb URL: https://github.com/llvm/llvm-project/commit/5ddc371890324ba8aa5c54b42faeb0ed8a552fdb DIFF: https://github.com/llvm/llvm-project/commit/5ddc371890324ba8aa5c54b42faeb0ed8a552fdb.diff

[PATCH] D156513: [clang] [libIndex] Remove unused 'RefD' parameter of IndexingContext::handleReference()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ddc37189032: [clang] [libIndex] Remove unused 'RefD' parameter of IndexingContext… (authored by nridge). Repository: rG LLVM Github Monorepo CHA

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

nridge added inline comments. Comment at: clang/lib/Index/IndexBody.cpp:150 +ParentDC, +unsigned(SymbolRole::NameReference)); + } ckandeler wrote: > kadircet wrote: > > nridge wrote: > > > `

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

nridge added a comment. In D150124#4542032 , @kadircet wrote: > btw, thanks a lot Nathan for taking good care of clangd, I don't think I say > that enough I'm happy to help! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

pengfei added a comment. In D155145#4543326 , @anna wrote: > We see a crash bisected to this patch about using an illegal instruction. > Here's the CPUInfo for the machine: > > CPU info: > current cpu id: 22 > total 32(physical cores 16) (assigned

[clang] 2f79bb1 - [Driver][test] Add -nogpulib to some AMDGPU tests

Author: Fangrui Song Date: 2023-07-28T19:57:25-07:00 New Revision: 2f79bb10461d114783a1548201928549ace09755 URL: https://github.com/llvm/llvm-project/commit/2f79bb10461d114783a1548201928549ace09755 DIFF: https://github.com/llvm/llvm-project/commit/2f79bb10461d114783a1548201928549ace09755.diff

[clang] 2ca82f3 - [Driver][test] Add --cuda-path= to some tests

Author: Fangrui Song Date: 2023-07-28T20:27:40-07:00 New Revision: 2ca82f36813d984df9730794bcf6ba558daf0161 URL: https://github.com/llvm/llvm-project/commit/2ca82f36813d984df9730794bcf6ba558daf0161 DIFF: https://github.com/llvm/llvm-project/commit/2ca82f36813d984df9730794bcf6ba558daf0161.diff

[clang] 9155e51 - [Driver][test] Add --cuda-path= to some tests

Author: Fangrui Song Date: 2023-07-28T21:21:42-07:00 New Revision: 9155e517e6e1cda474d0d0fa82f71696c325bc10 URL: https://github.com/llvm/llvm-project/commit/9155e517e6e1cda474d0d0fa82f71696c325bc10 DIFF: https://github.com/llvm/llvm-project/commit/9155e517e6e1cda474d0d0fa82f71696c325bc10.diff

[clang] 80765ed - [Driver][test] Ignore %clang exit code for -mcpu=native tests

Author: Fangrui Song Date: 2023-07-28T21:31:44-07:00 New Revision: 80765ede5bbcca1364c2d4ae06127011eaba6389 URL: https://github.com/llvm/llvm-project/commit/80765ede5bbcca1364c2d4ae06127011eaba6389 DIFF: https://github.com/llvm/llvm-project/commit/80765ede5bbcca1364c2d4ae06127011eaba6389.diff

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 545331. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-e

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 545332. ccotter added a comment. - Fix ReleaseNotes again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.t

[clang] f7f65b6 - [test] Set target triple for Driver/miamcu-opt.c

Author: Fangrui Song Date: 2023-07-28T22:06:11-07:00 New Revision: f7f65b68b0e774feee59d4860033ddccc67c134d URL: https://github.com/llvm/llvm-project/commit/f7f65b68b0e774feee59d4860033ddccc67c134d DIFF: https://github.com/llvm/llvm-project/commit/f7f65b68b0e774feee59d4860033ddccc67c134d.diff

[clang] 724d689 - [Driver][test] Add --cuda-path= and ignore %clang exit code for -mcpu=native

Author: Fangrui Song Date: 2023-07-28T22:14:36-07:00 New Revision: 724d68967018deb86e56a5e269500833b54945f8 URL: https://github.com/llvm/llvm-project/commit/724d68967018deb86e56a5e269500833b54945f8 DIFF: https://github.com/llvm/llvm-project/commit/724d68967018deb86e56a5e269500833b54945f8.diff

[PATCH] D156588: feat: Add support for Rocky Linux to LLVM Distro

zkkxu created this revision. zkkxu added reviewers: EricWF, kazu, JDevlieghere. Herald added a project: All. zkkxu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1565

[PATCH] D156027: [clang][Interp] Rework how initializers work

tbaeder updated this revision to Diff 545336. tbaeder marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156027/new/ https://reviews.llvm.org/D156027 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/In

[PATCH] D156588: feat: Add support for Rocky Linux to LLVM Distro

tbaeder added a comment. Herald added a subscriber: ormris. @MaskRay Isn't this something we should be doing with config files now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156588/new/ https://reviews.llvm.org/D156588

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin added a comment. In D105759#4543685 , @hubert.reinterpretcast wrote: > In D105759#4543246 , @aaron.ballman > wrote: > >> I'd recommend we change the diagnostic to be a warning that defaults to an >> er

<    1   2   3