[clang] 96832a6 - [hexagon] restore library path arguments

Author: Brian Cain Date: 2023-07-27T13:26:28-07:00 New Revision: 96832a6bf7e0e7f1e8d634d38c44a1b32d512923 URL: https://github.com/llvm/llvm-project/commit/96832a6bf7e0e7f1e8d634d38c44a1b32d512923 DIFF: https://github.com/llvm/llvm-project/commit/96832a6bf7e0e7f1e8d634d38c44a1b32d512923.diff LO

[PATCH] D156330: [hexagon] restore library path arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96832a6bf7e0: [hexagon] restore library path arguments (authored by androm3da). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D156259: Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:664-666 +if ((Style.Language == FormatStyle::LK_Cpp || + Style.Language == FormatStyle::LK_ObjC) && +!Current.is(tok::comment) && PrevNonComment &&

[PATCH] D156482: [clang][CGExprConstant] handle FunctionToPointerDecay

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Consider the following code: void foo (void) {} void (*bar)(void) = foo; And the corresponding AST:

[PATCH] D156482: [clang][CGExprConstant] handle FunctionToPointerDecay

nickdesaulniers updated this revision to Diff 544909. nickdesaulniers added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156482/new/ https://reviews.llvm.org/D156482 Files: clang/lib/CodeGen/CGExprConstant.cpp Index: clang

[clang] ac72531 - [Driver] Add `-f[no-]offload-uniform-block`

Author: Yaxun (Sam) Liu Date: 2023-07-27T16:36:02-04:00 New Revision: ac725310433aea6a7c808b11dab6f1a7d4ecf78e URL: https://github.com/llvm/llvm-project/commit/ac725310433aea6a7c808b11dab6f1a7d4ecf78e DIFF: https://github.com/llvm/llvm-project/commit/ac725310433aea6a7c808b11dab6f1a7d4ecf78e.dif

[PATCH] D155213: [Driver] Add `-f[no-]offload-uniform-block`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac725310433a: [Driver] Add `-f[no-]offload-uniform-block` (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D76096: [clang] allow const structs/unions/arrays to be constant expressions for C

nickdesaulniers added a comment. In D76096#4537078 , @efriedma wrote: > The idea is to maintain the parallel infrastructure for structs and arrays, > but not for other things. Are you referring specifically to InitListExprs on VarDecls of records (struc

[clang] 6a8b66e - Fix test hip-options.hip

Author: Yaxun (Sam) Liu Date: 2023-07-27T17:36:38-04:00 New Revision: 6a8b66ec19675ff69a222181e77015a4b44b3dac URL: https://github.com/llvm/llvm-project/commit/6a8b66ec19675ff69a222181e77015a4b44b3dac DIFF: https://github.com/llvm/llvm-project/commit/6a8b66ec19675ff69a222181e77015a4b44b3dac.dif

[PATCH] D156492: [clang][deps] Make the C++ API more type-safe

jansvoboda11 created this revision. jansvoboda11 added a reviewer: artemcm. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Scanner's C++ API accepts a set of mo

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 544954. AlexVlx removed a reviewer: eli.friedman. AlexVlx added a comment. This adds more ecumenical handling of unsupported builtins, as per the review discussion (a suffixed equivalent stub is emitted instead); it's paired with an associated change in acce

[PATCH] D105759: Implement P2361 Unevaluated string literals

hubert.reinterpretcast added a comment. > I hope this patch may allow to gather some data on that. @cor3ntin, I have reports that applications having encoding prefixes in `static_assert` are failing to build. The committee did not adopt the subject paper as a "DR resolution". Is it possible to

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

shafik updated this revision to Diff 544960. shafik marked an inline comment as done. shafik added a comment. - Updated so that we ignore ambiguous overload candidate if the name lookup was also ambiguous. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155387/new/ https://reviews.llvm.o

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

shafik marked 4 inline comments as done. shafik added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:15191 OverloadCandidateSet::iterator Best; switch (CandidateSet.BestViableFunction(*this, OpLoc, Best)) { case OR_Success: rsmith wrote: >

[PATCH] D155775: [Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 544974. AlexVlx added a comment. Exploit the fact that ROCm/AMDGPU does LTCG at the moment and for the foreseeable future by moving the accelerator code selection pass to later. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155775/new/ https://revi

[PATCH] D156466: [clang][CGExprConstant] handle implicit widening/narrowing Int-to-Int casts

shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156466/new/ https://reviews.llvm.org/D156466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

rsmith added a comment. LGTM, though please wait a day or two for any more comments from @gribozavr2 since he's looked at this more closely than I have. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155895/new/ https://reviews.llvm.org/D155895 _

[PATCH] D154764: [ASTImporter] Fields are imported first and reordered for correct layout.

shafik added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:8018 +int m() { + return &((A *)0)->f1 - &((A *)0)->f2; +} So is it the case that this caused `f2` to be imported first and then `f1`? Which is the opposit

[clang] 38b648b - [clang][Analysis][NFC] Remove indented empty lines (fix format checking)

Author: dingfei Date: 2023-07-28T08:36:51+08:00 New Revision: 38b648b4a1ab9f3eef3d44a286034df34b4d0ecb URL: https://github.com/llvm/llvm-project/commit/38b648b4a1ab9f3eef3d44a286034df34b4d0ecb DIFF: https://github.com/llvm/llvm-project/commit/38b648b4a1ab9f3eef3d44a286034df34b4d0ecb.diff LOG:

[clang] 7f25a88 - [analyzer] Remove rdar links from static analyzer and libAnalysis sources. NFC.

Author: Artem Dergachev Date: 2023-07-27T17:51:49-07:00 New Revision: 7f25a882616263108d99f7696407b725351324de URL: https://github.com/llvm/llvm-project/commit/7f25a882616263108d99f7696407b725351324de DIFF: https://github.com/llvm/llvm-project/commit/7f25a882616263108d99f7696407b725351324de.dif

[PATCH] D155661: [clang][ASTImporter] Fix friend class template import within dependent context

danix800 updated this revision to Diff 544993. danix800 retitled this revision from "[ASTImporter] Fix friend class template import within dependent context" to "[clang][ASTImporter] Fix friend class template import within dependent context". danix800 added a comment. Update ReleaseNotes Repos

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

galenelias added a comment. In D150403#4539874 , @owenpan wrote: > This seems to cause a regression. See > https://github.com/llvm/llvm-project/issues/64134. @galenelias any idea? I will take a look. The logic I added is trying to distinguish `{ } {` b

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

ChuanqiXu added a comment. > We should reach out to some GCC folks to see if this is an oversight in their > documentation or not. I've sent a mail: https://gcc.gnu.org/pipermail/gcc/2023-July/242159.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D156093: [ASTImporter] Re-odering by lexical order for all imported decls within record

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:1950 +ToD && ToDC == ToD->getLexicalDeclContext() && +ToDC->containsDecl(ToD)) { + ToDC->removeDecl(ToD); If `ToDC` does not contain the decl is that a problem, what case

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

MaskRay added a comment. In D156363#4539877 , @dblaikie wrote: > FWIW this sounds good to me (though given how wide the patch is, might be > worth waiting a few days to a week in case anyone else has thoughts). > > I only looked at a sample of the test c

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

shafik updated this revision to Diff 544999. shafik added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155387/new/ https://reviews.llvm.org/D155387 Files: clang/include/clang/Sema/Lookup.h clang/lib/Sema/SemaOverload.cpp clang/lib/Sema/SemaTemplate.cpp clang/

[libunwind] 3da76c2 - [libunwind] Fix build with -Wunused-function

Author: Shoaib Meenai Date: 2023-07-27T20:22:16-07:00 New Revision: 3da76c2116179fdb3fff8feb4551209e4218746e URL: https://github.com/llvm/llvm-project/commit/3da76c2116179fdb3fff8feb4551209e4218746e DIFF: https://github.com/llvm/llvm-project/commit/3da76c2116179fdb3fff8feb4551209e4218746e.diff

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

wangpc updated this revision to Diff 545006. wangpc added a comment. - Rebase. - Unsupport clang-18. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 Files: clang-tools-extra/clangd/unittests/FindTargetT

[PATCH] D156093: [ASTImporter] Re-odering by lexical order for all imported decls within record

danix800 added a comment. After thought a little bit more I'm doubting whether this lexical ordering is of any practical usage or any meanfullness at all, especially when imported into existing (non-empty) context, reordering by `From` context can not be correct after merging occured. I need mo

[PATCH] D156201: [ASTImporter] Fix corrupted RecordLayout introduced by circular referenced fields

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:7403 + UO->setOperatorLoc(ToOperatorLoc); + UO->setCanOverflow(E->canOverflow()); + I don't see the following values from the old code used: `E->getValueKind()`, `E->getObjectKind()` and `

[PATCH] D154764: [ASTImporter] Fields are imported first and reordered for correct layout.

danix800 added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:8018 +int m() { + return &((A *)0)->f1 - &((A *)0)->f2; +} shafik wrote: > So is it the case that this caused `f2` to be imported first and then `f1`? >

[PATCH] D156482: [clang][CGExprConstant] handle FunctionToPointerDecay

shafik added a comment. Makes sense but I want @efriedma to look at as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156482/new/ https://reviews.llvm.org/D156482 ___ cfe-commits mailing list cfe-co

[PATCH] D156201: [ASTImporter] Fix corrupted RecordLayout introduced by circular referenced fields

danix800 added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:7403 + UO->setOperatorLoc(ToOperatorLoc); + UO->setCanOverflow(E->canOverflow()); + shafik wrote: > I don't see the following values from the old code used: `E->getValueKind()`, > `E->ge

[PATCH] D154764: [ASTImporter] Fields are imported first and reordered for correct layout.

danix800 added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:8018 +int m() { + return &((A *)0)->f1 - &((A *)0)->f2; +} danix800 wrote: > shafik wrote: > > So is it the case that this caused `f2` to be imported firs

[PATCH] D155546: [clang][Interp] Implement __builtin_fmin

tbaeder added a comment. Thanks for the info @jcranmer-intel. I see that the current intepreter doesn't check this for `__builtin_fmin`(GCC does) either, but it does error out for e.g. `__builtin_nan("") + 1` (GCC doesn't). @aaron.ballman I'd like to handle that in a separate patch where I als

[PATCH] D156201: [ASTImporter] Fix corrupted RecordLayout introduced by circular referenced fields

danix800 added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:7403 + UO->setOperatorLoc(ToOperatorLoc); + UO->setCanOverflow(E->canOverflow()); + danix800 wrote: > shafik wrote: > > I don't see the following values from the old code used: > > `E->g

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146368/new/ https://reviews.llvm.org/D146368 __

[PATCH] D156201: [ASTImporter] Fix corrupted RecordLayout introduced by circular referenced fields

danix800 updated this revision to Diff 545016. danix800 added a comment. Add missing field value setting (`FPOptionsOverride`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156201/new/ https://reviews.llvm.org/D156201 Files: clang/include/clang

[PATCH] D156503: [clang][Interp] Don't assume throw stmts have a subexpr

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[clang] 3174766 - [Docs] Fix code-blocks missing a colon and a newline

Author: Roger Ferrer Ibanez Date: 2023-07-28T05:36:49Z New Revision: 31747668325227013e4cdd2c7aa185110485 URL: https://github.com/llvm/llvm-project/commit/31747668325227013e4cdd2c7aa185110485 DIFF: https://github.com/llvm/llvm-project/commit/31747668325227013e4cdd2c7aa185110485.diff

[PATCH] D156438: [Docs] Fix code-blocks missing colon

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG31747668: [Docs] Fix code-blocks missing a colon and a newline (authored by rogfer01). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D156351: clang driver throws error for -mabi=elfv2 or elfv2

MaskRay added inline comments. Comment at: clang/test/Driver/ppc-abi.c:18 // RUN: -mabi=altivec | FileCheck -check-prefix=CHECK-ELFv2 %s +// RUN: %clang -target powerpc64le-unknown-unknown-gnu %s -### -o %t.o 2>&1 \ +// RUN: -mabi=elfv1 | FileCheck -check-prefix=CHECK-UNKNOW

[PATCH] D153616: [clang][Interp] Create a new local variable in visitLambdaExpr()

tbaeder abandoned this revision. tbaeder added a comment. Abandoning this in favor of https://reviews.llvm.org/D156027 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153616/new/ https://reviews.llvm.org/D153616 _

[PATCH] D155546: [clang][Interp] Implement __builtin_fmin

tbaeder added a comment. As for signaling vs. quiet NaNs, it seems like both GCC and Clang only check for NaNs, and don't care if it's signaling or not. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155546/new/ https://reviews.llvm.org/D155546 _

[PATCH] D156506: [clang][Interp] Check floating results for NaNs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This does not handle the builtin functions yet, since

[PATCH] D156507: [RISCV] Upgrade Zihintntl extension to version 1.0 and move out of experimental state.

Jim created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, jdoerfert, luismarques, apazos, sameer.abuasal, s.egerton, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, s

[PATCH] D156509: [clang][Interp] Diagnose unknown parameter values

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D156507: [RISCV] Upgrade Zihintntl extension to version 1.0 and move out of experimental state.

craig.topper added a comment. We already have https://reviews.llvm.org/D151547 in review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156507/new/ https://reviews.llvm.org/D156507 ___ cfe-commits mailing

[PATCH] D156427: [clang] Improve hermeticity of clang header tests.

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156427/new/ https://reviews.llvm.org/D156427 _

[PATCH] D149015: [clang-tidy] Added bugprone-inc-dec-in-conditions check

xgupta added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/IncDecInConditionsCheck.cpp:30 +void IncDecInConditionsCheck::registerMatchers(MatchFinder *Finder) { + auto OperatorMacher = expr( + anyOf(binaryOperator(anyOf(isComparisonOperator(), isLogical

[PATCH] D156509: [clang][Interp] Diagnose unknown parameter values

tbaeder updated this revision to Diff 545028. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156509/new/ https://reviews.llvm.org/D156509 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Interp.cpp clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Opcodes.td

<    1   2   3