[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

FreddyYe updated this revision to Diff 544625. FreddyYe marked an inline comment as done. FreddyYe added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156239/new/ https://reviews.llvm.org/D156239 Files: clang/lib/Basi

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

jhenderson added a comment. In D142660#4535693 , @stephenpeckham wrote: > I don't see any reason to check the OBJECT_MODE environment variable if the > -X flag is used. What would the error be: "You specified a valid -X flag, > but by the way, OBJECT

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

ChuanqiXu added a comment. FYI, for https://github.com/llvm/llvm-project/issues/56301, I've posted https://discourse.llvm.org/t/rfc-a-new-aapass-for-coroutines-or-a-simple-workaround/72336 to make some initial progress. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D155165: [clang][Interp] Fully serialize Floatings to bytes

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155165/new/ https://reviews.llvm.org/D155165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] f443838 - [clang][ASTImporter] Fix import of recursive field initializer.

Author: Balázs Kéri Date: 2023-07-27T09:34:34+02:00 New Revision: f4438385d4d9b7e652b41f908250e55f75695ab6 URL: https://github.com/llvm/llvm-project/commit/f4438385d4d9b7e652b41f908250e55f75695ab6 DIFF: https://github.com/llvm/llvm-project/commit/f4438385d4d9b7e652b41f908250e55f75695ab6.diff L

[PATCH] D155574: [clang][ASTImporter] Fix import of recursive field initializer.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4438385d4d9: [clang][ASTImporter] Fix import of recursive field initializer. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155574/ne

[PATCH] D156064: [SemaCXX] Recognise initializer_list injected-class-name types as initializer_lists

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156064/new/ https://reviews.llvm.org/D156064 __

[PATCH] D156064: [SemaCXX] Recognise initializer_list injected-class-name types as initializer_lists

cor3ntin added inline comments. Comment at: clang/docs/ReleaseNotes.rst:111 +- Fix CTAD for ``std::initializer_list``. This allows + ``std::initializer_list{1, 2, 3}`` to be a ``std::initializer_list`` + as intended. Repository: rG LLVM Github Monorepo CH

[PATCH] D156212: [clang][Interp] Implement remaining strcmp builtins

cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:88-92 + if (!AT->getElementType()->isCharType() && + !AT->getElementType()->isChar8Type()) +return false; + + return true; aaron.ballman wrote: > Allowing `char8_t` seem

[PATCH] D156047: [clang][Interp] Handle CXXParenListInitExprs

cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:661 assert(E->getNumInits() == 1); return DiscardResult ? this->discard(E->inits()[0]) : this->visit(E->inits()[0]); how could DiscardResult e

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Put all the index expressions on the stack and cast th

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

rogfer01 added a comment. I didn't have libcxx handy but @SixWeining testcase also failed with libstdcxx so I made a slightly smaller standalone testcase based on what libstdcxx does and I manually replaced all the template stuff. typedef decltype((int *)2 - (int *)1) my_ptrdiff_t; struc

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

rogfer01 added a comment. I didn't have libcxx handy but @SixWeining testcase also fails with libstdcxx so I expanded what C++ does and removed the templates. With the new patch this does not fail anymore. typedef decltype((int *)2 - (int *)1) my_ptrdiff_t; struct my_lambda { bool op

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

wangpc updated this revision to Diff 544640. wangpc added a comment. - Remove usages of `-fsized-deallocation` in some tests. - Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 Files: clang-tools

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

wangpc added a comment. In D112921#4536088 , @Mordante wrote: > In D112921#4535716 , @wangpc wrote: > >> In D112921#4532378 , @Mordante >> wrote: >> >>> In D112921#453091

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

cor3ntin added a comment. In D155955#4537145 , @efriedma wrote: > The general approach seems fine. The multiplier for constexpr vs. constant > folding can be left for a followup, and we can continue to consider other > possible improvements elsewhere.

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

BeMg updated this revision to Diff 544645. BeMg added a comment. Add prefix __riscv_ for all marco Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156221/new/ https://reviews.llvm.org/D156221 Files: clang/lib/Headers/riscv_ntlh.h clang/test/Code

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13807-13815 + // Don't warn if the comparison involves integral or floating-point types with + // the same canonical types. + QualType LHSCanonical = Constant->getType().getCanonicalType(); + QualTyp

[PATCH] D156402: [clang][dataflow] Don't crash when constructing an array of records.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When I wrote https://reviews.llvm.org/D155446, I

[PATCH] D156403: [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

Fznamznon added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1906-1908 + if (D.isConstexpr()) +// Note: constexpr already initializes everything correctly. +trivialAutoVarInit = LangOptions::TrivialAutoVarInitKind::Uninitialized; Should we h

[PATCH] D156047: [clang][Interp] Handle CXXParenListInitExprs

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:661 assert(E->getNumInits() == 1); return DiscardResult ? this->discard(E->inits()[0]) : this->visit(E->inits()[0]); cor3ntin wrote: > how coul

[PATCH] D156403: [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:841-847 auto [It, Inserted] = SymbolProviders.try_emplace(S.ID); if (Inserted) { auto Headers = include_cleaner::headersForSymbol(Sym, SM, Opts.PragmaIncludes);

[clang] 4cd7d8e - [clang] UnsafeBufferUsage.cpp - fix MSVC "not all control paths return a value" warning. NFC.

Author: Simon Pilgrim Date: 2023-07-27T10:17:57+01:00 New Revision: 4cd7d8e30aca25c86ff40cd547f78b27d573a503 URL: https://github.com/llvm/llvm-project/commit/4cd7d8e30aca25c86ff40cd547f78b27d573a503 DIFF: https://github.com/llvm/llvm-project/commit/4cd7d8e30aca25c86ff40cd547f78b27d573a503.diff

[PATCH] D156325: [Driver] Link shared asan runtime lib with -z now on Solaris/x86

ro added a comment. In D156325#4537237 , @MaskRay wrote: > This needs a clang/test/Driver test. Indeed, I forgot. Added now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156325/new/ https://reviews.llvm

[PATCH] D156325: [Driver] Link shared asan runtime lib with -z now on Solaris/x86

ro updated this revision to Diff 544660. ro added a comment. Add testcases. Re-tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156325/new/ https://reviews.llvm.org/D156325 Files: clang/l

[clang] 6b5149a - [Driver] Link shared asan runtime lib with -z now on Solaris/x86

Author: Rainer Orth Date: 2023-07-27T11:32:48+02:00 New Revision: 6b5149aa442efc10afa00e8864e58a24a9cf5c9f URL: https://github.com/llvm/llvm-project/commit/6b5149aa442efc10afa00e8864e58a24a9cf5c9f DIFF: https://github.com/llvm/llvm-project/commit/6b5149aa442efc10afa00e8864e58a24a9cf5c9f.diff L

[PATCH] D156325: [Driver] Link shared asan runtime lib with -z now on Solaris/x86

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b5149aa442e: [Driver] Link shared asan runtime lib with -z now on Solaris/x86 (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D156405: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Delegatin

[PATCH] D156406: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Identifie

[PATCH] D155819: [include-cleaner] Loose matching for verbatim headers

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/include-cleaner/lib/Types.cpp:171-173 +for (unsigned I : BySpellingAlternate.lookup(Spelling)) + if (!llvm::is_contained(Result

[PATCH] D156064: [SemaCXX] Recognise initializer_list injected-class-name types as initializer_lists

MitalAshok updated this revision to Diff 544673. MitalAshok added a comment. wording of changelog Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156064/new/ https://reviews.llvm.org/D156064 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/Sema

[PATCH] D156351: clang driver throws error for -mabi=elfv2 or elfv2

long5hot updated this revision to Diff 544674. long5hot added a comment. Herald added a subscriber: kbarton. failure is only when we do not give full target triple. for e.x. --target=ppc64 -mabi=elfv2 or even when OS option is unknown e.g. --target=powerpc64-unknown-gnu Repository: rG LLVM Gi

[PATCH] D156411: [clang][dataflow] HTMLLogger: Don't crash if CFG contains unreachable blocks.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://r

[clang] 99ce17b - [clang][docs][OpenMP] Update status of OMPT support.

Author: Michael Halkenhaeuser Date: 2023-07-27T06:16:13-04:00 New Revision: 99ce17b71c41190cd82f4c5382910d71cb673abe URL: https://github.com/llvm/llvm-project/commit/99ce17b71c41190cd82f4c5382910d71cb673abe DIFF: https://github.com/llvm/llvm-project/commit/99ce17b71c41190cd82f4c5382910d71cb673a

[PATCH] D156403: [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression.

VitaNuo updated this revision to Diff 544684. VitaNuo marked 6 inline comments as done. VitaNuo added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156403/new/ https://reviews.llvm.org/D156403 Files: clang-tools-extr

[PATCH] D156336: [clang][docs][OpenMP] Update status of OMPT support.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG99ce17b71c41: [clang][docs][OpenMP] Update status of OMPT support. (authored by mhalk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D156415: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subsc

[PATCH] D156403: [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:901 } +if (auto StdSym = tooling::stdlib::Symbol::named(S->Scope, S->Name, Lang)) + if (a

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 544688. koops added a comment. Correction for clang-format errors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634 Files: clang/include/clang/AST/StmtOpenMP.h clang/include/clang/Basic/DiagnosticSemaKind

[PATCH] D156403: [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression.

VitaNuo updated this revision to Diff 544689. VitaNuo marked an inline comment as done. VitaNuo added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156403/new/ https://reviews.llvm.org/D156403 Files: clang-tools-extra

[PATCH] D156403: [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:842 - auto [It, Inserted] = SymbolProviders.try_emplace(S.ID); - if (Inserted) { -auto Headers = -include_cleaner::headersForSymbol(Sym, SM, Opts.PragmaIncludes); -i

[clang-tools-extra] 3c6a7b0 - [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression.

Author: Viktoriia Bakalova Date: 2023-07-27T10:34:35Z New Revision: 3c6a7b0045afe9a230346e476bf07f88c145fdb5 URL: https://github.com/llvm/llvm-project/commit/3c6a7b0045afe9a230346e476bf07f88c145fdb5 DIFF: https://github.com/llvm/llvm-project/commit/3c6a7b0045afe9a230346e476bf07f88c145fdb5.diff

[PATCH] D156403: [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c6a7b0045af: [clangd] Revert the symbol collector behavior to old pre-include-cleaner… (authored by VitaNuo). Repository: rG LLVM Github Monorepo

[PATCH] D155546: [clang][Interp] Implement __builtin_fmin

tbaeder updated this revision to Diff 544691. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155546/new/ https://reviews.llvm.org/D155546 Files: clang/lib/AST/Interp/InterpBuiltin.cpp clang/test/AST/Interp/builtin-functions.cpp Index: clang/test/AST/Interp/builtin-functions.cpp

[PATCH] D156047: [clang][Interp] Handle CXXParenListInitExprs

tbaeder updated this revision to Diff 544692. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156047/new/ https://reviews.llvm.org/D156047 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/I

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

tbaeder updated this revision to Diff 544693. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156400/new/ https://reviews.llvm.org/D156400 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Inter

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

MaskRay added inline comments. Comment at: clang/test/lit.cfg.py:391 +if 'system-aix' in config.available_features: + config.environment['OBJECT_MODE'] = '32_64' Recent Python style prefers double quotes Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D152093: [clang][Analysis] Handle && and || against variable and its negation as tautology

hazohelet added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152093/new/ https://reviews.llvm.org/D152093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ABataev added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:1652 + Stmt *AStmt, SourceLocation StartLoc, SourceLocation EndLoc, + OpenMPDirectiveKind prevMappedDirective = OMPD_unknown) { + PrevMappedDirective CHANGES SINCE LAST ACTION

[PATCH] D156406: [NFC][clang] Fix static analyzer concerns

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156406/new/ https://reviews.llvm.org/D156406

[PATCH] D156405: [NFC][clang] Fix static analyzer concerns

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156405/new/ https://reviews.llvm.org/D156405

[PATCH] D156047: [clang][Interp] Handle CXXParenListInitExprs

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM, thanks! But please look at the bot failures, i suppose you need to rebase before merging. Also, can you try to add the new interpreter to `test/SemaCXX/paren-list-agg-init.cpp` ? C

[PATCH] D152093: [clang][Analysis] Handle && and || against variable and its negation as tautology

aaron.ballman added a comment. Generally LGTM, just a minor suggestion on slightly rewording the diagnostics and combining them. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9743-9748 +def warn_tautological_negation_and_compare: Warning< + "'&&' against a vari

[PATCH] D155546: [clang][Interp] Implement __builtin_fmin

aaron.ballman added a comment. In D155546#4532839 , @jcranmer-intel wrote: > Treating sNaN as always signaling FE_INVALID is probably the safer option. That sounds reasonable to me. Comment at: clang/test/AST/Interp/builtin-functions

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev updated this revision to Diff 544711. dzhidzhoev added a comment. Rebased on top of https://reviews.llvm.org/D155818. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 Files: clang/test/CodeGen

[PATCH] D156047: [clang][Interp] Handle CXXParenListInitExprs

tbaeder added a comment. > Also, can you try to add the new interpreter to > test/SemaCXX/paren-list-agg-init.cpp ? Hmm no, looks like there's a problem with rvalue references. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156047/new/ https://reviews.llvm.org/D156047

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 added a comment. Hi @dblaikie, Could you please take a look at my reply ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143967/new/ https://reviews.llvm.org/D143967 __

[PATCH] D150946: [clang][Interp] PointerToIntegral casts

aaron.ballman added a comment. In D150946#4536971 , @phosek wrote: > This test is failing on our Windows builders with the following error: > > Script: > -- > : 'RUN: at line 1'; c:\b\s\w\ir\x\w\llvm_build\bin\clang.exe -cc1 > -internal-isystem c

[PATCH] D156307: [clang][DeclPrinter] Fix AST print of curly constructor initializers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156307/new/ https://reviews.llvm.org/D156307

[PATCH] D156402: [clang][dataflow] Don't crash when constructing an array of records.

mboehme added a comment. CI failures look unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156402/new/ https://reviews.llvm.org/D156402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D156423: [OMPIRBuilder] Fix module finalization

domada created this revision. domada added reviewers: jsjodin, skatrak, agozillon, kiranchandramohan, kiranktp, NimishMishra, TIFitis, raghavendhra, dpalermo, jdoerfert. domada added a project: OpenMP. Herald added subscribers: gysit, Dinistro, bviyer, Moerafaat, zero9178, bzcheeseman, awarzynski

[PATCH] D152093: [clang][Analysis] Handle && and || against variable and its negation as tautology

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lg with aaron's suggestion. thanks for the patch, and for your patience! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152093/new/ https://reviews.llvm.org/D152093 __

[PATCH] D151834: Include math-errno with fast-math

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2321-2328 + if ((FD->hasAttr() && !ErrnoOverriden && !OptNone) || ((ConstWithoutErrnoAndExceptions || ConstWithoutExceptions) && - (!ConstWithoutErrnoAndExceptions || (!getLangOpts().Ma

[clang] e6e83cb - [clang][dataflow] Don't crash when constructing an array of records.

Author: Martin Braenne Date: 2023-07-27T12:46:13Z New Revision: e6e83cbcc748a55a7eddce67b228298820cb9315 URL: https://github.com/llvm/llvm-project/commit/e6e83cbcc748a55a7eddce67b228298820cb9315 DIFF: https://github.com/llvm/llvm-project/commit/e6e83cbcc748a55a7eddce67b228298820cb9315.diff LOG

[PATCH] D156402: [clang][dataflow] Don't crash when constructing an array of records.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6e83cbcc748: [clang][dataflow] Don't crash when constructing an array of records. (authored by mboehme). Repository: rG LLVM Github Monorepo CHA

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta updated this revision to Diff 544728. xgupta added a comment. updated code as per the comment of @cor3ntin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155457/new/ https://reviews.llvm.org/D155457 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D156411: [clang][dataflow] HTMLLogger: Don't crash if CFG contains unreachable blocks.

mboehme added a comment. Pre-merge failure looks unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156411/new/ https://reviews.llvm.org/D156411 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta updated this revision to Diff 544732. xgupta added a comment. minor update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155457/new/ https://reviews.llvm.org/D155457 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/type-limit-comp

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

aaron.ballman added a comment. In D156247#4537351 , @ChuanqiXu wrote: > While I am not against the approach, do you think we need similar semantics > for `-fno-concepts`, `-fno-modules`, etc... ? I think we need to take it on a case by case basis. In ge

[clang] 771d7d7 - [clang][dataflow] HTMLLogger: Don't crash if CFG contains unreachable blocks.

Author: Martin Braenne Date: 2023-07-27T13:02:42Z New Revision: 771d7d71df418f12c80632ec6c3488af98f9b196 URL: https://github.com/llvm/llvm-project/commit/771d7d71df418f12c80632ec6c3488af98f9b196 DIFF: https://github.com/llvm/llvm-project/commit/771d7d71df418f12c80632ec6c3488af98f9b196.diff LOG

[PATCH] D156411: [clang][dataflow] HTMLLogger: Don't crash if CFG contains unreachable blocks.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG771d7d71df41: [clang][dataflow] HTMLLogger: Don't crash if CFG contains unreachable blocks. (authored by mboehme). Repository: rG LLVM Github Mono

[PATCH] D155922: [clang][dataflow] Eliminate `ReferenceValue`.

mboehme added a comment. Pre-merge failure looks unrelated. It's in AST/Interp/literals.cpp, and this patch shouldn't affect that in any way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155922/new/ https://reviews.llvm.org/D155922 _

[PATCH] D155921: [clang][dataflow] Reverse course on `getValue()` deprecation.

mboehme added a comment. Pre-merge failure looks unrelated. It's in AST/Interp/literals.cpp, and this patch shouldn't affect that in any way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155921/new/ https://reviews.llvm.org/D155921 _

[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

aaron.ballman added a comment. In D151373#4533550 , @fridtjof wrote: > I fixed the failing IBOutletCollection.m test - there was code to do special > handling for the respective attribute type, which my patch accidentally > skipped previously. I reorder

[PATCH] D156425: [clang-repl] Remove redundant tests

Hahnfeld created this revision. Hahnfeld added a reviewer: v.g.vassilev. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. They only need to be tested once in `execute.cpp` and `fail.cpp`. Repository:

[clang] 1b334a2 - [clang][dataflow] Eliminate `ReferenceValue`.

Author: Martin Braenne Date: 2023-07-27T13:14:47Z New Revision: 1b334a2ae7af8ad8b2e3367db6433f1bc7b2b1a4 URL: https://github.com/llvm/llvm-project/commit/1b334a2ae7af8ad8b2e3367db6433f1bc7b2b1a4 DIFF: https://github.com/llvm/llvm-project/commit/1b334a2ae7af8ad8b2e3367db6433f1bc7b2b1a4.diff LOG

[clang] e95134b - [clang][dataflow] Reverse course on `getValue()` deprecation.

Author: Martin Braenne Date: 2023-07-27T13:14:49Z New Revision: e95134b9cb1885b0da929737858163486a5c399c URL: https://github.com/llvm/llvm-project/commit/e95134b9cb1885b0da929737858163486a5c399c DIFF: https://github.com/llvm/llvm-project/commit/e95134b9cb1885b0da929737858163486a5c399c.diff LOG

[PATCH] D155922: [clang][dataflow] Eliminate `ReferenceValue`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b334a2ae7af: [clang][dataflow] Eliminate `ReferenceValue`. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

aaron.ballman added a reviewer: libc++. aaron.ballman added a comment. I would like explicit buy-in from the libc++ folks on the idea of adding `-fno-coroutines` as they're going to be impacted by Clang supporting such an option (and they may have additional testing requirements to ensure that l

[PATCH] D155921: [clang][dataflow] Reverse course on `getValue()` deprecation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe95134b9cb18: [clang][dataflow] Reverse course on `getValue()` deprecation. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

ChuanqiXu added a comment. Thanks for the explanation. I am strongly in favor with you : ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156247/new/ https://reviews.llvm.org/D156247 ___ cfe-commits maili

[PATCH] D156426: [HIP] link HIP runtime library without --hip-link

yaxunl created this revision. yaxunl added reviewers: tra, scchan, MaskRay, jhuber6. Herald added a project: All. yaxunl requested review of this revision. When doing combined compilation/link for HIP source files, clang should link the HIP runtime library automatically without `--hip-link`. ht

[PATCH] D156426: [HIP] link HIP runtime library without --hip-link

jhuber6 added a comment. So this is equivalent to `nvcc` implicitly calling `-lcudart`? I've had thoughts about the `clang-linker-wrapper` adding known runtime flags to the link job if it's not found. E.g. if we find a CUDA image we pass `-lcudart`. CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

cor3ntin added a comment. In D156247#4534645 , @ilya-biryukov wrote: > At Google, we would like to postpone adoption of coroutines until the > aforementioned bugs are fixed, but we feel that Clang 17 would be a good > candidate to enable other C++20 fe

[PATCH] D156426: [HIP] link HIP runtime library without --hip-link

yaxunl added a comment. In D156426#4538646 , @jhuber6 wrote: > So this is equivalent to `nvcc` implicitly calling `-lcudart`? I've had > thoughts about the `clang-linker-wrapper` adding known runtime flags to the > link job if it's not found. E.g. if we

[PATCH] D156426: [HIP] link HIP runtime library without --hip-link

jhuber6 added inline comments. Comment at: clang/include/clang/Driver/Driver.h:712 + /// Whether there are HIP input files. + bool hasHIPInputs() const { return HasHIPInputs; } + Shouldn't we have access to the compilation? I figured we could check `C.getActiv

[PATCH] D156237: Complete the implementation of P2361 Unevaluated string literals

aaron.ballman added a comment. Can you update the patch description with more details about why these changes are being made in this way (to help people doing code archaeology in the future)? Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:60 + "'exter

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

ilya-biryukov added a comment. Thanks, disabling the language feature definitely makes more sense. `-fno-coroutines` is trickier to implement, but this cannot be too hard. While we are waiting for libc++ folks to come back with feedback, what would be the desired behavior. GCC seems to 1. error

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

MrTrillian updated this revision to Diff 544743. MrTrillian added a comment. Reduced path small strings length to 256 (incidentally close to MAX_PATH on Windows), per @benlangmuir 's comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154130/new/ https://reviews.llvm.org/D154130 Fil

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin marked 3 inline comments as done. DiggerLin added inline comments. Comment at: llvm/test/tools/llvm-ranlib/aix-X-option.test:17-18 +## Test the OBJECT_MODE environment variable when adding symbol table. +# RUN: unset OBJECT_MODE +# RUN: llvm-ranlib t_X32.a +# RUN: llvm-

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

MrTrillian marked an inline comment as done. MrTrillian added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:663 +} else { + llvm::sys::path::remove_dots(AbsPathBuf, /*remove_dot_dot=*/true); + CanonicalName = AbsPathBuf.str().copy(CanonicalNameStorage

[PATCH] D151834: Include math-errno with fast-math

zahiraam updated this revision to Diff 544745. zahiraam marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/include/clang/Basic/FPOptions.def clang/include/clang/Basic/LangOptions.h clang/lib/Code

[PATCH] D156427: [clang] Improve hermeticity of clang header tests.

simpal01 created this revision. Herald added a project: All. simpal01 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Specifying --sysroot prevents these header tests from being located in standard library directories. Repository: r

[PATCH] D151834: Include math-errno with fast-math

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2321-2328 + if ((FD->hasAttr() && !ErrnoOverriden && !OptNone) || ((ConstWithoutErrnoAndExceptions || ConstWithoutExceptions) && - (!ConstWithoutErrnoAndExceptions || (!getLangOpts().MathErr

[PATCH] D156426: [HIP] link HIP runtime library without --hip-link

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Driver/Driver.h:712 + /// Whether there are HIP input files. + bool hasHIPInputs() const { return HasHIPInputs; } + jhuber6 wrote: > Shouldn't we have access

[PATCH] D156426: [HIP] link HIP runtime library without --hip-link

yaxunl updated this revision to Diff 544750. yaxunl marked an inline comment as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156426/new/ https://reviews.llvm.org/D156426 Files: clang/docs/HIPSupport.rst clang/lib/Driver/ToolChains/

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo updated this revision to Diff 544751. VitaNuo marked 8 inline comments as done. VitaNuo added a comment. Address review comments. Update the action to trigger when source action is requested explicitly or from the preamble range. Add unit test. Repository: rG LLVM Github Monorepo CHA

[PATCH] D156426: [HIP] link HIP runtime library without --hip-link

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LG, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156426/new/ https://reviews.llvm.org/D156426 ___ cfe-commits mailing list cfe-

[PATCH] D156425: [clang-repl] Remove redundant tests

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156425/new/ https://reviews.llvm.org/D156425

  1   2   3   >