[PATCH] D156063: [Clang] Reject programs declaring namespace std to be inline

cor3ntin added a comment. Can you add a test for `foo::std` ? I suspects it warns, which is incorrect ? Can you add additional tests for `inline std::foo` ? (which should warn) Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156063/new/ htt

[PATCH] D156053: [Clang] Fix crash in CIndex, when visiting a static_assert without message

cor3ntin added a comment. There is a failed unit test, can you look into it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156053/new/ https://reviews.llvm.org/D156053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/vartemplate-lambda.cpp:17 +// expected-note{{cannot be used in a constant expression}} \ +// expected-er

[PATCH] D154716: [SemaCXX] Fix bug where unexpanded lambda captures where assumed to be expanded

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154716/new/ https://reviews.llvm.org/D154716 __

[PATCH] D144829: [BPF] Add a few new insns under cpu=v4

yonghong-song added a comment. In D144829#4519036 , @eddyz87 wrote: > I tried adding a test similar to `assemble-disassemble.ll`: > > // RUN: llvm-mc -triple bpfel --mcpu=v4 --assemble --filetype=obj %s \ > // RUN: | llvm-objdump -d --mattr=+alu32 -

[PATCH] D144829: [BPF] Add a few new insns under cpu=v4

yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:379 + "$dst = (s8)$src", + [(set GPR:$dst, (sra (shl GPR:$src, (i64 56)), (i64 56)))]>; + def MOVSX_rr_16 : ALU_RR I think it is possible to avoid matc

[clang] 2dea969 - [clang][CodeGen] Introduce `-frecord-command-line` for MachO

Author: Antonio Frighetto Date: 2023-07-24T09:24:59+02:00 New Revision: 2dea969d8337251e4c9335fd601bd4e0e5dee10f URL: https://github.com/llvm/llvm-project/commit/2dea969d8337251e4c9335fd601bd4e0e5dee10f DIFF: https://github.com/llvm/llvm-project/commit/2dea969d8337251e4c9335fd601bd4e0e5dee10f.d

[PATCH] D155716: [clang][CodeGen] Introduce `-frecord-command-line` for MachO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2dea969d8337: [clang][CodeGen] Introduce `-frecord-command-line` for MachO (authored by antoniofrighetto). Repository: rG LLVM Github Monorepo CH

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.h:87-93 +/// Return true if this token is a predefined macro +/// unexpandable by MSVC preprocessor. +inline bool isUnexpandableMsMacro(TokenKind K) { + return K == tok::kw___FUNCTION__ || K == tok:

[clang] 8ac137a - [NFC] Add checks for self-assignment.

Author: Sindhu Chittireddy Date: 2023-07-24T00:38:08-07:00 New Revision: 8ac137acefc01caf636db5f95eb0977c97def1ba URL: https://github.com/llvm/llvm-project/commit/8ac137acefc01caf636db5f95eb0977c97def1ba DIFF: https://github.com/llvm/llvm-project/commit/8ac137acefc01caf636db5f95eb0977c97def1ba.

[PATCH] D155776: [NFC] Add checks for self-assignment.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ac137acefc0: [NFC] Add checks for self-assignment. (authored by schittir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D155776: [NFC] Add checks for self-assignment.

schittir added a comment. @tahonermann Thank you for considering this thoroughly. This patch is now landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776 ___

[PATCH] D156076: [PowerPC][Clang] Remove constraint for initial-exec TLS mode on AIX

nemanjai added a comment. So we don't have code generation for this, but we are enabling it in the front end? What happens if we try to produce code for the IR this produces? It would make more sense to me to implement what is needed in the back end prior to allowing the front end to produce th

[PATCH] D156044: [clangd] Exclude builtin headers from system include extraction

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156044/new/ https://reviews.llvm.org/D156044 __

[PATCH] D155776: [NFC] Add checks for self-assignment.

jplehr added a comment. Hi, it seems that this broke the AMDGPU OpenMP buildbot https://lab.llvm.org/buildbot/#/builders/193/builds/35271 Happy to help if you need more info etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://re

[PATCH] D155694: [NFC][analyzer] Enable implicit destructor for cfg-lifetime tests

tomasz-kaminski-sonarsource updated this revision to Diff 543407. tomasz-kaminski-sonarsource added a comment. Updated text of FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155694/new/ https://reviews.llvm.org/D155694 Files: clang/test/Ana

[PATCH] D155776: [NFC] Add checks for self-assignment.

MitalAshok added a comment. This doesn't compile, could you fix this or revert 8ac137acefc01caf636db5f95eb0977c97def1ba ? Comment at: clang/lib/AST/APValue.cpp:393 APValue &APValue::operator=(APValue &&RHS

[PATCH] D155694: [NFC][analyzer] Enable implicit destructor for cfg-lifetime tests

tomasz-kaminski-sonarsource marked an inline comment as done. tomasz-kaminski-sonarsource added inline comments. Comment at: clang/test/Analysis/lifetime-cfg-output.cpp:6 +// that has non-trivial destructor. As the behavior for such types is different +// from ones with trivial d

[PATCH] D156089: [Driver][XRay][test] Convert more tests to check 'target=...' after 016785d9316d8c5abc5fdf3cdb86479095bbb677

SixWeining created this revision. SixWeining added reviewers: probinson, MaskRay. Herald added a subscriber: dberris. Herald added a project: All. SixWeining requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix https://github.com/llvm/llvm-p

[clang] fa39c0a - Revert "[NFC] Add checks for self-assignment."

Author: Michael Platings Date: 2023-07-24T09:36:11+01:00 New Revision: fa39c0a58e87d9fb0751d4e65a77259a3ec53448 URL: https://github.com/llvm/llvm-project/commit/fa39c0a58e87d9fb0751d4e65a77259a3ec53448 DIFF: https://github.com/llvm/llvm-project/commit/fa39c0a58e87d9fb0751d4e65a77259a3ec53448.di

[PATCH] D155776: [NFC] Add checks for self-assignment.

michaelplatings added a comment. I reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D155846: [NFC][clang] Fix static analyzer concerns

Fznamznon abandoned this revision. Fznamznon added a comment. Oh shoot, I trusted the tool too much to not double check that the copy ctor is already deleted. Thank you for the catch and for the bug report. I'll abandon this change then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D153954: [WIP][clang][analyzer] Relax alpha.cplusplus.EnumCastOutOfRange checker

gamesh411 updated this revision to Diff 543413. gamesh411 edited the summary of this revision. gamesh411 added a comment. The checker now retains the original detection logic, but only whitelists empty enums. As a future step the checker is moved into the optin package. Repository: rG LLVM Gi

[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

tbaeder updated this revision to Diff 543414. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156042/new/ https://reviews.llvm.org/D156042 Files: clang/lib/AST/Interp/InterpBuiltin.cpp clang/test/AST/Interp/builtin-functions.cpp Index: clang/t

[PATCH] D156063: [Clang] Reject programs declaring namespace std to be inline

MitalAshok requested changes to this revision. MitalAshok added a comment. This revision now requires changes to proceed. This does currently break `namespace foo { inline namespace std {} }`, `namespace foo::inline std {}`, etc. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1136

[PATCH] D155849: [NFC][clang] Fix static analyzer concerns

Fznamznon updated this revision to Diff 543417. Fznamznon added a comment. Rebase, fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155849/new/ https://reviews.llvm.org/D155849 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp Index: clang/lib

[PATCH] D156065: [clang-format] Insert namespace comments with leading spaces

owenpan updated this revision to Diff 543415. owenpan added a comment. Fixed unit tests in NamespaceEndCommentsFixerTest.cpp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156065/new/ https://reviews.llvm.org/D156065 Files: clang/lib/Format/NamespaceEndCommentsFixer.cpp clang/unitt

[PATCH] D155992: [clangd] Use xxh3_64bits for background index file digests

kadircet added a comment. thanks for doing this! as Sam pointed out this will result in invalidation of all the index shards, but that's not something new. we already don't clean up non-relevant index shards when people delete sources over time and rely on people having new checkouts or cleari

[PATCH] D155992: [clangd] Use xxh3_64bits for background index file digests

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Agree - LGTM but please land once the branch `release/17.x` exists. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155992/new/ http

[PATCH] D156056: [clang-tidy] Initialize DiagnosticEngine in ExpandModularHeaders

PiotrZSL marked an inline comment as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:75 + Diags(new DiagnosticIDs, +new DiagnosticOptions(Compiler.getDiagnosticOpts()), new Forwarding

[PATCH] D155842: [NFC][clang] Fix static analyzer concerns

Fznamznon updated this revision to Diff 543420. Fznamznon added a comment. Rebase to maybe fix precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155842/new/ https://reviews.llvm.org/D155842 Files: clang/lib/Frontend/HeaderIncludeGen.cpp

[clang] 438fc2c - [analyzer] Fix crash in GenericTaintChecker when propagatig taint to AllocaRegion

Author: Tomasz Kamiński Date: 2023-07-24T10:52:35+02:00 New Revision: 438fc2c83b73e66f6dbae4f34e9a19f41302f825 URL: https://github.com/llvm/llvm-project/commit/438fc2c83b73e66f6dbae4f34e9a19f41302f825 DIFF: https://github.com/llvm/llvm-project/commit/438fc2c83b73e66f6dbae4f34e9a19f41302f825.dif

[PATCH] D155847: [analyzer] Fix crash in GenericTaintChecker when propagatig taint to AllocaRegion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG438fc2c83b73: [analyzer] Fix crash in GenericTaintChecker when propagatig taint to… (authored by tomasz-kaminski-sonarsource). Repository: rG LLVM

[PATCH] D153954: [WIP][clang][analyzer] Relax alpha.cplusplus.EnumCastOutOfRange checker

gamesh411 marked 4 inline comments as done. gamesh411 added a comment. In D153954#4456713 , @shafik wrote: > I did not look at this in detail but I don't think this approach is correct. > I fixed this for constant evaluation the other day and you can fin

[PATCH] D156090: [Driver][XRay][test] Add support for loongarch64

Ami-zhang created this revision. Ami-zhang added reviewers: SixWeining, probinson, MaskRay. Herald added a subscriber: dberris. Herald added a project: All. Ami-zhang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D156089

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 543424. victorkingi added a comment. no changes rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://reviews.llvm.org/D155452 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D155294: [Driver][RISCV] Find baremetal multilibs using YAML for GNU toolchain

Joe added a comment. > Theoretically, I think this matching of multilibs could be done without the > need for multilib.yaml, but it is indeed much easier considering the logic is > already there. Actually, I retract this statement. There would be no way of knowing what the default library is w

[clang] 17a58b3 - [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

Author: Alex Bradbury Date: 2023-07-24T10:24:34+01:00 New Revision: 17a58b3ca7ec18585e9ea8ed8b39d72fe36fb6cb URL: https://github.com/llvm/llvm-project/commit/17a58b3ca7ec18585e9ea8ed8b39d72fe36fb6cb DIFF: https://github.com/llvm/llvm-project/commit/17a58b3ca7ec18585e9ea8ed8b39d72fe36fb6cb.diff

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17a58b3ca7ec: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling… (authored by asb). Herald added a subscriber: wangpc. Changed p

[PATCH] D156056: [clang-tidy] Initialize DiagnosticEngine in ExpandModularHeaders

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:75 + Diags(new DiagnosticIDs, +new DiagnosticOptions(Compiler.getDiagnosticOpts()), new ForwardingDiagnosticConsumer(Compiler.getDiagnos

[PATCH] D156089: [Driver][XRay][test] Convert more tests to check 'target=...' after 016785d9316d8c5abc5fdf3cdb86479095bbb677

SixWeining added inline comments. Comment at: clang/test/Driver/XRay/xray-ignore-loops-flags.cpp:5 // // RUN: %clang -fxray-instrument -fxray-ignore-loops -target x86_64-linux- -### \ // RUN: -x c++ -emit-llvm -c -o - %s 2>&1 | FileCheck %s `x86_64-linux` i

[PATCH] D156056: [clang-tidy] Initialize DiagnosticEngine in ExpandModularHeaders

PiotrZSL marked an inline comment as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:75 + Diags(new DiagnosticIDs, +new DiagnosticOptions(Compiler.getDiagnosticOpts()), new Forwarding

[PATCH] D155396: [Sema][ObjC] Invalidate BlockDecl with invalid return expr & its parent BlockExpr

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks good to me. Comment at: clang/test/AST/ast-dump-recovery.m:24 +// CHECK-NEXT: | `-BlockDecl {{.*}} invalid +int (^a)() = ^() { + return c;

[clang] 569e99a - [clang][docs] Attempt to fix warning when building ReleaseNotes

Author: Alex Bradbury Date: 2023-07-24T10:36:42+01:00 New Revision: 569e99a471f618b7fdf045d5e96f21d3e3a7f898 URL: https://github.com/llvm/llvm-project/commit/569e99a471f618b7fdf045d5e96f21d3e3a7f898 DIFF: https://github.com/llvm/llvm-project/commit/569e99a471f618b7fdf045d5e96f21d3e3a7f898.diff

[clang-tools-extra] b0fd2fd - [include_cleaner] IncludeSpeller.cpp - fix MSVC "not all control paths return a value" warning. NFC.

Author: Simon Pilgrim Date: 2023-07-24T10:37:59+01:00 New Revision: b0fd2fd81606513444d867db13236750754b0d02 URL: https://github.com/llvm/llvm-project/commit/b0fd2fd81606513444d867db13236750754b0d02 DIFF: https://github.com/llvm/llvm-project/commit/b0fd2fd81606513444d867db13236750754b0d02.diff

[clang-tools-extra] 9fbabba - [clangd] InlayHints.cpp - fix MSVC "not all control paths return a value" warning. NFC.

Author: Simon Pilgrim Date: 2023-07-24T10:37:59+01:00 New Revision: 9fbabba9212e7f1a2488a3b05eed0fc61006a7ac URL: https://github.com/llvm/llvm-project/commit/9fbabba9212e7f1a2488a3b05eed0fc61006a7ac DIFF: https://github.com/llvm/llvm-project/commit/9fbabba9212e7f1a2488a3b05eed0fc61006a7ac.diff

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark added a comment. In D155809#4521494 , @rsmith wrote: > This looks correct to me, but it's still a little subtle. Perhaps it'd be > clearer to map the method to an integer (0 for copy assignment, 1 for move > assignment, 2 for destructor, 3 for e

cfe-commits@lists.llvm.org

yubing updated this revision to Diff 543433. yubing added a comment. make retcc respect regcall ABI v.4 as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155863/new/ https://reviews.llvm.org/D155863 Files: clang/include/clang/Basic/LangOptio

cfe-commits@lists.llvm.org

yubing added inline comments. Comment at: llvm/lib/Target/X86/X86CallingConv.td:468 +defm X86_32_RegCallv4_Win : +X86_RegCall_base; defm X86_Win64_RegCall : pengfei wrote: > This will define RetCC_* as well but it is not used, hence will emit warning. >

cfe-commits@lists.llvm.org

yubing updated this revision to Diff 543437. yubing added a comment. small fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155863/new/ https://reviews.llvm.org/D155863 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Driv

[PATCH] D155396: [Sema][ObjC] Invalidate BlockDecl with invalid return expr & its parent BlockExpr

danix800 added inline comments. Comment at: clang/test/AST/ast-dump-recovery.m:24 +// CHECK-NEXT: | `-BlockDecl {{.*}} invalid +int (^a)() = ^() { + return c; hokein wrote: > nit: it'd be nice to encode the github issue number to the testcase here, for > ex

[PATCH] D155985: [clang][ASTDumper] Remove redundant dump of BlockDecl's ParmVarDecl

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155985/new/ https://reviews.llvm.org/D155985

[PATCH] D155294: [Driver][RISCV] Find baremetal multilibs using YAML for GNU toolchain

Joe updated this revision to Diff 543440. Joe added a comment. Add default ABI to multilib flags if none supplied CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155294/new/ https://reviews.llvm.org/D155294 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp

[PATCH] D155984: [Sema][ObjC] Invalidate BlockDecl with invalid ParmVarDecl

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, the fix looks reasonable to me Comment at: clang/test/AST/ast-dump-recovery.m:22 +// CHECK-NEXT: `-BlockDecl {{.*}} invalid +int (^a)(int, int) = ^(int, undefine b)

[clang] 587b8f3 - [NFC][analyzer] Enable implicit destructor for cfg-lifetime tests

Author: Tomasz Kamiński Date: 2023-07-24T11:50:20+02:00 New Revision: 587b8f323d2db30928a2d9f54412aeead69b6cb7 URL: https://github.com/llvm/llvm-project/commit/587b8f323d2db30928a2d9f54412aeead69b6cb7 DIFF: https://github.com/llvm/llvm-project/commit/587b8f323d2db30928a2d9f54412aeead69b6cb7.dif

[PATCH] D155694: [NFC][analyzer] Enable implicit destructor for cfg-lifetime tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tomasz-kaminski-sonarsource marked an inline comment as done. Closed by commit rG587b8f323d2d: [NFC][analyzer] Enable implicit destructor for cfg-lifetime tests (author

[PATCH] D155984: [Sema][ObjC] Invalidate BlockDecl with invalid ParmVarDecl

danix800 marked an inline comment as done. danix800 added inline comments. Comment at: clang/test/AST/ast-dump-recovery.m:22 +// CHECK-NEXT: `-BlockDecl {{.*}} invalid +int (^a)(int, int) = ^(int, undefine b) { + return 1; hokein wrote: > nit: a => `gh64005`

[PATCH] D155294: [Driver][RISCV] Find baremetal multilibs using YAML for GNU toolchain

michaelplatings added a comment. > some nasty and repetitive regexes Yes, it's the same for Arm architecture extensions. Petr & I went back and forth on this for a long time. See discussion here to understand Petr's concerns: https://discourse.llvm.org/t/rfc-multilib/67494/23 CHANGES SINCE LA

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

tblah accepted this revision. tblah added a comment. This revision is now accepted and ready to land. This looks good to me. Thanks for your efforts on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://reviews.llvm.org/D155452

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

Fznamznon added a comment. Just a couple of NITs otherwise LGTM Comment at: clang/lib/Sema/SemaDeclCXX.cpp:2506 + + for (auto A : E->arguments()) +if (!getDerived().TraverseStmt(A)) Comment at: clang/lib/Sema/SemaDeclCXX.cpp:254

[PATCH] D156093: [ASTImporter] Add extra sorting round for keeping lexical order of all imported decls within record

danix800 created this revision. danix800 added a project: clang. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. danix800 requested review of this revision. Herald added a subscriber: cfe-commits. Revision https:

[clang] 106bde9 - [Sema][ObjC] Invalidate BlockDecl with invalid return expr & its parent BlockExpr

Author: dingfei Date: 2023-07-24T18:24:32+08:00 New Revision: 106bde9ab2bdffb2409311ef2d4f2c3c9ca77d3f URL: https://github.com/llvm/llvm-project/commit/106bde9ab2bdffb2409311ef2d4f2c3c9ca77d3f DIFF: https://github.com/llvm/llvm-project/commit/106bde9ab2bdffb2409311ef2d4f2c3c9ca77d3f.diff LOG:

[PATCH] D155396: [Sema][ObjC] Invalidate BlockDecl with invalid return expr & its parent BlockExpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG106bde9ab2bd: [Sema][ObjC] Invalidate BlockDecl with invalid return expr & its parent… (authored by dingfei ). Changed prior to com

[PATCH] D152246: [clang][ThreadSafety] Analyze known function pointer values

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152246/new/ https://reviews.llvm.org/D152246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152504/new/ https://reviews.llvm.org/D152504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155393: [clang][Interp] Implement __builtin_isfpclass

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155393/new/ https://reviews.llvm.org/D155393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D155394: [clang][Interp] Implement __builtin_fpclassify

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155394/new/ https://reviews.llvm.org/D155394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D155430: [clang][Interp] Implement __arithmethic_fence for floating types

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155430/new/ https://reviews.llvm.org/D155430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] 3cb16f6 - [Sema][ObjC] Invalidate BlockDecl with invalid ParmVarDecl

Author: dingfei Date: 2023-07-24T18:32:46+08:00 New Revision: 3cb16f6d2ddd030c35df7ad3eb7985f1947173cb URL: https://github.com/llvm/llvm-project/commit/3cb16f6d2ddd030c35df7ad3eb7985f1947173cb DIFF: https://github.com/llvm/llvm-project/commit/3cb16f6d2ddd030c35df7ad3eb7985f1947173cb.diff LOG:

[PATCH] D155984: [Sema][ObjC] Invalidate BlockDecl with invalid ParmVarDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3cb16f6d2ddd: [Sema][ObjC] Invalidate BlockDecl with invalid ParmVarDecl (authored by dingfei ). Changed prior to commit: https:/

[clang] 4b15bb9 - [clang][ASTDumper] Remove redundant dump of BlockDecl's ParmVarDecl

Author: dingfei Date: 2023-07-24T18:42:26+08:00 New Revision: 4b15bb9a317edcf6a3ad95ddaa4a843afe700261 URL: https://github.com/llvm/llvm-project/commit/4b15bb9a317edcf6a3ad95ddaa4a843afe700261 DIFF: https://github.com/llvm/llvm-project/commit/4b15bb9a317edcf6a3ad95ddaa4a843afe700261.diff LOG:

[PATCH] D155985: [clang][ASTDumper] Remove redundant dump of BlockDecl's ParmVarDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b15bb9a317e: [clang][ASTDumper] Remove redundant dump of BlockDecl's ParmVarDecl (authored by dingfei ). Changed prior to commit:

[clang] 239ad4f - [OPENMP][NFC] Editing OpenMP support page

Author: Sandeep Kosuri Date: 2023-07-24T05:43:07-05:00 New Revision: 239ad4fde8805ad8d48babff633230313e051e36 URL: https://github.com/llvm/llvm-project/commit/239ad4fde8805ad8d48babff633230313e051e36 DIFF: https://github.com/llvm/llvm-project/commit/239ad4fde8805ad8d48babff633230313e051e36.diff

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

awarzynski added a comment. Thanks for working on this, LG! I've left a few minor comments inline. Comment at: clang/include/clang/Driver/Options.td:6449-6455 +def opt_record_file : Separate<["-"], "opt-record-file">, Flags<[FC1Option, CC1Option]>, + HelpText<"File name to us

[clang] 77ac634 - Fix the Clang sphinx build

Author: Aaron Ballman Date: 2023-07-24T07:32:48-04:00 New Revision: 77ac634c64ec75b461139a730b23e6a9c26ae1dc URL: https://github.com/llvm/llvm-project/commit/77ac634c64ec75b461139a730b23e6a9c26ae1dc DIFF: https://github.com/llvm/llvm-project/commit/77ac634c64ec75b461139a730b23e6a9c26ae1dc.diff

[PATCH] D144829: [BPF] Add a few new insns under cpu=v4

eddyz87 added a comment. Hi Yonghong, Thank you for the comments. Could you please also add a few tests for `gotol`? Sorry, I should have asked for those last week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144829/new/ https://reviews.llvm.org

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

cor3ntin updated this revision to Diff 543472. cor3ntin added a comment. - Use -fconstexpr-steps to limit the size of the array. - Aply the logic to both constant evaluation and constant folding as is constant evaluation fail the limit can now be increased. Repository: rG LLVM Github Monorepo

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

cor3ntin added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:6754-6758 bool IsNothrow = false; for (unsigned I = 1, N = E->getNumArgs(); I != N; ++I) { EvaluateIgnoredValue(Info, E->getArg(I)); IsNothrow |= E->getType()->isNothrowT(); } --

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval-default-params.cpp:48 -struct InitWithLambda { -int b = [](int error = undefined()) { // expected-error {{cannot take address of consteval function 'undefined' outside of an immediate invocation

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval-default-params.cpp:48 -struct InitWithLambda { -int b = [](int error = undefined()) { // expected-error {{cannot take address of consteval function 'undefined' outside of an immediate invocatio

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

cor3ntin updated this revision to Diff 543476. cor3ntin added a comment. - Fix FunctionDecl constness - Replan an `auto` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155175/new/ https://reviews.llvm.org/D155175 Files: clang/include/clang/AST/Re

[PATCH] D156108: Rebase, extend the test a bit

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D156108 Files: clang/test/SemaTemplate/gh61159.cpp

[PATCH] D155705: [clang] Fix specialization of non-templated member classes of class templates

Fznamznon updated this revision to Diff 543478. Fznamznon added a comment. Rebase, extend the test a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155705/new/ https://reviews.llvm.org/D155705 Files: clang/docs/ReleaseNotes.rst clang/lib/Se

[PATCH] D156108: Rebase, extend the test a bit

Fznamznon abandoned this revision. Fznamznon added a comment. Miss click! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156108/new/ https://reviews.llvm.org/D156108 ___ cfe-commits mailing list cfe-commi

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D155705: [clang] Fix specialization of non-templated member classes of class templates

Fznamznon added a comment. > Maybe we should think about tests that might exercise this code a bit more. I tried adding more checks, but the patch fixes a specific case. Do you have some examples in mind? Please note that in order to test new change there should be an instantiation of nested non

[clang] dfca883 - [Sema] Fix handling of functions that hide classes

Author: John Brawn Date: 2023-07-24T13:11:30+01:00 New Revision: dfca88341794eec88c5009a93c569172fff62635 URL: https://github.com/llvm/llvm-project/commit/dfca88341794eec88c5009a93c569172fff62635 DIFF: https://github.com/llvm/llvm-project/commit/dfca88341794eec88c5009a93c569172fff62635.diff LO

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdfca88341794: [Sema] Fix handling of functions that hide classes (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM, modulo suggestion Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:63-69 + if (SizeTWidth == 64) +S.Stk.push>(Integral<64, false>::from(Val)); + else if (Si

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:356 + "cannot allocate array; evaluated array bound %0 exceeds the limit (%1); " + "use -fconstexpr-steps=%0 to increase this limit">; def note_constexpr_new_too_small : Note<

[PATCH] D155808: [clang][driver] Missing the condition in IsARMBigEndain function.

simpal01 updated this revision to Diff 543484. simpal01 added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155808/new/ https://reviews.llvm.org/D155808 Files: clang/lib/Driver/ToolChains/BareMetal.cpp cl

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

cor3ntin marked 2 inline comments as done. cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:356 + "cannot allocate array; evaluated array bound %0 exceeds the limit (%1); " + "use -fconstexpr-steps=%0 to increase this limit">; def not

[clang] cc928c6 - [NFC][clang] Fix static analyzer concerns

Author: Podchishchaeva, Mariya Date: 2023-07-24T05:15:50-07:00 New Revision: cc928c683058b2e43d250234066609008aa02f68 URL: https://github.com/llvm/llvm-project/commit/cc928c683058b2e43d250234066609008aa02f68 DIFF: https://github.com/llvm/llvm-project/commit/cc928c683058b2e43d250234066609008aa02

[PATCH] D155849: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc928c683058: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155849/new/ https://reviews.l

[clang] dc3cd59 - Revert "[Sema] Fix handling of functions that hide classes"

Author: John Brawn Date: 2023-07-24T13:30:26+01:00 New Revision: dc3cd5926423c56d4673308617f035713aa024d6 URL: https://github.com/llvm/llvm-project/commit/dc3cd5926423c56d4673308617f035713aa024d6 DIFF: https://github.com/llvm/llvm-project/commit/dc3cd5926423c56d4673308617f035713aa024d6.diff LO

[clang] 0cb2906 - [NFC][clang] Fix static analyzer concerns

Author: Podchishchaeva, Mariya Date: 2023-07-24T05:31:55-07:00 New Revision: 0cb2906cdfb3480382828890e9ac4c076c17f3fa URL: https://github.com/llvm/llvm-project/commit/0cb2906cdfb3480382828890e9ac4c076c17f3fa DIFF: https://github.com/llvm/llvm-project/commit/0cb2906cdfb3480382828890e9ac4c076c17f

[PATCH] D155842: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cb2906cdfb3: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155842/new/ https://reviews.l

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:356 + "cannot allocate array; evaluated array bound %0 exceeds the limit (%1); " + "use -fconstexpr-steps=%0 to increase this limit">; def note_constexpr_new_too_small : Note<

cfe-commits@lists.llvm.org

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86CallingConv.td:98-103 +def RC_X86_64_RegCallv4_Win : RC_X86_64_RegCall { + let GPR_8 = [AL, CL, DL, DIL, SIL, R8B, R9B, R11B, R12B, R14B, R15B]; + let GPR_16 = [AX, CX, DX, DI, SI, R8W, R9W, R11W, R12W, R14W, R15

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

cor3ntin updated this revision to Diff 543490. cor3ntin added a comment. Address Aaron's comments and add documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155955/new/ https://reviews.llvm.org/D155955 Files: clang/docs/ReleaseNotes.rst

  1   2   3   4   >