[PATCH] D155982: Partially revert "clang/HIP: Remove __llvm_amdgcn_* wrapper hacks"

arsenm updated this revision to Diff 543111. arsenm marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155982/new/ https://reviews.llvm.org/D155982 Files: clang/lib/Headers/__clang_hip_libdevice_declares.h clang/test/Headers/__clang_hip_math_deprecated.hi

[PATCH] D155446: [clang][dataflow] Eliminate duplication between `AggregateStorageLocation` and `StructValue`.

xazax.hun accepted this revision. xazax.hun added a comment. I did not do a thorough review checking every line, but I read the design paper and skimmed through this patch. Love the direction, and I am OK with landing this as is. Comment at: clang/include/clang/Analysis/FlowS

[clang] e4ad1f9 - [NFC] Remove extra semicolons in clang/lib/APINotes/APINotesFormat.h

Author: Evan Wilde Date: 2023-07-21T16:19:53-07:00 New Revision: e4ad1f976d1209b8ff233e6aab924f92b7484c2d URL: https://github.com/llvm/llvm-project/commit/e4ad1f976d1209b8ff233e6aab924f92b7484c2d DIFF: https://github.com/llvm/llvm-project/commit/e4ad1f976d1209b8ff233e6aab924f92b7484c2d.diff LO

[PATCH] D105049: [NFC] Remove extra semicolons in clang/lib/APINotes/APINotesFormat.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4ad1f976d12: [NFC] Remove extra semicolons in clang/lib/APINotes/APINotesFormat.h (authored by etcwilde). Herald added a project: All. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D155847: [analyzer] Fix crash in GenericTaintChecker when propagatig taint to AllocaRegion

xazax.hun accepted this revision. xazax.hun added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155847/new/ https://reviews.llvm.org/D155847 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D155921: [clang][dataflow] Reverse course on `getValue()` deprecation.

xazax.hun accepted this revision. xazax.hun added a comment. Sounds good to me. I believe this make check author's lives easier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155921/new/ https://reviews.llvm.org/D155921 ___

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

MrTrillian marked an inline comment as done. MrTrillian added inline comments. Comment at: clang/test/Lexer/case-insensitive-include-win.c:5-9 +// Note: We must use the real path here, because the logic to detect case +// mismatch relies on resolving the real path and checking th

[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

ormris accepted this revision. ormris added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154923/new/ https://reviews.llvm.org/D154923 ___

[PATCH] D155540: [clangd] Remove extra dependancies for clangd

sammccall added a comment. In D155540#4524219 , @MaskRay wrote: > `llvm/cmake/modules/HandleLLVMOptions.cmake` passes `-Wl,-z,defs`. > `-DBUILD_SHARED_LIBS=on` builds get checking from the linker option > (https://maskray.me/blog/2021-06-13-dependency-r

[PATCH] D155540: [clangd] Remove extra dependancies for clangd

MaskRay added a comment. In D155540#4524326 , @sammccall wrote: > In D155540#4524219 , @MaskRay wrote: > >> `llvm/cmake/modules/HandleLLVMOptions.cmake` passes `-Wl,-z,defs`. >> `-DBUILD_SHARED_LIBS=on` builds ge

[PATCH] D154324: [C++20] [Modules] [ODRHash] Use CanonicalType for base classes

alexfh added a comment. In D154324#4522552 , @Hahnfeld wrote: > In D154324#4522551 , @alexfh wrote: > >> BTW, if in a.h I change >> >> typename std::enable_if<::p::P::value>::type> >> >> to >> >> typename std:

[clang-tools-extra] ab4e461 - [include-cleaner] allow spelling strategies to customize verbatim/system headers

Author: Sam McCall Date: 2023-07-22T02:36:29+02:00 New Revision: ab4e461353bb16e538aca260121533fec7e0678c URL: https://github.com/llvm/llvm-project/commit/ab4e461353bb16e538aca260121533fec7e0678c DIFF: https://github.com/llvm/llvm-project/commit/ab4e461353bb16e538aca260121533fec7e0678c.diff LO

[PATCH] D155671: [include-cleaner] allow spelling strategies to customize verbatim/system headers

This revision was automatically updated to reflect the committed changes. Closed by commit rGab4e461353bb: [include-cleaner] allow spelling strategies to customize verbatim/system headers (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D154324: [C++20] [Modules] [ODRHash] Use CanonicalType for base classes

rsmith added a comment. In D154324#4524235 , @v.g.vassilev wrote: > @rsmith, thanks for the suggestions! Could you go over > `ODRHash::AddTemplateName` suggest how to fix it to address > https://reviews.llvm.org/D153003 and https://reviews.llvm.org/D41

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

owenpan accepted this revision. owenpan added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2976-2977 +FormatToken *LBrace = FormatTok; +LBrace->setFinalizedType(TT_NamespaceLBrace); +

[clang] aa34b34 - Set default C++ level for PlayStation(r) to C++17.

Author: Sunil Srivastava Date: 2023-07-21T18:18:21-07:00 New Revision: aa34b34e93d444efec6cd894e5e55927d0e413e6 URL: https://github.com/llvm/llvm-project/commit/aa34b34e93d444efec6cd894e5e55927d0e413e6 DIFF: https://github.com/llvm/llvm-project/commit/aa34b34e93d444efec6cd894e5e55927d0e413e6.di

[clang] 9d525bf - Optimize emission of `dynamic_cast` to final classes.

Author: Richard Smith Date: 2023-07-21T19:07:59-07:00 New Revision: 9d525bf94b255df89587db955b5fa2d3c03c2c3e URL: https://github.com/llvm/llvm-project/commit/9d525bf94b255df89587db955b5fa2d3c03c2c3e DIFF: https://github.com/llvm/llvm-project/commit/9d525bf94b255df89587db955b5fa2d3c03c2c3e.diff

[PATCH] D154658: Optimize emission of `dynamic_cast` to final classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d525bf94b25: Optimize emission of `dynamic_cast` to final classes. (authored by rsmith). Changed prior to commit: https://reviews.llvm.org/D154658?vs=542693&id=543133#toc Repository: rG LLVM Github

[PATCH] D155982: Partially revert "clang/HIP: Remove __llvm_amdgcn_* wrapper hacks"

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155982/new/ https://reviews.llvm.org/D155982 ___ cfe-commits mailing list cfe-

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

jhuber6 created this revision. jhuber6 added reviewers: tra, arsenm, jlebar, kushanam, aaron.ballman, yaxunl, jdoerfert. Herald added subscribers: mattd, gchakrabarti, asavonic, jeroen.dobbelaere. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

galenelias added a comment. In D151761#4483050 , @HazardyKnusperkeks wrote: > Thanks for the patience, I'm really looking forward to use this. > > But please wait for other opinions. Thanks so much @HazardyKnusperkeks for all the feedback and help. Out

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

tra added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:1995 } - if (S.Context.getTargetInfo().getTriple().isNVPTX()) { -S.Diag(AL.getLoc(), diag::err_alias_not_supported_on_nvptx); Allowing or not `noreturn` depends on the CUDA version we'

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

tra added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:1995 } - if (S.Context.getTargetInfo().getTriple().isNVPTX()) { -S.Diag(AL.getLoc(), diag::err_alias_not_supported_on_nvptx); tra wrote: > Allowing or not `noreturn` depends on the CUD

[PATCH] D155857: [clang] fix nonnull warnings during build

MaskRay added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:773 + # Disabling this GCC warning as it is emitting a lot of false positives + append_if(CMAKE_COMPILER_IS_GNUCXX "-Wno-nonnull" CMAKE_CXX_FLAGS) Use an imperative sentence

[PATCH] D156014: [Clang][NVPTX] Permit use of the alias attribute for NVPTX targets

jhuber6 added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:1995 } - if (S.Context.getTargetInfo().getTriple().isNVPTX()) { -S.Diag(AL.getLoc(), diag::err_alias_not_supported_on_nvptx); tra wrote: > tra wrote: > > Allowing or not `noreturn`

[clang] b2f7b5d - [CodeGen] Support bitcode input containing multiple modules

Author: Fangrui Song Date: 2023-07-21T20:05:35-07:00 New Revision: b2f7b5dbaefe4f2e3f8f279735ea3509a796693f URL: https://github.com/llvm/llvm-project/commit/b2f7b5dbaefe4f2e3f8f279735ea3509a796693f DIFF: https://github.com/llvm/llvm-project/commit/b2f7b5dbaefe4f2e3f8f279735ea3509a796693f.diff

[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2f7b5dbaefe: [CodeGen] Support bitcode input containing multiple modules (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

yaxunl added a comment. In D155539#4524189 , @probinson wrote: > This change to lang-std.cpp causes it not to verify _which_ language standard > is the default. It only verifies that cuda and hip don't _change_ it. > If you run FileCheck on one of those

[clang] 2e7d711 - [clang] Add serialization support for the DynamicAllocLValue variant of APValue::LValueBase::Ptr

Author: Nathan Ridge Date: 2023-07-21T23:16:51-04:00 New Revision: 2e7d711a106170185e9bbbf15115613d9a5854c5 URL: https://github.com/llvm/llvm-project/commit/2e7d711a106170185e9bbbf15115613d9a5854c5 DIFF: https://github.com/llvm/llvm-project/commit/2e7d711a106170185e9bbbf15115613d9a5854c5.diff

[PATCH] D154471: [clang] Add serialization support for the DynamicAllocLValue variant of APValue::LValueBase::Ptr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e7d711a1061: [clang] Add serialization support for the DynamicAllocLValue variant of APValue… (authored by nridge). Repository: rG LLVM Github Mo

<    1   2   3