[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther added inline comments. Comment at: clang/test/Driver/baremetal.cpp:348 +// RUN: %clang %s -### --target=powerpc-unknown-eabi 2>&1 \ +// RUN: | FileCheck --check-prefix=CHECK-PPCEABI %s MaskRay wrote: > MaskRay wrote: > > Without a sysroot, we may pic

[PATCH] D155661: [ASTImporter] Fix friend class template import within dependent context

danix800 updated this revision to Diff 542778. danix800 added a comment. Apply git-clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155661/new/ https://reviews.llvm.org/D155661 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AS

[PATCH] D155421: [clangd] Add BlockEnd comments for control flow statements

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, this looks like in a good shape. I left comments with some thoughts and nits, but they're not blockers, feel free to land it. Comment at: clang-tools-extra/clangd/In

[PATCH] D155694: [NFC][analyzer] Enable implicit destructor for cfg-lifetime tests

tomasz-kaminski-sonarsource updated this revision to Diff 542779. tomasz-kaminski-sonarsource added a comment. Added generic FIXME comment for covering test cases for types with trivial destructor. This affects nearly all tests cases from file, so some tought needs to be put on how to apporach i

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

rsmith added a comment. This looks correct to me, but it's still a little subtle. Perhaps it'd be clearer to map the method to an integer (0 for copy assignment, 1 for move assignment, 2 for destructor, 3 for equality comparison), and then order them by that integer? That'd be more obviously a

[PATCH] D152793: [RISCV] Add MC layer support for Zicfisslp.

fakepaper56 updated this revision to Diff 542785. fakepaper56 added a comment. Make the patch only focus on Zicfiss. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 Files: clang/test/Preprocessor/riscv-

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

raghavendhra updated this revision to Diff 542786. raghavendhra added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155794/new/ https://reviews.llvm.org/D155794 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cp

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

raghavendhra updated this revision to Diff 542787. raghavendhra added a comment. Rebased patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155794/new/ https://reviews.llvm.org/D155794 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/li

[PATCH] D155381: [clangd] Allow indexing of __reserved_names outside system headers

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! I agree that this no-configuration approach is nicer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155381/new/ https://reviews.llvm.org

[PATCH] D155921: [clang][dataflow] Reverse course on `getValue()` deprecation.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the value categories RFC

[PATCH] D155922: [clang][dataflow] Eliminate `ReferenceValue`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There are no remaining uses of this class in the

[PATCH] D153946: [clangd] Add a flag to allow indexing of reserved identifiers

nridge added a comment. Yeah, I'm happy to go with D155381 instead. In D153946#4503585 , @sammccall wrote: > (Stupid over-flexible config system is too slow... I've learned my lesson > from that one!) The issues with

[PATCH] D154471: [clang] Add serialization support for the DynamicAllocLValue variant of APValue::LValueBase::Ptr

nridge updated this revision to Diff 542793. nridge added a comment. Add testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154471/new/ https://reviews.llvm.org/D154471 Files: clang/include/clang/AST/PropertiesBase.td clang/test/AST/dynami

[clang] 086ee99 - Reapply [IR] Mark and constant expressions as undesirable

Author: Nikita Popov Date: 2023-07-21T10:10:50+02:00 New Revision: 086ee99564afbb11449c08ea2e094f7f49fadde5 URL: https://github.com/llvm/llvm-project/commit/086ee99564afbb11449c08ea2e094f7f49fadde5 DIFF: https://github.com/llvm/llvm-project/commit/086ee99564afbb11449c08ea2e094f7f49fadde5.diff

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

jplehr added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1009 + std::vector getLLVMCompilerUsed() { +return static_cast &>(LLVMCompilerUsed); + } I believe that this can be simplified to ``` std::vector &getLLVMCompilerUsed() { return

[PATCH] D154471: [clang] Add serialization support for the DynamicAllocLValue variant of APValue::LValueBase::Ptr

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154471/new/ https://reviews.llvm.org/D154471 __

[PATCH] D152589: [clang-tidy] Add readability test for not allowing relative includes

ErezAmihud abandoned this revision. ErezAmihud added a comment. Closed, because I don't have time to work on it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152589/new/ https://reviews.llvm.org/D152589

[clang] f9caa12 - [Clang] Fix constraint checking of non-generic lambdas.

Author: Corentin Jabot Date: 2023-07-21T10:59:36+02:00 New Revision: f9caa12328b265b77221fe7a310d4504673d814a URL: https://github.com/llvm/llvm-project/commit/f9caa12328b265b77221fe7a310d4504673d814a DIFF: https://github.com/llvm/llvm-project/commit/f9caa12328b265b77221fe7a310d4504673d814a.diff

[PATCH] D154368: [Clang] Fix constraint checking of non-generic lambdas.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9caa12328b2: [Clang] Fix constraint checking of non-generic lambdas. (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D154368?vs=541858&id=542806#toc Repository: rG LLVM Git

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

JiruiWu added inline comments. Comment at: clang/test/CodeGen/aarch64-ABI-align-packed-assembly.c:100 struct packed_struct on_callee_stack; on_callee_stack = va_arg(vl, struct packed_struct); } chill wrote: > Can we add some `CHECK:` lines here and to othe

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

JiruiWu added a comment. Ping: @rjmccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146242/new/ https://reviews.llvm.org/D146242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D154696: [Clang] Diagnose jumps into statement expressions

cor3ntin updated this revision to Diff 542813. cor3ntin added a comment. Rebase + add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154696/new/ https://reviews.llvm.org/D154696 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/

[PATCH] D155321: [clang][Analysis] ExprMutationAnalyzer: break infinite recursion on recursive function call

danix800 updated this revision to Diff 542824. danix800 added a comment. Apply git-clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155321/new/ https://reviews.llvm.org/D155321 Files: clang-tools-extra/test/clang-tidy/checkers/readabi

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 542838. victorkingi added a comment. No changes rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://reviews.llvm.org/D155452 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D155396: [Sema][ObjC] Propagating value-dependent errors into BlockExpr

hokein added a comment. thanks! Comment at: clang/lib/Sema/SemaStmt.cpp:3736 +BlockDecl *BD = CurBlock->TheDecl; +if (!BD->isInvalidDecl() && RetValExp && RetValExp->containsErrors()) + BD->setInvalidDecl(); nit: the `isInvalidDecl` check is not ne

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta updated this revision to Diff 542846. xgupta added a comment. update test for Windows system Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155457/new/ https://reviews.llvm.org/D155457 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Se

[PATCH] D155935: [RISCV] Enable multiversion function

BeMg created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuas

[clang] 33c2e4e - [Clang] Fix access to an unitinialized variable

Author: Corentin Jabot Date: 2023-07-21T12:34:35+02:00 New Revision: 33c2e4ec7c3efb7d77df0d9f5c3f1c423aac6b0f URL: https://github.com/llvm/llvm-project/commit/33c2e4ec7c3efb7d77df0d9f5c3f1c423aac6b0f DIFF: https://github.com/llvm/llvm-project/commit/33c2e4ec7c3efb7d77df0d9f5c3f1c423aac6b0f.diff

[PATCH] D155898: [clangd] Fix go-to-type target location

usaxena95 accepted this revision. usaxena95 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/XRefs.cpp:347 +void enhanceLocatedSymbolsFromIndex( +llvm::MutableArrayRef Result, +const llvm::DenseMap &ResultIndex,

[PATCH] D154696: [Clang] Diagnose jumps into statement expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. LG! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154696/new/ https://reviews.llvm.org/D154696 ___ cfe-commits mailing list cfe-commit

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151683/new/ https://reviews.llvm.org/D151683 ___ cfe-commits mailing list cfe-comm

[PATCH] D154688: [clang] Show verify prefix in error messages

aaron.ballman added a comment. Precommit CI found relevant failures that should be addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154688/new/ https://reviews.llvm.org/D154688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. Ping for review. We'd like to get this in to LLVM 17 if possible. Please let me know if there are comments/suggestions. Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/ https://reviews.llvm.org/

[PATCH] D133843: [clangd] Prefer definitions for gototype and implementation

kadircet abandoned this revision. kadircet added a comment. abandoning in favor of D155898 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133843/new/ https://reviews.llvm.org/D133843 __

[clang-tools-extra] 209694d - [clangd] Make the order of missing-include edits deterministic

Author: Haojian Wu Date: 2023-07-21T14:16:16+02:00 New Revision: 209694ded0e06edfed11d6e67b396112dae21629 URL: https://github.com/llvm/llvm-project/commit/209694ded0e06edfed11d6e67b396112dae21629 DIFF: https://github.com/llvm/llvm-project/commit/209694ded0e06edfed11d6e67b396112dae21629.diff LO

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

w2yehia added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:440 + if (NeedsProfileRT || needsGCovInstrumentation(Args)) +CmdArgs.push_back("-lpthreads"); + The change in `compiler-rt/lib/profile/InstrProfilingFile.c` affects non-AIX platf

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

AlexVlx added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5542 + if (!getLangOpts().HIPStdPar) +ErrorUnsupported(E, "builtin function"); efriedma wrote: > AlexVlx wrote: > > efriedma wrote: > > > This doesn't make sense; we can't just igno

[PATCH] D133843: [clangd] Prefer definitions for gototype and implementation

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Yeah, having used this feature for a while, you're right about all of this of course, the current behavior is infuriating. Sorry! Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D155890: [clang-tidy] Add folly::Optional to unchecked-optional-access

ymandel added a comment. In D155890#4521266 , @carlosgalvezp wrote: > This should be a configuration option, we should not hardcore > project-specific things in the source code. I agree, but we already are hardcoding specific types -- I think this is a

[PATCH] D155921: [clang][dataflow] Reverse course on `getValue()` deprecation.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. This sounds reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155921/new/ https://reviews.llvm.org/D155921

[clang-tools-extra] 0a093f6 - [clangd] Prefer definitions for gototype and implementation

Author: Kadir Cetinkaya Date: 2023-07-21T14:38:51+02:00 New Revision: 0a093f62d15468f2b6ac4bfdc7a2dc7ba88364d0 URL: https://github.com/llvm/llvm-project/commit/0a093f62d15468f2b6ac4bfdc7a2dc7ba88364d0 DIFF: https://github.com/llvm/llvm-project/commit/0a093f62d15468f2b6ac4bfdc7a2dc7ba88364d0.dif

[PATCH] D133843: [clangd] Prefer definitions for gototype and implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a093f62d154: [clangd] Prefer definitions for gototype and implementation (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D133843?vs=460003&id=542874#toc Repository: rG LLVM

[clang] 2021910 - [Clang] Diagnose jumps into statement expressions

Author: Corentin Jabot Date: 2023-07-21T15:08:51+02:00 New Revision: 20219106060208f0c2f5d096eb3aed7b712f5067 URL: https://github.com/llvm/llvm-project/commit/20219106060208f0c2f5d096eb3aed7b712f5067 DIFF: https://github.com/llvm/llvm-project/commit/20219106060208f0c2f5d096eb3aed7b712f5067.diff

[PATCH] D154696: [Clang] Diagnose jumps into statement expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG202191060602: [Clang] Diagnose jumps into statement expressions (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] 26b19a6 - [clang][analyzer]Fix non-effective taint sanitation

Author: Daniel Krupp Date: 2023-07-21T15:11:13+02:00 New Revision: 26b19a67e5c398a30b26214544878ec364dc59af URL: https://github.com/llvm/llvm-project/commit/26b19a67e5c398a30b26214544878ec364dc59af DIFF: https://github.com/llvm/llvm-project/commit/26b19a67e5c398a30b26214544878ec364dc59af.diff

[PATCH] D155848: [clang][analyzer]Fix non-effective taint sanitation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dkrupp marked an inline comment as done. Closed by commit rG26b19a67e5c3: [clang][analyzer]Fix non-effective taint sanitation (authored by dkrupp). Herald added a proje

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

aaron.ballman added a subscriber: rjmccall. aaron.ballman added a comment. In D155175#4518366 , @cor3ntin wrote: > Remove an assert (added in a previous iteration of this PR). > > Unfortunately, we sometimes do emit the address of an immediate function, >

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn updated this revision to Diff 542893. john.brawn edited the summary of this revision. john.brawn added a comment. Restructured to check for hidden tags in the main loop. Also add a bunch of extra tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154503/new/ https://review

[PATCH] D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

gribozavr2 added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:10325 - for (const auto *FD : RD.fields()) { -// Ill-formed if the field is an ObjectiveC pointer or of a type that is -// non-trivial for the purpose of calls. -QualType FT = FD->getType(

[PATCH] D155848: [clang][analyzer]Fix non-effective taint sanitation

dkrupp updated this revision to Diff 542903. dkrupp added a comment. -formatting issues fixed -sanitizecCmd changed to void CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155848/new/ https://reviews.llvm.org/D155848 Files: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp cl

[PATCH] D155848: [clang][analyzer]Fix non-effective taint sanitation

dkrupp added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:970 - ForEachCallArg( - [&](ArgIdxTy I, const Expr *E, SVal V) { -if (PropDstArgs.contains(I)) { steakhal wrote: > dkrupp wrote: > > dkrupp wrote: >

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a temporary fix (for clang 17) that caps the size of any array we try to constant evaluate: There are 2 limits:

[PATCH] D155714: [clang] Fix diagnostics for defaulted, implicitly deleted 'operator=='.

AMP999 updated this revision to Diff 542909. AMP999 added a comment. An entry added to clang/docs/ReleaseNotes.rst Thank You for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155714/new/ https://reviews.llvm.org/D155714 Files: clang/

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 marked 2 inline comments as done. qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:440 + if (NeedsProfileRT || needsGCovInstrumentation(Args)) +CmdArgs.push_back("-lpthreads"); + w2yehia wrote: > w2yehia wrote: > >

[PATCH] D154324: [C++20] [Modules] [ODRHash] Use CanonicalType for base classes

alexfh added a comment. In D154324#4520096 , @alexfh wrote: > In D154324#4516964 , @alexfh wrote: > >> In D154324#4516917 , @ChuanqiXu >> wrote: >> >>> Maybe we got somet

[PATCH] D155714: [clang] Fix diagnostics for defaulted, implicitly deleted 'operator=='.

AMP999 added a comment. I appreciate if you take a look at another patch I sent to address the ci build failure when calling `clang/utils/ci/run-buildbot check-format` caused by some extra white spaces. https://reviews.llvm.org/D155814 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D154324: [C++20] [Modules] [ODRHash] Use CanonicalType for base classes

alexfh added a comment. In D154324#4522541 , @alexfh wrote: > In D154324#4520096 , @alexfh wrote: > >> In D154324#4516964 , @alexfh wrote: >> >>> In D154324#4516917

[PATCH] D154324: [C++20] [Modules] [ODRHash] Use CanonicalType for base classes

Hahnfeld added a comment. In D154324#4522551 , @alexfh wrote: > BTW, if in a.h I change > > typename std::enable_if<::p::P::value>::type> > > to > > typename std::enable_if::value>::type> > > Compilation succeeds. For the fun of it, could you test ht

[PATCH] D155714: [clang] Fix diagnostics for defaulted, implicitly deleted 'operator=='.

AMP999 added a comment. By the way I don't have permissions to commit so I'll send you my name and email: Name: Amirreza Ashouri Email: ar.ashouri...@gmail.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155714/new/ https://reviews.llvm.org/D155

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

cor3ntin added a comment. > Should we be marking the init expression/declaration as invalid to force > codegen not to run on the expression? So it's not removing the init, but is > marking the declaration its attached to as invalid. We should remove the init from the declaration entirely, the t

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 542916. sstwcw added a comment. - Add comment explaining the replacements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files: clang/docs/ClangFormatStyleOptions.r

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Changes LGTM as-is, I'm okay with tracking the assertion question separately. Please give @Fznamznon a chance to check that her concerns have all been addressed before landing.

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

MrTrillian updated this revision to Diff 542922. MrTrillian retitled this revision from "[lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations" to "[lit][clang] Avoid realpath on Windows due to MAX_PATH limitations". MrTrillian edited the summary of this revision. CHANGES SINCE LAS

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

MrTrillian added a comment. In D154130#4516226 , @tahonermann wrote: > It is unclear to me why/when we would ever want the substitute drive > expansion; the modified tests aren't very elucidating. My naive expectation > is that we effectively want to r

[PATCH] D155396: [Sema][ObjC] Propagating value-dependent errors into BlockExpr

danix800 added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3736 +BlockDecl *BD = CurBlock->TheDecl; +if (!BD->isInvalidDecl() && RetValExp && RetValExp->containsErrors()) + BD->setInvalidDecl(); hokein wrote: > nit: the `isInvalidDecl` c

[PATCH] D155396: [Sema][ObjC] Propagating value-dependent errors into BlockExpr

danix800 added inline comments. Comment at: clang/test/SemaObjC/crash-on-val-dep-block-expr.m:1 +// RUN: %clang_cc1 -fblocks -fsyntax-only -verify %s +// no crash danix800 wrote: > hokein wrote: > > can you move these tests to > > `llvm-project/clang/test/AST/as

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta added a comment. Just normal ping, @aaron.ballman, can please take a look, pre-merge checks are also passing now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155457/new/ https://reviews.llvm.org/D155457 __

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

yaxunl added a comment. Since we need to support -O0, we need to be prepared that we may not be able to remove all the calls of unsupported functions even though they may never be called at run time. We could simply replace them with traps in the middle end. This should work if such functions

[PATCH] D155396: [Sema][ObjC] Propagating value-dependent errors into BlockExpr

danix800 updated this revision to Diff 542950. danix800 added a comment. 1. Remove unnecessary condition & cleanup code 2. Move testcase into correct place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155396/new/ https://reviews.llvm.org/D155396

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet added a comment. In D155064#4514893 , @cor3ntin wrote: > This looks good to me modulo nitpicks. > When you land that, please make an issue on github for the missing narrowing > warning, it seems important. > > I'll wait before approving in cas

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

AlexVlx added a comment. @yaxunl interesting point - are you worried about cases where due to missing inlining / const prop an indirect call site that can be replaced with a direct one would remain indirect? I think the problem in that case would actually be different, in that possibly reachabl

[PATCH] D155848: [clang][analyzer]Fix non-effective taint sanitation

steakhal added a comment. Thanks, all good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155848/new/ https://reviews.llvm.org/D155848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] 0517a9c - clang/Debian: add Debian Trixie now that it is in unstable

Author: Sylvestre Ledru Date: 2023-07-21T18:23:14+02:00 New Revision: 0517a9cae90fafbc36267a81df40ce4eef73eb30 URL: https://github.com/llvm/llvm-project/commit/0517a9cae90fafbc36267a81df40ce4eef73eb30 DIFF: https://github.com/llvm/llvm-project/commit/0517a9cae90fafbc36267a81df40ce4eef73eb30.dif

[PATCH] D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1.

AMP999 updated this revision to Diff 542972. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155814/new/ https://reviews.llvm.org/D155814 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp Index: clang/lib/Analysis/UnsafeBufferUsage.cpp

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. Cool, looks like the libc++ presubmit tests have already spotted some unintended changes. Will root cause+fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151587/n

[PATCH] D148654: Modify BoundsSan to improve debuggability

oskarwirga added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148654/new/ https://reviews.llvm.org/D148654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

aaron.ballman added a comment. In D155457#4513812 , @xgupta wrote: > In D155457#4511652 , @aaron.ballman > wrote: > >> In the x86 compilation: `sizeof(std::size_t) < sizeof(uint64_t)` is true, so >> we test the

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

nickdesaulniers added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8384-8385 const MaterializeTemporaryExpr *E) { + if (Info.EvalMode == EvalInfo::EM_ConstantFold) +return false; + removing these two lines fixes the following regressions:

[PATCH] D155890: [clang-tidy] Add folly::Optional to unchecked-optional-access

adukeman added a comment. In D155890#4522266 , @ymandel wrote: > In D155890#4521266 , @carlosgalvezp > wrote: > >> This should be a configuration option, we should not hardcore >> project-specific things in the

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

nickdesaulniers added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8384-8385 const MaterializeTemporaryExpr *E) { + if (Info.EvalMode == EvalInfo::EM_ConstantFold) +return false; + nickdesaulniers wrote: > removing these two lines fixes t

[clang] b0bb68f - [test] Unsupport CodeGenCXX/destructors for LLVM_ENABLE_REVERSE_ITERATION builds

Author: Fangrui Song Date: 2023-07-21T10:28:52-07:00 New Revision: b0bb68fd3cb7bfbaf669d25f3149e24638cfb179 URL: https://github.com/llvm/llvm-project/commit/b0bb68fd3cb7bfbaf669d25f3149e24638cfb179 DIFF: https://github.com/llvm/llvm-project/commit/b0bb68fd3cb7bfbaf669d25f3149e24638cfb179.diff

[PATCH] D155890: [clang-tidy] Add folly::Optional to unchecked-optional-access

ymandel added a comment. In D155890#4523243 , @adukeman wrote: > In D155890#4522266 , @ymandel wrote: > >> In D155890#4521266 , >> @carlosgalvezp wrote: >> >>> This shoul

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

efriedma added a comment. > In what regards how to do deferred diagnostics, it think it can be done like > this (I crossed streams in my prior reply when discussing this part, so it's > actually nonsense): instead of emitting undef here, we can emit a builtin > with the same signature, but with

[PATCH] D155890: [clang-tidy] Add folly::Optional to unchecked-optional-access

gribozavr2 added a comment. In D155890#4523243 , @adukeman wrote: > In D155890#4522266 , @ymandel wrote: > >> In D155890#4521266 , >> @carlosgalvezp wrote: >> >>> This sh

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

yaxunl added a comment. In D155850#4523051 , @AlexVlx wrote: > @yaxunl interesting point - are you worried about cases where due to missing > inlining / const prop an indirect call site that can be replaced with a > direct one would remain indirect? I t

[PATCH] D155982: Partially revert "clang/HIP: Remove __llvm_amdgcn_* wrapper hacks"

arsenm created this revision. arsenm added a reviewer: yaxunl. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. Revert part of f407a7399575a6821940973c54754d42e72dd9ce .

[PATCH] D155890: [clang-tidy] Add folly::Optional to unchecked-optional-access

carlosgalvezp added a comment. In D155890#4523262 , @gribozavr2 wrote: > In D155890#4523243 , @adukeman > wrote: > >> In D155890#4522266 , @ymandel >> wrote: >> >>> In

[PATCH] D155890: [clang-tidy] Add folly::Optional to unchecked-optional-access

carlosgalvezp resigned from this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. > I think it'd be good to add reviewers there I realize the CodeOwners for Analysis are already in the list of reviewers, I won't interfere then :) Repository: rG LLVM G

[PATCH] D155982: Partially revert "clang/HIP: Remove __llvm_amdgcn_* wrapper hacks"

yaxunl added inline comments. Comment at: clang/lib/Headers/__clang_hip_libdevice_declares.h:319 +// relevant. +__device__ inline _Float16 __llvm_amdgcn_rcp_f16(_Float16 x) { + return ((_Float16)1.0f) / x; Can we add the deprecated attribute to urge people not t

[PATCH] D155982: Partially revert "clang/HIP: Remove __llvm_amdgcn_* wrapper hacks"

arsenm added inline comments. Comment at: clang/lib/Headers/__clang_hip_libdevice_declares.h:319 +// relevant. +__device__ inline _Float16 __llvm_amdgcn_rcp_f16(_Float16 x) { + return ((_Float16)1.0f) / x; yaxunl wrote: > Can we add the deprecated attribute to u

[PATCH] D155982: Partially revert "clang/HIP: Remove __llvm_amdgcn_* wrapper hacks"

arsenm added inline comments. Comment at: clang/lib/Headers/__clang_hip_libdevice_declares.h:319 +// relevant. +__device__ inline _Float16 __llvm_amdgcn_rcp_f16(_Float16 x) { + return ((_Float16)1.0f) / x; arsenm wrote: > yaxunl wrote: > > Can we add the depreca

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 542990. nickdesaulniers added a comment. - restore E->getStorageDuration() == SD_Static check to fix libcxx regressions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151587/new/ https://reviews.llvm.org

[PATCH] D155890: [clang-tidy] Add folly::Optional to unchecked-optional-access

gribozavr2 added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:62 +return N != nullptr && (isTopLevelNamespaceWithName(*N, "base") || +isTopLevelNamespaceWithName(*N, "folly")); }

[PATCH] D155984: [Sema][ObjC] Invalidate BlockDecl with invalid ParmVarDecl

danix800 created this revision. danix800 added reviewers: hokein, aaron.ballman. danix800 added a project: clang. Herald added a subscriber: kristof.beyls. Herald added a project: All. danix800 requested review of this revision. Herald added a subscriber: cfe-commits. `BlockDecl` should be invalid

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

raghavendhra marked 2 inline comments as done. raghavendhra added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4914 + GVMode->setVisibility(llvm::GlobalVariable::ProtectedVisibility); + assert(!GVMode->isDeclaration() && + "Only globals with de

[PATCH] D155985: [clang][ASTDumper] Remove redundant dump of ParmVarDecl

danix800 created this revision. danix800 added reviewers: hokein, aaron.ballman. danix800 added a project: clang. Herald added a subscriber: kristof.beyls. Herald added a project: All. danix800 requested review of this revision. Herald added a subscriber: cfe-commits. `ParmVarDecl` of `BlockDecl`

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

cor3ntin added a comment. I'm not sure I understand the motivation for this change. Sure, people do that but they also might do the same thing for ssize_t, intmax_t, or to compare int to int32_t. I think a better heuristic would be to not emit a warning for any integral (and floating point?) ty

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

raghavendhra updated this revision to Diff 542999. raghavendhra added a comment. Addressed JP's review comments and rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155794/new/ https://reviews.llvm.org/D155794 Files: clang/lib/CodeGen/CGOp

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 543000. capfredf added a comment. changes per @v.g.vassilev's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files: clang/include/clang/Interpreter/CodeC

[PATCH] D155544: [AIX][TLS] Add -maix-small-local-exec-tls option.

DiggerLin added inline comments. Comment at: llvm/test/CodeGen/PowerPC/check-aix-small-local-exec-tls-opt.ll:15 + +; Make sure that the test was actually compiled successfully after using the +; -maix-small-local-exec-tls option. since the patch only add a new op

  1   2   3   >