[PATCH] D155335: This fixes an issue with 245d10b7a2c12ec25e7b5860a38c61991543a739, where on slightly older versions of clang, we get the below error and several others similar.

saugustine created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. saugustine requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In file included from .../clang/lib/AST/Interp/Source.h:17: In file included fro

[PATCH] D155336: [clang][JumpDiagnostics] bring VerifyIndirectOrAsmJumps to C++17

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update the code to more modern C++ style. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

MrTrillian added a comment. I would appreciate help with moving this code review forwards. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154130/new/ https://reviews.llvm.org/D154130 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D155335: Replace forward-declarations with proper headers for Decl and Stmt

saugustine updated this revision to Diff 540552. saugustine added a comment. Switch to pure revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155335/new/ https://reviews.llvm.org/D155335 Files: clang/lib/AST/Interp/Source.h Index: clang/li

[clang] b9543f7 - Revert "[clang][Interp][NFC] Trim Source.h includes"

Author: Sterling Augustine Date: 2023-07-14T13:34:26-07:00 New Revision: b9543f7de69770a97e983452c5158acc3b4783c7 URL: https://github.com/llvm/llvm-project/commit/b9543f7de69770a97e983452c5158acc3b4783c7 DIFF: https://github.com/llvm/llvm-project/commit/b9543f7de69770a97e983452c5158acc3b4783c7.

[PATCH] D155335: Revert 245d10b7a2c12ec25e7b5860a38c61991543a739

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9543f7de697: Revert "[clang][Interp][NFC] Trim Source.h includes"

[PATCH] D155337: [CMake] Include riscv32-unknown-elf target in Fuchsia toolchain

phosek created this revision. Herald added subscribers: ekilmer, VincentWu, abrachet, vkmr, sameer.abuasal, s.egerton, Jim, benna, psnobl, abidh, rogfer01, shiva0217, kito-cheng, simoncook, asb, arichardson. Herald added a project: All. phosek requested review of this revision. Herald added subsc

[PATCH] D155336: [clang][JumpDiagnostics] bring VerifyIndirectOrAsmJumps to C++17

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155336/new/ https://reviews.llvm.org/D155336

[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

MaskRay added a comment. In D154923#4491673 , @MaskRay wrote: > In D154923#4491411 , @efriedma > wrote: > >> If I follow correctly, this is basically undoing the splitting that was done >> by the command that pr

[clang] 5b8b9b3 - Revert "[UTC] Adapt version matcher to glob CLANG_VENDOR"

Author: Johannes Doerfert Date: 2023-07-14T13:53:36-07:00 New Revision: 5b8b9b39ccd06989b722f8d0adad0aa4da6d7d72 URL: https://github.com/llvm/llvm-project/commit/5b8b9b39ccd06989b722f8d0adad0aa4da6d7d72 DIFF: https://github.com/llvm/llvm-project/commit/5b8b9b39ccd06989b722f8d0adad0aa4da6d7d72.d

[clang] b9f1df7 - Revert "[UTC] Add fallback support for specific metadata, and check their defs"

Author: Johannes Doerfert Date: 2023-07-14T13:53:37-07:00 New Revision: b9f1df7a04d7a3169623e437597aa4b32d99d8b3 URL: https://github.com/llvm/llvm-project/commit/b9f1df7a04d7a3169623e437597aa4b32d99d8b3 DIFF: https://github.com/llvm/llvm-project/commit/b9f1df7a04d7a3169623e437597aa4b32d99d8b3.d

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 540559. paulkirth marked an inline comment as done. paulkirth edited the summary of this revision. paulkirth added a comment. Revise tests + update summary - Add driver tests for -S - Add codegen tests for -S - Test Unified LTO codegen - Use -fdriver-only t

[PATCH] D154123: [HIP] Start document HIP support by clang

keryell added inline comments. Comment at: clang/docs/HIPSupport.rst:24 + +Clang supports HIP on `ROCm platform `_. + I thought the idea of HIP was to also target Nvidia GPU? Otherwise I do not understand "portable applicat

[PATCH] D155336: [clang][JumpDiagnostics] bring VerifyIndirectOrAsmJumps to C++17

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:740-741 unsigned IGScope = LabelAndGotoScopes[IG]; Stmt *&Entry = JumpScopesMap[IGScope]; if (!Entry) Entry = IG; } --

[PATCH] D155336: [clang][JumpDiagnostics] bring VerifyIndirectOrAsmJumps to C++17

nickdesaulniers updated this revision to Diff 540561. nickdesaulniers added a comment. This revision is now accepted and ready to land. - better identifiers, use llvm::DenseMap::contains Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155336/new/ htt

[PATCH] D154123: [HIP] Start document HIP support by clang

keryell added inline comments. Comment at: clang/docs/HIPSupport.rst:24 + +Clang supports HIP on `ROCm platform `_. + keryell wrote: > I thought the idea of HIP was to also target Nvidia GPU? Otherwise I do not > understand

[PATCH] D155294: [Driver][RISCV] Find baremetal multilibs using YAML for GNU toolchain

michaelplatings added a comment. Hi Joe, it's nice to see multilib.yaml getting some adoption :) > For the RISCVMultilibFlags, the mabi flag is used in combination with all the > march extension features (e.g +m). Notably, this doesn't align with the > current arm/aarch64 multilib flags, which

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.h:231 /// Used e.g. to break like: + /// \code /// functionCall(Parameter, otherCall( Unrelated. Comment at: clang/lib/Format/ContinuationIndenter.h:234

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

tahonermann added a comment. >> In D154130#4486898 , @tahonermann >> wrote: >> >>> 95% of the %>t are around clang modulemap files, because that code resolves >>> real paths in C++ by design, so I can't avoid it. >> >> Can you link to evidence that this

[clang] 5b012bf - [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

Author: ziqingluo-90 Date: 2023-07-14T14:47:07-07:00 New Revision: 5b012bf5ab5fcb840fe7f6c8664b8981ce6f24f3 URL: https://github.com/llvm/llvm-project/commit/5b012bf5ab5fcb840fe7f6c8664b8981ce6f24f3 DIFF: https://github.com/llvm/llvm-project/commit/5b012bf5ab5fcb840fe7f6c8664b8981ce6f24f3.diff

[PATCH] D150338: [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b012bf5ab5f: [-Wunsafe-buffer-usage] Improving insertion of the [[clang… (authored by ziqingluo-90). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D155339: Enable zba and zbs for riscv android

hiraditya created this revision. hiraditya added reviewers: enh, pirama, srhines. Herald added subscribers: luke, VincentWu, danielkiss, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

benlangmuir added a comment. > I took a look at the code and it looks to me like it would be safe to change > ModuleMap::canonicalizeModuleMapPath() to use a drive preserving > canonicalization This sounds reasonable to me (the person who added canonicalizeModuleMapPath), though I am not at al

[PATCH] D153623: [clang][Sema] Add fixit for scoped enum format error

cjdb added a comment. Sorry, forgot to come back and LGTM, but it did indeed LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153623/new/ https://reviews.llvm.org/D153623 ___ cfe-commits mailing list

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Otherwise we observe false positive warnings claiming that an asm goto cannot jump to another label in a dif

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers updated this revision to Diff 540574. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - add link to CBL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155342/new/ https://reviews.llvm.org/D155342

[clang] 9115f18 - [clang][JumpDiagnostics] bring VerifyIndirectOrAsmJumps to C++17

Author: Nick Desaulniers Date: 2023-07-14T15:20:08-07:00 New Revision: 9115f18de90611d42147838e53bd8e37f206b744 URL: https://github.com/llvm/llvm-project/commit/9115f18de90611d42147838e53bd8e37f206b744 DIFF: https://github.com/llvm/llvm-project/commit/9115f18de90611d42147838e53bd8e37f206b744.di

[PATCH] D155336: [clang][JumpDiagnostics] bring VerifyIndirectOrAsmJumps to C++17

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9115f18de906: [clang][JumpDiagnostics] bring VerifyIndirectOrAsmJumps to C++17 (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers updated this revision to Diff 540584. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155342/new/ https://reviews.llvm.org/D155342 Files: clang/lib/Sema/JumpDiagnostics.cpp clang/test/Sem

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers updated this revision to Diff 540585. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - reword description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155342/new/ https://reviews.llvm.org/D155

[clang] bac2a07 - clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

Author: Matt Arsenault Date: 2023-07-14T18:46:18-04:00 New Revision: bac2a075408377a8aa41f6626b17bb3e471221f3 URL: https://github.com/llvm/llvm-project/commit/bac2a075408377a8aa41f6626b17bb3e471221f3 DIFF: https://github.com/llvm/llvm-project/commit/bac2a075408377a8aa41f6626b17bb3e471221f3.diff

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers updated this revision to Diff 540586. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - reword commit msg one more time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155342/new/ https://reviews.

[PATCH] D154495: clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

arsenm closed this revision. arsenm added a comment. bac2a075408377a8aa41f6626b17bb3e471221f3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154495/new/ https://reviews.llvm.org/D154495 __

[PATCH] D154675: [Clang] Fix crash when emitting diagnostic for out of order designated initializers in C++

shafik updated this revision to Diff 540587. shafik marked 2 inline comments as done. shafik added a comment. - Add release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154675/new/ https://reviews.llvm.org/D154675 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaInit.c

[clang] c9ef33e - [Clang] Fix crash when emitting diagnostic for out of order designated initializers in C++

Author: Shafik Yaghmour Date: 2023-07-14T15:57:51-07:00 New Revision: c9ef33e1d8a8aeb68a18f24af6d9fc9ab4ecf257 URL: https://github.com/llvm/llvm-project/commit/c9ef33e1d8a8aeb68a18f24af6d9fc9ab4ecf257 DIFF: https://github.com/llvm/llvm-project/commit/c9ef33e1d8a8aeb68a18f24af6d9fc9ab4ecf257.dif

[PATCH] D154675: [Clang] Fix crash when emitting diagnostic for out of order designated initializers in C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9ef33e1d8a8: [Clang] Fix crash when emitting diagnostic for out of order designated… (authored by shafik). Herald added a project: clang. Repositor

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

jyu2 accepted this revision. jyu2 added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155342/new/ https://reviews.llvm.org/D155342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

jyu2 added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:794 + // [-Wc++20-extensions] + LabelDecl *TL = TargetLabel; + // Is TargetLabel one of the targets of the JumpStmt? If not, then skip Just wonder why not just use TargetLab

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:56 def BPFNoALU32 : Predicate<"!Subtarget->getHasAlu32()">; +def BPFHasCPUv4_ldsx : Predicate<"Subtarget->getCPUv4_ldsx()">; +def BPFHasCPUv4_movsx : Predicate<"Subtarget->getCPUv4_movsx()">; --

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

hubert.reinterpretcast added inline comments. Comment at: clang/docs/ReleaseNotes.rst:136-139 +- Implemented `P2169R4: A nice placeholder with no name `_. This allows using `_` + as a variable name multiple times in the same scope and is supported in

[clang] 232ce90 - [OpenMP][FIX] Adjust "known" attributes for runtime functions

Author: Johannes Doerfert Date: 2023-07-14T17:01:48-07:00 New Revision: 232ce90541fe1bd1aa96319b36d8fe5b5344a52b URL: https://github.com/llvm/llvm-project/commit/232ce90541fe1bd1aa96319b36d8fe5b5344a52b DIFF: https://github.com/llvm/llvm-project/commit/232ce90541fe1bd1aa96319b36d8fe5b5344a52b.d

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt updated this revision to Diff 540600. RIscRIpt marked 17 inline comments as done. RIscRIpt added a comment. Addressed review comments, rebased onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153914/new/ https://reviews.llvm.org/D1

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.h:87-93 +/// Return true if this token is a predefined macro +/// unexpandable by MSVC preprocessor. +inline bool isUnexpandableMsMacro(TokenKind K) { + return K == tok::kw___FUNCTION__ || K == tok:

[PATCH] D155337: [CMake] Include riscv32-unknown-elf target in Fuchsia toolchain

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. It would be a better summary to say "include ... runtimes ...". Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:10 set(_FUCHSIA_ENABLE_PROJECTS "bolt;clang;clang-too

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 540611. sstwcw edited the summary of this revision. sstwcw added a comment. - Add back the const qualifiers for methods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093

[clang] 143e2c2 - [RISCV] Split clmul/clmulh/clmulr builtins into _32 and _64 versions.

Author: Craig Topper Date: 2023-07-14T19:09:15-07:00 New Revision: 143e2c2ac03cbcce290a9f14b0d667bf0f793280 URL: https://github.com/llvm/llvm-project/commit/143e2c2ac03cbcce290a9f14b0d667bf0f793280 DIFF: https://github.com/llvm/llvm-project/commit/143e2c2ac03cbcce290a9f14b0d667bf0f793280.diff

[PATCH] D154646: Fix some typos in comments: evalute -> evaluate (NFC)

SuperSodaSea updated this revision to Diff 540621. SuperSodaSea retitled this revision from "Fix some typos in comments: evalute -> evaluate" to "Fix some typos in comments: evalute -> evaluate (NFC)". SuperSodaSea added a comment. Update patch CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D154186: [clang][DeclPrinter] Fix AST print of delegating constructors

strimo378 updated this revision to Diff 540627. strimo378 added a comment. Updated test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154186/new/ https://reviews.llvm.org/D154186 Files: clang/lib/AST/DeclPrinter.cpp clang/test/AST/ast-pri

[clang] c915908 - Revert D150338, "[-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute"

Author: NAKAMURA Takumi Date: 2023-07-15T13:55:11+09:00 New Revision: c915908f6d6946151b17eae00c7f093e6f37c677 URL: https://github.com/llvm/llvm-project/commit/c915908f6d6946151b17eae00c7f093e6f37c677 DIFF: https://github.com/llvm/llvm-project/commit/c915908f6d6946151b17eae00c7f093e6f37c677.dif

[clang] ba7273b - Reformat

Author: NAKAMURA Takumi Date: 2023-07-15T13:55:11+09:00 New Revision: ba7273b02577236fbbca53554bafc6c22d7dd4c9 URL: https://github.com/llvm/llvm-project/commit/ba7273b02577236fbbca53554bafc6c22d7dd4c9 DIFF: https://github.com/llvm/llvm-project/commit/ba7273b02577236fbbca53554bafc6c22d7dd4c9.dif

[PATCH] D150338: [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

chapuni reopened this revision. chapuni added a comment. This revision is now accepted and ready to land. Excuse me, I have reverted this due to circular deps. `clangAnalysis` should not depend on `clangSema`. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.

[PATCH] D155356: [clang][Interp] Implement __builtin_nan family of functions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. One existing problem is that we can't do much with the

[PATCH] D154616: [RISCV] Use unsigned instead of signed types for Zk* and Zb* builtins.

VincentWu accepted this revision. VincentWu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154616/new/ https://reviews.llvm.org/D154616 _

<    1   2