[PATCH] D123971: [clang][PS4] Enable SplitLTOUnits by default

ormris added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123971/new/ https://reviews.llvm.org/D123971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] 3a6a070 - [clang-format] Add an option to remove redundant parentheses

Author: Owen Pan Date: 2023-07-11T16:33:19-07:00 New Revision: 3a6a0702c2a4c2290f0b55b0451a9f97d7592baf URL: https://github.com/llvm/llvm-project/commit/3a6a0702c2a4c2290f0b55b0451a9f97d7592baf DIFF: https://github.com/llvm/llvm-project/commit/3a6a0702c2a4c2290f0b55b0451a9f97d7592baf.diff LOG:

[PATCH] D154484: [clang-format] Add an option to remove redundant parentheses

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a6a0702c2a4: [clang-format] Add an option to remove redundant parentheses (authored by owenpan). Changed prior to commit: https://reviews.llvm.or

[PATCH] D151730: [RISCV] Support target attribute for function

reames added a comment. FYI, this change appears to be a partial diff. Locally, I need to add RISCV to supportsMultiVersioning() to get this to work at all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D15173

[PATCH] D151730: [RISCV] Support target attribute for function

jrtc27 added a comment. Isn't multiversioning a separate thing that builds on top of per-function target attributes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 __

[PATCH] D151730: [RISCV] Support target attribute for function

craig.topper added a comment. In D151730#4491773 , @jrtc27 wrote: > Isn't multiversioning a separate thing that builds on top of per-function > target attributes? That's what I thought. The supportsMultiVersioning call was in an earlier version of the

[clang] fd2254b - clang: Update test for strict minnum/maxnum fix

Author: Matt Arsenault Date: 2023-07-11T19:51:38-04:00 New Revision: fd2254b7358d0f78a79784688bd8012c1a52b9cf URL: https://github.com/llvm/llvm-project/commit/fd2254b7358d0f78a79784688bd8012c1a52b9cf DIFF: https://github.com/llvm/llvm-project/commit/fd2254b7358d0f78a79784688bd8012c1a52b9cf.diff

[clang] b10899d - [clang] Fix -Wlogical-op-parentheses in Clang.cpp (NFC)

Author: Jie Fu Date: 2023-07-12T07:53:50+08:00 New Revision: b10899d869954e1426684cbc20a43d7303075d49 URL: https://github.com/llvm/llvm-project/commit/b10899d869954e1426684cbc20a43d7303075d49 DIFF: https://github.com/llvm/llvm-project/commit/b10899d869954e1426684cbc20a43d7303075d49.diff LOG: [

[clang] 875b881 - [clang-format][NFC] Remove redundant parentheses in the source code

Author: Owen Pan Date: 2023-07-11T17:05:00-07:00 New Revision: 875b881186c4eb146e77e76ad72ee0a356d7c69f URL: https://github.com/llvm/llvm-project/commit/875b881186c4eb146e77e76ad72ee0a356d7c69f DIFF: https://github.com/llvm/llvm-project/commit/875b881186c4eb146e77e76ad72ee0a356d7c69f.diff LOG:

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 539346. paulkirth added a comment. Rebase and try to accomodate Unified LTO changes. Based on the Unified LTO patches, I think this is the correct handling for FatLTO, but I'd like to get a second opinion before landing this. CC: @ormris Repository: rG

[PATCH] D146777: [clang] Preliminary fat-lto-object support

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:623 +if (Args.hasArg(options::OPT_ffat_lto_objects)) + CmdArgs.push_back("-fat-lto-objects"); } New lld long options only allow `--` form. So use two dashes. Repos

[PATCH] D145302: [clangd] Add library for clangd main function

glandium added a comment. This broke building with `-DLLVM_LINK_LLVM_DYLIB=ON`: /usr/bin/ld: tools/clang/tools/extra/clangd/refactor/tweaks/CMakeFiles/obj.clangDaemonTweaks.dir/AddUsing.cpp.o: in function `clang::clangd::(anonymous namespace)::AddUsing::prepare(clang::clangd::Tweak::Selectio

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

shafik added inline comments. Comment at: clang/test/SemaCXX/static-assert-cxx26.cpp:167 +static_assert(false, MessageInvalidSize{}); // expected-error {{static assertion failed}} \ + // expected-error {{the message in a static_asser

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

shafik added inline comments. Comment at: clang/test/SemaCXX/static-assert-cxx26.cpp:1 +// RUN: %clang_cc1 -std=c++2c -fsyntax-only %s -verify + How about a test case w/ `data()` and or `size()` has default arguments. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D154822: [clang] Support '-fgpu-default-stream=per-thread' for NVIDIA CUDA

boxu-zhang added a comment. I don't have the permission to push to main branch. Can anyone push this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154822/new/ https://reviews.llvm.org/D154822 ___ cfe-co

[PATCH] D154701: [clang] Overridden CXXMethodDecl::isVirtual() assertion failed before fully imported.

danix800 added inline comments. Comment at: clang/test/Analysis/ctu-astimport-virtual-assertion/main.cpp:22 + +#include "Inputs/input.h" balazske wrote: > Such tests are not in the //Analysis// folder but in the //ASTMerge// folder > instead. I would say that th

[PATCH] D143241: [Clang] Reset FP options before function instantiations

thesamesam added a comment. During our regular snapshot testing, we've hit this in Gentoo on 32-bit Linux x86: https://github.com/llvm/llvm-project/issues/63704#issuecomment-1631791518. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143241/new/ htt

[PATCH] D154935: [clang][dataflow] Introduce `getFieldValue()` test helpers.

mboehme updated this revision to Diff 539365. mboehme added a comment. Changes in response to review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154935/new/ https://reviews.llvm.org/D154935 Files: clang/unittests/Analysis/FlowSensitiv

[PATCH] D154965: [clang][dataflow] Fix initializing a reference field with an `InitListExpr`.

mboehme updated this revision to Diff 539366. mboehme added a comment. Changes in response to review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154965/new/ https://reviews.llvm.org/D154965 Files: clang/lib/Analysis/FlowSensitive/Tran

[clang] 2902ea3 - [clang][dataflow] Introduce `getFieldValue()` test helpers.

Author: Martin Braenne Date: 2023-07-12T04:52:23Z New Revision: 2902ea3d817bf381817ff76228c3212f4dc87d47 URL: https://github.com/llvm/llvm-project/commit/2902ea3d817bf381817ff76228c3212f4dc87d47 DIFF: https://github.com/llvm/llvm-project/commit/2902ea3d817bf381817ff76228c3212f4dc87d47.diff LOG

[clang] 103a0fc - [clang][dataflow] Use `getFieldValue()` in TransferTest.cpp.

Author: Martin Braenne Date: 2023-07-12T04:52:25Z New Revision: 103a0fc0846050dd671e6485ab52491042f905c6 URL: https://github.com/llvm/llvm-project/commit/103a0fc0846050dd671e6485ab52491042f905c6 DIFF: https://github.com/llvm/llvm-project/commit/103a0fc0846050dd671e6485ab52491042f905c6.diff LOG

[clang] 0014aab - [clang][dataflow] Use `IntegerValue` instead of `StructValue` in `ValueTest`.

Author: Martin Braenne Date: 2023-07-12T04:52:22Z New Revision: 0014aab2d5882525c23130108e17fbbb5a2120f1 URL: https://github.com/llvm/llvm-project/commit/0014aab2d5882525c23130108e17fbbb5a2120f1 DIFF: https://github.com/llvm/llvm-project/commit/0014aab2d5882525c23130108e17fbbb5a2120f1.diff LOG

[clang] 1e9b4fc - [clang][dataflow] Various refactorings in TypeErasedDataflowAnalysisTest.cpp

Author: Martin Braenne Date: 2023-07-12T04:52:27Z New Revision: 1e9b4fc1dcf27ae43477efe0329f738e4419871b URL: https://github.com/llvm/llvm-project/commit/1e9b4fc1dcf27ae43477efe0329f738e4419871b DIFF: https://github.com/llvm/llvm-project/commit/1e9b4fc1dcf27ae43477efe0329f738e4419871b.diff LOG

[clang] b47bdcb - [clang][dataflow] Include fields initialized in an `InitListExpr` in `getModeledFields()`.

Author: Martin Braenne Date: 2023-07-12T04:52:29Z New Revision: b47bdcbc7207aac617d3c35dfc029f79b0a46fd8 URL: https://github.com/llvm/llvm-project/commit/b47bdcbc7207aac617d3c35dfc029f79b0a46fd8 DIFF: https://github.com/llvm/llvm-project/commit/b47bdcbc7207aac617d3c35dfc029f79b0a46fd8.diff LOG

[clang] bd9b57d - [clang][dataflow] Fix initializing a reference field with an `InitListExpr`.

Author: Martin Braenne Date: 2023-07-12T04:52:30Z New Revision: bd9b57de4ff7c65be0d69179232ba2d5fe832195 URL: https://github.com/llvm/llvm-project/commit/bd9b57de4ff7c65be0d69179232ba2d5fe832195 DIFF: https://github.com/llvm/llvm-project/commit/bd9b57de4ff7c65be0d69179232ba2d5fe832195.diff LOG

[PATCH] D154934: [clang][dataflow] Use `IntegerValue` instead of `StructValue` in `ValueTest`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0014aab2d588: [clang][dataflow] Use `IntegerValue` instead of `StructValue` in `ValueTest`. (authored by mboehme). Repository: rG LLVM Github Mono

[PATCH] D154935: [clang][dataflow] Introduce `getFieldValue()` test helpers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2902ea3d817b: [clang][dataflow] Introduce `getFieldValue()` test helpers. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D154949: [clang][dataflow] Use `getFieldValue()` in TransferTest.cpp.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG103a0fc08460: [clang][dataflow] Use `getFieldValue()` in TransferTest.cpp. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D154952: [clang][dataflow] Various refactorings in TypeErasedDataflowAnalysisTest.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e9b4fc1dcf2: [clang][dataflow] Various refactorings in TypeErasedDataflowAnalysisTest.cpp (authored by mboehme). Repository: rG LLVM Github Monor

[PATCH] D154961: [clang][dataflow] Include fields initialized in an `InitListExpr` in `getModeledFields()`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb47bdcbc7207: [clang][dataflow] Include fields initialized in an `InitListExpr` in… (authored by mboehme). Repository: rG LLVM Github Monorepo CH

[PATCH] D154965: [clang][dataflow] Fix initializing a reference field with an `InitListExpr`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd9b57de4ff7: [clang][dataflow] Fix initializing a reference field with an `InitListExpr`. (authored by mboehme). Repository: rG LLVM Github Monor

[PATCH] D153701: [WIP][Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8901-8914 + // [P2718R0] Lifetime extension in range-based for loops. + // + // 6.7.7 [class.temporary] p5: + // There are four contexts in which temporaries are destroyed at a different

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 539378. xgupta retitled this revision from "[clang-tidy] Add check for possibly incomplete switch statements " to "[clang-tidy] Add check for possibly incomplete switch statements". xgupta added a reviewer: PiotrZSL. xgupta added a comment. Herald added a revie

[clang] fa68972 - [dataflow] document flow condition

Author: Sam McCall Date: 2023-07-12T07:20:46+02:00 New Revision: fa689726768b7b5cae01970cce2e59a72a0229b4 URL: https://github.com/llvm/llvm-project/commit/fa689726768b7b5cae01970cce2e59a72a0229b4 DIFF: https://github.com/llvm/llvm-project/commit/fa689726768b7b5cae01970cce2e59a72a0229b4.diff LO

[PATCH] D154969: [dataflow] document flow condition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa689726768b: [dataflow] document flow condition (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D154969?vs=539086&id=5

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 539383. xgupta added a comment. . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/clang-tidy/misc/IncompleteSwitchCheck.cpp clang-

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 539389. xgupta added a comment. Address bkramer's comments except one for "checking that you're casting from an enum". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files: clang-tools-extra/clang-tidy/misc

[PATCH] D145302: [clangd] Add library for clangd main function

raj.khem added a comment. indeed, broke my CI with same issue. In D145302#4491973 , @glandium wrote: > This broke building with `-DLLVM_LINK_LLVM_DYLIB=ON`: > > /usr/bin/ld: > tools/clang/tools/extra/clangd/refactor/tweaks/CMakeFiles/obj.clangDaemonTw

[PATCH] D153989: [compiler-rt] Move crt into builtins

arichardson added a comment. I think reduplication of build logic makes sense but these are conceptually separate things. The compiler rt builtins are needed in many cases where the C start-up code isn't (e.g. baremetal OS code). Would moving it to a subdirectory of builtins/ work too? That way

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 539390. xgupta added a comment. Update ReleaseNotes.rst CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/clang-tidy/misc/IncompleteSw

[clang] 304e974 - [Clang] Correctly handle $, @, and ` when represented as UCN

Author: Corentin Jabot Date: 2023-07-12T08:03:23+02:00 New Revision: 304e97469455b57f6496f68fef569eeaed3a2cd8 URL: https://github.com/llvm/llvm-project/commit/304e97469455b57f6496f68fef569eeaed3a2cd8 DIFF: https://github.com/llvm/llvm-project/commit/304e97469455b57f6496f68fef569eeaed3a2cd8.diff

[PATCH] D153621: [Clang] Correctly handle $, @, and ` when represented as UCN

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG304e97469455: [Clang] Correctly handle $, @, and ` when represented as UCN (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.o

[clang] 7d935d0 - [dataflow] improve determinism of generated SAT system

Author: Sam McCall Date: 2023-07-12T08:09:10+02:00 New Revision: 7d935d083659c9ddaf3389c1747fc8c59f07e3fc URL: https://github.com/llvm/llvm-project/commit/7d935d083659c9ddaf3389c1747fc8c59f07e3fc DIFF: https://github.com/llvm/llvm-project/commit/7d935d083659c9ddaf3389c1747fc8c59f07e3fc.diff LO

[PATCH] D154948: [dataflow] improve determinism of generated SAT system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d935d083659: [dataflow] improve determinism of generated SAT system (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D154471: [clang] Add serialization support for the DynamicAllocLValue variant of APValue::LValueBase::Ptr

nridge planned changes to this revision. nridge added a comment. Thank you for the suggested testcase! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154471/new/ https://reviews.llvm.org/D154471 ___ cfe-c

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 539402. 4vtomat marked 12 inline comments as done. 4vtomat added a comment. Resolved Craig's and Michael's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810 F

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

nridge resigned from this revision. nridge added a comment. I'm sorry, I feel like I don't have a good enough level of insight into the requirements to usefully critique this patch, nor the bandwidth to take a detailed look through the implementation right now. I think it's best for me to resig

[PATCH] D154983: [clang-extdef-mapping] register necessary targest for ms-style asm block

danix800 added a comment. I don't have merge permission, can anyone do the merge plz? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154983/new/ https://reviews.llvm.org/D154983 ___ cfe-commits mailing li

[PATCH] D153989: [compiler-rt] Move crt into builtins

phosek added a comment. In D153989#4492229 , @arichardson wrote: > I think reduplication of build logic makes sense but these are conceptually > separate things. The compiler rt builtins are needed in many cases where the > C start-up code isn't (e.g.

<    1   2   3