[clang] d4a5673 - [AIX][clang][tests] XFail PCH/late-parsed-instantiations.cpp

Author: Serge Pavlov Date: 2023-07-06T14:06:30+07:00 New Revision: d4a5673addd69aa2a299d9de4db8d17373be URL: https://github.com/llvm/llvm-project/commit/d4a5673addd69aa2a299d9de4db8d17373be DIFF: https://github.com/llvm/llvm-project/commit/d4a5673addd69aa2a299d9de4db8d17373be.diff

[PATCH] D154572: [RISCV] Use 'long' in aes64 Zknd/Zkne builtin tests.

craig.topper created this revision. craig.topper added reviewers: asb, VincentWu, kito-cheng. Herald added subscribers: jobnoorman, luke, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D143241: [Clang] Reset FP options before function instantiations

sepavloff added a comment. In D143241#4475741 , @Jake-Egan wrote: > Hi, the following assertion is getting tripped on AIX: > > Assertion failed: *FpPragmaCurrentValue == > SemaObj->FpPragmaStack.DefaultValue && "Expected a default pragma > float_contr

[clang] 533af6e - [AIX] make integrated-as as default on AIX.

Author: esmeyi Date: 2023-07-06T03:16:10-04:00 New Revision: 533af6e5c4b35b72805cdbd6229644d288e172e4 URL: https://github.com/llvm/llvm-project/commit/533af6e5c4b35b72805cdbd6229644d288e172e4 DIFF: https://github.com/llvm/llvm-project/commit/533af6e5c4b35b72805cdbd6229644d288e172e4.diff LOG: [

[PATCH] D154036: [libc] Add support for creating wrapper headers for offloading in clang

sivachandra added a comment. The libc specific changes are really minimal straightforward. The GPU side, the clang driver changes etc. need a review by a GPU expert. Comment at: libc/include/CMakeLists.txt:8 +if(LIBC_TARGET_ARCHITECTURE_IS_GPU) + include(GetClangResourceDir)

[PATCH] D150758: [AIX] make integrated-as as default on AIX.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG533af6e5c4b3: [AIX] make integrated-as as default on AIX. (authored by Esme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options

sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:87-90 +if (Feature == "sme") { + Features.push_back("+sve"); + Features.push_back("+sve2"); + Features.push_back("+bf16"); SME shouldn't require SVE or SV

[clang] 51feb1a - [RISCV] Use 'int' for return type for clz_64/clo_64 tests in riscv64-xtheadbb.c. NFC

Author: Craig Topper Date: 2023-07-06T00:25:20-07:00 New Revision: 51feb1a72c5beb8f46d2f5569f3c3398f8902272 URL: https://github.com/llvm/llvm-project/commit/51feb1a72c5beb8f46d2f5569f3c3398f8902272 DIFF: https://github.com/llvm/llvm-project/commit/51feb1a72c5beb8f46d2f5569f3c3398f8902272.diff

[clang] 7c9230c - [RISCV] Add trunc instruction to the __builtin_riscv_ctz_64/__builtin_riscv_clz_64 IR.

Author: Craig Topper Date: 2023-07-06T00:55:16-07:00 New Revision: 7c9230c4f2ad267c716520fb25c4037acd2204fd URL: https://github.com/llvm/llvm-project/commit/7c9230c4f2ad267c716520fb25c4037acd2204fd DIFF: https://github.com/llvm/llvm-project/commit/7c9230c4f2ad267c716520fb25c4037acd2204fd.diff

[PATCH] D152604: [Driver] Default -fsanitize-address-globals-dead-stripping to true for ELF

glandium added a comment. In the realm of unintended consequences, this broke ODR violation detection when linking a rust static library with asan enabled because, while __asan_globals_registered is COMDAT in clang, for some reason, it's not in rust... So you end up with two asan.module_ctor th

[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, ormris, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, steven_wu, edward-jones, zzheng, jrtc27, shiva0217, kito

[PATCH] D154572: [RISCV] Use 'long' in aes64 Zknd/Zkne builtin tests. NFC

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154572/new/ https://reviews.llvm.org/D154572 ___

[PATCH] D154577: [RISCV] Use 'long' in sha512 builtin tests. NFC

craig.topper created this revision. craig.topper added reviewers: kito-cheng, asb, VincentWu. Herald added subscribers: jobnoorman, luke, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

craig.topper added a comment. Does this only change the calling convention when `__attribute__((riscv_vector_cc))` is used? The attribute should be mentioned in the patch description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154576/new/ http

[clang] ac03e3f - [RISCV] Use 'long' in aes64 Zknd/Zkne builtin tests. NFC

Author: Craig Topper Date: 2023-07-06T01:14:02-07:00 New Revision: ac03e3f51c271b985efeb0fe6b9782cd6928be33 URL: https://github.com/llvm/llvm-project/commit/ac03e3f51c271b985efeb0fe6b9782cd6928be33 DIFF: https://github.com/llvm/llvm-project/commit/ac03e3f51c271b985efeb0fe6b9782cd6928be33.diff

[PATCH] D154572: [RISCV] Use 'long' in aes64 Zknd/Zkne builtin tests. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac03e3f51c27: [RISCV] Use 'long' in aes64 Zknd/Zkne builtin tests. NFC (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

4vtomat added a comment. In D154576#4476291 , @craig.topper wrote: > Does this only change the calling convention when > `__attribute__((riscv_vector_cc))` is used? The attribute should be mentioned > in the patch description. Yes it only changes when

[PATCH] D154578: [ARM][Driver] Change float-abi warning

michaelplatings created this revision. michaelplatings added a reviewer: simon_tatham. Herald added a subscriber: kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously the war

[clang] 6b8a9ff - [clang-format] Fix RAS reference alignment when PAS is left or middle

Author: Gedare Bloom Date: 2023-07-06T01:41:16-07:00 New Revision: 6b8a9ff7e74fcf00a5b37c505abcd3d290b2d3c2 URL: https://github.com/llvm/llvm-project/commit/6b8a9ff7e74fcf00a5b37c505abcd3d290b2d3c2 DIFF: https://github.com/llvm/llvm-project/commit/6b8a9ff7e74fcf00a5b37c505abcd3d290b2d3c2.diff

[PATCH] D153579: [clang-format] Fix RAS reference alignment when PAS is left or middle

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b8a9ff7e74f: [clang-format] Fix RAS reference alignment when PAS is left or middle (authored by gedare, committed by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D154580: Add missing semantic highlighing for concepts.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Gith

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

hokein added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4921 + // value is. + if (isa(E)) +return false; aaron.ballman wrote: > hokein wrote: > > hokein wrote: > > > hokein wrote: > > > > yronglin wrote: > > > > > yronglin wrote: > > > > >

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, cor3ntin, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. InitMaps are created for primitive arrays when the fir

[PATCH] D154580: [clangd][c++20]Add missing semantic highlighing for concepts.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:966 + +if (auto *TSI = D->getTypeSourceInfo()) { + auto ATL = TSI->getTypeLoc().getContainedAutoTypeLoc(); if we add this logic it definitely needs a comment

[PATCH] D153340: [include-cleaner] Add an IgnoreHeaders flag to the command-line tool.

hokein updated this revision to Diff 537631. hokein marked 5 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153340/new/ https://reviews.llvm.org/D153340 Files: clang-tools-extra/cl

[clang] a84e0b4 - [clang-format] Fix align consecutive declarations over function pointers

Author: Gedare Bloom Date: 2023-07-06T02:17:32-07:00 New Revision: a84e0b4bdc872adbdaafbade8164b197784b URL: https://github.com/llvm/llvm-project/commit/a84e0b4bdc872adbdaafbade8164b197784b DIFF: https://github.com/llvm/llvm-project/commit/a84e0b4bdc872adbdaafbade8164b197784b.diff

[PATCH] D153585: [clang-format] Fix align consecutive declarations over function pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa84e0b4bdc99: [clang-format] Fix align consecutive declarations over function pointers (authored by gedare, committed by owenpan). Changed prior to

[PATCH] D153340: [include-cleaner] Add an IgnoreHeaders flag to the command-line tool.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp:231 + } + return [FilterRegs](llvm::StringRef Path) { +llvm::errs() << "Path: " << Path << "\n"; kadircet wrote: > `FilterRegs=std::move(FilterRegs)` and dro

[clang-tools-extra] 507d766 - [include-cleaner] Add an IgnoreHeaders flag to the command-line tool.

Author: Haojian Wu Date: 2023-07-06T11:18:44+02:00 New Revision: 507d766d76d873aa6e446889f93384745a0e1c0b URL: https://github.com/llvm/llvm-project/commit/507d766d76d873aa6e446889f93384745a0e1c0b DIFF: https://github.com/llvm/llvm-project/commit/507d766d76d873aa6e446889f93384745a0e1c0b.diff LO

[PATCH] D153340: [include-cleaner] Add an IgnoreHeaders flag to the command-line tool.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG507d766d76d8: [include-cleaner] Add an IgnoreHeaders flag to the command-line tool. (authored by hokein). Changed prior to commit: https://reviews

[PATCH] D154586: [clang][dataflow] Various changes to handling of modeled fields.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Rename `getReferencedFields()` to `getModeledF

[PATCH] D154580: [clangd][c++20]Add missing semantic highlighing for concepts.

massberg updated this revision to Diff 537642. massberg added a comment. Set correct token for deduced auto types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154580/new/ https://reviews.llvm.org/D154580 Files: clang-tools-extra/clangd/Semanti

[PATCH] D154580: [clangd][c++20]Add missing semantic highlighing for concepts.

massberg updated this revision to Diff 537643. massberg added a comment. Directly get correct source loc in case of deduced auto types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154580/new/ https://reviews.llvm.org/D154580 Files: clang-tools

[PATCH] D154580: [clangd][c++20]Add missing semantic highlighing for concepts.

massberg marked 2 inline comments as done. massberg added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:969 + if (ATL.isConstrained()) { + StartLoc = ATL.getConceptNameInfo().getEndLoc().getLocWithOffset(1); + } ---

[PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG7aafea001282: [llvm][Support] Deprecate llvm::writeFileAtomically API (authored by hokein). Repository: r

[PATCH] D154591: [OpenMP][OMPIRBuilder] Rename IsEmbedded and IsTargetCodegen flags

skatrak created this revision. skatrak added reviewers: jsjodin, jdoerfert, kiranchandramohan. Herald added subscribers: gysit, Dinistro, bviyer, sunshaoce, Moerafaat, zero9178, bzcheeseman, mattd, gchakrabarti, awarzynski, sdasgup3, asavonic, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatian

[clang] 626c789 - Fix compile error in UnresolvedSetTest.cpp, hopefully the last one

Author: John Brawn Date: 2023-07-06T11:54:45+01:00 New Revision: 626c789d92bc917e7db30478e9b6d4c9b567ee17 URL: https://github.com/llvm/llvm-project/commit/626c789d92bc917e7db30478e9b6d4c9b567ee17 DIFF: https://github.com/llvm/llvm-project/commit/626c789d92bc917e7db30478e9b6d4c9b567ee17.diff LO

[PATCH] D154502: [AST] Fix bug in UnresolvedSet::erase of last element

john.brawn added inline comments. Comment at: clang/unittests/AST/UnresolvedSetTest.cpp:11 +}; +} // namespace clang + jroelofs wrote: > jroelofs wrote: > > This ODR violation broke the build for me because it's picking up the > > definition from Decl.h instead

[PATCH] D154596: [RISCV] Fix required features checking with empty string

Jim created this revision. Herald added subscribers: jobnoorman, VincentWu, vkmr, luismarques, sameer.abuasal, s.egerton, benna, psnobl, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, arichardson. Herald added a project: All. Jim requested review of this revision. Herald added subscribers: cfe

[PATCH] D154036: [libc] Add support for creating wrapper headers for offloading in clang

jhuber6 added inline comments. Comment at: libc/include/CMakeLists.txt:8 +if(LIBC_TARGET_ARCHITECTURE_IS_GPU) + include(GetClangResourceDir) +endif() sivachandra wrote: > Where does this come from? It's a global CMake module that LLVM provides in `cmake/Modules

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: clang/lib/CodeGen/CGDecl.cpp:19 #include "CGOpenMPRuntime.h" +#include "CGOpenMPRuntimeGPU.h" #include "CodeGenFunction.h" You

[PATCH] D154597: [clang][dataflow] Various refactorings to UncheckedOptionalAccessModel.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These are intended to ease an upcoming change th

[PATCH] D154597: [clang][dataflow] Various refactorings to UncheckedOptionalAccessModel.

mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:258 /// symbolic value of its "has_value" property. -StructValue &createOptionalValue(Environment &Env, BoolValue &HasValueVal) { +StructValue &createOptionalValu

[PATCH] D154189: [clang][Interp] Implement zero-init of record types

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154189/new/ https://reviews.llvm.org/D154189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153653/new/ https://reviews.llvm.org/D153653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154567: [RISCV] Use ClangBuiltin in IntrinsicsRISCV.td to map some scalar crypto builtins to IR intrinsic.

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154567/new/ https://reviews.llvm.org/D154567 ___ cfe-

[PATCH] D154577: [RISCV] Use 'long' in sha512 builtin tests. NFC

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154577/new/ https://reviews.llvm.org/D154577 ___ cfe-

[PATCH] D154578: [ARM][Driver] Change float-abi warning

michaelplatings updated this revision to Diff 537673. michaelplatings added a comment. Fix duplicate implicit group warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154578/new/ https://reviews.llvm.org/D154578 Files: clang/include/clang/Bas

[PATCH] D154597: [clang][dataflow] Various refactorings to UncheckedOptionalAccessModel.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Nice! I don't think you need a second review for this one, since it's just superficial (if important!) refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] f223c96 - [clang][Interp][NFC] Return a const Descriptor from a getter

Author: Timm Bäder Date: 2023-07-06T14:52:05+02:00 New Revision: f223c964df86b239f76946b30a1400cb9b7adaa3 URL: https://github.com/llvm/llvm-project/commit/f223c964df86b239f76946b30a1400cb9b7adaa3 DIFF: https://github.com/llvm/llvm-project/commit/f223c964df86b239f76946b30a1400cb9b7adaa3.diff LO

[clang] 9642343 - [clang][Interp][NFC] Make a local variable const

Author: Timm Bäder Date: 2023-07-06T14:52:05+02:00 New Revision: 9642343d3023bdf5edcb2a016a9a9cc6cfd23834 URL: https://github.com/llvm/llvm-project/commit/9642343d3023bdf5edcb2a016a9a9cc6cfd23834 DIFF: https://github.com/llvm/llvm-project/commit/9642343d3023bdf5edcb2a016a9a9cc6cfd23834.diff LO

[clang] 868aa93 - [clang][Interp][NFC] Take a const Function pointer in Context::Run()

Author: Timm Bäder Date: 2023-07-06T14:52:05+02:00 New Revision: 868aa9360587945146c86449cbd6c5170e1c9e2b URL: https://github.com/llvm/llvm-project/commit/868aa9360587945146c86449cbd6c5170e1c9e2b DIFF: https://github.com/llvm/llvm-project/commit/868aa9360587945146c86449cbd6c5170e1c9e2b.diff LO

[clang] bd59d17 - [clang][Interp][NFC] Fix some doc comment confusion

Author: Timm Bäder Date: 2023-07-06T14:52:05+02:00 New Revision: bd59d17e71f8c58f25fdba7f614cb0449c38d628 URL: https://github.com/llvm/llvm-project/commit/bd59d17e71f8c58f25fdba7f614cb0449c38d628 DIFF: https://github.com/llvm/llvm-project/commit/bd59d17e71f8c58f25fdba7f614cb0449c38d628.diff LO

[clang] 00c2739 - [clang][Interp][NFC] Move some declarations into the if condition

Author: Timm Bäder Date: 2023-07-06T14:52:05+02:00 New Revision: 00c27397dc63358bc7e5975c7af80efbf863d2c2 URL: https://github.com/llvm/llvm-project/commit/00c27397dc63358bc7e5975c7af80efbf863d2c2 DIFF: https://github.com/llvm/llvm-project/commit/00c27397dc63358bc7e5975c7af80efbf863d2c2.diff LO

[PATCH] D152554: [OpenMP] Migrate device code privatisation from Clang CodeGen to OMPIRBuilder

TIFitis updated this revision to Diff 537680. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152554/new/ https://reviews.llvm.org/D152554 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRu

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: yaxunl, tra, MaskRay. DmitryPolukhin added projects: clang, clang-tools-extra. Herald added subscribers: kadircet, arphaman. Herald added a project: All. DmitryPolukhin published this revision for review. Herald added subscribers

[PATCH] D154580: [clangd][c++20]Add missing semantic highlighing for concepts.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! I forgot about the TypeLoc hierarchy, getNameLoc() isn't so obvious... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154580/new/ htt

[PATCH] D154556: [OPENMP52] Support Support omp_cur_iteration modifier for doacross clause.

ABataev added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:2516-2523 + if (DepType == OMPC_DOACROSS_source) +OS << "source:"; + else if (DepType == OMPC_DOACROSS_sink) +OS << "sink:"; + else if (DepType == OMPC_DOACROSS_source_omp_cur_iteration) +OS

[PATCH] D154603: [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker

gamesh411 created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project: All. game

[PATCH] D135849: [llvm] Return canonical virtual path from `RedirectingFileSystem`

jansvoboda11 updated this revision to Diff 537689. jansvoboda11 added a comment. Add unit tests, use `SmallVector`, make `clang-scan-deps` test portable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135849/new/ https://reviews.llvm.org/D135849 Fil

[PATCH] D154295: [Driver][MSVC] Support DWARF fission when using LTO on Windows

hans accepted this revision. hans added a comment. Looks reasonable to me too. It would be nice to have some documentation for this feature though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154295/new/ https://reviews.llvm.org/D154295 ___

[clang] d4f43e4 - [docs] Update 'please file a bug' link for clang-cl

Author: Hans Wennborg Date: 2023-07-06T15:13:10+02:00 New Revision: d4f43e4293f98616057ccf00661926f540bfdfab URL: https://github.com/llvm/llvm-project/commit/d4f43e4293f98616057ccf00661926f540bfdfab DIFF: https://github.com/llvm/llvm-project/commit/d4f43e4293f98616057ccf00661926f540bfdfab.diff

[PATCH] D154603: [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker

gamesh411 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp:95 // Stores the region of the environment pointer of 'main' (if present). -REGISTER_TRAIT_WITH_PROGRAMSTATE(EnvPtrRegion, const MemRegion *) +REGISTER_TRAIT_WITH_PROGRAMSTA

[PATCH] D135849: [llvm][vfs] For virtual directories, use the virtual path as real path

jansvoboda11 added a comment. I think this patch should now stand on its own. Dealing with a VFS definition that uses the wrong case for virtual paths is not necessary for correctness. If Clang asks the FS for a file using the correct case, the query either fails and we never get far enough to

[PATCH] D86993: Document Clang's expectations of the C standard library.

aaron.ballman added a comment. In D86993#4474682 , @nikic wrote: >> I continue to think it's a mistake for us to document that Clang will not >> work with a conforming C standard library implementation unless we're filing >> issues with WG14 to alert the

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw updated this revision to Diff 537701. sstwcw added a comment. - Add tests for non-whitespace sequences Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154091/new/ https://reviews.llvm.org/D154091 Files: clang/lib/Format/BreakableToken.cpp

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 updated this revision to Diff 537706. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153883/new/ https://reviews.llvm.org/D153883 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGOpenMPRuntime.h clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/CodeGen/CGOpenMPRun

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added a comment. @ABataev thank you for the review! I have now fixed the last nit and will commit the patch soon! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153883/new/ https://reviews.llvm.org/D153883 ___ cfe-commits mailing lis

[clang] f97b61e - [Driver][MSVC] Support DWARF fission when using LTO on Windows

Author: Haohai Wen Date: 2023-07-06T22:18:58+08:00 New Revision: f97b61ed27aa6b0cef21e86e71d683feab32ce34 URL: https://github.com/llvm/llvm-project/commit/f97b61ed27aa6b0cef21e86e71d683feab32ce34 DIFF: https://github.com/llvm/llvm-project/commit/f97b61ed27aa6b0cef21e86e71d683feab32ce34.diff LO

[PATCH] D154295: [Driver][MSVC] Support DWARF fission when using LTO on Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf97b61ed27aa: [Driver][MSVC] Support DWARF fission when using LTO on Windows (authored by HaohaiWen). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D154295: [Driver][MSVC] Support DWARF fission when using LTO on Windows

HaohaiWen added a comment. Thanks everyone. > It would be nice to have some documentation for this feature though. This feature is same as Linux -gsplit-dwarf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154295/new/ https://reviews.llvm.org/D15

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin updated this revision to Diff 537714. yronglin added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153296/new/ https://reviews.llvm.org/D153296 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ExprConstant

[clang-tools-extra] 8af9a37 - Add missing semantic highlighing for concepts.

Author: Jens Massberg Date: 2023-07-06T16:28:57+02:00 New Revision: 8af9a373ad95ef49e2f2aa83c021b8043f848ab9 URL: https://github.com/llvm/llvm-project/commit/8af9a373ad95ef49e2f2aa83c021b8043f848ab9 DIFF: https://github.com/llvm/llvm-project/commit/8af9a373ad95ef49e2f2aa83c021b8043f848ab9.diff

[PATCH] D154580: [clangd][c++20]Add missing semantic highlighing for concepts.

This revision was automatically updated to reflect the committed changes. massberg marked an inline comment as done. Closed by commit rG8af9a373ad95: Add missing semantic highlighing for concepts. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D147184: [clang][CodeGenCXX] Improve handling of itanium ABI member function alignment requirements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG196c144d0bc1: [clang][CodeGenCXX] Improve handling of itanium ABI member function alignment… (authored by daltenty). Herald added a project: clang. H

[PATCH] D154295: [Driver][MSVC] Support DWARF fission when using LTO on Windows

hans added a comment. In D154295#4477165 , @HaohaiWen wrote: >> It would be nice to have some documentation for this feature though. > > This feature is same as Linux -gsplit-dwarf. Right, but it would be nice to document that clang-cl supports it (which

[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb22a5d46179b: [analyzer] Fix false negative when pass implicit cast nil to nonnull (authored by songruiwang ). Repository

[clang] a8a6a49 - [RISCV] Use 'long' in sha512 builtin tests. NFC

Author: Craig Topper Date: 2023-07-06T07:37:19-07:00 New Revision: a8a6a4947439766355fb7e3dd81947d7f54f687a URL: https://github.com/llvm/llvm-project/commit/a8a6a4947439766355fb7e3dd81947d7f54f687a DIFF: https://github.com/llvm/llvm-project/commit/a8a6a4947439766355fb7e3dd81947d7f54f687a.diff

[PATCH] D154577: [RISCV] Use 'long' in sha512 builtin tests. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8a6a4947439: [RISCV] Use 'long' in sha512 builtin tests. NFC (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn updated this revision to Diff 537721. john.brawn added a comment. Avoid doing work when we don't have both decls that can hide and decls that can be hidden. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154503/new/ https://reviews.llvm.org/D154503 Files: clang/lib/Sema/Se

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf added inline comments. Comment at: clang/lib/Interpreter/CodeCompletion.cpp:84 + std::string AllCodeText = + MainInterp.getAllInput() + "\nvoid dummy(){\n" + Buffer.str() + "}"; + auto Lines = std::count(AllCodeText.begin(), AllCodeText.end(), '\n') + 1; -

[clang] b22a5d4 - [analyzer] Fix false negative when pass implicit cast nil to nonnull

Author: songruiwang Date: 2023-07-06T22:36:51+08:00 New Revision: b22a5d46179b0ec2d5350c078dc349f09177b9ed URL: https://github.com/llvm/llvm-project/commit/b22a5d46179b0ec2d5350c078dc349f09177b9ed DIFF: https://github.com/llvm/llvm-project/commit/b22a5d46179b0ec2d5350c078dc349f09177b9ed.diff L

[PATCH] D154493: [X86] Support some Intel CPUs for cpu_specific/dispatch feature

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:333 { {"pentium"}, CK_Pentium, ~0U, FeatureX87 | FeatureCMPXCHG8B, 'B', false }, { {"pentium-mmx"}, CK_Pent

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:542 +N = Decls.size(); + } + rjmccall wrote: > This is going to fire on every single ordinary lookup that finds multiple > declarations, right? I haven't fully internalized the iss

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn updated this revision to Diff 537731. john.brawn added a comment. Same patch as previous, but with full context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154503/new/ https://reviews.llvm.org/D154503 Files: clang/lib/Sema/SemaLookup.cpp clang/test/SemaCXX/using-hidin

[clang] 1db5b49 - [RISCV] Use ClangBuiltin in IntrinsicsRISCV.td to map some scalar crypto builtins to IR intrinsic.

Author: Craig Topper Date: 2023-07-06T07:53:31-07:00 New Revision: 1db5b49ae62a7820378d8dfb2d8fd53e1774992d URL: https://github.com/llvm/llvm-project/commit/1db5b49ae62a7820378d8dfb2d8fd53e1774992d DIFF: https://github.com/llvm/llvm-project/commit/1db5b49ae62a7820378d8dfb2d8fd53e1774992d.diff

[PATCH] D154567: [RISCV] Use ClangBuiltin in IntrinsicsRISCV.td to map some scalar crypto builtins to IR intrinsic.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1db5b49ae62a: [RISCV] Use ClangBuiltin in IntrinsicsRISCV.td to map some scalar crypto… (authored by craig.topper). Repository: rG LLVM Github Mon

[clang] 1388887 - Enable dynamic-sized VLAs for data sharing in OpenMP offloaded target regions.

Author: Doru Bercea Date: 2023-07-06T10:57:10-04:00 New Revision: 1370e568dea84c4ea65fe5c01ef4f4ccc751 URL: https://github.com/llvm/llvm-project/commit/1370e568dea84c4ea65fe5c01ef4f4ccc751 DIFF: https://github.com/llvm/llvm-project/commit/1370e568dea84c4ea65fe5c01ef4f4ccc751.diff L

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 closed this revision. doru1004 added a comment. Commit: 1370e568dea84c4ea65fe5c01ef4f4ccc751 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153883/new/ https://reviews.llvm.org/D153883 __

[PATCH] D86993: Document Clang's expectations of the C standard library.

nikic added a comment. In D86993#4477080 , @aaron.ballman wrote: > In D86993#4474682 , @nikic wrote: > >>> I continue to think it's a mistake for us to document that Clang will not >>> work with a conforming C sta

[PATCH] D154616: [RISCV] Use unsigned instead of signed types for Zk* and Zb* builtins.

craig.topper created this revision. craig.topper added reviewers: asb, VincentWu, kito-cheng. Herald added subscribers: jobnoorman, luke, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D154495: clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

arsenm updated this revision to Diff 537737. arsenm added a comment. Split div/sqrt handling since they have different values. Also cuda does have unimplemented flags to control these individually. Not sure it's worth trying to merge them into one function CHANGES SINCE LAST ACTION https://r

[PATCH] D154036: [libc] Add support for creating wrapper headers for offloading in clang

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. OK, let's go with this. It's a fairly alarming mess localised quite closely to the language that requires the complexity, minimal damage to libc itself. Repository: rG LLV

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

cor3ntin updated this revision to Diff 537742. cor3ntin added a comment. Address Hubert's feedback - Add code and tests to properly support member initializer - Add code and tests to support designated initializers - Correctly hamdle members of anonymous union - Make placeholder redeclaration in

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

cor3ntin updated this revision to Diff 537745. cor3ntin added a comment. Add tests for static structured bindings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153536/new/ https://reviews.llvm.org/D153536 Files: clang/docs/ReleaseNotes.rst cla

[PATCH] D146712: [clang-tidy] Add portability-non-portable-integer-constant check

whisperity requested changes to this revision. whisperity added a comment. Earlier (IIRC in March) we did an internal test of the check and the following results were obtained. The results are kinda //weird//, to say the least. Numbers are //after// CodeChecker has done a serverside uniqueing (m

[PATCH] D153621: [Clang] Correctly handle $, @, and ` when represented as UCN

cor3ntin added a comment. In D153621#4449244 , @aaron.ballman wrote: > Changes generally LGTM, but I'll leave it to @tahonermann to do the final > sign-off given this is related to text. @tahonermann Ping :) Repository: rG LLVM Github Monorepo CHA

[PATCH] D154556: [OPENMP52] Support Support omp_cur_iteration modifier for doacross clause.

jyu2 updated this revision to Diff 537749. jyu2 added a comment. Thanks Alexey for the review. This is address his comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154556/new/ https://reviews.llvm.org/D154556 Files: clang/include/clang/Ba

[PATCH] D154556: [OPENMP52] Support Support omp_cur_iteration modifier for doacross clause.

jyu2 added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:2516-2523 + if (DepType == OMPC_DOACROSS_source) +OS << "source:"; + else if (DepType == OMPC_DOACROSS_sink) +OS << "sink:"; + else if (DepType == OMPC_DOACROSS_source_omp_cur_iteration) +OS <<

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

tahonermann accepted this revision. tahonermann added a comment. These changes look fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153589/new/ https://reviews.llvm.org/D153589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   3   >