[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

massberg updated this revision to Diff 537163. massberg marked 2 inline comments as done. massberg added a comment. Add test case that isn't correctly handled yet and add FIXME comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154450/new/ http

[PATCH] D154460: [ODRHash] Stop hashing `ObjCMethodDecl::isPropertyAccessor` as it doesn't capture inherent method quality.

vsapsai created this revision. vsapsai added reviewers: ChuanqiXu, jansvoboda11, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `isPropertyAccessor` depen

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

qianzhen updated this revision to Diff 537175. qianzhen added a comment. Update to address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150221/new/ https://reviews.llvm.org/D150221 Files: clang/include/clang/Basic/CodeGenOptions

[PATCH] D150221: Add option -fkeep-persistent-storage-variables to emit all variables that have a persistent storage duration

qianzhen added inline comments. Comment at: clang/test/CodeGen/keep-persistent-storage-variables.cpp:32-39 +int test1() { + g1 = 3; + return g1; +} + +int test2() { + return g2; hubert.reinterpretcast wrote: > Why add functions that use `g1` and `g2`? Is there

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw updated this revision to Diff 537190. sstwcw added a comment. - Add tests for other escape sequences Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154091/new/ https://reviews.llvm.org/D154091 Files: clang/lib/Format/BreakableToken.cpp c

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw marked an inline comment as done. sstwcw added a comment. In D154091#4470158 , @MyDeveloperDay wrote: > What would happen in a \r\n example If the entire `\r\n` part fits on the first line, the break is after `\r\n`. If only the part up to `\r`

[PATCH] D154467: [clang-format] Add Verilog suffixes to the scripts

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Herald added a comment. NOTE: Clang-Format Team Automated Re

[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

tripleCC added a comment. In D154221#4472112 , @steakhal wrote: > @tripleCC Could you clarify the status. Do you need some help or review? Do > you have concerns? > You made some inline comments that I couldn't put into context. @steakhal Yes, I need s

[PATCH] D143052: [CMake] Replace llvm_check_linker_flag and llvm_check_compiler_linker_flag

phosek added a comment. In D143052#4468485 , @ldionne wrote: > What is the status of this? We now require CMake 3.20, can this be rebased > and landed in some form? The issue I ran into is that `check_linker_flag` annoyingly behaves differently from `c

[PATCH] D153693: [clang][Interp] Handle InitListExprs of composite type

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153693/new/ https://reviews.llvm.org/D153693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154262/new/ https://reviews.llvm.org/D154262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D153695: [clang][Interp] Fix passing parameters of composite type

tbaeder marked 3 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.h:71 - /// Parameter indices. - llvm::DenseMap Params; + /// Parameter indices. > + llvm::DenseMap Params; shafik wrote: > I don't unde

[PATCH] D153957: [C++20] [Modules] Allow Stmt::Profile to treat lambdas as equal conditionally

ChuanqiXu added a comment. I'd like to land this in the next week if no objections come in. Since clang-17 is going to be branched and this one is small and relevant. Also this one prevents the testing of the std modules. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153957/new/ https

[clang] feafbb9 - [analyzer] Differentiate lifetime extended temporaries

Author: Tomasz Kamiński Date: 2023-07-05T07:39:14+02:00 New Revision: feafbb9fda57dc77d5349a352b8495b6ef0f1bf5 URL: https://github.com/llvm/llvm-project/commit/feafbb9fda57dc77d5349a352b8495b6ef0f1bf5 DIFF: https://github.com/llvm/llvm-project/commit/feafbb9fda57dc77d5349a352b8495b6ef0f1bf5.dif

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

This revision was automatically updated to reflect the committed changes. tomasz-kaminski-sonarsource marked an inline comment as done. Closed by commit rGfeafbb9fda57: [analyzer] Differentiate lifetime extended temporaries (authored by tomasz-kaminski-sonarsource). Repository: rG LLVM Github M

[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I'd say, as tests pass and I and @xazax.hun think that this is an improvement - along with you - then we should merge this as-is and do corrections once reported. Comme

[PATCH] D154473: [clang][Tooling] Add mapping for make_error_code

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154473 Files: clang

[PATCH] D154474: [clang][Interp] Fix ignoring Integral- and IntegralToBoolean casts

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a subscriber: inglorion. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D154475: [clang][Interp] Fix ignoring MaterializeTemporaryExprs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D154475: [clang][Interp] Fix ignoring MaterializeTemporaryExprs

tbaeder added a comment. This is split out from https://reviews.llvm.org/D149828, but I think that other one had problems (which made me write this version). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154475/new/ https://reviews.llvm.org/D15447

[PATCH] D154475: [clang][Interp] Fix ignoring MaterializeTemporaryExprs

cor3ntin added a comment. Can you describe the problems? Otherwise, this looks reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154475/new/ https://reviews.llvm.org/D154475 ___ cfe-commits mail

[PATCH] D154474: [clang][Interp] Fix ignoring Integral- and IntegralToBoolean casts

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154474/new/ https://reviews.llvm.org/D154474 ___

[clang] 3ec1274 - [clang][NFC] Move two declarations closer to their point of use

Author: Timm Bäder Date: 2023-07-05T08:54:24+02:00 New Revision: 3ec12740d0bc1b14bcafb8c9ece9e679f6957e9a URL: https://github.com/llvm/llvm-project/commit/3ec12740d0bc1b14bcafb8c9ece9e679f6957e9a DIFF: https://github.com/llvm/llvm-project/commit/3ec12740d0bc1b14bcafb8c9ece9e679f6957e9a.diff LO

[PATCH] D154473: [clang][Tooling] Add mapping for make_error_code

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc:353 +// type. +SYMBOL(make_error_code, std::, /*no headers*/) nit: maybe add `m

<    1   2