[PATCH] D154388: Don't pass -ibuiltininc, which is used only by the driver, to CC1

ahatanak created this revision. ahatanak added reviewers: arphaman, fahad, MaskRay. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. This fixes a fallout from 5b77e752dcd073846b89559d6c0e1a7699e58615

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:20 + +Clang supports OpenCL, HIP and OpenMP on amdgpu target. + lamb-j wrote: > arsenm wrote: > > "on amdgpu target" doesn't sound grammatical > "for t

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl updated this revision to Diff 536887. yaxunl marked 2 inline comments as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154133/new/ https://reviews.llvm.org/D154133 Files: clang/docs/AMDGPUSupport.rst Index: clang/docs/AMDGPUS

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 added a comment. In D154180#4469417 , @ABataev wrote: > LG with a nit Thank you so much! Jennifer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154180/new/ https://reviews.llvm.org/D154180 _

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan updated this revision to Diff 536890. Jake-Egan added a comment. Fix formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153600/new/ https://reviews.llvm.org/D153600 Files: clang/lib/Driver/ToolChains/Clang.cpp llvm/include/llvm/CodeGen/AsmPrinter.h llvm/include/ll

[PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154329/new/ https://reviews.llvm.org/D154329 ___

[PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

avl accepted this revision. avl added a comment. This revision is now accepted and ready to land. this LGTM, assuming D154329 is landed. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153740/new/ https:

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter added a comment. @PiotrZSL - checking back, do you plan to revisit this change soon (I think there are some pending feedback and you planned some changes)? I'd like to see this in change merged in. Let me know if I can help. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] 35041a4 - [OPENMP52] Codegen support for doacross clause.

Author: Jennifer Yu Date: 2023-07-03T15:24:05-07:00 New Revision: 35041a435def860e2b1b99133b934632a9d634ac URL: https://github.com/llvm/llvm-project/commit/35041a435def860e2b1b99133b934632a9d634ac DIFF: https://github.com/llvm/llvm-project/commit/35041a435def860e2b1b99133b934632a9d634ac.diff L

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35041a435def: [OPENMP52] Codegen support for doacross clause. (authored by jyu2). Changed prior to commit: https://reviews.llvm.org/D154180?vs=536

[PATCH] D153600: Implement -frecord-command-line for XCOFF

stephenpeckham added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:2338 // Emit bytes for llvm.commandline metadata. - emitModuleCommandLines(M); + if (!TM.getTargetTriple().isOSBinFormatXCOFF()) +emitModuleCommandLines(M); I wo

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

PiotrZSL added a comment. In D144347#4469770 , @ccotter wrote: > @PiotrZSL - checking back, do you plan to revisit this change soon (I think > there are some pending feedback and you planned some changes)? I'd like to > see this in change merged in. Let

[clang] cff99b7 - Add a flag to disable "duplicate definition of category" warnings

Author: Akira Hatanaka Date: 2023-07-03T16:25:22-07:00 New Revision: cff99b76ac4f502ceba897a62db658667f1237f3 URL: https://github.com/llvm/llvm-project/commit/cff99b76ac4f502ceba897a62db658667f1237f3 DIFF: https://github.com/llvm/llvm-project/commit/cff99b76ac4f502ceba897a62db658667f1237f3.diff

[PATCH] D154251: Add a flag to disable "duplicate definition of category" warnings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcff99b76ac4f: Add a flag to disable "duplicate definition of category" warnings (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter added a comment. Great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144347/new/ https://reviews.llvm.org/D144347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f3620e5c9ee: [clang-format] Correctly annotate */&/&& in operator function calls (authored by owenpan). Repository: rG LLVM Github Monorepo CHAN

[clang] 3f3620e - [clang-format] Correctly annotate */&/&& in operator function calls

Author: Owen Pan Date: 2023-07-03T17:49:10-07:00 New Revision: 3f3620e5c9ee0f7b64afc39e5a26c6f4cc5e7b37 URL: https://github.com/llvm/llvm-project/commit/3f3620e5c9ee0f7b64afc39e5a26c6f4cc5e7b37 DIFF: https://github.com/llvm/llvm-project/commit/3f3620e5c9ee0f7b64afc39e5a26c6f4cc5e7b37.diff LOG:

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan updated this revision to Diff 536920. Jake-Egan edited the summary of this revision. Jake-Egan added a comment. Thanks for the review @stephenpeckham, I updated the patch with the requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153600/new/ https://reviews.llv

[PATCH] D154396: [clang] Add support for SerenityOS

ADKaster created this revision. Herald added a project: All. ADKaster requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Adds support for the `$arch-pc-serenity` target to the Clang front end. This makes the compiler look for libraries

[PATCH] D154397: [Driver] Default to -ftls-model=initial-exec on SerenityOS

ADKaster created this revision. Herald added a project: All. ADKaster requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Force Clang use the initial-exec TLS model instead of the default local-exec when building code for Serenity. Thi

[PATCH] D154401: [tools] Support building shared libLLVM and libClang for SerenityOS

ADKaster created this revision. Herald added subscribers: mstorsjo, fedor.sergeev. Herald added a project: All. ADKaster requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch tells CMake that the --whole-archive linke

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific-cpus.c:40 ATTR(cpu_specific(knm)) void CPU(void){} +ATTR(cpu_specific(cascadelake)) void CPU(void){} +ATTR(cpu_specific(cooperlake)) void CPU(void){} --

[PATCH] D153600: Implement -frecord-command-line for XCOFF

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:2338 // Emit bytes for llvm.commandline metadata. - emitModuleCommandLines(M); + // The command line metadata waas emitted earlier on XCOFF. + if (!TM.getTargetTriple().isOS

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

hubert.reinterpretcast added a comment. Updated patch limited to changing the feature test macro value would match Varna meeting outcome (changes to allow macro to be `0` accepted as DR). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143670/new/ h

[PATCH] D152021: [clang][AIX] Fix Overly Strict LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor comment. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:732-735 UseSeparateSections)) CmdArgs

[PATCH] D154397: [Driver] Default to -ftls-model=initial-exec on SerenityOS

jrtc27 added a comment. This is pretty dodgy, I don't think it belongs upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154397/new/ https://reviews.llvm.org/D154397 ___ cfe-commits mailing list cfe

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 536947. 4vtomat marked 27 inline comments as done. 4vtomat added a comment. Herald added a subscriber: wangpc. Sorry for late update. Resolved MaskRay's comments, thanks for detailed review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat added inline comments. Comment at: clang/test/Driver/print-supported-extensions.c:6 +// RUN: %clang --target=riscv64 --print-supported-extensions 2>&1 | \ +// RUN: FileCheck %s --check-prefix=CHECK-RISCV + MaskRay wrote: > MaskRay wrote: > > Use `--impl

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat marked an inline comment as done. 4vtomat added inline comments. Comment at: clang/test/Driver/print-supported-extensions.c:3 + +// REQUIRES: riscv-registered-target + MaskRay wrote: > If you remove `all` and `RISCV` from `LLVM_TARGETS_TO_BUILD`, you can

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. Now I think the feature may be important for the performance of modules. And I feel we should work on the ASTWriter side instead of ASTReader side. Since the size of BMIs is a problem now also it shows that it is not free to load the large BMIs. So while it is semanti

[PATCH] D154397: [Driver] Default to -ftls-model=initial-exec on SerenityOS

ADKaster abandoned this revision. ADKaster added a comment. In D154397#4470094 , @jrtc27 wrote: > This is pretty dodgy, I don't think it belongs upstream Fair enough, the original patch had "probably don't upstream this" in the commit description. @Bert

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

MyDeveloperDay added a comment. What would happen in a \r\n example Comment at: clang/lib/Format/BreakableToken.cpp:207 + case 't': + case 'v': +AfterSpace = SplitPoint + 2; Are you testing \r \v \f Repository: rG LLVM Github Monorepo CHA

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

iains added a comment. In D126694#4470139 , @ChuanqiXu wrote: > Now I think the feature may be important for the performance of modules. And > I feel we should work on the ASTWriter side instead of ASTReader side. Since > the size of BMIs is a problem n

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. In D126694#4470235 , @iains wrote: > In D126694#4470139 , @ChuanqiXu > wrote: > >> Now I think the feature may be important for the performance of modules. And >> I feel we should work

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 536964. eopXD added a comment. Resolve test case failure in llvm/test/CodeGen/RISCV/rvv/combine-vmv.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/in

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. BTW, in my experience for talking about modules to users, they mainly/mostly care about the compilation performance. And I can't image how many people would like to use modules if they know they won't get a compilation performance win. Repository: rG LLVM Github Mo

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

iains added a comment. In D126694#4470250 , @ChuanqiXu wrote: > BTW, in my experience for talking about modules to users, they mainly/mostly > care about the compilation performance. And I can't image how many people > would like to use modules if they

[PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein added a comment. thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154329/new/ https://reviews.llvm.org/D154329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a579db32a7a: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1543

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. > That is clearly a big motivation - I will ask the folks we were talking to at > WG21 if that is their priority - or maybe they care about language isolation > etc. Yeah, I know the folks in WG21 prefer the language isolation. But you know, there are many folks who

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

iains added a comment. In D126694#4470261 , @ChuanqiXu wrote: >> That is clearly a big motivation - I will ask the folks we were talking to >> at WG21 if that is their priority - or maybe they care about language >> isolation etc. > > Yeah, I know the f

<    1   2