[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

ABataev added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + doru1004 wrote: > ABataev wrote: > > doru1004 wrote: >

[PATCH] D153469: [dataflow] Replace most BoolValue subclasses with references to Formula (and AtomicBoolValue => Atom and BoolValue => Formula where appropriate)

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/Arena.h:61 + /// Passing in the same formula will result in the same BoolValue. + /// FIXME: This canonic

[PATCH] D153485: [dataflow] use true/false literals in formulas, rather than variables

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Formula.h:71 + bool literal() const { +assert(kind() == Literal); castAsLiteral() ? Comment at: clang/unittests/A

[clang] 917eddf - OpenMP: Don't use target regions in library function test

Author: Matt Arsenault Date: 2023-06-30T15:04:03-04:00 New Revision: 917eddfdcb15bddf67a54ede1f1643d5fc83628d URL: https://github.com/llvm/llvm-project/commit/917eddfdcb15bddf67a54ede1f1643d5fc83628d DIFF: https://github.com/llvm/llvm-project/commit/917eddfdcb15bddf67a54ede1f1643d5fc83628d.diff

[PATCH] D152857: OpenMP: Don't use target regions in library function test

arsenm closed this revision. arsenm added a comment. 917eddfdcb15bddf67a54ede1f1643d5fc83628d CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152857/new/ https://reviews.llvm.org/D152857 __

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + ABataev wrote: > doru1004 wrote: > > ABataev wrote: >

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

arsenm added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:20 + +Clang supports OpenCL, HIP and OpenMP on amdgpu target. + "on amdgpu target" doesn't sound grammatical CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154133/new/ https://review

[PATCH] D154251: Add a flag to disable "duplicate definition of category" warnings

ahatanak created this revision. ahatanak added reviewers: Bigcheese, vsapsai. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154251 Files: clang/include/clang/Basic/Diagno

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

lamb-j added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:20 + +Clang supports OpenCL, HIP and OpenMP on amdgpu target. + arsenm wrote: > "on amdgpu target" doesn't sound grammatical "for the //amdgpu// target"? or "on AMD GPU targets?" ==

[PATCH] D154253: [clang] detect integer overflow through temporary values

lnihlen created this revision. Herald added a project: All. lnihlen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes GH63629. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154253 Files: clang/lib/Sema/SemaChecki

[PATCH] D154253: [clang] detect integer overflow through temporary values

cjdb added a comment. > Fixes GH63629. Would you mind changing this to `Fixes #63629` please? That'll get it connected in GitHub. The patch looks good, would you mind adding some release notes before I give LGTM please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

eddyz87 added a comment. Hi Yonghong, What is the current plan for these changes? I'd like to refresh D140804 to make BPF_ST instruction available for cpu v4. I see that the latest CI run failed because of libcxx issue, I think it is completely unrelated to th

[PATCH] D154070: [lld/COFF] Add /dwodir to enable DWARF fission with LTO

mstorsjo added a comment. No objection from me here, this seems straightforward. We should probably add a corresponding option in the lld mingw frontend too (as a separate patch later). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154070/new/ htt

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

mstorsjo added a comment. Is this a NFC change, as a preparation for a separate change? In that case, please add an NFC tag to the subject - if not, please explain (and test) the expected behaviour change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D154229: [clang] Replace uses of CreateElementBitCast (NFC)

JOE1994 updated this revision to Diff 536398. JOE1994 added a comment. Rebase Wait to check whether the libCXX CI passes after rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154229/new/ https://reviews.llvm.org/D154229 Files: clang/lib/C

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 updated this revision to Diff 536394. jyu2 marked an inline comment as done. jyu2 added a comment. Thanks Alexey's review. This address Alexey's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154180/new/ https://reviews.llvm.org/D154

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11383 void CGOpenMPRuntime::emitDoacrossOrdered(CodeGenFunction &CGF, - const OMPDependClause *C) { + const OMPClause *

[PATCH] D154257: [clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test

hamishknight created this revision. hamishknight added a reviewer: bnbarham. hamishknight added a project: clang. Herald added subscribers: arphaman, martong. Herald added a project: All. hamishknight requested review of this revision. Herald added a subscriber: cfe-commits. Change `ASTUnit::LoadF

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11401-11402 llvm::Value *Args[] = { - emitUpdateLocation(CGF, C->getBeginLoc()), - getThreadID(CGF, C->getBeginLoc()), + RT.emitUpdateLocation(CGF, C->getBeginLoc()), + RT.getT

[PATCH] D154253: [clang] detect integer overflow through temporary values

shafik added a comment. Nice catch, I missed that in my last fix: https://reviews.llvm.org/D137897 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154253/new/ https://reviews.llvm.org/D154253 ___ cfe-commi

[PATCH] D154253: [clang] detect integer overflow through temporary values

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154253/new/ https://reviews.llvm.org/D154253 ___

[PATCH] D154253: [clang] detect integer overflow through temporary values

lnihlen updated this revision to Diff 536413. lnihlen added a comment. Add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154253/new/ https://reviews.llvm.org/D154253 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaChecking.

[PATCH] D154253: [clang] detect integer overflow through temporary values

lnihlen added a comment. Added release note, fixed commit log. PTAL, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154253/new/ https://reviews.llvm.org/D154253 ___ cfe-commits mailing list cfe-co

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + doru1004 wrote: > ABataev wrote: > > doru1004 wrote: >

[PATCH] D154207: [AMDGPU] Rename predefined macro __AMDGCN_WAVEFRONT_SIZE

jdoerfert added a comment. I think this is a step in the right direction. @arsenm ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154207/new/ https://reviews.llvm.org/D154207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D154257: [clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test

benlangmuir accepted this revision. benlangmuir added a comment. Gotta love `return AST.release()` being passed directly back into `std::unique_ptr(...)`. Thanks for fixing! Comment at: clang/tools/libclang/CIndex.cpp:3965 unsaved_files); - std::unique_ptr Unit(ASTUni

[PATCH] D154207: [AMDGPU] Rename predefined macro __AMDGCN_WAVEFRONT_SIZE

arsenm added a comment. lgtm except for dropping test coverage Comment at: clang/test/Driver/hip-macros.hip:20 // RUN: -mwavefrontsize64 %s 2>&1 | FileCheck --check-prefixes=WAVE64 %s -// WAVE64-DAG: #define __AMDGCN_WAVEFRONT_SIZE 64 -// WAVE32-DAG: #define __AMDGCN_WAVEFRO

[PATCH] D154257: [clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test

hamishknight updated this revision to Diff 536426. hamishknight added a comment. Updated to use explicit `std::unique_ptr` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154257/new/ https://reviews.llvm.org/D154257 Files: clang/include/clang/Frontend/ASTUnit.h clang/lib/CrossTU/Cros

[PATCH] D154257: [clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test

hamishknight marked an inline comment as done. hamishknight added inline comments. Comment at: clang/tools/libclang/CIndex.cpp:3965 unsaved_files); - std::unique_ptr Unit(ASTUnit::LoadFromCommandLine( + auto Unit = ASTUnit::LoadFromCommandLine( Args->data(), Args-

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix a FIXME from an earlier commit. Repository:

[PATCH] D154207: [AMDGPU] Rename predefined macro __AMDGCN_WAVEFRONT_SIZE

yaxunl updated this revision to Diff 536431. yaxunl marked 2 inline comments as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154207/new/ https://reviews.llvm.org/D154207 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/test/CodeGenH

[clang] 5f32baf - [clang] Replace uses of CreateElementBitCast (NFC)

Author: Youngsuk Kim Date: 2023-06-30T17:35:36-04:00 New Revision: 5f32baf17db172478f1081e3d345f08e1053579f URL: https://github.com/llvm/llvm-project/commit/5f32baf17db172478f1081e3d345f08e1053579f DIFF: https://github.com/llvm/llvm-project/commit/5f32baf17db172478f1081e3d345f08e1053579f.diff

[PATCH] D154229: [clang] Replace uses of CreateElementBitCast (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5f32baf17db1: [clang] Replace uses of CreateElementBitCast (NFC) (authored by JOE1994). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

<    1   2   3