[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

arsenm added a comment. Unrelated but can we get this to start reporting xnack and ecc? Comment at: clang/tools/amdgpu-arch/AMDGPUArchByHIP.cpp:80 +if (err != hipSuccess) { + llvm::errs() << "Failed to get device id for ordinal " << i << "\n"; + return 1;

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

arsenm added inline comments. Comment at: clang/tools/amdgpu-arch/AMDGPUArchByHIP.cpp:91 +} +printf("%s\n", prop.gcnArchName); + } llvm::outs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153725/new/ https://reviews.llvm.org/D153725 _

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

jhuber6 added a comment. In D153725#4463589 , @arsenm wrote: > Unrelated but can we get this to start reporting xnack and ecc? A lot of CMake relies on this just being an ordered list of architectures, so we'd probably need to make that an opt-in thing.

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: llvm/include/llvm/TargetParser/X86TargetParser.def:262 CPU_SPECIFIC("core_i7_sse4_2", "nehalem", 'P', "+cmov,+mmx,+sse,+sse2,+sse3,+ssse3,+sse4.1,+sse4.2,+popcnt") CPU_SPECIFIC("core_aes_pcl

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis updated this revision to Diff 536216. TIFitis added a comment. Rebased to fix build error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/te

[PATCH] D153006: [clang][dataflow] Perform deep copies in copy and move operations.

RKSimon added a comment. @mboehme https://lab.llvm.org/buildbot/#/builders/124 is still broken - please can you revert the patch series? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153006/new/ https://reviews.llvm.org/D153006 __

[PATCH] D135849: [clang][deps][lex] Avoid canonicalization of remapped framework directories (take 2)

jansvoboda11 updated this revision to Diff 536224. jansvoboda11 added a comment. Return canonical virtual path from `RedirectingFileSystem` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135849/new/ https://reviews.llvm.org/D135849 Files: clang/l

[PATCH] D152109: Update clang-repl documentation

Krishna-13-cyber updated this revision to Diff 536221. Krishna-13-cyber marked 2 inline comments as done. Krishna-13-cyber added a comment. - Update with addressing the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152109/new/ https://revi

[PATCH] D152554: [OpenMP] Migrate deviice code privatization from Clang CodeGen to OMPIRBuilder

TIFitis updated this revision to Diff 536226. TIFitis marked 4 inline comments as done. TIFitis added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152554/new/ https://reviews.llvm.org/D152554 Files: clang

[PATCH] D152554: [OpenMP] Migrate deviice code privatization from Clang CodeGen to OMPIRBuilder

TIFitis added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:1444 +/// alloca address where the runtime returns the device pointers. +llvm::DenseMap CaptureDeviceAddrMap; }; jdoerfert wrote: > If it is an alloca (for sure) use `llvm::

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber added a comment. In D147888#4463163 , @tbaeder wrote: > Ping. Thanks for the ping! Does this require any further modification? I think if we will have to change the whole set of diagnostics if we go with this change of `pick exactly one

[PATCH] D135849: [llvm] Return canonical virtual path from `RedirectingFileSystem`

jansvoboda11 added a comment. Module map canonicalization in `clang-scan-deps` causes issues even after D135841 landed. Here's the problematic scenario this patch aims to solve: - there is a framework `FW` whose headers (but not module maps) are redirected in

[PATCH] D135849: [llvm] Return canonical virtual path from `RedirectingFileSystem`

jansvoboda11 added a comment. Just realized this most likely won't work if the case-insensitive VFS is specified with wrong spelling too, e.g. `Fw.framework`. Maybe we'll need to combine this patch with one of the alternatives after all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 0d8d718 - [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

Author: Akash Banerjee Date: 2023-06-30T15:12:28+01:00 New Revision: 0d8d718171192301f2beb10bd08ce62e70281a5e URL: https://github.com/llvm/llvm-project/commit/0d8d718171192301f2beb10bd08ce62e70281a5e DIFF: https://github.com/llvm/llvm-project/commit/0d8d718171192301f2beb10bd08ce62e70281a5e.diff

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d8d71817119: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder (authored by TIFitis). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl marked 5 inline comments as done. yaxunl added inline comments. Comment at: clang/docs/HIPSupport.rst:33 + + clang -c --offload-arch=gfx906 test.hip -o test.o + scchan wrote: > can we add -xhip to enable HIP for files without the .hip file ext? will do

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

probinson added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:3474 +/// IF __M[j+31] == 1 +/// result[j+31:j] := Load32(__X+(i*4)) +/// ELSE pengfei wrote: > probinson wrote: > > pengfei wrote: > > > probinson wrote: > > > > pengfei wrote: >

[PATCH] D154123: [HIP] Start document HIP support by clang

yaxunl updated this revision to Diff 536231. yaxunl marked 4 inline comments as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154123/new/ https://reviews.llvm.org/D154123 Files: clang/docs/HIPSupport.rst Index: clang/docs/HIPSupport.

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1605-1609 +(CGM.getContext().getTargetInfo().getTriple().isAMDGPU() || + CGM.getContext().getTargetInfo().getTriple().isNVPTX())) { + CGOpenMPRuntimeGPU &RT = + *(static_cast(&C

[PATCH] D154221: Fix false negative when implicit cast nil to nonnull

tripleCC created this revision. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. tripleCC requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

yaxunl added a comment. In D153725#4463589 , @arsenm wrote: > Unrelated but can we get this to start reporting xnack and ecc? Using HIP runtime reports xnack and ecc. It reports the target ID including the accurate xnack and ecc feature which is ready t

[clang] cec30e2 - [dataflow] Fix complie on gcc7 part 2

Author: Donát Nagy Date: 2023-06-30T16:27:36+02:00 New Revision: cec30e2b190bd58a26f54b5fd4232d3828632466 URL: https://github.com/llvm/llvm-project/commit/cec30e2b190bd58a26f54b5fd4232d3828632466 DIFF: https://github.com/llvm/llvm-project/commit/cec30e2b190bd58a26f54b5fd4232d3828632466.diff LO

[PATCH] D154207: [AMDGPU] Rename predefined macro __AMDGCN_WAVEFRONT_SIZE

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:318 + Builder.defineMacro("__AMDGCN_WAVEFRONT_SIZE__", Twine(WavefrontSize)); + // ToDo: deprecate this macro for naming consistency. arsenm

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

donat.nagy added a comment. When I tried to compile with gcc 7.5 after your fix commit (2f7d30dee826 ), I got another very similar compilation error from a different location and I pushed commit cec30e2b190b

[PATCH] D151963: [clang][NFC] Remove trailing whitespaces and enforce it in lib, include and docs

eddyz87 added inline comments. Comment at: libcxx/utils/ci/buildkite-pipeline-clang.yml:20-31 + - label: "Format" +commands: + - "! grep -rnI '[[:blank:]]$' clang/lib clang/include clang/docs || false" + +agents: + queue: "libcxx-builders" + os: "linux" -

[PATCH] D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

evelez7 updated this revision to Diff 536245. evelez7 marked an inline comment as done. evelez7 added a comment. Move semicolon line below After fragment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154038/new/ https://reviews.llvm.org/D154038 Fi

[clang] ac65cc1 - [OpenMP][OpenMPIRBuilder] Migrate kernel launch code and host fallback code generation from Clang to the OpenMPIRBuilder

Author: Jan Sjodin Date: 2023-06-30T10:40:21-04:00 New Revision: ac65cc1215132b4725ed64b726671867a028e275 URL: https://github.com/llvm/llvm-project/commit/ac65cc1215132b4725ed64b726671867a028e275 DIFF: https://github.com/llvm/llvm-project/commit/ac65cc1215132b4725ed64b726671867a028e275.diff LO

[PATCH] D151035: [OpenMP][OpenMPIRBuilder] Migrate kernel launch code and host fallback code generation from Clang to the OpenMPIRBuilder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac65cc121513: [OpenMP][OpenMPIRBuilder] Migrate kernel launch code and host fallback code… (authored by jsjodin). Herald added a project: clang. Hera

[clang] a5ea676 - Reverting commit 0d8d718171192301f2beb10bd08ce62e70281a5e as it broke libomptarget tests

Author: Akash Banerjee Date: 2023-06-30T16:03:57+01:00 New Revision: a5ea6760674762cb597cf328dc467f1296633da0 URL: https://github.com/llvm/llvm-project/commit/a5ea6760674762cb597cf328dc467f1296633da0 DIFF: https://github.com/llvm/llvm-project/commit/a5ea6760674762cb597cf328dc467f1296633da0.diff

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/tools/amdgpu-arch/AMDGPUArch.cpp:47 - // Attempt to load the HSA runtime. - if (llvm::Error Err = loadHSA()) { -logAllUnhandledErrors(std::move(Err), llvm::errs()); -return 1; -

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

yaxunl updated this revision to Diff 536257. yaxunl marked 3 inline comments as done. yaxunl added a reviewer: arsenm. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153725/new/ https://reviews.llvm.org/D153725 Files: clang/tools/amdgpu-arch

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Headers/avx2intrin.h:3474 +/// IF __M[j+31] == 1 +/// result[j+31:j] := Load32(__X+(i*4)) +/// ELSE probinson wrote: >

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

yaxunl added a comment. I tested the program on Windows and Linux and it works. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153725/new/ https://reviews.llvm.org/D153725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis added a comment. In D154014#4462886 , @MaskRay wrote: > In D154014#4461076 , @rupprecht > wrote: > >> In D154014#4457883 , @MaskRay >> wrote: >> This is a bre

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen updated this revision to Diff 536260. sdesmalen marked 11 inline comments as done. sdesmalen added a comment. Updated patch: - Addressed review comments (clarified documentation, minor refactoring) - Added new tests (codegen + sema tests to make sure attributes are propagated to types

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen added inline comments. Comment at: clang/include/clang/AST/Type.h:3940 +/// on declarations and function pointers. +unsigned AArch64SMEAttributes : 8; + erichkeane wrote: > sdesmalen wrote: > > erichkeane wrote: > > > sdesmalen wrote: > > > > er

[clang] 1d75b18 - [analyzer][NFC] Fix dangling StringRef in barely used code

Author: Donát Nagy Date: 2023-06-30T17:15:43+02:00 New Revision: 1d75b18843fbca52655e240a120b5fdeeef17c0e URL: https://github.com/llvm/llvm-project/commit/1d75b18843fbca52655e240a120b5fdeeef17c0e DIFF: https://github.com/llvm/llvm-project/commit/1d75b18843fbca52655e240a120b5fdeeef17c0e.diff LO

[PATCH] D153889: [analyzer][NFC] Fix dangling StringRef in barely used code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d75b18843fb: [analyzer][NFC] Fix dangling StringRef in barely used code (authored by donat.nagy). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1605-1609 +(CGM.getContext().getTargetInfo().getTriple().isAMDGPU() || + CGM.getContext().getTargetInfo().getTriple().isNVPTX())) { + CGOpenMPRuntimeGPU &RT = + *(static_cast(&CG

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. In D153092#4452251 , @AlexVlx wrote: > In D153092#4452070 , @yaxunl wrote: > >> This could be a good chance t

[clang] 1461fab - [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

Author: Paul Robinson Date: 2023-06-30T08:31:02-07:00 New Revision: 1461fabfb141699cb1b9ffbe37abf73fa3d78b74 URL: https://github.com/llvm/llvm-project/commit/1461fabfb141699cb1b9ffbe37abf73fa3d78b74 DIFF: https://github.com/llvm/llvm-project/commit/1461fabfb141699cb1b9ffbe37abf73fa3d78b74.diff

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1461fabfb141: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h (authored by probinson). Herald added a project: clang. R

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

probinson added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153993/new/ https://reviews.llvm.org/D153993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

bazuzi updated this revision to Diff 536269. bazuzi added a comment. Updated function comment to remove unnecessary repetition and include newly-discovered caveat re: flow conditions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153805/new/ https

[PATCH] D153681: [X86] Move back _mulx_u32 to 32-bit only

probinson added a comment. I'm okay with putting this back if the codegen (D153620 ) can't be resolved. Honestly I didn't think it was a problem. But I think Craig or Simon should sign off. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

jhuber6 added inline comments. Comment at: clang/tools/amdgpu-arch/AMDGPUArch.cpp:47 - // Attempt to load the HSA runtime. - if (llvm::Error Err = loadHSA()) { -logAllUnhandledErrors(std::move(Err), llvm::errs()); -return 1; - } - - hsa_status_t Status = hsa_init();

[PATCH] D153776: [clang][analyzer] Display notes in StdLibraryFunctionsChecker only if interesting

donat.nagy requested changes to this revision. donat.nagy added a comment. This revision now requires changes to proceed. Thanks for attaching the test results! Unfortunately it seems that it was important to look at them, because I noticed that in the posgresql codebase there are many bug repor

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

donat.nagy added a comment. See results and their discussion on the review of the tightly connected follow-up commit D153776 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153612/new/ https://reviews.llvm.org/D15

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/tools/amdgpu-arch/AMDGPUArch.cpp:47 - // Attempt to load the HSA runtime. - if (llvm::Error Err = loadHSA()) { -logAllUnhandledErrors(std::move(Err), llvm::errs()); -return 1; -

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

jhuber6 added a comment. Also w.r.t. target-id, I'm wondering what a good solution would be. Right now the main usage of `amdgpu-arch` is both to detect the `-mcpu / -march` in CMake and to fill in the architecture via `--offload-arch=native` or `-fopenmp-target=amdgcn-amd-amdhsa`. We may want

[PATCH] D135849: [llvm] Return canonical virtual path from `RedirectingFileSystem`

benlangmuir added a comment. > Just realized this most likely won't work if the case-insensitive VFS is > specified with wrong spelling too, e.g. Fw.framework. Is this about the spelling in the VFS definition itself, or about the path being looked up? If it's the VFS definition maybe we can say

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

arsenm added inline comments. Comment at: clang/tools/amdgpu-arch/AMDGPUArch.cpp:47 - // Attempt to load the HSA runtime. - if (llvm::Error Err = loadHSA()) { -logAllUnhandledErrors(std::move(Err), llvm::errs()); -return 1; - } - - hsa_status_t Status = hsa_init();

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

jhuber6 added inline comments. Comment at: clang/tools/amdgpu-arch/AMDGPUArch.cpp:47 - // Attempt to load the HSA runtime. - if (llvm::Error Err = loadHSA()) { -logAllUnhandledErrors(std::move(Err), llvm::errs()); -return 1; - } - - hsa_status_t Status = hsa_init();

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

jhuber6 added inline comments. Comment at: clang/tools/amdgpu-arch/AMDGPUArch.cpp:47 - // Attempt to load the HSA runtime. - if (llvm::Error Err = loadHSA()) { -logAllUnhandledErrors(std::move(Err), llvm::errs()); -return 1; - } - - hsa_status_t Status = hsa_init();

[clang] e5cc56a - [clang] Update cxx_status for 632dd6a4ca0036009f

Author: Yuanfang Chen Date: 2023-06-30T09:10:33-07:00 New Revision: e5cc56a0d1026ca25410b3abea64496c13bfbbe3 URL: https://github.com/llvm/llvm-project/commit/e5cc56a0d1026ca25410b3abea64496c13bfbbe3 DIFF: https://github.com/llvm/llvm-project/commit/e5cc56a0d1026ca25410b3abea64496c13bfbbe3.diff

[PATCH] D154043: [CodeGen] -fsanitize={function, kcfi}: ensure align 4 if +strict-align

MaskRay abandoned this revision. MaskRay added a comment. Obsoleted by D154125 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154043/new/ https://reviews.llvm.org/D154043 __

[PATCH] D154229: [clang] Replace uses of CreateElementBitCast (NFC)

JOE1994 created this revision. JOE1994 added a reviewer: barannikov88. Herald added a project: All. JOE1994 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Partial progress towards replacing uses of CreateElementBitCast, as it no longer doe

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 updated this revision to Diff 536288. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153883/new/ https://reviews.llvm.org/D153883 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGOpenMPRuntime.h clang/lib/CodeGen/CGOpenMPRuntime

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 marked 3 inline comments as done. doru1004 added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1605-1609 +(CGM.getContext().getTargetInfo().getTriple().isAMDGPU() || + CGM.getContext().getTargetInfo().getTriple().isNVPTX())) { + CGOpenMPR

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

sammccall accepted this revision. sammccall added a comment. Thanks! As discussed offline, I had some concerns about whether there were any cases where it was safe to use formulas separate from the FC that might constrain them. But we found some: these are formulas produced by the downstream an

[PATCH] D154091: [clang-format] Prefer breaking long strings at new lines

MyDeveloperDay added a comment. is there a git issue for this, I'm struggling to understand the problem we are solving. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154091/new/ https://reviews.llvm.org/D154091 ___

[PATCH] D154191: [LTO] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. This is generally fine. I don't see any error that should fall into `consumeError` condition that won't just error out anyway (like out of disk space, etc.) and I don't see those are spe

[PATCH] D152857: OpenMP: Don't use target regions in library function test

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152857/new/ https://reviews.llvm.org/D152857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

bazuzi updated this revision to Diff 536293. bazuzi added a comment. Rebase on main to pull in change from DenseSet to SetVector. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153805/new/ https://reviews.llvm.org/D153805 Files: clang/include/cla

[clang] 40bb302 - clang: Add start of header test for __clang_hip_libdevice_declares

Author: Matt Arsenault Date: 2023-06-30T12:39:11-04:00 New Revision: 40bb302c451ec1a8f6a2b8238e0a56448b8e1a12 URL: https://github.com/llvm/llvm-project/commit/40bb302c451ec1a8f6a2b8238e0a56448b8e1a12 DIFF: https://github.com/llvm/llvm-project/commit/40bb302c451ec1a8f6a2b8238e0a56448b8e1a12.diff

[PATCH] D152829: clang: Add start of header test for __clang_hip_libdevice_declares

arsenm closed this revision. arsenm added a comment. 40bb302c451ec1a8f6a2b8238e0a56448b8e1a12 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152829/new/ https://reviews.llvm.org/D152829 __

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

sammccall added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:183 + /// been stored in flow conditions. + Solver::Result querySolver(llvm::DenseSet Constraints); + sammccall wrote: > sammccall wrote: > > FWIW

[PATCH] D153375: [Clang] Fix incorrect use of direct initialization with copy initialization

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM but can you add a line in Release Notes? Thanks Comment at: clang/test/CXX/dcl.decl/dcl.init/dcl.init.list/p3.cpp:292 + E e; + e = {0}; // expected-error {{cannot

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

bazuzi added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:183 + /// been stored in flow conditions. + Solver::Result querySolver(llvm::DenseSet Constraints); + sammccall wrote: > sammccall wrote: > > FWIW, I

[PATCH] D154145: [HIP] Fix -mllvm option for device lld linker

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIPAMD.cpp:164 +StringRef ArgVal = Arg->getValue(1); +if (ArgVal.startswith("-mllvm=")) { + ArgVal = ArgVal.substr(strlen("-mllvm=")); jhub

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:183 + /// been stored in flow conditions. + Solver::Result querySolver(llvm::DenseSet Constraints); + sammccal

[clang] aa964f1 - [HIP] Fix -mllvm option for device lld linker

Author: Yaxun (Sam) Liu Date: 2023-06-30T12:54:38-04:00 New Revision: aa964f157f9b50fab3895afbfda6e0915cf6bb4a URL: https://github.com/llvm/llvm-project/commit/aa964f157f9b50fab3895afbfda6e0915cf6bb4a DIFF: https://github.com/llvm/llvm-project/commit/aa964f157f9b50fab3895afbfda6e0915cf6bb4a.dif

[PATCH] D154145: [HIP] Fix -mllvm option for device lld linker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGaa964f157f9b: [HIP] Fix -mllvm option for device lld linker (authored by yaxunl). Herald added a project: cl

[clang] 62e4c22 - [clang] Fix ASTUnit working directory handling

Author: Hamish Knight Date: 2023-06-30T09:56:42-07:00 New Revision: 62e4c22c95a9c5fbbebded43388006d5fed3b613 URL: https://github.com/llvm/llvm-project/commit/62e4c22c95a9c5fbbebded43388006d5fed3b613 DIFF: https://github.com/llvm/llvm-project/commit/62e4c22c95a9c5fbbebded43388006d5fed3b613.diff

[PATCH] D154134: [clang] Fix ASTUnit working directory handling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62e4c22c95a9: [clang] Fix ASTUnit working directory handling (authored by hamishknight, committed by bnbarham). Repository: rG LLVM Github Monorep

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx added a comment. Thank you @yaxunl. @rjmccall / @efriedma any input on this? I'd like to try landing it next week to unblock some additional work. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153092/new/ https://reviews.llvm.org/D153092 __

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

sammccall added a comment. LG as is, sorry for the noise! Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:183 + /// been stored in flow conditions. + Solver::Result querySolver(llvm::DenseSet Constraints); + gribozavr2 wrote:

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

bazuzi added a comment. It looks like D153485 changes the context for the last few comments significantly. What's the appetite for adding yet another child commit to the chain D153485 is in that exposes the solver directly? I

[PATCH] D154229: [clang] Replace uses of CreateElementBitCast (NFC)

barannikov88 accepted this revision. barannikov88 added a comment. This revision is now accepted and ready to land. Looks pretty straightforward. Comment at: clang/lib/CodeGen/CGClass.cpp:1000 + SrcPtr = SrcPtr.withElementType(CGF.Int8Ty); CGF.Builder.CreateMemCpy(D

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

sammccall added a comment. In D153805#4464487 , @bazuzi wrote: > It looks like D153485 changes the context > for the last few comments significantly. What's the appetite for adding yet > another child commit to the cha

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:590-591 +void Emit(CodeGenFunction &CGF, Flags EmissionFlags) override { + CGOpenMPRuntimeGPU &RT = + *(static_cast(&CGF.CGM.getOpenMPRuntime())); + RT.getKmpcFreeShared(CGF, AddrSizePa

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + ABataev wrote: > 1. Is it possible that VariableArrayT

[PATCH] D152109: Update clang-repl documentation

v.g.vassilev accepted this revision. v.g.vassilev added a comment. LGTM! If you don't have commit access I can commit this on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152109/new/ https://reviews.llvm.org/D152109 _

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

cjdb added a comment. In D153359#4463009 , @tbaeder wrote: > @cjdb I know this is kind of silly after @hazohelet has already added it to > the release notes... but it seems like showing the difference is useless > since the difference was only introduce

[PATCH] D154229: [clang] Replace uses of CreateElementBitCast (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGClass.cpp:1000 + SrcPtr = SrcPtr.withElementType(CGF.Int8Ty); CGF.Builder.CreateMemCpy(DestPtr, SrcPtr, Size.getQuantity()); } barannikov88 wrote: > Just something to think about. > C

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

ABataev added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + doru1004 wrote: > ABataev wrote: > > 1. Is it possible

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

craig.topper added inline comments. Comment at: llvm/include/llvm/TargetParser/X86TargetParser.def:275 CPU_SPECIFIC("core_5th_gen_avx_tsx", "broadwell", 'Y', "+cmov,+mmx,+sse,+sse2,+sse3,+ssse3,+sse4.1,+sse4.2,+movbe,+popcnt,+f16c,+avx,+fma,+bmi,+lzcnt,+avx2,+adx") -CPU_SPECIFI

[PATCH] D153659: [RISCV] Fix name mangling for LMUL!=1 vector types with attribute(rvv_vector_bits)

craig.topper added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153659/new/ https://reviews.llvm.org/D153659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 updated this revision to Diff 536321. doru1004 marked 4 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153883/new/ https://reviews.llvm.org/D153883 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGOpenMPRu

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1605-1606 +if (getLangOpts().OpenMPIsDevice) { + CGOpenMPRuntimeGPU &RT = + *(static_cast(&CGM.getOpenMPRuntime())); + if (RT.isDelayedVariableLengthDecl(*this, &D)) {

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/Formula.h:27 +/// +/// This often represents an assertion that is interesting to the analysis but +/// cann

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 updated this revision to Diff 536322. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153883/new/ https://reviews.llvm.org/D153883 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGOpenMPRuntime.h clang/lib/CodeGen/CGOpenMPRuntime

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

ABataev added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2168 +ElementType = VLAType->getElementType(); +llvm::Value *VLASize = VLASizeMap[VLAType->getSizeExpr()]; +if (!VLASize) Use VLASizeMap.find() instead

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + ABataev wrote: > doru1004 wrote: > > ABataev wrote: >

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

bazuzi added a comment. Since the timeline for being able to use this is dependent not only on commits but integrates as well, lets go ahead with this then. Can someone commit it for me when we're ready? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

dblaikie added a comment. In D152017#4462263 , @probinson wrote: >> we might emit member function declarations for call sites in DWARF, for >> instance > > So are you now leaning more toward wanting to emit the "used" declarations as > well? I'm sure yo

[PATCH] D154229: [clang] Replace uses of CreateElementBitCast (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGClass.cpp:1000 + SrcPtr = SrcPtr.withElementType(CGF.Int8Ty); CGF.Builder.CreateMemCpy(DestPtr, SrcPtr, Size.getQuantity()); } JOE1994 wrote: > barannikov88 wrote: > > Just somet

[PATCH] D152109: Update clang-repl documentation

Krishna-13-cyber added a comment. In D152109#4464563 , @v.g.vassilev wrote: > LGTM! If you don't have commit access I can commit this on your behalf. Yes, It would be great if you could land it on my behalf! Thanks. Repository: rG LLVM Github Monore

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 updated this revision to Diff 536326. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153883/new/ https://reviews.llvm.org/D153883 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGOpenMPRuntime.h clang/lib/CodeGen/CGOpenMPRuntime

[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

rsmith added a comment. LGTM, thank you for doing this! Comment at: clang/lib/Sema/SemaExpr.cpp:18201 +// Hence, in correct code any cleanup objects created inside current +// evaluation context must be outside the immediate invocation. +E = ExprWithCleanups::Create

<    1   2   3   >