[PATCH] D154253: [clang] detect integer overflow through temporary values

aeubanks added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:15215 Exprs.append(Construct->arg_begin(), Construct->arg_end()); +else if (auto Temporary = dyn_cast(E)) + Exprs.push_back(Temporary->getSubExpr()); nit: `clang::` isn't

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 updated this revision to Diff 536443. jyu2 added a comment. Thanks Alexey!!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154180/new/ https://reviews.llvm.org/D154180 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenM

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11401-11402 llvm::Value *Args[] = { - emitUpdateLocation(CGF, C->getBeginLoc()), - getThreadID(CGF, C->getBeginLoc()), + RT.emitUpdateLocation(CGF, C->getBeginLoc()), + RT.getThre

[PATCH] D153375: [Clang] Fix incorrect use of direct initialization with copy initialization

shafik updated this revision to Diff 536451. shafik marked an inline comment as done. shafik added a comment. - Added release note - Added test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153375/new/ https://reviews.llvm.org/D153375 Files: clang/docs/ReleaseNotes.rst clang/l

[clang] 3b29b8a - Expose DataflowAnalysisContext.querySolver().

Author: Samira Bazuzi Date: 2023-07-01T00:15:45+02:00 New Revision: 3b29b8a2aba205b59163ba11c537fbfe25133181 URL: https://github.com/llvm/llvm-project/commit/3b29b8a2aba205b59163ba11c537fbfe25133181 DIFF: https://github.com/llvm/llvm-project/commit/3b29b8a2aba205b59163ba11c537fbfe25133181.diff

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b29b8a2aba2: Expose DataflowAnalysisContext.querySolver(). (authored by bazuzi, committed by gribozavr). Repository: rG LLVM Github Monorepo CHA

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

iains updated this revision to Diff 536457. iains added a comment. just rebased to support p1815 work Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145965/new/ https://reviews.llvm.org/D145965 Files: clang/include/clang/Basic/DiagnosticSemaKinds

[PATCH] D153989: [compiler-rt] Move crt into builtins

phosek added a comment. @smeenai Do you have any opinion on this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153989/new/ https://reviews.llvm.org/D153989 ___ cfe-commits mailing list cfe-commit

[PATCH] D154253: [clang] detect integer overflow through temporary values

lnihlen updated this revision to Diff 536466. lnihlen added a comment. remove extrneous clang:: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154253/new/ https://reviews.llvm.org/D154253 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaCh

[PATCH] D153375: [Clang] Fix incorrect use of direct initialization with copy initialization

rsmith added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15441-15443 // C++11 5.17p9: // The meaning of x = {v} [...] is that of x = T(v) [...]. The meaning // of x = {} is x = T(). The code change doesn't match this comment, which

[PATCH] D153989: [compiler-rt] Move crt into builtins

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Sorry, it's been a week :D I assume that crt doesn't need the builtins to be available for its configure (the way the rest of compiler-rt does)? If so, this LGTM. Comment

[PATCH] D153375: [Clang] Fix incorrect use of direct initialization with copy initialization

rsmith requested changes to this revision. rsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/test/CXX/dcl.decl/dcl.init/dcl.init.list/p3.cpp:293 + e = {E::E1}; + e = {0}; // expected-error {{cannot initialize a value of type 'E' with

[PATCH] D154270: [clang][CodeGen] Fix global variables initialized with an inheriting constructor.

efriedma created this revision. efriedma added reviewers: rsmith, rnk, rjmccall, akhuang. Herald added a subscriber: kristof.beyls. Herald added a project: All. efriedma requested review of this revision. Herald added a project: clang. For inheriting constructors which have to be emitted inline, w

[PATCH] D154270: [clang][CodeGen] Fix global variables initialized with an inheriting constructor.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Wow, what an amazing bug :) Comment at: clang/lib/CodeGen/CGDecl.cpp:2459 + if (!isa(Arg.getAnyValue())) +Arg.getAnyValue()->setName(D.getName()); Is

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + doru1004 wrote: > doru1004 wrote: > > ABataev wrote: >

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

ABataev added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + doru1004 wrote: > doru1004 wrote: > > doru1004 wrote: >

[clang] a57bdc8 - [clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test

Author: Hamish Knight Date: 2023-06-30T16:02:12-07:00 New Revision: a57bdc8fe68753c341cac0fcecabcd4d35e45466 URL: https://github.com/llvm/llvm-project/commit/a57bdc8fe68753c341cac0fcecabcd4d35e45466 DIFF: https://github.com/llvm/llvm-project/commit/a57bdc8fe68753c341cac0fcecabcd4d35e45466.diff

[PATCH] D154257: [clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa57bdc8fe687: [clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test (authored by hamishknight, committed by bnbarham). Changed prior to

[clang] b776e2a - [clang] detect integer overflow through temporary values

Author: Lucile Nihlen Date: 2023-06-30T23:19:04Z New Revision: b776e2a0b03e93c45deb92f36a391d457ae5b43f URL: https://github.com/llvm/llvm-project/commit/b776e2a0b03e93c45deb92f36a391d457ae5b43f DIFF: https://github.com/llvm/llvm-project/commit/b776e2a0b03e93c45deb92f36a391d457ae5b43f.diff LOG:

[PATCH] D154253: [clang] detect integer overflow through temporary values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb776e2a0b03e: [clang] detect integer overflow through temporary values (authored by lnihlen). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D154251: Add a flag to disable "duplicate definition of category" warnings

ahatanak updated this revision to Diff 536479. ahatanak added a comment. Fix clang/test/Misc/warning-flags.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154251/new/ https://reviews.llvm.org/D154251 Files: clang/include/clang/Basic/DiagnosticCo

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + ABataev wrote: > doru1004 wrote: > > doru1004 wrote: >

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + doru1004 wrote: > ABataev wrote: > > doru1004 wrote: >

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

ABataev added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + doru1004 wrote: > doru1004 wrote: > > ABataev wrote: >

[PATCH] D153989: [compiler-rt] Move crt into builtins

phosek added a comment. In D153989#4465759 , @smeenai wrote: > Sorry, it's been a week :D I assume that crt doesn't need the builtins to be > available for its configure (the way the rest of compiler-rt does)? If so, > this LGTM. Great question, I chec

[PATCH] D153989: [compiler-rt] Move crt into builtins

smeenai added a comment. In D153989#4465907 , @phosek wrote: > In D153989#4465759 , @smeenai wrote: > >> Sorry, it's been a week :D I assume that crt doesn't need the builtins to be >> available for its configure

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + ABataev wrote: > doru1004 wrote: > > doru1004 wrote: >

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 updated this revision to Diff 536489. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153883/new/ https://reviews.llvm.org/D153883 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGOpenMPRuntime.h clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/CodeGen/CGOpenMPRun

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added a comment. @ABataev This is as close as I could get it to what you wanted. I don't know how to get hold of the target directive so late in the emission process i.e. in markedAsEscaped function. The target directive doesn't get visited in the var checked for escaped vars so I cann

[PATCH] D154070: [lld/COFF] Add /dwodir to enable DWARF fission with LTO

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a631a8fedc2: [lld/COFF] Add /dwodir to enable DWARF fission with LTO (authored by HaohaiWen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154070/new/ htt

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added a comment. In any case the patch is good to go. It no longer relies on VLA size checks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153883/new/ https://reviews.llvm.org/D153883 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

FreddyYe updated this revision to Diff 536495. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Address comment, thanks review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154209/new/ https://reviews.llvm.org/D154209 Files:

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

h-vetinari added a comment. In D129635#4451189 , @saiislam wrote:> > Are there any features in this table which have been already implemented but > have not been tagged? > https://clang.llvm.org/docs/OpenMPSupport.html#openmp-5-1-implementation-details

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

HaohaiWen updated this revision to Diff 536502. HaohaiWen added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154176/new/ https://reviews.llvm.org/D154176 Files: clang/lib/Driver/ToolChains/MSVC.cpp clang/test/Driver/msvc-

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

owenpan updated this revision to Diff 536501. owenpan added a comment. Don't fix the token type of */&/&& if the line is a function declaration. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154184/new/ https://reviews.llvm.org/D154184 Files: clang/lib/Format/TokenAnnotator.cpp cla

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

HaohaiWen added a comment. In D154176#4465223 , @mstorsjo wrote: > Is this a NFC change, as a preparation for a separate change? In that case, > please add an NFC tag to the subject - if not, please explain (and test) the > expected behaviour change. T

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw added a comment. See the updated summary. There does not seem to be an issue on GitHub when I searched. I simply noticed it when reading the code in order to understand how strings got broken. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D154251: Add a flag to disable "duplicate definition of category" warnings

vsapsai accepted this revision. vsapsai added a comment. This revision is now accepted and ready to land. As long as there are no other failing tests, looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154251/new/ https://reviews.llvm.

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

sandeepkosuri added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9818 + D.hasClausesOfKind() || + (CGM.getLangOpts().OpenMP >= 51 && D.getDirectiveKind() == OMPD_target && + D.hasClausesOfKind()); ABataev wrote: > What if D i

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3320 + // Annotate */&/&& in `operator` function calls as binary operators. + for (const auto *Tok = Line.First; Tok; Tok = Tok->Next) { rymiel wrote: > I assume this extra fixup s

[PATCH] D154191: [LTO] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein marked an inline comment as done. hokein added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154191/new/ https://reviews.llvm.org/D154191 ___ cfe-commits mailing

[PATCH] D154191: [LTO] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein closed this revision. hokein added a comment. committed in 6ecc6b1250b253816703cbca18af432b95fb4089 and dc6c8b8d1e357acf6440824afaf6b6547b34aeeb .

[PATCH] D154186: [clang][DeclPrinter] Fix AST print of delegating constructors

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. strimo378 added a project: clang. Herald added a project: All. strimo378 requested review of this revision. Herald added a subscriber: cfe-commits. DeclPrinter::PrintConstructorInitializers did not consider delegating ini

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

pengfei added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:3474 +/// IF __M[j+31] == 1 +/// result[j+31:j] := Load32(__X+(i*4)) +/// ELSE probinson wrote: > pengfei wrote: > > probinson wrote: > > > pengfei wrote: > > > > A more intrinsic g

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

MaskRay added a comment. In D154014#4461076 , @rupprecht wrote: > In D154014#4457883 , @MaskRay wrote: > >>> This is a breaking change since some SCLs might use .* or (abc|def) which >>> are supported regexes but

[PATCH] D153652: [Support] Don't set "all_exe" mode by default for file written by llvm::writeToOutput

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1233e2e66831: [Support] Don't set "all_exe" mode by default for file written by llvm… (authored by hokein). Repository: rG LLVM Github Monorepo C

[PATCH] D153776: [clang][analyzer] Display notes in StdLibraryFunctionsChecker only if interesting

balazske updated this revision to Diff 536133. balazske added a comment. Rebase to newest parent review version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153776/new/ https://reviews.llvm.org/D153776 Files: clang/lib/StaticAnalyzer/Checkers/

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

kito-cheng accepted this revision. kito-cheng added a comment. LGTM, Give my blessing, thanks for moving this forward :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 ___

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

phosek added a comment. If we want to support both regular expressions and glob patterns permanently, then a solution like `#!regex` or `#!glob` is likely the way to go. If we want to allow soft-transition, then we could do something like `#!special-case-list-v2`, where v1 would support regular

[PATCH] D154189: [clang][Interp] Implement zero-init of record types

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Unify `CXXTemporaryObjectExpr` and `CXXConstructExp

[clang-tools-extra] 2feac34 - [clangd] Replace writeFileAtomically with writeToOutput, NFC

Author: Haojian Wu Date: 2023-06-30T10:02:42+02:00 New Revision: 2feac34aeeaf67943492a5adfe45c3f4767bdfe4 URL: https://github.com/llvm/llvm-project/commit/2feac34aeeaf67943492a5adfe45c3f4767bdfe4 DIFF: https://github.com/llvm/llvm-project/commit/2feac34aeeaf67943492a5adfe45c3f4767bdfe4.diff LO

[PATCH] D153849: [clang][Diagnostics] Fix diagnostic line numbers

tbaeder added a comment. That works as well as far as I know, but I changed it locally to just use the issue ID anyway. Could you set the status to accepted? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153849/new/ https://reviews.llvm.or

[clang] db15ace - [clang] NFC, replace llvm::writeFileAtomically with llvm::writeToOutput

Author: Haojian Wu Date: 2023-06-30T10:18:49+02:00 New Revision: db15ace6ab667af302f8788ab2a14c3382522ed4 URL: https://github.com/llvm/llvm-project/commit/db15ace6ab667af302f8788ab2a14c3382522ed4 DIFF: https://github.com/llvm/llvm-project/commit/db15ace6ab667af302f8788ab2a14c3382522ed4.diff LO

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

owenpan updated this revision to Diff 536139. owenpan added a comment. Early break if `operator` is `TT_FunctionDeclarationName`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154184/new/ https://reviews.llvm.org/D154184 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Fo

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

RKSimon added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific.c:47 // LINUX: %[[FEAT_INIT:.+]] = load i32, ptr getelementptr inbounds ({ i32, i32, i32, [1 x i32] }, ptr @__cpu_model, i32 0, i32 3, i32 0), align 4 -// LINUX: %[[FEAT_JOIN:.+]] = and i32 %[[FEAT_I

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

cor3ntin added a comment. It would be great if we could make progress on this for clang 17, I was told it's forcing some people to use other compilers. Are the recent changes to the itanium abi enough to complete this work? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/ne

[PATCH] D153849: [clang][Diagnostics] Fix diagnostic line numbers

tbaeder added a comment. @cor3ntin Thanks. You're very close to getting on my default reviewer list though, so be careful ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153849/new/ https://reviews.llvm.org/D153849 __

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific.c:47 // LINUX: %[[FEAT_INIT:.+]] = load i32, ptr getelementptr inbounds ({ i32, i32, i32, [1 x i32] }, ptr @__cpu_model, i32 0, i32 3, i32 0), align 4 -// LINUX: %[[FEAT_JOIN:.+]] = and i32 %[[FEAT_

[clang] 2eefd19 - [clang][analyzer] No end-of-file when seek to file begin.

Author: Balázs Kéri Date: 2023-06-30T10:29:49+02:00 New Revision: 2eefd19613b8ea1f4cf59a4f0321bdc5f5ab0841 URL: https://github.com/llvm/llvm-project/commit/2eefd19613b8ea1f4cf59a4f0321bdc5f5ab0841 DIFF: https://github.com/llvm/llvm-project/commit/2eefd19613b8ea1f4cf59a4f0321bdc5f5ab0841.diff L

[PATCH] D153363: [clang][analyzer] No end-of-file when seek to file begin.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2eefd19613b8: [clang][analyzer] No end-of-file when seek to file begin. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153363/new/ ht

[clang] 3a9ea6a - [clang] NFC, replace llvm::writeFileAtomically with llvm::writeToOutput API inGlobalModuleIndex.cpp

Author: Haojian Wu Date: 2023-06-30T10:30:54+02:00 New Revision: 3a9ea6a48a7092b89515f4c3e2b2b6d5851b2b61 URL: https://github.com/llvm/llvm-project/commit/3a9ea6a48a7092b89515f4c3e2b2b6d5851b2b61 DIFF: https://github.com/llvm/llvm-project/commit/3a9ea6a48a7092b89515f4c3e2b2b6d5851b2b61.diff LO

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

RKSimon added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific.c:47 // LINUX: %[[FEAT_INIT:.+]] = load i32, ptr getelementptr inbounds ({ i32, i32, i32, [1 x i32] }, ptr @__cpu_model, i32 0, i32 3, i32 0), align 4 -// LINUX: %[[FEAT_JOIN:.+]] = and i32 %[[FEAT_I

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

donat.nagy added a comment. Thank you for the fix :) ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153674/new/ https://reviews.llvm.org/D153674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

tbaeder added a comment. @cjdb I know this is kind of silly after @hazohelet has already added it to the release notes... but it seems like showing the difference is useless since the difference was only introduced during the clang 17 development.(?) For a 16 -> 17 transition, it probably caus

[PATCH] D153849: [clang][Diagnostics] Fix diagnostic line numbers

cor3ntin added a comment. In D153849#4463001 , @tbaeder wrote: > @cor3ntin Thanks. You're very close to getting on my default reviewer list > though, so be careful ;) Thanks for the heads up, I might add you to mine :D Repository: rG LLVM Github Mon

[PATCH] D154189: [clang][Interp] Implement zero-init of record types

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1115 + // all field and bases explicitly. + if (E->requiresZeroInitialization() && Ctor->isTrivial()) { +assert(E->getType()->isRecordType()); I briefly talked about this wi

[PATCH] D154191: [LTO] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein created this revision. hokein added reviewers: jkorous, avl. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. Herald added a project: All. hokein requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM

[PATCH] D154191: [LTO] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein added a comment. This is a patch split out from https://reviews.llvm.org/D153740. Comment at: llvm/lib/LTO/ThinLTOCodeGenerator.cpp:433 - if (E.Error == - llvm::atomic_write_error::failed_to_create_uniq_file) { -errs() << "Er

[clang] 550fa4e - [clang] Do not discard cleanups while processing immediate invocation

Author: Mariya Podchishchaeva Date: 2023-06-30T04:50:08-04:00 New Revision: 550fa4eabd83d133595c7a5a07d54fc029b73733 URL: https://github.com/llvm/llvm-project/commit/550fa4eabd83d133595c7a5a07d54fc029b73733 DIFF: https://github.com/llvm/llvm-project/commit/550fa4eabd83d133595c7a5a07d54fc029b737

[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG550fa4eabd83: [clang] Do not discard cleanups while processing immediate invocation (authored by Fznamznon). Changed prior to commit: https://revi

[clang] 8554a55 - [clang][Diagnostics] Fix diagnostic line numbers

Author: Timm Bäder Date: 2023-06-30T10:57:10+02:00 New Revision: 8554a55d041f2c7de329adda538cadf7eeb6e8a8 URL: https://github.com/llvm/llvm-project/commit/8554a55d041f2c7de329adda538cadf7eeb6e8a8 DIFF: https://github.com/llvm/llvm-project/commit/8554a55d041f2c7de329adda538cadf7eeb6e8a8.diff LO

[PATCH] D153849: [clang][Diagnostics] Fix diagnostic line numbers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8554a55d041f: [clang][Diagnostics] Fix diagnostic line numbers (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

dang added inline comments. Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:437 .append(Var->getName(), DeclarationFragments::FragmentKind::Identifier) + .append(";", DeclarationFragments::FragmentKind::Text) .append(std::move(After)); ---

[clang] c442912 - [clang][Interp][NFC] Add type checks to InterpStack::peek()

Author: Timm Bäder Date: 2023-06-30T11:02:25+02:00 New Revision: c442912d736946703b8a9278cb2e323c51dbefcb URL: https://github.com/llvm/llvm-project/commit/c442912d736946703b8a9278cb2e323c51dbefcb DIFF: https://github.com/llvm/llvm-project/commit/c442912d736946703b8a9278cb2e323c51dbefcb.diff LO

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

owenpan updated this revision to Diff 536145. owenpan added a comment. Handle `operator` preceded by `return` or `co-return`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154184/new/ https://reviews.llvm.org/D154184 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:4003-4004 + // that are not referenced or used later. e.g.: if (int var = init()); + ConditionVar->setReferenced(false); + ConditionVar->setIsUsed(false); + shafik wrote: > That seem a

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

owenpan updated this revision to Diff 536151. owenpan added a comment. Handle multiple */&/&& in a single `operator` function argument. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154184/new/ https://reviews.llvm.org/D154184 Files: clang/lib/Format/TokenAnnotator.cpp clang/unitte

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

owenpan updated this revision to Diff 536154. owenpan added a comment. Update a unit test to make it more rigorous. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154184/new/ https://reviews.llvm.org/D154184 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTes

[PATCH] D152932: [ARM] Adding precommit tests for D146242

JiruiWu updated this revision to Diff 536157. JiruiWu added a comment. Update tests, adding an assembly test to better demonstrate the effects of D146242 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152932/new/

[PATCH] D147888: Update declaration message of extern linkage

tbaeder added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147888/new/ https://reviews.llvm.org/D147888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

JiruiWu marked an inline comment as done. JiruiWu added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5813 getContext().getTypeUnadjustedAlignInChars(Ty).getQuantity(); -unsigned BaseAlign = getContext().getTypeAlignInChars(Base).getQuantity(); -A

[PATCH] D154134: [clang] Fix ASTUnit working directory handling

hamishknight updated this revision to Diff 536163. hamishknight added a comment. Updated ReparseWorkingDirTest to fix Windows CI CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154134/new/ https://reviews.llvm.org/D154134 Files: clang/lib/Frontend/ASTUnit.cpp clang/unittests/Frontend

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon updated this revision to Diff 536172. Fznamznon added a comment. Move changes to another place, check destination type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152003/new/ https://reviews.llvm.org/D152003 Files: clang/docs/Release

[clang] 0c545a4 - Revert "clang: Use new frexp intrinsic for builtins and add f16 version"

Author: Hans Wennborg Date: 2023-06-30T13:26:25+02:00 New Revision: 0c545a441285a73e00b859dd52f1a85cb9fc URL: https://github.com/llvm/llvm-project/commit/0c545a441285a73e00b859dd52f1a85cb9fc DIFF: https://github.com/llvm/llvm-project/commit/0c545a441285a73e00b859dd52f1a85cb9fc.diff

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:589 +: AddrSizePair(AddrSizePair) {} +void Emit(CodeGenFunction &CGF, Flags Flags) override { + CGOpenMPRuntimeGPU &RT = Name of the variable hides the type, potential warnin

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. Thanks, this probably makes more sense than what I did before Comment at: clang/lib/Format/TokenAnnotator.cpp:3320 + // Annotate */&/&& in `operator` function calls as bin

[clang] d32fb5e - [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

Author: Sean Perry Date: 2023-06-30T08:06:12-04:00 New Revision: d32fb5e5f51dedba495301073b9250f84ac6d8a8 URL: https://github.com/llvm/llvm-project/commit/d32fb5e5f51dedba495301073b9250f84ac6d8a8 DIFF: https://github.com/llvm/llvm-project/commit/d32fb5e5f51dedba495301073b9250f84ac6d8a8.diff LO

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd32fb5e5f51d: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step (authored by SeanP, committed by abhina.sreeskantharajan).

[PATCH] D153776: [clang][analyzer] Display notes in StdLibraryFunctionsChecker only if interesting

balazske added a comment. | results with the latest version: | | memcached_1.6.8_stdclf_notetag_interesting_test_2 | Reports

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

v.g.vassilev added a comment. In D153003#4462388 , @ChuanqiXu wrote: >> Oh, I guess we're somehow adding a semi-resolved form of the base class type >> of D into the ODR hash, which then includes details of the >> using-declaration. That seems wrong --

[PATCH] D154207: [AMDGPU] Rename predefined macro __AMDGCN_WAVEFRONT_SIZE

yaxunl created this revision. yaxunl added reviewers: arsenm, b-sumner, jdoerfert. Herald added subscribers: kerbowa, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: wdng. rename it to __AMDGCN_WAVEFRONT_SIZE__ fo

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl added a comment. In D154133#4462387 , @jdoerfert wrote: > I would recommend to introduce `__AMDGCN_WAVEFRONT_SIZE__` as an alias for > `'__AMDGCN_WAVEFRONT_SIZE` and at some point to deprecate the latter. > Otherwise, LGTM Added __AMDGCN_WAVEFRON

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11382-11383 void CGOpenMPRuntime::emitDoacrossOrdered(CodeGenFunction &CGF, - const OMPDependClause *C) { + const

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

FreddyYe created this revision. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is also a pre-commit change for D151696 Repository: rG LLVM

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific.c:47 // LINUX: %[[FEAT_INIT:.+]] = load i32, ptr getelementptr inbounds ({ i32, i32, i32, [1 x i32] }, ptr @__cpu_model, i32 0, i32 3, i32 0), align 4 -//

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

yaxunl updated this revision to Diff 536203. yaxunl added a comment. added `__AMDGCN_WAVEFRONT_SIZE__` and reordered CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154133/new/ https://reviews.llvm.org/D154133 Files: clang/docs/AMDGPUSupport.rst Index: clang/docs/AMDGPUSupport.rst ==

[clang] b15bf30 - Reapply "clang: Use new frexp intrinsic for builtins and add f16 version"

Author: Matt Arsenault Date: 2023-06-30T09:07:23-04:00 New Revision: b15bf305ca3e9ce63aaef7247d32fb3a75174531 URL: https://github.com/llvm/llvm-project/commit/b15bf305ca3e9ce63aaef7247d32fb3a75174531 DIFF: https://github.com/llvm/llvm-project/commit/b15bf305ca3e9ce63aaef7247d32fb3a75174531.diff

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

RKSimon added inline comments. Comment at: llvm/include/llvm/TargetParser/X86TargetParser.def:262 CPU_SPECIFIC("core_i7_sse4_2", "nehalem", 'P', "+cmov,+mmx,+sse,+sse2,+sse3,+ssse3,+sse4.1,+sse4.2,+popcnt") CPU_SPECIFIC("core_aes_pclmulqdq", "westmere", 'Q', "+cmov,+mmx,+sse,

[PATCH] D154207: [AMDGPU] Rename predefined macro __AMDGCN_WAVEFRONT_SIZE

arsenm added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:318 + Builder.defineMacro("__AMDGCN_WAVEFRONT_SIZE__", Twine(WavefrontSize)); + // ToDo: deprecate this macro for naming consistency. If you're renaming it anyway, might as well go f

Re: r237346 - Revert r237339 as sanitizer-ppc64-linux1 does not like it.

___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   >