[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1299 +// StdLibraryFunctionsChecker. +ExplodedNode *Pred = const_cast(Node); +if (!Case.getNote().empty()) { donat.nagy wrote: > Can you expl

[PATCH] D153652: [Support] Don't set "all_exe" mode by default for file written by llvm::writeToOutput

jhenderson added a comment. The updated unit test is failing on Windows in the pre-merge checks. Please investigate and fix as appropriate. Comment at: llvm/unittests/Support/raw_ostream_test.cpp:500 + ASSERT_TRUE(!!Perms); + EXPECT_EQ(0, *Perms & llvm::sys::fs::all_exe); +

[PATCH] D153836: [RISCV] Bump vector crypto to v1.0.0-rc1

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, jdoerfert, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng,

[PATCH] D152686: [clangd] Enforce strict unused includes by default

kadircet added a comment. In D152686#4449481 , @cjdb wrote: > This patch seems to have broken clangd for a project of mine. Most of my > headers are now flagged as not being directly used even though they're the > root header for the symbol. replied on

[PATCH] D153833: [clang][dataflow] Use namespace qualifiers when defining functions.

mboehme added a comment. Pre-merge failures look unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153833/new/ https://reviews.llvm.org/D153833 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

zixuan-wu added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1734 + __RISCV_VXRM_RDN = 2, + __RISCV_VXRM_ROD = 3, +}; I am wondering if we need a dynamic mode enum which representing using current vxrm value? Repository: rG LLVM

[PATCH] D152989: Pre-commit test for D151696.

FreddyYe updated this revision to Diff 534861. FreddyYe added a comment. Added more checks for resolver function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152989/new/ https://reviews.llvm.org/D152989 Files: clang/test/CodeGen/attr-cpuspecif

[clang-tools-extra] 8aa88ee - [clangd] Fix the flaky FindTarget unittest after 1b66840

Author: Haojian Wu Date: 2023-06-27T09:48:41+02:00 New Revision: 8aa88ee5e01df0daf08a3768fbf23fe655ad81c0 URL: https://github.com/llvm/llvm-project/commit/8aa88ee5e01df0daf08a3768fbf23fe655ad81c0 DIFF: https://github.com/llvm/llvm-project/commit/8aa88ee5e01df0daf08a3768fbf23fe655ad81c0.diff LO

[PATCH] D153314: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

nikic added inline comments. Comment at: clang/lib/CodeGen/Targets/AArch64.cpp:522-523 auto *Load = CGF.Builder.CreateLoad(VAListAddr); Address Addr = Address(Load, CGF.Int8Ty, SlotSize); -return CGF.Builder.CreateElementBitCast(Addr, CGF.ConvertTypeForMem(Ty)); +

[PATCH] D153776: [clang][analyzer] Display notes in StdLibraryFunctionsChecker only if interesting

balazske updated this revision to Diff 534868. balazske added a comment. `markInteresting` must be used at arguments found to be invalid Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153776/new/ https://reviews.llvm.org/D153776 Files: clang/lib/

[PATCH] D153776: [clang][analyzer] Display notes in StdLibraryFunctionsChecker only if interesting

balazske added a comment. Here are results for vim, still the fileno problem is not fixed. This run was m

[clang] dc6f5c9 - [Clang][Sema] Do not try to analyze dependent alignment during -Wcast-align

Author: serge-sans-paille Date: 2023-06-27T10:29:09+02:00 New Revision: dc6f5c9b588adfe62449a898ebd06a5a09c05439 URL: https://github.com/llvm/llvm-project/commit/dc6f5c9b588adfe62449a898ebd06a5a09c05439 DIFF: https://github.com/llvm/llvm-project/commit/dc6f5c9b588adfe62449a898ebd06a5a09c05439.d

[PATCH] D151753: [Clang][Sema] Do not try to analyze dependent alignment during -Wcast-align

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc6f5c9b588a: [Clang][Sema] Do not try to analyze dependent alignment during -Wcast-align (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D151753?vs=528999&id=534869#t

[PATCH] D153776: [clang][analyzer] Display notes in StdLibraryFunctionsChecker only if interesting

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1325 if (!Pred) -break; +continue; } steakhal wrote: > Why do you continue here? Do you have a case for this? This is only be

[PATCH] D153833: [clang][dataflow] Use namespace qualifiers when defining functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9a4097e9cd89: [clang][dataflow] Use namespace qualifiers when defining functions. (authored by mboehme). Repository: rG LLVM Github Monorepo CHAN

[clang] 9a4097e - [clang][dataflow] Use namespace qualifiers when defining functions.

Author: Martin Braenne Date: 2023-06-27T08:56:21Z New Revision: 9a4097e9cd891e1445ba07ac6a21fe117fce URL: https://github.com/llvm/llvm-project/commit/9a4097e9cd891e1445ba07ac6a21fe117fce DIFF: https://github.com/llvm/llvm-project/commit/9a4097e9cd891e1445ba07ac6a21fe117fce.diff LOG

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

donat.nagy added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1299 +// StdLibraryFunctionsChecker. +ExplodedNode *Pred = const_cast(Node); +if (!Case.getNote().empty()) { balazske wrote: > donat.nagy w

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

FreddyYe added inline comments. Herald added a subscriber: StephenFan. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2067 + // favor this processor. + TuneCPU = SD->getCPUName(GD.getMultiVersionIndex())->getName(); +} pengfei wrote: > erichkeane w

[PATCH] D153849: [clang][Diagnostics] Fix diagnostic line numbers

tbaeder created this revision. tbaeder added reviewers: cjdb, aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The first line of the code snippet we print is potentially lower than the

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe added a comment. In D151696#4448680 , @FreddyYe wrote: > In D151696#4448573 , @erichkeane > wrote: > >> I think this is OK, I have a slight fear we're losing a bit of the 'tune' >> functionality, but it

[clang] c319694 - [clang][Interp][NFC] Compare std::optional variables directly

Author: Timm Bäder Date: 2023-06-27T11:36:42+02:00 New Revision: c3196947312e530960fde1b8849a4a848a5095f3 URL: https://github.com/llvm/llvm-project/commit/c3196947312e530960fde1b8849a4a848a5095f3 DIFF: https://github.com/llvm/llvm-project/commit/c3196947312e530960fde1b8849a4a848a5095f3.diff LO

[PATCH] D153798: [clang-format] Correctly annotate operator free function call

Nuu accepted this revision. Nuu added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Comment at: clang/lib/Format/TokenAnnotator.cpp:316 + // line can't be a declaration. bool OperatorCalledAsMemberFunction = + (Prev->Prev

[PATCH] D150758: [AIX] make integrated-as as default on AIX.

Esme updated this revision to Diff 534884. Esme added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150758/new/ https://reviews.llvm.org/D150758 Files: clang/lib/Driver/ToolChains/AIX.h clang/test/Driver/aix-as.c clang/tes

[PATCH] D153409: [clang][dataflow] Treat fields of anonymous records as being part of their parent.

mboehme updated this revision to Diff 534891. mboehme added a comment. Undo all of the non-test changes. This patch now only introduces a test that we can access fields of anonymous structs. I realized based on gribozavr2's comment that we shouldn't be lumping all fields of anonymous records into

[PATCH] D153409: [clang][dataflow] Treat fields of anonymous records as being part of their parent.

mboehme marked 2 inline comments as done. mboehme added a comment. PTAL Comment at: clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp:305 +if (Field->isAnonymousStructOrUnion()) + getFieldsFromClassHierarchy(Field->getType(), Fields); +else -

[PATCH] D153851: [clang][dataflow] Output debug info if `getChild()` doesn't find field.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends On D153409

[PATCH] D153852: [clang][dataflow] Initialize fields of anonymous records correctly.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, the newly added test would crash. D

[PATCH] D153852: [clang][dataflow] Initialize fields of anonymous records correctly.

mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:575 assert(InitExpr != nullptr); - -Value *InitExprVal = Env.getValue(*InitExpr, SkipPast::None); -if (InitExprVal == nullptr) - return; - -const FieldDecl *Field = S->g

[clang] 173df3d - [clang][CFG][NFC] A few smaller cleanups

Author: Timm Bäder Date: 2023-06-27T11:38:41+02:00 New Revision: 173df3dd5f9a812b07f9866965f4e92a982a3fca URL: https://github.com/llvm/llvm-project/commit/173df3dd5f9a812b07f9866965f4e92a982a3fca DIFF: https://github.com/llvm/llvm-project/commit/173df3dd5f9a812b07f9866965f4e92a982a3fca.diff LO

[PATCH] D153854: [clang][dataflow] Make `getThisPointeeStorageLocation()` return an `AggregateStorageLocation`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This avoids the need for casts at callsites. De

[clang] 0243a76 - Revert "[clang][CFG][NFC] A few smaller cleanups"

Author: Timm Bäder Date: 2023-06-27T13:06:27+02:00 New Revision: 0243a76f53abbf0bfa69e0893a4a9c8b9d926284 URL: https://github.com/llvm/llvm-project/commit/0243a76f53abbf0bfa69e0893a4a9c8b9d926284 DIFF: https://github.com/llvm/llvm-project/commit/0243a76f53abbf0bfa69e0893a4a9c8b9d926284.diff LO

[clang] 268032f - [clang] Add myself as code owner for the new constant interpreter

Author: Timm Bäder Date: 2023-06-27T13:39:03+02:00 New Revision: 268032f6f10d595bb723f6b4a21632a9f3b35be8 URL: https://github.com/llvm/llvm-project/commit/268032f6f10d595bb723f6b4a21632a9f3b35be8 DIFF: https://github.com/llvm/llvm-project/commit/268032f6f10d595bb723f6b4a21632a9f3b35be8.diff LO

[PATCH] D153241: [clang][Diagnostics] Provide source range to invalid casts in const expr

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153241/new/ https://reviews.llvm.org/D153241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D153857: [clang] Fix new-expression with elaborated-type-specifier

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Expressions like new struct A {}; struct A* b = (1 == 1) ? new struct A : new struct A; `` Were parsed as defin

[PATCH] D153314: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 updated this revision to Diff 534913. JOE1994 added a comment. Apply suggested change from nikic (sorry, I missed it out in the previous update) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153314/new/ https://reviews.llvm.org/D153314 Fil

[PATCH] D153560: [Clang] Allow C++11 style initialisation of SVE types.

paulwalker-arm updated this revision to Diff 534914. paulwalker-arm added a comment. Rebased and updated to allow copy initialisation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153560/new/ https://reviews.llvm.org/D153560 Files: clang/lib/Co

[PATCH] D153652: [Support] Don't set "all_exe" mode by default for file written by llvm::writeToOutput

hokein updated this revision to Diff 534917. hokein marked 2 inline comments as done. hokein added a comment. fix the test failures on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153652/new/ https://reviews.llvm.org/D153652 Files: llvm

[PATCH] D153652: [Support] Don't set "all_exe" mode by default for file written by llvm::writeToOutput

hokein added a comment. In D153652#4451292 , @jhenderson wrote: > The updated unit test is failing on Windows in the pre-merge checks. Please > investigate and fix as appropriate. Good catch, thanks. I have restricted the unittest to linux only, I thin

[PATCH] D153369: [OpenMP] Always apply target declarations to canonical definitions

ABataev added a comment. Did you try instead fix the OMPDeclareTargetDeclAttr::getActiveAttr() function to make it look through all the declarations and return the attribute from the first found instead of adding a new attribute? Comment at: clang/lib/Sema/SemaOpenMP.cpp:2299

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin updated this revision to Diff 534920. yronglin added a comment. Poke CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153701/new/ https://reviews.llvm.org/D153701 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Decl.h cla

[PATCH] D153241: [clang][Diagnostics] Provide source range to invalid casts in const expr

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM (modulo failed build / rebase) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153241/new/ https://reviews.llvm.org/D153241

[PATCH] D153369: [OpenMP] Always apply target declarations to canonical definitions

jhuber6 added a comment. In D153369#4451993 , @ABataev wrote: > Did you try instead fix the OMPDeclareTargetDeclAttr::getActiveAttr() > function to make it look through all the declarations and return the > attribute from the first found instead of addi

[PATCH] D153690: [clang][Sema] Remove dead diagnostic for loss of __unaligned qualifier

hazohelet added a comment. Ah looking at the code again, I noticed this change is not NFC. This suppresses inappropriate diagnostics (example added in summary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153690/new/ https://reviews.llvm.org/D15

[PATCH] D153369: [OpenMP] Always apply target declarations to canonical definitions

ABataev added a comment. In D153369#4452008 , @jhuber6 wrote: > In D153369#4451993 , @ABataev wrote: > >> Did you try instead fix the OMPDeclareTargetDeclAttr::getActiveAttr() >> function to make it look through

[PATCH] D153860: [clang-tidy] Fix modernize-use-std-print check when return value used

mikecrowe created this revision. mikecrowe added a reviewer: PiotrZSL. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscribe

[PATCH] D151952: [clang] adds `__type_pack_index` so we can get a type's parameter pack index

BertalanD added a subscriber: jwakely. BertalanD added a comment. I am considering making use of this feature in a real-world project. I have a few short observations after rebasing this diff and playing with it for a bit: - It seems to me that `__has_builtin(__type_pack_index)` currently evalu

[clang] 6101d72 - [RISCV] Relax rules for ordering s/z/x prefixed extensions in ISA naming strings

Author: Alex Bradbury Date: 2023-06-27T13:32:11+01:00 New Revision: 6101d720cb499f5ad19293475b429828fa3dbd75 URL: https://github.com/llvm/llvm-project/commit/6101d720cb499f5ad19293475b429828fa3dbd75 DIFF: https://github.com/llvm/llvm-project/commit/6101d720cb499f5ad19293475b429828fa3dbd75.diff

[PATCH] D149246: [RISCV] Relax rules for ordering s/z/x prefixed extensions in ISA naming strings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6101d720cb49: [RISCV] Relax rules for ordering s/z/x prefixed extensions in ISA naming strings (authored by asb). Changed prior to commit: https:/

[PATCH] D153314: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153314/new/ https://reviews.llvm.org/D153314 ___ c

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

yaxunl added a comment. This could be a good chance to switch VT to constant address space instead of global address space. AFAIK if a target has global addr space they usually also has constant addr space since they usually support OpenCL or CUDA/HIP. Is there any reason we cannot introduce a

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:4415-4439 + } else if (Kind == OMPC_doacross) { +// Handle dependence type for the doacross clause. +ColonProtectionRAIIObject ColonRAII(*this); +Data.ExtraModifier = getOpenMPSimpleClauseType

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11094 + bool checkLastPrivateForMappedDirectives(ArrayRef Clauses); + bool mapLoopConstruct(llvm::SmallVector *ClausesWithoutBind, const member function? Add a comment ==

[PATCH] D153652: [Support] Don't set "all_exe" mode by default for file written by llvm::writeToOutput

jhenderson added inline comments. Comment at: llvm/unittests/Support/raw_ostream_test.cpp:500 + ASSERT_TRUE(!!Perms); + EXPECT_EQ(0, *Perms & llvm::sys::fs::all_exe); + hokein wrote: > jhenderson wrote: > > Here and below, rather than just checking the all_exe

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin added a comment. Seems the diagnostic message `:5:9: note: constexpr evaluation hit maximum step limit; possible infinite loop?` was redundant, also gcc dose not emit this message. https://godbolt.org/z/v55P88cdT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D153417: New CharSetConverter wrapper class for ConverterEBCDIC

abhina.sreeskantharajan added a comment. > I don't think anyone is particularly against the concept of adding a charset > conversion API; most of the discussion is around the choice to implement the > API as a thin wrapper around POSIX iconv(). And that concern applies equally > no matter wher

[PATCH] D153836: [RISCV] Bump vector crypto to v1.0.0-rc1

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. Agreed that looking at https://github.com/riscv/riscv-crypto/compare/v20230531...v20230620 there are no changes that need to be reflected on the LLVM side beyond the version bump here. LGTM Repos

[PATCH] D151952: [clang] adds `__type_pack_index` so we can get a type's parameter pack index

jwakely added a comment. In D151952#4396485 , @cjdb wrote: > Since we're doing this, it may also be worth checking that `T1s...` are > unique in `T2s...`, which I'd intended to be a separate feature. It seems like it would be more efficient to include t

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx added a comment. In D153092#4452070 , @yaxunl wrote: > This could be a good chance to switch VT to constant address space instead of > global address space. AFAIK if a target has global addr space they usually > also has constant addr space sinc

[PATCH] D153369: [OpenMP] Always apply target declarations to canonical definitions

jhuber6 updated this revision to Diff 534950. jhuber6 added a comment. Updating to use `VD->redecls()`. Thanks for pointing that out, couldn't find it when I looked initially. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153369/new/ https://revie

[PATCH] D153369: [OpenMP] Always apply target declarations to canonical definitions

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: clang/lib/Sema/SemaOpenMP.cpp:22991 ML->DeclarationMarkedOpenMPDeclareTarget(ND, A); + checkDeclIsAllowedInOpenMPTarget(nullptr, ND, Loc);

[PATCH] D153369: [OpenMP] Always apply target declarations to canonical definitions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d699bf2664d: [OpenMP] Always apply target declarations to canonical definitions (authored by jhuber6). Changed prior to commit: https://reviews.l

[clang] 1d699bf - [OpenMP] Always apply target declarations to canonical definitions

Author: Joseph Huber Date: 2023-06-27T09:15:03-05:00 New Revision: 1d699bf2664d2a9e64024fd9eb87451d6360ea8c URL: https://github.com/llvm/llvm-project/commit/1d699bf2664d2a9e64024fd9eb87451d6360ea8c DIFF: https://github.com/llvm/llvm-project/commit/1d699bf2664d2a9e64024fd9eb87451d6360ea8c.diff

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added a comment. @nikic Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/ https://reviews.llvm.org/D148216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/test/Sema/warn-thread-safety-analysis.c:76-77 +void cleanup_int(int *unused) __attribute__((release_capability(mu1))) { + (void)unused; + mutex_exclusive_unlock(&mu1);

[PATCH] D153728: [llvm] Move AttributeMask to a separate header

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0fa2d7c2928: [llvm] Move AttributeMask to a separate header (authored by IncludeGuardian). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153728/new/ https:

[clang] f0fa2d7 - [llvm] Move AttributeMask to a separate header

Author: Elliot Goodrich Date: 2023-06-27T15:26:17+01:00 New Revision: f0fa2d7c292853b79b5bcd16be97940859a800ec URL: https://github.com/llvm/llvm-project/commit/f0fa2d7c292853b79b5bcd16be97940859a800ec DIFF: https://github.com/llvm/llvm-project/commit/f0fa2d7c292853b79b5bcd16be97940859a800ec.dif

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin added inline comments. Comment at: clang/include/clang/AST/DeclBase.h:1687 +/// Only used by CXXDeductionGuideDecl. Indicates the kind +/// of the Deduction Guide that is the implicitly generated +/// (used during overload resolution). ===

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

tbaeder updated this revision to Diff 534982. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152504/new/ https://reviews.llvm.org/D152504 Files: clang/include/clang/Analysis/CFG.h clang/lib/Analysis/CFG.cpp clang/lib/Analysis/ThreadSafety.cp

[clang] 474ec69 - [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

Author: Youngsuk Kim Date: 2023-06-27T10:38:54-04:00 New Revision: 474ec694191a51d7f30a11f8b03dee911c8ef346 URL: https://github.com/llvm/llvm-project/commit/474ec694191a51d7f30a11f8b03dee911c8ef346 DIFF: https://github.com/llvm/llvm-project/commit/474ec694191a51d7f30a11f8b03dee911c8ef346.diff

[PATCH] D153314: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG474ec694191a: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC) (authored by JOE1994). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153314/new

[PATCH] D105759: Implement P2361 Unevaluated string literals

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1411 let Documentation = [DeprecatedDocs]; + let ParseArgumentsAsUnevaluated = 1; } cor3ntin wrote: > aaron.ballman wrote: > > What is the plan for non-standard attributes? Ar

[PATCH] D153860: [clang-tidy] Fix modernize-use-std-print check when return value used

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clang-tidy/modernize/UseStdPrintCheck.cpp:73-95 +static clang::ast_matchers::StatementMatcher +unusedReturnValue(clang::ast_matchers::S

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

balazske updated this revision to Diff 534991. balazske marked 5 inline comments as done. balazske added a comment. Fixed review issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153612/new/ https://reviews.llvm.org/D153612 Files: clang/lib/S

[PATCH] D153882: [clangd] Always allow diagnostics from stale preambles

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: arphaman, javed.absar. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. We'

[PATCH] D153882: [clangd] Always allow diagnostics from stale preambles

kadircet updated this revision to Diff 534995. kadircet added a comment. - Squash base commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153882/new/ https://reviews.llvm.org/D153882 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1299 +// StdLibraryFunctionsChecker. +ExplodedNode *Pred = const_cast(Node); +if (!Case.getNote().empty()) { donat.nagy wrote: > balazske wro

[PATCH] D153883: [Clang][OpenMP] Enable use of __kmpc_alloc_shared for VLAs defined in AMD GPU offloaded regions

doru1004 created this revision. doru1004 added reviewers: ronlieb, gregrodgers, carlo.bertolli, arsenm, jdoerfert, dhruvachak, ABataev. doru1004 added a project: OpenMP. Herald added subscribers: sunshaoce, guansong, yaxunl, jvesely. Herald added a project: All. doru1004 requested review of this r

[PATCH] D150978: [clang][Sema] Add CodeCompletionContext::CCC_ObjCClassForwardDecl

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150978/new/ https://reviews.llvm.org/D150978 _

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:3501-3503 +} else if (!AllowEvaluatedString && tok::isStringLiteral(Tok.getKind())) { + Expr = ParseUnevaluatedStringLiteralExpression(); +} else { aaron.ballman wrote: > cor3n

[PATCH] D105759: Implement P2361 Unevaluated string literals

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:3501-3503 +} else if (!AllowEvaluatedString && tok::isStringLiteral(Tok.getKind())) { + Expr = ParseUnevaluatedStringLiteralExpression(); +} else { cor3ntin wrote: > aaron

[clang] f6be96a - [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

Author: Takuya Shimizu Date: 2023-06-28T00:19:46+09:00 New Revision: f6be96aa4e5e282ea52041ad6fe5fff13a3df103 URL: https://github.com/llvm/llvm-project/commit/f6be96aa4e5e282ea52041ad6fe5fff13a3df103 DIFF: https://github.com/llvm/llvm-project/commit/f6be96aa4e5e282ea52041ad6fe5fff13a3df103.diff

[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

This revision was automatically updated to reflect the committed changes. hazohelet marked an inline comment as done. Closed by commit rGf6be96aa4e5e: [clang][ExprConstant] Fix display of syntactically-invalid note for member… (authored by hazohelet). Changed prior to commit: https://reviews.ll

[PATCH] D153883: [Clang][OpenMP] Enable use of __kmpc_alloc_shared for VLAs defined in AMD GPU offloaded regions

jhuber6 added a comment. So this is implementing the `stacksave` using `__kmpc_alloc_shared` instead? It makes sense since the OpenMP standard expects sharing for the stack. I wonder how this interfaces with `-fopenmp-cuda-mode`. Comment at: clang/lib/CodeGen/CGDecl.cpp:1603

[PATCH] D153883: [Clang][OpenMP] Enable use of __kmpc_alloc_shared for VLAs defined in AMD GPU offloaded regions

ABataev added a comment. Add the runtime test? Comment at: clang/lib/CodeGen/CGDecl.cpp:587 +std::pair AddrSizePair; +KmpcAllocFree(std::pair AddrSizePair) +: AddrSizePair(AddrSizePair) {} Better to pass it as const reference

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:878-879 - if (!isIntOrBool(AL.getArgAsExpr(0))) { + Expr *First = AL.getArgAsExpr(0); + if (isa(First) || !isIntOrBool(First)) { S.Diag(AL.getLoc(), diag::err_attribute_argument_n_type)

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 534999. cor3ntin added a comment. Add tests for pascal strings (which are not a thing in C++ apparently) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files: cla

[PATCH] D153885: [Clang][Driver] Change missing multilib error to warning

michaelplatings created this revision. michaelplatings added a reviewer: simon_tatham. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The error could be awkward to work around when exper

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

ymandel updated this revision to Diff 535002. ymandel added a comment. Respond to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152263/new/ https://reviews.llvm.org/D152263 Files: clang/include/clang/Analysis/Analyses/IntervalPartition.

[PATCH] D153885: [Clang][Driver] Change missing multilib error to warning

simon_tatham added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:740 -def err_drv_no_matching_multilib : Error< - "no multilib found matching flags: %0">; +def warn_drv_no_matching_multilib : Warning< + "no multilib found matching flags: %0">

[PATCH] D153883: [Clang][OpenMP] Enable use of __kmpc_alloc_shared for VLAs defined in AMD GPU offloaded regions

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1085 } - for (const auto *VD : I->getSecond().EscapedVariableLengthDecls) { -// Use actual memory size of the VLA object including the padding ABataev wrote: > Why this c

[PATCH] D153883: [Clang][OpenMP] Enable use of __kmpc_alloc_shared for VLAs defined in AMD GPU offloaded regions

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1085 } - for (const auto *VD : I->getSecond().EscapedVariableLengthDecls) { -// Use actual memory size of the VLA object including the padding doru1004 wrote: > ABataev wr

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

ymandel marked 3 inline comments as done. ymandel added inline comments. Comment at: clang/lib/Analysis/IntervalPartition.cpp:26 + + std::queue Worklist; + for (const CFGBlock *S : Header.succs()) xazax.hun wrote: > ymandel wrote: > > xazax.hun wrote: > > > Is

[PATCH] D153690: [clang][Sema] Remove dead diagnostic for loss of __unaligned qualifier

hazohelet updated this revision to Diff 535010. hazohelet added a comment. Added release note and test because this change is not NFC CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153690/new/ https://reviews.llvm.org/D153690 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Ba

[PATCH] D153883: [Clang][OpenMP] Enable use of __kmpc_alloc_shared for VLAs defined in AMD GPU offloaded regions

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1085 } - for (const auto *VD : I->getSecond().EscapedVariableLengthDecls) { -// Use actual memory size of the VLA object including the padding jhuber6 wrote: > doru1004 wr

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

xazax.hun accepted this revision. xazax.hun added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152263/new/ https://reviews.llvm.org/D152263 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D153889: [analyzer][NFC] Fix dangling StringRef in barely used code

donat.nagy created this revision. donat.nagy added reviewers: Szelethus, gamesh411, steakhal. Herald added subscribers: manas, ASDenysPetrov, dkrupp, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. donat.nagy requested r

[PATCH] D153890: [clang] Fix checking the equality comparator of base classes in __is_trivially_equality_comparable

philnik created this revision. philnik added reviewers: aaron.ballman, cor3ntin. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes #63192 Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D153860: [clang-tidy] Fix modernize-use-std-print check when return value used

mikecrowe marked an inline comment as done. mikecrowe added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseStdPrintCheck.cpp:73-95 +static clang::ast_matchers::StatementMatcher +unusedReturnValue(clang::ast_matchers::StatementMatcher MatchedCallExpr) { +

[PATCH] D153883: [Clang][OpenMP] Enable use of __kmpc_alloc_shared for VLAs defined in AMD GPU offloaded regions

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1085 } - for (const auto *VD : I->getSecond().EscapedVariableLengthDecls) { -// Use actual memory size of the VLA object including the padding ABataev wrote: > jhuber6 wr

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

aaron.ballman added subscribers: cjdb, aaron.ballman. aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:135-136 - Compiler flags ``-std=c++2c`` and ``-std=gnu++2c`` have been added for experimental C++2c implementation work. +- Implemented `P2169R4: A

  1   2   3   >