[PATCH] D152986: [clang] Allow 'nomerge' attribute for function pointers

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. In D152986#4426256 , @eddyz87 wrote: > In D152986#4425736 , @rnk wrote: > >> The purpose of the attribute is really

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

mstorsjo added a comment. In D152785#4438544 , @MaskRay wrote: > CodeView is the default debug info format for COFF. Perhaps `-gsplit-dwarf` > should be rejected when the default `-gcodeview` is used, with a test. IIRC some users do generate both CodeVi

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

schittir updated this revision to Diff 533386. schittir marked 3 inline comments as done. schittir added a comment. Changes to address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153236/new/ https://reviews.llvm.org/D153236 Files: clang/lib/Sema/SemaExprObjC.cpp clang/l

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

schittir added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:886-887 TopLevelCase = Case; - else + else { +assert(DeepestParsedCaseStmt && "DeepestParsedCaseStmt cannot be null"); Actions.ActOnCaseStmtBody(DeepestParsedCaseStmt, C

[PATCH] D153468: [clang][LTO] Add flag to run verifier after every pass

aeubanks created this revision. aeubanks added a reviewer: tejohnson. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D153469: [dataflow] Replace most BoolValue subclasses with references to Formula (and AtomicBoolValue => Atom and BoolValue => Formula where appropriate)

sammccall created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This properly frees the Value hierarchy from

[clang] 8e85739 - [clang-format] Don't finalize #if, #else, #endif, etc.

Author: Owen Pan Date: 2023-06-21T15:15:57-07:00 New Revision: 8e85739a5f24e34cb22768fe6ef33b593ed054df URL: https://github.com/llvm/llvm-project/commit/8e85739a5f24e34cb22768fe6ef33b593ed054df DIFF: https://github.com/llvm/llvm-project/commit/8e85739a5f24e34cb22768fe6ef33b593ed054df.diff LOG:

[PATCH] D153243: [clang-format] Don't finalize #if, #else, #endif, etc.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e85739a5f24: [clang-format] Don't finalize #if, #else, #endif, etc. (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153243/new/ https:

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

owenpan marked 2 inline comments as done. owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6371-6380 + verifyFormat("#if FOO\n" + "int a = 1;\n" + "#else\n" + "int ab = 2;\n" + "#endif\n" +

[PATCH] D153175: [Frontend] Don't output skipped includes from predefines

smeenai added a comment. In D153175#4431923 , @hans wrote: >> -H is supposed to skip outputting headers from -include command line >> arguments, but -fshow-skipped-includes was outputting any skipped >> includes encountered via -include. > > I was thrown

[PATCH] D153476: [dataflow] document & test determinism of formula structure

sammccall created this revision. Herald added subscribers: martong, mgrang, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This doesn't depend on object addres

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

brendandahl added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5608-5612 +Clang supports the ``__attribute__((wasm_async))`` +attribute for the WebAssembly target. This attribute may be attached to a +function definition, which indicates the function will be

[clang] 67a1129 - [Frontend] Don't output skipped includes from predefines

Author: Shoaib Meenai Date: 2023-06-21T15:48:27-07:00 New Revision: 67a11290df64fec44e671a1bdc3a225ed8a02962 URL: https://github.com/llvm/llvm-project/commit/67a11290df64fec44e671a1bdc3a225ed8a02962 DIFF: https://github.com/llvm/llvm-project/commit/67a11290df64fec44e671a1bdc3a225ed8a02962.diff

[clang] 1df10f1 - [Frontend] Remove ShowIncludesPretendHeader

Author: Shoaib Meenai Date: 2023-06-21T15:48:28-07:00 New Revision: 1df10f15807f9b7deba3f714d27e21578a8b4748 URL: https://github.com/llvm/llvm-project/commit/1df10f15807f9b7deba3f714d27e21578a8b4748 DIFF: https://github.com/llvm/llvm-project/commit/1df10f15807f9b7deba3f714d27e21578a8b4748.diff

[PATCH] D153175: [Frontend] Don't output skipped includes from predefines

This revision was automatically updated to reflect the committed changes. Closed by commit rG67a11290df64: [Frontend] Don't output skipped includes from predefines (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153175/new/ http

[PATCH] D153176: [Frontend] Remove ShowIncludesPretendHeader

This revision was automatically updated to reflect the committed changes. Closed by commit rG1df10f15807f: [Frontend] Remove ShowIncludesPretendHeader (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153176/new/ https://reviews.l

[clang] db3dced - [-Wunsafe-buffer-usage] Handle pointer initializations for grouping related variables

Author: Rashmi Mudduluru Date: 2023-06-21T15:54:09-07:00 New Revision: db3dcedb9cedcec4a9570fda7406490c642df8ae URL: https://github.com/llvm/llvm-project/commit/db3dcedb9cedcec4a9570fda7406490c642df8ae DIFF: https://github.com/llvm/llvm-project/commit/db3dcedb9cedcec4a9570fda7406490c642df8ae.di

[PATCH] D150489: [-Wunsafe-buffer-usage] Handle pointer initializations for grouping related variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb3dcedb9ced: [-Wunsafe-buffer-usage] Handle pointer initializations for grouping related… (authored by t-rasmud). Herald added a project: clang. Her

[PATCH] D153462: [Headers][doc] Add various arith/logical intrinsic descriptions to avx2intrin.h

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153462/new/ https://reviews.llvm.org/D153462 ___ cfe-commits mailing list c

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues

schittir added a comment. @tahonermann @shafik - is it ok to land this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D153481: [clang] NFCI: Use `DirectoryEntryRef` in framework lookup

frs513 created this revision. Herald added a project: All. frs513 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This removes one use of the deprecated `DirectoryEntry::getName()`. Repository: rG LLVM Github Monorepo https://reviews.l

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 533433. paulkirth marked 12 inline comments as done. paulkirth added a comment. Rebase and address comments - Update & rename tests - Fix typos - Handle options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth added inline comments. Comment at: clang/include/clang/Driver/Options.td:2311 MarshallingInfoString>; +defm fat_lto_objects : BoolFOption<"fat-lto-objects", + CodeGenOpts<"FatLTO">, DefaultFalse, MaskRay wrote: > We just need the pos flag for CC1Opt

[clang] 0867d41 - [flang] don't require -flang-experimental-exec flag anymore

Author: Brad Richardson Date: 2023-06-21T16:47:52-07:00 New Revision: 0867d4157328169c570f4d1e9c01806624035873 URL: https://github.com/llvm/llvm-project/commit/0867d4157328169c570f4d1e9c01806624035873 DIFF: https://github.com/llvm/llvm-project/commit/0867d4157328169c570f4d1e9c01806624035873.dif

[PATCH] D153379: Remove -flang-experimental-exec flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG0867d4157328: [flang] don't require -flang-experimental-exec flag anymore (authored by everythingfunctional, committed by ktras). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D153485: [dataflow] use true/false literals in formulas, rather than variables

sammccall created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. And simplify formulas containing true/false

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:3476-3477 + + // Regarding the 16: Note that multiple passes are added in + // addQualifierAlignmentFixerPasses(). + SmallVector Passes; This comment is unnecessary and too verbose IMO. I s

[PATCH] D153488: [dataflow] HTMLLogger: meaningful names for flow condition variables

sammccall created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Instead of meaningless "V7", use the name "B

[clang] c448e1d - HIP: Directly call ldexp builtins

Author: Matt Arsenault Date: 2023-06-21T21:34:42-04:00 New Revision: c448e1dabeeb066c41d893fc8e7a3d8bde2056c8 URL: https://github.com/llvm/llvm-project/commit/c448e1dabeeb066c41d893fc8e7a3d8bde2056c8 DIFF: https://github.com/llvm/llvm-project/commit/c448e1dabeeb066c41d893fc8e7a3d8bde2056c8.diff

[PATCH] D138397: HIP: Directly call ldexp builtins

arsenm closed this revision. arsenm added a comment. c448e1dabeeb066c41d893fc8e7a3d8bde2056c8 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138397/new/ https://reviews.llvm.org/D138397 __

[PATCH] D142823: Intrinsics: Allow tablegen to mark parameters with dereferenceable

arsenm closed this revision. arsenm added a comment. 1717c18664d5880f78db85eb0075a2c1379df2d9 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142823/new/ https://reviews.llvm.org/D142823 __

[PATCH] D153491: [dataflow] Avoid copying environment

sammccall created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This appears to be just an accidental copy r

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

shafik added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11226 +def err_module_private_use : Error< + "%select{declaration|definition|default argument|" + "explicit specialization|partial specialization}0 of %1 is private to module " -

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

shafik added a reviewer: clang-language-wg. shafik added a comment. Adding clang-language-wg for more visibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145965/new/ https://reviews.llvm.org/D145965 __

[PATCH] D152788: [Clang] Show type in enum out of range diagnostic

shafik added a comment. Thank you for this improvement! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152788/new/ https://reviews.llvm.org/D152788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152796: [clang][Sema] Fix diagnostic message for unused constant varialbe templates

shafik added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1385 + Diag(DiagD->getLocation(), diag::warn_unused_template) + << /*variable*/ 1 << DiagD; } else if (DiagD->getType().isConstQualified()) { Sorry for late review bu

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

shafik added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/LexerUtils.cpp:273 +return Lexer::findLocationAfterToken(NoexceptLoc, tok::r_paren, SM, + LangOpts, true); + To conform with [burprone-argume

[PATCH] D153493: [dataflow] avoid more accidental copies of Environment

sammccall created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is clunky but greatly improves debuggin

[PATCH] D153493: [dataflow] avoid more accidental copies of Environment

sammccall updated this revision to Diff 533463. sammccall added a comment. refactor, restore comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153493/new/ https://reviews.llvm.org/D153493 Files: clang/include/clang/Analysis/FlowSensitive/Dat

[PATCH] D153493: [dataflow] avoid more accidental copies of Environment

sammccall added reviewers: ymandel, xazax.hun. sammccall added a comment. The idea with the change to Environment::join() is that the current signature forces the base environment to be mutable, but this sometimes forces the caller to make a copy, and the implementation actually copies everythin

[PATCH] D152671: [doc][LoongArch] Add missed release note about `ual` feature addition

xen0n added a comment. Thanks for the catch! Comment at: llvm/docs/ReleaseNotes.rst:163 * The ``lp64s`` ABI is supported now and has been tested on Rust bare-matal target. +* An target feature ``ual`` is introduced to allow unaligned memory accesses and + this feature is en

[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:983 EnableNewConstInterp(C.getLangOpts().EnableNewConstInterp), - BottomFrame(*this, SourceLocation(), nullptr, nullptr, CallRef()), + BottomFrame(*this, SourceLocation(), nullpt

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall added reviewers: gribozavr2, xazax.hun, mboehme. sammccall added a comment. Splitting out Formula from BoolValue is a pretty big change... I've tried to keep this patch a manageable size by really just using Formula for interacting with the SAT solver and some printing, but this means

[PATCH] D152946: [C++20][Modules] Implement P2615R1 revised export diagnostics.

shafik added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:835 + + // C++20 [module.interface]p3: if (auto *ND = dyn_cast(D)) { Can you please add the quoted text for clarity. This is especially helpful if the text changes in the future and we

[PATCH] D153469: [dataflow] Replace most BoolValue subclasses with references to Formula (and AtomicBoolValue => Atom and BoolValue => Formula where appropriate)

sammccall added reviewers: mboehme, xazax.hun, gribozavr2. sammccall added a comment. Here we start to see benefits: Value becomes less reliant on inheritance, flow conditions are no longer Values that can uselessly bear properties, atomic variables are numbered in order of creation, we'll soon

[PATCH] D152671: [doc][LoongArch] Add missed release note about `ual` feature addition

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: llvm/docs/ReleaseNotes.rst:164 +* An target feature ``ual`` is introduced to allow unaligned memory accesses and + this feature is enabled by default on g

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. Thank you for the detailed analysis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153228/new/ https://reviews.llvm.org/D153228 ___ c

[PATCH] D143241: [Clang] Reset FP options before function instantiations

sepavloff added inline comments. Comment at: clang/lib/Parse/ParseTemplate.cpp:1736 + // point of the template definition. + Actions.resetFPOptions(LPT.FPO); + rjmccall wrote: > Ah, is this bug specific to the MSVC-compatible template logic? Exactly. This is MS

[clang-tools-extra] cea0eea - [llvm] Split out DenseMapInfo specialization

Author: Elliot Goodrich Date: 2023-06-22T06:50:54+01:00 New Revision: cea0eea28e71204bf8543ca94dbf185cbf597ca5 URL: https://github.com/llvm/llvm-project/commit/cea0eea28e71204bf8543ca94dbf185cbf597ca5 DIFF: https://github.com/llvm/llvm-project/commit/cea0eea28e71204bf8543ca94dbf185cbf597ca5.dif

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

This revision was automatically updated to reflect the committed changes. Closed by commit rGcea0eea28e71: [llvm] Split out DenseMapInfo specialization (authored by IncludeGuardian). Herald added a project: Flang. Changed prior to commit: https://reviews.llvm.org/D150997?vs=532038&id=5

[PATCH] D153379: Remove -flang-experimental-exec flag

antmo added a comment. Hello, I think this broke some bots due to remaining references to -flang-experimental-exec in llvm-zorg buildbot config - clang-aarch64-sve-vla-2stage https://lab.llvm.org/buildbot/#/builders/198/builds/2907 - clang-aarch64-sve-vls-2stage https://lab.llvm.org/buildbot/#

[PATCH] D153370: [RISCV] Add support for custom instructions for Sifive S76.

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:135 {"xventanacondops", RISCVExtensionVersion{1, 0}}, +{"xsfcie", RISCVExtensionVersion{1, 0}}, }; Put this with xsfvcp Comment at: llvm/lib/Target/RISC

<    1   2