[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

2023-06-20 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 533022. sammccall added a comment. update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366 Files: clang/include/clang/Analysis/FlowSensitive/Arena.h clang/

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

2023-06-20 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. A constant expression (including the immediate invocations generated for `consteval` functions) is a full-expression, so destructors should be run at the end of evaluating it, not as part of the enclosing expression. That's presumably why the code is calling `MaybeCreate

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

2023-06-20 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 533025. sammccall edited the summary of this revision. sammccall added a comment. updating description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366 Files: clan

[PATCH] D153281: [flang] add -flang-experimental-polymorphism flag to flang-new

2023-06-20 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. Looks ok to me. Note that some of the polymorphic TODOs will only be removed when HLFIR is in place. Looks like you have a clang-format issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153281/new/ https://reviews.l

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

2023-06-20 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 533027. sammccall edited the summary of this revision. sammccall added a comment. more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366 Files: clang/include/

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

2023-06-20 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 533028. sammccall added a comment. remove dead comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366 Files: clang/include/clang/Analysis/FlowSensitive/Arena.h

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

2023-06-20 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 533029. sammccall added a comment. clean up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366 Files: clang/include/clang/Analysis/FlowSensitive/Arena.h clang/incl

[PATCH] D153362: [clang][DebugInfo] Emit DW_AT_defaulted for defaulted C++ member functions

2023-06-20 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Any particular use for this debug info in DWARF consumers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153362/new/ https://reviews.llvm.org/D153362 ___ cfe-commits mailing lis

[clang] 56e36e4 - [UsersManual] Add llvm-progen as an alternative tool for AutoFDO profile generation.

2023-06-20 Thread Hongtao Yu via cfe-commits
Author: Hongtao Yu Date: 2023-06-20T13:26:30-07:00 New Revision: 56e36e47f50446f519dfa2132cf5a49cc0816866 URL: https://github.com/llvm/llvm-project/commit/56e36e47f50446f519dfa2132cf5a49cc0816866 DIFF: https://github.com/llvm/llvm-project/commit/56e36e47f50446f519dfa2132cf5a49cc0816866.diff LO

[PATCH] D142994: [UsersManual] Add llvm-progen as an alternative tool for AutoFDO profile generation.

2023-06-20 Thread Hongtao Yu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56e36e47f504: [UsersManual] Add llvm-progen as an alternative tool for AutoFDO profile… (authored by hoy). Repository: rG LLVM Github Monorepo CH

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

2023-06-20 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. I'm really happy to see this limitation finally addressed! It's quite a bit of embarrassing tech debt that affects folks making Windows x86 builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137872/new/ https://reviews.llvm

[PATCH] D153179: [clang codegen] Fix ABI for HVA returns on AArch64 MSVC.

2023-06-20 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. Interesting. In Clang, we basically layer the C++ rules over the C rules: if C++ aspects of a class allow it to be passed directly transparently, then we defer down to the C rules, which deal with HVAs, structs, and things like that. In D153179#4429813

[PATCH] D153362: [clang][DebugInfo] Emit DW_AT_defaulted for defaulted C++ member functions

2023-06-20 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Not sure if this is the driving motivation, but this would probably allow LLDB's expression evaluator to synthesize a default implementation for these functions if they were optimized away.

[PATCH] D153375: [Clang] Fix incorrect use of direct initialization with copy initialization

2023-06-20 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane, rsmith. Herald added a project: All. shafik requested review of this revision. In `Sema::CreateBuiltinBinOp()` we were incorrectly using direct initialization instead of copy initialization. This led to a crash in a

[clang] 148075c - [clang][test] Refactor FileCheck metadata in pragma-followup_inner.cpp

2023-06-20 Thread John McIver via cfe-commits
Author: John McIver Date: 2023-06-20T14:55:12-06:00 New Revision: 148075cf87c76672474306fa463aadd93b1c027a URL: https://github.com/llvm/llvm-project/commit/148075cf87c76672474306fa463aadd93b1c027a DIFF: https://github.com/llvm/llvm-project/commit/148075cf87c76672474306fa463aadd93b1c027a.diff L

[PATCH] D153184: [NFC][clang] Refactor FileCheck metadata references in pragma-followup_inner.cpp

2023-06-20 Thread John McIver via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG148075cf87c7: [clang][test] Refactor FileCheck metadata in pragma-followup_inner.cpp (authored by jmciver). Repository: rG LLVM Github Monorepo C

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

2023-06-20 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 added inline comments. Comment at: clang/docs/LanguageExtensions.rst:656 + T __builtin_elementwise_nearbyint(T x) round x to the nearest integer value in floating point format, floating point types + rounding accord

[PATCH] D153179: [clang codegen] Fix ABI for HVA returns on AArch64 MSVC.

2023-06-20 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Filed https://github.com/llvm/llvm-project/issues/63417 . (On a related note, I also filed https://github.com/llvm/llvm-project/issues/63360 for an issue I stumbled over involving deleted copy constructors.) > Interesting. In Clang, we basically layer the C++ rules ov

[PATCH] D153179: [clang codegen] Fix ABI for HVA returns on AArch64 MSVC.

2023-06-20 Thread Eli Friedman via Phabricator via cfe-commits
efriedma updated this revision to Diff 533045. efriedma added a comment. Updated testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153179/new/ https://reviews.llvm.org/D153179 Files: clang/lib/CodeGen/MicrosoftCXXABI.cpp clang/test/CodeG

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

2023-06-20 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Looking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

2023-06-20 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6784 + if (II->getInterestingIdentifierID() != 0) +NewTD->addAttr(AvailableOnlyInDefaultEvalMethodAttr::Create(Context)); } zahiraam wrote: > rjmccall wrote: > > Please swit

[PATCH] D152741: [WPD] implement -fskip-vtable-filepaths

2023-06-20 Thread Di Mo via Phabricator via cfe-commits
modimo updated this revision to Diff 533048. modimo added a comment. Remove leftover code from original implementation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152741/new/ https://reviews.llvm.org/D152741 Files: clang/include/clang/Basic/Co

[PATCH] D153179: [clang codegen] Fix ABI for HVA returns on AArch64 MSVC.

2023-06-20 Thread Eli Friedman via Phabricator via cfe-commits
efriedma updated this revision to Diff 533049. efriedma added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153179/new/ https://reviews.llvm.org/D153179 Files: clang/lib/CodeGen/MicrosoftCXXABI.cpp clang/test/CodeGenCXX/hom

[PATCH] D144911: adding bf16 support to NVPTX

2023-06-20 Thread Kushan Ahmadian via Phabricator via cfe-commits
kushanam updated this revision to Diff 533051. kushanam added a comment. fixing bf16 test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144911/new/ https://reviews.llvm.org/D144911 Files: clang/include/clang/Basic/BuiltinsNVPTX.def llvm/

[PATCH] D153179: [clang codegen] Fix ABI for HVA returns on AArch64 MSVC.

2023-06-20 Thread Eli Friedman via Phabricator via cfe-commits
efriedma updated this revision to Diff 533050. efriedma added a comment. Upload correct diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153179/new/ https://reviews.llvm.org/D153179 Files: clang/lib/CodeGen/MicrosoftCXXABI.cpp clang/test/Co

[PATCH] D153379: Remove -flang-experimental-exec flag

2023-06-20 Thread Brad Richardson via Phabricator via cfe-commits
everythingfunctional created this revision. everythingfunctional added reviewers: ktras, rouson, sscalpone, PeteSteinfeld, awarzynski. everythingfunctional added projects: Flang, LLVM. Herald added subscribers: sunshaoce, jdoerfert, mstorsjo. Herald added a project: All. everythingfunctional reque

[PATCH] D153179: [clang codegen] Fix ABI for HVA returns on AArch64 MSVC.

2023-06-20 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153179/new/ https://reviews.llvm.org/D153179 ___ cfe-c

[PATCH] D153179: [clang codegen] Fix ABI for HVA returns on AArch64 MSVC.

2023-06-20 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. The other thing I'm getting at here is that our TargetInfo.cpp abstraction is pretty well built out, even if it's a huge mess. The C++ rules are generally platform neutral, and we don't usually have to resort to these kinds of triple checks, but sometimes it's the most stra

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

2023-06-20 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:1945 + auto DRE = + DeclRefExpr::Create(*Context, {}, {}, VD, false, SourceLocation(), + VD->getType(), VK_PRValue); tbaeder wrote: > NoQ wrote: > > Is th

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

2023-06-20 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: clang/docs/LanguageExtensions.rst:656 + T __builtin_elementwise_nearbyint(T x) round x to the nearest integer value in floating point format, floating point types + rounding accordin

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

2023-06-20 Thread Amy Huang via Phabricator via cfe-commits
akhuang updated this revision to Diff 533079. akhuang added a comment. rebase and clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137872/new/ https://reviews.llvm.org/D137872 Files: clang/include/clang/CodeGen/CGFunctionInfo.h clang

[PATCH] D144911: adding bf16 support to NVPTX

2023-06-20 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXInstrInfo.td:559-568 -multiclass CVT_FROM_FLOAT_SM80 { -def _f32 : - NVPTXInst<(outs RC:$dst), -(ins Float32Regs:$src, CvtMode:$mode), -!strconcat("cvt${mode:base}${mode:rel

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

2023-06-20 Thread Jeffrey Byrnes via Phabricator via cfe-commits
jrbyrnes updated this revision to Diff 533080. jrbyrnes marked 5 inline comments as done. jrbyrnes added a comment. Address comments + enable selection of ptr types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147732/new/ https://reviews.llvm.org/

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

2023-06-20 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added inline comments. Comment at: llvm/test/MC/ARM/thumb-fixups.s:1 +@ RUN: llvm-mc -triple armv6m-unknown-unknown %s --show-encoding > %t +@ RUN: FileCheck < %t %s We normally just pipe the output to FileCheck, e.g. `| Fi

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

2023-06-20 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. I'll just leave this tiny bit of analysis here, that we did on the whiteboard a while ago. > The "intermediate" overload `void f(std::span, int *)` stays there but > usually is not useful. If there are more than two parameters need to be > fixed, there will be more such us

[clang] 0150493 - Try to implement lambdas with inalloca parameters by forwarding without use of inallocas.

2023-06-20 Thread Amy Huang via cfe-commits
Author: Amy Huang Date: 2023-06-20T17:30:20-07:00 New Revision: 015049338d7e8e0e81f2ad2f94e5a43e2e3f5220 URL: https://github.com/llvm/llvm-project/commit/015049338d7e8e0e81f2ad2f94e5a43e2e3f5220 DIFF: https://github.com/llvm/llvm-project/commit/015049338d7e8e0e81f2ad2f94e5a43e2e3f5220.diff LOG

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

2023-06-20 Thread Amy Huang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG015049338d7e: Try to implement lambdas with inalloca parameters by forwarding without use of… (authored by akhuang). Repository: rG LLVM Github Mo

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

2023-06-20 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. @ABataev wdyt? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

2023-06-20 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2077 + for (const auto &[VD, Fixables] : FixablesForUnsafeVars.byVar) { FixItsForVariable[VD] = There's a bug in variable naming: `FixablesForUnsafeVars`actually contains fix

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

2023-06-20 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Ok whew that's a big patch! I *think* I found a couple of bugs. In any case, this code is quickly becoming very complicated, and the functions we're editing are rapidly growing out of control. Chopping them up into smaller functions with clear separation of concerns would p

[PATCH] D153375: [Clang] Fix incorrect use of direct initialization with copy initialization

2023-06-20 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. It looks like the build failure happens on other PR as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153375/new/ https://reviews.llvm.org/D153375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

2023-06-20 Thread Joel Dice via Phabricator via cfe-commits
dicej added a comment. @sbc100 Thanks for the "lgtm". What's the next step to get this merged? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153293/new/ https://reviews.llvm.org/D153293 ___ cfe-commits

[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

2023-06-20 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D145849#4430870 , @ilammy wrote: > In D145849#4412286 , @MaskRay wrote: > >> However, `Triple.isMacOSX()` is allowed before the feature actually works >> and `compiler-rt/test/xray/lit

[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

2023-06-20 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D145849#4436623 , @MaskRay wrote: > In D145849#4430870 , @ilammy wrote: > >> In D145849#4412286 , @MaskRay >> wrote: >> >>> However, `Triple.i

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

2023-06-20 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 added a comment. I'm happy to merge it, but perhaps we should get @sunfish to lg too. Also, should we remove the `-experimental-pic` linker flag, or are you OK with that warning from the linker? If yes, I wonder if we should do that as part of this CL or a followup? Repository: rG

[clang] e105141 - [Driver] Allow XRay for more architectures on ELF systems

2023-06-20 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2023-06-20T20:41:54-07:00 New Revision: e1051414a16e970c2e36c2ab7dfe2b17353c4751 URL: https://github.com/llvm/llvm-project/commit/e1051414a16e970c2e36c2ab7dfe2b17353c4751 DIFF: https://github.com/llvm/llvm-project/commit/e1051414a16e970c2e36c2ab7dfe2b17353c4751.diff

[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

2023-06-20 Thread Fangrui Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd5bebb3fb402: [Driver] Allow XRay on Apple Silicon (authored by ilammy, committed by MaskRay). Changed prior to commit: https://reviews.llvm.org/D145849?vs=530285&id=533116#toc Repository: rG LLVM Gi

[clang] d5bebb3 - [Driver] Allow XRay on Apple Silicon

2023-06-20 Thread Fangrui Song via cfe-commits
Author: Oleksii Lozovskyi Date: 2023-06-20T20:47:32-07:00 New Revision: d5bebb3fb402c4ba7e5838d267fa840eee8ecdce URL: https://github.com/llvm/llvm-project/commit/d5bebb3fb402c4ba7e5838d267fa840eee8ecdce DIFF: https://github.com/llvm/llvm-project/commit/d5bebb3fb402c4ba7e5838d267fa840eee8ecdce.d

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

2023-06-20 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Can you post a before/after comparison of the exact output for that example? Comment at: clang/lib/Sema/SemaOverload.cpp:10752 QualType ToTy = Conv.Bad.getToType(); + ParmVarDecl *ToPVD = !isObjectArgument ? Fn->getParamDecl(I) : nullptr;

[PATCH] D152661: [XRay] Make xray_fn_idx entries PC-relative

2023-06-20 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 533131. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. fix clang/test/CodeGen/xray-function-index.c Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D153161: [RISCV] Move Zca/Zcb/Zcd/Zcf/Zcmp/Zcmt out of experimental status.

2023-06-20 Thread Xinlong Wu via Phabricator via cfe-commits
VincentWu added inline comments. Comment at: clang/test/Driver/riscv-arch.c:376 -// RUN: %clang --target=riscv32-unknown-elf -march=rv32izca -### %s \ +// RUN: %clang --target=riscv32-unknown-elf -march=rv32izfa -### %s \ // RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV

[PATCH] D152661: [XRay] Make xray_fn_idx entries PC-relative

2023-06-20 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Tested on aarch64-linux-gnu and powerpc64le-linux-gnu. I'll use `createLinkerPrivateSymbol` instead of `createLinkerPrivateTempSymbol` since the symbol is not considered `IsTemporary` by MC... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] e0a6561 - [XRay] Make xray_fn_idx entries PC-relative

2023-06-20 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2023-06-20T22:40:56-07:00 New Revision: e0a6561ec9ec10f8c0c43b15dfcbbc3c57d37d3f URL: https://github.com/llvm/llvm-project/commit/e0a6561ec9ec10f8c0c43b15dfcbbc3c57d37d3f DIFF: https://github.com/llvm/llvm-project/commit/e0a6561ec9ec10f8c0c43b15dfcbbc3c57d37d3f.diff

[PATCH] D152661: [XRay] Make xray_fn_idx entries PC-relative

2023-06-20 Thread Fangrui Song via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0a6561ec9ec: [XRay] Make xray_fn_idx entries PC-relative (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D152661?vs=5331

[PATCH] D153161: [RISCV] Move Zca/Zcb/Zcd/Zcf/Zcmp/Zcmt out of experimental status.

2023-06-20 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/test/Driver/riscv-arch.c:376 -// RUN: %clang --target=riscv32-unknown-elf -march=rv32izca -### %s \ +// RUN: %clang --target=riscv32-unknown-elf -march=rv32izfa -### %s \ // RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

2023-06-20 Thread Takuya Shimizu via Phabricator via cfe-commits
hazohelet updated this revision to Diff 533142. hazohelet added a comment. Address comments from @tbaeder - Bind parameter source range rather than its declaration to variable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153359/new/ https://reviews.llvm.org/D153359 Files: clang/li

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

2023-06-20 Thread Takuya Shimizu via Phabricator via cfe-commits
hazohelet marked 2 inline comments as done. hazohelet added a comment. Consider the following code. (I added another parameter to the original code so that the covered range becomes clearer) void func(int aa, int bb); void test() { func(1, "two"); } BEFORE this patch: source:4:15:

[PATCH] D153363: [clang][analyzer] No end-of-file when seek to file begin.

2023-06-20 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. This case

[PATCH] D153338: [clang-format] vim integration: Mention python3 variant of bindings

2023-06-20 Thread Jannik Silvanus via Phabricator via cfe-commits
jsilvanus updated this revision to Diff 533149. jsilvanus added a comment. Don't change proposed key binding from K to I, just add the python3 part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153338/new/ https://reviews.llvm.org/D153338 Files:

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

2023-06-20 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3898 if (!Args.hasArg(options::OPT_dumpdir)) { + Arg *FinalOutput = Args.getLastArg(options::OPT_o, options::OPT__SLASH_o); Arg *Arg = Args.MakeSeparateArg( Add a test to sho

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

2023-06-20 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific.c:342 -// CHECK: attributes #[[S]] = {{.*}}"target-features"="+avx,+cmov,+crc32,+cx8,+f16c,+mmx,+popcnt,+sse,+sse2,+sse3,+sse4.1,+sse4.2,+ssse3,+x87,+xsave" // CHECK-SAME: "tune-cpu"="ivybridge" --

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

2023-06-20 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/Driver/split-debug.c:55 // RUN: %clang -### -c -target x86_64 -gsplit-dwarf=single -g -o %tfoo.o %s 2>&1 | FileCheck %s --check-prefix=SINGLE_WITH_FILENAME +// RUN: %clang_cl -### -c --target x86_64-unknown-windows-msvc -gs

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

2023-06-20 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:1167 // GCC style -dumpdir. We intentionally don't implement the less useful -dumpbase{,-ext}. -def dumpdir : Separate<["-"], "dumpdir">, Flags<[CC1Option]>, +def dumpdir : Separate<["-"], "dumpdir

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

2023-06-20 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific.c:342 -// CHECK: attributes #[[S]] = {{.*}}"target-features"="+avx,+cmov,+crc32,+cx8,+f16c,+mmx,+popcnt,+sse,+sse2,+sse3,+sse4.1,+sse4.2,+ssse3,+x87,+xsave" // CHECK-SAME: "tune-cpu"="ivybridge" -

<    1   2