[clang] 706b547 - [AIX][TLS] Relax front end diagnostics to accept the local-exec TLS model

Author: Amy Kwan Date: 2023-06-19T12:17:30-05:00 New Revision: 706b5472d897ca75ebd210e4109637793288bcf2 URL: https://github.com/llvm/llvm-project/commit/706b5472d897ca75ebd210e4109637793288bcf2 DIFF: https://github.com/llvm/llvm-project/commit/706b5472d897ca75ebd210e4109637793288bcf2.diff LOG:

[PATCH] D149596: [AIX][TLS] Relax front end diagnostics to accept the local-exec TLS model

This revision was automatically updated to reflect the committed changes. Closed by commit rG706b5472d897: [AIX][TLS] Relax front end diagnostics to accept the local-exec TLS model (authored by amyk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej updated this revision to Diff 532705. dicej added a comment. generalize Wasm tests and release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153293/new/ https://reviews.llvm.org/D153293 Files: clang/docs/ReleaseNotes.rst clang/test

[clang] 2da4517 - Reland "[DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)"

Author: Vladislav Dzhidzhoev Date: 2023-06-19T19:50:46+02:00 New Revision: 2da45172c4bcd42f704c57c656926f56f32fc5ce URL: https://github.com/llvm/llvm-project/commit/2da45172c4bcd42f704c57c656926f56f32fc5ce DIFF: https://github.com/llvm/llvm-project/commit/2da45172c4bcd42f704c57c656926f56f32fc5c

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added inline comments. Comment at: clang/docs/LanguageExtensions.rst:656 + T __builtin_elementwise_nearbyint(T x) round x to the nearest integer value in floating point format, floating point types + rounding accord

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn updated this revision to Diff 532719. hnrklssn added a comment. Keep supporting --check-globals without explicit level as meaning '--check-globals all' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/ https://reviews.llvm.org/D14

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn marked an inline comment as done. hnrklssn added inline comments. Comment at: llvm/utils/UpdateTestChecks/common.py:1286 + if value == default_value: +continue if action.dest == 'filters': nikic wrote: > nikic wrote: > > nikic wrote: >

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

Sedeniono updated this revision to Diff 532721. Sedeniono added a comment. As suggested by HazardyKnusperkeks, increased the number of stack elements and removed the reserve(). That causes all Passes to be stored on the stack. (I counted 17 distinct possible passes, but not all of them can be ac

[PATCH] D153251: [clangd] Index the type of a non-type template parameter

nridge planned changes to this revision. nridge added inline comments. Comment at: clang/lib/Index/IndexDecl.cpp:708 } else if (const auto *NTTP = dyn_cast(TP)) { +IndexCtx.indexTypeSourceInfo(NTTP->getTypeSourceInfo(), Parent); if (NTTP->hasDefaultArgumen

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

Sedeniono marked 2 inline comments as done. Sedeniono added inline comments. Comment at: clang/lib/Format/Format.cpp:3475 AnalyzerPass; SmallVector Passes; HazardyKnusperkeks wrote: > Just increase here, and add a comment that there are multiple passe

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 532734. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clan

[PATCH] D153248: [clangd] Use resolveTypeToRecordDecl() to resolve the type of a base specifier during heuristic resolution

nridge added a comment. In D153248#4432108 , @hokein wrote: > The other question might worth thinking, are these cases critical to fix now? > I'm not sure `this->find()` is a common case (`find();` already works today). I may have simplified the test ca

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu added inline comments. Comment at: llvm/test/MC/RISCV/comments.ll:25 +# CHECK: .Lpcrel_hi0:#c0 #c1 #c2 #c3 #c4 #c5 #c6 +# CHECK: auipc s0, %pcrel_hi(symbol+10) +# CHECK: addis0, s0, %pcrel_lo(.Lpcrel_hi0) This shoul

[PATCH] D153243: [clang-format] Don't finalize #if, #else, #endif, etc.

Sedeniono requested changes to this revision. Sedeniono added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1416-1421 + if (Tok->is(tok::hash) && !Tok->Previous && Tok->Next && + Tok->Next->is

[clang] 407dcaf - [Driver] Correct -fnoxray-link-deps to -fno-xray-link-deps

Author: Fangrui Song Date: 2023-06-19T12:48:33-07:00 New Revision: 407dcaf002f71abf940f3e903fa17791b150995d URL: https://github.com/llvm/llvm-project/commit/407dcaf002f71abf940f3e903fa17791b150995d DIFF: https://github.com/llvm/llvm-project/commit/407dcaf002f71abf940f3e903fa17791b150995d.diff

[PATCH] D153235: [RISCV] Change the type of argument to clz and ctz from ZiZi/WiWi to iUi/iULi

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:22 +TARGET_BUILTIN(__builtin_riscv_clz_32, "iUi", "nc", "zbb|xtheadbb") +TARGET_BUILTIN(__builtin_riscv_clz_64, "iULi", "nc", "zbb|xtheadbb,64bit") +TARGET_BUILTIN(__builtin_riscv_ctz_32,

[PATCH] D153208: [clang-format] Add InsertNewlineAtEOF to .clang-format files

HazardyKnusperkeks added a comment. In D153208#4431697 , @owenpan wrote: > In D153208#4431239 , > @HazardyKnusperkeks wrote: > >> We also could add a clang-format style, the you wouldn't have to to touch >> all

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Please wait for at least @MyDeveloperDay to say something, as he is the original author of the work. Comment at: clang/lib/Format/Format.cpp:3475

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

shafik added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:18177 getASTContext()), /*IsImmediateInvocation*/ true); if (Cached.hasValue()) Drive by nit clean-up while we are here. Comment

[PATCH] D152882: [LinkerWrapper] Support device binaries in multiple link jobs

jhuber6 updated this revision to Diff 532748. jhuber6 added a comment. I'm not sure why this keeps failing on Windows and have no clue how to tell what's going wrong. The builder simply says c:\ws\w4\llvm-project\premerge-checks\build\bin\clang-linker-wrapper.exe: error: invalid argument But

[PATCH] D153298: [clang-tidy] Extend bugprone-exception-escape diagnostics

isuckatcs added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ExceptionEscapeCheck.cpp:84-86 + if (AnalyzeResult.containsUnknownElements()) +diag(MatchedDecl->getLocation(), "may throw unknown exceptions", + DiagnosticIDs::Note);

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu updated this revision to Diff 532753. abel-bernabeu added a comment. Added --match-fulllines to FileCheck for making the check stricter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153008/new/ https://reviews.llvm.org/D153008 Files

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu updated this revision to Diff 532754. abel-bernabeu added a comment. Removed a gratuitous blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153008/new/ https://reviews.llvm.org/D153008 Files: llvm/lib/Target/RISCV/AsmParser/

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu accepted this revision. abel-bernabeu added a comment. Am happy with the current patch version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153008/new/ https://reviews.llvm.org/D153008 ___

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu updated this revision to Diff 532758. abel-bernabeu added a comment. On the zdinx test, changed a FileCheck comment that was written starting with "//" rather than "#". Changed for "#" just for consistency with the rest of tests. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu added a comment. @jrtc27: The tests: - are under llvm/test/MC/RISCV - use llvm-mc as assembler (rather than C!) - are as simple as they can be - cover every line touched by this patch. Would you unblock this now? Thanks for your feedback so far. @MaskRay: Let me know if you miss

[PATCH] D153310: Add builtin_elementwise_pow

bob80905 created this revision. Herald added subscribers: luke, Anastasia, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a

[clang] fec7c64 - Revert "Reland "[DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)""

Author: Vladislav Dzhidzhoev Date: 2023-06-20T01:54:48+02:00 New Revision: fec7c6457ced7e87d4e0837402b0b8a644cf6242 URL: https://github.com/llvm/llvm-project/commit/fec7c6457ced7e87d4e0837402b0b8a644cf6242 DIFF: https://github.com/llvm/llvm-project/commit/fec7c6457ced7e87d4e0837402b0b8a644cf624

[clang] cb9ac70 - Reland "[DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)" (2)

Author: Vladislav Dzhidzhoev Date: 2023-06-20T03:01:46+02:00 New Revision: cb9ac7051589ea0d05507f9370d0716bef86b4ae URL: https://github.com/llvm/llvm-project/commit/cb9ac7051589ea0d05507f9370d0716bef86b4ae DIFF: https://github.com/llvm/llvm-project/commit/cb9ac7051589ea0d05507f9370d0716bef86b4a

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:110 FeatureBitset Features; + char Mangling; + bool OnlyForCPUDispatchSpecific; RKSimon wrote: > Do we have a documented list of the mangling values anywhere? The values >

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen marked an inline comment as done. HaohaiWen added a comment. Any other comments? If not , I'll land this patch tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 _

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe updated this revision to Diff 532772. FreddyYe added a comment. Adjust atom_sse4_2_movbe test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 Files: clang/lib/Basic/Targets/X86.cpp clang/lib

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

sbc100 accepted this revision. sbc100 added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153293/new/ https://reviews.llvm.org/D153293 __

[PATCH] D153314: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 created this revision. JOE1994 added reviewers: barannikov88, nikic. Herald added subscribers: StephenFan, kbarton, nemanjai. Herald added a project: All. JOE1994 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Partial progress towa

[PATCH] D153243: [clang-format] Don't finalize #if, #else, #endif, etc.

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1416-1421 + if (Tok->is(tok::hash) && !Tok->Previous && Tok->Next && + Tok->Next->isOneOf(tok::pp_if, tok::pp_ifdef, tok::pp_ifndef, + tok::pp_elif, to

[PATCH] D153208: [clang-format] Add InsertNewlineAtEOF to .clang-format files

owenpan added a comment. In D153208#4433511 , @HazardyKnusperkeks wrote: > In D153208#4431697 , @owenpan wrote: > >> In D153208#4431239 , >> @HazardyKnusperkeks wrote: >

[PATCH] D138397: HIP: Directly call ldexp builtins

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138397/new/ https://reviews.llvm.org/D138397 ___ cfe-commits mailing list cfe-

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152391/new/ https://reviews.llvm.org/D152391 __

[clang] dafaa84 - [XRay] Make llvm.xray.customevent parameter type match __xray_customevent

Author: Fangrui Song Date: 2023-06-19T20:38:16-07:00 New Revision: dafaa8463ef6991055c2fcee799757fa46965625 URL: https://github.com/llvm/llvm-project/commit/dafaa8463ef6991055c2fcee799757fa46965625 DIFF: https://github.com/llvm/llvm-project/commit/dafaa8463ef6991055c2fcee799757fa46965625.diff

[PATCH] D153298: [clang-tidy] Extend bugprone-exception-escape diagnostics

PiotrZSL updated this revision to Diff 532783. PiotrZSL marked 3 inline comments as done. PiotrZSL added a comment. Review fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153298/new/ https://reviews.llvm.org/D153298 Files: clang-tools-extra

[PATCH] D153298: [clang-tidy] Extend bugprone-exception-escape diagnostics

PiotrZSL added a comment. Question would be, does this can stay +- like this and we could wait with extension this until some users for example complain, that they would like it to be extended, or this need to be done now. Main reason for this change is, that often I run into situation when ther

[PATCH] D153235: [RISCV] Change the type of argument to clz and ctz from ZiZi/WiWi to iUi/iULi

Jim updated this revision to Diff 532790. Jim added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153235/new/ https://reviews.llvm.org/D153235 Files: clang/include/clang/Basic/BuiltinsRISCV.def clang/test/CodeGen/RI

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 532796. eopXD marked an inline comment as done. eopXD added a comment. Save and restore FRM in RISCVInsertReadWriteCSR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 532797. eopXD added a comment. Remove unnecessary include-s. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/include/clang/Basic/riscv_vector.td clang/

[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

grosser added a comment. That is perfectly fine. I just wanted to let you know that we are still interested in this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138278/new/ https://reviews.llvm.org/D138278 __

[PATCH] D153251: [clangd] Index the type of a non-type template parameter

nridge updated this revision to Diff 532798. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153251/new/ https://reviews.llvm.org/D153251 Files: clang/lib/Index/IndexDecl.cpp clang/unittests/Index/I

<    1   2