[clang-tools-extra] 845618c - [clang-tidy] Refactor common code from the Noexcept*Checks into `NoexceptFunctionCheck`

Author: AMS21 Date: 2023-06-18T06:50:05Z New Revision: 845618cf69e89313084a4e93f8ff31d8e6ea4499 URL: https://github.com/llvm/llvm-project/commit/845618cf69e89313084a4e93f8ff31d8e6ea4499 DIFF: https://github.com/llvm/llvm-project/commit/845618cf69e89313084a4e93f8ff31d8e6ea4499.diff LOG: [clang-

[PATCH] D153198: [clang-tidy] Refactor common code from the Noexcept*Checks into `NoexceptFunctionCheck`

This revision was automatically updated to reflect the committed changes. Closed by commit rG845618cf69e8: [clang-tidy] Refactor common code from the Noexcept*Checks into… (authored by AMS21, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D153220: [clang-tidy] Improve `performance-move-const-arg` message when no move constructor is available

AMS21 created this revision. AMS21 added reviewers: PiotrZSL, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. AMS21 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commi

[PATCH] D153220: [clang-tidy] Improve `performance-move-const-arg` message when no move constructor is available

AMS21 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance/move-const-arg.cpp:345 +namespace issue_62550 { + +struct NonMoveConstructable { I've tried to add ``` // CHECK-MESSAGES: [[@LINE+1]]:1: note: 'NonMoveConstructable'

[PATCH] D153218: [clang-tidy] Fix `llvmlibc-inline-function-decl` false positives for templated function definitions

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. I got one concern, if you write this: template LIBC_INLINE void VariadicTemplate::goodVariadicTemplate() {} template inline void VariadicTemplate::badVariadicTemplate() {}

[PATCH] D153220: [clang-tidy] Improve `performance-move-const-arg` message when no move constructor is available

PiotrZSL added a comment. Overall looks ok, Add some test with records being used via typedef. Comment at: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp:117 + bool IsConstArg = ArgType.isConstQualified(); + bool IsTriviallyCopyable = ArgType.isTriviallyCopyab

[PATCH] D153218: [clang-tidy] Fix `llvmlibc-inline-function-decl` false positives for templated function definitions

AMS21 updated this revision to Diff 532455. AMS21 added a comment. Implemented suggested fix and added a test case Added entry to ReleaseNotes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153218/new/ https://reviews.llvm.org/D153218 Files: clan

[PATCH] D153218: [clang-tidy] Fix `llvmlibc-inline-function-decl` false positives for templated function definitions

AMS21 added a comment. Regarding the problems with attributes like nodiscard. I'm honestly not quite sure, but from the way the check is implemented and the warning is worded, it sounds to me like the attributes should come after LIBC_INLINE. Although looking at the Styleguide for libc, I didn'

[PATCH] D153220: [clang-tidy] Improve `performance-move-const-arg` message when no move constructor is available

AMS21 updated this revision to Diff 532458. AMS21 marked 5 inline comments as done. AMS21 added a comment. Implement suggested changes Add tests with typedefs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153220/new/ https://reviews.llvm.org/D15322

[PATCH] D153218: [clang-tidy] Fix `llvmlibc-inline-function-decl` false positives for templated function definitions

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153218/new/ https://reviews.llvm.org/D153218 ___

[PATCH] D153220: [clang-tidy] Improve `performance-move-const-arg` message when no move constructor is available

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. +- LGTM Comment at: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp:207 + +if (const CXXRecordDecl *RecordDecl = ArgType->getAsCXXRecordDecl(); +

[PATCH] D153218: [clang-tidy] Fix `llvmlibc-inline-function-decl` false positives for templated function definitions

AMS21 added a comment. If there are no more problems, I would kindly as for someone to push this on my behalf :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153218/new/ https://reviews.llvm.org/D153218 __

[PATCH] D153220: [clang-tidy] Improve `performance-move-const-arg` message when no move constructor is available

AMS21 updated this revision to Diff 532466. AMS21 marked 2 inline comments as done. AMS21 added a comment. Implemented suggested changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153220/new/ https://reviews.llvm.org/D153220 Files: clang-tool

[PATCH] D153220: [clang-tidy] Improve `performance-move-const-arg` message when no move constructor is available

AMS21 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance/move-const-arg.cpp:345 +namespace issue_62550 { + +struct NonMoveConstructable { PiotrZSL wrote: > AMS21 wrote: > > I've tried to add > > > > ``` > > // CHECK-MESSAG

[PATCH] D153220: [clang-tidy] Improve `performance-move-const-arg` message when no move constructor is available

PiotrZSL accepted this revision. PiotrZSL added a comment. LGTM Comment at: clang-tools-extra/docs/ReleaseNotes.rst:378-379 +- Improved :doc:`performance-move-const-arg + ` check to warn when no move + constructor is available. + NOTE: `check to warn when no

[PATCH] D153197: [AVR] Expand shifts during AVRISelLowering

Patryk27 added inline comments. Comment at: llvm/lib/Target/AVR/AVRISelLowering.cpp:2207 + MF->push_back(LoopBB); + MachineBasicBlock *ExitBB = EntryBB->splitAt(MI, false); + Alright, this is wrong, after all - I've just tested it on a more elaborate code in r

[PATCH] D153220: [clang-tidy] Improve `performance-move-const-arg` message when no move constructor is available

AMS21 updated this revision to Diff 532467. AMS21 added a comment. Improve doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153220/new/ https://reviews.llvm.org/D153220 Files: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp cla

[PATCH] D153220: [clang-tidy] Improve `performance-move-const-arg` message when no move constructor is available

AMS21 added a comment. As always if there are no more problems, I would kindly ask for someone to push this on my behalf :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153220/new/ https://reviews.llvm.org/D153220 ___

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian added a comment. This is good to review now. Phabricator has become a bit confused after rebasing on top of https://reviews.llvm.org/D151557, I don't know whether it's worth creating a new, cleaner review and close this on? CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang-tools-extra] c96306d - [clang-tidy] Fix `llvmlibc-inline-function-decl` false positives for templated function definitions

Author: AMS21 Date: 2023-06-18T11:40:33Z New Revision: c96306db2cad4cf687cb044c8a0635f982a4db98 URL: https://github.com/llvm/llvm-project/commit/c96306db2cad4cf687cb044c8a0635f982a4db98 DIFF: https://github.com/llvm/llvm-project/commit/c96306db2cad4cf687cb044c8a0635f982a4db98.diff LOG: [clang-

[clang-tools-extra] 82d4dc2 - [clang-tidy] Improve `performance-move-const-arg` message when no move constructor is available

Author: AMS21 Date: 2023-06-18T11:40:47Z New Revision: 82d4dc20efbd72e20b430913e985e38997c7a3e8 URL: https://github.com/llvm/llvm-project/commit/82d4dc20efbd72e20b430913e985e38997c7a3e8 DIFF: https://github.com/llvm/llvm-project/commit/82d4dc20efbd72e20b430913e985e38997c7a3e8.diff LOG: [clang-

[PATCH] D153218: [clang-tidy] Fix `llvmlibc-inline-function-decl` false positives for templated function definitions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc96306db2cad: [clang-tidy] Fix `llvmlibc-inline-function-decl` false positives for templated… (authored by AMS21, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153220: [clang-tidy] Improve `performance-move-const-arg` message when no move constructor is available

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82d4dc20efbd: [clang-tidy] Improve `performance-move-const-arg` message when no move… (authored by AMS21, committed by PiotrZSL). Repository: rG

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

Destroyerrrocket requested changes to this revision. Destroyerrrocket added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clangd/ModulesManager.cpp:413-414 + else +WaitingCallables[Filename.str()].push_back( +{std::move

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx updated this revision to Diff 532470. AlexVlx added a comment. `clang-format` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153092/new/ https://reviews.llvm.org/D153092 Files: clang/lib/CodeGen/CGVTT.cpp clang/lib/CodeGen/CGVTables.cpp clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D153226: OpenMP: Don't include stdbool.h in builtin headers

arsenm created this revision. arsenm added reviewers: ronlieb, jdoerfert, doru1004. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. arsenm requested review of this revision. Herald added subscribers: jplehr, sstefan1, wdng. Pre-C99 didn't include bool, and C99 a

[PATCH] D153226: OpenMP: Don't include stdbool.h in builtin headers

ronlieb added a subscriber: mhalk. ronlieb added a comment. @mhalk to review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153226/new/ https://reviews.llvm.org/D153226 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D153226: OpenMP: Don't include stdbool.h in builtin headers

ronlieb accepted this revision. ronlieb added a comment. This revision is now accepted and ready to land. patch applied to local build resolves issues seen CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153226/new/ https://reviews.llvm.org/D153226 ___

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

Sedeniono created this revision. Sedeniono added a reviewer: MyDeveloperDay. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan. Sedeniono requested review of this revision. This fixes github issue #5

[PATCH] D152351: [clang] Add __builtin_isfpclass

sepavloff added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152351/new/ https://reviews.llvm.org/D152351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] 7dd387d - [clang] Add __builtin_isfpclass

Author: Serge Pavlov Date: 2023-06-18T22:53:32+07:00 New Revision: 7dd387d2971d7759cadfffeb2082439f6c7ddd49 URL: https://github.com/llvm/llvm-project/commit/7dd387d2971d7759cadfffeb2082439f6c7ddd49 DIFF: https://github.com/llvm/llvm-project/commit/7dd387d2971d7759cadfffeb2082439f6c7ddd49.diff

[PATCH] D152351: [clang] Add __builtin_isfpclass

This revision was automatically updated to reflect the committed changes. Closed by commit rG7dd387d2971d: [clang] Add __builtin_isfpclass (authored by sepavloff). Changed prior to commit: https://reviews.llvm.org/D152351?vs=530772&id=532477#toc Repository: rG LLVM Github Monorepo CHANGES S

[clang] 112fa9a - [Doc] Fix table layout

Author: Serge Pavlov Date: 2023-06-18T23:46:08+07:00 New Revision: 112fa9aa7042861ba101828d87e8d6b629121eae URL: https://github.com/llvm/llvm-project/commit/112fa9aa7042861ba101828d87e8d6b629121eae DIFF: https://github.com/llvm/llvm-project/commit/112fa9aa7042861ba101828d87e8d6b629121eae.diff

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

mikecrowe marked 6 inline comments as done. mikecrowe added a comment. Thanks for the comprehensive review. Comment at: clang-tools-extra/clang-tidy/modernize/UseStdPrintCheck.cpp:43-44 + + if (!MaybeHeaderToInclude && (ReplacementPrintFunction == "std::print" || +

[clang] b57e049 - clang/HIP: Use __builtin_fmaf16

Author: Matt Arsenault Date: 2023-06-18T13:13:49-04:00 New Revision: b57e049fe5ccf48bb105b96020901d2912de9588 URL: https://github.com/llvm/llvm-project/commit/b57e049fe5ccf48bb105b96020901d2912de9588 DIFF: https://github.com/llvm/llvm-project/commit/b57e049fe5ccf48bb105b96020901d2912de9588.diff

[PATCH] D144802: clang: Add __builtin_elementwise_round

arsenm updated this revision to Diff 532481. arsenm marked 2 inline comments as done. arsenm added a comment. Fix description and add release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144802/new/ https://reviews.llvm.org/D144802 Files: clang/docs/LanguageExtensions.rst cl

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian created this revision. Herald added subscribers: bviyer, luke, Moerafaat, kmitropoulou, zero9178, steakhal, mtrofin, bzcheeseman, mattd, gchakrabarti, pmatos, asb, sdasgup3, asavonic, jeroen.dobbelaere, wenzhicui, wrengr, ormris, foad, ChuanqiXu, cota, teijeong, frasercrmck, rdzh

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian added a comment. Herald added a subscriber: jsetoain. This was found with IncludeGuardian 0.0.8. The line that suggested this can be found in the output here . The count of pre

[PATCH] D152975: [clang-format] Allow break after return keyword

HazardyKnusperkeks added a comment. In D152975#4430504 , @gedare wrote: > In D152975#4425932 , > @HazardyKnusperkeks wrote: > >> And please add a remark in the changelog. > > Is there a separate changelog file?

[clang] 9932eb0 - [AST] Use DenseMapBase::lookup (NFC)

Author: Kazu Hirata Date: 2023-06-18T11:52:59-07:00 New Revision: 9932eb083a0b735dbbf8b3341ba93dccc00358ae URL: https://github.com/llvm/llvm-project/commit/9932eb083a0b735dbbf8b3341ba93dccc00358ae DIFF: https://github.com/llvm/llvm-project/commit/9932eb083a0b735dbbf8b3341ba93dccc00358ae.diff L

[PATCH] D153205: [clang-format] Add new block type ListInit

HazardyKnusperkeks added a comment. In D153205#4430528 , @owenpan wrote: > It seems to me that there has been a proliferation of new options being > proposed and/or accepted recently. I'd like to remind everyone of the > long-standing policy >

[PATCH] D153208: [clang-format] Add InsertNewlineAtEOF to .clang-format files

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. We also could add a clang-format style, the you wouldn't have to to touch all .clang-format files. ;) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153208/new/

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/Analyses/IntervalPartition.h:35 + + std::set Blocks; + Nit: I wonder if we want something like `llvm::DenseSet` when we use smaller types like pointers. Same for `Successors`. =

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

HazardyKnusperkeks added a comment. I'm shocked, astonished and in awe how small this patch is. Great work and explanation! Comment at: clang/lib/Format/Format.cpp:3475 AnalyzerPass; SmallVector Passes; Just increase here, and add a comment that th

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Except readability issues with this check code (bunch of else, ..), and that I didn't took a deep dive into format string conversion (I hope that author is right there). I would say that t

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

mikecrowe added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FormatStringConverter.cpp:202 +/// Called for each format specifier by ParsePrintfString. +bool FormatStringConverter::HandlePrintfSpecifier( +const analyze_printf::PrintfSpecifier &FS, const char

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu updated this revision to Diff 532488. abel-bernabeu added a comment. Updated commit message: - fixed a typo - added a co-author Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153008/new/ https://reviews.llvm.org/D153008 Files: llvm

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu updated this revision to Diff 532489. abel-bernabeu added a comment. Fixed a typo on commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153008/new/ https://reviews.llvm.org/D153008 Files: llvm/lib/Target/RISCV/AsmParser/R

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm created this revision. arsenm added reviewers: aaron.ballman, RKSimon, fhahn, junaire, bob80905, python3kgae, erichkeane, sepavloff, kpn, andrew.w.kaylor. Herald added a subscriber: StephenFan. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber:

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe updated this revision to Diff 532494. FreddyYe added a comment. Update cpus-intel.ll. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 Files: clang/lib/Basic/Targets/X86.cpp clang/lib/Basic/Ta

[PATCH] D152764: [clang-tidy] Reserved-identifier: Improved AllowedIdentifiers option to support regular expressions

felix642 updated this revision to Diff 532495. felix642 added a comment. Resolved comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152764/new/ https://reviews.llvm.org/D152764 Files: clang-tools-extra/clang-tidy/bugprone/ReservedIdentifie

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe marked 2 inline comments as done. FreddyYe added inline comments. Comment at: llvm/test/CodeGen/X86/cpus-intel.ll:8 ; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown -mcpu=pentium 2>&1 | FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty -; RUN: llc < %s

[PATCH] D153235: [RISCV] Change the type of argument to clz and ctz from ZiZi/WiWi to iUi/iULi

Jim created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, si

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

ChuanqiXu updated this revision to Diff 532502. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153114/new/ https://reviews.llvm.org/D153114 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/ClangdLSPServer.cpp clan

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

ChuanqiXu added inline comments. Comment at: clang-tools-extra/clangd/ModulesManager.cpp:413-414 + else +WaitingCallables[Filename.str()].push_back( +{std::move(ReadyCallback), std::move(ReadyCallback)}); +} Destroyerrrocket wrote: > This is a bug; T

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 532507. HaohaiWen added a comment. Use --target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Dr

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen marked 7 inline comments as done. HaohaiWen added inline comments. Comment at: llvm/lib/MC/WinCOFFObjectWriter.cpp:124 +bool isDwoSection(const MCSection &Sec) { + return Sec.getName().endswith(".dwo"); MaskRay wrote: > static It's already in anonymo

[clang] 2d8044e - Recommit [ABI] [C++20] [Modules] Don't generate vtable if the class is defined in other module unit

Author: Chuanqi Xu Date: 2023-06-19T10:41:12+08:00 New Revision: 2d8044ee8b19f23e0a7fe5cd35876515d0d1d72e URL: https://github.com/llvm/llvm-project/commit/2d8044ee8b19f23e0a7fe5cd35876515d0d1d72e DIFF: https://github.com/llvm/llvm-project/commit/2d8044ee8b19f23e0a7fe5cd35876515d0d1d72e.diff LO

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

jdoerfert added a comment. could you put a little more information in the commit message please. "It won't do X when we do Y", could mean a lot of things. We don't do Y anymore, or we do X' now, with various choices for X'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

schittir created this revision. schittir added reviewers: aaron.ballman, tahonermann, erichkeane. Herald added a project: All. schittir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Replace getAs with castAs and add assert if needed. Re

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe updated this revision to Diff 532517. FreddyYe marked an inline comment as done. FreddyYe added a comment. Typo refine: OnlyForCPUSpecificDispath -> OnlyForCPUDispatchSpecific Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe added a comment. Thanks for @RKSimon 's review, I'd like also to mention that https://reviews.llvm.org/D152989 is supposed to be the base commit of here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

barannikov88 added a comment. - I'd prefer Lex() over equivalent getParser().Lex() because it is shorter. - Ideally, every change should be tested. - The tests should be minimal. That is, they should be assembly files passed to llvm-mc rather than ll files passed to llc. I'm not very familiar wi

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

schittir updated this revision to Diff 532528. schittir added a comment. Fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153236/new/ https://reviews.llvm.org/D153236 Files: clang/lib/Parse/ParseStmt.cpp clang/lib/Sema/SemaExprObjC.cpp clang/lib/Sema/SemaObjCProperty.cpp

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

sepavloff added inline comments. Comment at: clang/docs/LanguageExtensions.rst:656 + T __builtin_elementwise_nearbyint(T x) round x to the nearest integer value in floating point format, floating point types + rounding halfw

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

skan accepted this revision. skan added a comment. This revision is now accepted and ready to land. LGTM for the MC part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 __

[PATCH] D152764: [clang-tidy] Reserved-identifier: Improved AllowedIdentifiers option to support regular expressions

PiotrZSL accepted this revision. PiotrZSL added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152764/new/ https://reviews.llvm.org/D152764 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

eopXD updated this revision to Diff 532531. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/ https://reviews.llvm.org/D151397 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Sem

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

eopXD updated this revision to Diff 532532. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152879/new/ https://reviews.llvm.org/D152879 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Sem

[PATCH] D153241: [clang][Diagnostics] Provide source range to invalid casts in const expr

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, shafik, hazohelet, cjdb. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D153132: [clang analysis][NFCI] Preparatory work for D153131.

courbet added a comment. > Is this actually required for the subsequent change? I don't see the > connection. In the followup change, we have to check the returns after the enter and exit CFG block are computed. We can't analyze the returns as they are seen because , because what matters for t

[PATCH] D153132: [clang analysis][NFCI] Preparatory work for D153131.

courbet updated this revision to Diff 532534. courbet added a comment. remove type alias Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153132/new/ https://reviews.llvm.org/D153132 Files: clang/lib/Analysis/ThreadSafety.cpp Index: clang/lib/Anal

[PATCH] D153111: [clang][Serialization][RISCV] Increase the number of reserved predefined type IDs

zixuan-wu added a comment. I also caught this issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153111/new/ https://reviews.llvm.org/D153111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 532536. eopXD added a comment. Herald added a subscriber: qcolombet. Update code: - Change value to indicate no rounding mode change from `99` to `7`. - Add code under `RISCVDAGToDAGISel::performCombineVMergeAndVOps` to deal with the extra rounding mode operan

[PATCH] D153243: [clang-format] Don't finalize #if, #else, #endif, etc.

owenpan created this revision. owenpan added a reviewer: Sedeniono. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Don't finalize a preprocessor

[PATCH] D153111: [clang][Serialization][RISCV] Increase the number of reserved predefined type IDs

rogfer01 added a comment. Thanks @eopXD. Not sure why you didn't observe the failure. I understand your build has `-DLLVM_ENABLE_ASSERTIONS=ON`. I investigated a bit the libcxx errors flagged by the precommit CI. I can get similar (but not exactly the same errors) if the build before this chang

[PATCH] D153208: [clang-format] Add InsertNewlineAtEOF to .clang-format files

owenpan added a comment. In D153208#4431239 , @HazardyKnusperkeks wrote: > We also could add a clang-format style, the you wouldn't have to to touch all > .clang-format files. ;) Something like `BasedOnStyle: clang-format`? I like it but feel that it s