[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)); + else if (!UseIntegratedAs) { shchenz wrote: > qiongs

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:703 +Arg *A = Args.getLastArgNoClaim(options::OPT_fno_integrated_as); +D.Diag(diag::warn_drv_unsupported_lto_option_for_target) +<< A->getSpelling() << ToolChain.getTriple().getT

[clang] ce8ff3f - Remove clang/ModuleInfo.txt

Author: Jonas Hahnfeld Date: 2023-06-16T09:11:11+02:00 New Revision: ce8ff3facc637ae116f0d1c560a602b4dc939deb URL: https://github.com/llvm/llvm-project/commit/ce8ff3facc637ae116f0d1c560a602b4dc939deb DIFF: https://github.com/llvm/llvm-project/commit/ce8ff3facc637ae116f0d1c560a602b4dc939deb.diff

[PATCH] D152995: Remove clang/ModuleInfo.txt

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce8ff3facc63: Remove clang/ModuleInfo.txt (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D152645: [clangd] Handle DependentNameType in HeuristicResolver::resolveTypeToRecordDecl()

nridge updated this revision to Diff 532008. nridge marked 2 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152645/new/ https://reviews.llvm.org/D152645 Files: clang-tools-e

[PATCH] D152645: [clangd] Handle DependentNameType in HeuristicResolver::resolveTypeToRecordDecl()

nridge added inline comments. Comment at: clang-tools-extra/clangd/HeuristicResolver.cpp:56 + if (const auto *DNT = T->getAs()) { +T = resolveDeclsToType(resolveDependentNameType(DNT)); +if (!T) hokein wrote: > Is the `resolveDeclsToType` call necessary

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144457/new/ https://reviews.llvm.org/D144457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] 4d0cfa6 - [clang] Don't create import decls without -fmodules

Author: Kadir Cetinkaya Date: 2023-06-16T09:26:45+02:00 New Revision: 4d0cfa6d09e2a84cceb669949d72df58c031a8c5 URL: https://github.com/llvm/llvm-project/commit/4d0cfa6d09e2a84cceb669949d72df58c031a8c5 DIFF: https://github.com/llvm/llvm-project/commit/4d0cfa6d09e2a84cceb669949d72df58c031a8c5.dif

[PATCH] D152274: [clang] Don't create import decls without -fmodules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4d0cfa6d09e2: [clang] Don't create import decls without -fmodules (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D15227

[PATCH] D153109: [clang-format][NFC] Clean up unit tests

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. This patch adds a `verifyNoChange` macro to verify code that won't

[PATCH] D153111: [clang][Serialization][RISCV] Increase the number of reserved predefined type IDs

rogfer01 created this revision. rogfer01 added reviewers: eopXD, Eugene.Zelenko, craig.topper. Herald added subscribers: jobnoorman, VincentWu, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, shiva0217, kito-cheng, simoncook, arichardson. Herald added a project: All. rogfe

[PATCH] D153018: [include-cleaner] Reorder SymbolReference fields to avoid padding space, NFC

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153018/new/ https://reviews.llvm.org/D153018 __

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

rogfer01 added a comment. It looks like we need to increase `NUM_PREDEF_TYPE_IDS`. Let's continue the discussion on D153111 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152070/new/ https://reviews.llvm.org/D1520

[clang] 461f91b - [clang][Interp] Handle LambdaExprs

Author: Timm Bäder Date: 2023-06-16T10:05:33+02:00 New Revision: 461f91b1e4ef8bd8a5acc95d2e4badc3b2da5f30 URL: https://github.com/llvm/llvm-project/commit/461f91b1e4ef8bd8a5acc95d2e4badc3b2da5f30 DIFF: https://github.com/llvm/llvm-project/commit/461f91b1e4ef8bd8a5acc95d2e4badc3b2da5f30.diff LO

[PATCH] D146030: [clang][Interp] Handle LambdaExprs

This revision was automatically updated to reflect the committed changes. Closed by commit rG461f91b1e4ef: [clang][Interp] Handle LambdaExprs (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146030/new/ https://reviews.llvm.org/D

[PATCH] D153111: [clang][Serialization][RISCV] Increase the number of reserved predefined type IDs

rogfer01 added a comment. Let me check if I can add a `static_assert` to get a compile-time failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153111/new/ https://reviews.llvm.org/D153111 ___ cfe-com

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 532038. IncludeGuardian added a comment. Run clang-format over patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo updated this revision to Diff 532042. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153015/new/ https://reviews.llvm.org/D153015 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-ex

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

Hahnfeld added a comment. > For example, the template name with QualifiedTemplate kind has different hash > name with the name with DependentTemplate kind. But it is not true after the > patch. Yes, I do understand. However, what I'm asking is why we need to differentiate between the two, ie i

[clang-tools-extra] 3b59842 - [include-cleaner] Reorder SymbolReference fields to avoid padding space, NFC

Author: Haojian Wu Date: 2023-06-16T10:21:44+02:00 New Revision: 3b59842a721f0729221347ce0eb20075b1135cc5 URL: https://github.com/llvm/llvm-project/commit/3b59842a721f0729221347ce0eb20075b1135cc5 DIFF: https://github.com/llvm/llvm-project/commit/3b59842a721f0729221347ce0eb20075b1135cc5.diff LO

[PATCH] D153018: [include-cleaner] Reorder SymbolReference fields to avoid padding space, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b59842a721f: [include-cleaner] Reorder SymbolReference fields to avoid padding space, NFC (authored by hokein). Repository: rG LLVM Github Monore

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

jansvoboda11 added a comment. In D151938#4426106 , @Jake-Egan wrote: > Hi, there's a test failure on AIX, could you take a look please? > > https://lab.llvm.org/buildbot/#/builders/214/builds/8005/steps/6/logs/FAIL__Clang__index-with-module_m Thanks for

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo updated this revision to Diff 532044. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Simplify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153015/new/ https://reviews.llvm.org/D153015 Files: clang-tools-extra/clangd

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo added a comment. Thanks for the review! Comment at: clang-tools-extra/clangd/Hover.cpp:663 + const auto *Var = dyn_cast(D); + if (Var && !llvm::isa(Var)) { if (const Expr *Init = Var->getInit()) hokein wrote: > We're ignoring all `ParmVarDecl` ca

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:663 + const auto *Var = dyn_cast(D); + if (Var && !llvm::isa(Var)) { if (const Expr *Init = Var->getInit()) VitaNuo wrote: > hokein wrote: > > We're ignoring all `ParmVarDecl` ca

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:393-395 +const auto *FileEntry = SM.getFileEntryForID(FID); +for (const auto *Export : PI.getExporters(FileEntry, SM.getFileManager())) + return toURI(Export->tryGetRealPat

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

ChuanqiXu added a comment. > what I'm asking is why we need to differentiate between the two, ie in which > cases do we want these two to have a different hash? I don't understand. It should a basic requirement for different AST entities to have different values. > The way I understand your st

[PATCH] D153114: [WIP] [clangd] [C++20] [Modules] Support C++20 modules for clangd

ChuanqiXu created this revision. Herald added subscribers: kadircet, arphaman, javed.absar. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. https://reviews.llvm.org/D

[PATCH] D153114: [WIP] [clangd] [C++20] [Modules] Support C++20 modules for clangd

ChuanqiXu updated this revision to Diff 532056. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153114/new/ https://reviews.llvm.org/D153114 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/clangd/ClangdLSPServer.h clang-

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, looks good, just one nit to simplify the unittest. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:3726 +TEST(Hover, FunctionParameterDefaulValueNotEv

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

chill added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5809 -// For alignment adjusted HFAs, cap the argument alignment to 16, leave it -// default otherwise. +// For alignment adjusted HFAs, cap the argument alignment to 16, otherwise +// set

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 532060. HaohaiWen marked an inline comment as done. HaohaiWen added a comment. Address skan's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files: clan

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:1896 +// Each section in COFF can directly contain relocations. +if (isa(&Obj) && Section.relocations().empty()) + continue; skan wrote: > Should we me

[PATCH] D153111: [clang][Serialization][RISCV] Increase the number of reserved predefined type IDs

rogfer01 updated this revision to Diff 532061. rogfer01 added a comment. ChangeLog: - Add a sentinel and a `static_assert` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153111/new/ https://reviews.llvm.org/D153111 Files: clang/include/clang/Serialization/ASTBitCodes.h clang/lib/Se

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

RKSimon added inline comments. Comment at: llvm/test/CodeGen/X86/cpus-intel.ll:8 ; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown -mcpu=pentium 2>&1 | FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty -; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

Hahnfeld added a comment. In D153003#4427412 , @ChuanqiXu wrote: > An important node here is that ODRHash is used to check the AST Nodes are > keeping the same across compilations. There is gap to use ODRHash to check > the semantical equality. Oh ok..

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

chill added inline comments. Comment at: clang/test/CodeGen/aarch64-ABI-align-packed.c:34 struct aligned_member_8 { uint16x8_t M0 __attribute((aligned (8))); // member alignment 16 since __attribute((aligned (n))) sets the minimum alignment }; Don't you mea

[PATCH] D153111: [clang][Serialization][RISCV] Increase the number of reserved predefined type IDs

eopXD accepted this revision. eopXD added a comment. This revision is now accepted and ready to land. This change looks good to me. Weird that the error did not pop out on my side. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153111/new/ https://reviews.llvm.org/D153111 __

[PATCH] D152645: [clangd] Handle DependentNameType in HeuristicResolver::resolveTypeToRecordDecl()

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/HeuristicResolver.cpp:33 +const Type *resolveDeclsToType(const std::vector &Decls, + ASTContext &Ctx)

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

ChuanqiXu added a comment. > I was thinking to "solve" this by making them hash to the same value, but I'm > hearing that using ODRHash for this purpose is the wrong approach to begin > with? We can't say this abstractly. It should be fine to work in ODRHash for C++20 modules issues as long as

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

JiruiWu marked an inline comment as done. JiruiWu added inline comments. Comment at: clang/test/CodeGen/aarch64-ABI-align-packed.c:34 struct aligned_member_8 { uint16x8_t M0 __attribute((aligned (8))); // member alignment 16 since __attribute((aligned (n))) sets the minimum

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

tmatheson requested changes to this revision. tmatheson added a comment. This revision now requires changes to proceed. I think the current patch is wrong for a couple of reasons. Firstly the data types being tested, e.g. `struct S { int8x16_t m; }` etc, are not just composite types, but HVAs: h

[clang] 6408317 - [clang][Sema] Provide source range to several Wunused warnings

Author: Takuya Shimizu Date: 2023-06-16T19:26:53+09:00 New Revision: 64083172eea26e50c8b22b85697a825be8bda424 URL: https://github.com/llvm/llvm-project/commit/64083172eea26e50c8b22b85697a825be8bda424 DIFF: https://github.com/llvm/llvm-project/commit/64083172eea26e50c8b22b85697a825be8bda424.diff

[PATCH] D152707: [clang][Sema] Provide source range to several Wunused warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rG64083172eea2: [clang][Sema] Provide source range to several Wunused warnings (authored by hazohelet). Changed prior to commit: https://reviews.llvm.org/D152707?vs=531266&id=532079#toc Repository: rG

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

chill added a comment. I was just thinking to LGTM it :) IMHO, the alignment adjustment happens because of C.4 (B.3 indeed leave the HFA/HVA unmodified). > C.4 If the argument is an HFA, an HVA, a Quad-precision Floating-point or > short vector type then the NSAA is rounded up to the next m

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

chill added inline comments. Comment at: clang/test/CodeGen/aarch64-ABI-align-packed.c:34 struct aligned_member_8 { uint16x8_t M0 __attribute((aligned (8))); // member alignment 16 since __attribute((aligned (n))) sets the minimum alignment }; JiruiWu wrote

[clang] 835cdcb - [Clang] Fix compare-record.c test on s390x (NFC)

Author: Nikita Popov Date: 2023-06-16T12:43:58+02:00 New Revision: 835cdcb9191fb8036f782ae532594c4e1f456ffc URL: https://github.com/llvm/llvm-project/commit/835cdcb9191fb8036f782ae532594c4e1f456ffc DIFF: https://github.com/llvm/llvm-project/commit/835cdcb9191fb8036f782ae532594c4e1f456ffc.diff

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

Hahnfeld added a comment. > We can't say this abstractly. It should be fine to work in ODRHash for C++20 > modules issues as long as we don't lose informations. I honestly don't understand this: For the approach to work, we would need to hash the two cases of an unqualified and a qualified temp

[clang] 2903a8a - [CGTypes] Remove recursion protection

Author: Nikita Popov Date: 2023-06-16T13:07:14+02:00 New Revision: 2903a8ab07260f9836db82b7e5330f1892830aca URL: https://github.com/llvm/llvm-project/commit/2903a8ab07260f9836db82b7e5330f1892830aca DIFF: https://github.com/llvm/llvm-project/commit/2903a8ab07260f9836db82b7e5330f1892830aca.diff

[PATCH] D152999: [CGTypes] Remove recursion protection

This revision was automatically updated to reflect the committed changes. Closed by commit rG2903a8ab0726: [CGTypes] Remove recursion protection (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149443/new/ https://reviews.llvm.org/D149443 ___

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:3368 - VD = VD->getCanonicalDecl(); + VD = cast(VD->getCanonicalDecl()); auto I = FunctionGlobalizedDecls.find(CGF.CurFn); This is unnecessary, `getCanonicalDecl()` c

[PATCH] D153123: Fix diag for read-only target features

yaxunl created this revision. yaxunl added reviewers: tra, jhuber6, arsenm. Herald added subscribers: kerbowa, jvesely. Herald added a project: All. yaxunl requested review of this revision. Herald added subscribers: jplehr, sstefan1, wdng. Herald added a reviewer: jdoerfert. Currently the diag is

[PATCH] D152021: [clang][AIX] Fix Overly Strict LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

qiongsiwu1 updated this revision to Diff 532099. qiongsiwu1 added a comment. Revert to the DataSections logic. It is better not to change that in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152021/new/ https://reviews.llvm.org/D152021

[clang-tools-extra] c9888dc - [clangd] Skip function parameter decls when evaluating variables on hover.

Author: Viktoriia Bakalova Date: 2023-06-16T12:09:28Z New Revision: c9888dce44748bfbf3719351c3feb3359eaba017 URL: https://github.com/llvm/llvm-project/commit/c9888dce44748bfbf3719351c3feb3359eaba017 DIFF: https://github.com/llvm/llvm-project/commit/c9888dce44748bfbf3719351c3feb3359eaba017.diff

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

This revision was automatically updated to reflect the committed changes. VitaNuo marked an inline comment as done. Closed by commit rGc9888dce4474: [clangd] Skip function parameter decls when evaluating variables on hover. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo added a comment. Thanks! Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:3726 +TEST(Hover, FunctionParameterDefaulValueNotEvaluatedOnInvalidDecls) { + struct { hokein wrote: > nit: instead of creating a completely-new TEST, it seems sim

[PATCH] D153123: Fix diag for read-only target features

arsenm added inline comments. Comment at: clang/test/OpenMP/driver-openmp-amdgpu.c:8 +// RUN: --offload-device-only -o - 2>&1 | FileCheck --check-prefix=CHECK %s +// CHECK-NOT: warning: feature flag {{.*}} is ignored since the feature is read only Can you use

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:89 +static constexpr int FirstInterestingIdentifierID = LastObjCKeywordID + 1; +static constexpr int LastInterestingIdentifierID = LastObjCKeywordID + tok::NUM_INTERESTING_IDENTIFIERS; +stati

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 updated this revision to Diff 532110. qiongsiwu1 added a comment. Revising the option processing logic to not pass in `-no-integrated-as=0`. Thanks @shchenz and @MaskRay for the feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152

[PATCH] D153128: [AArch64][RCPC3] Add Neon intrinsics for LDAP1 and STL2

pratlucas created this revision. pratlucas added reviewers: tmatheson, vhscampos, dmgreen. Herald added a subscriber: kristof.beyls. Herald added a project: All. pratlucas requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds new intris

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 marked 3 inline comments as done. qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)); + else if (!UseIntegrat

[PATCH] D153130: [Clang][AArch64] Implement ACLE feature macro for FEAT_LRCPC3

pratlucas created this revision. pratlucas added reviewers: tmatheson, vhscampos. Herald added a subscriber: kristof.beyls. Herald added a project: All. pratlucas requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements the new value

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 marked an inline comment as done. qiongsiwu1 added a comment. In D152924#4426895 , @shchenz wrote: > Seems passing `-Wl,-bplugin_opt:-no-integrated-as=1` from clang driver does > not work as expected. Is this expected or by design(We can only

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

tmatheson added a comment. In D146242#4427707 , @chill wrote: > I was just thinking to LGTM it :) > > IMHO, the alignment adjustment happens because of C.4 (B.3 indeed leave the > HFA/HVA unmodified). > >> C.4 If the argument is an HFA, an HVA, a Quad-

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

courbet created this revision. courbet added a reviewer: delesley. Herald added a reviewer: NoQ. Herald added a project: All. courbet requested review of this revision. Herald added a project: clang. ...of guarded variables, when the function is not marked as requiring locks: class Return {

[PATCH] D149437: [clangd] Emit ChangeAnnotation label and description for include-cleaner diagnostics.

hokein updated this revision to Diff 532117. hokein marked 2 inline comments as done. hokein added a comment. rebase, and address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149437/new/ https://reviews.llvm.org/D149437 Files: c

[PATCH] D153132: [clang analysis][NFCI] Preparatory work for D153131.

courbet created this revision. courbet added a reviewer: delesley. Herald added a reviewer: NoQ. Herald added a project: All. courbet requested review of this revision. Herald added a project: clang. Refactoring in preparation for D153131 Repository: rG LLVM

[PATCH] D149437: [clangd] Emit ChangeAnnotation label and description for include-cleaner diagnostics.

hokein added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:169 -std::vector generateMissingIncludeDiagnostics( +using MissingIncludeEdits = llvm::MapVector; +MissingIncludeEdits generateMissingIncludeEdits( kadircet wrote: > what do w

[clang-tools-extra] b472176 - [clangd] Remove unused includes in IncludeCleaner.cpp, NFC

Author: Haojian Wu Date: 2023-06-16T15:15:07+02:00 New Revision: b472176829d44a68d94f26eaa743947e92fc9d1d URL: https://github.com/llvm/llvm-project/commit/b472176829d44a68d94f26eaa743947e92fc9d1d DIFF: https://github.com/llvm/llvm-project/commit/b472176829d44a68d94f26eaa743947e92fc9d1d.diff LO

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:703 +Arg *A = Args.getLastArgNoClaim(options::OPT_fno_integrated_as); +D.Diag(diag::warn_drv_unsupported_lto_option_for_target) +<< A->getSpelling() << ToolChain.getTriple().g

[clang] 459f495 - [clang][Interp] Check inc/dec family of ops for initialization

Author: Timm Bäder Date: 2023-06-16T15:19:23+02:00 New Revision: 459f495f49a197a042890e1daa0a98cbae892d2b URL: https://github.com/llvm/llvm-project/commit/459f495f49a197a042890e1daa0a98cbae892d2b DIFF: https://github.com/llvm/llvm-project/commit/459f495f49a197a042890e1daa0a98cbae892d2b.diff LO

[PATCH] D149846: [clang][Interp] Check inc/dec family of ops for initialization

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG459f495f49a1: [clang][Interp] Check inc/dec family of ops for initialization (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

chill added a comment. In D146242#4427966 , @tmatheson wrote: > In D146242#4427707 , @chill wrote: > >> I was just thinking to LGTM it :) >> >> IMHO, the alignment adjustment happens because of C.4 (B.3 indeed le

[PATCH] D153123: Fix diag for read-only target features

yaxunl added inline comments. Comment at: clang/test/OpenMP/driver-openmp-amdgpu.c:8 +// RUN: --offload-device-only -o - 2>&1 | FileCheck --check-prefix=CHECK %s +// CHECK-NOT: warning: feature flag {{.*}} is ignored since the feature is read only arsenm wrote

[PATCH] D152914: [Draft] Make __builtin_cpu builtins target-independent

nemanjai added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:903-907 +// Load of a value provided by the system library at a fixed address. Used for +// accessing things like HWCAP word provided by GLIBC. +def int_fixed_addr_ld +: DefaultAttrsIntrinsic<[llvm

[clang] 1e9ac71 - [clang][Interp] Handle PredefinedExprs

Author: Timm Bäder Date: 2023-06-16T15:52:12+02:00 New Revision: 1e9ac717877b5a9410db99a8f0d61fa9ca144b44 URL: https://github.com/llvm/llvm-project/commit/1e9ac717877b5a9410db99a8f0d61fa9ca144b44 DIFF: https://github.com/llvm/llvm-project/commit/1e9ac717877b5a9410db99a8f0d61fa9ca144b44.diff LO

[PATCH] D148689: [clang][Interp] Handle PredefinedExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e9ac717877b: [clang][Interp] Handle PredefinedExprs (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D148689?vs=519835&id

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

tmatheson accepted this revision. tmatheson added a comment. This revision now requires review to proceed. In D146242#4428051 , @chill wrote: > But there isn't any other power of two between 8 and 16. Ok, I see where I was going wrong, misreading C4 (it'

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

tmatheson added a comment. The description/commit message should reflect the final reasoning behind the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146242/new/ https://reviews.llvm.org/D146242 ___

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:715 + +void VisitObjCImplementationDecl(const ObjCImplementationDecl *OIMD) { + if (const auto *CI = OIMD->getClassInterface()) can you also add tests for these into `Fin

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

Manna updated this revision to Diff 532138. Manna added a comment. Address review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153033/new/ https://reviews.llvm.org/D153033 Files: clang/lib/AST/ASTContext.cpp clang/lib/AST/MicrosoftMangle.cpp clang/lib/Analysis/ThreadSaf

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:3368 - VD = VD->getCanonicalDecl(); + VD = cast(VD->getCanonicalDecl()); auto I = FunctionGlobalizedDecls.find(CGF.CurFn); aaron.ballm

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

ManuelJBrito added a comment. In D142388#4425246 , @aaron.ballman wrote: > In D142388#4415349 , @rsmith wrote: > >> I think `__builtin_any_value` works pretty well, and emphasizes that this >> can really return

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:703 +Arg *A = Args.getLastArgNoClaim(options::OPT_fno_integrated_as); +D.Diag(diag::warn_drv_unsupported_lto_option_for_target) +<< A->getSpelling() << ToolChain.getTriple().getT

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 updated this revision to Diff 532164. JOE1994 added a comment. - Fix nullptr bug (fixes Clang regression test :` Clang :: CodeGen/constructor-attribute.c` ) - Following feedback from @barannikov88 - Rebase onto latest main : a76376cdb034d817803cbdb2f3f451487807124d

[PATCH] D106409: [PowerPC] Truncate exponent parameter for vec_cts,vec_ctf

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106409/new/ https://reviews.llvm.org/D106409 __

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2552-2554 auto AddrAS = addr ? addr->getType()->getPointerAddressSpace() : 0; - auto AddrInt8PtrTy = - AddrAS ? CGF.Int8Ty->getPointerTo(AddrAS) : CGF.Int8PtrTy; + auto AddrPtrTy = +AddrA

[PATCH] D153146: [CLANG] Fix potential integer overflow value in getRVVTypeSize()

Manna created this revision. Manna added reviewers: erichkeane, aaron.ballman, tahonermann. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. In getRVVTypeSize(clang::​ASTContext &, clang::​BuiltinType const *) potential integer overflow occurs o

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added a comment. With the updated revision, I don't see new test failures from `ninja check-clang` & `ninja check-llvm` & `ninja check-clang-unit` & `ninja check-llvm-unit` . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/ https

[PATCH] D152856: [Driver] Allow warning for unclaimed TargetSpecific options

MaskRay updated this revision to Diff 532167. MaskRay added a comment. avoid `mutable` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152856/new/ https://reviews.llvm.org/D152856 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Dri

[clang] a79995c - [Driver] Allow warning for unclaimed TargetSpecific options

Author: Fangrui Song Date: 2023-06-16T08:32:25-07:00 New Revision: a79995ca6004082774a87f7a58ab6be5343364b7 URL: https://github.com/llvm/llvm-project/commit/a79995ca6004082774a87f7a58ab6be5343364b7 DIFF: https://github.com/llvm/llvm-project/commit/a79995ca6004082774a87f7a58ab6be5343364b7.diff

[PATCH] D152856: [Driver] Allow warning for unclaimed TargetSpecific options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa79995ca6004: [Driver] Allow warning for unclaimed TargetSpecific options (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D153017: [analyzer] Fix false negative when using a nullable parameter directly without binding to a variable

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM; I'll commit this on Monday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153017/new/ https://reviews.llvm.org/D153017 __

[PATCH] D153038: [Clang] Fixes a diagnostic typo.

This revision was automatically updated to reflect the committed changes. Closed by commit rG501405f1d5f0: [Clang] Fixes a diagnostic typo. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153038/new/ https://reviews.llvm.org/D1

[clang] 501405f - [Clang] Fixes a diagnostic typo.

Author: Mark de Wever Date: 2023-06-16T17:40:53+02:00 New Revision: 501405f1d5f027717ab6866aa1dece2d384791cc URL: https://github.com/llvm/llvm-project/commit/501405f1d5f027717ab6866aa1dece2d384791cc DIFF: https://github.com/llvm/llvm-project/commit/501405f1d5f027717ab6866aa1dece2d384791cc.diff

[PATCH] D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments

MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:515 +- Apply ``-fmacro-prefix-map`` to anonymous tags in template arguments + (`#63219 `_) I'll add a period to be consistent with other e

[PATCH] D152658: [InstCombine] Change SimplifyDemandedVectorElts to use PoisonElts instead of UndefElts

ManuelJBrito added inline comments. Comment at: llvm/lib/Target/X86/X86InstCombineIntrinsic.cpp:3102-3105 case Intrinsic::x86_sse4a_extrqi: case Intrinsic::x86_sse4a_insertq: case Intrinsic::x86_sse4a_insertqi: +PoisonElts.setHighBits(VWidth / 2); nl

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

chill added a comment. > Previously when a packed struct, containing vector data types such as > uint16x8_t, is passed as a function argument, the alignment of the > struct used by the function caller and the alignment used by the callee > to load the argument from stack does not match. I would s

[clang] 30ffb3e - [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments

Author: Dan McGregor Date: 2023-06-16T08:47:00-07:00 New Revision: 30ffb3e4fbce3132fbf63c62a8ecbb1edbec4fc9 URL: https://github.com/llvm/llvm-project/commit/30ffb3e4fbce3132fbf63c62a8ecbb1edbec4fc9 DIFF: https://github.com/llvm/llvm-project/commit/30ffb3e4fbce3132fbf63c62a8ecbb1edbec4fc9.diff

  1   2   >