[clang] 09d6ee7 - [Clang] Directly create opaque pointers

Author: Nikita Popov Date: 2023-06-15T09:09:33+02:00 New Revision: 09d6ee765780837d5156ac81f968465bdcec73ba URL: https://github.com/llvm/llvm-project/commit/09d6ee765780837d5156ac81f968465bdcec73ba DIFF: https://github.com/llvm/llvm-project/commit/09d6ee765780837d5156ac81f968465bdcec73ba.diff

[PATCH] D152505: [Clang] Directly create opaque pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09d6ee765780: [Clang] Directly create opaque pointers (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Re

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c6f2f629cc0: [OpenMP] Update the default version of OpenMP to 5.1 (authored by animeshk-amd). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D152995: Remove clang/ModuleInfo.txt

Hahnfeld created this revision. Hahnfeld added reviewers: rsmith, aaron.ballman. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The script `build-for-llvm-top.sh` and LLVM's `ModuleInfo.txt` are gone s

[PATCH] D152995: Remove clang/ModuleInfo.txt

Hahnfeld added a comment. Just checking to be sure there is no other use case that the file is used for, but I doubt it... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152995/new/ https://reviews.llvm.org/D152995

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabua

[clang] b92ccc3 - [CGCall] Directly create opaque pointers (NFCI)

Author: Nikita Popov Date: 2023-06-15T10:06:40+02:00 New Revision: b92ccc355acb8a329918ceb2837df1b351675ece URL: https://github.com/llvm/llvm-project/commit/b92ccc355acb8a329918ceb2837df1b351675ece DIFF: https://github.com/llvm/llvm-project/commit/b92ccc355acb8a329918ceb2837df1b351675ece.diff

[PATCH] D152645: [clangd] Handle DependentNameType in HeuristicResolver::resolveTypeToRecordDecl()

hokein added inline comments. Comment at: clang-tools-extra/clangd/HeuristicResolver.cpp:33 +const Type *HeuristicResolver::resolveDeclsToType( +const std::vector &Decls) const { the reason to promote this utility function to a class method seems to be able

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

nikic added a comment. Looks reasonable. Main note I have is that I think the use of getUnqual() over passing AddrSpace=0 would be preferred. Comment at: clang/lib/CodeGen/CGAtomic.cpp:91 auto Addr = CGF.Builder.CreatePointerBitCastOrAddrSpaceCast( -VoidPt

[PATCH] D153001: [clang][ThreadSafety] Add __builtin_instance_member (WIP)

tbaeder created this revision. tbaeder added reviewers: aaronpuchert, NoQ, aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As discussed in https://github.com/llvm/llvm-project/issues/20777

[PATCH] D152433: [ARM,AArch64] Add a full set of -mtp= options.

This revision was automatically updated to reflect the committed changes. Closed by commit rG10e42281144e: [ARM,AArch64] Add a full set of -mtp= options. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152433/new/ https://r

[clang] 10e4228 - [ARM,AArch64] Add a full set of -mtp= options.

Author: Simon Tatham Date: 2023-06-15T09:27:41+01:00 New Revision: 10e42281144ecca019764b554f3f0f709bba0f71 URL: https://github.com/llvm/llvm-project/commit/10e42281144ecca019764b554f3f0f709bba0f71 DIFF: https://github.com/llvm/llvm-project/commit/10e42281144ecca019764b554f3f0f709bba0f71.diff

[PATCH] D152275: Use memory region declaration intrinsic when generating code for array subscripts

simeon added a comment. > - The compile-time overhead of creating a bunch of extra intrinsics might be > significant. Maybe we can mitigate to some extent by avoiding emitting the > intrinsic in simple cases where it doesn't actually help (constant indexes?). Yes, that would make sense. > - U

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

Hahnfeld created this revision. Hahnfeld added reviewers: rtrieu, vsapsai, ChuanqiXu, Bigcheese. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For hashing, we should not differentiate between template

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

eopXD updated this revision to Diff 531654. eopXD added a comment. Bump CI due to rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/ https://reviews.llvm.org/D151397 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Sem

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

ChuanqiXu added a comment. This looks not so good. In this way, we can't disambiguate other template types. At least we added the kind and a TODO here. BTW, the attached test case is in fact in correct. See https://eel.is/c++draft/basic.def.odr#14.3, such mergeable declarations shouldn't be at

[clang] 1dee56a - [clang] NFC: Use `DirectoryEntryRef` in `FileManager::getCanonicalName()`

Author: Jan Svoboda Date: 2023-06-15T11:22:31+02:00 New Revision: 1dee56aed7357ad87e7b30316554b760c75d5779 URL: https://github.com/llvm/llvm-project/commit/1dee56aed7357ad87e7b30316554b760c75d5779 DIFF: https://github.com/llvm/llvm-project/commit/1dee56aed7357ad87e7b30316554b760c75d5779.diff L

[clang] 7bca6f4 - [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

Author: Jan Svoboda Date: 2023-06-15T11:22:31+02:00 New Revision: 7bca6f452f53a4a8d31a56b480e5b9fbaabad4fb URL: https://github.com/llvm/llvm-project/commit/7bca6f452f53a4a8d31a56b480e5b9fbaabad4fb DIFF: https://github.com/llvm/llvm-project/commit/7bca6f452f53a4a8d31a56b480e5b9fbaabad4fb.diff L

[PATCH] D151855: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7bca6f452f53: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2) (authored by jansvoboda11). Repository: rG LLVM Github Mo

[PATCH] D151922: [clang] NFC: Use `DirectoryEntryRef` in `FileManager::getCanonicalName()`

This revision was automatically updated to reflect the committed changes. Closed by commit rG1dee56aed735: [clang] NFC: Use `DirectoryEntryRef` in `FileManager::getCanonicalName()` (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D151922?vs=527582&id=531660#toc Rep

[PATCH] D152275: Use memory region declaration intrinsic when generating code for array subscripts

jeroen.dobbelaere added a comment. In D152275#4418363 , @efriedma wrote: > - Not sure how this interacts with full restrict and related proposals. the full restrict PropagateAndConvertNoAlias pass will need to learn about it, but that should be trivial.

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

Hahnfeld added a comment. In D153003#4423926 , @ChuanqiXu wrote: > This looks not so good. In this way, we can't disambiguate other template > types. At least we added the kind and a TODO here. Which template name types would we need to disambiguate? We

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

skan added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:1895 + if (RelocatedSection != Obj.section_end() && Name.contains(".dwo")) { +// Each section in COFF can directly contain relocations. +if (isa(&Obj) && Section.relocations().e

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

skan added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:1896 +// Each section in COFF can directly contain relocations. +if (isa(&Obj) && Section.relocations().empty()) + continue; Should we merge the check into

[clang] 462bda1 - [clang] Deprecate `DirectoryEntry::getName()`

Author: Jan Svoboda Date: 2023-06-15T12:14:41+02:00 New Revision: 462bda1d562acc5a907eafe0afeb79556101c65d URL: https://github.com/llvm/llvm-project/commit/462bda1d562acc5a907eafe0afeb79556101c65d DIFF: https://github.com/llvm/llvm-project/commit/462bda1d562acc5a907eafe0afeb79556101c65d.diff L

[PATCH] D151927: [clang] Deprecate `DirectoryEntry::getName()`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG462bda1d562a: [clang] Deprecate `DirectoryEntry::getName()` (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

eopXD updated this revision to Diff 531676. eopXD added a comment. Bump CI due to update of parent revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/ https://reviews.llvm.org/D151397 Files: clang/include/clang/Basic/riscv_vector

[PATCH] D153006: [clang][dataflow] Perform deep copies in copy and move operations.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This serves two purposes: - Because, today, we

[PATCH] D152879: [1/2][RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

eopXD updated this revision to Diff 531681. eopXD edited the summary of this revision. eopXD added a comment. Edit codegen test case for llvm/test/CodeGen/RISCV/rvv/{vnclip.ll/vnclipu.ll} correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152

[clang] fa5788f - [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

Author: Jan Svoboda Date: 2023-06-15T12:34:54+02:00 New Revision: fa5788ff8dc10f36e0947757e335cd180a1a63c9 URL: https://github.com/llvm/llvm-project/commit/fa5788ff8dc10f36e0947757e335cd180a1a63c9 DIFF: https://github.com/llvm/llvm-project/commit/fa5788ff8dc10f36e0947757e335cd180a1a63c9.diff L

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa5788ff8dc1: [clang][index] NFCI: Make `CXFile` a `FileEntryRef` (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosH

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

ChuanqiXu added a comment. In D153003#4424004 , @Hahnfeld wrote: > In D153003#4423926 , @ChuanqiXu > wrote: > >> This looks not so good. In this way, we can't disambiguate other template >> types. At least we ad

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

eopXD updated this revision to Diff 531686. eopXD added a comment. Remove `let hasSideEffects = 0;` under VPseudoBinaryNoMaskRoundingMode, VPseudoBinaryNoMaskTURoundingMode, and VPseudoBinaryMaskPolicyRoundingMode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

eopXD updated this revision to Diff 531687. eopXD added a comment. Recover, the previous update should happen under D151396 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/ https://reviews.llvm.org/D151

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. Is the comment here relevant? https://discourse.llvm.org/t/interleaving-several-c-style-comments-in-the-same-inline-assembly-line/71353/8 Does this patch do that already? Also is it a problem that the ignored comments

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

eopXD updated this revision to Diff 531689. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/ https://reviews.llvm.org/D151397 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Sema/SemaChecking

[clang] 28f3edd - AMDGPU: Add llvm.amdgcn.exp2 intrinsic

Author: Matt Arsenault Date: 2023-06-15T07:00:07-04:00 New Revision: 28f3edd2be2a27b9dc7739d137147007c5fd9e41 URL: https://github.com/llvm/llvm-project/commit/28f3edd2be2a27b9dc7739d137147007c5fd9e41 DIFF: https://github.com/llvm/llvm-project/commit/28f3edd2be2a27b9dc7739d137147007c5fd9e41.diff

[PATCH] D152901: AMDGPU: Add llvm.amdgcn.exp2 intrinsic

arsenm closed this revision. arsenm added a comment. 28f3edd2be2a27b9dc7739d137147007c5fd9e41 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152901/new/ https://reviews.llvm.org/D152901 __

[PATCH] D152879: [1/2][RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

eopXD updated this revision to Diff 531690. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152879/new/ https://reviews.llvm.org/D152879 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/r

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu added a comment. For the customer who reported the problem, the comments are in the input source (doing their job explaining what the operands are). Now, if that comment is not seen when compiling with "-S" it is less of a problem that having the compilation not succeeding. I did

[PATCH] D152889: [2/2][RISCV] Model vxrm control for vsadd, vsaddu, vssub, and vssubu

eopXD updated this revision to Diff 531691. eopXD edited the summary of this revision. eopXD added a comment. Herald added subscribers: qcolombet, MatzeB. Changes: - Change value to omit vxrm write from 4 to 99 - Resolve test case failure - Be consistent on template naming Repository: rG LLVM

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

mboehme updated this revision to Diff 531694. mboehme added a comment. Always return the same `Value` for the same integer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152813/new/ https://reviews.llvm.org/D152813 Files: clang/include/clang/Ana

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

mboehme added a comment. PTAL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152813/new/ https://reviews.llvm.org/D152813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D148827: -fsanitize=function: support C

uabelho added a comment. Hi, A question: it seems like this messes with alignment on functions? So with input program al.c: __attribute__((aligned(64))) void alignedfn(void) { __asm("nop"); } void alignedfn2(void) { __asm("nop"); } int main(void){} if we compile with -fsanit

[clang] 976d8b4 - [clang][Interp] Virtual function calls

Author: Timm Bäder Date: 2023-06-15T13:33:43+02:00 New Revision: 976d8b40cccf4678fe8c414210ce82170049b715 URL: https://github.com/llvm/llvm-project/commit/976d8b40cccf4678fe8c414210ce82170049b715 DIFF: https://github.com/llvm/llvm-project/commit/976d8b40cccf4678fe8c414210ce82170049b715.diff LO

[PATCH] D142630: [clang][Interp] Implement virtual function calls

This revision was automatically updated to reflect the committed changes. Closed by commit rG976d8b40cccf: [clang][Interp] Virtual function calls (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D142630?vs=527336&id=531697#toc Repository: rG LLVM Github Monorepo CHAN

[PATCH] D152548: [Clang][Interp] Diagnose uninitialized ctor of global record arrays

tbaeder added inline comments. Comment at: clang/test/AST/Interp/cxx20.cpp:177 + // ref-note {{subobject 'f' is not initialized}} + We usually have a space after the `;` and keep the comments aligned on the `//`. Repository: rG LLVM Gith

[clang] 0f6110a - No longer diagnose (functionally) empty structures under -Wuninitialized

Author: Aaron Ballman Date: 2023-06-15T07:43:31-04:00 New Revision: 0f6110a4a4250f3d684e166b2d3279fbe4a1f239 URL: https://github.com/llvm/llvm-project/commit/0f6110a4a4250f3d684e166b2d3279fbe4a1f239 DIFF: https://github.com/llvm/llvm-project/commit/0f6110a4a4250f3d684e166b2d3279fbe4a1f239.diff

[PATCH] D153013: [clang-tidy] Correct the include-cleaner-check diagnostic message for missing-includes.

hokein created this revision. hokein added a reviewer: VitaNuo. Herald added subscribers: PiotrZSL, kadircet, carlosgalvezp, arphaman, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. We

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 531701. eopXD edited the summary of this revision. eopXD added a comment. Resolve test case failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/inc

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

ymandel updated this revision to Diff 531702. ymandel added a comment. Expand comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152263/new/ https://reviews.llvm.org/D152263 Files: clang/include/clang/Analysis/Analyses/IntervalPartition.h

[clang] e96bec9 - [OpenMP] Correctly diagnose conflicting target identifierers for AMDGPU

Author: Joseph Huber Date: 2023-06-15T07:06:44-05:00 New Revision: e96bec9cd8e14ee2174490c0ce09cedfcd6be79e URL: https://github.com/llvm/llvm-project/commit/e96bec9cd8e14ee2174490c0ce09cedfcd6be79e DIFF: https://github.com/llvm/llvm-project/commit/e96bec9cd8e14ee2174490c0ce09cedfcd6be79e.diff

[PATCH] D152965: [OpenMP] Correctly diagnose conflicting target identifierers for AMDGPU

This revision was automatically updated to reflect the committed changes. Closed by commit rGe96bec9cd8e1: [OpenMP] Correctly diagnose conflicting target identifierers for AMDGPU (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D152995: Remove clang/ModuleInfo.txt

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152995/new/ https://reviews.llvm.org/D152995 _

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd04452d54829: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported… (authored by dzhidzhoev). Changed prior to commit: https:/

[clang] d04452d - [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

Author: Vladislav Dzhidzhoev Date: 2023-06-15T14:29:03+02:00 New Revision: d04452d54829cd7af5b43d670325ffa755ab0030 URL: https://github.com/llvm/llvm-project/commit/d04452d54829cd7af5b43d670325ffa755ab0030 DIFF: https://github.com/llvm/llvm-project/commit/d04452d54829cd7af5b43d670325ffa755ab003

[clang] a7e7d34 - Revert "[DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)"

Author: Vladislav Dzhidzhoev Date: 2023-06-15T14:35:54+02:00 New Revision: a7e7d34dc1ce35afdcd813348a7254ddfe13698a URL: https://github.com/llvm/llvm-project/commit/a7e7d34dc1ce35afdcd813348a7254ddfe13698a DIFF: https://github.com/llvm/llvm-project/commit/a7e7d34dc1ce35afdcd813348a7254ddfe13698

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

rogfer01 added a comment. Hi @abel-bernabeu, I did a quick experiment replacing all the calls to `getLexer().Lex()` with `getParser().Lex()` and now your testcase is accepted and looks like this in the output f2: addisp, sp, -32 sd ra, 24(sp) sd s0, 16(sp

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D152977: [NFC] Fix potential dereferencing of null return value.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with the think-o fixed. Comment at: clang/lib/Frontend/FrontendActions.cpp:461 +assert(NamedCtx, "NamedCtx cannot be null"); + This

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 531717. skatrak added a comment. Rebasde to fix build error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/Lower/OpenMP.h flang/lib/L

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Arena.h:89 + /// `Value`. These literals are the same every time. + IntegerValue &makeIntLiteral(llvm::APInt Value); + Should we be takin

[PATCH] D152977: [NFC] Fix potential dereferencing of null return value.

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:294-295 // UntouchedAndPossiblyDestroyed or UnlockedAndPossiblyDestroyed. - assert(lstate->isUntouchedAndPossiblyDestroyed() || - lstate->isUnlockedAndPossiblyDestroye

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo updated this revision to Diff 531718. VitaNuo added a comment. Simplify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153015/new/ https://reviews.llvm.org/D153015 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/unit

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman added a comment. In D150226#4422856 , @dblaikie wrote: > In D150226#4417539 , @aaron.ballman > wrote: > >> In D150226#4408980 , @dblaikie >> wrote: >> >>>

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

tmatheson added a reviewer: stuij. tmatheson added inline comments. Comment at: clang/test/CodeGen/aarch64-ABI-align-packed.cpp:6 +// These tests check the ABI alignment of packed structs and packed fields +// are consistent with the AAPCS64 document. +extern "C" { --

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

tmatheson added inline comments. Comment at: clang/test/CodeGen/aarch64-ABI-align-packed.cpp:6 +// These tests check the ABI alignment of packed structs and packed fields +// are consistent with the AAPCS64 document. +extern "C" { tmatheson wrote: > The filename

[PATCH] D153013: [clang-tidy] Correct the include-cleaner-check diagnostic message for missing-includes.

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:49 SourceLocation SymRefLocation; + include_cleaner::Symbol Sym; include_cleaner::Heade

[PATCH] D152889: [2/2][RISCV] Model vxrm control for vsadd, vsaddu, vssub, and vssubu

eopXD updated this revision to Diff 531721. eopXD added a comment. Fixed incorrect pattern that caused test case failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152889/new/ https://reviews.llvm.org/D152889 Files: clang/include/clang/Basic

[PATCH] D152542: [clangd] Use include_cleaner spelling strategies in clangd.

VitaNuo added a comment. Duplicate of https://reviews.llvm.org/D152913. Landed the other one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152542/new/ https://reviews.llvm.org/D152542 ___ cfe-commits ma

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 531722. eopXD added a comment. Update code based on edit of parent revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/include/clang/Basic/riscv_ve

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

RKSimon added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:15 #include "llvm/ADT/StringSwitch.h" +#include "llvm/ADT/StringExtras.h" #include (clang-format) - include order Comment at: llvm/lib/TargetParser/X86Targe

[PATCH] D153013: [clang-tidy] Correct the include-cleaner-check diagnostic message for missing-includes.

hokein updated this revision to Diff 531725. hokein marked an inline comment as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153013/new/ https://reviews.llvm.org/D153013 Files: clang-tools-extra/cl

[clang-tools-extra] eed4a4d - [clang-tidy] Correct the include-cleaner-check diagnostic message for missing-includes.

Author: Haojian Wu Date: 2023-06-15T15:26:48+02:00 New Revision: eed4a4d02e4f33cc2f2a9980466d1c7a1cf37398 URL: https://github.com/llvm/llvm-project/commit/eed4a4d02e4f33cc2f2a9980466d1c7a1cf37398 DIFF: https://github.com/llvm/llvm-project/commit/eed4a4d02e4f33cc2f2a9980466d1c7a1cf37398.diff LO

[PATCH] D153013: [clang-tidy] Correct the include-cleaner-check diagnostic message for missing-includes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeed4a4d02e4f: [clang-tidy] Correct the include-cleaner-check diagnostic message for missing… (authored by hokein). Repository: rG LLVM Github Mono

[PATCH] D153017: [StaticAnalyzer] Fix false negative when using a nullable parameter directly without binding to a variable

tripleCC created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, szepet, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. tripleCC requested review of this revision. Herald added a project: cl

[PATCH] D153018: [include-cleaner] Reorder SymbolReference fields to avoid padding space, NFC

hokein created this revision. hokein added a reviewer: VitaNuo. Herald added subscribers: kadircet, arphaman. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. This will bring down the size from 40 bytes to 32 bytes. Repository: r

[PATCH] D152986: [clang] Allow 'nomerge' attribute for function pointers

eddyz87 created this revision. Herald added a reviewer: aaron.ballman. Herald added subscribers: jeroen.dobbelaere, jdoerfert. Herald added a project: All. eddyz87 published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allow specifying 'nomerge'

[PATCH] D152986: [clang] Allow 'nomerge' attribute for function pointers

eddyz87 added reviewers: rnk, yonghong-song. eddyz87 added a subscriber: rnk. eddyz87 added a comment. Hi @aaron.ballman, @rnk, I see that you were involved in the discussion when `nomerge` attribute was added in D79121 . Could you please take a look at this prop

[PATCH] D152986: [clang] Allow 'nomerge' attribute for function pointers

eddyz87 added subscribers: dfaust, jemarch. eddyz87 added a comment. Hi @jemarch, @dfaust, You might be interested in this discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152986/new/ https://reviews.llvm.org/D152986

[PATCH] D146777: [clang] Preliminary fat-lto-object support

tejohnson added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1065 + if (CodeGenOpts.FatLTO) { +// Set EnableSplitLTOUnit, since the config above won't +if (!TheModule->getModuleFlag("EnableSplitLTOUnit")) Can you expand the comment a bi

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

hokein added a comment. thanks. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:3726 +TEST(Hover, FunctionParameterDefaulValueNotEvaluated) { + Annotations T("void foo(int p^aram = 5);"); + TestTU TU = TestTU::withCode(T.code()); I believe this

[PATCH] D153006: [clang][dataflow] Perform deep copies in copy and move operations.

mboehme updated this revision to Diff 531734. mboehme added a comment. Avoid including llvm/Testing/Support/Error.h in clang/unittests/Analysis/FlowSensitive/TestingSupport.h. This can lead to version conflicts in projects that want to include TestingSupport.h but use a different version of gtes

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu updated this revision to Diff 531735. abel-bernabeu added a comment. [RISCV] Allow slash-star comments in instruction operands It has been reported by one of Esperanto's customers that slash-start comments ("/*") within inline assembly were only allowed before the first in

[clang] b1aba4a - [clang][Diagnostics] Don't expand label fixit to the next line

Author: Timm Bäder Date: 2023-06-15T15:58:23+02:00 New Revision: b1aba4a1009937aca920539f7737b1973f908dbd URL: https://github.com/llvm/llvm-project/commit/b1aba4a1009937aca920539f7737b1973f908dbd DIFF: https://github.com/llvm/llvm-project/commit/b1aba4a1009937aca920539f7737b1973f908dbd.diff LO

[PATCH] D152525: [clang][Diagnostics] Don't expand label fixit to the next line

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1aba4a10099: [clang][Diagnostics] Don't expand label fixit to the next line (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D152525?vs=529922&id=531737#toc Repository: rG LL

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu updated this revision to Diff 531740. abel-bernabeu added a comment. [RISCV] Allow slash-star comments in instruction operands It has been reported by one of Esperanto's customers that slash-start comments ("/*") within inline assembly were only allowed before the first instruction

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu added a comment. I was a bit reluctant to start a discussion on migrating getLexer().Lex() to getParser().Lex(), but I guess it makes sense to do it now rather than deferring. It is cleaner now, I agree. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu updated this revision to Diff 531741. abel-bernabeu added a comment. [RISCV] Allow slash-star comments in instruction operands It has been reported by one of Esperanto's customers that slash-start comments ("/*") within inline assembly were only allowed before the first in

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

FreddyYe added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:314 + // Empty processor. Include X87 and CMPXCHG8 for backwards compatibility. + { {""}, CK_None, ~0U, FeatureX87 | FeatureCMPXCHG8B, '\0', false }, + { {"generic"}, CK_None, ~0U, FeaturesPen

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu updated this revision to Diff 531746. abel-bernabeu added a comment. [RISCV] Allow slash-star comments in instruction operands It has been reported by one of Esperanto's customers that slash-start comments ("/*") within inline assembly were only allowed before the first instruction

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)); + else if (!UseIntegratedAs) { shchenz wrote: > See

[clang] ed578f0 - [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

Author: Vladislav Dzhidzhoev Date: 2023-06-15T16:15:39+02:00 New Revision: ed578f02cf44a52adde16647150e7421f3ef70f3 URL: https://github.com/llvm/llvm-project/commit/ed578f02cf44a52adde16647150e7421f3ef70f3 DIFF: https://github.com/llvm/llvm-project/commit/ed578f02cf44a52adde16647150e7421f3ef70f

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

DavidSpickett added inline comments. Comment at: clang/test/CodeGen/RISCV/riscv-inline-asm-gcc-commenting.c:23 +// CHECK: f1: +// CHECK: lui a0, 1 +// CHECK-NEXT: addiw a0, a0, 564 Check for the comment content here too? `# this is fine # this

[PATCH] D153017: [StaticAnalyzer] Fix false negative when using a nullable parameter directly without binding to a variable

steakhal added a comment. I believe, `zaks.anna` and `vsavchenko` are no longer involved in the project. I think it makes sense to have the code owners NoQ and xazax.hun as reviewers, and I also tend to review quite a lot nowadays. And we usually use the `[analyzer]` tag instead of `[StaticAnalyz

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)); + else if (!UseIntegratedAs) { qiongsiwu1 wrote: > shc

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

barannikov88 added a comment. Herald added a subscriber: wangpc. Does the test have to be a C source? Why not just plain asm (fed into llvm-mc)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153008/new/ https://reviews.llvm.org/D153008 ___

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)); + else if (!UseIntegratedAs) { shchenz wrote: > qio

[PATCH] D152882: [LinkerWrapper] Support device binaries in multiple link jobs

jhuber6 updated this revision to Diff 531756. jhuber6 added a comment. Hopefully fixing test on Windows. I think it's fine to let the packager bundle mutliple of these now since it's caught in `clang`. So if the user really wants to force it we should allow them to since the bundler format is just

  1   2   3   >