[PATCH] D151785: [clangd] Desugar template parameter aliases in type hints

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Comment at: clang-tools-extra/clangd/InlayHints.cpp:196 +// Determines if any intermediate type in desugaring QualType QT is of +// substituted template paramet

[PATCH] D152696: Prevent deadlocks in death tests.

mboehme updated this revision to Diff 530789. mboehme added a comment. Set the `death_test_style` flag globally in TestMain.cpp instead of each individual test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152696/new/ https://reviews.llvm.org/D152

[PATCH] D152696: Prevent deadlocks in death tests.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152696/new/ https://reviews.llvm.org/D152696 ___ cfe

[PATCH] D152520: [clangd] Unify printing policy for type hints

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152520/new/ https://reviews.llvm.org/D152520 ___

[PATCH] D152074: [6/11][Clang][RISCV] Expand all variants for strided segment load

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152074/new/ https://reviews.llvm.org/D152074 ___

[PATCH] D152075: [7/11][Clang][RISCV] Expand all variants for strided segment store

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152075/new/ https://reviews.llvm.org/D152075 ___

[PATCH] D152076: [8/11][Clang][RISCV] Expand all variants for indexed strided segment load

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152076/new/ https://reviews.llvm.org/D152076 ___

[clang] ee72e2b - [Sema] Remove unused isNonTypeNestedNameSpecifier

Author: Kazu Hirata Date: 2023-06-13T00:24:40-07:00 New Revision: ee72e2b3939a82a29345c7e53929a3a769a78735 URL: https://github.com/llvm/llvm-project/commit/ee72e2b3939a82a29345c7e53929a3a769a78735 DIFF: https://github.com/llvm/llvm-project/commit/ee72e2b3939a82a29345c7e53929a3a769a78735.diff L

[clang] c493394 - [clang] Use DenseMapBase::lookup (NFC)

Author: Kazu Hirata Date: 2023-06-13T00:24:43-07:00 New Revision: c4933940f76bb775c33b70f4543d30c2e595ef1f URL: https://github.com/llvm/llvm-project/commit/c4933940f76bb775c33b70f4543d30c2e595ef1f DIFF: https://github.com/llvm/llvm-project/commit/c4933940f76bb775c33b70f4543d30c2e595ef1f.diff L

[clang] 6639717 - [Driver] Remove unused declaration addTranslatorArgs

Author: Kazu Hirata Date: 2023-06-13T00:24:46-07:00 New Revision: 6639717de8365e50983b057cdc3396d77d1374c1 URL: https://github.com/llvm/llvm-project/commit/6639717de8365e50983b057cdc3396d77d1374c1 DIFF: https://github.com/llvm/llvm-project/commit/6639717de8365e50983b057cdc3396d77d1374c1.diff L

[PATCH] D152634: [Sema] Remove unused isNonTypeNestedNameSpecifier

This revision was automatically updated to reflect the committed changes. Closed by commit rGee72e2b3939a: [Sema] Remove unused isNonTypeNestedNameSpecifier (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152634/new/ https://review

[clang] 249bd21 - [StaticAnalyzer] Remove several unused declarations

Author: Kazu Hirata Date: 2023-06-13T00:24:44-07:00 New Revision: 249bd21c937144686b75a38565b49c6ea51a20bf URL: https://github.com/llvm/llvm-project/commit/249bd21c937144686b75a38565b49c6ea51a20bf DIFF: https://github.com/llvm/llvm-project/commit/249bd21c937144686b75a38565b49c6ea51a20bf.diff L

[clang] 9567cfd - [StaticAnalyzer] Remove unused function hasGlobalsOrParametersStorage

Author: Kazu Hirata Date: 2023-06-13T00:24:47-07:00 New Revision: 9567cfd03432e3ac27201af6f5b479dda28cbf0c URL: https://github.com/llvm/llvm-project/commit/9567cfd03432e3ac27201af6f5b479dda28cbf0c DIFF: https://github.com/llvm/llvm-project/commit/9567cfd03432e3ac27201af6f5b479dda28cbf0c.diff L

[clang] a89895a - [Sema] Remove unused member variable MSVCGuidDecl

Author: Kazu Hirata Date: 2023-06-13T00:24:49-07:00 New Revision: a89895ab5742819394e9af7f485e9188f8b24aa4 URL: https://github.com/llvm/llvm-project/commit/a89895ab5742819394e9af7f485e9188f8b24aa4 DIFF: https://github.com/llvm/llvm-project/commit/a89895ab5742819394e9af7f485e9188f8b24aa4.diff L

[PATCH] D152077: [9/11][Clang][RISCV] Expand all variants for indexed strided segment store

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152077/new/ https://reviews.llvm.org/D152077 ___

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n marked 8 inline comments as done. goldstein.w.n added inline comments. Comment at: llvm/include/llvm/Transforms/Utils/InferCallsiteAttrs.h:28 + // relatively high value is okay. + static constexpr unsigned kMaxChecks = UINT_MAX; + arsenm wrote: >

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n updated this revision to Diff 530798. goldstein.w.n added a comment. fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152226/new/ https://reviews.llvm.org/D152226 Files: clang/test/CodeGen/LoongArch/inline-asm-constraints.c cl

[PATCH] D152764: [clang-tidy] Reserved-identifier: Improved AllowedIdentifiers option to support regular expressions

PiotrZSL added a comment. Except pointed out issues, looks fine. Comment at: clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.cpp:49-50 + for (const auto &Identifier : AllowedIdentifiers) { +if (!llvm::Regex(Identifier).isValid()) + configurationDiag("In

[PATCH] D147717: [C++20] Claim full support for consteval again

Fznamznon added a comment. The CI failure is unrelated and I suppose should be already fixed by aa28875 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147717/new/ https://review

[PATCH] D152782: [CodeGen] Remove unused declaration/function GetOrCreateRTTIProxyGlobalVariable

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The last use removed by: commit 46f366494f3ca8cc98daa6fb4f29c7c446c176b6 Author: Fangrui Song Date: Sat May 20 08:24:20

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

owenpan added a comment. In D151761#4410998 , @HazardyKnusperkeks wrote: > In D151761#4410158 , @galenelias > wrote: > >> Yah, I think leaving it open would be my preference at this point. Not sure >> how to p

[clang] bba6ea8 - [C++20] Claim full support for consteval again

Author: Mariya Podchishchaeva Date: 2023-06-13T03:50:24-04:00 New Revision: bba6ea8c2d56faad49936b95a57c7499095b920b URL: https://github.com/llvm/llvm-project/commit/bba6ea8c2d56faad49936b95a57c7499095b920b DIFF: https://github.com/llvm/llvm-project/commit/bba6ea8c2d56faad49936b95a57c7499095b92

[PATCH] D147717: [C++20] Claim full support for consteval again

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbba6ea8c2d56: [C++20] Claim full support for consteval again (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

nikic added inline comments. Comment at: llvm/lib/Transforms/Utils/InferCallsiteAttrs.cpp:597 + // callsite violating the constraint. + if (checkCallerDoesNotAccessMemory() && !CB->doesNotAccessMemory()) { +// Wait until we know we actually need it to do potentially expensi

[PATCH] D152078: [10/11][Clang][RISCV] Expand all variants for vget on tuple types

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152078/new/ https://reviews.llvm.org/D152078 ___

[PATCH] D152079: [11/11][Clang][RISCV] Expand all variants for vset on tuple types

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152079/new/ https://reviews.llvm.org/D152079 ___

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. HaohaiWen requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jplehr, sstefan1, MaskRay, aheejin. Herald added a reviewer: jdoerfert. Herald added projects: clang

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 530819. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h flang/include/flang/Optimizer/HLFIR/HLFIROps.h llvm/includ

[PATCH] D152788: [Clang] Show type in enum out of range diagnostic

dim created this revision. dim added reviewers: aaron.ballman, erichkeane, shafik, thakis. Herald added a project: All. dim requested review of this revision. Herald added a project: clang. When the diagnostic for an out of range enum value is printed, it currently does not show the actual enum ty

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 530825. HaohaiWen added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver

[PATCH] D152707: [clang][Sema] Provide source range to several Wunused warnings

hazohelet added a comment. In D152707#4413899 , @tbaeder wrote: > Precommit-CI also found some problems on Windows It's a littile surprising to me that clang outputs different diagnostics on windows. I suspect it might be related to the clang driver, so

[PATCH] D152628: [RISCV] Add __builtin_riscv_zip/unzip for Zbkb to match gcc.

asb added a comment. I'm not super familiar with these builtins so this might be a silly question why are the new builtins added in this patch LiLi (long int) rather than ZiZi (int32_t) like the old `_32` suffixed builtins? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D152433: [ARM,AArch64] Add a full set of -mtp= options.

simon_tatham updated this revision to Diff 530830. simon_tatham added a comment. Rebased past rG34d7acd444b8 (which conflicted with it, though trivially) and attempted to fix the clang-format complaint in pre-merge checks.

[PATCH] D152627: [RISCV] Change the immediate argument to Zk* intrinsics/builtins from i8 to i32.

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM. llvm/test/Bitcode is the other place the autoupgrade tests could go, but it looks like it's not used any more frequently for such tests than llvm/test/CodeGen/$tgt/. Repository: rG LLVM Gi

[PATCH] D152792: [Tooling/Inclusion] Add missing PRI family macros.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D152792 Files: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSym

[PATCH] D152707: [clang][Sema] Provide source range to several Wunused warnings

hazohelet updated this revision to Diff 530834. hazohelet added a comment. - Change `%clang` to `%clang_cc1 -fcxx-exceptions` in the test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152707/new/ https://reviews.llvm.org/D152707 Files: clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaDec

[PATCH] D152793: [RISCV] Add MC layer support for Zicfisslp.

fakepaper56 created this revision. Herald added subscribers: jobnoorman, luke, vporpo, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng,

[PATCH] D152793: [RISCV] Add MC layer support for Zicfisslp.

fakepaper56 added a comment. The patch might be too early to be posted. My idea is to make people easier to develop shadow-stack/landing-pads. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793

[PATCH] D152708: [RFC][Draft] Enable primitive support for Two-Level Line Tables in LLVM

StephenTozer added a comment. In D152708#4414402 , @dblaikie wrote: > It is unfortunate to hear that TLLT are a significant size increase, though > not entirely surprising - it's a bunch of extra info to encode. I'll be glad > to have this example to ex

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

qiucf updated this revision to Diff 530843. qiucf marked an inline comment as done. qiucf edited the summary of this revision. qiucf removed a reviewer: jsji. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116016/new/ https://reviews.llvm.org/D116016

[PATCH] D152796: [clang][Sema] Fix diagnostic message for unused constant varialbe templates

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, tbaeder, shafik. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. BEFORE this patch, unused const-qualified variable templates such as `template const double var_t =

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij added a comment. In D149444#4415306 , @MaskRay wrote: > Normally we implement the feature in llvm/ first, and the `clang/lib/Driver` > change should be the last patch. Yes good point. I won't commit it yet. For this feature we're using Phab as a

[PATCH] D151785: [clangd] Desugar template parameter aliases in type hints

zyounan updated this revision to Diff 530850. zyounan marked an inline comment as done. zyounan added a comment. Final update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151785/new/ https://reviews.llvm.org/D151785 Files: clang-tools-extra/cla

[PATCH] D151785: [clangd] Desugar template parameter aliases in type hints

zyounan updated this revision to Diff 530851. zyounan added a comment. Oops. Remove extra debugging statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151785/new/ https://reviews.llvm.org/D151785 Files: clang-tools-extra/clangd/InlayHints.c

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

AMS21 added a comment. Patch is now open for 2+ weeks. If there are no more reviews, I would kindly ask for someone to push this on my behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148697/new/ https://reviews.llvm.org/D148697

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 530855. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h flang/include/flang/Optimizer/HLFIR/HLFIROps.h llvm/includ

[clang] 5160f6f - Revert "[Driver] Mark m_x86_Features_Group options as TargetSpecific"

Author: Hans Wennborg Date: 2023-06-13T12:50:51+02:00 New Revision: 5160f6fefb0021a0b23e99c7cf621a330241c211 URL: https://github.com/llvm/llvm-project/commit/5160f6fefb0021a0b23e99c7cf621a330241c211 DIFF: https://github.com/llvm/llvm-project/commit/5160f6fefb0021a0b23e99c7cf621a330241c211.diff

[PATCH] D152435: [analyzer][CStringChecker] Adjust the invalidation operation on the super region of the destination buffer during string copy

steakhal added a comment. Thanks for the elaborated answer on the GH issue. Now it makes sense. And the fix is align with the observations, which is good. I only have concerns about the code quality of the modifier code. It was already in pretty bad shape, and I cannot say we improve it with thi

[clang-tools-extra] 7d68f2e - [clangd] Desugar template parameter aliases in type hints

Author: Younan Zhang Date: 2023-06-13T19:15:24+08:00 New Revision: 7d68f2ef411ea2188666c2f67a8ee8b923adb12d URL: https://github.com/llvm/llvm-project/commit/7d68f2ef411ea2188666c2f67a8ee8b923adb12d DIFF: https://github.com/llvm/llvm-project/commit/7d68f2ef411ea2188666c2f67a8ee8b923adb12d.diff

[PATCH] D151785: [clangd] Desugar template parameter aliases in type hints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d68f2ef411e: [clangd] Desugar template parameter aliases in type hints (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D152689: [NFC] Remove dead conditionals

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152689/new/ https://reviews.llvm.org/D152689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] c91ee29 - [Tooling/Inclusion] Add missing PRI family macros.

Author: Haojian Wu Date: 2023-06-13T13:33:53+02:00 New Revision: c91ee293f93b2547b75361b03fb6c85e0c19ed95 URL: https://github.com/llvm/llvm-project/commit/c91ee293f93b2547b75361b03fb6c85e0c19ed95 DIFF: https://github.com/llvm/llvm-project/commit/c91ee293f93b2547b75361b03fb6c85e0c19ed95.diff LO

[PATCH] D152792: [Tooling/Inclusion] Add missing PRI family macros.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc91ee293f93b: [Tooling/Inclusion] Add missing PRI family macros. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. > Looks like this is causing a crash on current main: > https://github.com/llvm/llvm-project/issues/62838 That was fixed in D151326 . I think we should be okay to re-enable this now. The first assertion was a bit of an edge case; I had

[PATCH] D152801: [include-cleaner] Don't apply PreferredHeader hings for standard headers.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. Fixes https://github.com/llvm/llvm-project/issues/62635 Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[clang] de6da6a - Reapply D146987 "[Assignment Tracking] Enable by default"

Author: OCHyams Date: 2023-06-13T12:43:46+01:00 New Revision: de6da6ad55d3ca945195d1cb109cb8efdf40a52a URL: https://github.com/llvm/llvm-project/commit/de6da6ad55d3ca945195d1cb109cb8efdf40a52a DIFF: https://github.com/llvm/llvm-project/commit/de6da6ad55d3ca945195d1cb109cb8efdf40a52a.diff LOG:

[PATCH] D152707: [clang][Sema] Provide source range to several Wunused warnings

aaron.ballman added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1350 continue; // Deleted functions are supposed to be unused. +SourceRange DiagRange = SourceRange(DiagD->getLocation()); +if (const ASTTemplateArgumentListInfo *ASTTAL =

[PATCH] D152788: [Clang] Show type in enum out of range diagnostic

aaron.ballman added a comment. Thank you for this, I like the changes! Can you add a test showing template instantiation (the case that you were struggling to identify the enumeration from) and a release note? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis updated this revision to Diff 530865. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/target_dat

[PATCH] D152707: [clang][Sema] Provide source range to several Wunused warnings

hazohelet added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1350 continue; // Deleted functions are supposed to be unused. +SourceRange DiagRange = SourceRange(DiagD->getLocation()); +if (const ASTTemplateArgumentListInfo *ASTTAL =

[PATCH] D142630: [clang][Interp] Implement virtual function calls

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/AST/Interp/records.cpp:650 +}; +#endif tbaeder wrote: > aaron.ballman wrote: > > We should also have test cases for

[PATCH] D152802: [clang-tidy] Fix crash in `modernize-use-default-member-init`

AMS21 created this revision. AMS21 added reviewers: PiotrZSL, njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. AMS21 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This was causes by `

[PATCH] D152520: [clangd] Unify printing policy for type hints

zyounan updated this revision to Diff 530867. zyounan added a comment. Rebase onto D151785 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152520/new/ https://reviews.llvm.org/D152520 Files: clang-tools-extra/cl

[PATCH] D152707: [clang][Sema] Provide source range to several Wunused warnings

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LG aside from the few suggested changes and moving the header to the Inputs directory. Comment at: clang/lib/Sema/Sema.cpp:1350 continue; // Deleted

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152752/new/ https://reviews.llvm.org/D152752 ___ c

[PATCH] D152433: [ARM,AArch64] Add a full set of -mtp= options.

simon_tatham added a comment. Right, this seems to be passing tests now, so I think @nickdesaulniers's issue is fixed, and I've also split up the tests as @MaskRay suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152433/new/ https://review

[PATCH] D152473: [clang-format] Add test case for issue 63170

MyDeveloperDay added a comment. Part of my concern was that the reversion removed a unit test, which effectively regressed a different fix, I'm not comfortable with that. I think we can resolve the original problem with the following fix. diff --git a/clang/lib/Format/UnwrappedLineFormatter.c

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. @rjmccall any chance we get your feedback on this please? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D152804: [clang-format] Propose a new solution to - Fix overlapping replacements before PPDirectives

MyDeveloperDay created this revision. MyDeveloperDay added a reviewer: owenpan. MyDeveloperDay added projects: clang, clang-format. Herald added a project: All. Herald added reviewers: rymiel, HazardyKnusperkeks. MyDeveloperDay requested review of this revision. Propose a new solution to D151954:

[PATCH] D152804: [clang-format] Propose a new solution to - Fix overlapping replacements before PPDirectives

MyDeveloperDay added a comment. ok this still doesn't resolve the original https://github.com/llvm/llvm-project/issues/62892 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152804/new/ https://reviews.llvm.org/D152804 __

[PATCH] D152802: [clang-tidy] Fix crash in `modernize-use-default-member-init`

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:274-276 + if (isa(InitType)) { +return; + } instead of ignoring array types, better would be just not provide FixItHints for them, so WRN woul

[PATCH] D152804: [clang-format] Propose a new solution to - Fix overlapping replacements before PPDirectives

MyDeveloperDay added a comment. but it does seem to resolve https://github.com/llvm/llvm-project/issues/63170 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152804/new/ https://reviews.llvm.org/D152804 __

[PATCH] D152796: [clang][Sema] Fix diagnostic message for unused constant varialbe templates

tbaeder accepted this revision. tbaeder added a comment. This revision is now accepted and ready to land. Makes sense. LGTM provided precommit CI comes back green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152796/new/ https://reviews.llvm.org/D

[PATCH] D152801: [include-cleaner] Don't apply PreferredHeader hings for standard headers.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152801/new/ https://reviews.llvm.org/D152801

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

aaron.ballman added a comment. This should also come with a release note for the changes. Comment at: clang/lib/AST/ASTContext.cpp:11998-11999 + return CC_X86StdCall; +else if (T.getArch() == llvm::Triple::m68k) + return CC_M68kRTD; + } --

[PATCH] D142823: Intrinsics: Allow tablegen to mark parameters with dereferenceable

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142823/new/ https://reviews.llvm.org/D142823 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

aaron.ballman added a comment. I think precommit CI may have found a relevant failure: TEST 'Clang :: Index/IBOutletCollection.m' FAILED Script: -- : 'RUN: at line 8'; c:\ws\w5\llvm-project\premerge-checks\build\bin\c-index-test.exe -cursor-a

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch includes a test that fails without th

[clang-tools-extra] 5cdb906 - [clangd] Unify printing policy for type hints

Author: Younan Zhang Date: 2023-06-13T21:31:10+08:00 New Revision: 5cdb906f1e4093600f99aab8660e1536514a57e8 URL: https://github.com/llvm/llvm-project/commit/5cdb906f1e4093600f99aab8660e1536514a57e8 DIFF: https://github.com/llvm/llvm-project/commit/5cdb906f1e4093600f99aab8660e1536514a57e8.diff

[PATCH] D152520: [clangd] Unify printing policy for type hints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5cdb906f1e40: [clangd] Unify printing policy for type hints (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152802: [clang-tidy] Fix crash in `modernize-use-default-member-init`

AMS21 updated this revision to Diff 530892. AMS21 marked an inline comment as done. AMS21 added a comment. Still issue a warning just no fixit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152802/new/ https://reviews.llvm.org/D152802 Files: clan

[PATCH] D152802: [clang-tidy] Fix crash in `modernize-use-default-member-init`

PiotrZSL added a comment. Maybe we should still support arrays in some way Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152802/new/ https://reviews.llvm.org/D152802 ___ cfe-commits mailing list cfe-

[PATCH] D152802: [clang-tidy] Fix crash in `modernize-use-default-member-init`

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:273 + + const bool ValueInit = isa(InitExpression); + const bool CanAssign = ```const bool ValueInit = isa(InitExpression) && !isa(InitType);``` T

[PATCH] D149548: [IR] Update to use new shufflevector semantics

ManuelJBrito added a comment. In D149548#4413762 , @uweigand wrote: > In D149548#4413639 , @nlopes wrote: > >> If a vector is fully initialized with `insertvector` (i.e., one operation >> per index), then the val

[PATCH] D152632: [Clang] Add warnings for CWG2521

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:411 + "identifier '%0' preceded by space(s) in the literal operator declaration " + "is deprecated">, InGroup, DefaultIgnore; def warn_reserved_module_name : Warning<

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman added a comment. In D150226#4408980 , @dblaikie wrote: > In D150226#4408563 , @erichkeane > wrote: > >> In D150226#4408381 , >> @aaron.ballman wrote: >> >>

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25716 + "int param2,\n" + "int param3);\n", + Style); H-G-Hristov wrote: > Does this work with `BAS_BlockIndent`? I don't see any re

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

vaibhav.y added inline comments. Comment at: clang/lib/Tooling/SarifLinker.cpp:21 + +namespace llvm::sarif_linker { +[[noreturn]] void ReportErrorAndExit(llvm::errc error_code, StringRef Message) { Is this for link diagnostics reported as SARIF? Repository:

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

aaron.ballman added a comment. Aside from the suggested changes, the Clang bits LGTM Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7636-7639 +static void handleWebAssemblyAsyncAttr(Sema &S, Decl *D, const ParsedAttr &AL) { + D->addAttr(::new (S.Context) WebAssemblyAsyncAttr(S.C

[PATCH] D152525: [clang][Diagnostics] Don't expand label fixit to the next line

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D152525#4408902 , @tbaeder wrote: > As far as the fixit goes, I guess the previous version was better, since it > didn't leave an emp

[PATCH] D150358: [clang][Interp] Remove args from called functions in more cases

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/functions.cpp:262 +namespace CallWithArgs { + /// This used to call problems during checkPotentialConstantExpression() runs. + constexpr void g(int a) {} tbaeder wrote: > aaron.ballman wrot

[PATCH] D152818: [Clang] Fix assertion when pragma FENV_ACCESS is used with a throw function.

zahiraam created this revision. zahiraam added a reviewer: aaron.ballman. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. See issue here: https://godbolt.org/z/aYME8KTdn Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D15281

[PATCH] D152818: [Clang] Fix assertion when pragma FENV_ACCESS is used with a throw function.

tbaeder added a comment. Has the test case been obfuscated on purpose? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152818/new/ https://reviews.llvm.org/D152818 ___ cfe-commits mailing list cfe-commits@

[PATCH] D152818: [Clang] Fix assertion when pragma FENV_ACCESS is used with a throw function.

zahiraam added a comment. In D152818#4417644 , @tbaeder wrote: > Has the test case been obfuscated on purpose? This is a smaller reproducible from creduce. Didn't know if it would be OK to have an include in a LIT test? Repository: rG LLVM Github Mo

[PATCH] D152818: [Clang] Fix assertion when pragma FENV_ACCESS is used with a throw function.

tbaeder added a comment. In D152818#4417649 , @zahiraam wrote: > In D152818#4417644 , @tbaeder wrote: > >> Has the test case been obfuscated on purpose? > > This is a smaller reproducible from creduce. Didn't know

[PATCH] D152707: [clang][Sema] Provide source range to several Wunused warnings

hazohelet updated this revision to Diff 530912. hazohelet added a comment. Address review comments - Move the test header to `Inputs` folder - Remove explicit constructor call of `SourceRange` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152707/new/ https://reviews.llvm.org/D152707 F

[PATCH] D152707: [clang][Sema] Provide source range to several Wunused warnings

hazohelet marked 3 inline comments as done. hazohelet added a comment. Thanks for the review. I'll check the pre-commit CI result before landing this just in case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152707/new/ https://reviews.llvm.org/D152707 ___

[PATCH] D152818: [Clang] Fix assertion when pragma FENV_ACCESS is used with a throw function.

zahiraam added a comment. In D152818#4417683 , @tbaeder wrote: > In D152818#4417649 , @zahiraam > wrote: > >> In D152818#4417644 , @tbaeder >> wrote: >> >>> Has the test

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2052-2106 +void clang::CodeGen::mergeDefaultFunctionDefinitionAttributes( +llvm::Function &F, const CodeGenOptions CodeGenOpts, +const LangOptions &LangOpts, const TargetOptions &TargetOpts, +bool

[PATCH] D149000: Update with warning message for comparison to NULL pointer

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:14726 - if (UnaryOperator *UO = dyn_cast(E)) { + if (UnaryOperator *UO = dyn_cast(E->IgnoreParenCasts())) { if (UO->getOpcode() != UO_AddrOf) aaron.ballman wrote: > The iss

  1   2   3   >