[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk created this revision. Prabhuk added a reviewer: phosek. Herald added a subscriber: pengfei. Herald added a project: All. Prabhuk requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Adding support for X86_64 UEFI target to begin

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 528609. Prabhuk added a comment. Update commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Targets

[PATCH] D131594: Add Clang UEFI target to support "x86_64-unknown-uefi" triple

Prabhuk updated this revision to Diff 528610. Prabhuk added a comment. Updated commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131594/new/ https://reviews.llvm.org/D131594 Files: llvm/include/llvm/MC/TargetRegistry.h llvm/include

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

efriedma added a comment. The following also crashes, with no MaterializeTemporaryExpr involved. struct X { short n; char c; }; struct Y { _Atomic(X) a; _Atomic(int) b; }; constexpr X x{}; int z; Y y = { x, z }; Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan created this revision. Herald added a subscriber: yaxunl. Herald added a project: All. scchan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Add the --whole-archive flag when linking HIP programs to instruct lld to go throug

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers added a comment. In D151587#4397446 , @efriedma wrote: > The following also crashes, with no MaterializeTemporaryExpr involved. > > struct X { > short n; > char c; > }; > > struct Y { > _Atomic(X) a; > _Atomic(int)

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

efriedma added a comment. > Yeah, but not because of this patch; that's a pre-existing issue. Right; the _Atomic crashes are a pre-existing issue unrelated to MaterializeTemporaryExpr, so you shouldn't be trying to solve it by messing with HasAnyMaterializeTemporaryExpr. Repository: rG LLVM

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

arsenm added inline comments. Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:371 +// the offsets. +uint64_t DstAlign = (i == 0) ? 4 : 8; +Builder.CreateMemCpy(PtrToStore, /*DstAlign*/ Align(DstAlign), Args[i], I don't follow th

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

arsenm added inline comments. Comment at: clang/test/CodeGenHIP/printf_nonhostcall.cpp:137 + +__device__ float f1 = 3.14f; +__device__ double f2 = 2.71828; Also half Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

arsenm added a comment. Also should be noted in the release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150427/new/ https://reviews.llvm.org/D150427 ___ cfe-commits mailing list cfe-commits@lists

[clang] 949830a - [OpenMP] Mark kernels as mustprogress

Author: Johannes Doerfert Date: 2023-06-05T16:33:53-07:00 New Revision: 949830af4246688899657ac1974041804a143ae1 URL: https://github.com/llvm/llvm-project/commit/949830af4246688899657ac1974041804a143ae1 DIFF: https://github.com/llvm/llvm-project/commit/949830af4246688899657ac1974041804a143ae1.d

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

craig.topper added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:224 +RVV_VECTOR_TYPE_INT("__rvv_uint8m4x2_t", RvvUint8m4x2, RvvUint8m4x2Ty, 32, 8, 2, false) +//===- Int16 tuple types --===// +RVV_VECTOR_T

[PATCH] D152071: [3/11][Clang][RISCV] Expand all variants for unit stride segment load

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1533 + + if (NoPassthru) // Push poison into passthru +Operands.append(NF, llvm::PoisonValue::get(ElementVectorType)); `if` should use curly braces if the `else

[PATCH] D152073: [5/11][Clang][RISCV] Expand all variants for unit stride fault-first segment load

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1645 + + if (NoPassthru) // Push poison into passthru +Operands.append(NF, llvm::PoisonValue::get(ElementVectorType)); Curly braces Repository: rG LLVM Gith

[PATCH] D152074: [6/11][Clang][RISCV] Expand all variants for strided segment load

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1719 + + if (NoPassthru) // Push poison into passthru +Operands.append(NF, llvm::PoisonValue::get(ElementVectorType)); Curly braces Repository: rG LLVM Gith

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

tstellar added inline comments. Herald added a subscriber: Enna1. Herald added a project: All. Comment at: compiler-rt/cmake/base-config-ix.cmake:126 +set(COMPILER_RT_INSTALL_DATA_DIR "${default_install_path}" CACHE PATH + "Path where compiler-rt data files should be installed."

[PATCH] D127040: [InstrProf][WIP] Implement boolean counters in coverage

gulfem abandoned this revision. gulfem added a comment. Herald added a subscriber: wlei. Created a duplicate review by mistake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127040/new/ https://reviews.llvm.org/D127040

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering

MaskRay added a comment. `KCFI_CHECK` lowering has some complexity to allocate a temporary register. This needs to following the calling convention which can be modified by many compiler options and function attributes. I wonder whether we can move the if-condition part of the expanded code se

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

MaskRay added inline comments. Comment at: llvm/test/CodeGen/X86/movdir64b-inline-asm-x86_64.ll:1 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 2 +; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+movdir64b | FileCheck

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

tbaeder added a comment. In D152090#4395827 , @MaskRay wrote: > `def fcaret_diagnostics_max_lines` in `Options.td` has the `NoDriverOption` > flag. Move it to other places with `BooleainFFlag` should work. > Then in `Clang.cpp` you can just write `Args.

[PATCH] D152083: [clang] Warning for uninitialized elements in fixed-size arrays

shafik added a reviewer: clang-language-wg. shafik added a comment. Adding reviewer for more visibility CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152083/new/ https://reviews.llvm.org/D152083 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n created this revision. goldstein.w.n added reviewers: nikic, fhahn, jdoerfert, arsenm. Herald added subscribers: libc-commits, luke, pmatos, asb, ormris, StephenFan, frasercrmck, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMo

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n added a comment. llvm-test-suite passes with this patch enabled. But note: **There currently some failing clang tests**. Most of them look benign (just need to propagate a few attributes to a few thousand places), but I was hoping there is a way to auto-regenerate them before going

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

sivachandra added inline comments. Comment at: libc/CMakeLists.txt:22 +# that clang will use it. +if(LLVM_LIBC_MAKE_DISCOVERABLE) + if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR) Likely out of date and not required for this patch? Repository: rG LLVM Github Monorepo

[clang] c336c98 - [C++20] [Modules] [Serialization] Don't write comments to BMI for C++20 Named Modules

Author: Chuanqi Xu Date: 2023-06-06T13:05:17+08:00 New Revision: c336c983bcd9bf3559c76ed4eb6b25fbafbcd361 URL: https://github.com/llvm/llvm-project/commit/c336c983bcd9bf3559c76ed4eb6b25fbafbcd361 DIFF: https://github.com/llvm/llvm-project/commit/c336c983bcd9bf3559c76ed4eb6b25fbafbcd361.diff LO

[clang] 9571a28 - [WebAssembly] Add tests ensuring rotates persist

Author: Paulo Matos Date: 2023-06-06T07:48:35+02:00 New Revision: 9571a28ee4e801a7796569d62fe037fc22cd65a4 URL: https://github.com/llvm/llvm-project/commit/9571a28ee4e801a7796569d62fe037fc22cd65a4 DIFF: https://github.com/llvm/llvm-project/commit/9571a28ee4e801a7796569d62fe037fc22cd65a4.diff L

[PATCH] D152126: [WebAssembly] Add tests ensuring rotates persist

This revision was automatically updated to reflect the committed changes. Closed by commit rG9571a28ee4e8: [WebAssembly] Add tests ensuring rotates persist (authored by pmatos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152126/new/ https://revie

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

protze.joachim reopened this revision. protze.joachim added a comment. This revision is now accepted and ready to land. The review should not be closed, since the patch was reverted and should be recommitted (this time possibly with a reference to this review?) Repository: rG LLVM Github Mono

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice added a comment. In D141907#4398196 , @protze.joachim wrote: > The review should not be closed, since the patch was reverted and should be > recommitted (this time possibly with a reference to this review?) This is recommitted as 0beffb854

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n updated this revision to Diff 528707. goldstein.w.n marked an inline comment as done. goldstein.w.n added a comment. Remove libc changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152226/new/ https://reviews.llvm.org/D152226 Files

[PATCH] D131594: [Triple] Add triple for UEFI

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. Can you also provide description for this change (this should be the same you'll use for the Git message). Comment at: llvm/include/llvm/MC/TargetRegistry.h:568 + asser

<    1   2   3